Tuesday, 2019-03-05

*** michaelbeaver has quit IRC00:00
*** aaronsheffield has quit IRC00:25
*** sreejithp has quit IRC00:37
*** cheng1 has joined #airshipit01:21
*** sthussey has quit IRC01:22
*** Nishant__ has quit IRC01:40
*** debugger_io has quit IRC02:30
*** hemanth_n has joined #airshipit02:46
*** hemanth_n has quit IRC02:57
*** roman_g has quit IRC03:17
*** openstackgerrit has joined #airshipit03:36
openstackgerritDan Crank proposed openstack/airship-deckhand master: Log client-id in UCP API endpoints  https://review.openstack.org/63406803:36
*** cheng1 has quit IRC03:37
openstackgerritjacky06 proposed openstack/airship-armada master: Update json module to jsonutils  https://review.openstack.org/64047604:43
openstackgerritjacky06 proposed openstack/airship-armada master: Update json module to jsonutils  https://review.openstack.org/64047604:48
openstackgerritjacky06 proposed openstack/airship-armada master: Update json module to jsonutils  https://review.openstack.org/64047604:58
*** cheng1 has joined #airshipit05:31
*** jhesketh has quit IRC05:47
*** jhesketh has joined #airshipit05:48
*** cheng1 has quit IRC05:48
*** cheng1 has joined #airshipit05:58
*** c06 has joined #airshipit06:03
c06hi all.. is there any cleanup scripts available for airskiff...!06:04
openstackgerritSmruti Soumitra Khuntia proposed openstack/airship-armada master: End user logging for audit traceabilty  https://review.openstack.org/63812406:09
*** dims has quit IRC06:24
*** juhak has quit IRC06:31
*** juhak_ has joined #airshipit06:31
*** juhak_ is now known as juhak06:37
*** cheng1 has quit IRC06:40
c06hi, i tried this patch for airship in a bottle: https://review.openstack.org/#/c/615387/06:48
c06facing error while running airship-in-a-bottle.sh script06:51
c06http://paste.openstack.org/show/747269/ - any suggestions.?06:51
*** cheng1 has joined #airshipit07:06
*** c06 has quit IRC07:35
*** c06 has joined #airshipit07:44
*** pkaralis has quit IRC07:51
*** roman_g has joined #airshipit08:43
*** mbeierl has quit IRC09:02
*** mbeierl has joined #airshipit09:04
*** c06 has quit IRC09:19
*** roman_g has quit IRC09:20
*** lemko has joined #airshipit09:23
*** cheng1 has quit IRC09:34
*** roman_g has joined #airshipit09:41
*** cheng1 has joined #airshipit09:49
*** cheng1 has quit IRC10:08
*** hemanth_n has joined #airshipit10:29
*** dimitris_ has quit IRC10:58
*** dims has joined #airshipit11:01
*** hemanth_n has quit IRC11:15
*** dimitris_ has joined #airshipit11:23
*** jesusaur has quit IRC13:22
*** jesusaur has joined #airshipit13:25
*** hemanth_n has joined #airshipit13:31
mattmceuenHey c06:  I'll take a look today :)13:44
mattmceuenHere's the agenda for our team meeting coming up in 15min folks! https://etherpad.openstack.org/p/airship-meeting-2019-03-0513:44
*** levmorgan has joined #airshipit13:51
*** aaronsheffield has joined #airshipit13:55
*** Nishant_ has joined #airshipit13:57
*** sgrasley has joined #airshipit13:59
evrardjpo/13:59
*** juhak has quit IRC13:59
mattmceuen#startmeeting airship14:00
openstackMeeting started Tue Mar  5 14:00:10 2019 UTC and is due to finish in 60 minutes.  The chair is mattmceuen. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: airship)"14:00
mattmceuen#topic Rollcall14:00
openstackThe meeting name has been set to 'airship'14:00
mattmceuenGM / GE everyone!14:00
*** openstack changes topic to "Rollcall (Meeting topic: airship)"14:00
Nishant_o/14:00
*** juhak has joined #airshipit14:00
dwaltGM! o/14:00
mattmceuenAgenda for today: https://etherpad.openstack.org/p/airship-meeting-2019-03-0514:00
hemanth_nGM14:00
mattmceuenWe'll wait a few for folks to trickle in; please add anything you'd like to discuss to the agenda14:00
seaneagano/14:00
georgki14:01
georgkhi14:01
levmorgano/14:01
mattmceuenOk - let's get started14:02
mattmceuen#topic Armada Helm test timeout value change14:02
*** openstack changes topic to "Armada Helm test timeout value change (Meeting topic: airship)"14:02
mattmceuendwalt: all yours14:02
dwaltThanks mattmceuen14:02
dwaltJust a heads up: there is an Armada change that went in recently that changes the behavior of how Helm tests are run in Armada14:03
dwalt#link14:03
dwalt#link https://review.openstack.org/61858514:03
dwaltwoops :)14:03
dwaltThe timeout value for Helm tests is no longer derived from the wait timeout value and is a separate test.timeout key14:04
mattmceuendwalt, wasn't it also the case that the helm test was actually being included in the overall wait timeout?14:04
mattmceuenSuch that, if timeout was 5 min, and the actual deploy took 5 min, there wouldn't be any time left for test?14:05
*** sthussey has joined #airshipit14:05
dwaltmattmceuen: yes, it was derived from the remaining time left from the wait timeout after an upgrade was completed14:05
dwaltexactly14:05
dwaltNow that the new default timeout value is 300, some longer tests may unexpectedly timeout. For instance, we saw this happen with Neutron in the Airship-Seaworthy site14:06
dwalt#link https://review.openstack.org/63946214:06
dwaltThat's all, just more of a heads up14:06
mattmceuenGot it - good one, thanks for bring it up14:06
dwaltsure thing14:07
mattmceuen#topic Airship comminity IRC meeting time change14:07
*** openstack changes topic to "Airship comminity IRC meeting time change (Meeting topic: airship)"14:07
mattmceuenHey roman_g do we have you in yet perchance?14:07
mattmceuenI have a handle on this one anyway: https://review.openstack.org/#/c/640359/14:07
mattmceuenAs discussed here & on the mailing list, there's a majority desire to shift the meeting time a bit - this formally moves it 2 hours later on the same days as now14:08
mattmceuenSo heads up -- today's meeting may be the last one at the current time!  However, I think it just depends on when the PS merges.14:08
mattmceuenSo reviews on that PS are appreciated - thanks14:09
mattmceuen#topic Onboarding Environments / Dev Documentation14:10
*** openstack changes topic to "Onboarding Environments / Dev Documentation (Meeting topic: airship)"14:10
mattmceuenHey sthussey, you were out last week but we talked about something you added to the agenda - looping back:14:10
mattmceuenThere is a variety of different tooling/yamls for standing up an Airship enviroment14:10
mattmceuenI put in a storyboard item to try to align those a bit based on our discussion last week: https://storyboard.openstack.org/#!/story/200512314:11
mattmceuenThe storyboard description got a little verbose -- if anyone would like to discuss / nitpick it, I can copy/paste into a spec; but I'll only do that if needed or helpful :D14:11
mattmceuenIn any case - feedback welcome from all on that (as is implementation!)14:12
mattmceuenI think we brought up last week dwalt that you're working on aligning airskiff site to the treasuremap globals -- how's that going?14:12
sthusseySo we still want to maintain the automation for standing up 3 different flavors of dev/testing environments?14:13
mattmceuenso dwalt just lost his connection, he may not be answering the question :)14:13
*** dustinspecker has joined #airshipit14:13
mattmceuenthe spec calls out aligning aiab single node tooling to the aiab multinode tooling to remove one of those14:13
mattmceuennot spec, storyboard14:13
mattmceuenas single node is a special case of multinode14:14
sthusseyOkay, I misread that as only the demo environment14:14
*** stingerpk has joined #airshipit14:14
roman_go/14:15
roman_gHi. Just came. Sorry for being late.14:15
mattmceuenI think (anyone correct me if wrong) that the single-node demo env is really the one that gets a lot of use, and the single-node dev site doesn't get a lot of use (since devs often use multinode aiab) - anyone know otherwise?14:15
mattmceueno/ roman_g! no worries14:15
sthusseyCan we note in there deleting the dev-minimal then?14:16
mattmceuensure thing - if anyone has any concerns between now & impl time, please bring it up; if so we can just migrate the dev-minimal site at the same time14:17
*** michael-beaver has joined #airshipit14:17
dwaltSorry for the connection issues. The patch to align Airskiff with the UCP global documents in Treasuremap is here: https://review.openstack.org/63521814:17
mattmceuenAs part of the discussion last week, also came up that it would be valuable to have some additional developer-centric documentation.  I created a story / tasks for that as well:  https://storyboard.openstack.org/#!/story/200512214:18
dwaltI haven't been able to revisit it this week, but it's very close. There are just a few secret substitutions that need to be cleaned up14:18
mattmceuenawesome - ty dwalt14:18
*** stingerpk has quit IRC14:19
mattmceuenInterested on feedback on the content of the dev doc story.  Especially from folks who need it the most!  If it doesn't answer the right questions etc, please let me know and we can add more tasks14:19
roman_gWill have a look14:19
levmorganWill do.14:20
mattmceuenI made the tasks a bit granular because different authors have experience in different areas.  If anyone would like to author some content that is not called out as a task yet, though, please go ahead and add a task14:20
mattmceuenI plan to tackle some of the content and would appreciate as much collaboration as possible :D14:20
mattmceuenthanks guys14:20
mattmceuen#topic     Divingbell gates are broken in upstream14:20
*** openstack changes topic to "Divingbell gates are broken in upstream (Meeting topic: airship)"14:20
mattmceuenroman_g:  I know you discussed this a bit with the OSH folks; where does this sit now - still trying to root cause the specific issue, right?14:21
roman_gRoman is here. Slowly progressing.14:21
mattmceuenIs there anything other folks can do to assist you in that?14:22
roman_gI know that behavior changes between 2.11.0 and 2.12.0.rc114:22
roman_gWel,, may be a quick Zoom session, to show me how i can quickly test different versions of helm/tiller14:22
*** lemko has quit IRC14:22
roman_gWould appreciate a lot.14:22
sthusseyis this the issue of how maps are handled?14:23
roman_gyes.14:23
roman_gpatch from cheng1 did not help14:23
sthusseyMight also want to check with what version of Go tiller was built. May be a underlying change in Go's behavior14:24
roman_gI can compile/recompile helm/tiller very fast, but I did not get to a point where I could easily use newly compiled helm/tiller for the chart renderring14:24
roman_gI have go version go1.10.4 linux/amd6414:25
mattmceuenroman_g I'll set up a troubleshooting session & send out on the ML.  seaneagan if you can join I think that would be helpful too.   I'm thinking it'll probably be Thurs or Fri14:25
roman_glatest on Ubuntu 16.04.5 LTS14:25
mattmceuen#action mattmceuen: set up troubleshooting session for helm mapping issue impacting divingbell gates14:26
roman_gthank you, mattmceuen14:26
mattmceuenthank you roman_g for tackling this14:26
roman_gsthussey: good advice. Thanks.14:26
mattmceuen#topic Deckhand & Shipyard - OpenSUSE builds14:27
*** openstack changes topic to "Deckhand & Shipyard - OpenSUSE builds (Meeting topic: airship)"14:27
roman_garunkant:14:27
roman_gjames is not here14:27
roman_gArun, are you here?14:27
mattmceuenThis one may be a good one for the ML :)14:28
roman_g#action followup in ML for OpenSUSE builds of Airship14:29
mattmceuenty roman_g14:29
mattmceuen#topic Minimirror: move spec and review on the fly patches14:29
*** openstack changes topic to "Minimirror: move spec and review on the fly patches (Meeting topic: airship)"14:29
dwaltthanks for adding this again roman_g14:29
roman_g:D14:30
roman_gwould you have a look?14:30
dwaltThere has been some new developments in this area, as it looks like we will soon be able to publish a mini-mirror image from openstack-helm-images. That means we can integrate this in AIAB and seaworthy14:30
dwaltas for the spec, I still need to remove that. Thanks for the reminder14:31
mattmceuenoh, that's awesome14:31
roman_git's piblished in openstack-helm-images already, as far as I can see14:31
dwaltthank you evrardjp as well for your work in osh-images so that this can be possible!14:31
mattmceuen+114:31
roman_gbut there are some patches from Alex Volkov, which are non-merged, and will not be merged (because minimirror is in different repo now). For example, there is a good manual for the minimirrod.14:32
roman_g*or14:32
mattmceuenyeah, those will need to be abandoned or reworked against the new repo as appropriate14:33
mattmceuenwill take a look roman_g14:33
roman_gthank you14:33
mattmceuenalrighty, moving on:14:33
mattmceuen#topic Airship talks accepted into the Denver Summit14:33
*** openstack changes topic to "Airship talks accepted into the Denver Summit (Meeting topic: airship)"14:33
roman_g#link https://review.openstack.org/#/q/minimirror - some of them seem to be good to be integrated into the openstack-helm-images repo14:33
mattmceuenoops14:33
roman_gsorry14:34
mattmceuenmy bad roman_g, pulled the trigger too early14:34
mattmceuenhttps://etherpad.openstack.org/p/airship-meeting-2019-03-0514:34
mattmceuen^ that has an extract of the Airship-related sessions at the upcoming summit, FYI14:35
mattmceuenSome of them by us in the meeting, some by other folks, and some are cross-project presentations that have tagged #airship14:35
mattmceuenBut good to see a lot of content and variety planned for the open infra summit around Airship!14:35
*** c06 has joined #airshipit14:36
mattmceuenAny other thoughts on this topic?14:36
roman_gCongrats to winners :)14:37
roman_gLook forward to watch the recording on youtube.14:37
mattmceuen+114:37
mattmceuen#topic Ironic driver spec14:37
*** openstack changes topic to "Ironic driver spec (Meeting topic: airship)"14:37
mattmceuenwe have hemanth_n here - pas-ha I believe we wanted to sync up a bit or have some Q&A on the Ironic spec, right?14:38
mattmceuenI think we may be missing pas-ha here today14:39
mattmceuenI believe the open questions were around Ironic functions not being exactly 1:1 with MaaS functions, and how to bridge the gap from a plugin perspective14:41
mattmceuenThere is discussion around that in the Spec, but I'm not certain what the outstanding questions are that needed to be discussed here14:41
hemanth_nI will take a look at spec and will try to answer them ... and probably will reach to pas-ha14:42
mattmceuenthanks hemanth_n - that would be awesome14:42
mattmceuenSpec, for anyone who's interested:  https://review.openstack.org/#/c/613358/14:42
sthusseyIt looks like someone from Dell also has some input on that spec14:42
mattmceuenyep Prakash14:43
mattmceuenHe has been providing feedback on the spec as well and has expressed interest in collaborating on Ironic - Airship integration14:44
mattmceuenWe'll continue this on the spec review proper - thx guys14:44
mattmceuen#topioc 1.0 release14:45
mattmceuenThis is your hogepodge!14:45
hogepodgeI added the topic14:45
roman_g#topic 1.0 release14:45
mattmceuensigh14:45
mattmceuen#topic 1.0 release14:45
hogepodgeWe're looking at scheduling for the time between now and the summit, and the 1.0 release is supposed to happen in there14:45
*** openstack changes topic to "1.0 release (Meeting topic: airship)"14:45
hogepodgeI wanted to check on the status of the release, how it might bump up against the OpenStack Stein release, and other issues around it.14:46
hogepodgeWe also have things like Foundation Newsletter and demos and work on the bare metal whitepaper that will also need to take the release into accound.14:47
hogepodgeaccount.14:47
mattmceuenGood add.  Time is definitely flying between now and the summit.14:47
mattmceuenInitial Ironic integration is the biggest thing we wanted to have in place for the 1.0 release14:48
mattmceuenSo that is one we need to stay on top of14:48
hogepodgeWill Ironic cause it to slip past the summit?14:49
mattmceuenRemains to be seen, I am optimistic.  We don't need the integration to be 100% full-featured for the release IMO, but we did express it as something we should have in place.14:51
mattmceuenI will sync up with pas-ha and get a better answer14:51
mattmceuenAnother area we wanted to firm up a bit is the "ease of use" around YAMLs.  I think we've come a long way since Berlin in a couple areas:14:52
mattmceuen1) the treasuremap repo has continued to mature, and we're publishing monthly releases that can be used as a basis for deployments14:53
mattmceuen2) The airship-spyglass project can be used to generate site configurations from xls files14:53
hogepodgeok14:54
hogepodgeI think the preference would be to have a release with fewer features than a late release, mostly because of the summit platform14:55
hogepodgebut we can't have a broken release14:55
mattmceuenDocumentation was an additional area to firm up for 1.0.  The dev documentation brought up earlier is a good foundation for that.14:55
hogepodgewe can talk more at the community meeting this Friday14:55
hogepodge(which is another topic to slip in under the wire)14:55
mattmceuenRoger hogepodge - will proceed with that in mind14:55
mattmceuen:D14:55
mattmceuengo for it14:55
hogepodgeThere's and OSF/Airship community meeting this Friday. I'll send details to the mailing list.14:56
hogepodgeFor now we'll start weekly, but will move to biweekly if it makes more sense.14:56
mattmceuenSounds like a plan - ty for setting that up14:56
*** c06 has quit IRC14:56
mattmceuen#topic Roundtable14:57
*** openstack changes topic to "Roundtable (Meeting topic: airship)"14:57
mattmceuenJust a couple mins left --14:57
mattmceuen    https://review.openstack.org/#/c/615387/14:57
mattmceuen    https://review.openstack.org/#/c/635507/ - openstack/airship-treasuremap - Add cache for results of requests to quay.io in Updater tool14:57
mattmceuen^ if we can get some review on these that would be awesome14:57
mattmceuenAnything else to discuss today?14:57
levmorganWell14:58
levmorganDoes anyone know about the coverage threshold in Zuul being raised to 86 percent (at least for Pegleg?)14:58
sthusseyI saw a PS that did that14:59
dwalt#link https://review.openstack.org/634593/14:59
Nishant_I see it 86 percent here - https://github.com/openstack/airship-pegleg/blob/master/tox.ini#L6315:00
levmorganThanks!15:00
mattmceuenLooks like tests were added as part of that change so that is good :)15:01
dwalt+115:01
mattmceuenthanks lamt!15:01
sthusseyhttps://review.openstack.org/#/c/634593/6/tox.ini15:01
mattmceuenwe our out of time!15:01
mattmceuen*are15:01
mattmceuen#endmeeting15:01
*** openstack changes topic to "airshipit.org || General Review Dashboard: https://review.openstack.org/#/q/project:%255Eopenstack/airship.*+status:open,n,z"15:01
openstackMeeting ended Tue Mar  5 15:01:48 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/airship/2019/airship.2019-03-05-14.00.html15:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/airship/2019/airship.2019-03-05-14.00.txt15:01
openstackLog:            http://eavesdrop.openstack.org/meetings/airship/2019/airship.2019-03-05-14.00.log.html15:01
mattmceuenThanks everybody!15:01
roman_gThanks.15:02
*** michael-beaver has quit IRC15:07
*** juhak has quit IRC15:14
*** juhak has joined #airshipit15:15
*** juhak has quit IRC15:16
*** juhak has joined #airshipit15:16
*** levmorgan has quit IRC15:27
*** michael-beaver has joined #airshipit15:27
*** stingerpk has joined #airshipit15:28
*** openstackgerrit has quit IRC15:28
*** stingerpk has quit IRC15:30
*** juhak has quit IRC15:55
*** juhak_ has joined #airshipit15:56
*** michael-beaver has quit IRC15:56
*** openstackgerrit has joined #airshipit16:00
openstackgerritAlexander Hughes proposed openstack/airship-pegleg master: Update tox coverage to 85 percent  https://review.openstack.org/64106316:00
*** michael-beaver has joined #airshipit16:18
*** michael-beaver has quit IRC16:22
*** michaelbeaver has joined #airshipit16:22
*** michaelbeaver has quit IRC16:26
*** hemanth_n has quit IRC16:27
*** hemanth_n has joined #airshipit16:29
*** hemanth_n has quit IRC16:31
openstackgerritMerged openstack/airship-pegleg master: Update tox coverage to 85 percent  https://review.openstack.org/64106316:35
roman_ghttps://review.openstack.org/#/c/635507/ - please, review. openstack/airship-treasuremap - Add cache for results of requests to quay.io in Updater tool16:41
roman_gThank you.16:41
roman_ghttps://review.openstack.org/#/c/640359/ - please, review. openstack-infra/irc-meetings - Update Airship meeting time, change chair16:43
roman_gEspecially cores. Thank you.16:43
openstackgerritLev Morgan proposed openstack/airship-pegleg master: Search all scopes for catalogs  https://review.openstack.org/63482116:48
*** roman_g has quit IRC16:51
*** roman_g has joined #airshipit16:53
-openstackstatus- NOTICE: Gerrit is being restarted for a configuration change, it will be briefly offline.17:09
*** michael-beaver has joined #airshipit17:10
*** peyunco has joined #airshipit17:50
roman_gOu, yeah. I got to understanding on how to quickly test helm/tiller.18:11
openstackgerritNishant Kumar proposed openstack/airship-maas master: Support for password rotation  https://review.openstack.org/63498118:46
openstackgerritNishant Kumar proposed openstack/airship-shipyard master: [Database] Shipyard DB changes  https://review.openstack.org/63614718:49
openstackgerritAlexander Hughes proposed openstack/airship-pegleg master: PKI Cert generation and check updates  https://review.openstack.org/63941418:51
openstackgerritMerged openstack/airship-deckhand master: Use helm-toolkit for DB initialization  https://review.openstack.org/63921819:21
openstackgerritMerged openstack/airship-drydock master: Use helm toolkit for DB initialization  https://review.openstack.org/63462520:46
*** georgk has quit IRC20:52
*** georgk has joined #airshipit20:53
roman_gcommit which broke overrides functionality (used in divingbell, used in openstack-helm-infra, used in gates) is this one: https://github.com/helm/helm/commit/de5a6a931bfc47c1fa3a72db038002cbf68315ff21:01
roman_gchangeing github.com/imdario/mergo from v0.3.5 back to 6633656539c1639d9d78127b7d47c622b5d7b6dc in glide.yaml and rebuilding latest helm does not make anything better (sugestion from Pete Birley)21:02
roman_gI'm tracking issue here https://storyboard.openstack.org/#!/story/2005095 (there are some basic scripts to get to tests).21:04
openstackgerritMichael Beaver proposed openstack/airship-armada master: Enable Armada to acquire Tiller IP from config file  https://review.openstack.org/63323721:11
openstackgerritMichael Beaver proposed openstack/airship-armada master: Move Tiller into Armada pod  https://review.openstack.org/63278821:11
openstackgerritMichael Beaver proposed openstack/airship-armada master: Normalize assignment of Tiller defaults  https://review.openstack.org/64112621:11
openstackgerritAnthony Bellino proposed openstack/airship-divingbell master: [WIP] Initial commit for Ansible framework  https://review.openstack.org/63918621:11
openstackgerritAnthony Bellino proposed openstack/airship-divingbell master: [WIP] Initial Ansible Daemonset  https://review.openstack.org/64053921:18
*** peyunco has quit IRC21:36
dustinspeckerHello. Using Shipyard's test_site action. When the helm test fails, Armada logs have the fact it failed, but Shipyard reports the step armada_test_releases as success. It used to report this as fail/error. Is this an intentional change?21:55
openstackgerritRahul Khiyani proposed openstack/airship-maas master: UCP:readOnlyRootFilesystem: true for Maas chart  https://review.openstack.org/63920022:00
openstackgerritRahul Khiyani proposed openstack/airship-promenade master: UCP:readOnlyRootFilesystem: true for promenade, etcd and K8s charts  https://review.openstack.org/63918922:01
openstackgerritRahul Khiyani proposed openstack/airship-shipyard master: UCP:readOnlyRootFilesystem: true for shipyard and airflow charts  https://review.openstack.org/63919522:01
openstackgerritRahul Khiyani proposed openstack/airship-drydock master: UCP:readOnlyRootFilesystem: true for drydock chart  https://review.openstack.org/63919722:02
dustinspeckerIs it possible this could happen when using a newer Shipyard CLI (docker image) than the shipyard-api pod and armada-api pods? Not sure if there was an update between the two that I'm just out of sync on.22:04
dwaltdustinspecker: I believe it should always be a success. That step is supposed to report whether or not Helm tests were executed successfully, not whether the tests passed22:20
dwaltIt also logs the direct Armada API response, which *should* match the correct result of the test22:21
dustinspeckerInteresting. I thought at one point if the test pod existed, it came back as fail/error. Now it's coming back as success.22:21
dustinspeckerThank you!22:21
dwaltdo you have the exact output you can share?22:22
dwaltHere is the code in question: https://github.com/openstack/airship-shipyard/blob/master/src/bin/shipyard_airflow/shipyard_airflow/plugins/armada_test_releases.py#L6722:22
dustinspeckerHmm. Thank you. I really thought it came back with fail/error. Thanks for info - I'm probably misremembering.22:23
dwaltdustinspecker: np! It's definitely possible it could report a failure, but I think that's indicative of a failure to run the test rather than a failure of the test itself22:24
dustinspeckerYeah, in this case it was because the test pod existed, so helm status says failed. Just surprised Shipyard/Armada came back as success. Was convinced it didn't do that.22:25
Nishant_does the shipyard step - `armada_build` also shows as success, ideally in this case it should say failed22:33
Nishant_dustinspecker: ^^22:35
dustinspeckernishant: There is not an `armada_build` step. Every step is success.22:37
dustinspeckernishant: this is for test_site action. This is an action to trigger a helm test on demand.22:38
*** dustinspecker has quit IRC22:44
Nishant_dustinspecker: ok I have not had a chance to playaround with the `test_site` action but during a `deploy_site` or an `update_site` a similar issue does result in the  `armada_build` step marked as failed which runs the test.22:51
Nishant_ok i did run a `test_site` action and I see same behaviour as seen by dustinspecker  i.e. some tests fail stating the test already exist but the step indicates to be a success and as dwalt mentioned it is the expected behaviour.23:07
dwaltNISHANT_: thanks for looking into that!23:07
openstackgerritDmitrii Kabanov proposed openstack/airship-maas master: Add package repositories  https://review.openstack.org/63684823:10
Nishant_dwalt: Do you think it can make more sense to mark the step as a failure or add another step which would validate if all the tests passed or not? If not passed then step should be marked as failed causing the `test_site` action to fail?23:12
dwaltThat would probably be more in-line with the behavior of armada_build23:12
dwaltMaybe we can propose a storyboard item for this? The test_site action is due for changes soon since Armada will be changing its testing interface23:13
Nishant_ok sounds like it can be a point of discussion23:16
*** sgrasley has quit IRC23:32
*** michael-beaver has quit IRC23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!