openstackgerrit | Jagan Mohan Kavva proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 01:16 |
---|---|---|
openstackgerrit | Ahmad Mahmoudi proposed airship/pegleg master: WIP: Updating airshp clients https://review.opendev.org/712825 | 02:23 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add single source of Seletors https://review.opendev.org/712802 | 02:57 |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: [WIP] Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 03:25 |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: [WIP] Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 03:28 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options https://review.opendev.org/710180 | 03:32 |
openstackgerrit | Ahmad Mahmoudi proposed airship/pegleg master: WIP: Updating pegleg airship clients https://review.opendev.org/712825 | 03:32 |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #airshipit | 05:36 | |
openstackgerrit | Ahmad Mahmoudi proposed airship/pegleg master: WIP: Updating pegleg airship clients https://review.opendev.org/712825 | 05:56 |
openstackgerrit | Ahmad Mahmoudi proposed airship/pegleg master: WIP: Updating pegleg airship clients https://review.opendev.org/712825 | 06:33 |
*** dpawlik has quit IRC | 06:37 | |
*** dpawlik has joined #airshipit | 06:55 | |
*** roman_g has quit IRC | 07:01 | |
*** dpawlik has quit IRC | 07:10 | |
*** dpawlik has joined #airshipit | 07:16 | |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Fix go get for airshipctl module https://review.opendev.org/710400 | 07:25 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Show isogen container logs if debug is enabled https://review.opendev.org/706594 | 08:53 |
openstackgerrit | Vamsi Savaram proposed airship/airshipctl master: [#89] Gather container logs in check pipeline https://review.opendev.org/712555 | 09:07 |
*** rezroo has quit IRC | 09:28 | |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 09:30 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Implement document rendering sub-command https://review.opendev.org/698658 | 12:04 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Add cert-manager https://review.opendev.org/712932 | 12:20 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add cert-manager https://review.opendev.org/712932 | 12:25 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Update kubeadm https://review.opendev.org/712935 | 12:30 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Update baremetal-provider https://review.opendev.org/712936 | 12:33 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#91] refactor secrets as top level command https://review.opendev.org/711684 | 13:00 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP]Enable Logs Output in Zuul for Deployment Scripts https://review.opendev.org/709763 | 13:17 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add cert-manager https://review.opendev.org/712932 | 13:20 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Update kubeadm https://review.opendev.org/712935 | 13:20 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Update baremetal-provider https://review.opendev.org/712936 | 13:20 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Update cluster-api https://review.opendev.org/712944 | 13:20 |
openstackgerrit | Jagan Mohan Kavva proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 13:20 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: Upgrade Cluster API from v1alpha2 to v1alpha3 https://review.opendev.org/712944 | 13:38 |
airshipbot | <ih616h> This issue implies that we want to use the `argo` CLI as a subclient to `airshipctl`: https://github.com/airshipit/airshipctl/issues/96 | 13:40 |
airshipbot | <ih616h> I thought we decided to abandon the idea of subclients? | 13:40 |
*** rezroo has joined #airshipit | 13:55 | |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP]Enable Logs Output in Zuul for Deployment Scripts https://review.opendev.org/709763 | 14:01 |
airshipbot | <alexander.hughes> that was my understanding as well, and the basis for removing kubectl subcommand | 14:07 |
openstackgerrit | Jagan Mohan Kavva proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 14:17 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: Use 16GB flavor for gate job https://review.opendev.org/712160 | 14:23 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: Add Bare Metal Operator resources https://review.opendev.org/706533 | 14:23 |
openstackgerrit | Merged airship/airshipctl master: Fix go get for airshipctl module https://review.opendev.org/710400 | 14:32 |
airshipbot | <sirajudeen.yasin> I just rebased this commit https://review.opendev.org/#/c/710180/ and zuul gave -1 due to coverage tests, so i assume it is because of few other recent commits as well.. can we create a issue to add more test cases wherever possible, I will try to work on it | 14:33 |
airshipbot | <ih616h> That sounds like a good idea to me. There is currently this PS, which is also working toward an increase in coverage, so if you write any tests, just make sure you aren't duplicating any work: https://review.opendev.org/#/c/712503/ | 14:35 |
airshipbot | <sirajudeen.yasin> thanks Ian, the above commit should help a lot.. I will add if i can any more test cases | 14:37 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: WIP: Add the dynamic kubernetes client https://review.opendev.org/712963 | 14:40 |
airshipbot | <alexander.hughes> so 712503 is two sided | 14:49 |
airshipbot | <alexander.hughes> it increases test coverage to 84%, but also increases minimum threshold to 82% | 14:49 |
airshipbot | <alexander.hughes> for the sake of being nimble we may want to keep threshold at 80% as we get new features in. I'm an advocate for testing where we can, but some of the stuff being implemented is framework for future commands and until the future work is done it can't really be tested | 14:50 |
airshipbot | <sirajudeen.yasin> i just ran coverage with that PS 712503 and got 82.2% while 82 is threshold.. might be due to other recent merges | 14:50 |
airshipbot | <sirajudeen.yasin> i agree with alex | 14:52 |
airshipbot | <dwalt> I've observed low quality tests getting added to codebases where the threshold artificially increases. It can become a nightmare | 14:52 |
airshipbot | <sb464f> Hey Team GM. I am deploying one site internally and running into this issue. ```TASK [/tmp/airshipctl/roles/airshipctl-build-ephemeral-iso : build ephemeral node iso] ********************************************************************************************************************** fatal: [primary]: FAILED! => {"changed": true, "cmd": ["airshipctl", "bootstrap", "isogen"], "delta": "0:00:00.029178", "end | 14:54 |
airshipbot | "msg": "non-zero return code", "rc": 1, "start": "2020-03-12 17:48:42.127352", "stderr": "", "stderr_lines": [], "stdout": "Current context manifest must have primary repository set", "stdout_lines": ["Current context manifest must have primary repository set"]} ``` I passed the variables that role is using, am I missing any other variabkes..? | 14:54 |
airshipbot | <ih616h> Can't help, but it might be worth mentioning that I'm also experiencing the above issue | 14:55 |
airshipbot | <alexander.hughes> `TASK [airshipctl-build-ephemeral-iso : build ephemeral node iso] *******************************************************` `fatal: [primary]: FAILED! => {"changed": true, "cmd": ["airshipctl", "bootstrap", "isogen"], "delta": "0:01:24.958713", "end": "2020-03-12 18:27:09.299779", "msg": "non-zero return code", "rc": 1, "start": "2020-03-12 18:25:44.341066", "stderr": "", "stderr_lines": [], "stdout | 14:56 |
airshipbot | builder container\n2020/03/12 18:27:09 Creating cloud-init for ephemeral K8s\nDocument filtered by selector \"~G_~V_Secret\" found no documents", "stdout_lines": ["2020/03/12 18:25:44 Creating ISO builder container", "2020/03/12 18:27:09 Creating cloud-init for ephemeral K8s", "Document filtered by selector \"~G_~V_Secret\" found no documents"]}` | 14:56 |
airshipbot | <alexander.hughes> I got that one last night, there's ongoing work to address | 14:56 |
airshipbot | <dwalt> Could you share your airship config? | 14:56 |
airshipbot | <alexander.hughes> Kostiantyn mentioned it | 14:56 |
airshipbot | <dwalt> @sb464f | 14:56 |
airshipbot | <sb464f> 1 sec | 14:56 |
airshipbot | <sb464f> that has IP's of our site let me edit and send. | 14:57 |
airshipbot | <sb464f> ```sudo cat /home/sai/.airship/config apiVersion: airshipit.org/v1alpha1 clusters: dummycluster: cluster-type: ephemeral: bootstrap-info: dummy_bootstrap_config cluster-kubeconf: dummycluster_ephemeral contexts: dummy_cluster: context-kubeconf: dummy_cluster manifest: dummy_manifest current-context: dummy_cluster kind: Config manifests: dummy_manifest: primary-repo | 14:58 |
airshipbot | primary: checkout: branch: "master" force: false remote-ref: "" tag: "" url: http://HOST_IP:8095/nc-airship-2.0/ ## this is temporary hack, as soon as we use `document pull` command in gate process ## this will subpath will be airshipctl/manifests/site/test-bootstrap, as airshipctl ## will be primary repository sub-path: "manifests/site/test-bo | 14:58 |
airshipbot | /home/sai/nc-airship-2.0/ modules-config: bootstrapInfo: dummy_bootstrap_config: container: volume: /data/srv/iso:/config image: kkalynovskyi/image-builder:latest containerRuntime: docker remoteDirect: remoteType: redfish isoUrl: http://HOST_IP:8095/debian-custom.iso builder: userDataFileName: user-data networkConfigFileName: network-conf | 14:58 |
airshipbot | output-metadata.yaml users:``` | 14:58 |
airshipbot | <dwalt> That looks like the correct usage to me. I will have to take a look at the config module. | 14:59 |
*** segorov has quit IRC | 15:05 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add single source of Seletors https://review.opendev.org/712802 | 15:12 |
airshipbot | <kk6740> this issue is being addressed right now with this commit, @dwalt @alexander.hughes | 15:13 |
airshipbot | <kk6740> https://review.opendev.org/712802 | 15:13 |
airshipbot | <kk6740> and there is one more that needs to be done, since we have new ways to get network data | 15:14 |
airshipbot | <kk6740> but no network data | 15:14 |
airshipbot | <dwalt> @kk6740 that's great! That won't fix @sb464f's problem though, right? | 15:15 |
openstackgerrit | Ahmad Mahmoudi proposed airship/pegleg master: Bionic pegleg airship clients https://review.opendev.org/712825 | 15:16 |
airshipbot | <kk6740> @dwalt it will | 15:16 |
airshipbot | <kk6740> this line https://review.opendev.org/#/c/712802/5/roles/airshipctl-test-configs/templates/airshipconfig.j2 | 15:16 |
airshipbot | <sb464f> i think it does https://review.opendev.org/#/c/712802/5/roles/airshipctl-test-configs/templates/airshipconfig.j2 | 15:16 |
airshipbot | <kk6740> because of gates not working, these issues keep popping up, | 15:16 |
airshipbot | <dwalt> oh, I flew past that one. Awesome. :slightly_smiling_face: | 15:17 |
airshipbot | <kk6740> if those servers would stop giving node_failures, we could enable to job to be voting | 15:17 |
airshipbot | <kk6740> and we could see | 15:17 |
airshipbot | <ih616h> why don't we put that single line change into its own PS? It doesn't seem related to the rest of the change and would be uch easier to merge | 15:17 |
openstackgerrit | Francis Bacon Yi proposed airship/airshipctl master: Increase config pkg test coverage https://review.opendev.org/712503 | 15:23 |
airshipbot | <kk6740> anyone knows if there was any proposals how are we going to handle network userdata in new form of json-string ? | 15:25 |
airshipbot | <alexander.hughes> there was json/yaml discussion during yaml sig. was network userdata part of that? | 15:26 |
airshipbot | <kk6740> i think we had only general acknowledgment of the issue | 15:26 |
airshipbot | <alexander.hughes> ok, I hadn't heard any proposals. I think it would have been during that call if we had one | 15:27 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP]Enable Logs Output in Zuul for Deployment Scripts https://review.opendev.org/709763 | 15:29 |
airshipbot | <kk6740> please review https://review.opendev.org/#/c/712802/ | 15:39 |
airshipbot | <alexander.hughes> minor refactor needs review https://review.opendev.org/#/c/711684/ to satisfy https://github.com/airshipit/airshipctl/issues/91 | 15:41 |
airshipbot | <ih616h> @alexander.hughes I thought we were holding off on that PS? | 15:42 |
airshipbot | <alexander.hughes> Rodolfo assigned it as critical for beta since our last talk | 15:42 |
airshipbot | <ih616h> right. good enough for me | 15:44 |
airshipbot | <alexander.hughes> sorry I misspoke, it's labeled as 2.0. but if it was still in design shouldn't be assigned imo | 15:44 |
*** mattmceuen has joined #airshipit | 15:44 | |
airshipbot | <ih616h> I'm also not sure if priority/critical makes sense on a 2.0 item... | 15:45 |
airshipbot | <alexander.hughes> the way I rationalize it is this way: there are milestones we are working towards, within each milestone certain issues are more critical than others. so when we get to beta->2.0 push this would be one of the first items that needs to be worked compared to a 2.0 medium or low | 15:46 |
airshipbot | <alexander.hughes> but if it's done in advance saves us the effort later. didn't intentionally pick this out as a future item just saw an opportunity for improvement and proposed/opened issue and it happened to be assigned to 2.0 | 15:47 |
airshipbot | <kk6740> Does anyone have any information how make the push to quay finally work https://github.com/airshipit/images ? | 15:53 |
airshipbot | <kk6740> or whoever has the key, maybe can push manually for now | 15:53 |
airshipbot | <mattmceuen> qwqqqq | 15:56 |
airshipbot | <kk6740> iddqd? | 15:56 |
airshipbot | <ih616h> @mattmceuen having trouble with vim? | 15:57 |
airshipbot | <mattmceuen> sigh | 15:57 |
airshipbot | <mattmceuen> Kostiantyn - what's the automated image push blocked on? | 15:58 |
airshipbot | <kk6740> only if i knew, i really miss the part with the pushes of images | 15:59 |
airshipbot | <mattmceuen> I will take a look today | 15:59 |
airshipbot | <kk6740> maybe someone who took care of pushing airshipctl image can fix this one as well, since bascially it is the same issue | 15:59 |
airshipbot | <mattmceuen> If I can's sort it out I will push manually | 15:59 |
airshipbot | <mattmceuen> *can't | 15:59 |
airshipbot | <kk6740> thanks | 16:01 |
airshipbot | <dwalt> airshipctl also has issues. What is the specific problem on airship/images? | 16:04 |
openstackgerrit | Merged airship/airshipctl master: [#91] refactor secrets as top level command https://review.opendev.org/711684 | 16:05 |
airshipbot | <ih616h> I'm seeing test failures on master... :slightly_frowning_face: | 16:12 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Fix a bug in pkg/k8s/client.TestNewClient https://review.opendev.org/713011 | 16:19 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Resolve gather-libvirt-logs role failures https://review.opendev.org/713012 | 16:20 |
airshipbot | <ih616h> Seems to only happen locally. 713011 should fix it | 16:22 |
airshipbot | <ih616h> happens because the unit test was using a real config file | 16:22 |
airshipbot | <an310y> Hi guys, could you please merge https://review.opendev.org/#/c/709638/ https://review.opendev.org/#/c/680495/? They are already have +2 and Verified+1 | 16:23 |
airshipbot | <an310y> And review/merge https://review.opendev.org/#/c/710480/ and https://review.opendev.org/#/c/711566/. These all CR’s related to virtual OSH deployment. | 16:25 |
openstackgerrit | Merged airship/pegleg master: Bionic pegleg airship clients https://review.opendev.org/712825 | 16:26 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Resolve gather-libvirt-logs role failures https://review.opendev.org/713012 | 16:28 |
*** openstackgerrit has quit IRC | 16:31 | |
*** mfuller has joined #airshipit | 16:34 | |
airshipbot | <dwalt> @an310y those changes LGTM at a glance. I'd feel more comfortable approving if they had additional, positive reviews from others working on the seaworthy-virt efforts. | 16:35 |
*** openstackgerrit has joined #airshipit | 16:35 | |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: [#106] Add docker install role https://review.opendev.org/711540 | 16:35 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 16:45 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP]Enable Logs Output in Zuul for Deployment Scripts https://review.opendev.org/709763 | 16:46 |
airshipbot | <an310y> @sreejith.punnapuzha @sirajudeen.yasin could you please review above CR’s ? | 16:57 |
airshipbot | <sreejith.punnapuzha> Sure | 16:58 |
airshipbot | <an310y> and two from previous msg as well. Thanks | 16:59 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Fix a bug in pkg/k8s/client.TestNewClient https://review.opendev.org/713011 | 17:05 |
airshipbot | <an310y> @dwalt I’ve asked @sirajudeen.yasin and @sreejith.punnapuzha, they have reviewed it a couple of minutes ago. Please let me know if I need to involve someone else. | 17:10 |
airshipbot | <dwalt> That's great. Thanks @an310y:) | 17:11 |
airshipbot | <mattmceuen> Quick poll, folks. We have possession of the airshipit.slack.com workspace, if we want to use it. If we wanted to use it, I'd send an invitation to everyone in airshipproject.slack.com, communicate it out, and close airshipproject down a couple days later or some such. | 17:14 |
airshipbot | <mattmceuen> Slightly better branding, however I don't have a huge preference -- what do y'all think? | 17:15 |
airshipbot | <dwalt> That feels like a more permanent home to me. As if we belong there | 17:21 |
airshipbot | <mattmceuen> @alexander.hughes we haven't sent out the newsletter with instructions yet, right? :slightly_smiling_face: | 17:21 |
airshipbot | <alexander.hughes> I have not. Waiting on final confirmation on slack link sounded like Monday | 17:22 |
airshipbot | <alexander.hughes> I like consistent branding. Airshipit has my vote | 17:23 |
airshipbot | <ih616h> +1 airshipit | 17:23 |
airshipbot | <mattmceuen> cool. ok, will try to get mirroring sorted out there by eod; we have a permanent home identified for the bot as well | 17:23 |
airshipbot | <dwalt> Maybe more people will have pictures in the permanent workspace ;) | 17:24 |
airshipbot | <sreejith.punnapuzha> +1 airshipit | 17:25 |
*** dpawlik has quit IRC | 17:30 | |
airshipbot | <kk6740> this is my real picture | 17:33 |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #airshipit | 17:36 | |
openstackgerrit | Francis Bacon Yi proposed airship/airshipctl master: Increase config pkg test coverage https://review.opendev.org/712503 | 17:52 |
airshipbot | <mattmceuen> invitations sent | 18:04 |
openstackgerrit | Francis Bacon Yi proposed airship/airshipctl master: Increase config pkg test coverage https://review.opendev.org/712503 | 18:29 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 18:35 |
airshipbot | <alexander.hughes> only see a general channel in the other workspace. is that what we're using? | 18:43 |
*** airshipbot1 has joined #airshipit | 18:46 | |
airshipbot | <ih616h> there's a airshipit | 18:48 |
*** jbryce is now known as airship-irc-bot | 19:03 | |
*** airship-irc-bot is now known as jbryce | 19:07 | |
airshipbot | <alexander.hughes> ah seems the new workspace you need to add the airshipit channel manually. this one came included for me | 19:10 |
airshipbot | <mattmceuen> Ah, that's probably some setting I can tweak after I'm an admin | 19:11 |
airshipbot | <alexander.hughes> yeah small QOL change. just throwing it out as a disclaimer for everyone making swap now | 19:11 |
airshipbot | <kk6740> can we please merge this small item https://review.opendev.org/#/c/713012/2 | 19:11 |
jbryce | mattmceuen: you should be an owner now in the new workspace | 19:11 |
*** airshipbot1 has quit IRC | 19:12 | |
airshipbot | <mattmceuen> o/ jbryce - thanks!f | 19:12 |
*** airship-irc-bot1 has joined #airshipit | 19:13 | |
*** airship-irc-bot1 has quit IRC | 19:13 | |
*** airship-irc-bot has joined #airshipit | 19:13 | |
airship-irc-bot | <jbryce> test from airshipit workspace | 19:15 |
jbryce | test from irc for new airshipit workspace | 19:15 |
airship-irc-bot | <kk6740> please review this, very small, and needed fix for logs on zuul :slightly_smiling_face: https://review.opendev.org/#/c/713012/2 | 19:15 |
*** airship-irc-bot has quit IRC | 19:16 | |
*** airship-irc-bot has joined #airshipit | 19:17 | |
jbryce | the bot between the #airship channels is up and running and persists across restarts, etc | 19:18 |
mattmceuen | that's fantastic | 19:18 |
mattmceuen | thanks for your help jbryce - I'll plan to ax the old workspace early next week after folks have a chance to move over | 19:19 |
jbryce | sounds good | 19:20 |
airship-irc-bot | <alexander.hughes> nit: can we get airship logo on airshipit workspace please | 19:28 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP]Enable Logs Output in Zuul for Deployment Scripts https://review.opendev.org/709763 | 19:37 |
airship-irc-bot | <kk6740> please take a look at these commits: https://review.opendev.org/#/c/712802/5 https://review.opendev.org/#/c/712829/4 They depend on each other and togather fix gate | 19:37 |
airship-irc-bot | <kk6740> very important in a process of moving further in gating process | 19:38 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: WIP: Add the dynamic kubernetes client https://review.opendev.org/712963 | 19:42 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Fix a failure when running unit tests locally https://review.opendev.org/713011 | 19:45 |
openstackgerrit | Merged airship/airshipctl master: Resolve gather-libvirt-logs role failures https://review.opendev.org/713012 | 20:09 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Provide Redfish feedback in RemoteDirect errors https://review.opendev.org/711992 | 20:45 |
openstackgerrit | Merged airship/treasuremap master: Fixing the typo in authoring_and_deployment https://review.opendev.org/711780 | 21:00 |
openstackgerrit | Merged airship/images master: Example network-config network_data.json format https://review.opendev.org/712667 | 21:01 |
openstackgerrit | diwakar thyagaraj proposed airship/porthole master: Enable container resource limits https://review.opendev.org/709267 | 21:02 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: [#106] Add docker install role https://review.opendev.org/711540 | 21:22 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: [#106] Add docker install role https://review.opendev.org/711540 | 21:23 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add single source of Seletors https://review.opendev.org/712802 | 21:31 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 21:32 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Fix network and cloud data for ephemeral host https://review.opendev.org/712829 | 21:32 |
mattmceuen | The reason the airhip/images images are failing to be published: | 21:42 |
mattmceuen | Failed to import the required Python library (Docker SDK for Python: docker (Python >= 2.7) or docker-py (Python 2.6)) on ubuntu-bionic-rax-iad-0015106816's Python /usr/bin/python3. Please read module documentation and install in the appropriate location, for example via `pip install docker` or `pip install docker-py` (Python 2.6). The error was: No module named 'requests' | 21:43 |
mattmceuen | Does that ring a bell for anyone who has fixed it from other contexts? I think Dmitry may have cloned those image handling jobs from somewhere, but not sure where | 21:44 |
mattmceuen | https://www.irccloud.com/pastebin/FVoNcP5P/ | 21:44 |
airshipbot | <dwalt> I think that's because Ansible's `docker_login` module requires the `docker-py` package | 21:44 |
airshipbot | <dwalt> I'll grab the relevant airshipctl implementation | 21:45 |
airship-irc-bot | <andrew.walters> Here is what we use in airshipctl: https://github.com/airshipit/airshipctl/blob/master/roles/airshipctl-publish-images/tasks/main.yaml#L13 | 21:46 |
airship-irc-bot | <andrew.walters> Do you have a job link to confirm that's when it's happening? | 21:47 |
mattmceuen | ah, thanks - I'll take a look at that | 21:48 |
mattmceuen | Here's the output I'm looking at: https://zuul.opendev.org/t/openstack/build/3349d65040bf46f1ac4a3da226794f39 | 21:48 |
airship-irc-bot | <dwalt> Cool. I think that will fix it | 21:49 |
mattmceuen | sorry dwalt, I'm missing something -- I don't see airshipctl installing `docker-py` package either, how does it get there? | 21:50 |
airship-irc-bot | <dwalt> The error in the build link says `The error was: No module named 'requests'` | 21:50 |
airship-irc-bot | <dwalt> `python3-requests` is what needs to be installed, I think | 21:51 |
airship-irc-bot | <kk6740> please review when u have time: https://review.opendev.org/#/c/712802/5 https://review.opendev.org/#/c/712829/4 | 21:51 |
mattmceuen | aha - yep I think you're right dwalt, thanks | 21:52 |
airship-irc-bot | <dwalt> On closer inspection, those packages are for 2.6 :P `for example via `pip install docker` or `pip install docker-py` (Python 2.6).` | 21:53 |
airship-irc-bot | <dwalt> no problem! | 21:53 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: [#106] Add docker install role https://review.opendev.org/711540 | 21:55 |
openstackgerrit | Matt McEuen proposed airship/images master: Fix publish job https://review.opendev.org/713066 | 21:56 |
airship-irc-bot | <dwalt> Is the proper command to fix goimports `goimports -local "opendev.org/airship/airshipctl" -w .`? | 21:58 |
*** mfuller has quit IRC | 23:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!