| *** openstack has joined #airshipit | 09:52 | |
| *** ChanServ sets mode: +o openstack | 09:52 | |
| *** dpawlik has quit IRC | 09:55 | |
| *** dpawlik has joined #airshipit | 09:56 | |
| openstackgerrit | Merged airship/airshipctl master: Update Kustomize integration to api/v0.3.1 https://review.opendev.org/715571 | 11:36 |
|---|---|---|
| openstackgerrit | Vladislav Kuzmin proposed airship/airshipctl master: Make Redfish parameters configurable https://review.opendev.org/717812 | 12:20 |
| openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Introduce document plugin subcommand https://review.opendev.org/719931 | 12:23 |
| openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Introduce document plugin subcommand https://review.opendev.org/719931 | 12:54 |
| *** SRao has joined #airshipit | 12:59 | |
| mattmceuen | GM all! Here's the agenda for our IRC meeting in about an hour: https://etherpad.opendev.org/p/airship-meeting-2020-04-14 | 13:07 |
| mattmceuen | No topics yet, so feel free to add any topics or patchset review requests to it | 13:08 |
| *** diga_ has joined #airshipit | 13:23 | |
| *** diga_ has quit IRC | 13:24 | |
| *** diga has joined #airshipit | 13:25 | |
| openstackgerrit | Vamsi Savaram proposed airship/airshipctl master: Gather container logs in check pipeline https://review.opendev.org/717522 | 13:36 |
| *** evgenyl has quit IRC | 13:50 | |
| *** vdrok has quit IRC | 13:50 | |
| *** vdrok has joined #airshipit | 13:51 | |
| *** evgenyl has joined #airshipit | 13:51 | |
| *** ak3216 has joined #airshipit | 13:52 | |
| *** ak3216 is now known as andrewkarandjeff | 13:56 | |
| *** raymonddeng has joined #airshipit | 13:57 | |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Add Dell Redfish client https://review.opendev.org/717123 | 13:59 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Add iDRAC ephemeral boot media support https://review.opendev.org/713711 | 13:59 |
| *** ab2434_ has joined #airshipit | 13:59 | |
| *** alhatneha has joined #airshipit | 13:59 | |
| mattmceuen | #startmeeting airship | 14:00 |
| openstack | Meeting started Tue Apr 14 14:00:12 2020 UTC and is due to finish in 60 minutes. The chair is mattmceuen. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: airship)" | 14:00 | |
| openstack | The meeting name has been set to 'airship' | 14:00 |
| mattmceuen | #topic Rollcall | 14:00 |
| *** openstack changes topic to "Rollcall (Meeting topic: airship)" | 14:00 | |
| mattmceuen | Good morning/evening everyone! | 14:00 |
| airship-irc-bot1 | <alexander.hughes> o/ | 14:00 |
| mattmceuen | Here's our agenda for today: https://etherpad.opendev.org/p/airship-meeting-2020-04-14 | 14:00 |
| airship-irc-bot1 | <dwalt> o/ | 14:00 |
| airship-irc-bot1 | <ih616h> o/ | 14:00 |
| ian-pittwood | o/ | 14:01 |
| mattmceuen | please add any review requests or topics that you'd like to discuss today | 14:01 |
| *** roman_g has joined #airshipit | 14:01 | |
| airship-irc-bot1 | <mb551n> o/ | 14:01 |
| *** jtwill98 has joined #airshipit | 14:02 | |
| mattmceuen | we have folks coming in from the design call now; we'll give it just another minute... | 14:02 |
| *** raymonddeng has left #airshipit | 14:02 | |
| *** raymonddeng has joined #airshipit | 14:02 | |
| mattmceuen | Alrighty: | 14:03 |
| mattmceuen | #topic Announcements | 14:03 |
| *** openstack changes topic to "Announcements (Meeting topic: airship)" | 14:03 | |
| mattmceuen | alexander.hughes, take it away sir | 14:03 |
| airship-irc-bot1 | <alexander.hughes> hello all! it's been a fantastic 10 months since Airship introduced it's formal governance paving the way to be confirmed as a top level OSF project | 14:04 |
| airship-irc-bot1 | <alexander.hughes> in June, 2 months from now we'll hold our next committee election, for the TC. the responsibilities and eligibility is defined here: https://opendev.org/airship/governance#user-content-technical-committee | 14:04 |
| *** mfixtex has joined #airshipit | 14:04 | |
| airship-irc-bot1 | <alexander.hughes> something to ponder for those looking to get more involved in the community | 14:05 |
| mattmceuen | the year has flown by quickly :) | 14:05 |
| mattmceuen | the working committee elections will follow quickly about a month later as well | 14:05 |
| mattmceuen | Thanks for the heads up alex. Any other thoughts/questions on this one? | 14:06 |
| mattmceuen | #topic irc-slack bot | 14:06 |
| *** openstack changes topic to "irc-slack bot (Meeting topic: airship)" | 14:06 | |
| mattmceuen | portdirect: thanks for bringing this one up, go for it | 14:06 |
| portdirect | nothing really to add | 14:06 |
| portdirect | not sure who is looking after the bot | 14:07 |
| mattmceuen | bots taking over the world | 14:07 |
| openstackgerrit | Ian Howell proposed airship/airshipctl master: Uplift go-git https://review.opendev.org/717856 | 14:07 |
| mattmceuen | jbryce fyi: this is how bot-copied text looks if you're using an alternate client to slack -- https://usercontent.irccloud-cdn.com/file/5LDRdjJK/Screen%20Shot%202020-04-14%20at%208.11.21%20AM.png | 14:07 |
| mattmceuen | not sure if there's a config for that or not | 14:07 |
| mattmceuen | Reminder for folks using slack in general: your underlying slack ID (typically your email address minus the domain) is reported in IRC by the bot | 14:08 |
| mattmceuen | This is changeable if you choose to change it (deep in some config item in slack). E.g. michael beaver, you're showing up as the vanilla: | 14:09 |
| mattmceuen | <mb551n> o/ | 14:09 |
| mattmceuen | Anyway, if anyone has experience with resolving the bot-identity problem in other slack/irc clients, please let portdirect and us know | 14:10 |
| mattmceuen | moving on in the meantime: | 14:11 |
| mattmceuen | #topic Airship blog calls for content | 14:12 |
| *** openstack changes topic to "Airship blog calls for content (Meeting topic: airship)" | 14:12 | |
| mattmceuen | go for it alexander.hughes | 14:12 |
| airship-irc-bot1 | <alexander.hughes> thanks Matt, we mentioned this during the virtual meetup that we've got content on the airship blog here https://www.airshipit.org/blog/ but we've had a lot of great work lately from contributors that deserve to be showcased. things that have gone above and beyond plain documentation where we've had demos of new features being worked and detailed discussions on challenges and victories with these features | 14:13 |
| airship-irc-bot1 | <alexander.hughes> if you'd like to showcase any of that work, it's as simple as contributing in markdown to https://github.com/AirshipWeb/airship-website/ if you'd like to get involved or need direction don't hesitate to reach out to me | 14:13 |
| *** mfixtex is now known as mikefix | 14:14 | |
| mattmceuen | sharing accomplishments and informing the community - sounds like a win win | 14:14 |
| mattmceuen | Please chew on that and come up with some good things to share, team. We can also enlist extra hands to help with writing tasks; step 1 is "good ideas" | 14:15 |
| mattmceuen | Next topic: | 14:16 |
| mattmceuen | #topic Consolidate common Zuul jobs into aiship-zuul-xxx repo | 14:16 |
| *** openstack changes topic to "Consolidate common Zuul jobs into aiship-zuul-xxx repo (Meeting topic: airship)" | 14:16 | |
| mattmceuen | Not sure who added this one? | 14:16 |
| roman_g | Hi. It's mine. | 14:16 |
| mattmceuen | ah thanks roman_g, go for it | 14:16 |
| roman_g | Just wanted to ask if it's a good time to move common jobs to separate repo and then import them from it. | 14:16 |
| roman_g | Opinions? | 14:17 |
| mattmceuen | Good question. We'd started out developing common jobs in airshipctl directly to allow them to stabilize, but originally with the plan to move them back to the zuul job repo when stable | 14:17 |
| *** uzumaki has joined #airshipit | 14:17 | |
| roman_g | We have this zuul-airship-something repo already | 14:17 |
| mattmceuen | roman_g just curious, are you aware of other projects that could reuse any jobs yet? | 14:18 |
| roman_g | Airship/images and airship/airshipctl may be. | 14:18 |
| roman_g | Are we interested in improving airship 1.x jobs/gates? | 14:19 |
| airship-irc-bot1 | <aodinokov> due to the fact that images is a separate directory, we can't test images :slightly_smiling_face: | 14:19 |
| airship-irc-bot1 | <aodinokov> in the job :slightly_smiling_face: | 14:19 |
| roman_g | http://opendev.org/airship/images - I meant this repo | 14:20 |
| mattmceuen | I think we're always interested in proving airship 1.x jobs/gates. I'm not sure whether it makes sense to share jobs between A1 and A2, but I think putting common A1 jobs in the zuul repo might be good if we see a good opportunity for it | 14:20 |
| airship-irc-bot1 | <dwalt> I think we recently tried to do this with one of the jobs, but we ended up breaking the developer gate scripts, which are not aware of the ways we can indicate role dependencies in Zuul. I think we need to develop an offline dependency strategy first. | 14:20 |
| uzumaki | +1 | 14:20 |
| airship-irc-bot1 | <dwalt> With that being said, there are a lot of opportunities to reuse our roles, especially in Airship 1 | 14:21 |
| mattmceuen | dwalt: putting you on the spot, are you able to walk us through the dependency issue we ran into? | 14:21 |
| airship-irc-bot1 | <dwalt> Anything that does publishing or mirroring would be great to have consistent across all ~20 repos or however many variations we maintain now | 14:21 |
| airship-irc-bot1 | <dwalt> I'll do my best :slightly_smiling_face: | 14:21 |
| roman_g | thanks. publishin | 14:22 |
| roman_g | Publishing and mirroring seem to be good targets | 14:22 |
| mattmceuen | yeah, agree roman_g | 14:23 |
| roman_g | What is good is that is independent of devs, and would not break anything. | 14:23 |
| roman_g | *it is independent of devs | 14:23 |
| airship-irc-bot1 | <dwalt> We moved a docker role out of airship/airshipctl and into airship/images recently. I can't remember which one. When we did so, we "imported" that role into airshipctl using a feature in zuul that allows you to use roles in other repositories. This left our upstream CI green, but downstream, the dependent roles were missing, as zuul was not there to pull them in. Our downstream strategy could be as simple as cloning airship/images. | 14:23 |
| uzumaki | re the mirroring topic, there's also a script in the zuul.d I suppose, which does Github comment posting, using Gerrit events. This is the single script in the scripts directory. I noticed it's not being used anymore, and has been succeeded by the airshipbot. Do we still want to keep that? And the Zuul job it corresponds to? | 14:24 |
| airship-irc-bot1 | <dwalt> +1 to testing with those jobs first roman_g uzumaki | 14:24 |
| airship-irc-bot1 | <dwalt> s/downstream/locally | 14:25 |
| roman_g | OK, thanks. I'm done. | 14:25 |
| roman_g | Downstream/locally - devs should ideally install and use ansible ;) | 14:26 |
| uzumaki | <dwalt> agree on testing those first | 14:26 |
| roman_g | This way we wold not duplicate work, by writing 1) ansible code and then 2) bash code. | 14:26 |
| airship-irc-bot1 | <dwalt> The scripts I'm referring to are just dev friendly wrappers on the ansible: https://github.com/airshipit/airshipctl/tree/master/tools/gate | 14:27 |
| mattmceuen | one approach is to put content into shell scripts, and then invoke those within zuul via shallow ansible playbooks | 14:27 |
| mattmceuen | portdirect did some great things with that approach in openstack-helm | 14:27 |
| mattmceuen | And asking developers to run bash locally on their laptops seems more reasonable to me than ansible, but that's only an opinion | 14:28 |
| mattmceuen | but I also agree roman_g that it would be nice from a CI perspective to use "zuul everywhere" and not juggle different CI systems | 14:29 |
| airship-irc-bot1 | <dwalt> +1 for the OSH approach. That was always helpful when getting started in OSH | 14:29 |
| jtwill98 | +1 bash is locally available | 14:29 |
| airship-irc-bot1 | <pb269f> I've got a poc of the bash approach for airshipctl that i could push up this week if there is interest? | 14:30 |
| airship-irc-bot1 | <pb269f> it would need some cleanup, but is what ive been using in my home lab for a couple of weeks | 14:30 |
| mattmceuen | oh yeah, that would be cool to see | 14:30 |
| howell | +1 for the poc | 14:30 |
| airship-irc-bot1 | <dwalt> I'd love to give that a try | 14:30 |
| airship-irc-bot1 | <dwalt> +1 | 14:31 |
| airship-irc-bot1 | <alexander.hughes> +1 | 14:31 |
| portdirect | ok - will do :) | 14:31 |
| mattmceuen | thanks portdirect | 14:31 |
| mattmceuen | and roman_g, dwalt | 14:31 |
| mattmceuen | ok! I think we can move on: | 14:31 |
| mattmceuen | #topic Reminder for new contributors - GitHub issues https://github.com/airshipit/airshipctl/issues | 14:31 |
| *** openstack changes topic to "Reminder for new contributors - GitHub issues https://github.com/airshipit/airshipctl/issues (Meeting topic: airship)" | 14:31 | |
| airship-irc-bot1 | <dwalt> as for the original question, are we safe to test those mirroring jobs in airship/zuul-jobs? | 14:32 |
| mattmceuen | oops sorry to cut you off dwalt | 14:32 |
| airship-irc-bot1 | <dwalt> since they should have no impact locally | 14:32 |
| airship-irc-bot1 | <dwalt> no worries :slightly_smiling_face: | 14:32 |
| mattmceuen | I think that makes a good first target, yeah - and can go ahead | 14:32 |
| airship-irc-bot1 | <dwalt> great! Thanks for bringing this up roman_g | 14:33 |
| airship-irc-bot1 | <dwalt> and volunteering ;) | 14:33 |
| mattmceuen | hahahah | 14:33 |
| mattmceuen | alright, lemme try a fresh segue: | 14:34 |
| mattmceuen | #topic Reminder for new contributors - GitHub issues https://github.com/airshipit/airshipctl/issues | 14:34 |
| *** openstack changes topic to "Reminder for new contributors - GitHub issues https://github.com/airshipit/airshipctl/issues (Meeting topic: airship)" | 14:34 | |
| mattmceuen | go for it alexander.hughes | 14:34 |
| * uzumaki is wondering if that :slightly_smiling_face: can be tab-completed. Or if <dwalt> is determined enough to type the whole thing | 14:34 | |
| airship-irc-bot1 | <alexander.hughes> I got a message from a new community member a few minutes ago asking on how to get involved in airship development, so first I'd like to welcome all of the new community members that are lurking in chat | 14:34 |
| mattmceuen | o/ welcome! | 14:35 |
| * uzumaki keeps lurking about, sneaking, prowling | 14:35 | |
| raymonddeng | Hi, that was me! Thanks for the warm welcome ^^ | 14:35 |
| airship-irc-bot1 | <alexander.hughes> and to answer the question again publicly, the best way to jump in with issues is by heading over to https://github.com/airshipit/airshipctl/issues and browsing through the list. I highly encourage you all to make use of the new labels, such as "good first issue" or "documentation" etc. to find an issue that interests you | 14:35 |
| airship-irc-bot1 | <alexander.hughes> welcome Raymond :slightly_smiling_face: | 14:35 |
| uzumaki | welcome aboard raymonddeng ! o/ | 14:35 |
| mattmceuen | +1 welcome Raymond, feel free to reach out here any time if you'd like some help getting started | 14:36 |
| mattmceuen | And now, I pass the baton back to you roman_g: | 14:36 |
| mattmceuen | #topic Copyright line in file headers | 14:37 |
| *** openstack changes topic to "Copyright line in file headers (Meeting topic: airship)" | 14:37 | |
| roman_g | Apache 2.0 license application example says that there should be a copyright line | 14:37 |
| roman_g | We don't have it in airshipctl at the moment. | 14:38 |
| roman_g | Has there been a discussion in WC/TC what should be put there? Who is copyright owner? | 14:38 |
| roman_g | Lawers have been contacted, may be? | 14:38 |
| roman_g | https://www.apache.org/licenses/LICENSE-2.0#apply | 14:39 |
| mattmceuen | we've discussed somewhere, forget which forum exactly | 14:39 |
| mattmceuen | check out kubernetes' license: https://github.com/kubernetes/kubernetes/blob/master/LICENSE | 14:39 |
| mattmceuen | it is one of many many examples that simply leave the Copyright template as-is | 14:39 |
| roman_g | https://github.com/kubernetes/kubernetes/blob/master/cmd/kubectl/kubectl.go#L2 | 14:40 |
| mattmceuen | I believe that's what we followed, trusting in the cumulative lawyer wisdom of the open source community at large | 14:40 |
| airship-irc-bot1 | <alexander.hughes> but the headers in files has been a subject of debate lately, looking at k8s again https://github.com/kubernetes/kubernetes/blob/master/pkg/api/endpoints/util.go | 14:40 |
| airship-irc-bot1 | <alexander.hughes> lists copyright kubernetes authors | 14:40 |
| mattmceuen | alexander.hughes, can you share a link to the debate if you can find it again? | 14:40 |
| roman_g | Kubernetes community adds copyright line in every file, as it is recommended https://www.apache.org/licenses/LICENSE-2.0#apply | 14:41 |
| mattmceuen | We have erred away from e.g. "Airship Authors" copyrighting to date, as it is not a legal entity (neither is Kubernetes Authors as far as I know) | 14:41 |
| portdirect | copywrite in the files means very little | 14:41 |
| portdirect | what matters is the copywrite of the commit | 14:41 |
| mattmceuen | +1 | 14:42 |
| portdirect | other than being a topic of endless debate of course ;) | 14:42 |
| mattmceuen | which is a cumulative thing -- can have multiple copyrights on a per-file basis up top | 14:42 |
| portdirect | please no | 14:42 |
| portdirect | we can, and theres nothing wrong with it | 14:42 |
| portdirect | but the one thing that really matters at the end of the day is git log | 14:42 |
| mattmceuen | ah, I see what you mean | 14:43 |
| portdirect | it just makes things super complex, and frankly hard to approach | 14:43 |
| portdirect | its why the `Kubernetes Authors` approach is used | 14:43 |
| uzumaki | how do we ensure copyrighting in commits? the signed-off-by thing? or the CLA? | 14:43 |
| portdirect | it just heads off this thing | 14:43 |
| portdirect | and gently directs people to make use of the version control history for the authorship | 14:44 |
| portdirect | otherwise, in the case of both k8s and the linux kernel | 14:44 |
| portdirect | your (c) headers would be hundreds if not thousands of lines long | 14:44 |
| uzumaki | oh I see! | 14:45 |
| mattmceuen | the joys of open source | 14:45 |
| mattmceuen | anything else on this topic folks? | 14:46 |
| uzumaki | well, how does this entity get defined then? | 14:46 |
| roman_g | No | 14:46 |
| uzumaki | the "Kubernetes Authors" | 14:46 |
| uzumaki | it's implied that it includes all the committers? | 14:46 |
| mattmceuen | That's why we don't have an "Airship Authors" defined - because that's not a legal entity | 14:46 |
| portdirect | they are the authors of kubernetes | 14:46 |
| uzumaki | so, like the OWNERS file people? | 14:47 |
| mattmceuen | I think there is a healthy dose of "it doesn't matter" when it comes to this stuff -- the license guarantees it's open source, the git history shows who the authors are | 14:47 |
| portdirect | no - to use a book/adademic paper analogy, they are the 'editors' | 14:48 |
| portdirect | mattmceuen: +++ | 14:48 |
| uzumaki | ah! I get it now. That's what I was thinking as well, got it | 14:48 |
| mattmceuen | and theres a lot of examples of big projects /not/ defining a copyright in the Authors file | 14:48 |
| uzumaki | portdirect, I see, thanks! | 14:48 |
| mattmceuen | you are not the first person to be confused by this stuff uzumaki :D | 14:48 |
| *** rezroo has joined #airshipit | 14:48 | |
| * mattmceuen was at least earlier in the confusion chain | 14:49 | |
| mattmceuen | ok! moving on! | 14:49 |
| uzumaki | I see, well, open source has its own joys, like you said mattmceuen | 14:49 |
| mattmceuen | #topic Review Requests | 14:49 |
| *** openstack changes topic to "Review Requests (Meeting topic: airship)" | 14:49 | |
| mattmceuen | https://review.opendev.org/#/c/717856/ - uplift go-git | 14:49 |
| mattmceuen | https://review.opendev.org/#/c/718532/ - Add APIExtensions ClientSet to airship Client | 14:49 |
| mattmceuen | https://review.opendev.org/#/c/717844/ - Remove deprecated `interfacer` linter | 14:49 |
| mattmceuen | Let's please get some solid reviews on these ones today. Any additional patchsets that y'all would like to put forward today? | 14:50 |
| mattmceuen | as you do, feel free to drop a note in the IRC channel anytime | 14:51 |
| mattmceuen | #topic Roundtable | 14:51 |
| *** openstack changes topic to "Roundtable (Meeting topic: airship)" | 14:51 | |
| mattmceuen | Any additional topics, or community feedback this morning? | 14:51 |
| uzumaki | mattmceuen, a small nit. Can we somehow embed the agenda etherpad link with the topics? That way, if sbd joins in later, they can quickly come upto speed with the etherpad | 14:51 |
| *** francisy has joined #airshipit | 14:51 | |
| mattmceuen | would definitely be interested in making that easier | 14:51 |
| uzumaki | that'll be great | 14:52 |
| mattmceuen | for the most part I think they're aligned already (I for one tend to copy and paste out of the agenda) | 14:52 |
| mattmceuen | are you thinking more like, dropping the verbatim topic name into the etherpad after its kicked off? | 14:52 |
| uzumaki | no, I mean, the etherpad URL, part of the topic string | 14:52 |
| mattmceuen | ohhhhhhhh | 14:52 |
| mattmceuen | I see | 14:52 |
| airship-irc-bot1 | <alexander.hughes> For the new community members I forgot to mention another good set of resources for getting engaged with the day to day of Airship development https://wiki.openstack.org/wiki/Airship lists all our community meetings, how to subscribe to the mailing list, etc. | 14:53 |
| uzumaki | And we can keep the topic name bunch of identifying keywords, not to make the topic stirng too long | 14:53 |
| mattmceuen | I'll take an action item to look into the meeting bot documentation, and see what I can do uzumaki | 14:53 |
| uzumaki | mattmceuen, that sounds great! | 14:53 |
| mattmceuen | if this is something we could automate somehow, would make it super easy | 14:53 |
| uzumaki | yes | 14:54 |
| mattmceuen | thanks for sharing that alexander.hughes | 14:54 |
| * mattmceuen also, etherpad :) https://etherpad.opendev.org/p/airship-meeting-2020-04-14 | 14:54 | |
| uzumaki | merci! | 14:55 |
| mattmceuen | de rien | 14:55 |
| mattmceuen | any other topics team? | 14:55 |
| uzumaki | nope | 14:55 |
| mattmceuen | alright - thanks for a productive meeting; hope you all enjoy the rest of your Tuesday | 14:55 |
| mattmceuen | See you next week if not before :) | 14:56 |
| mattmceuen | #endmeeting | 14:56 |
| *** openstack changes topic to "https://opendev.org/airship || https://wiki.openstack.org/wiki/Airship || https://review.opendev.org/#/q/projects:airship+status:open+NOT+label:Verified%253D-1+NOT+label:Workflow%253D-1+NOT+message:DNM+NOT+message:WIP" | 14:56 | |
| openstack | Meeting ended Tue Apr 14 14:56:09 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:56 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-04-14-14.00.html | 14:56 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-04-14-14.00.txt | 14:56 |
| uzumaki | see you! \o | 14:56 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-04-14-14.00.log.html | 14:56 |
| openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Introduce document plugin subcommand https://review.opendev.org/719931 | 14:57 |
| *** raymonddeng has left #airshipit | 14:57 | |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add pipeline factory and pipeline helpers https://review.opendev.org/719108 | 15:11 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add kubernetes pipeline implementation https://review.opendev.org/719113 | 15:11 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add pipeline Run command https://review.opendev.org/719666 | 15:11 |
| *** alhatneha has quit IRC | 15:12 | |
| *** jtwill98 has quit IRC | 15:12 | |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add pipeline Run command https://review.opendev.org/719666 | 15:21 |
| openstackgerrit | Vamsi Savaram proposed airship/images master: Gather container logs in check pipeline https://review.opendev.org/713733 | 15:21 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Add iDRAC ephemeral boot media support https://review.opendev.org/713711 | 15:21 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Move bootstrap cmd functionality to baremetal cmd https://review.opendev.org/719103 | 15:30 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Move remote cmd functionality to baremetal cmd https://review.opendev.org/719109 | 15:30 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: Add ephemeral host power on command https://review.opendev.org/716744 | 15:30 |
| openstackgerrit | Drew Walters proposed airship/airshipctl master: WIP: Add baremetal ephemeral ejectmedia command https://review.opendev.org/719111 | 15:30 |
| airship-irc-bot1 | <james.gu> a quick question for folks that are familiar with update-golden. The gate appears to run update-golden then run the unit test. What is the purpose of always running update-golden in the gate? Would that step virtually guarantee the pass of unit tests? | 15:39 |
| airship-irc-bot1 | <ih616h> @james.gu it's a bit convoluted but... | 15:40 |
| airship-irc-bot1 | <ih616h> the unit tests are run first | 15:40 |
| airship-irc-bot1 | <ih616h> then update-golden is run | 15:40 |
| openstackgerrit | Alexey Odinokov proposed airship/airshipctl master: Substituting ad-hoc sushy-emulator and apache reverse-proxy with apache with sushy-emulator attached via wsgi https://review.opendev.org/719320 | 15:40 |
| airship-irc-bot1 | <ih616h> (update-golden actually reruns the unit tests) | 15:40 |
| *** uzumaki has quit IRC | 15:40 | |
| airship-irc-bot1 | <ih616h> then there's a git-diff which verifies that there's no new golden files | 15:41 |
| airship-irc-bot1 | <alexander.hughes> basically we're testing to make sure current tests work then making sure that the tests themselves are valid (no tests are missing, no unused tests are present) when we update the tests, we test again to make sure they still pass | 15:41 |
| airship-irc-bot1 | <james.gu> ah it is the "(update-golden actually reruns the unit tests)" that caught me | 15:41 |
| airship-irc-bot1 | <ih616h> on that note - `update-golden` only runs the code in the `./cmd` package | 15:42 |
| airship-irc-bot1 | <ih616h> and it only partially runs tests - there's no assertions being made | 15:42 |
| airship-irc-bot1 | <james.gu> just curious, since the unit test has already passed in the previous step, is there a need for update-golden (golden data has to be identical to what the cmd class output)? | 15:44 |
| airship-irc-bot1 | <ih616h> yes - if a developer deletes a unit test in `./cmd`, it's possible that they forget to delete its associated golden file | 15:45 |
| airship-irc-bot1 | <ih616h> basically, it verifies that developers are properly cleaning up after themselves :slightly_smiling_face: | 15:45 |
| airship-irc-bot1 | <james.gu> from that purpose, it makes sense. I thought the purpose was broader, to match/update golden data to the actual cmd output. | 15:46 |
| airship-irc-bot1 | <james.gu> thanks for the explanation howell | 15:47 |
| *** uzumaki has joined #airshipit | 15:50 | |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add PhaseSelector and PhaseLabel https://review.opendev.org/718869 | 15:52 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add CurrentContextCluster Type and Name methods https://review.opendev.org/718814 | 15:52 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add pipeline factory and pipeline helpers https://review.opendev.org/719108 | 15:52 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add kubernetes pipeline implementation https://review.opendev.org/719113 | 15:52 |
| openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add pipeline Run command https://review.opendev.org/719666 | 15:52 |
| *** avolkov has quit IRC | 15:57 | |
| *** ab2434_ has quit IRC | 16:00 | |
| *** diga has quit IRC | 16:03 | |
| openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Introduce document plugin subcommand https://review.opendev.org/719931 | 16:19 |
| openstackgerrit | Vamsi Savaram proposed airship/images master: Gather container logs in check pipeline https://review.opendev.org/713733 | 16:23 |
| openstackgerrit | Prateek Dodda proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 16:27 |
| openstackgerrit | Rodolfo Pacheco proposed airship/airshipctl master: Implements airshipctl config --import <from kubeconfig> https://review.opendev.org/717630 | 16:35 |
| *** evrardjp has quit IRC | 16:37 | |
| *** evrardjp has joined #airshipit | 16:37 | |
| *** SRao has quit IRC | 16:52 | |
| *** mikefix has quit IRC | 17:04 | |
| openstackgerrit | Rodolfo Pacheco proposed airship/airshipctl master: Implements airshipctl config --import <from kubeconfig> https://review.opendev.org/717630 | 17:11 |
| openstackgerrit | Stas Egorov proposed airship/airshipctl master: removed Modules from Config https://review.opendev.org/718567 | 17:14 |
| *** roman_g has quit IRC | 17:19 | |
| *** roman_g has joined #airshipit | 17:19 | |
| *** roman_g has quit IRC | 17:20 | |
| *** roman_g has joined #airshipit | 17:20 | |
| *** roman_g has quit IRC | 17:20 | |
| *** roman_g has joined #airshipit | 17:21 | |
| *** roman_g has quit IRC | 17:21 | |
| *** roman_g has joined #airshipit | 17:22 | |
| *** roman_g has quit IRC | 17:22 | |
| *** roman_g has joined #airshipit | 17:22 | |
| *** roman_g has quit IRC | 17:23 | |
| *** roman_g has joined #airshipit | 17:23 | |
| *** roman_g has quit IRC | 17:24 | |
| *** uzumaki has quit IRC | 18:02 | |
| *** dpawlik has quit IRC | 18:02 | |
| openstackgerrit | Matthew Fuller proposed airship/airshipui master: [WIP] Add plugin to show database status to Airship UI https://review.opendev.org/716414 | 18:11 |
| openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [WIP] Refactor of codebase addressing IDE errors https://review.opendev.org/720047 | 18:14 |
| *** andrewkarandjeff has quit IRC | 18:43 | |
| openstackgerrit | Alexander Hughes proposed airship/airshipctl master: Refactor of codebase addressing IDE errors https://review.opendev.org/720047 | 19:15 |
| openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app https://review.opendev.org/717848 | 19:39 |
| openstackgerrit | Alexander Hughes proposed airship/airshipctl master: Refactor of codebase addressing IDE errors https://review.opendev.org/720047 | 19:43 |
| *** vamsisavaram has quit IRC | 19:54 | |
| openstackgerrit | Alexander Hughes proposed airship/airshipctl master: Refactor of codebase addressing IDE errors https://review.opendev.org/720047 | 19:56 |
| openstackgerrit | Ian Howell proposed airship/airshipctl master: Implements airshipctl config --import <from kubeconfig> https://review.opendev.org/717630 | 19:56 |
| *** mikefix has joined #airshipit | 20:03 | |
| openstackgerrit | eric welch proposed airship/deckhand master: WIP password rotation for deckhand, testing first helm install https://review.opendev.org/712162 | 20:16 |
| *** georgk has quit IRC | 20:19 | |
| *** georgk has joined #airshipit | 20:20 | |
| *** georgk has quit IRC | 20:20 | |
| *** georgk has joined #airshipit | 20:21 | |
| *** georgk has quit IRC | 20:23 | |
| openstackgerrit | Alexey Odinokov proposed airship/airshipctl master: Substituting ad-hoc sushy-emulator and apache reverse-proxy with apache with sushy-emulator attached via wsgi https://review.opendev.org/719320 | 21:00 |
| *** KeithMnemonic has joined #airshipit | 21:08 | |
| *** roman_g has joined #airshipit | 21:08 | |
| *** KeithMnemonic has quit IRC | 21:16 | |
| openstackgerrit | Matthew Fuller proposed airship/airshipui master: Add plugin to show database status to Airship UI https://review.opendev.org/716414 | 21:16 |
| *** KeithMnemonic has joined #airshipit | 21:17 | |
| openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app https://review.opendev.org/717848 | 21:25 |
| *** roman_g has quit IRC | 21:53 | |
| airship-irc-bot1 | <sirajudeen.yasin> Code review pls, https://review.opendev.org/#/c/713755/12 , just updated some commit msg per review comment | 21:58 |
| openstackgerrit | Rahul Khiyani proposed airship/armada master: Tiller: Add apparmor profile to tiller container https://review.opendev.org/719528 | 21:59 |
| openstackgerrit | Sirajudeen proposed airship/airshipctl master: Organize CLI helper functions https://review.opendev.org/713755 | 22:03 |
| openstackgerrit | Sirajudeen proposed airship/airshipctl master: Organize CLI helper functions https://review.opendev.org/713755 | 22:08 |
| openstackgerrit | Sirajudeen proposed airship/airshipctl master: Fix for Lint warnings https://review.opendev.org/718289 | 22:18 |
| *** mikefix has quit IRC | 22:21 | |
| *** born2bake has quit IRC | 22:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
