Friday, 2020-04-24

*** happyhemant has quit IRC01:11
*** uzumaki has quit IRC01:54
openstackgerritdiwakar thyagaraj proposed airship/porthole master: [WIP] Fix Labels and Apparmor for ceph-ns  https://review.opendev.org/72256603:11
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976303:17
openstackgerritdiwakar thyagaraj proposed airship/porthole master: [WIP] Fix Labels and Apparmor for ceph-ns  https://review.opendev.org/72256603:42
*** evrardjp has quit IRC04:35
*** evrardjp has joined #airshipit04:35
*** roman_g has quit IRC04:53
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218505:09
*** dpawlik has joined #airshipit06:03
*** rezroo has quit IRC06:33
openstackgerritRuslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment  https://review.opendev.org/72262107:24
*** born2bake has joined #airshipit07:25
openstackgerritRuslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment  https://review.opendev.org/72262107:48
openstackgerritDmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199509:11
openstackgerritDmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199509:12
openstackgerritDmitry Ukov proposed airship/airshipctl master: Add template based generator plugin  https://review.opendev.org/72160209:27
*** avolkov has joined #airshipit09:28
*** SRao has joined #airshipit11:35
openstackgerritDmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199512:09
openstackgerritDmitry Ukov proposed airship/airshipctl master: [WIP] Rplacement transformer variables improvement  https://review.opendev.org/72267312:09
*** SRao has quit IRC12:51
*** rezroo has joined #airshipit12:54
openstackgerritVamsi Savaram proposed airship/airshipctl master: Refactor proxy configuration  https://review.opendev.org/72268413:01
openstackgerritVladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable  https://review.opendev.org/71781213:21
openstackgerritVladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable  https://review.opendev.org/71781213:29
openstackgerritVladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable  https://review.opendev.org/71781213:56
openstackgerritMerged airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218813:59
openstackgerritVladislav Kuzmin proposed airship/airshipctl master: Improve config package organization pt.1  https://review.opendev.org/71009714:08
openstackgerritDrew Walters proposed airship/airshipctl master: Add management configuration module  https://review.opendev.org/72084314:27
openstackgerritDrew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts  https://review.opendev.org/72030414:27
*** mikefix has joined #airshipit14:30
openstackgerritDrew Walters proposed airship/promenade master: Add SECURITY.md  https://review.opendev.org/70899514:31
openstackgerritMerged airship/airshipctl master: Add stricter Redfish error inspection  https://review.opendev.org/72215614:39
*** SRao has joined #airshipit14:43
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72252214:46
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976314:50
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72252214:51
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72252214:54
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72252214:56
openstackgerritMerged airship/treasuremap master: Uplift porthole chart with the lastest reference  https://review.opendev.org/72177714:58
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72281715:02
*** dpawlik has quit IRC15:10
openstackgerritMerged airship/promenade master: Add SECURITY.md  https://review.opendev.org/70899515:24
openstackgerritDmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199515:49
openstackgerritDmitry Ukov proposed airship/airshipctl master: [WIP] Rplacement transformer variables improvement  https://review.opendev.org/72267315:49
openstackgerritJagan Mohan Kavva proposed airship/porthole master: [WIP] Unable to execute utilscli commands  https://review.opendev.org/72136415:52
openstackgerritIan Howell proposed airship/airshipctl master: Define a standard for creating commands  https://review.opendev.org/72030115:56
*** uzumaki has joined #airshipit16:12
openstackgerritStas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info  https://review.opendev.org/72057616:23
*** evrardjp has quit IRC16:35
*** evrardjp has joined #airshipit16:35
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: Update developer guide for deployment with proxy  https://review.opendev.org/72293616:38
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976316:52
*** mikefix has quit IRC16:52
*** SRao has quit IRC16:58
openstackgerritMerged airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199517:21
openstackgerritPhil Sphicas proposed airship/shipyard master: fix: airflow quicktest error  https://review.opendev.org/72295017:26
openstackgerritDrew Walters proposed airship/airshipctl master: WIP: Decode Redfish error responses as raw JSON  https://review.opendev.org/72295117:30
openstackgerritStas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry  https://review.opendev.org/72151317:48
openstackgerritManoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs  https://review.opendev.org/71536617:58
airship-irc-bot1<kk6740> @ih616h @awander i have noticed that clusterctl package utilizes errors package: `"github.com/pkg/errors"`  ,specifically wrapf function, it appears to give much more information than what we get with errors currently, including a python like traceback, which is very helpful when debugging.  Should we consider using this as well?18:00
*** alanmeadows has quit IRC18:03
*** alanmeadows has joined #airshipit18:03
openstackgerritManoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs  https://review.opendev.org/71536618:07
airship-irc-bot1<kk6740> an example traceback: ```                    evalsymlink failure on 'testdata/functions/capi/infrastructure/v0.3.0' : lstat /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/testdata/functions/capi/infrastructure/v0.3.0: no such file or directory                     Failed to create bundle                     opendev.org/airship/airshipctl/pkg/clusterctl/implementations.(*Repository).GetFile18:07
airship-irc-bot1    /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/implementations/repository.go:67                     sigs.k8s.io/cluster-api/cmd/clusterctl/client/repository.(*componentsClient).Get                     /Users/kkalinovskiy/go/pkg/mod/sigs.k8s.io/cluster-api@v0.3.3/cmd/clusterctl/client/repository/components_client.go:74                     opendev.org/airship/airshipctl/pkg/clusterctl/client.TestFactory18:07
airship-irc-bot1        /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/factory_test.go:42                     testing.tRunner                     /usr/local/Cellar/go/1.13.1/libexec/src/testing/testing.go:909                     runtime.goexit                     /usr/local/Cellar/go/1.13.1/libexec/src/runtime/asm_amd64.s:1357                     failed to read "components.yaml" from provider's repository18:07
airship-irc-bot1"infrastructure-custom-airship-infra"                     sigs.k8s.io/cluster-api/cmd/clusterctl/client/repository.(*componentsClient).Get                     /Users/kkalinovskiy/go/pkg/mod/sigs.k8s.io/cluster-api@v0.3.3/cmd/clusterctl/client/repository/components_client.go:76                     opendev.org/airship/airshipctl/pkg/clusterctl/client.TestFactory18:07
airship-irc-bot1/Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/factory_test.go:42                     testing.tRunner                     /usr/local/Cellar/go/1.13.1/libexec/src/testing/testing.go:909                     runtime.goexit                     /usr/local/Cellar/go/1.13.1/libexec/src/runtime/asm_amd64.s:1357```18:07
openstackgerritManoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs  https://review.opendev.org/71536618:08
airship-irc-bot1<ih616h> There was a reason that we'd decided to just use vanilla errors back when the project started, but I'm failing to remember why...18:10
airship-irc-bot1<ih616h> the stack traces are definitely nice18:10
airship-irc-bot1<kk6740> i mean, we can still use our own error implementation for custom errors18:10
airship-irc-bot1<kk6740> it’s just we can decorate them to provide stack tracebacks, rather than simply returning same error without any feedback where it happened18:11
airship-irc-bot1<ih616h> I remember now - we were planning on using the builtin `error` package for type switching on errors18:11
airship-irc-bot1<ih616h> we can't do that if we're using `Wrap` and `Wrapf`18:12
airship-irc-bot1<ih616h> let me find an example...18:12
*** rezroo has quit IRC18:13
airship-irc-bot1<kk6740> i think in go 13, they have introduced As() methods for errors18:13
airship-irc-bot1<kk6740> that can be used with wrap i think18:13
airship-irc-bot1<ih616h> something like this: https://github.com/airshipit/airshipctl/blob/master/pkg/config/config_helper.go#L3318:13
airship-irc-bot1<kk6740> not sure though18:13
airship-irc-bot1<ih616h> using `Wrap` strips off all the context18:13
airship-irc-bot1<ih616h> (or rather, using `github.com/pkg/errors.Wrap` strips off the context)18:14
airship-irc-bot1<kk6740> oh, so we can’t use As() with wrap?18:15
airship-irc-bot1<kk6740> wonder if ```fmt.Errorf("adding more context: %w", err)``` from golang 13, will help here18:17
airship-irc-bot1<ih616h> It doesn't look like it - `Wrap` returns a whole new error - https://github.com/pkg/errors/blob/master/errors.go#L20918:18
airship-irc-bot1<ih616h> ok it looks like we could use it, but it'd need some boiler plate - you can get the "root" error with `Cause`: https://github.com/pkg/errors/blob/master/errors.go#L16018:19
airship-irc-bot1<se6518> Please review airshipctl config CLI: https://review.opendev.org/72057618:43
airship-irc-bot1<se6518> and small change: https://review.opendev.org/72151318:43
openstackgerritDrew Walters proposed airship/airshipctl master: Decode Redfish error responses as raw JSON  https://review.opendev.org/72295118:49
*** avolkov has quit IRC18:57
openstackgerritStas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry  https://review.opendev.org/72151319:01
*** uzumaki has quit IRC19:08
*** KeithMnemonic has quit IRC19:24
*** KeithMnemonic has joined #airshipit19:25
openstackgerritMerged airship/treasuremap master: Added labels for global osh-infra charts  https://review.opendev.org/71130719:26
*** rezroo has joined #airshipit19:39
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72281719:42
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72281719:45
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976319:59
*** toabctl has quit IRC20:00
*** roman_g has joined #airshipit20:01
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image  https://review.opendev.org/72281720:06
*** roman_g has quit IRC20:06
openstackgerritStas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry  https://review.opendev.org/72151320:15
-openstackstatus- NOTICE: The Zuul project gating service is reporting new patches in merge conflict erroneously due to a configuration error, fix in progress20:18
openstackgerritStas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry  https://review.opendev.org/72151320:22
openstackgerritPrateek Dodda proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951920:27
openstackgerritRahul Khiyani proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951920:47
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218520:48
*** michael-beaver has joined #airshipit20:59
*** KeithMnemonic has quit IRC21:03
openstackgerritDrew Walters proposed airship/airshipctl master: Decode Redfish error responses as raw JSON  https://review.opendev.org/72295121:04
openstackgerritDrew Walters proposed airship/airshipctl master: Add management configuration module  https://review.opendev.org/72084321:45
openstackgerritDrew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts  https://review.opendev.org/72030421:45
openstackgerritPrateek Dodda proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951922:03
*** born2bake has quit IRC22:11
openstackgerritStas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry  https://review.opendev.org/72151322:35
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216522:51
-openstackstatus- NOTICE: the This Zuul outage was taken as an opportunity to perform an impromptu maintenance for changing our service deployment model; any merge failures received from Zuul between 19:40 and 20:20 UTC were likely in error and those changes should be rechecked; any patches uploaded between 20:55 and 22:45 UTC were missed entirely by Zuul and should also be rechecked to get fresh test results22:55
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218523:02
*** thansen has quit IRC23:51
*** thansen has joined #airshipit23:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!