*** happyhemant has quit IRC | 01:11 | |
*** uzumaki has quit IRC | 01:54 | |
openstackgerrit | diwakar thyagaraj proposed airship/porthole master: [WIP] Fix Labels and Apparmor for ceph-ns https://review.opendev.org/722566 | 03:11 |
---|---|---|
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 03:17 |
openstackgerrit | diwakar thyagaraj proposed airship/porthole master: [WIP] Fix Labels and Apparmor for ceph-ns https://review.opendev.org/722566 | 03:42 |
*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #airshipit | 04:35 | |
*** roman_g has quit IRC | 04:53 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 05:09 |
*** dpawlik has joined #airshipit | 06:03 | |
*** rezroo has quit IRC | 06:33 | |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment https://review.opendev.org/722621 | 07:24 |
*** born2bake has joined #airshipit | 07:25 | |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment https://review.opendev.org/722621 | 07:48 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 09:11 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 09:12 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Add template based generator plugin https://review.opendev.org/721602 | 09:27 |
*** avolkov has joined #airshipit | 09:28 | |
*** SRao has joined #airshipit | 11:35 | |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 12:09 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Rplacement transformer variables improvement https://review.opendev.org/722673 | 12:09 |
*** SRao has quit IRC | 12:51 | |
*** rezroo has joined #airshipit | 12:54 | |
openstackgerrit | Vamsi Savaram proposed airship/airshipctl master: Refactor proxy configuration https://review.opendev.org/722684 | 13:01 |
openstackgerrit | Vladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable https://review.opendev.org/717812 | 13:21 |
openstackgerrit | Vladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable https://review.opendev.org/717812 | 13:29 |
openstackgerrit | Vladislav Kuzmin proposed airship/airshipctl master: Make remote parameters configurable https://review.opendev.org/717812 | 13:56 |
openstackgerrit | Merged airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 13:59 |
openstackgerrit | Vladislav Kuzmin proposed airship/airshipctl master: Improve config package organization pt.1 https://review.opendev.org/710097 | 14:08 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management configuration module https://review.opendev.org/720843 | 14:27 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts https://review.opendev.org/720304 | 14:27 |
*** mikefix has joined #airshipit | 14:30 | |
openstackgerrit | Drew Walters proposed airship/promenade master: Add SECURITY.md https://review.opendev.org/708995 | 14:31 |
openstackgerrit | Merged airship/airshipctl master: Add stricter Redfish error inspection https://review.opendev.org/722156 | 14:39 |
*** SRao has joined #airshipit | 14:43 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722522 | 14:46 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 14:50 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722522 | 14:51 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722522 | 14:54 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722522 | 14:56 |
openstackgerrit | Merged airship/treasuremap master: Uplift porthole chart with the lastest reference https://review.opendev.org/721777 | 14:58 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722817 | 15:02 |
*** dpawlik has quit IRC | 15:10 | |
openstackgerrit | Merged airship/promenade master: Add SECURITY.md https://review.opendev.org/708995 | 15:24 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 15:49 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Rplacement transformer variables improvement https://review.opendev.org/722673 | 15:49 |
openstackgerrit | Jagan Mohan Kavva proposed airship/porthole master: [WIP] Unable to execute utilscli commands https://review.opendev.org/721364 | 15:52 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Define a standard for creating commands https://review.opendev.org/720301 | 15:56 |
*** uzumaki has joined #airshipit | 16:12 | |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info https://review.opendev.org/720576 | 16:23 |
*** evrardjp has quit IRC | 16:35 | |
*** evrardjp has joined #airshipit | 16:35 | |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: Update developer guide for deployment with proxy https://review.opendev.org/722936 | 16:38 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 16:52 |
*** mikefix has quit IRC | 16:52 | |
*** SRao has quit IRC | 16:58 | |
openstackgerrit | Merged airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 17:21 |
openstackgerrit | Phil Sphicas proposed airship/shipyard master: fix: airflow quicktest error https://review.opendev.org/722950 | 17:26 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: WIP: Decode Redfish error responses as raw JSON https://review.opendev.org/722951 | 17:30 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry https://review.opendev.org/721513 | 17:48 |
openstackgerrit | Manoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs https://review.opendev.org/715366 | 17:58 |
airship-irc-bot1 | <kk6740> @ih616h @awander i have noticed that clusterctl package utilizes errors package: `"github.com/pkg/errors"` ,specifically wrapf function, it appears to give much more information than what we get with errors currently, including a python like traceback, which is very helpful when debugging. Should we consider using this as well? | 18:00 |
*** alanmeadows has quit IRC | 18:03 | |
*** alanmeadows has joined #airshipit | 18:03 | |
openstackgerrit | Manoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs https://review.opendev.org/715366 | 18:07 |
airship-irc-bot1 | <kk6740> an example traceback: ``` evalsymlink failure on 'testdata/functions/capi/infrastructure/v0.3.0' : lstat /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/testdata/functions/capi/infrastructure/v0.3.0: no such file or directory Failed to create bundle opendev.org/airship/airshipctl/pkg/clusterctl/implementations.(*Repository).GetFile | 18:07 |
airship-irc-bot1 | /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/implementations/repository.go:67 sigs.k8s.io/cluster-api/cmd/clusterctl/client/repository.(*componentsClient).Get /Users/kkalinovskiy/go/pkg/mod/sigs.k8s.io/cluster-api@v0.3.3/cmd/clusterctl/client/repository/components_client.go:74 opendev.org/airship/airshipctl/pkg/clusterctl/client.TestFactory | 18:07 |
airship-irc-bot1 | /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/factory_test.go:42 testing.tRunner /usr/local/Cellar/go/1.13.1/libexec/src/testing/testing.go:909 runtime.goexit /usr/local/Cellar/go/1.13.1/libexec/src/runtime/asm_amd64.s:1357 failed to read "components.yaml" from provider's repository | 18:07 |
airship-irc-bot1 | "infrastructure-custom-airship-infra" sigs.k8s.io/cluster-api/cmd/clusterctl/client/repository.(*componentsClient).Get /Users/kkalinovskiy/go/pkg/mod/sigs.k8s.io/cluster-api@v0.3.3/cmd/clusterctl/client/repository/components_client.go:76 opendev.org/airship/airshipctl/pkg/clusterctl/client.TestFactory | 18:07 |
airship-irc-bot1 | /Users/kkalinovskiy/projects/airship/airshipctl/pkg/clusterctl/client/factory_test.go:42 testing.tRunner /usr/local/Cellar/go/1.13.1/libexec/src/testing/testing.go:909 runtime.goexit /usr/local/Cellar/go/1.13.1/libexec/src/runtime/asm_amd64.s:1357``` | 18:07 |
openstackgerrit | Manoj Alva proposed airship/go-redfish master: Support for Additional Redfish APIs https://review.opendev.org/715366 | 18:08 |
airship-irc-bot1 | <ih616h> There was a reason that we'd decided to just use vanilla errors back when the project started, but I'm failing to remember why... | 18:10 |
airship-irc-bot1 | <ih616h> the stack traces are definitely nice | 18:10 |
airship-irc-bot1 | <kk6740> i mean, we can still use our own error implementation for custom errors | 18:10 |
airship-irc-bot1 | <kk6740> it’s just we can decorate them to provide stack tracebacks, rather than simply returning same error without any feedback where it happened | 18:11 |
airship-irc-bot1 | <ih616h> I remember now - we were planning on using the builtin `error` package for type switching on errors | 18:11 |
airship-irc-bot1 | <ih616h> we can't do that if we're using `Wrap` and `Wrapf` | 18:12 |
airship-irc-bot1 | <ih616h> let me find an example... | 18:12 |
*** rezroo has quit IRC | 18:13 | |
airship-irc-bot1 | <kk6740> i think in go 13, they have introduced As() methods for errors | 18:13 |
airship-irc-bot1 | <kk6740> that can be used with wrap i think | 18:13 |
airship-irc-bot1 | <ih616h> something like this: https://github.com/airshipit/airshipctl/blob/master/pkg/config/config_helper.go#L33 | 18:13 |
airship-irc-bot1 | <kk6740> not sure though | 18:13 |
airship-irc-bot1 | <ih616h> using `Wrap` strips off all the context | 18:13 |
airship-irc-bot1 | <ih616h> (or rather, using `github.com/pkg/errors.Wrap` strips off the context) | 18:14 |
airship-irc-bot1 | <kk6740> oh, so we can’t use As() with wrap? | 18:15 |
airship-irc-bot1 | <kk6740> wonder if ```fmt.Errorf("adding more context: %w", err)``` from golang 13, will help here | 18:17 |
airship-irc-bot1 | <ih616h> It doesn't look like it - `Wrap` returns a whole new error - https://github.com/pkg/errors/blob/master/errors.go#L209 | 18:18 |
airship-irc-bot1 | <ih616h> ok it looks like we could use it, but it'd need some boiler plate - you can get the "root" error with `Cause`: https://github.com/pkg/errors/blob/master/errors.go#L160 | 18:19 |
airship-irc-bot1 | <se6518> Please review airshipctl config CLI: https://review.opendev.org/720576 | 18:43 |
airship-irc-bot1 | <se6518> and small change: https://review.opendev.org/721513 | 18:43 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Decode Redfish error responses as raw JSON https://review.opendev.org/722951 | 18:49 |
*** avolkov has quit IRC | 18:57 | |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry https://review.opendev.org/721513 | 19:01 |
*** uzumaki has quit IRC | 19:08 | |
*** KeithMnemonic has quit IRC | 19:24 | |
*** KeithMnemonic has joined #airshipit | 19:25 | |
openstackgerrit | Merged airship/treasuremap master: Added labels for global osh-infra charts https://review.opendev.org/711307 | 19:26 |
*** rezroo has joined #airshipit | 19:39 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722817 | 19:42 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722817 | 19:45 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 19:59 |
*** toabctl has quit IRC | 20:00 | |
*** roman_g has joined #airshipit | 20:01 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: Adding the ability to inject certificate authorities into docker image https://review.opendev.org/722817 | 20:06 |
*** roman_g has quit IRC | 20:06 | |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry https://review.opendev.org/721513 | 20:15 |
-openstackstatus- NOTICE: The Zuul project gating service is reporting new patches in merge conflict erroneously due to a configuration error, fix in progress | 20:18 | |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry https://review.opendev.org/721513 | 20:22 |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 20:27 |
openstackgerrit | Rahul Khiyani proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 20:47 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 20:48 |
*** michael-beaver has joined #airshipit | 20:59 | |
*** KeithMnemonic has quit IRC | 21:03 | |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Decode Redfish error responses as raw JSON https://review.opendev.org/722951 | 21:04 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management configuration module https://review.opendev.org/720843 | 21:45 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts https://review.opendev.org/720304 | 21:45 |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 22:03 |
*** born2bake has quit IRC | 22:11 | |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added error handler for empty runtime entry https://review.opendev.org/721513 | 22:35 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 22:51 |
-openstackstatus- NOTICE: the This Zuul outage was taken as an opportunity to perform an impromptu maintenance for changing our service deployment model; any merge failures received from Zuul between 19:40 and 20:20 UTC were likely in error and those changes should be rechecked; any patches uploaded between 20:55 and 22:45 UTC were missed entirely by Zuul and should also be rechecked to get fresh test results | 22:55 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 23:02 |
*** thansen has quit IRC | 23:51 | |
*** thansen has joined #airshipit | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!