*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #airshipit | 04:36 | |
*** dpawlik has joined #airshipit | 06:04 | |
*** dpawlik has quit IRC | 06:04 | |
*** dpawlik has joined #airshipit | 06:07 | |
*** dpawlik has quit IRC | 06:07 | |
*** dpawlik has joined #airshipit | 06:08 | |
*** rezroo has joined #airshipit | 06:31 | |
*** roman_g has joined #airshipit | 08:10 | |
*** roman_g has quit IRC | 08:50 | |
*** roman_g has joined #airshipit | 09:03 | |
*** rezroo has quit IRC | 09:04 | |
*** roman_g has quit IRC | 09:38 | |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment https://review.opendev.org/722621 | 09:39 |
---|---|---|
*** roman_g has joined #airshipit | 09:55 | |
*** zogger has quit IRC | 10:51 | |
*** avolkov has joined #airshipit | 10:52 | |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: [WIP] Remove "cluster initinfra" command https://review.opendev.org/724276 | 12:08 |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Remove "cluster initinfra" command https://review.opendev.org/724276 | 12:10 |
*** SRao has joined #airshipit | 13:04 | |
*** muhaha has joined #airshipit | 13:07 | |
*** rezroo has joined #airshipit | 13:11 | |
*** mikefix has joined #airshipit | 13:20 | |
*** KeithMnemonic has joined #airshipit | 13:31 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example https://review.opendev.org/724938 | 13:40 |
*** muhaha84 has joined #airshipit | 13:41 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example https://review.opendev.org/724938 | 13:55 |
*** nishantkr has joined #airshipit | 14:06 | |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest https://review.opendev.org/717119 | 14:17 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest https://review.opendev.org/717119 | 14:21 |
openstackgerrit | Arvinderpal Wander proposed airship/airshipctl master: WIP: Adds support for `clusterctl move` of capi and bmo resources from ephermeral to workload cluster. https://review.opendev.org/724940 | 14:29 |
airship-irc-bot1 | <alexander.hughes> code review please https://review.opendev.org/#/c/724828/ | 14:43 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add state validation to Redfish shutdown/startup https://review.opendev.org/724928 | 14:52 |
openstackgerrit | Matt McEuen proposed airship/airshipctl master: [WIP] Stub out replacement structure https://review.opendev.org/724869 | 14:53 |
openstackgerrit | Sophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility https://review.opendev.org/725300 | 15:13 |
airship-irc-bot1 | <se6518> Please review fix for the airshipctl config bug: https://review.opendev.org/724405 | 15:16 |
airship-irc-bot1 | <se6518> and new CLI: https://review.opendev.org/720576 | 15:16 |
*** jamesgu has joined #airshipit | 15:22 | |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest https://review.opendev.org/717119 | 15:24 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest https://review.opendev.org/717119 | 15:36 |
*** dpawlik has quit IRC | 15:59 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example https://review.opendev.org/724938 | 16:01 |
openstackgerrit | Prateek Dodda proposed airship/drydock master: Enabling Apparmor for drydock init containers https://review.opendev.org/724768 | 16:06 |
openstackgerrit | Prateek Dodda proposed airship/deckhand master: Enabling Apparmor profile to deckhand init containers https://review.opendev.org/724902 | 16:31 |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: Enabling Apparmor profile to shipyard init containers https://review.opendev.org/724702 | 16:33 |
*** SRao has quit IRC | 16:35 | |
*** evrardjp has quit IRC | 16:35 | |
openstackgerrit | Alexander Hughes proposed airship/pegleg master: Fail early on invalid save locations https://review.opendev.org/724828 | 16:35 |
*** evrardjp has joined #airshipit | 16:36 | |
openstackgerrit | diwakar thyagaraj proposed airship/porthole master: [WIP] Enable Deployment consistency across all UC https://review.opendev.org/725117 | 16:45 |
*** bornie2bake has joined #airshipit | 16:51 | |
*** bornie2bake has quit IRC | 16:54 | |
*** bornie2bake has joined #airshipit | 16:55 | |
airship-irc-bot1 | <alexander.hughes> Why do we have nested commands in pkg directory? It wasn't introduced in this patchset, just first time I've noticed it https://review.opendev.org/#/c/724506/7/pkg/clusterctl/cmd/command.go | 17:07 |
*** bornie2bake has quit IRC | 17:08 | |
airship-irc-bot1 | <kk6740> @alexander.hughes, sorry didn’t understood that question fully. is that about make of the package ? | 17:09 |
airship-irc-bot1 | <alexander.hughes> so normal structure is ./airshipctl/pkg/<package> or ./airshipctl/cmd/<command> but in the case of clusterctl, we have ./airshipctl/pkg/clusterctl/cmd/command.go -- why isn't command.go instead located at ./airshipctl/cmd/clusterctl/command.go ? | 17:10 |
*** bornie2bake has joined #airshipit | 17:11 | |
airship-irc-bot1 | <kk6740> when did that, i expected that there are more commands from clusterctl, not only init, as well move, upgrade and possible more. So I thought since we may have many of these commands, it is logical to put it into pkg/clusterctl/cmd/, rather than into pkg/clusterctl/command.go | 17:14 |
airship-irc-bot1 | <kk6740> as an example i took this from kubectl, where they have pkg/cmd. | 17:16 |
airship-irc-bot1 | <kk6740> https://github.com/kubernetes/kubectl/tree/master/pkg/cmd | 17:16 |
*** bornie2bake has quit IRC | 17:20 | |
airship-irc-bot1 | <sb464f> Hi Team can I get some reviews here please -> https://review.opendev.org/#/c/725035/ | 17:30 |
airship-irc-bot1 | <pb269f> lgtm sai | 17:31 |
airship-irc-bot1 | <pb269f> the pods not being present immediately is a kicker, i like your approach better than what we did in the osh gates | 17:31 |
airship-irc-bot1 | <pb269f> https://github.com/openstack/openstack-helm-infra/blob/master/tools/deployment/common/005-deploy-k8s.sh#L151-L158 | 17:32 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface https://review.opendev.org/725140 | 17:42 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface https://review.opendev.org/725140 | 17:44 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration https://review.opendev.org/724506 | 17:48 |
openstackgerrit | Merged airship/airshipctl master: Wait for control pods to be ready before moving to initinfra https://review.opendev.org/725035 | 18:04 |
openstackgerrit | Merged airship/pegleg master: Fail early on invalid save locations https://review.opendev.org/724828 | 18:13 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add mutual exclusivity to manager host selectors https://review.opendev.org/724905 | 18:25 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests https://review.opendev.org/725366 | 18:30 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests https://review.opendev.org/725366 | 18:31 |
airship-irc-bot1 | <sb464f> thanks for the reviews : ) | 18:32 |
*** mikefix has quit IRC | 18:41 | |
airship-irc-bot1 | <ih616h> Could I get some reviews on this: | 18:47 |
airship-irc-bot1 | <ih616h> https://review.opendev.org/#/c/724937/ | 18:47 |
airship-irc-bot1 | <ih616h> it deadens a `time.Sleep` when unit testing | 18:47 |
openstackgerrit | Ian Pittwood proposed airship/docs master: [WIP] Add issue tracking conventions https://review.opendev.org/721361 | 19:07 |
openstackgerrit | Ian Pittwood proposed airship/docs master: Add issue tracking conventions https://review.opendev.org/721361 | 19:11 |
openstackgerrit | Merged airship/airshipctl master: Add a mockable Sleep method to redfish client https://review.opendev.org/724937 | 19:22 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Copyright Added/Updated with latest format https://review.opendev.org/725378 | 19:29 |
*** roman_g has quit IRC | 19:29 | |
*** roman_g has joined #airshipit | 19:54 | |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add Redfish SystemPowerOn/Off tests https://review.opendev.org/725388 | 20:45 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go https://review.opendev.org/725390 | 20:54 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests https://review.opendev.org/725366 | 20:55 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add state validation to Redfish shutdown/startup https://review.opendev.org/724928 | 20:55 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add Redfish SystemPowerOn/Off tests https://review.opendev.org/725388 | 20:55 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go https://review.opendev.org/725390 | 20:56 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Implement airshipctl config import https://review.opendev.org/717630 | 21:03 |
*** muhaha84 has quit IRC | 21:12 | |
*** muhaha has quit IRC | 21:12 | |
openstackgerrit | Sophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility https://review.opendev.org/725300 | 21:36 |
*** avolkov has quit IRC | 21:42 | |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Implement airshipctl config import https://review.opendev.org/717630 | 21:42 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration https://review.opendev.org/724506 | 21:55 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go https://review.opendev.org/725390 | 22:10 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface https://review.opendev.org/725140 | 22:14 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration https://review.opendev.org/724506 | 22:15 |
openstackgerrit | Ruslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment https://review.opendev.org/722621 | 22:38 |
openstackgerrit | Arvinderpal Wander proposed airship/airshipctl master: WIP: Adds support for `clusterctl move` of capi and bmo resources from ephermeral to workload cluster. https://review.opendev.org/724940 | 22:47 |
openstackgerrit | Sophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility https://review.opendev.org/725300 | 22:51 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration https://review.opendev.org/724506 | 23:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!