| *** uzumaki has joined #airshipit | 00:02 | |
| *** uzumaki has quit IRC | 01:19 | |
| *** uzumaki has joined #airshipit | 01:20 | |
| *** uzumaki has quit IRC | 06:59 | |
| *** uzumaki has joined #airshipit | 08:19 | |
| *** uzumaki has quit IRC | 09:03 | |
| *** uzumaki has joined #airshipit | 09:52 | |
| *** uzumaki has quit IRC | 10:05 | |
| *** uzumaki has joined #airshipit | 10:05 | |
| *** uzumaki has quit IRC | 14:07 | |
| airship-irc-bot | <alexander.hughes> team - Kostiantyn brings up a valid concern on https://review.opendev.org/c/airship/vino/+/768613/15/nodelabeler/Dockerfile#1 regarding the nodelabeler image for ViNO daemonset responsible for labeling the nodes with the VM bridge interface IP address. my initial thought is to move the Dockerfile to airship/images and update the build job to trigger on changes to vino/nodelabeler or to the Dockerfile itself in | 14:42 |
|---|---|---|
| airship-irc-bot | airship/images. In this way we could keep an updated nodelabeler image, and host it in Quay like our other images. I welcome alternative thoughts though | 14:42 |
| airship-irc-bot | <dwalt> Will this be updated frequently during ViNO development or largely stay the same? This might be something we want to consider hosting in airship/images so we can reuse it. | 14:57 |
| airship-irc-bot | <alexander.hughes> I'm not aware of any related node labeling stories on the horizon, I anticipate that once merged the nodelabeler go code and Dockerfile will remain static. The DaemonSet can be updated independently as needed | 14:59 |
| airship-irc-bot | <kk6740> Would it be possible to set up a trigger in quay to build the image on change? | 15:01 |
| airship-irc-bot | <kk6740> I think that may be faster way for us | 15:02 |
| airship-irc-bot | <alexander.hughes> I propose the build job via Zuul should go in whichever project houses the Dockerfile, with triggers on both the nodelabeler go Code and the nodelabeler Dockerfile for any changes. keeping both together simplifies the triggers and cross-repo dependency | 15:02 |
| airship-irc-bot | <dwalt> @kk6740 what do the Quay triggers use to build the images? | 15:58 |
| airship-irc-bot | <dwalt> I've been thinking about those recently too. I think it makes a lot of sense for us to reduce the code we maintain when we can | 15:58 |
| airship-irc-bot | <dwalt> The same `docker push` stuff that pushes to Quay is used by downstream consumers to publish images to private docker registries though. We should continue exercising that | 16:00 |
| airship-irc-bot | <kk6740> i dont remember all, but there is github and git integration | 16:00 |
| airship-irc-bot | <kk6740> good part about the quay build trigger, is that u dont need credentials stored inside the repository | 16:04 |
| airship-irc-bot | <kk6740> @dwalt i would suggest that for now at least, build and push the image manually to quay? | 16:14 |
| airship-irc-bot | <kk6740> so we can integrate it with daemonset that vino deploys | 16:14 |
| airship-irc-bot | <dwalt> That sounds good to me. The change looks good to me as-is, and we can always migrate the image to airship/images later | 16:15 |
| airship-irc-bot | <dwalt> I think some improvements are in order to that repository anyway. I believe that every image is built on every change right now. It takes over an hour for CI to run | 16:15 |
| airship-irc-bot | <alexander.hughes> Drew do you have Quay credentials to push directly? | 16:28 |
| airship-irc-bot | <dwalt> Yes, I can encrypt them for you | 16:29 |
| airship-irc-bot | <alexander.hughes> ok cool, thanks. looks like ViNO CI is still broken due to the charts/ deploy-k8s.sh script changes, do we want to just disable the job temporarily? | 16:31 |
| airship-irc-bot | <alexander.hughes> there's a work effort to put in place a permanent fix, but not ready yet | 16:31 |
| *** ianychoi_ has quit IRC | 18:46 | |
| airship-irc-bot | <pb269f> What's up with the script? | 19:13 |
| airship-irc-bot | <pb269f> Have a link for a job I can look at? | 19:13 |
| airship-irc-bot | <alexander.hughes> @pb269f failure https://zuul.opendev.org/t/openstack/build/b3dcda22a8ee4b9b85a5a0c7d40e8faa Kostiantyn is addressing in https://review.opendev.org/c/airship/vino/+/770155 to move a lighter version of the script into ViNO | 19:14 |
| airship-irc-bot | <pb269f> oh - thats easy | 19:15 |
| airship-irc-bot | <pb269f> you dont need to install docker before running the script :D | 19:15 |
| airship-irc-bot | <pb269f> your trying to do it twice | 19:15 |
| airship-irc-bot | <kk6740> https://review.opendev.org/c/airship/vino/+/770155/38/playbooks/integration-test.yaml | 19:15 |
| airship-irc-bot | <kk6740> being addressed as well | 19:16 |
| airship-irc-bot | <pb269f> i gave that feedback intitially when this script was brought in | 19:16 |
| airship-irc-bot | <pb269f> though ++ to forking and adding/removing what you want | 19:16 |
| airship-irc-bot | <pb269f> but id remove all those package installs, and the ensure-docker role as well if still present | 19:17 |
| airship-irc-bot | <pb269f> so you have a script that you know does all thats required for local dev etc | 19:17 |
| airship-irc-bot | <kk6740> docker is installed inside deploy-k8s script | 19:17 |
| airship-irc-bot | <pb269f> exactly | 19:17 |
| airship-irc-bot | <pb269f> if you want to use it, this is what you need - no more, no less: | 19:18 |
| airship-irc-bot | <pb269f> https://opendev.org/airship/charts/src/branch/master/playbooks/airship-setup.yaml | 19:19 |
| airship-irc-bot | <pb269f> and then the script will run without issue | 19:19 |
| airship-irc-bot | <pb269f> https://review.opendev.org/c/airship/vino/+/770155/38/playbooks/integration-test.yaml | 19:20 |
| airship-irc-bot | <pb269f> ^ here you were installing docker from ubuntu repos, and *then* clearing the firewall | 19:20 |
| airship-irc-bot | <pb269f> which would make it sad | 19:20 |
| airship-irc-bot | <pb269f> review'ed - wile the ensure-docker remains, the contents of that script wont work properly, no matter where located | 19:23 |
| airship-irc-bot | <kk6740> yea, dint notice that | 19:23 |
| airship-irc-bot | <pb269f> if you just remove that, the script works - we gate it pretty well | 19:24 |
| airship-irc-bot | <kk6740> well, imho the script looks like really fast moving target. i definitely support using single script to install k8s across all the envs, however in our case and given short timelines, it’s easier and faster to have it locally, at the same time we can switch at any time to using the script from charts repository. | 19:26 |
| airship-irc-bot | <pb269f> sure - it should be pretty stable, i made a few changes over the weekend, but other than adding behind the proxy support, i dont expect any major changes coming in | 19:27 |
| airship-irc-bot | <pb269f> remember - we gate it all, so any issues probably not as a result of it being broken ;) | 19:28 |
| airship-irc-bot | <kk6740> well, we were using the script | 19:28 |
| airship-irc-bot | <kk6740> and it was working | 19:28 |
| airship-irc-bot | <pb269f> by sheer luck | 19:28 |
| airship-irc-bot | <pb269f> as it stood, the docker daemon and cli would not have been happy | 19:29 |
| airship-irc-bot | <pb269f> eg any builds etc would have failed | 19:29 |
| airship-irc-bot | <pb269f> anyway - up to you | 19:29 |
| airship-irc-bot | <kk6740> :+1: | 19:30 |
| airship-irc-bot | <alexander.hughes> @kk6740 https://review.opendev.org/c/airship/vino/+/770155/38..40 is ensure docker supposed to be here? conflicting information in your response to Pete in the code vs what's in the commit msg | 20:23 |
| airship-irc-bot | <kk6740> yea, i wanted to delete it, but then i understood that i will need to alot of extra work to do , or call everything with sudo | 20:24 |
| airship-irc-bot | <kk6740> so i’ll add second patchset | 20:24 |
| airship-irc-bot | <kk6740> to get rid of docker installation from somewhere, either from script or from the playbook | 20:25 |
| airship-irc-bot | <alexander.hughes> oh with the group setup | 20:25 |
| airship-irc-bot | <kk6740> yes, ansible allows to drop the connection and relogin, which is done in ensure_docker role | 20:25 |
| airship-irc-bot | <alexander.hughes> gotcha | 20:25 |
| airship-irc-bot | <kk6740> script does work without ensure docker without any problems but we fail further when trying to build an image | 20:26 |
| *** rezroo has joined #airshipit | 22:40 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!