| airship-irc-bot | <ao129q> May I have another +2 here please https://review.opendev.org/c/airship/treasuremap/+/789480 | 01:31 |
|---|---|---|
| *** jhesketh has quit IRC | 06:28 | |
| *** jhesketh has joined #airshipit | 09:01 | |
| *** uzumaki has joined #airshipit | 12:08 | |
| airship-irc-bot | <sirishagopigiri> Hi Team, Requesting some reviews on the below PSs related to #280 https://review.opendev.org/c/airship/airshipctl/+/786629 https://review.opendev.org/c/airship/airshipctl/+/790003 https://review.opendev.org/c/airship/airshipctl/+/790020 https://review.opendev.org/c/airship/airshipctl/+/790023 https://review.opendev.org/c/airship/airshipctl/+/790026 Mostly the PSs are related to documentation changing the description | 13:25 |
| airship-irc-bot | for the commands and adding examples. No much go code involved. Thank you in advance! | 13:25 |
| airship-irc-bot | <sirishagopigiri> Hi team, requesting another +2 and WF+1 on this PS https://review.opendev.org/c/airship/charts/+/780846 and some reviews on this https://review.opendev.org/c/airship/treasuremap/+/788289 (related to treasuremap issue #27) thank you in advance! | 13:26 |
| airship-irc-bot | <ao129q> @mattmceuen what are our expectations on hwcc? I see https://review.opendev.org/c/airship/treasuremap/+/788548 and guessing it had issue in 2.0, but afaik they were fixed in master | 17:54 |
| airship-irc-bot | <ao129q> and i did not have issues with it in other places | 17:55 |
| airship-irc-bot | <mattmceuen> @ao129q you may not have had issues with it in other places, but you didn't use it for anything productive in other cases either :slightly_smiling_face: | 17:56 |
| airship-irc-bot | <ao129q> right | 17:56 |
| airship-irc-bot | <mattmceuen> The idea of taking it out of the type definitions was, "it's having problems and we're not using it; let's take it out and then add it back in once we know what we want to do with it" | 17:56 |
| airship-irc-bot | <mattmceuen> less risk that way | 17:56 |
| airship-irc-bot | <ao129q> good to me | 17:56 |
| airship-irc-bot | <ao129q> thx | 17:56 |
| *** srwilkers has quit IRC | 18:30 | |
| *** rpioso has quit IRC | 18:31 | |
| *** srwilkers has joined #airshipit | 18:35 | |
| *** rpioso has joined #airshipit | 18:35 | |
| *** raildo has joined #airshipit | 20:07 | |
| *** raildo_ has joined #airshipit | 20:49 | |
| *** raildo has quit IRC | 20:52 | |
| *** thansen has quit IRC | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!