Tuesday, 2021-05-11

*** muhaha has joined #airshipit07:19
*** muhaha has quit IRC08:17
*** avolkov has joined #airshipit09:21
airship-irc-bot1<scnp89> Hi Team, Requesting reviews on this https://review.opendev.org/c/airship/treasuremap/+/789981 (related to Treasuremap issue  #111). Thank you in advance12:59
airship-irc-bot1<sirishagopigiri> Hi team, Requesting some reviews on the below PS https://review.opendev.org/c/airship/treasuremap/+/788289 (related to treasuremap issue #27) thank you in advance!13:07
airship-irc-bot1<ratnopam.chakrabarti> Hi Team, requesting core reviews on https://review.opendev.org/c/airship/airshipctl/+/789640 - Clusterctl move validate logic update and https://review.opendev.org/c/airship/airshipctl/+/789639 - GCP site manifests updates to pass validate_docs with kube-val. These are related to issues #503 and #528. Thanks!13:12
airship-irc-bot1<mattmceuen> Hi all, GM - I forgot to check the agenda yesterday and send out a cancellation for our IRC/Slack meeting if it's empty14:00
airship-irc-bot1<mattmceuen> It's empty :slightly_smiling_face:  does anyone have anything they'd like to discuss, or should I go ahead and cancel?14:00
airship-irc-bot1<mattmceuen> Cancellation sent!14:02
airship-irc-bot1<mf4716> Thanks @mattmceuen - only item I wanted to circle back on was the discussion pre-PTG about instituting possible best practices for patch-set aging.  It can wait for the next IRC.  Make it a great day!14:04
*** muhaha has joined #airshipit14:21
*** happyhemant has joined #airshipit14:24
airship-irc-bot1<sidney.shiba> Hi Core reviewers, could you please review the following PS related to Dex? • https://review.opendev.org/c/airship/treasuremap/+/78899114:31
airship-irc-bot1<ao129q> may we have another +2 here please https://review.opendev.org/c/airship/airshipctl/+/79052914:53
airship-irc-bot1<sa069q> Hi Team, can I have some reviews on https://review.opendev.org/c/airship/treasuremap/+/790420/2 Very small change to use existing Dex implementation in treasuremap for SIP15:53
*** muhaha has quit IRC16:16
airship-irc-bot1<sirishagopigiri> Hi Team, Requesting some reviews on the below PSs related to #280 https://review.opendev.org/c/airship/airshipctl/+/790020 https://review.opendev.org/c/airship/airshipctl/+/790023 https://review.opendev.org/c/airship/airshipctl/+/790026 https://review.opendev.org/c/airship/airshipctl/+/790033 https://review.opendev.org/c/airship/airshipctl/+/789250 https://review.opendev.org/c/airship/airshipctl/+/786838 Most of the PSs are16:33
airship-irc-bot1related to documentation changing the description for the commands and adding examples. Thank you in advance!16:33
*** muhaha has joined #airshipit17:54
airship-irc-bot1<madhukar> I’ve got a few questions around KRM functions in kustomize, Are KRM functions not run during `kustomize build`. Are they supposed to be run separately to generate resources, and then applied later?18:03
*** muhaha has quit IRC18:06
airship-irc-bot1<mf4192> Hi team, requesting reviews for #537 to functionalize metal3 worker definition. Comments have been addressed and passed gates a little while ago18:07
airship-irc-bot1<mf4192> https://review.opendev.org/c/airship/airshipctl/+/77893118:07
*** happyhemant has quit IRC18:23
airship-irc-bot1<sidney.shiba> Hi all, I am trying to add elements to a list with kustomize but instead it is replacing with the patched elements. The objective is to add elements to `spec.configSpec,files` and `spec.configSpec.commands`:  `apiVersion: mycustomresource.cluster.x-k8s.io/v1alpha3` `kind: MyCustomResourse` `metadata:`   `name: mycustomresource` `spec:`   `configSpec:`     `files:`     `- content: |`         `[Service]`19:53
airship-irc-bot1`Environment="HTTP_PROXY=REPLACEMENT_HTTP_PROXY"`         `Environment="HTTPS_PROXY=REPLACEMENT_HTTPS_PROXY"`         `Environment="NO_PROXY=REPLACEMENT_NO_PROXY"`       `path: "/etc/systemd/system/docker.service.d/http-proxy.conf"`     `commands:`     `- export HOME=/root`     `- systemctl daemon-reload`     `- systemctl restart docker`  The patch used is listed below: `apiVersion: mycustomresource.cluster.x-k8s.io/v1alpha3` `kind:19:53
airship-irc-bot1MyCustomResourse` `metadata:`   `name: mycustomresource` `spec:`   `configSpec:`     `files:`     `- contentFrom:`         `secret:`           `key: tls.crt`           `name: ca-cert-secret`       `owner: root:root`       `path: /etc/kubernetes/certs/ca-cert`       `permissions: "0644"`     `commands:`     `- echo '10.10.25.100 my.test.local' | tee -a /etc/hosts`  And the kustomization.yaml file used can be found below: `apiVersion:19:53
airship-irc-bot1kustomize.config.k8s.io/v1beta1` `kind: Kustomization` `resources:` `- ./custom-resource.yaml`  `patchesStrategicMerge:` `- ./patch-add.yaml`  What am I missing?19:53
*** rpioso has quit IRC20:09
*** srwilkers has quit IRC20:09
*** rpioso has joined #airshipit20:13
*** srwilkers has joined #airshipit20:13
*** avolkov has quit IRC20:41
*** avolkov has joined #airshipit20:47
airship-irc-bot1<sirajudeen.yasin> @sidney.shiba, but then you are trying to replace the files and commands21:46
airship-irc-bot1<sirajudeen.yasin> may be you can try this format patchesJson690221:47
airship-irc-bot1<sirajudeen.yasin> https://skryvets.com/blog/2019/05/15/kubernetes-kustomize-json-patches-6902#operations21:49
airship-irc-bot1<sidney.shiba> I have it running with patchesJson6902 but need instead patchesStrategicMerge so I can update some values of the yaml patches using the replacement transformer prior to applying this patch.21:49
airship-irc-bot1<sirajudeen.yasin> with operation add21:49
airship-irc-bot1<sirajudeen.yasin> oh ok21:50
airship-irc-bot1<sirajudeen.yasin> so you want to use patch as well as replacement transformer ?21:50
airship-irc-bot1<sidney.shiba> As indicated in the other thread, I am looking for the patchesStrategicMerge alternative so I can use Replacement transformer to the patch.21:52
airship-irc-bot1<sirajudeen.yasin> ok21:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!