| -opendevstatus- NOTICE: Our Zuul gating CI/CD services will be offline starting around 14:00 UTC (in roughly two hours from now) in order to apply some critical security updates, and is not expected to remain offline for more than 30 minutes. | 12:00 | |
| airship-irc-bot | <sirishagopigiri> Hi Team, requesting another +2 and WF +1 on the below PS related to airshipctl issue #280 https://review.opendev.org/c/airship/airshipctl/+/789250 Thank you in advance! | 12:47 |
|---|---|---|
| -opendevstatus- NOTICE: Our Zuul gating CI/CD services are being taken offline now in order to apply some critical security updates, and are not expected to remain offline for more than 30 minutes. | 13:55 | |
| airship-irc-bot | <sb048x> Team, Requesting reviews on https://review.opendev.org/c/airship/treasuremap/+/793592/ https://review.opendev.org/c/airship/treasuremap/+/795527/ Changes in Dex for sub-clusters | 14:27 |
| airship-irc-bot | <vetbijaya> Hi Team, need one more +2 and workflow on this PS related to adding flags on cluster getkubeconfig cmd: https://review.opendev.org/c/airship/airshipctl/+/784111 Thanks in advance. | 15:52 |
| airship-irc-bot | <ma257n> > Hello All, Could you please provide me review comments on my AIAP manifest location change PS. https://review.opendev.org/c/airship/airshipctl/+/783533 Thanks in advance, | 15:57 |
| airship-irc-bot | <gs909v> Hi team, could you please provide reviews for clustermap validation: https://review.opendev.org/c/airship/airshipctl/+/795343 | 17:05 |
| airship-irc-bot | <sirajudeen.yasin> Hi Team, Can i request some reviews for this PS https://review.opendev.org/c/airship/treasuremap/+/795703 => Uplift airshipctl to stable version in treasuremap validate_docs issue with airshipctl uplift: validate_docs in treasuremap is passing only for test-site. Need suggestions from team. My options: 1) Either we make it as non-voting and get the uplift merged and fix other sites. Fixing validate_docs for other sites | 17:46 |
| airship-irc-bot | requires implementing the site/type specific plan (deploy-gating). 2) invoke validate_docs only for the specific site instead of always validating all sites. To implement this we can remove the separate validate_docs job in zuul and invoke ./tools/validate_docs <site_name> as an additional step in the site specific gate runner (deployment) job before running image_build. | 17:46 |
| airship-irc-bot | <raliev> @sirajudeen.yasin what's the problem with validating other sites? I downloaded your patch and was able to successfully validate reference-airship-core and test-site at least | 18:08 |
| airship-irc-bot | <sirajudeen.yasin> @raliev,they both inherit same type airship-core, so those two sites might work and not the other sites. I will double check and confirm | 18:11 |
| airship-irc-bot | <sirajudeen.yasin> I will also re-run for all sites, I had issues initially with multi-tenant type. is the plan run deploy-gating implemented for all sites in treasuremap ? | 18:21 |
| airship-irc-bot | <raliev> just verified multi-tenant. no issues with deploy-gating | 18:22 |
| airship-irc-bot | <sirajudeen.yasin> i see the work for phas eplan for multi-tenant is still in progress https://review.opendev.org/c/airship/treasuremap/+/796028 | 18:23 |
| airship-irc-bot | <sirajudeen.yasin> anyway if it is minor tweeks for other sites.. i will ammed my PS and proceed | 18:24 |
| airship-irc-bot | <raliev> ```[airshipctl] 2021/06/24 13:21:11 validating phase: controlplane-target error creating new loader with git: uri looks like abs path: /root/src/treasuremap/manifests/site/virtual-network-cloud/target/controlplane, dir: evalsymlink failure on '/root/src/treasuremap/manifests/site/virtual-network-cloud/target/controlplane' : lstat /root/src/treasuremap/manifests/site/virtual-network-cloud/target/controlplane: no such file or directory, | 18:25 |
| airship-irc-bot | get: invalid source string: /root/src/treasuremap/manifests/site/virtual-network-cloud/target/controlplane``` if it's expected - we can just patch the default plan and remove controlplane-ephemeral phase from there | 18:25 |
| airship-irc-bot | <raliev> but I believe we need it... | 18:25 |
| airship-irc-bot | <raliev> regarding multi-tenant site, there is just one minor tweak required in iso plan, I'll show you | 18:26 |
| airship-irc-bot | <sirajudeen.yasin> BaremetalHost ? | 18:26 |
| airship-irc-bot | <raliev> yes | 18:26 |
| airship-irc-bot | <raliev> ```diff --git a/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml b/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml index e88f98a..b0542dc 100644 --- a/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml +++ b/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml @@ -20,3 +20,10 @@ status: # when we have more flexible labeling | 18:27 |
| airship-irc-bot | system in place, we will not # deliver this document to ephemeral cluster state: externally provisioned + ID: "" + operationHistory: {} + errorMessage: "" + hardwareProfile: "" + operationalStatus: "" + poweredOn: false +``` | 18:27 |
| airship-irc-bot | <sirajudeen.yasin> i have that change in local.. will push it | 18:27 |
| airship-irc-bot | <sirajudeen.yasin> My assumption was that the plan run for each site/type will be a separate work and till that time the validation will break without specific plan patch.. but if it works i will adjust the PS to validate all sites | 18:29 |
| airship-irc-bot | <raliev> @sirajudeen.yasin with these changes I was able to successfully verify all sites in TM: ```root@ubuntu-airship:~/src/treasuremap# git diff diff --git a/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml b/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml index e88f98a..b0542dc 100644 --- a/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml +++ | 18:53 |
| airship-irc-bot | b/manifests/site/reference-multi-tenant/ephemeral/bootstrap/baremetalhost.yaml @@ -20,3 +20,10 @@ status: # when we have more flexible labeling system in place, we will not # deliver this document to ephemeral cluster state: externally provisioned + ID: "" + operationHistory: {} + errorMessage: "" + hardwareProfile: "" + operationalStatus: "" + poweredOn: false + diff --git | 18:53 |
| airship-irc-bot | a/manifests/site/virtual-network-cloud/phases/kustomization.yaml b/manifests/site/virtual-network-cloud/phases/kustomization.yaml index aaa757c..324f3bb 100644 --- a/manifests/site/virtual-network-cloud/phases/kustomization.yaml +++ b/manifests/site/virtual-network-cloud/phases/kustomization.yaml @@ -1,6 +1,6 @@ resources: - ../kubeconfig - - ../../../type/multi-tenant/phases + - ../../../type/airship-core/phases ## TODO Consider making | 18:53 |
| airship-irc-bot | a catalogue combined with variable substitution instead patchesStrategicMerge: - phase-patch.yaml diff --git a/tools/validate_docs b/tools/validate_docs index e153b88..20c44ba 100755 --- a/tools/validate_docs +++ b/tools/validate_docs @@ -26,11 +26,5 @@ export MANIFEST_REPO_URL=$MANIFEST_REPO_URL cd ${AIRSHIPCTL_PROJECT} -# Validate only specific site if set -if [ ! -z "$1" ]; then - ./tools/validate_docs $1 -else - | 18:53 |
| airship-irc-bot | ./tools/validate_docs -fi - +./tools/validate_docs "$@"``` | 18:53 |
| airship-irc-bot | <raliev> I can upload them to your commit if you want... | 18:54 |
| airship-irc-bot | <sirajudeen.yasin> Thanks Ruslan.. I will watch the current zuul run and will update the PS as suggested by you | 18:55 |
| airship-irc-bot | <ao129q> may we have review here please https://review.opendev.org/c/airship/airshipctl/+/797370/ | 20:11 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!