| airship-irc-bot | <aodinokov> Seems like even though we've merged https://review.opendev.org/c/airship/airshipctl/+/797358/8/pkg/api/v1alpha1/templater_plugin_types.go the templater is still working with the previous implementation... Because we're building it as a separate module and referencing OLD airshipctl https://github.com/airshipit/airshipctl/blob/master/krm-functions/templater/image/go.mod the same for replacement transformer | 06:48 |
|---|---|---|
| airship-irc-bot | https://github.com/airshipit/airshipctl/blob/master/krm-functions/replacement-transformer/image/go.mod That means that if you modifying any part related to templater or replacement transformer - it's necessary to do 2 commits. The second must be done after the first is merged and it must contain new go.mod. This is a good example that shows that it was not a really good idea - build it as a separate module. I think this is going to be repeated | 06:48 |
| airship-irc-bot | in future. I want to move that 2 krm-functions back to build as part of airshipctl module to prevent that. | 06:48 |
| airship-irc-bot | <sb048x> Team, can we have reviews please on https://review.opendev.org/c/airship/treasuremap/+/793592/ https://review.opendev.org/c/airship/treasuremap/+/795527/ https://review.opendev.org/c/airship/treasuremap/+/797340/ Changes in Dex for sub-clusters | 13:32 |
| airship-irc-bot | <vetbijaya> can I also get some review comments on this PS related to plan status cmd: https://review.opendev.org/c/airship/airshipctl/+/772890 Thank you in advance! | 14:37 |
| airship-irc-bot | <ratnopam.chakrabarti> Hi Team, can I get some reviews on https://review.opendev.org/c/airship/airshipctl/+/795319. This is to fix CAPD zuul gate failure and other issues related to phasePlan. Thanks in advance. | 14:59 |
| airship-irc-bot | <ao129q> folks! need another +2 https://review.opendev.org/c/airship/treasuremap/+/798258/ and https://review.opendev.org/c/airship/treasuremap/+/797471/ | 16:35 |
| airship-irc-bot | <ao129q> thanks in advance! | 16:35 |
| airship-irc-bot | <sidney.shiba> Hi Team, can you please review https://review.opendev.org/c/airship/charts/+/798919. I found a bug when id_token expires (kubeconfig generated by dex-aio), the refresh token needed an IDP certificate, which is provided by this fix. | 16:38 |
| airship-irc-bot | <sidney.shiba> Hi Team, Is there a problem with the latest `treasuremap` (`master`) and/or `airshipctl` (`1e8f31a160016a71c454507e529620e837efea78`) combo? When executing `airshipctl plan list` or a `airshipctl phase render` command I get this error: `unable to find one of 'kustomization.yaml', 'kustomization.yml' or 'Kustomization' in directory '/home/ubuntu/projects/treasuremap'`. Is there something I have to do to get it work? | 19:34 |
| airship-irc-bot | <ratnopam.chakrabarti> @sidney.shiba, I had encountered this error in airshipctl(not in treasuremap). I had to take latest airshipctl and rebuild with 21_system_executables script. | 19:46 |
| airship-irc-bot | <sidney.shiba> Hi Core team, could you please review https://review.opendev.org/c/airship/treasuremap/+/796949. It is just one file and one line. It should be a breeze to review it. | 21:23 |
| airship-irc-bot | <sidney.shiba> Hi core team, back to square zero due to merge conflict. Could you please review https://review.opendev.org/c/airship/treasuremap/+/796949. It is just one file and one line. Should be a breeze review. | 23:20 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!