| *** karimb has quit IRC | 00:10 | |
| *** karimb has joined #ara | 01:00 | |
| *** karimb has quit IRC | 01:51 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Don't query for hosts and playbooks on every page https://review.openstack.org/435713 | 15:23 |
|---|---|---|
| dmsimard | andymccr: re: https://review.openstack.org/#/c/433055/ | 15:46 |
| dmsimard | I misread it during the review but the variable name is actually value_type ? https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py | 15:46 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: The kwarg for Ansible 2.3's get_config is actually value_type https://review.openstack.org/435717 | 15:52 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: The kwarg for Ansible 2.3's get_config is actually value_type https://review.openstack.org/435717 | 15:57 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: WIP: Support generating html or junit for one or many specific playbooks https://review.openstack.org/435719 | 16:02 |
| *** themurph_ has joined #ara | 19:08 | |
| *** themurph has quit IRC | 19:08 | |
| andymccr | ahh dmsimard - i had it on a test env and must've dyslexia'd that one up when i converted it over :( | 20:52 |
| andymccr | dmsimard: maybe we should setup a test using ansible@devel that is non-voting? that'd bring up issues similar to this (and work when they are fixed!) | 20:54 |
| andymccr | ahh but i guess theyre uint tests and dont integrate with ansible | 20:58 |
| andymccr | i suppose just having the func tests for OSA (or other) would be good enough | 20:59 |
| dmsimard | andymccr: well, in the past I wanted to run Ansible's own integration tests ( https://github.com/ansible/ansible/tree/devel/test/integration ) but there's actually a lot of them and most are not super relevant so we wrote our own limited smoke-ish integration tests | 21:00 |
| dmsimard | I think with the embedded integration/unit tests and OSA the coverage should be pretty good | 21:01 |
| andymccr | ahh wait you do install ansible in the run_tests | 21:01 |
| andymccr | but yeah that would work - sorry for the mixup on that var though! | 21:02 |
| dmsimard | yeah, we have an integration job that installs latest from 2.1.x and whatever is latest | 21:02 |
| dmsimard | once 2.3 is out, I'll create a job for 2.2.x and leave latest there so it picks up 2.3 | 21:02 |
| dmsimard | no worries | 21:02 |
| dmsimard | I wonder how reliable @devel would be, would definitely leave it non voting but it's definitely not very stable | 21:05 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: WIP: Support generating html or junit for one or many specific playbooks https://review.openstack.org/435719 | 22:09 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!