| dmsimard | wkid: hey did you end up figuring it out ? I'm curious :D | 02:08 |
|---|---|---|
| openstackgerrit | Vieri proposed openstack/ara-server master: fix tox python3 overrides https://review.openstack.org/605316 | 03:03 |
| *** apollo13 has joined #ara | 08:40 | |
| apollo13 | hi there, is there any way to run ara without direct access to a database? like an append only rest api? | 08:40 |
| apollo13 | mhm, nope the code seems to be rather clear :D | 08:41 |
| apollo13 | I am getting this warning: https://dpaste.de/1FqL/raw and unlogged entries. is this worth reporting or is 3.6 unsupported completly? it only happens for some tasks… | 09:04 |
| dmsimard | apollo13: (sorry just woke up) | 11:42 |
| dmsimard | This looks like a module-specific issue | 11:42 |
| apollo13 | dmsimard: no worries, it is not like I am paying you for anything! | 11:42 |
| apollo13 | the module is django_manage | 11:43 |
| dmsimard | It returns data structured in a way that's not expected | 11:43 |
| dmsimard | Or at least that's what it looks like | 11:43 |
| apollo13 | https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/web_infrastructure/django_manage.py it is; if you tell me what I need to debug I'll happily do that | 11:44 |
| apollo13 | maybe tuple on https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/web_infrastructure/django_manage.py#L304 works? | 11:44 |
| apollo13 | or rather 2 lines above call tuple instead of list | 11:44 |
| dmsimard | Changed is supposed to be a boolean ? | 11:45 |
| apollo13 | is it? | 11:46 |
| dmsimard | I can look later after properly waking up | 11:46 |
| apollo13 | I'll "bool()" changed for now and see if that fixes it | 11:46 |
| apollo13 | sure, take your time. I'll lurk around | 11:46 |
| dmsimard | https://github.com/openstack/ara/blob/master/ara/models.py#L377 | 11:47 |
| apollo13 | well yes, in ara; was wondering about ansible | 11:47 |
| apollo13 | but looks to be the idea | 11:48 |
| apollo13 | I'll propose a bug fix to ansible | 11:48 |
| dmsimard | Well the variable is supposed to be a bool, but I guess Ansible doesn't enforce it | 11:48 |
| apollo13 | the question is where to fix it | 11:49 |
| apollo13 | if ansible doesn't enfore it, it would make sense for ara to bool() it | 11:49 |
| apollo13 | or change ansible to ensure it is bool | 11:49 |
| apollo13 | or just fix the django module | 11:49 |
| apollo13 | let me ask in #ansible-devel | 11:49 |
| dmsimard | From ARA's perspective, we can coerce it to bool I guess, but it's not exactly accurate | 11:50 |
| apollo13 | well if the field is required to be bool in the database, it seems like a sensible "defensive coding" change | 11:50 |
| dmsimard | Like that module would always return changed trur | 11:50 |
| dmsimard | true* | 11:51 |
| dmsimard | Despite what actually happened | 11:51 |
| apollo13 | why would it always return true? | 11:51 |
| apollo13 | https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/web_infrastructure/django_manage.py#L297 sets changed to false initially | 11:51 |
| dmsimard | In python as soon as there is a string, it's true | 11:51 |
| apollo13 | bool([]) would be false | 11:51 |
| dmsimard | Ah, I didn't check what happened before | 11:51 |
| apollo13 | well I guess it depends on what exactly ends up in filtered_output in the end | 11:52 |
| dmsimard | Anyway, django_manage needs to properly return a bool there and the results in a msg field or something like that | 11:52 |
| dmsimard | You can carry a patched version of the module in your role/etc to test | 11:53 |
| apollo13 | yeah, I know how to do that, just wanted to so if that is something you wanted to fix either way | 11:53 |
| apollo13 | https://github.com/ansible/ansible/pull/46157 | 12:09 |
| apollo13 | dmsimard: lets see, ansible will probably accept my PR. that said; what would you fine folks think about adding a rest API to ara for the plugins? I rather not expose my database directly :/ | 12:19 |
| dmsimard | apollo13: you mean something like this? https://demo.getara.org/api/v1/ :p | 12:41 |
| apollo13 | dmsimard: and a callback that submits to that, yes | 12:41 |
| dmsimard | apollo13: it exists | 12:42 |
| dmsimard | apollo13: it's called ara 1.0 | 12:42 |
| apollo13 | ah cool | 12:42 |
| dmsimard | it's not quite ready yet, but it's getting there | 12:42 |
| dmsimard | https://github.com/openstack/ara-server | 12:43 |
| dmsimard | https://github.com/openstack/ara-clients | 12:43 |
| dmsimard | https://github.com/openstack/ara-plugins | 12:43 |
| apollo13 | sorry for the noise then :) | 12:43 |
| dmsimard | np, depending on what you are working on, it's probably ready to be used in some capacity but consider it beta | 12:44 |
| dmsimard | there is no frontend with feature parity yet | 12:44 |
| dmsimard | it's essentially a complete rewrite | 12:44 |
| apollo13 | mhm, I'd like to work on a django project again | 12:45 |
| apollo13 | I'll dig into the code if I find time | 12:46 |
| dmsimard | apollo13: neat, always excited to get some help, let me know if you have questions | 12:55 |
| apollo13 | dmsimard: well most importantly, which timezone are you in so I know when I can sync up with you. I'll probably will have question about the main ideas etc… (I am a django core dev, so I'll be fine with the code; but I do not know what your ideas/goals are) | 13:02 |
| dmsimard | eastern time zone in north america | 13:03 |
| dmsimard | i.e, it was 4:40AM when you started writing here :p | 13:03 |
| apollo13 | good, so in about 3 hours when I am at home begins to start being a good time for you :þ | 13:04 |
| dmsimard | apollo13: your skills in django would be quite useful, I am but a sysadmin/ops person who tries his best :) | 13:04 |
| dmsimard | well I am usually available right about now, before that I'm either waking up or sending kids to school etc | 13:04 |
| apollo13 | perfect | 13:05 |
| dmsimard | apollo13: if you happen to be at ansiblefest next week, we can chat | 13:07 |
| dmsimard | I'll bring ara stickers too. :D | 13:07 |
| apollo13 | I am in austria :/ | 13:07 |
| *** sshnaidm is now known as sshnaidm|mtg | 13:07 | |
| apollo13 | and america is currently a no-go area for me :/ | 13:07 |
| dmsimard | ouch | 13:08 |
| dmsimard | Well I'm from Canada and even for me it's almost risky to go with the current political climate ? :( | 13:08 |
| apollo13 | dmsimard: mhm, lets say I am interested; how much breakage can you deal with before you kick me out? :D | 13:15 |
| apollo13 | as in update it to what I would expect django code to look like | 13:15 |
| dmsimard | apollo13: I'm by no means an expert at django, I would defer to gvincent for reviews | 13:16 |
| apollo13 | ok, I'll hack around and open a PR :) | 13:16 |
| dmsimard | apollo13: 1.0 is not released yet and we are allowing ourselves to break backwards compatibility -- there's no one using it yet | 13:16 |
| gvincent | :D | 13:16 |
| dmsimard | if we want to break things, it's now | 13:16 |
| apollo13 | not backwards compat, just code overhaul :) | 13:17 |
| dmsimard | apollo13: no but I mean, ara 0.x and ara 1.0 are vastly different | 13:17 |
| apollo13 | yeah, got that | 13:17 |
| apollo13 | ok, I'll start hacking away | 13:17 |
| apollo13 | btw what are your thoughts on using black? | 13:17 |
| dmsimard | apollo13: openstack projects don't use github pull requests though, I can walk you through the gerrit workflow -- it takes a few minutes to jump through some hoops once and then you're good to go | 13:18 |
| dmsimard | black ? :/ | 13:18 |
| apollo13 | mhm, I "know" gerrit from qt; but yeah a short walk through would certainly help | 13:18 |
| apollo13 | https://github.com/ambv/black | 13:19 |
| dmsimard | this is the first I've heard of it, it looks interesting | 13:19 |
| apollo13 | it might be especially useful for a new project | 13:20 |
| dmsimard | I would prefer an approach where we run an integration job with black instead of pre-commit hooks | 13:21 |
| dmsimard | but otherwise happy to give it a try | 13:22 |
| apollo13 | oh yes, forget the pre-commit hooks, I am also using it as part of CI | 13:22 |
| dmsimard | apollo13: https://ara.readthedocs.io/en/stable/contributing.html should be a good starting point for submitting patches -- tl;dr, 1) Have a launchpad account ( https://login.launchpad.net/+login ) 2) Sign in to gerrit (top right https://review.openstack.org/ ) 3) Set up your public ssh key in gerrit 4) hack your patch 5) send it with "git review" (there are distro packages for it or it can be installed with pip) | 13:27 |
| dmsimard | thankfully steps 1 through 3 only need to be done once, after that it's pretty straightforward | 13:28 |
| dmsimard | and then a patch looks like this in practice https://review.openstack.org/#/c/602049/ | 13:28 |
| dmsimard | we're able to manage our own unit and integration jobs and the jobs themselves even have ara reports :D http://logs.openstack.org/49/602049/1/check/ara-server-ansible-integration/f54302d/ara-report/ | 13:29 |
| dmsimard | Since the CI system, Zuul, actually has you write your jobs as ansible roles and playbooks and has ara enabled | 13:29 |
| apollo13 | nice | 13:30 |
| apollo13 | are there docs for zuul? | 13:30 |
| apollo13 | I do not really understand the jobs.yaml and project.yaml yet :) | 13:30 |
| apollo13 | https://zuul-ci.org/ this one? | 13:31 |
| dmsimard | yeah | 13:31 |
| apollo13 | ok, let me RTFM | 13:31 |
| dmsimard | ok, see you in a month | 13:31 |
| dmsimard | haha | 13:31 |
| apollo13 | Invalid SSH Key, I so hate gerrit | 13:31 |
| apollo13 | lets try rsa *shrug* | 13:32 |
| dmsimard | you might need to set something in your .ssh/config | 13:32 |
| dmsimard | because if your local ssh user is "apollo13" and your gerrit user is "foo", it's going to try and authenticate as appolo13@review.openstack.org instead of foo | 13:32 |
| apollo13 | dmsimard: no worries, I will manage :) | 13:32 |
| dmsimard | ++ | 13:33 |
| dmsimard | I'll clean some things up that might not be up to date in the readme/docs/etc | 13:35 |
| dmsimard | apollo13: there's some great talks about zuul if you're into that | 13:39 |
| apollo13 | mhm what is my gerrit username? | 13:40 |
| apollo13 | ah I have to set one :D | 13:41 |
| dmsimard | apollo13: once you're logged in to gerrit, click on your name at the top right and then settings | 13:41 |
| dmsimard | it's the first field | 13:41 |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Small cleanups for django best practices. https://review.openstack.org/605421 | 13:44 |
| dmsimard | well there you go | 13:44 |
| dmsimard | apollo13: FWIW authentication/permissions/administration/rbac/acl are things that have so far been an afterthought | 13:45 |
| dmsimard | apollo13: any implementation of such things that are currently in the code is likely because it was copy/paste from gvincent's template | 13:46 |
| apollo13 | ok, should there be a link to the CI run somewhere? | 13:47 |
| dmsimard | By that, I mean that the only thing that django is used for currently is for the API (django-rest-framework) | 13:47 |
| dmsimard | and that the API is currently 100% open | 13:47 |
| dmsimard | apollo13: it only posts the link once it's finished running, you can look at queued or in-progress jobs at http://zuul.openstack.org/ if need be | 13:47 |
| dmsimard | you can write ara-server in the filter box | 13:48 |
| dmsimard | https://i.imgur.com/sBwqjJe.png | 13:49 |
| dmsimard | zuul has a component called nodepool which creates and destroys single-purpose VMs for every job -- when something is queued, it means the job is waiting for a node to be allocated to it | 13:49 |
| apollo13 | okay, so I understand project.yaml now; how does it select the node? or what do the nodes run? ubuntu, something? | 13:50 |
| apollo13 | or is that specified by parent: tox | 13:50 |
| dmsimard | in https://github.com/openstack/ara/blob/master/zuul.d/jobs.yaml you'll see nodesetsz | 13:50 |
| dmsimard | nodesets* | 13:50 |
| dmsimard | apollo13: https://review.openstack.org/#/c/557933 is an example of setting things up from scratch | 13:51 |
| dmsimard | those jobs are failing but hopefully it gives you a good idea of how it works | 13:51 |
| dmsimard | That project, ansible-role-ara, doesn't actually have any jobs set up right now | 13:52 |
| dmsimard | I sent a patch to add jobs, they're not merged, but zuul loaded the config from the patch and ran things speculatively | 13:52 |
| dmsimard | so it allows to experiment and iterate without needing to merge things | 13:52 |
| apollo13 | ok but how does ara-server currently select the nodes to run on? | 13:52 |
| apollo13 | I see no nodeset or anything | 13:53 |
| dmsimard | oh, sorry, I linked ara | 13:53 |
| apollo13 | nor a tox parent | 13:53 |
| apollo13 | ah | 13:53 |
| apollo13 | my bad | 13:53 |
| dmsimard | right | 13:53 |
| dmsimard | ara-server doesn't specify any nodeset | 13:53 |
| dmsimard | so it takes whatever is the nodeset inherited by the parent jobs | 13:53 |
| apollo13 | and where is this tox parent specified? | 13:54 |
| dmsimard | in this case it'd be ubuntu | 13:54 |
| dmsimard | sec | 13:55 |
| *** themurph has joined #ara | 13:59 | |
| dmsimard | tristanC: do you know when the zuul UI refactor will land ? | 14:00 |
| dmsimard | tristanC: I don't know if the job graph was part of it ? i.e, how to tell where a job was coming from | 14:00 |
| dmsimard | apollo13: there's no great UI for it (yet) but another thing that zuul does is that the configuration is actually dynamically aggregated from all the projects it manages | 14:01 |
| dmsimard | apollo13: the idea is that if a project defines a job, I can use it too without having to duplicate it | 14:02 |
| dmsimard | tox-py35 and tox-pep8 come from https://github.com/openstack-infra/zuul-jobs/blob/master/zuul.yaml | 14:02 |
| dmsimard | I don't see nodeset definitions there, so it means it's actually picking the nodeset up to the base job which is inherited by default | 14:02 |
| apollo13 | ok, that gives me stuff to read into, maybe I can integrate flake8/isort/black :) | 14:03 |
| dmsimard | and the base job is here https://github.com/openstack-infra/project-config/blob/master/zuul.d/jobs.yaml#L26 | 14:03 |
| dmsimard | apollo13: are you also familiar with django-rest-framework btw ? | 14:04 |
| apollo13 | partially | 14:05 |
| apollo13 | mainly with the plain ApiViews | 14:05 |
| apollo13 | but I can manage and know whom to ask ;) | 14:05 |
| dmsimard | ok! | 14:06 |
| dmsimard | Today I'll push some updates to readme/docs and try to get some sort of roadmap doc going | 14:07 |
| apollo13 | neat | 14:08 |
| *** tbielawa has joined #ara | 14:24 | |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Added CI for black/isort. https://review.openstack.org/605439 | 14:33 |
| apollo13 | I didn't run isort/black over the codebase yet; but this should show you the differences | 14:33 |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Fixed tox warning. https://review.openstack.org/605443 | 14:39 |
| apollo13 | that's it for now, gotta go home | 14:40 |
| tristanC | dmsimard: i don't know when the UI refactor will land, #zuul said soon | 14:45 |
| tristanC | dmsimard: the job graph hasn't been rebased on the refactor | 14:48 |
| dmsimard | ok, np, I was just struggling myself to find the chain of inheritance for a job :p | 14:48 |
| dmsimard | because it was spread over different repos | 14:48 |
| dmsimard | tristanC: I guess https://review.openstack.org/#/c/591604/ doesn't pass python unit test jobs though ? unless that's a flap | 14:52 |
| gvincent | apollo13, dmsimard for https://review.openstack.org/#/c/605443/ why can we just put py3 instead of py35 to remove the warning? | 15:19 |
| apollo13 | depends on what you wanna test and support I guess | 15:19 |
| apollo13 | py3 would be 3.7 on my machine | 15:19 |
| gvincent | because basepython = python3.5 for user to have python 3.5 installed | 15:19 |
| dmsimard | the problem with that is that if we put python3.5 as the basepython | 15:19 |
| dmsimard | yeah | 15:19 |
| dmsimard | what gvincent said | 15:20 |
| gvincent | dmsimard, are you ok to update only the env name? | 15:20 |
| dmsimard | I haven't had a chance to look, there's someone else who sent a patch that changes the tox environments https://review.openstack.org/#/c/605316/ | 15:21 |
| apollo13 | I am fine with either, I just thought you wanted to test against 3.5 | 15:21 |
| dmsimard | I do not have an opinion right now, would need to look | 15:21 |
| dmsimard | there's even 3.7 now heh | 15:22 |
| dmsimard | it's tricky, 3.7 even broke some things | 15:22 |
| apollo13 | every python release breaks things :þ | 15:23 |
| dmsimard | It sort of sucks, I guess it means we need to start testing with different versions of python | 15:23 |
| dmsimard | makes for a complicated matrix | 15:23 |
| dmsimard | different OS, different version of python, different version of ansible | 15:23 |
| apollo13 | sure, in the end that is what you will end up with as soon as ara-server leaves pre-beta :þ | 15:24 |
| openstackgerrit | Guillaume Vincent proposed openstack/ara-server master: Remove tox basepython warning https://review.openstack.org/605457 | 15:24 |
| dmsimard | apollo13: if you look here you'll see an (outdated) table of what we test with ara 0.x https://github.com/openstack/ara#contributing-testing-issues-and-bugs | 15:25 |
| dmsimard | "py35" is really just "python3" in reality | 15:26 |
| apollo13 | not if you remove basepython, then py35 defaults axctually to python3.5 | 15:26 |
| apollo13 | according to the tox docs | 15:27 |
| dmsimard | depends on which distro | 15:27 |
| dmsimard | for example, centos doesn't have py3 | 15:27 |
| apollo13 | right, so I would expect that to fail on centos | 15:28 |
| apollo13 | according to tox: tox allows setting the python version for an environment via the basepython setting. If that’s not set tox can set a default value from the environment name ( e.g. py37 implies Python 3.7). Matching up the python version with the environment name has became expected at this point, leading to surprises when some configs don’t do so. | 15:28 |
| *** sshnaidm|mtg is now known as sshnaidm | 15:29 | |
| apollo13 | unless you installed python3 from epel | 15:30 |
| dmsimard | right | 15:31 |
| gvincent | depending on with py3 we use we will have some trouble with django 2.X also no? | 15:31 |
| dmsimard | the thing is I'm not sure yet how we might want to test with different versions of python | 15:31 |
| dmsimard | if we need to put "one" version of python in the tox file | 15:31 |
| apollo13 | gvincent: yes, django tries to support newest python versions but it might not always be up2date | 15:33 |
| apollo13 | dmsimard: you don't need to put one version of python into the tox file | 15:33 |
| apollo13 | every testenv can have it's own | 15:34 |
| apollo13 | and if not it inherits from the default testenv | 15:34 |
| apollo13 | so you can add testenv:py36 with basepython=python3.6 and voila | 15:34 |
| dmsimard | apollo13: I think you would probably have an interesting opinion on a "hack" that I'm using with django | 16:14 |
| dmsimard | tl;dr, ara needs to stay as simple as possible and there shouldn't be much needed other than "pip install ara", export the ansible callback config and run your playbook as usual | 16:15 |
| apollo13 | makes sense | 16:16 |
| dmsimard | I am determined at keeping things this way and so it could not be a requirement for people to stand up an API server | 16:17 |
| dmsimard | There *is* a http client which is a simple wrapper around python requests | 16:17 |
| dmsimard | but there is also an "offline" client which doesn't require standing up an API server | 16:17 |
| dmsimard | the hack is that it uses the django test client -- the one that is usually only used in unit tests | 16:18 |
| dmsimard | It works very well, actually. No http, no traffic. | 16:18 |
| dmsimard | and then, the idea is that these two clients have the exact same interface (post/get/patch/delete/etc) so that the callback is able to use one or the other, depending on the configuration | 16:19 |
| apollo13 | interesting | 16:19 |
| dmsimard | https://github.com/openstack/ara-clients/blob/master/ara/clients/offline.py | 16:19 |
| dmsimard | https://github.com/openstack/ara-clients/blob/master/ara/clients/http.py | 16:19 |
| apollo13 | mhm, to be honest I'd probably manually resolve the urls and call the view directly with a fake request obect | 16:21 |
| dmsimard | sure, that's why I said you'd probably have an opinion on it :D | 16:21 |
| dmsimard | the current implementation works but I'm open to doing something cleaner | 16:22 |
| apollo13 | I like the test approach, but it is really ment for testing | 16:22 |
| apollo13 | ie if it breaks you get to keep the pieces | 16:22 |
| dmsimard | yup, hence my description of it being a hack | 16:22 |
| dmsimard | the test client takes care of a lot of boilerplate that I didn't need to write so it was a convenient choice | 16:23 |
| apollo13 | I will see what I can come up with; we might loose a few things like middlewares, but eg access control etc probably doesn't make much sense for a offline client anyways | 16:23 |
| apollo13 | or CORS and whatnot ;) | 16:24 |
| dmsimard | yeah, it's not a priority for the time being | 16:24 |
| dmsimard | apollo13: so what timezone are you in then ? | 16:24 |
| apollo13 | as of now Europe/Vienna, ie UTC + 2 till summer time is over which will get me back to +1 | 16:25 |
| apollo13 | zuul seems rather overloaded, all jobs still queued? | 16:25 |
| dmsimard | Yeah, there's a bit of a backlog right now. It's not usually this busy but there were some cascading issues not necessarily related to Zuul. | 16:28 |
| dmsimard | The nodepool component that takes care of provisioning the VMs that I told you about -- it relies on our different cloud providers to work and there was an outage in one of them | 16:29 |
| dmsimard | We have graphs to keep track of things -- http://grafana.openstack.org/d/rZtIH5Imz/nodepool?orgId=1 and http://grafana.openstack.org/d/T6vSHcSik/zuul-status?orgId=1 | 16:31 |
| *** tbielawa is now known as tbielawa|mtg | 16:39 | |
| apollo13 | I see | 16:41 |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Small cleanups for django best practices. https://review.openstack.org/605421 | 16:56 |
| apollo13 | is "__import__('pkg_resources').declare_namespace(__name__)" there for a reason? do you really want ara/api also be a namespace package? | 16:58 |
| dmsimard | apollo13: it's a bit messy right now because of ara 0.x and ara 1.0 are vastly different and "pip install ara" currently installs 0.x | 17:05 |
| dmsimard | the end goal is probably that "ara" will more or less become a metapackage, taking care of installing ara-server, ara-plugins, ara-clients and ara-web | 17:06 |
| dmsimard | right now -- server, clients, plugins are all namespaced packages of ara | 17:06 |
| dmsimard | in practice, what it translates to is that they end up being installed in the same path | 17:06 |
| dmsimard | site-packages/ara/api, site-packages/ara/clients, site-packages/ara/plugins, etc... so then you can do "from ara.clients import ..." instead of something like "from ara_clients.clients import ..." | 17:07 |
| apollo13 | dmsimard: yes I understand that, this is allowed in python3 by default | 17:07 |
| apollo13 | but ara/api/__init__.py has declare namespace | 17:08 |
| apollo13 | which makes ara/api itself namespaced and allows for instance to let another package install into ara/api/blabal | 17:08 |
| apollo13 | if I understand it correctly at least | 17:08 |
| dmsimard | hmmmm | 17:08 |
| apollo13 | by not having __init__.py in ara/ itself you implicitelly make ara a namespaced package in py3 | 17:09 |
| apollo13 | declare_namespace was the old setuptools or whatever stuff | 17:09 |
| dmsimard | but there's things in ara itself right now https://github.com/openstack/ara/tree/master/ara | 17:10 |
| apollo13 | well you do not expect this ara to work with ara-server together, or? | 17:11 |
| dmsimard | I'm admittedly not super knowledgeable around these parts -- I looked things up, I tried things and it works so I left it at that | 17:11 |
| dmsimard | ara 0.x will have to be retired at some point | 17:11 |
| apollo13 | right | 17:11 |
| apollo13 | I am pretty sure (tm) that removing declare_namespace from ara/api and ara/server will not hurt | 17:11 |
| apollo13 | anyways, that's for another day | 17:11 |
| dmsimard | go for it | 17:12 |
| apollo13 | later, I am looking into viewsets currently | 17:13 |
| dmsimard | I love what I'm seeing in https://review.openstack.org/#/c/605421/ already, thanks a lot for that :) | 17:14 |
| *** tbielawa|mtg is now known as tbielawa | 17:17 | |
| *** tbielawa is now known as tbielawa|lunch | 17:17 | |
| *** tbielawa|lunch is now known as tbielawa | 17:22 | |
| gvincent | +1 dmsimard thank you apollo13 | 17:22 |
| apollo13 | Oh I am not done yet :þ | 17:23 |
| gvincent | ahah | 17:23 |
| *** tbielawa is now known as tbielawa|lunch | 17:28 | |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Small cleanups for django best practices. https://review.openstack.org/605421 | 17:32 |
| apollo13 | ok, time to eat something, will see if I can clean up the remaining Todos in the code later | 17:32 |
| apollo13 | dmsimard: interesting: error: Namespace package problem: ara.api is a namespace package, but its __init__.py does not call declare_namespace()! Please fix it. -- gotta read python docs; though I wonder if that is a pbr issue | 17:33 |
| apollo13 | guess you were right :) | 17:33 |
| dmsimard | apollo13: we can figure this out later | 17:33 |
| dmsimard | it's a detail :p | 17:34 |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Small cleanups for django best practices. https://review.openstack.org/605421 | 18:35 |
| *** tbielawa|lunch is now known as tbielawa | 18:35 | |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Only ara is a namespace package, subpackages are not. https://review.openstack.org/605503 | 18:37 |
| apollo13 | ok, I am done for today; let me know what you think :) | 18:38 |
| apollo13 | if you have any questions, please don't hesitate to ask | 18:40 |
| apollo13 | if tests fail I'll fix tomorrow or so | 18:40 |
| openstackgerrit | Florian Apolloner proposed openstack/ara-server master: Small cleanups for django best practices. https://review.openstack.org/605421 | 18:51 |
| apollo13 | last update, I promise :) | 18:51 |
| apollo13 | but the code got simpler imo | 18:51 |
| *** evrardjp has joined #ara | 20:11 | |
| *** tbielawa has quit IRC | 20:29 | |
| *** tbielawa has joined #ara | 20:29 | |
| *** tbielawa is now known as tbielawa|g0n3 | 20:30 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Update and improve README to be more accurate https://review.openstack.org/605528 | 20:42 |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Bootstrap documentation and publish it to readthedocs https://review.openstack.org/605529 | 20:42 |
| openstackgerrit | David Moreau Simard proposed openstack/ara-server master: Bootstrap documentation and publish it to readthedocs https://review.openstack.org/605529 | 20:48 |
| *** themurph has quit IRC | 21:25 | |
| *** mgariepy has quit IRC | 21:59 | |
| *** mgariepy has joined #ara | 22:13 | |
| *** openstackgerrit has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
