dmsimard | I'm close... but not quite there yet http://logs.openstack.org/66/625666/15/check/ara-build-dashboard/a1c14f5/npm/html/ | 01:47 |
---|---|---|
dmsimard | oh hey, I needed to add logs.openstack.org to the CORS whitelist on api.demo | 02:14 |
dmsimard | that's actually a good thing :) | 02:14 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Use relative path when retrieving config.json https://review.openstack.org/629085 | 02:16 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: WIP: Run a CI job that builds and publishes the web dashboard https://review.openstack.org/625666 | 02:17 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 03:09 |
dmsimard | gvincent: ^ I think those two are ready to land -- we still need to figure out why the link to /playbooks sends us to the root of logs.openstack.org | 03:12 |
dmsimard | sample from before your recent rework: http://logs.openstack.org/66/625666/15/check/ara-build-dashboard/a1c14f5/npm/html/ | 03:12 |
dmsimard | and from after the WIP rework: http://logs.openstack.org/66/625666/15/check/ara-build-dashboard/a1c14f5/npm/html/ | 03:13 |
dmsimard | ssbarnea|bkp2: btw for https://storyboard.openstack.org/#!/story/2001161 | 03:14 |
dmsimard | ARA 1.0 has a new feature called labels | 03:15 |
dmsimard | they could also be called tags | 03:15 |
dmsimard | but anyway, the idea is to have just a generic logical container/relationship mechanism | 03:16 |
dmsimard | for example, we could ship a default label called "successful playbooks" and then have the API automatically tag successful playbooks as such | 03:17 |
dmsimard | but you could also have a label called rhbz123456 and put it on things | 03:17 |
dmsimard | so then you can search for results matching labels | 03:18 |
dmsimard | I haven't settled on a client-side implementation yet. Not sure what's the best way. | 03:20 |
dmsimard | An ansible module ? Something that the callback could pick up on ? | 03:22 |
dmsimard | ¯\_(ツ)_/¯ | 03:22 |
*** jungleslow has quit IRC | 06:12 | |
*** sshnaidm has quit IRC | 06:52 | |
*** jparrill has joined #ara | 07:25 | |
*** ssbarnea has joined #ara | 08:16 | |
*** ssbarnea|bkp2 has quit IRC | 08:16 | |
*** herald85 has joined #ara | 08:25 | |
*** themroc has joined #ara | 08:26 | |
*** sshnaidm has joined #ara | 08:31 | |
*** sshnaidm has quit IRC | 08:47 | |
*** sshnaidm has joined #ara | 09:55 | |
*** herald85 has quit IRC | 12:07 | |
*** herald85 has joined #ara | 13:34 | |
*** jlozadad has quit IRC | 14:06 | |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Use relative path when retrieving config.json https://review.openstack.org/629085 | 15:10 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 15:10 |
dmsimard | gvincent: removing ./ from config.json seemed fine locally, pushed it up to test ^ | 15:11 |
gvincent | ack | 15:11 |
dmsimard | gvincent: I'm still not sure what's the issue with the playbooks link going to logs.openstack.org directly (and somehow the webapp still works) | 15:11 |
dmsimard | also the lack of redirection from index to the playbooks page | 15:12 |
dmsimard | but I'm comfortable merging the job as is, it's probably not an issue with the job itself | 15:13 |
gvincent | which job? | 15:13 |
gvincent | 629085 ? | 15:13 |
dmsimard | gvincent: no https://review.openstack.org/#/c/625666/ | 15:15 |
dmsimard | ara-build-dashboard which generates http://logs.openstack.org/66/625666/17/check/ara-build-dashboard/3928b50/npm/html/ | 15:15 |
dmsimard | the link to playbook works but the URL gets weird | 15:16 |
dmsimard | and the index doesn't redirect properly for some reason | 15:16 |
dmsimard | rest seems fine to me | 15:16 |
gvincent | normally you set the homepage in the package.json with a valid url | 15:19 |
gvincent | "homepage": "http://logs.openstack.org/66/625666/17/check/ara-build-dashboard/3928b50/npm/html/" | 15:20 |
dmsimard | gvincent: I'm not sure if we know that URL ahead of time, I need to check if we can infer it | 15:20 |
gvincent | then in our router we can use it to have information properly configured | 15:21 |
gvincent | dmsimard, will it be easier to replace a service for that? | 15:21 |
dmsimard | It's a bit tricky from an end user perspective if we need to have people configure the URL | 15:22 |
gvincent | you have some services like https://www.netlify.com/ which can be integrated within your CI and create a specific url for every build | 15:23 |
gvincent | for patternfly for example https://deploy-preview-724--pf-next.netlify.com/ | 15:24 |
gvincent | this is the PR 724 updated after every commit | 15:24 |
gvincent | IMO it's a lot of work for now for 3 commands | 15:25 |
gvincent | git review -d ... && yarn install && yarn start | 15:25 |
dmsimard | gvincent: it's alright, we have a way to tell where the logs will be uploaded with zuul | 15:28 |
dmsimard | let me try it | 15:29 |
dmsimard | gvincent: this can't go in config.json right ? | 15:32 |
dmsimard | needs to be in package.json ? | 15:32 |
gvincent | yes | 15:32 |
gvincent | it's used by react-script during the build | 15:32 |
*** herald85 has quit IRC | 15:32 | |
dmsimard | so if I am someone who deploys ara-web, I'd always need to set up this URL in package.json ? | 15:32 |
gvincent | normally no | 15:33 |
gvincent | when you are deploying a web app you configure your webserver (apache) to serve your folder correctly | 15:33 |
dmsimard | so it's at the root, ok -- sure | 15:33 |
gvincent | yes | 15:33 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 15:53 |
dmsimard | attempt #1 ^ | 15:53 |
*** etienne has joined #ara | 15:55 | |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 16:06 |
*** themroc has quit IRC | 16:37 | |
*** gnupyx has joined #ara | 20:39 | |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 22:17 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 22:59 |
openstackgerrit | David Moreau Simard proposed openstack/ara-web master: Add a Zuul job that builds and publishes the web dashboard https://review.openstack.org/625666 | 23:12 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!