Wednesday, 2019-05-29

*** sshnaidm has quit IRC00:44
*** sshnaidm has joined #ara01:50
*** altlogbot_1 has quit IRC03:44
*** altlogbot_1 has joined #ara03:44
*** altlogbot_1 has quit IRC04:38
*** altlogbot_3 has joined #ara04:38
*** altlogbot_3 has quit IRC04:40
*** altlogbot_2 has joined #ara04:40
*** herald85 has joined #ara07:04
*** gvincent has quit IRC07:44
*** idir__ has joined #ara08:10
*** idir__ has quit IRC08:10
*** sshnaidm has quit IRC08:30
*** sshnaidm has joined #ara08:31
*** jungleslow has joined #ara09:24
*** gvincent has joined #ara09:29
*** gvincent has quit IRC09:30
*** gvincent has joined #ara09:31
*** vincent-- has joined #ara09:56
*** vincent- has quit IRC09:59
*** idir__ has joined #ara10:26
idir__hi, i setup authentication for ara-api (ara version 1.0.0.0b2), and my problem is: the interface does not get data from the api because of authentication. how can we solve this?10:28
*** idir__ has quit IRC10:37
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Differentiate between no playbooks from api server unreachable  https://review.opendev.org/66194011:06
gvincentdmsimard, https://review.opendev.org/#/c/661940/11:07
gvincentdmsimard, CORS is still not allowed on https://api.demo.recordsansible.org/11:08
*** dbpiv has quit IRC12:08
*** idir__ has joined #ara12:19
idir__hi, i setup ara version 1.0.0.0 and activate the authentication in ara-api, so the problem is : the interface of ara (ara-web) can not get data (401), how can i solve this ? thank you12:25
idir__is there any configuration in ara-web to solve this problem ?12:36
dmsimardidir__: authentication is not yet supported in ara-web12:41
dmsimardhttps://github.com/ansible-community/ara-web/issues/1.12:41
openstackgerritDavid Moreau Simard proposed recordsansible/ara-infra master: Allow all CORS origins for the API live demo  https://review.opendev.org/66196912:48
dmsimardgvincent: fixed ^ sorry12:48
idir__dmsimard: ok thank you :)12:53
idir__i added a task in database.potgresql to automate the creation of the django surper user, and also some variables for that and i can share it with you if you whant12:56
gvincentdmsimard, how can I know if the server is protected?12:56
idir__want12:56
dmsimardgvincent: protected ? by a password ?12:57
gvincentyes for the ui do you want me to catch any 401 api error and redirect to a login page?12:57
dmsimardidir__: would definitely appreciate if you could send those patches for the roles !12:58
dmsimardgvincent: that would make sense I guess. Only show a login page if the remote server requires authentication ?12:58
dmsimardI don't know if django returns any headers or something, let me set it up12:59
gvincentyes but there is no way for me to check if the api is protected except try and fail right?12:59
dmsimardgvincent: that's what I'm going to double check12:59
gvincentdmsimard, I was more thinking about a variable in the config13:00
dmsimardgvincent: a variable for what, showing the login screen ?13:00
gvincentno variable saying this ara-web is for a protected api13:01
idir__if you set up the authentication django will send 401 error13:01
gvincentapiUrl: ..., isApiProtected: true13:01
gvincentbut let's make the interface generic13:01
gvincentdmsimard, is /api/v1/ protected when the server is protected?13:03
gvincentidir__, ^13:03
dmsimardgvincent: http://api.trunk.demo.recordsansible.org && http://web.trunk.demo.recordsansible.org13:04
dmsimardset up with read_protected and write_protected13:04
idir__yes it is13:04
dmsimardhaven't set up a user yet, hang on13:04
gvincentperfect13:04
dmsimardgvincent: "/" could probably be not protected13:04
dmsimardwould that help ?13:04
gvincentdmsimard, I will check at startup /api/v1/ if 401 I will redirect the user to the login page13:05
gvincentit helps thank you13:05
dmsimardalso btw I added a small comment in https://review.opendev.org/#/c/661940/13:05
idir__when you set to true the to variables i think all is protected13:05
gvincentI can work on this13:05
gvincentdmsimard, I didn't want to include html in the page to avoid xss issues13:06
gvincenthtml in the message13:06
openstackgerritMerged recordsansible/ara-web master: Differentiate between no playbooks from api server unreachable  https://review.opendev.org/66194013:09
idir__dmsimard: how can i sen patches for the roles13:12
idir__?13:12
dmsimardidir__: I hope to be able to open up pull requests in the near future but in the meantime you need to send your patches to gerrit which involves setting up a few things that I'm happy to help with13:13
dmsimardThere are (now slightly outdated) docs here https://ara.readthedocs.io/en/stable/contributing.html but I had made a tl;dr version here https://github.com/ansible-community/ara/pull/12#issuecomment-43311953913:14
gvincentdmsimard, I would like to rename container to page in the js app13:19
gvincentis it something I can do ?13:19
idir__@dmsimard i'll try  gerrit, I will write to you later. it's ok for you ?13:21
dmsimardidir__: sure thing13:21
dmsimardgvincent: you mean like the file names ?13:21
gvincentyes13:21
dmsimardsure, go for it13:21
dmsimarddo what you gotta do13:21
idir__dmsimard:  you sed "Clone the repo" which repo ? the one in github ?13:49
idir__https://github.com/ansible-community/ara13:49
idir__this one https://github.com/ansible-community/ara/tree/1.0.0b213:50
dmsimardidir__: that's the same repo but different branches13:52
dmsimardidir__: if you want to send a patch on top of 1.0, you need to checkout the feature/1.0 branch13:53
idir__yes ^^13:53
dmsimardgit clone https://github.com/ansible-community/ara; cd ara; git checkout feature/1.013:53
idir__after chnages i have to commit and git review13:54
dmsimardidir__: yup, that's it13:55
dmsimardif you've set up your ssh key and username in gerrit13:55
idir__yes i do13:55
dmsimardthe thing that tends to cause issues is if your local ssh user is different than the one set up in gerrit13:55
dmsimardfor example if your local username is "user" and the gerrit user is "foo", it will try to authenticate as user@review.opendev.org and that wouldn't work since it needs to be foo@review.opendev.org13:55
dmsimardif it's different, you can set it up in your .ssh/config file like this: http://paste.openstack.org/show/752247/13:57
idir__yes it's normal,  know i'm not on my personal machine, i will create another key from mine and add it to opendev13:57
idir__i added Redhat version in vars with some changes in tasks i will add them14:00
idir__i'm very excited to contribute to this project :)14:00
dmsimardidir__: and I'm very happy that you are able to contribute :D14:01
openstackgerritDavid Moreau Simard proposed recordsansible/ara feature/1.0: Port contribution docs from 0.x and update for 1.0  https://review.opendev.org/66199214:03
dmsimardidir__: ^ a first iteration of the contribution docs updated for 1.014:04
idir__i've never used opendev, so i'll take the time to see how it works :p14:11
*** etienne has quit IRC14:38
*** dbpiv has joined #ara14:42
openstackgerritDavid Moreau Simard proposed recordsansible/ara feature/1.0: Port FAQ docs from 0.x and update for 1.0  https://review.opendev.org/66201014:54
gvincentDavid is there an endpoint for the api to get a short lived token?14:58
gvincentor should I store the user credentials locally?14:58
dmsimardapollo13: ^14:59
dmsimardgvincent: asking the expert14:59
dmsimardI don't think there's anything of the like right now but perhaps https://www.django-rest-framework.org/api-guide/authentication/#tokenauthentication could help15:00
dmsimardstoring the credentials locally sounds like a good first iteration15:01
gvincentin term of security this is crapy :D15:01
gvincentJWT on DRF is one module to add :D15:01
dmsimardgvincent: this one ? https://github.com/davesque/django-rest-framework-simplejwt15:04
dmsimardlooks simple enough but out of scope for 1.0, can be 1.1 :D15:06
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Fix error handler in Playbooks page  https://review.opendev.org/66201615:06
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: WIP Support authentication  https://review.opendev.org/66201715:06
gvincentdmsimard, WIP https://review.opendev.org/#/c/662017/15:07
gvincentcan you send me textContent= in https://review.opendev.org/#/c/662017/1/src/login/LoginContainer.js15:07
gvincentI need to go15:07
gvincentfor know I will sotre in the localStorage password and username15:08
gvincentand add basic auth on every request15:08
gvincenttomorrow is public holiday in France dmsimard15:08
gvincentI will finish it on friday15:08
gvincentcheers!15:08
dmsimardgvincent: no stress, I'll try it out and review in the meantime15:09
dmsimardgood job :)15:09
gvincenthttps://i.imgur.com/rK1aEpp.png15:09
*** herald85 has quit IRC15:09
dmsimardgvincent: very cool15:11
dmsimardit doesn't seem to work locally yet15:11
openstackgerritMerged recordsansible/ara feature/1.0: Port contribution docs from 0.x and update for 1.0  https://review.opendev.org/66199215:14
dmsimardgvincent: added comments on https://review.opendev.org/#/c/662017/15:19
openstackgerritDavid Moreau Simard proposed recordsansible/ara feature/1.0: Port FAQ docs from 0.x and update for 1.0  https://review.opendev.org/66201015:26
*** jungleslow has quit IRC15:27
openstackgerritMerged recordsansible/ara-infra master: Allow all CORS origins for the API live demo  https://review.opendev.org/66196915:32
*** altlogbot_2 has quit IRC15:35
*** altlogbot_2 has joined #ara15:35
*** irclogbot_3 has quit IRC15:36
*** irclogbot_3 has joined #ara15:36
idir__dmsimard: gvincent Hi, I'll test my configuration of gerrit. Please ignore it15:37
dmsimardsure15:38
openstackgerritMerged recordsansible/ara-web master: Fix error handler in Playbooks page  https://review.opendev.org/66201615:51
idir__dmsimard: I can't use SSH for push my commit. I try to use http connection. But the url from the documentation for the generation of change-id (http://review.opendev.org/tools/hook/commit-msg) doesn't work15:57
idir__oups missing s in hooks :p15:59
openstackgerritdjemaoune idir proposed recordsansible/ara feature/1.0: test gerrit  https://review.opendev.org/66202616:00
openstackgerritdjemaoune idir proposed recordsansible/ara feature/1.0: check topic fix  https://review.opendev.org/66202716:02
dmsimardidir__: congrats :)16:07
dmsimardTopics can also be set manually in the gerrit web UI after the patch was sent but not after it merged16:07
*** ktibi has joined #ara16:18
ktibiHi guys, I works with idir__ . thx for fix in beta2, all works with ansible 2.816:18
*** idir__ has quit IRC16:26
dmsimardktibi: ohai o/16:26
ktibidmsimard, We'll use the 1.0 version even if this beta doesn't have all feature for the web interface.16:27
ktibiI can see you work very fast so it's ok if we are beta users16:28
ktibiWe'll try to contribute to the ansible part, but we don't have JS devs sorry ^^16:29
dmsimardktibi: I'm also not a very javascript person :p16:34
dmsimard1.0 is pretty much ready for release, I've been wrapping up missing docs and writing a blog post16:34
dmsimardThe current state of things is not perfect but it will be a good foundation that we can iterate on for future dot releases :)16:35
ktibidmsimard, Yep maybe need some fix to have a web interface more friendly16:54
ktibilike a filter or a button for sort each line16:55
ktibibecause I need to scroll for find my last playbook (default make the oldest in the first position)16:56
openstackgerritMerged recordsansible/ara feature/1.0: Port FAQ docs from 0.x and update for 1.0  https://review.opendev.org/66201017:13
*** sshnaidm is now known as sshnaidm|off17:33
dmsimardktibi: some of the high level items are documented as issues in https://github.com/ansible-community/ara-web/issues17:55
dmsimardFeel free to weigh in if you have opinions or create new issues if you have ideas17:55
ktibiok, we'll try to make that )17:56
*** ktibi has quit IRC17:57
dmsimardRight now we are working to implement data from the API in the right places at the right time, usability and prettiness will come naturally as we iterate17:58
*** dbpiv has quit IRC19:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!