Friday, 2019-05-31

*** herald85 has joined #ara07:04
*** gvincent has joined #ara07:22
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Support authentication  https://review.opendev.org/66201708:37
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Support authentication  https://review.opendev.org/66201708:58
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Support authentication  https://review.opendev.org/66201709:08
*** apollo13 has quit IRC09:25
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Prevent Warning: Can't perform a React state update on an unmounted component  https://review.opendev.org/66241709:27
*** apollo13 has joined #ara09:27
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Rename Container into Page  https://review.opendev.org/66242109:39
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Rename Container into Page  https://review.opendev.org/66242410:13
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Fix visual glitches  https://review.opendev.org/66242510:13
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Fix visual glitches  https://review.opendev.org/66242510:14
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Fix visual glitches  https://review.opendev.org/66242510:17
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Support authentication  https://review.opendev.org/66201710:22
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Prevent Warning: Can't perform a React state update on an unmounted component  https://review.opendev.org/66241710:22
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Rename Container into Page and apply prettier  https://review.opendev.org/66242410:22
openstackgerritGuillaume Vincent proposed recordsansible/ara-web master: Fix visual glitches  https://review.opendev.org/66242510:22
gvincentsorry for the flood10:52
*** logan- has quit IRC12:07
dmsimardgvincent: no need to apologize for sending patches :p12:07
*** logan- has joined #ara12:07
gvincentI rebase my patches because I forgot some files12:08
gvincent:D12:08
dmsimardgvincent : btw a user helped find out a significant regression in the beta vs 0.x https://review.opendev.org/#/c/662328/12:08
gvincentyou will probably love 66201712:08
gvincent:D12:08
dmsimardThat's why we didn't have any changed status, only ok12:09
dmsimardgvincent: all lgtm, I'll review the login one in a bit. Great work :)12:19
*** openstack has joined #ara12:27
*** ChanServ sets mode: +o openstack12:27
dmsimardgvincent: perhaps add a "logged in as X" at the top right with a button to log out ? can be in another patch12:48
openstackgerritMerged recordsansible/ara feature/1.0: Add missing 'changed' and 'ignore_error' to results  https://review.opendev.org/66232812:55
openstackgerritDavid Moreau Simard proposed recordsansible/ara-web master: Remove stray comma  https://review.opendev.org/66245512:56
openstackgerritMerged recordsansible/ara-web master: Support authentication  https://review.opendev.org/66201713:06
openstackgerritMerged recordsansible/ara-web master: Prevent Warning: Can't perform a React state update on an unmounted component  https://review.opendev.org/66241713:07
openstackgerritMerged recordsansible/ara-web master: Rename Container into Page and apply prettier  https://review.opendev.org/66242413:08
openstackgerritMerged recordsansible/ara-web master: Fix visual glitches  https://review.opendev.org/66242513:08
gvincentdmsimard, I removed it because I need to differentiate between I'm authenticated and the server didn't need authentication13:11
gvincentso yes it should be in another patch13:12
dmsimardgvincent: demo updated with latest changes from api and web, we now have changed results :D https://web.demo.recordsansible.org/playbooks14:10
*** etienne has quit IRC14:27
*** openstackstatus has joined #ara14:29
*** ChanServ sets mode: +v openstackstatus14:29
-openstackstatus- NOTICE: The Gerrit service at https://review.opendev.org/ will be offline briefly for maintenance starting at 15:00 UTC (roughly 30 minutes from now); for details see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006684.html14:30
*** herald85 has quit IRC15:03
-openstackstatus- NOTICE: Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running.15:04
*** ChanServ changes topic to "Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running."15:04
gvincentdmsimard, nice15:13
gvincenton monday I will do the task result pop up15:13
dmsimardgvincent: created an issue for pagination https://github.com/ansible-community/ara-web/issues/1015:13
*** etienne has joined #ara15:14
gvincenteasy one :)15:14
* gvincent need to go15:14
dmsimardgvincent: have a nice weekend o/15:14
*** ChanServ changes topic to "ARA Records Ansible: Making playbook runs easier to visualize, understand and troubleshoot | https://ara.recordsansible.org | Git: https://github.com/ansible-community/ara | Changelog: https://github.com/ansible-community/ara/releases | This channel is logged: http://eavesdrop.openstack.org/irclogs/%23ara/""15:58
*** vincent-- has joined #ara15:59
openstackgerritDavid Moreau Simard proposed recordsansible/ara-web master: Align playbook infos and labels to the right in summary  https://review.opendev.org/66250015:59
-openstackstatus- NOTICE: Gerrit is back up and running again. Thank you for your patience and sorry for the delay in this notification (we thought the statusbot was still busy updating channel topics).16:45
*** openstackgerrit has quit IRC19:01
dmsimardvincent--: o/ the fix landed and we have "changed" things now: https://web.demo.recordsansible.org/playbooks/219:20
dmsimardand regarding that question for the variable declaration before the handler, the handler doesn't run immediately unless you flush handlers -- which we do not19:21
dmsimardthe way it's written feels wrong and I didn't realize that until you pointed it out :D19:21
*** dmsimard has quit IRC19:55
*** dmsimard has joined #ara19:55
*** dmsimard has quit IRC19:56
*** dmsimard has joined #ara20:01
*** dmsimard has quit IRC20:01
*** dmsimard has joined #ara20:21
ara-slackjt.neville: @jt.neville has joined the channel21:24
*** etienne has quit IRC22:28

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!