*** jparrill has quit IRC | 01:35 | |
*** sshnaidm has quit IRC | 02:05 | |
*** mnaser has quit IRC | 03:19 | |
*** mnaser has joined #ara | 03:20 | |
*** altlogbot_2 has quit IRC | 06:46 | |
*** altlogbot_2 has joined #ara | 06:48 | |
*** altlogbot_2 has quit IRC | 06:50 | |
*** altlogbot_2 has joined #ara | 06:54 | |
*** sshnaidm has joined #ara | 07:42 | |
*** vincent- has quit IRC | 10:26 | |
*** vincent- has joined #ara | 10:28 | |
*** vincent-- has joined #ara | 10:32 | |
*** vincent- has quit IRC | 10:34 | |
*** openstackgerrit has quit IRC | 13:48 | |
*** med_ has joined #ara | 13:51 | |
*** spiette has quit IRC | 14:05 | |
*** spiette has joined #ara | 14:08 | |
dmsimard | apollo13: just a question on https://review.opendev.org/#/c/666962/, rest lgtm | 14:48 |
---|---|---|
apollo13 | dmsimard: jupp could be | 14:49 |
apollo13 | I am so used to relative imports, let me fix that | 14:49 |
*** openstackgerrit has joined #ara | 14:50 | |
openstackgerrit | Florian Apolloner proposed recordsansible/ara master: Added utility method to get the current active client. https://review.opendev.org/666962 | 14:50 |
dmsimard | nahun: the larger fields are typically only available in detailed view to keep the list responses size in check | 14:54 |
dmsimard | some examples: host facts (/api/v1/hosts/<id>), result output (/api/v1/results/<id>), file contents (/api/v1/files/<id>) | 14:54 |
nahun | thanks, took me longer than I'd like to admit to figure that out | 15:19 |
dmsimard | nahun: it's documented briefly here: https://ara.readthedocs.io/en/latest/api-documentation.html#relationship-between-objects | 15:19 |
dmsimard | but it's not obvious :( | 15:20 |
dmsimard | ah actually that needs to be updated, playbook arguments are in the list view now | 15:31 |
nahun | If I was going to mess around and add task detail to the web UI, would you have the user click on the task result for the host and a popup show with the detailed results? So the web UI wouldn't make an API query for the detailed results until the user clicks on the task result for the specific host. | 16:39 |
dmsimard | nahun: yeah, the web app should ideally not query for something until it needs it | 16:43 |
dmsimard | otherwise it could end up querying for thousands of detailed results | 16:43 |
dmsimard | so the list view is "optimized" to provide as much contextual data as possible without the heavy stuff | 16:43 |
dmsimard | and then if you want to drill down, it would be an additional query | 16:43 |
dmsimard | in the ara 0.x webapp, the result details is displayed in a modal/popup -- you can see an example here: http://logs.openstack.org/62/666962/3/check/ansible-role-ara-api-ubuntu-postgresql/6550cb8/ara-report/ (expand "tasks" for a playbook and click on CHANGED, OK, etc. on the right hand side) | 16:44 |
nahun | would you do a popup like the old web UI for detailed results or another "dropdown" that expands like most of the other stuff in the new web UI? | 16:45 |
dmsimard | nahun: it's a good question :) | 16:45 |
dmsimard | the modal from 0.x was more or less of a hack due to the lack of API | 16:46 |
nahun | bootstrap has modal, but I don't know patternfly at all. I don't know react at all either... heh | 16:47 |
dmsimard | https://patternfly-react.surge.sh/patternfly-4/ has good docs | 16:48 |
dmsimard | but, honestly, getting the data in the UI in some shape or form would be useful | 16:48 |
dmsimard | we can iterate to make it prettier | 16:49 |
nahun | I like the idea of being able to show multiple task results at time, but popups look nice and clean | 16:49 |
dmsimard | gvincent isn't around right now but he's done most of the work in ara-web, I'll ping him via https://github.com/ansible-community/ara-web/issues/2 to see what he thinks | 16:50 |
nahun | ah nice, already an issue created | 16:50 |
dmsimard | there is a few in ara-web | 16:51 |
nahun | I may try to add it in myself, but the likelihood of it being something that can be merged is low. My code quality with JS usually isn't great. But if I'm not ashamed of it I may let you know. | 16:52 |
dmsimard | nahun: sure, feel free to take a stab at whatever approach feels easiest to you at first -- we have live previews provided by the CI i.e, http://logs.openstack.org/44/663344/1/check/ara-web-build-dashboard/eed4e31/npm/html/ | 16:54 |
dmsimard | so we can see what it looks like before landing anything | 16:54 |
dmsimard | I can definitely help push things along, ara-web is where we need the most work done :D | 16:55 |
dmsimard | added a comment in the issue | 16:59 |
*** dbpiv has joined #ara | 17:08 | |
*** dbpiv has quit IRC | 18:08 | |
*** vincent-- has quit IRC | 18:41 | |
openstackgerrit | David Moreau Simard proposed recordsansible/ara master: Added utility method to get the current active client. https://review.opendev.org/666962 | 19:43 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara master: Run actual integration tests for the ara-api role jobs https://review.opendev.org/666894 | 19:44 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara master: Add distributed_sqlite db backend and WSGI app https://review.opendev.org/665323 | 19:44 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara master: Run actual integration tests for the ara-api role jobs https://review.opendev.org/666894 | 20:28 |
openstackgerrit | Merged recordsansible/ara master: Added utility method to get the current active client. https://review.opendev.org/666962 | 20:42 |
*** openstackgerrit has quit IRC | 21:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!