*** jwcroppe has joined #cloudkitty | 00:22 | |
*** zhurong has joined #cloudkitty | 00:28 | |
*** liujiong has joined #cloudkitty | 01:11 | |
*** zhurong has quit IRC | 03:39 | |
*** zhangguoqing has joined #cloudkitty | 04:00 | |
*** sacharya has quit IRC | 05:25 | |
*** zhurong has joined #cloudkitty | 06:23 | |
*** sacharya has joined #cloudkitty | 06:25 | |
*** sacharya has quit IRC | 06:30 | |
*** logan- has quit IRC | 07:47 | |
*** logan- has joined #cloudkitty | 07:56 | |
*** sacharya has joined #cloudkitty | 08:01 | |
*** sacharya has quit IRC | 08:06 | |
*** jwcroppe has quit IRC | 08:41 | |
*** jwcroppe has joined #cloudkitty | 08:42 | |
*** jwcroppe has quit IRC | 08:46 | |
*** sacharya has joined #cloudkitty | 09:01 | |
*** sacharya has quit IRC | 09:06 | |
*** zhangguoqing has quit IRC | 09:27 | |
*** zhurong has quit IRC | 09:44 | |
*** liujiong has quit IRC | 10:13 | |
*** zhurong has joined #cloudkitty | 10:25 | |
*** sacharya has joined #cloudkitty | 11:02 | |
*** sacharya has quit IRC | 11:07 | |
*** zhurong has quit IRC | 11:15 | |
*** liujiong has joined #cloudkitty | 11:27 | |
*** gongysh has joined #cloudkitty | 12:52 | |
huats | Hi there ! | 13:02 |
---|---|---|
*** sacharya has joined #cloudkitty | 13:03 | |
liujiong | Hello, huats! | 13:03 |
huats | We have meeting ! | 13:04 |
huats | Let's wait a few minutes | 13:04 |
huats | for late arrival | 13:04 |
liujiong | Yes, I remember. | 13:04 |
*** gongysh has quit IRC | 13:07 | |
*** sacharya has quit IRC | 13:08 | |
aolwas | hi every one | 13:11 |
aolwas | sorry for the delay | 13:11 |
huats | don't worry | 13:12 |
huats | we were just waiting a bit for late arrivals | 13:12 |
liujiong | It's all right, aolwas. | 13:12 |
*** liujiong_lj has joined #cloudkitty | 13:15 | |
*** liujiong has quit IRC | 13:17 | |
*** liujiong_lj is now known as liujiong | 13:17 | |
*** zhangguoqing_ has joined #cloudkitty | 13:18 | |
zhangguoqing_ | I'm sorry that another thins brake me. | 13:19 |
huats | hey guys | 13:20 |
huats | I think we can start | 13:20 |
liujiong | OK. | 13:20 |
zhangguoqing_ | let's start. :) | 13:20 |
huats | So I think we should continue on having a look at the current state of reviews | 13:21 |
liujiong | Agree. | 13:23 |
zhangguoqing_ | https://review.openstack.org/#/c/329242/ | 13:23 |
huats | first of all guys | 13:24 |
huats | have you been able to review the various things I pushe you ? | 13:24 |
zhangguoqing_ | https://review.openstack.org/#/c/393021/ has been merged. | 13:25 |
liujiong | Hmm, I've reviewed 'improve user experience', that looks good to me now. | 13:25 |
aolwas | I've started to look at https://review.openstack.org/#/c/408518/ but didnt't have time to finish | 13:26 |
zhangguoqing_ | aolwas: thanks, you can communicate with me anytime. | 13:27 |
aolwas | I've also looked at https://review.openstack.org/#/c/329242/ and found a potentiel compatibility break we need to discuss | 13:27 |
aolwas | it may not have a lot of impact since few people may actually use gnocchi storage | 13:28 |
liujiong | let me know that, huats. | 13:28 |
huats | liujiong: I am not sure what you are refering | 13:29 |
huats | zhangguoqing_: can you please review https://review.openstack.org/#/c/404680/ | 13:29 |
huats | ? | 13:29 |
liujiong | The patch refering to configuration file. | 13:29 |
zhangguoqing_ | aolwas: I can not agree with you, gnocchi stroage will be used widly. | 13:30 |
zhangguoqing_ | huats: No problem. | 13:30 |
liujiong | I rename 'gnocchi_collector' section name. You mean this break compatibility? | 13:30 |
huats | zhangguoqing_: will be used (for gnocchi storage) but it is not used right now... | 13:30 |
aolwas | no, 'gnocchi_storage' which was 'storage_gnocchi' | 13:31 |
liujiong | Yes. | 13:31 |
liujiong | You mean this breaks compatibility? | 13:31 |
liujiong | If so, it's true. | 13:32 |
aolwas | for people currently using gnocchi for cloudkitty storage, since their current conf would be loaded correctly with this patch | 13:33 |
aolwas | but I don't know if it is really use today by anyone | 13:33 |
zhangguoqing_ | The key of 329242 is to delete cloudkitty.conf.sample file which we don't maintain it any more. | 13:35 |
liujiong | If needed, a warn can be logged telling people the section was renamed. | 13:36 |
*** gongysh has joined #cloudkitty | 13:36 | |
aolwas | zhangguoqing_ I agree but by doing this you also impact have you write the conf file | 13:36 |
liujiong | or just keep the section name as original? | 13:37 |
huats | zhangguoqing_: it is already deleted (cloudkitty.conf.sample) | 13:37 |
huats | I made a patch for that | 13:37 |
huats | IIRC | 13:38 |
aolwas | liujiong I looked this morning how we could make the old name deprecated in oslo.config and keep it for compatibility but did not found a good way to di it | 13:38 |
aolwas | 'do' | 13:38 |
huats | sorry I mixed | 13:38 |
liujiong | huats: we are talking about the compatibility problem. | 13:39 |
huats | liujiong: I know you are, but I don't think zhangguoqing_ was :) | 13:39 |
liujiong | aolwas: I have experience doing that, add the deprecation. | 13:40 |
aolwas | to summarize we have two options | 13:42 |
aolwas | - merge as it is now, since i think nobody currently use it | 13:43 |
aolwas | - mark it deprecated and suppress the old name next cycle | 13:43 |
zhangguoqing_ | storage_gnocchi is good. | 13:45 |
aolwas | for sure, we need to be cautious when renaming things in cloudkitty | 13:45 |
aolwas | or third option ... keep the name, you're right :) | 13:45 |
aolwas | but it make sense to have all section names homogeneous | 13:46 |
liujiong | if we keep the name, then we have two name convertion: ceilometer_collector and this one storage_gnocchi | 13:46 |
huats | may we can decide to keep it that way and decide to do that properly in Pike ? | 13:46 |
liujiong | huats: agree! | 13:47 |
zhangguoqing_ | ceilometer_collector and gnocchi_collector | 13:47 |
huats | zhangguoqing_: we talk of storage there :) | 13:48 |
zhangguoqing_ | sure, I know that. | 13:48 |
huats | I know you do | 13:48 |
zhangguoqing_ | ok | 13:49 |
huats | so liujiong can you update your patch to keep the name as it is currently ? | 13:50 |
liujiong | huats: sure, will do it soon. | 13:51 |
aolwas | I'll merge it just after | 13:51 |
liujiong | aolwas: thank you. | 13:52 |
huats | zhangguoqing_: it is really important that you review https://review.openstack.org/#/c/406180/ | 13:53 |
huats | It is really something that needs to enter this cycle as soon as we can | 13:53 |
huats | because we would love to had the horizon integration on it too... | 13:54 |
zhangguoqing_ | OK, I will review it soon. | 13:54 |
huats | thanks ! | 13:55 |
zhangguoqing_ | another import thing is 'Added release note'. | 13:55 |
huats | liujiong: now that the patch from aaron has been merged you can work on https://review.openstack.org/#/c/349779/ again :) | 13:55 |
huats | zhangguoqing_: it will be merged really soon | 13:56 |
aolwas | I can put workflow+1 to 'added release note' right now if it's ok for every one | 13:57 |
huats | zhangguoqing_: can you also answer the questions on https://review.openstack.org/#/c/366043/ | 13:57 |
huats | ? | 13:57 |
huats | it would be a nice feature... | 13:57 |
huats | guys I think we are very close from the release and so many things opened | 13:58 |
openstackgerrit | Merged openstack/cloudkitty: [docs] Add rating module introduction https://review.openstack.org/404089 | 13:58 |
huats | I think we should say "no more new features" and let's concentrate on merging the one that already have patches sent | 13:58 |
huats | if you want to add something please ping me before starting to code it | 13:58 |
huats | would you agree ? | 13:58 |
liujiong | huats: fine. | 13:59 |
huats | zhangguoqing_: aolwas ? | 13:59 |
huats | we need to decrease that backlog.... | 13:59 |
aolwas | good for me | 14:00 |
*** zhangguoqing_ has quit IRC | 14:02 | |
huats | liujiong: aolwas any special thing you want to deal right now ? | 14:04 |
huats | liujiong: if you have any questions please ping me | 14:04 |
huats | I don't want you to stay with questions | 14:04 |
aolwas | nothing to add for the moment | 14:05 |
liujiong | none | 14:05 |
huats | ok liujiong | 14:05 |
huats | we have lost guoqing at the end | 14:05 |
huats | I'll try to contact him | 14:05 |
huats | thans for your hard work guys ! | 14:06 |
huats | we are getting closer of the release and all that is both really important and really appreciated | 14:06 |
huats | ! | 14:06 |
aolwas | thanks guys | 14:08 |
aolwas | bye | 14:08 |
liujiong | bye | 14:08 |
openstackgerrit | Jeremy Liu proposed openstack/cloudkitty: Fix wrong option names and missed options in cloudkitty.conf.sample https://review.openstack.org/329242 | 14:08 |
openstackgerrit | zhangguoqing proposed openstack/cloudkitty-dashboard: Added release note for cloudkittydashboard https://review.openstack.org/399323 | 14:20 |
*** zhangguoqing has joined #cloudkitty | 14:24 | |
openstackgerrit | zhangguoqing proposed openstack/python-cloudkittyclient: Added release note for cloudkittyclient https://review.openstack.org/399316 | 14:24 |
*** zhangguoqing has quit IRC | 14:26 | |
liujiong | This patch should be ready now https://review.openstack.org/#/c/329242/ | 14:35 |
openstackgerrit | Merged openstack/cloudkitty: Added release note for cloudkitty https://review.openstack.org/389669 | 14:39 |
*** gongysh has quit IRC | 14:48 | |
*** liujiong has quit IRC | 14:58 | |
*** sacharya has joined #cloudkitty | 15:04 | |
*** sacharya has quit IRC | 15:09 | |
*** jwcroppe has joined #cloudkitty | 15:28 | |
*** sacharya has joined #cloudkitty | 15:41 | |
*** sacharya_ has joined #cloudkitty | 16:11 | |
*** sacharya has quit IRC | 16:14 | |
openstackgerrit | Merged openstack/cloudkitty: Fix wrong option names and missed options in cloudkitty.conf.sample https://review.openstack.org/329242 | 16:37 |
*** sacharya has joined #cloudkitty | 18:17 | |
*** sacharya_ has quit IRC | 18:17 | |
*** openstackgerrit has quit IRC | 18:33 | |
*** jwcroppe has quit IRC | 21:01 | |
*** jwcroppe has joined #cloudkitty | 22:26 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!