Thursday, 2017-01-12

*** jwcroppe has joined #cloudkitty00:22
*** zhurong has joined #cloudkitty00:28
*** liujiong has joined #cloudkitty01:11
*** zhurong has quit IRC03:39
*** zhangguoqing has joined #cloudkitty04:00
*** sacharya has quit IRC05:25
*** zhurong has joined #cloudkitty06:23
*** sacharya has joined #cloudkitty06:25
*** sacharya has quit IRC06:30
*** logan- has quit IRC07:47
*** logan- has joined #cloudkitty07:56
*** sacharya has joined #cloudkitty08:01
*** sacharya has quit IRC08:06
*** jwcroppe has quit IRC08:41
*** jwcroppe has joined #cloudkitty08:42
*** jwcroppe has quit IRC08:46
*** sacharya has joined #cloudkitty09:01
*** sacharya has quit IRC09:06
*** zhangguoqing has quit IRC09:27
*** zhurong has quit IRC09:44
*** liujiong has quit IRC10:13
*** zhurong has joined #cloudkitty10:25
*** sacharya has joined #cloudkitty11:02
*** sacharya has quit IRC11:07
*** zhurong has quit IRC11:15
*** liujiong has joined #cloudkitty11:27
*** gongysh has joined #cloudkitty12:52
huatsHi there !13:02
*** sacharya has joined #cloudkitty13:03
liujiongHello, huats!13:03
huatsWe have meeting !13:04
huatsLet's wait a few minutes13:04
huatsfor late arrival13:04
liujiongYes, I remember.13:04
*** gongysh has quit IRC13:07
*** sacharya has quit IRC13:08
aolwashi every one13:11
aolwassorry for the delay13:11
huatsdon't worry13:12
huatswe were just waiting a bit for late arrivals13:12
liujiongIt's all right, aolwas.13:12
*** liujiong_lj has joined #cloudkitty13:15
*** liujiong has quit IRC13:17
*** liujiong_lj is now known as liujiong13:17
*** zhangguoqing_ has joined #cloudkitty13:18
zhangguoqing_I'm sorry that another thins brake me.13:19
huatshey guys13:20
huatsI think we can start13:20
liujiongOK.13:20
zhangguoqing_let's start. :)13:20
huatsSo I think we should continue on having a look at the current state of reviews13:21
liujiongAgree.13:23
zhangguoqing_https://review.openstack.org/#/c/329242/13:23
huatsfirst of all guys13:24
huatshave you been able to review the various things I pushe you ?13:24
zhangguoqing_https://review.openstack.org/#/c/393021/ has been merged.13:25
liujiongHmm, I've reviewed 'improve user experience', that looks good to me now.13:25
aolwasI've started to look at https://review.openstack.org/#/c/408518/ but didnt't have time to finish13:26
zhangguoqing_aolwas: thanks, you can communicate with me anytime.13:27
aolwasI've also looked at https://review.openstack.org/#/c/329242/ and found a potentiel compatibility break we need to discuss13:27
aolwasit may not have a lot of impact since few people may actually use gnocchi storage13:28
liujionglet me know that, huats.13:28
huatsliujiong: I am not sure what you are refering13:29
huatszhangguoqing_: can you please review https://review.openstack.org/#/c/404680/13:29
huats?13:29
liujiongThe patch refering to configuration file.13:29
zhangguoqing_aolwas: I can not agree with you, gnocchi stroage will be used widly.13:30
zhangguoqing_huats: No problem.13:30
liujiongI rename 'gnocchi_collector' section name. You mean this break compatibility?13:30
huatszhangguoqing_: will be used (for gnocchi storage) but it is not used right now...13:30
aolwasno, 'gnocchi_storage' which was 'storage_gnocchi'13:31
liujiongYes.13:31
liujiongYou mean this breaks compatibility?13:31
liujiongIf so, it's true.13:32
aolwasfor people currently using gnocchi for cloudkitty storage, since their current conf would be loaded correctly with this patch13:33
aolwasbut I don't know if it is really use today by anyone13:33
zhangguoqing_The key of 329242 is to delete cloudkitty.conf.sample file which we don't maintain it any more.13:35
liujiongIf needed, a warn can be logged telling people the section was renamed.13:36
*** gongysh has joined #cloudkitty13:36
aolwaszhangguoqing_ I agree but by doing this you also impact have you write the conf file13:36
liujiongor just keep the section name as original?13:37
huatszhangguoqing_: it is already deleted (cloudkitty.conf.sample)13:37
huatsI made a patch for that13:37
huatsIIRC13:38
aolwasliujiong I looked this morning how we could make the old name deprecated in oslo.config and keep it for compatibility but did not found a good way to di it13:38
aolwas'do'13:38
huatssorry I mixed13:38
liujionghuats: we are talking about the compatibility problem.13:39
huatsliujiong: I know you are, but I don't think zhangguoqing_ was :)13:39
liujiongaolwas: I have experience doing that, add the deprecation.13:40
aolwasto summarize we have two options13:42
aolwas- merge as it is now, since i think nobody currently use it13:43
aolwas- mark it deprecated and suppress the old name next cycle13:43
zhangguoqing_storage_gnocchi is good.13:45
aolwasfor sure, we need to be cautious when renaming things in cloudkitty13:45
aolwasor third option ... keep the name, you're right :)13:45
aolwasbut it make sense to have all section names homogeneous13:46
liujiongif we keep the name, then we have two name convertion: ceilometer_collector and this one storage_gnocchi13:46
huatsmay we can decide to keep it that way and decide to do that properly in Pike  ?13:46
liujionghuats: agree!13:47
zhangguoqing_ceilometer_collector  and gnocchi_collector13:47
huatszhangguoqing_: we talk of storage there :)13:48
zhangguoqing_sure, I know that.13:48
huatsI know you do13:48
zhangguoqing_ok13:49
huatsso liujiong can you update your patch to keep the name as it is currently ?13:50
liujionghuats: sure, will do it soon.13:51
aolwasI'll merge it just after13:51
liujiongaolwas: thank you.13:52
huatszhangguoqing_: it is really important that you review https://review.openstack.org/#/c/406180/13:53
huatsIt is really something that needs to enter this cycle as soon as we can13:53
huatsbecause we would love to had the horizon integration on it too...13:54
zhangguoqing_OK, I will review it soon.13:54
huatsthanks !13:55
zhangguoqing_another import thing is 'Added release note'.13:55
huatsliujiong: now that the patch from aaron has been merged you can work on https://review.openstack.org/#/c/349779/ again :)13:55
huatszhangguoqing_: it will be merged really soon13:56
aolwasI can put workflow+1 to 'added release note' right now if it's ok for every one13:57
huatszhangguoqing_: can you also answer the questions on https://review.openstack.org/#/c/366043/13:57
huats?13:57
huatsit would be a nice feature...13:57
huatsguys I think we are very close from the release and so many things opened13:58
openstackgerritMerged openstack/cloudkitty: [docs] Add rating module introduction  https://review.openstack.org/40408913:58
huatsI think we should say "no more new features" and let's concentrate on merging the one that already have patches sent13:58
huatsif you want to add something please ping me before starting to code it13:58
huatswould you agree ?13:58
liujionghuats: fine.13:59
huatszhangguoqing_: aolwas ?13:59
huatswe need to decrease that backlog....13:59
aolwasgood for me14:00
*** zhangguoqing_ has quit IRC14:02
huatsliujiong: aolwas any special thing you want to deal right now ?14:04
huatsliujiong: if you have any questions please ping me14:04
huatsI don't want you to stay with questions14:04
aolwasnothing to add for the moment14:05
liujiongnone14:05
huatsok liujiong14:05
huatswe have lost guoqing at the end14:05
huatsI'll try to contact him14:05
huatsthans for your hard work guys !14:06
huatswe are getting closer of the release and all that is both really important and really appreciated14:06
huats!14:06
aolwasthanks guys14:08
aolwasbye14:08
liujiongbye14:08
openstackgerritJeremy Liu proposed openstack/cloudkitty: Fix wrong option names and missed options in cloudkitty.conf.sample  https://review.openstack.org/32924214:08
openstackgerritzhangguoqing proposed openstack/cloudkitty-dashboard: Added release note for cloudkittydashboard  https://review.openstack.org/39932314:20
*** zhangguoqing has joined #cloudkitty14:24
openstackgerritzhangguoqing proposed openstack/python-cloudkittyclient: Added release note for cloudkittyclient  https://review.openstack.org/39931614:24
*** zhangguoqing has quit IRC14:26
liujiongThis patch should be ready now https://review.openstack.org/#/c/329242/14:35
openstackgerritMerged openstack/cloudkitty: Added release note for cloudkitty  https://review.openstack.org/38966914:39
*** gongysh has quit IRC14:48
*** liujiong has quit IRC14:58
*** sacharya has joined #cloudkitty15:04
*** sacharya has quit IRC15:09
*** jwcroppe has joined #cloudkitty15:28
*** sacharya has joined #cloudkitty15:41
*** sacharya_ has joined #cloudkitty16:11
*** sacharya has quit IRC16:14
openstackgerritMerged openstack/cloudkitty: Fix wrong option names and missed options in cloudkitty.conf.sample  https://review.openstack.org/32924216:37
*** sacharya has joined #cloudkitty18:17
*** sacharya_ has quit IRC18:17
*** openstackgerrit has quit IRC18:33
*** jwcroppe has quit IRC21:01
*** jwcroppe has joined #cloudkitty22:26

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!