| opendevreview | Merged openstack/cloudkitty master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/cloudkitty/+/793707 | 13:43 |
|---|---|---|
| rafaelweingartner | Hello guys :) | 13:57 |
| gXiah | Hi ! | 13:58 |
| mkarpiarz | Hi! | 14:00 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Jul 12 14:00:37 2021 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| rafaelweingartner | I hope that we have quorum today :) | 14:01 |
| mkarpiarz | :) | 14:01 |
| rafaelweingartner | Hey Marius, long time no see you | 14:02 |
| *** gXiah is now known as adamaquesbi | 14:02 | |
| mkarpiarz | Indeed! | 14:02 |
| mkarpiarz | What's on the agenda today? | 14:03 |
| rafaelweingartner | https://etherpad.opendev.org/p/cloudkitty-meeting-topics | 14:03 |
| rafaelweingartner | I would like to discuss the merging process | 14:03 |
| mkarpiarz | I've seen some nice features being pushed recently. | 14:03 |
| rafaelweingartner | yes | 14:03 |
| rafaelweingartner | and I published the reprocessing API already as well | 14:03 |
| rafaelweingartner | priteau: are you going to join the meeting? | 14:03 |
| priteau | I am here. | 14:05 |
| rafaelweingartner | Cool ! | 14:06 |
| rafaelweingartner | Shall we begin, then | 14:06 |
| adamaquesbi | yes | 14:06 |
| rafaelweingartner | #topic Review and merging process | 14:06 |
| priteau | yes | 14:06 |
| rafaelweingartner | We are a small community of contributors, and one thing that I noticed is that we are taking too long to get things merged. | 14:06 |
| rafaelweingartner | One thing that slows the process is the requirement for 2 core reviews. | 14:07 |
| rafaelweingartner | However, it is not just that, the process is also slow because, as we can see, there is only a handful of people contributing with the project. | 14:07 |
| rafaelweingartner | I have been thinking about this process, and I was going to propose to reduce the requirement for 2 core reviews, but I am not sure if this would help | 14:08 |
| rafaelweingartner | what do you guys think? | 14:08 |
| adamaquesbi | I think it might help speed up the main stories, but for the smaller ones it's still difficult to get even on reviewer to look at it let alone +1 it | 14:09 |
| priteau | I am not sure if the two +2 votes is a written or unwritten rule of OpenStack | 14:11 |
| priteau | I think it's useful to keep more eyes on the big changes. Happy to lower the requirements for smaller patches but that's not what is blocking us. | 14:11 |
| priteau | The real fix is to get more core reviewers ;-) | 14:11 |
| adamaquesbi | it's "encouraged" (https://docs.openstack.org/project-team-guide/review-the-openstack-way.html) | 14:12 |
| rafaelweingartner | I see | 14:12 |
| rafaelweingartner | I agree with you priteau | 14:12 |
| rafaelweingartner | but I am still unsure on how to get more people contributing | 14:13 |
| rafaelweingartner | I might be mistaken, but I am see some new names today, adamaquesbi :) | 14:13 |
| adamaquesbi | yes ! I am a new contributor (or trying to be at this stage) | 14:13 |
| rafaelweingartner | Cool | 14:14 |
| priteau | We could also take a look at the review runways model that nova is using | 14:14 |
| priteau | https://etherpad.opendev.org/p/nova-runways-rocky | 14:14 |
| adamaquesbi | I have been assigned to Cloudkitty by Objectif-libre (Paris, France) | 14:14 |
| priteau | adamaquesbi: good to hear that objectif libre is still interested! | 14:14 |
| rafaelweingartner | that is very welcome :), look forward to see you around gerrit | 14:14 |
| mkarpiarz | Cool, nice to meet you, adamaquesbi! | 14:14 |
| adamaquesbi | It is, and our goal is to be even more implicated in the project | 14:14 |
| adamaquesbi | Thanks ! | 14:14 |
| rafaelweingartner | Welcome | 14:15 |
| mkarpiarz | I agree we either need more reviewers or existing reviewers should spend more time reviewing changes. | 14:16 |
| rafaelweingartner | I mean, I try to review everything I can | 14:16 |
| rafaelweingartner | but sometimes, we fall short of a second pair of eyes on patches | 14:17 |
| rafaelweingartner | the nova process is interesting, but I am not sure how it would work for us | 14:17 |
| rafaelweingartner | for instance, if I propose a patch, let's say the reprocessing API | 14:17 |
| mkarpiarz | I can only help when I'm not working on something else and I know Pierre is involved in other OpenStack projects as well. | 14:17 |
| rafaelweingartner | then somobody else would need to review it | 14:18 |
| rafaelweingartner | mkarpiarz: exactly! | 14:18 |
| priteau | rafaelweingartner: I think it's about defining focus (let's all look at the same patches at the same time) and deadlines | 14:18 |
| adamaquesbi | I agree with @priteau | 14:19 |
| priteau | I have been out of the office due to house move recently, and had to catch up with various work projects last week. Going forward I should have more time for reviews. | 14:19 |
| rafaelweingartner | priteau: how can we sync/define the same target for use? I mean, should we try to somehow e-mail each other and, for instance, define a target patch for a month? | 14:20 |
| rafaelweingartner | or something like that | 14:20 |
| priteau | I would suggest an Etherpad to avoid email back and forth | 14:20 |
| priteau | And one large patch per two-week period (between each IRC meeting) | 14:21 |
| rafaelweingartner | That sounds good to me | 14:21 |
| adamaquesbi | what about smaller patches ? | 14:22 |
| priteau | I would like that we approve trivial patches quickly, so they don't stay polluting our review queue | 14:23 |
| priteau | I suggest a bi-weekly run over the trivial patches to make them go away | 14:24 |
| adamaquesbi | meaning two times a week, or once every two weeks ? | 14:25 |
| priteau | every two weeks, at the IRC meeting | 14:25 |
| priteau | For example please approve https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/800034 | 14:25 |
| rafaelweingartner | once every two weeks | 14:25 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/792313 | 14:25 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/791138 | 14:25 |
| priteau | https://review.opendev.org/c/openstack/cloudkitty-specs/+/791137 | 14:25 |
| priteau | Should we try this at least for the next month? | 14:28 |
| rafaelweingartner | I would say so | 14:28 |
| rafaelweingartner | do we define a target patch for this process? | 14:29 |
| rafaelweingartner | then we can sync back in our next meeting | 14:29 |
| priteau | yes, would be gerat | 14:29 |
| priteau | I suppose it's one of these: https://review.opendev.org/q/project:openstack/cloudkitty+status:open+label:Review-Priority%252B1 | 14:30 |
| rafaelweingartner | what if we start with https://review.opendev.org/c/openstack/cloudkitty/+/684734? | 14:33 |
| rafaelweingartner | that is a long standing one | 14:33 |
| rafaelweingartner | and, if that gets merged, it would trigger this other: https://review.opendev.org/c/openstack/cloudkitty/+/684747 | 14:33 |
| opendevreview | Merged openstack/cloudkitty-specs master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/cloudkitty-specs/+/791137 | 14:34 |
| priteau | Do you feel they are more important than your own features? | 14:34 |
| rafaelweingartner | no I do not, but I do not like to see these legacy things there :) | 14:34 |
| rafaelweingartner | I actually find the reporcessing API way more important | 14:35 |
| priteau | Time is limited so I would prefer to focus on features that we want to see in CloudKitty :) | 14:35 |
| rafaelweingartner | alright, so, what about https://review.opendev.org/c/openstack/cloudkitty/+/786651? | 14:35 |
| priteau | Sounds good, I started working on it before this meeting | 14:36 |
| opendevreview | Merged openstack/cloudkitty-dashboard master: Moving IRC network reference to OFTC https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/800034 | 14:36 |
| rafaelweingartner | it is an interesting feature that enables people to handle unexpected swaps in assumed ever growing metrics | 14:36 |
| adamaquesbi | sounds good | 14:36 |
| rafaelweingartner | it is a plan then | 14:37 |
| rafaelweingartner | Ok, I added it to etherpad already as the target review of the meeting | 14:38 |
| priteau | Do you have a link to this etherpad? | 14:39 |
| rafaelweingartner | I used the same etherpad that we use for meeting | 14:39 |
| rafaelweingartner | should we create one just for these patches? | 14:40 |
| priteau | Should be fine, as long as we know where it is | 14:40 |
| rafaelweingartner | Yes, that is why I thought that using the same etherpad would facilitate things | 14:41 |
| rafaelweingartner | So, moving on, I would like to brifly discuss Xena release | 14:41 |
| rafaelweingartner | #topic Xena release | 14:41 |
| rafaelweingartner | the open patches that I have, I think that they are interesting to get into this release, but I am not sure if it is feasible for us to review all of them | 14:42 |
| rafaelweingartner | therefore, I would like to at least define one target major feature | 14:42 |
| rafaelweingartner | for me, the most interesting is the reprocessing API | 14:42 |
| rafaelweingartner | therefore, this is one thing that I would like to work towards to get into Xena | 14:43 |
| priteau | I think for me too | 14:43 |
| rafaelweingartner | do you guys have other preferences? | 14:43 |
| adamaquesbi | I have been looking at the work that's been done on CK the last few weeks/months, and I too think that the API should be dealt with first | 14:44 |
| rafaelweingartner | Cool, it seems that we are on the same page | 14:45 |
| rafaelweingartner | maybe we can target it, after the custom gnocchi query | 14:45 |
| adamaquesbi | yes | 14:45 |
| rafaelweingartner | that patch is quite long, specially the unit testing part | 14:45 |
| rafaelweingartner | I tried to cover all of the processing/reprocessing code with unit testings, as it is a sensitive piece of code | 14:45 |
| adamaquesbi | we can divide it into two patches then maybe ? | 14:46 |
| mkarpiarz | Personally I'd like this one to be merged since I've tested it and can confirm it's working: https://review.opendev.org/c/openstack/cloudkitty/+/778922 | 14:46 |
| rafaelweingartner | mkarpiarz: that is a quick win, I would say | 14:46 |
| rafaelweingartner | it is smaller, and easier to review, than the others I guess | 14:47 |
| priteau | I will try to review it before tackling the big gnocchi one | 14:47 |
| mkarpiarz | Cool, do we need another +2 or +1 then? | 14:48 |
| rafaelweingartner | awesome thanks | 14:48 |
| mkarpiarz | Ah, thanks priteau. | 14:48 |
| rafaelweingartner | Do you guys have some other review priorities to ask for? | 14:48 |
| mkarpiarz | Nope. | 14:49 |
| adamaquesbi | I do have a minor patch : https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 14:49 |
| priteau | adamaquesbi: you don't need the big comment block with Proposed fix for story#2006672, task#36940 | 14:51 |
| rafaelweingartner | Ok | 14:51 |
| adamaquesbi | Alright, should I remove it ? | 14:52 |
| rafaelweingartner | i think that we can post the comments there | 14:52 |
| adamaquesbi | I have some comments in other projects too | 14:52 |
| rafaelweingartner | and discuss the code changes in the patch, otherwise it will become a bit complicated to track suggestions | 14:52 |
| priteau | I'll post comments on Gerrit | 14:53 |
| rafaelweingartner | guys, we are running out of time. Therefore, before we close it for today. I will open for general topics then. | 14:53 |
| rafaelweingartner | #topic AOB | 14:53 |
| priteau | The next virtual PTG will take place October 18-22, 2021. | 14:54 |
| mkarpiarz | Ah, thanks for the reminder! | 14:55 |
| opendevreview | adam aquesbi proposed openstack/cloudkitty master: Avoid DivByZero if there is no metrics to collect https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 14:55 |
| priteau | Registration: https://openinfra-ptg.eventbrite.com/ | 14:55 |
| priteau | We should start thinking about date/time. I think it worked well when we used time of the IRC meeting | 14:55 |
| rafaelweingartner | yes | 14:56 |
| priteau | To signup your team, you must complete BOTH the survey[1] AND reserve time in the ethercalc[2] by end of day July 21. | 14:56 |
| rafaelweingartner | I put it in the agenda for the next meeting | 14:56 |
| rafaelweingartner | I will have to close now | 14:57 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:57 |
| priteau | We need to sign up *before* the next meeting | 14:57 |
| rafaelweingartner | #endmeeting | 14:57 |
| opendevmeet | Meeting ended Mon Jul 12 14:57:42 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:57 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-07-12-14.00.html | 14:57 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-07-12-14.00.txt | 14:57 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-07-12-14.00.log.html | 14:57 |
| adamaquesbi | Nice week to you all | 14:58 |
| priteau | rafaelweingartner: did you see my last message? we will need to reserve time before the next IRC meeting | 14:59 |
| rafaelweingartner | yes | 14:59 |
| rafaelweingartner | I will put in my agenda | 14:59 |
| rafaelweingartner | and talk with you guys via e-mail | 15:00 |
| priteau | ok | 15:01 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/791138 | 15:12 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: Use TOX_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/792313 | 15:12 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: [ussuri][goal] Update contributor documentation https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/791318 | 15:13 |
| opendevreview | Pierre Riteau proposed openstack/python-cloudkittyclient master: Fix creation of hashmap mapping with a zero cost https://review.opendev.org/c/openstack/python-cloudkittyclient/+/800524 | 17:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!