opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add rating modules GET endpoints to v2 API https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 11:14 |
---|---|---|
opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add rating modules GET endpoints to v2 API https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 12:11 |
rafaelweingartner | Hello Guys | 13:45 |
mkarpiarz | Hi, Rafeal! | 13:50 |
rafaelweingartner | #startmeeting cloudkitty | 14:00 |
opendevmeet | Meeting started Mon Mar 21 14:00:04 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
rafaelweingartner | Roll count | 14:00 |
rafaelweingartner | \o | 14:00 |
priteau | Hello | 14:01 |
priteau | o/ | 14:01 |
mkarpiarz | Hi! | 14:01 |
rafaelweingartner | Nice to see you all here :) | 14:02 |
rafaelweingartner | #topic Virtual PTG April 2022 | 14:02 |
rafaelweingartner | We've marked April 4, at 13:00-16:00 UTC [1]. We already have a CloudKitty meeting organized for this day. Therefore, it seems the most practical choice. The room we selected is called "Cactus". | 14:03 |
rafaelweingartner | I've also created an etherpad [2] to collect ideas/topics for the PTG sessions. If you have anything to discuss, please don't hesitate to write it there. | 14:03 |
rafaelweingartner | [1] https://ethercalc.openstack.org/7yxdas7suqnd | 14:03 |
rafaelweingartner | [2] https://etherpad.opendev.org/p/cloudkitty-ptg-zed | 14:03 |
rafaelweingartner | Moving on... | 14:04 |
rafaelweingartner | #topic OpenInfra Summit Berlin 2022 | 14:04 |
priteau | Thank you rafaelweingartner | 14:05 |
priteau | Remember to update the Etherpad link with the bot | 14:05 |
priteau | So it shows up in https://ptg.opendev.org/etherpads.html | 14:05 |
rafaelweingartner | Hmm | 14:05 |
rafaelweingartner | I think that I missed that | 14:05 |
rafaelweingartner | how do I do that? | 14:06 |
priteau | It will be done via the ptg IRC bot, probably closer to the event date | 14:07 |
rafaelweingartner | ah ok | 14:07 |
priteau | I am not sure if it is online yet | 14:07 |
rafaelweingartner | I see | 14:07 |
rafaelweingartner | I added a note here | 14:08 |
rafaelweingartner | I will see how to do that then | 14:08 |
rafaelweingartner | Thansk priteau! | 14:10 |
rafaelweingartner | So, moving on with the Summi topic. One of my CloudKitty presentations was accepted! Also, I suggest you guys to attend the event, it will be great opportunity to meet the OpenStack community. | 14:10 |
rafaelweingartner | I hope we see each other there | 14:10 |
priteau | I am planning to attend too | 14:11 |
mkarpiarz | Congratulation, Rafael! | 14:11 |
rafaelweingartner | Awesome! | 14:12 |
priteau | Well done on your talk. Mine was rejected :( | 14:12 |
rafaelweingartner | :( | 14:12 |
rafaelweingartner | I was hoping we would have more cloudkity talks | 14:13 |
priteau | Well, mine was on Blazar, not CloudKitty | 14:13 |
rafaelweingartner | I see | 14:13 |
rafaelweingartner | Now, moving on with the target review of the week. | 14:16 |
rafaelweingartner | #topic Target review of the meeting | 14:16 |
rafaelweingartner | We have the following patches as target for this meeting. | 14:16 |
rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:17 |
rafaelweingartner | Conflicts were resolved | 14:17 |
rafaelweingartner | And, now, we can move on with the review | 14:17 |
rafaelweingartner | I also addressed priteau requests there | 14:17 |
priteau | Thank you. I will take another look. | 14:18 |
priteau | rafaelweingartner: some comments are stil unresolved | 14:20 |
priteau | See https://review.opendev.org/c/openstack/cloudkitty/+/684734/10/cloudkitty/api/v2/rating/__init__.py | 14:20 |
rafaelweingartner | ah | 14:21 |
rafaelweingartner | I see | 14:21 |
rafaelweingartner | I missed that one | 14:21 |
priteau | Have you noticed, there is a counter of the number of unresolved comments on each patch | 14:21 |
priteau | Just under the commit message box at https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:21 |
opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add rating modules GET endpoints to v2 API https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:21 |
rafaelweingartner | hmm | 14:22 |
rafaelweingartner | now I see | 14:22 |
rafaelweingartner | I never paid attention to that message there | 14:22 |
priteau | Can you add a release note? | 14:26 |
rafaelweingartner | sure | 14:26 |
rafaelweingartner | done | 14:27 |
opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Add rating modules GET endpoints to v2 API https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:27 |
priteau | Also I believe we should avoid merging this until Yoga is released | 14:28 |
priteau | This is to make it easier to backport a high priority fix from master to stable/yoga | 14:29 |
rafaelweingartner | I agree | 14:29 |
rafaelweingartner | done | 14:31 |
rafaelweingartner | Moving on to the next patch, #link https://review.opendev.org/c/openstack/cloudkitty/+/824745, which is still waiting for the feedback from the author. | 14:32 |
priteau | I am afraid I didn't have time to discuss with him or review the patcg | 14:33 |
rafaelweingartner | ok, no worries | 14:33 |
rafaelweingartner | do you guys have other patches? | 14:34 |
mkarpiarz | Nope. | 14:34 |
priteau | Nothing from me | 14:34 |
rafaelweingartner | Thanks | 14:35 |
rafaelweingartner | and now, for the last topic | 14:35 |
rafaelweingartner | #topic Open floor moment | 14:35 |
rafaelweingartner | Do you guys have anything else do add in the meeting? | 14:35 |
priteau | I should mention I approved so patches with a single +2 last week for release preparations | 14:36 |
priteau | Minor things related to release notes | 14:36 |
priteau | cloudkitty-dashboard release notes were missing (infra problem during upload I am guessing), so I merged https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/834272 to force them to update | 14:37 |
priteau | And then all the various OpenStack release bot patches | 14:37 |
priteau | It's important to merge these patches quickly during the release preparation | 14:38 |
mkarpiarz | This is fine by me. Thanks, Pierre! | 14:38 |
priteau | And also added release notes links via https://review.opendev.org/c/openstack/releases/+/834268 | 14:38 |
rafaelweingartner | Thanks Pierre | 14:38 |
rafaelweingartner | whenever I see tha patches I aprove | 14:39 |
rafaelweingartner | but maybe I missed the emails | 14:39 |
priteau | For example this one was waiting: https://review.opendev.org/c/openstack/cloudkitty/+/832610 | 14:39 |
priteau | Submitted March 8 | 14:39 |
rafaelweingartner | Sorry for that Pierre | 14:39 |
priteau | No worries, just mentioning it for next time :) | 14:40 |
priteau | mkarpiarz: Would you be able to approve these backports: https://review.opendev.org/q/project:openstack/cloudkitty+-branch:master+status:open | 14:40 |
mkarpiarz | Sure. Do you want me to also merge them or should I wait? | 14:42 |
rafaelweingartner | I think that you can merge already | 14:42 |
priteau | Please merge when you are the second +2 | 14:42 |
priteau | Unless there is a strong reason not to | 14:43 |
priteau | i.e. first core vote is +2, second core vote is +2 W+1 | 14:43 |
priteau | mkarpiarz: are you planning to be at the summit? | 14:44 |
mkarpiarz | Yes, I am. :) | 14:46 |
rafaelweingartner | Awesome! | 14:46 |
priteau | Great! | 14:47 |
rafaelweingartner | Is that all? | 14:49 |
priteau | All for me | 14:49 |
mkarpiarz | Nothing from my side. | 14:50 |
rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:50 |
rafaelweingartner | #endmeeting | 14:50 |
opendevmeet | Meeting ended Mon Mar 21 14:50:40 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:50 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-03-21-14.00.html | 14:50 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-03-21-14.00.txt | 14:50 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-03-21-14.00.log.html | 14:50 |
mkarpiarz | Thank you all! | 14:51 |
priteau | Bye guys | 14:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!