| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Mon Aug 19 14:00:28 2024 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Hello guys! | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| rafaelweingartner | \o | 14:00 |
| priteau | o/ | 14:01 |
| rafaelweingartner | I guess its just us today =) | 14:03 |
| rafaelweingartner | #topic Target reviews | 14:03 |
| rafaelweingartner | Pedro and I discusse the situation with the tempest tests #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 14:03 |
| rafaelweingartner | and instead of creating new branches, and so on, which seemed way more work | 14:04 |
| rafaelweingartner | we decided to adapt the tests to work with both, the current state of the APIs, and the new state of the patch in #link https://review.opendev.org/c/openstack/cloudkitty/+/876643 | 14:04 |
| rafaelweingartner | what do you think? | 14:04 |
| rafaelweingartner | this way, we can merge the tempest tests | 14:04 |
| rafaelweingartner | and then the code | 14:04 |
| priteau | I am checking | 14:05 |
| priteau | It looks OK testing-wise, I left some minor comments about typos/wording | 14:07 |
| priteau | However this highlights to me that we shouldn't be making such changes in behaviour without bumping the API | 14:08 |
| priteau | Other projects have microversions for this. | 14:08 |
| rafaelweingartner | yes, but then we would need to introduce this kind of processes, which would take some good amount of energy | 14:09 |
| priteau | That's true | 14:09 |
| rafaelweingartner | I mean, I am in favor of it | 14:09 |
| rafaelweingartner | but, I am not sure if it would be doable for ourside now | 14:10 |
| rafaelweingartner | after Pedro updates the patch, can we merge it? | 14:10 |
| rafaelweingartner | I mean, would you be ok with the merge? | 14:10 |
| priteau | I can't say that I fully support it but I don't want to delay progress | 14:12 |
| priteau | So I will approve. | 14:13 |
| rafaelweingartner | Hmm | 14:15 |
| rafaelweingartner | What would be the concens with it? | 14:15 |
| rafaelweingartner | I mean, we are introducing a method to facilitate the life of people when scheduling/preparing rating rules | 14:16 |
| priteau | It is still an API change | 14:17 |
| priteau | It might break automation that people have in place | 14:18 |
| rafaelweingartner | if they have :) | 14:18 |
| rafaelweingartner | I see what you mean, but I have no idea on how to propose something like we are proposing, withotu changing the API | 14:18 |
| priteau | https://specs.openstack.org/openstack/api-wg/guidelines/api_interoperability.html#evaluating-api-changes | 14:18 |
| rafaelweingartner | I mean, we can introduce versioning | 14:19 |
| priteau | That's the point of using microversions | 14:19 |
| rafaelweingartner | but it would be so much work for so little gain | 14:19 |
| rafaelweingartner | and right now CloudKitty has an even bigger issue | 14:20 |
| rafaelweingartner | every reprocessing can generate different outcomes for unaware users | 14:20 |
| rafaelweingartner | then, of course, we can blame the user | 14:20 |
| priteau | This is why I am saying that I won't fight against it, just letting you know this is kind of against OpenStack guidelines / design. | 14:20 |
| rafaelweingartner | but, if we face the situaiton, the software if limited | 14:20 |
| rafaelweingartner | the change we are introducing requires a versiong change, but we do not need MV for that | 14:22 |
| rafaelweingartner | We are already doing that | 14:22 |
| rafaelweingartner | we will release this new behavior in a new major version, right? | 14:22 |
| priteau | I see, you are talking about the software version | 14:23 |
| priteau | Yes, there will be a major version bump | 14:23 |
| priteau | But the client/user doesn't see this (it is not exposed to them via the API) | 14:23 |
| priteau | Which is why there are also API versions (unrelated from software versions) | 14:23 |
| priteau | e.g. Nova: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html | 14:24 |
| rafaelweingartner | yes, but that is not necessary a requirement, right? | 14:24 |
| priteau | See the guideline link I posted above | 14:26 |
| rafaelweingartner | I know about it | 14:28 |
| rafaelweingartner | but that is what I am saying, we are adding/changing a new behavior in a new software version] | 14:28 |
| rafaelweingartner | that is what the guideline is about | 14:28 |
| rafaelweingartner | but anyways, I see that you are against it. I understand the decision, and I will see if we can (how to) overcome this kind of situation | 14:29 |
| priteau | I am pretty sure the guideline is talking about API versioning, not software (git) version | 14:29 |
| rafaelweingartner | that is up to interpretation | 14:30 |
| rafaelweingartner | as many other things in openstack management | 14:30 |
| rafaelweingartner | but I will discuss here how to acomodate what you suggested | 14:30 |
| priteau | As I said earlier I don't want to delay features just because of this, since we have limited manpower | 14:31 |
| rafaelweingartner | I see, but I understand what you mean. Therefore, let's follow the rule to the letter. It is better than to now follow the rule. | 14:33 |
| rafaelweingartner | That was basically it from our side here. Do you have any priority or attention that is needed in some specific patch? | 14:37 |
| priteau | Just a note that feature freeze is next week | 14:39 |
| priteau | And if we need any client changes, that needs to be released before Thursday next week | 14:39 |
| rafaelweingartner | I see | 14:41 |
| rafaelweingartner | I guess we will not make it then with that feature | 14:41 |
| rafaelweingartner | but that is fine | 14:41 |
| priteau | Unrelated, there are issues with testing of some unmaintained branches. | 14:41 |
| priteau | > keystoneauth1.exceptions.catalog.EndpointNotFound: internalURL endpoint for metric service in RegionOne region not found | 14:41 |
| priteau | Could be some issue with gnocchi rather than cloudkitty | 14:42 |
| rafaelweingartner | I am not sure | 14:42 |
| rafaelweingartner | do you know what error they are receiving? | 14:42 |
| rafaelweingartner | Gnocchi has not had a release in some good amount of time | 14:42 |
| rafaelweingartner | we are working towards a new release right now | 14:42 |
| priteau | I don't even see Gnocchi being deployed in https://dfcf198ef61f2cfa2f98-d07beda532036ff76a0dc6dba516b61f.ssl.cf5.rackcdn.com/911121/1/check/cloudkittyclient-devstack-functional-v1-client/613809a/ | 14:43 |
| rafaelweingartner | no idea | 14:45 |
| rafaelweingartner | there is a build issue before that error | 14:45 |
| rafaelweingartner | might be related | 14:45 |
| priteau | I can take a look at it | 14:46 |
| rafaelweingartner | ok | 14:46 |
| priteau | Nevermind, this error happens in master too, which works | 14:48 |
| priteau | I found the actual issue in the logs, I will check if I can fix it | 14:49 |
| priteau | It's a tox issue | 14:49 |
| rafaelweingartner | I see | 14:53 |
| priteau | This might fix it: https://review.opendev.org/c/openstack/python-cloudkittyclient/+/926540 | 14:53 |
| priteau | Please check in one hour if Zuul has passed | 14:53 |
| rafaelweingartner | I see | 14:54 |
| rafaelweingartner | ok | 14:54 |
| rafaelweingartner | Then I merge it | 14:54 |
| rafaelweingartner | I guess that was it for today. | 14:55 |
| rafaelweingartner | Do you have something else to add before we close? | 14:55 |
| priteau | Nothing else. | 14:56 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:56 |
| rafaelweingartner | #endmeeting | 14:56 |
| rafaelweingartner | #endmeeting | 14:56 |
| opendevmeet | Meeting ended Mon Aug 19 14:56:43 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:56 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-19-14.00.html | 14:56 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-19-14.00.txt | 14:56 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-19-14.00.log.html | 14:56 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 15:39 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty master: Introduce start and end dates on rating rules https://review.opendev.org/c/openstack/cloudkitty/+/876643 | 15:42 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 17:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!