| *** openstack has joined #craton | 09:46 | |
| *** openstackstatus has quit IRC | 10:13 | |
| *** openstack has joined #craton | 10:14 | |
| *** Mudpuppy has joined #craton | 10:22 | |
| *** Mudpuppy has quit IRC | 10:27 | |
| sigmavirus | sulo: I think I might actually finish the project_id works oon | 12:02 |
|---|---|---|
| sigmavirus | *today | 12:02 |
| *** acabot has joined #craton | 12:27 | |
| sulo | sigmavirus: awesome !! and thanks !! | 12:41 |
| *** openstackstatus has quit IRC | 12:43 | |
| *** openstack has joined #craton | 12:44 | |
| *** VW has joined #craton | 13:13 | |
| *** Mudpuppy has joined #craton | 14:09 | |
| sulo | https://review.openstack.org/#/c/386583 for some reviews pls | 14:38 |
| *** jovon has joined #craton | 14:38 | |
| sigmavirus | jimbaker: sulo I made this public security because I just submitted a review to fix it https://bugs.launchpad.net/craton/+bug/1628917 | 14:43 |
| openstack | Launchpad bug 1628917 in craton "User can create resources in another project" [High,Confirmed] | 14:43 |
| sigmavirus | Oh right, the infra review merged last night so we now have logging courtesy of openstack :D | 14:43 |
| *** syed_ has joined #craton | 15:19 | |
| sulo | sigmavirus: cool. thanks. patch is failing a few tests, but looks like minor fixups | 15:44 |
| syed_ | sulo: hi, a quick question, so i am trying to write the cell_update part in test api and having an error | 15:48 |
| syed_ | https://gist.github.com/ahsan518/fd7d0cd452e01c08217cb1253e1bf7a9 | 15:48 |
| sulo | looks like that is failing validation ?? | 15:49 |
| syed_ | yes, returning mismatch -- impl.MismatchError: 200 != 422 | 15:49 |
| syed_ | i am just getting CELL1 from fake resources and changing name though .. | 15:50 |
| sulo | yeah .. so i mean .. its failing validation | 15:51 |
| sigmavirus | sulo: ah yeah, I forgot to run them locally | 15:51 |
| sulo | syed_: when you run that on a running server .. do you see sqlalchemy error | 15:56 |
| sulo | ? | 15:56 |
| sulo | i mean api .. not db | 15:56 |
| sulo | any error | 15:56 |
| syed_ | I tried the normal update cell call and it was working | 15:58 |
| syed_ | https://www.irccloud.com/pastebin/co3WjRFE/ | 15:58 |
| sulo | but thats differnt from ur test | 15:59 |
| syed_ | yes that was for a different cell name | 15:59 |
| sulo | the payload is differnt | 16:00 |
| syed_ | yes, its using the Fake Resources, so there it should be changing the name from earlier to Cell_New1 | 16:00 |
| syed_ | let me run it again and see | 16:00 |
| sigmavirus | sulo: tests should be fixed | 16:02 |
| sulo | sigmavirus: thanks | 16:02 |
| sigmavirus | sulo: jimbaker so one thing I noticed is that our project schema is going to break keystone integration | 16:02 |
| sigmavirus | I think | 16:02 |
| sulo | really ? | 16:02 |
| sigmavirus | Wait, hold on | 16:03 |
| sigmavirus | Let me double check | 16:03 |
| sigmavirus | Yeah, so project-id is literally it's id, and that's the project_id we expect in relations (devices, etc.) | 16:04 |
| sigmavirus | And project.id will always be an integer | 16:04 |
| sigmavirus | But keystone project-ids are typically uuids | 16:04 |
| sulo | yeah | 16:04 |
| sigmavirus | So when someone is using Keystone for auth, and we pull the tenant/project-id from the context | 16:04 |
| sigmavirus | How are we going to store that in the db? | 16:04 |
| sigmavirus | are we going to store the keystone project uuid as the name and create our own project id that we use? | 16:05 |
| sulo | yeah :( | 16:05 |
| sulo | we should probably change the project schema | 16:06 |
| jimbaker | sigmavirus, fair enough | 16:06 |
| * sigmavirus brb | 16:07 | |
| sulo | syed_: did that fix your problem ? | 16:10 |
| sulo | syed_: actually this is not going to work .. you will need to restrict what can get updated | 16:15 |
| sulo | like you cant update project or region ids once created | 16:15 |
| sulo | etc | 16:15 |
| syed_ | sulo: i see, will work over it, thanks | 16:17 |
| sigmavirus | jimbaker: sulo so... should I change the schema? | 17:39 |
| sulo | sigmavirus: +1, what are you thinking though ? adding project_id ? | 17:41 |
| sigmavirus | sulo: I was thinking of just changing the constraint from int to varchar | 17:42 |
| jimbaker | sigmavirus, works for me | 18:11 |
| jimbaker | basically project_id should be considered an external identifier, and a string is the most general description | 18:11 |
| jimbaker | we see something similar in terms of our taskflow integration | 18:11 |
| jimbaker | we already have this with respect to device names. we may need to add more foreign identifiers over time. tbd | 18:11 |
| sigmavirus | hm, using the dockerfile on a 16.04 cloudserver and EXPOSE doesn't seem to be working as expected. I can't curl the service | 18:35 |
| *** VW has quit IRC | 18:35 | |
| *** VW has joined #craton | 18:41 | |
| sigmavirus | jimbaker: you have problems with this before? | 18:42 |
| jimbaker | sigmavirus, i haven't had a problem with the docker usage | 18:43 |
| sulo | i use Ubuntu 16.04.1 LTS cs with no problem | 18:43 |
| *** jovon_ has joined #craton | 18:44 | |
| sigmavirus | maybe I'm missing something? I've just been using docker run | 18:44 |
| jimbaker | i can try again - but basically i run docker every single time i look at code in review | 18:45 |
| sigmavirus | was missing the -P flag | 18:46 |
| jimbaker | looking forward to that being in our CI | 18:46 |
| sigmavirus | wasn't exposing the ports on the host | 18:46 |
| jimbaker | yes, -p would be important - it's one of the nice aspects of the docker model | 18:47 |
| Mudpuppy | can't p without tcp! | 18:47 |
| *** _d34dh0r53_ has joined #craton | 18:51 | |
| *** jovon has quit IRC | 18:51 | |
| *** d34dh0r53 has quit IRC | 18:51 | |
| *** palendae has quit IRC | 18:51 | |
| *** jovon_ is now known as jovon | 18:52 | |
| *** Mudpuppy has quit IRC | 19:00 | |
| sulo | ok one more https://review.openstack.org/#/c/386747/ | 19:09 |
| jimbaker | sulo, could we constrain with with_polymorphic in this case? | 19:13 |
| sulo | jimbaker: actually yeah, that might be better use case for this | 19:14 |
| jimbaker | i know we have this additional type distinction, which iirc we have been using to distinguish with respect to a container | 19:14 |
| jimbaker | ack | 19:14 |
| *** palendae has joined #craton | 19:17 | |
| *** palendae is now known as Guest37578 | 19:17 | |
| sulo | looks like i was actually already doing that for one of them atleast | 19:17 |
| *** lcastell has quit IRC | 20:03 | |
| *** lcastell has joined #craton | 20:05 | |
| *** Mudpuppy has joined #craton | 20:13 | |
| *** Mudpuppy_ has joined #craton | 20:13 | |
| *** Mudpuppy has quit IRC | 20:17 | |
| *** lcastell has quit IRC | 20:24 | |
| *** lcastell has joined #craton | 20:26 | |
| *** VW has quit IRC | 20:30 | |
| *** VW has joined #craton | 20:41 | |
| *** VW has quit IRC | 20:46 | |
| *** VW has joined #craton | 22:03 | |
| *** VW has quit IRC | 22:03 | |
| *** VW has joined #craton | 22:03 | |
| *** VW_ has joined #craton | 22:10 | |
| *** VW has quit IRC | 22:13 | |
| *** VW_ has quit IRC | 22:14 | |
| syed_ | guys, i have updated a new patch set, it is missing the tests for network right now, i would appreciate if you guys can take a look and let me know if any changes are needed : https://review.openstack.org/#/c/384817/5 | 22:27 |
| syed_ | https://review.openstack.org/#/c/384817 | 22:58 |
| *** VW has joined #craton | 23:00 | |
| *** Mudpuppy_ has quit IRC | 23:03 | |
| *** VW has quit IRC | 23:04 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!