*** ahsa518 has joined #craton | 00:17 | |
*** ahsa518 has quit IRC | 00:21 | |
*** ahsa518 has joined #craton | 00:21 | |
syed_ | sulo: | 01:08 |
---|---|---|
syed_ | i am getting this error when i try to pass the net_interface_update test | 01:08 |
syed_ | https://gist.github.com/ahsan518/9e34867ef8fed9c77f280ccaabce0022 | 01:08 |
syed_ | sqlalchemy.exc.InvalidRequestError: Object '<NetInterface at 0x7f5fa5beb1d0>' is already attached to session '84' (this is '83') | 01:08 |
syed_ | So it says that object already exists | 01:08 |
syed_ | https://gist.github.com/ahsan518/9e34867ef8fed9c77f280ccaabce0022#file-error-L9 | 01:09 |
syed_ | i guess this is causing the issue maybe .... | 01:09 |
syed_ | oops | 01:19 |
syed_ | sorry, i figured that one out | 01:19 |
syed_ | my bad guys ! | 01:19 |
*** valw has joined #craton | 02:02 | |
*** valw_ has joined #craton | 02:04 | |
*** valw has quit IRC | 02:07 | |
*** VW has joined #craton | 02:45 | |
*** VW has quit IRC | 03:18 | |
*** valw_ has quit IRC | 03:29 | |
*** ahsa518 has quit IRC | 03:29 | |
*** syed_ has quit IRC | 04:24 | |
*** VW has joined #craton | 05:19 | |
*** VW has quit IRC | 05:23 | |
sulo | sayed_: i left some comments on your patch https://review.openstack.org/#/c/384817 | 09:45 |
sulo | small fixes needed | 09:45 |
sulo | jimbaker: yeah, i think its probably wise to not spend more time on the workflow .. i doubt that this will be ready for any sort of demo | 10:37 |
sulo | jimbaker: think we should just spend time on the actual presentation | 10:37 |
sulo | i will have some screenshots of workflow from resolver etc .. just to give context | 10:38 |
*** VW has joined #craton | 12:19 | |
*** VW has quit IRC | 12:23 | |
sulo | sigmavirus: i think i know why that test passed | 12:49 |
sigmavirus | sulo: oh? | 12:50 |
sulo | sigmavirus: i think that mock order is wrong (probalby my doing) | 12:50 |
sigmavirus | aha | 12:50 |
sigmavirus | let me investigate that | 12:50 |
sigmavirus | sulo: looking at the docs, that is indeed the problem | 12:52 |
sigmavirus | (unittest.mock docs) | 12:52 |
sigmavirus | so pushing a new patchset with the user_id set to 1, and the patch ordering swapped | 12:52 |
sulo | damn unit test, can make anything pass | 12:53 |
sulo | but i guess kinda my fault for using the same id and not testing the first bit | 12:54 |
sulo | awesome catch though :) | 12:54 |
sigmavirus | sulo: tests caught it | 12:58 |
sigmavirus | This is also, why I like to check more than just one attribute in at est | 12:58 |
sigmavirus | but *shrug* | 12:58 |
sigmavirus | I have what appears to be a very bizarre approach to testing | 12:59 |
sigmavirus | sulo: fixed :D https://review.openstack.org/#/c/386646/ | 13:12 |
*** valw has joined #craton | 13:55 | |
*** valw has quit IRC | 14:03 | |
*** Tamayo has joined #craton | 14:07 | |
jimbaker | sulo, re workflow support - i believe there's some good stuff there, but clearly not ready yet | 14:25 |
sulo | yeah, lets revisit the workflow stuff after the summit | 14:29 |
*** syed_ has joined #craton | 14:47 | |
jimbaker | sulo, in terms of implementation :) | 14:50 |
jimbaker | i expect the actual architecture/design will be a big focus for next week | 14:50 |
jimbaker | in particular: using tooling like docker swarm | 14:51 |
syed_ | sulo: Thanks for the reviews. Have updated the patch. | 14:54 |
*** VW has joined #craton | 15:02 | |
* sigmavirus thinks he has a way to get keystone working with craton | 15:03 | |
jimbaker | sigmavirus, awesome | 15:12 |
*** chrisspencer_ has joined #craton | 15:13 | |
*** Mudpuppy has joined #craton | 15:45 | |
*** Mudpuppy has quit IRC | 15:48 | |
lcastell | \o/ | 15:56 |
sigmavirus | So far, no joy but Soon™ | 15:57 |
syed_ | sigmavirus: thanks Ian for the reviews | 15:57 |
syed_ | Glad for the keystone work :) | 15:57 |
syed_ | i hope it works | 15:57 |
sigmavirus | I doubt it will | 16:00 |
sigmavirus | Everything I touch turns to sadness | 16:00 |
jimbaker | sigmavirus, i'm just hearing the voice of marvin the robot now in my head... | 16:01 |
jimbaker | http://images.amcnetworks.com/bbcamerica.com/wp-content/uploads/2014/05/marvin.jpg | 16:02 |
syed_ | haha | 16:03 |
syed_ | :D | 16:03 |
* sigmavirus has no clue who Marvin teh Robot is | 16:11 | |
jimbaker | sigmavirus, how to get in touch with one's inner marvin: http://www.bbcamerica.com/anglophenia/2014/05/happy-towel-day-six-life-lessons-live-marvin-paranoid-android | 16:15 |
* sigmavirus keeps kicking himself for having never read that book | 16:20 | |
sulo | soo shits be broken ? bytes is not a 16-char string | 16:55 |
sulo | Message: UnknownException("500: (builtins.ValueError) bytes is not a 16-char string | 16:55 |
jimbaker | sulo, context? | 17:01 |
sulo | sigmavirus: http://paste.openstack.org/show/586439/ | 17:04 |
sigmavirus | sulo: how'd you encounter that? | 17:05 |
sigmavirus | i.e., what was the request you made? | 17:05 |
sulo | get /hosts | 17:06 |
*** VW has quit IRC | 17:07 | |
sigmavirus | sulo: what project id did you use? | 17:08 |
*** VW has joined #craton | 17:08 | |
sulo | some random string | 17:08 |
jimbaker | vs using something like uuidgen? | 17:09 |
sigmavirus | sulo: so with docker we use the same projectid every time | 17:10 |
*** VW has quit IRC | 17:12 | |
sulo | not sure i follow | 17:12 |
sigmavirus | sulo: so the project-id that we set-up by default is in the Dockerfile | 17:13 |
sigmavirus | Or are you testing random inputs? | 17:13 |
sulo | i am just testing random input | 17:13 |
sigmavirus | Aha | 17:13 |
sulo | the generation bit worked | 17:13 |
sulo | i guess its not too big a deal, as users will follow uuid here | 17:14 |
sigmavirus | We can add better validation in the middleware if we ant | 17:14 |
sulo | yeah +1 | 17:14 |
sigmavirus | uuidutils in oslo.utils will handle that for us | 17:14 |
*** chrisspencer_ has quit IRC | 17:15 | |
*** chrisspencer has joined #craton | 17:15 | |
jimbaker | ack, we can make it better/more robust | 17:16 |
*** VW has joined #craton | 17:17 | |
jimbaker | jovon, http://logs.openstack.org/43/386743/2/gate/gate-craton-python35/077f0e2/console.html#_2016-10-19_17_25_05_349401 | 17:32 |
jimbaker | some change in self.message vs self.msg ? | 17:36 |
jimbaker | anyway, should be easy enough to fix | 17:37 |
*** VW has quit IRC | 17:38 | |
*** Mudpuppy has joined #craton | 17:39 | |
*** valw has joined #craton | 17:39 | |
*** VW has joined #craton | 17:39 | |
*** VW has quit IRC | 17:43 | |
*** valw has quit IRC | 17:56 | |
*** VW has joined #craton | 17:57 | |
*** valw has joined #craton | 18:01 | |
jimbaker | syed_, so merged in your update work. thanks for that | 18:03 |
jimbaker | please work with jovon on the resulting merge conflict in his code, in addition to msg vs message conflict that the subsequent tox picked up | 18:04 |
syed_ | Cool. Thanks jim | 18:04 |
syed_ | I dont think jovon is in office today | 18:04 |
jimbaker | syed_, no worries, we can update that on his behalf then | 18:10 |
jimbaker | syed_, do you want to take care of that? | 18:10 |
jimbaker | sigmavirus, sulo, https://gist.github.com/jimbaker/18123ddb6e63e84ad66b2de44fc0ff72 with the cli work in https://review.openstack.org/#/c/388091/ | 18:11 |
jimbaker | so that specific change looks fine to me - just some bit rot on the project id parsing here | 18:11 |
*** VW has quit IRC | 18:12 | |
*** VW has joined #craton | 18:16 | |
*** VW has quit IRC | 18:16 | |
*** VW has joined #craton | 18:17 | |
jimbaker | fwiw, i think we are going to want to spend some time on the craton cli today - it seems sort of borked. so getting stuff like this | 18:19 |
jimbaker | $ craton --craton-url http://127.0.0.1:8080/v1 results in ERROR: b"'Namespace' object has no attribute 'func'" | 18:19 |
sulo | hmm you getting that error even with my patch ? | 18:20 |
jimbaker | sulo, yeah - i just applied your patch | 18:20 |
sulo | ahh .. actually i see why, so yeah other stuff broken too | 18:20 |
jimbaker | and it's now in master - it's necessary, just not sufficient | 18:20 |
sulo | also its incomplete | 18:21 |
sulo | and also missing networks / projects/ users/ netdevices etc | 18:21 |
*** valw has quit IRC | 18:21 | |
jimbaker | yeah - just a lot of missing stuff there | 18:21 |
sulo | its just not really usuable in general | 18:21 |
*** VW has quit IRC | 18:22 | |
jimbaker | anyway, now that core client code is actually usable and seemingly robust, we can put some effort into it | 18:22 |
jimbaker | sulo, btw, besides the fact that the workflow code i shared with you (everyone else here, https://gist.github.com/jimbaker/9cfc95a1a683bb22562b2c0d87811cd0) is incomplete - did that make sense? | 18:23 |
jimbaker | i believe the basic layout is fine, although i would definitely would want to revisit some of the structuring. but plenty of time to think about design issues next week | 18:25 |
*** valw has joined #craton | 18:26 | |
*** valw has quit IRC | 18:29 | |
*** valw has joined #craton | 18:29 | |
sulo | jimbaker: yeah i think so but i didnt go though it properly tbh | 18:31 |
jimbaker | sulo, np | 18:34 |
syed_ | Guys, https://review.openstack.org/#/c/388858/ | 18:34 |
jimbaker | syed_, thanks | 18:35 |
syed_ | @jimbaker sure | 18:35 |
syed_ | i will update that | 18:35 |
*** valw has quit IRC | 18:47 | |
*** valw has joined #craton | 18:55 | |
*** keekz has quit IRC | 19:10 | |
*** keekz has joined #craton | 19:12 | |
*** valw has quit IRC | 19:12 | |
*** valw has joined #craton | 19:14 | |
*** Tamayo has quit IRC | 19:24 | |
*** valw has quit IRC | 19:59 | |
*** Mudpuppy has quit IRC | 20:03 | |
*** valw has joined #craton | 20:09 | |
*** valw has quit IRC | 20:13 | |
sigmavirus | so progress on keystone integration: Keystoneauth works fine but when it sends the token to Craton I get a 422 that isn't logged *anywhere* in craton | 20:17 |
sigmavirus | so, I"m trying to figure out why | 20:17 |
sigmavirus | And I'm out for the day. See you all tomorrow | 20:17 |
*** VW has joined #craton | 20:33 | |
*** Mudpuppy has joined #craton | 20:56 | |
*** VW_ has joined #craton | 21:02 | |
*** VW_ has quit IRC | 21:02 | |
*** VW_ has joined #craton | 21:03 | |
jimbaker | sigmavirus, thanks for the investigation | 21:05 |
*** VW has quit IRC | 21:05 | |
*** valw has joined #craton | 21:14 | |
jimbaker | syed_, thanks for making that change for jovon - hopefully it will get through jenkins now (but i did test separately with tox!) | 21:23 |
jimbaker | (and passed jenkins) | 21:25 |
*** VW_ has quit IRC | 21:37 | |
syed_ | Thanks jimbaker | 21:41 |
*** VW has joined #craton | 22:21 | |
*** VW has quit IRC | 22:21 | |
*** VW_ has joined #craton | 22:26 | |
*** VW_ has quit IRC | 22:27 | |
*** VW_ has joined #craton | 22:27 | |
*** VW_ has quit IRC | 22:28 | |
*** VW_ has joined #craton | 22:29 | |
*** VW_ has quit IRC | 22:29 | |
*** VW has joined #craton | 22:30 | |
*** harlowja has quit IRC | 22:33 | |
*** valw has quit IRC | 22:40 | |
*** harlowja has joined #craton | 22:48 | |
*** VW has quit IRC | 23:01 | |
*** VW has joined #craton | 23:02 | |
*** VW has quit IRC | 23:02 | |
*** VW has joined #craton | 23:03 | |
*** VW has quit IRC | 23:04 | |
*** VW has joined #craton | 23:05 | |
*** VW has quit IRC | 23:06 | |
*** VW has joined #craton | 23:07 | |
*** Mudpuppy has quit IRC | 23:19 | |
*** Mudpuppy has joined #craton | 23:19 | |
*** Mudpuppy has quit IRC | 23:20 | |
*** Mudpuppy has joined #craton | 23:20 | |
*** VW has quit IRC | 23:41 | |
*** Mudpuppy has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!