*** VW has quit IRC | 00:02 | |
*** VW has joined #craton | 00:03 | |
*** harlowja has quit IRC | 00:04 | |
*** jovon has quit IRC | 00:40 | |
*** VW has quit IRC | 01:11 | |
*** VW has joined #craton | 01:33 | |
*** VW has quit IRC | 02:08 | |
*** valw has joined #craton | 02:17 | |
*** VW has joined #craton | 02:33 | |
*** valw has quit IRC | 03:09 | |
*** Syed__ has quit IRC | 03:15 | |
*** VW has quit IRC | 03:25 | |
*** VW has joined #craton | 03:31 | |
*** VW has quit IRC | 04:22 | |
*** VW has joined #craton | 04:25 | |
*** VW has quit IRC | 04:29 | |
*** david-lyle has quit IRC | 05:46 | |
jimbaker | sulo, https://gist.github.com/jimbaker/45cad5868e8eba174c9b04b6705e8787 | 05:58 |
---|---|---|
jimbaker | per the comment on that gist: "Some preliminary work to support host.variables.update(baz='some json', bar={'x': 47, 'y': 42}). But note that for some reason the response.json is not being populated. Also the response.json needs to be decoded for the 'variables' key" | 05:59 |
jimbaker | in case you want to work on this. otherwise i will continue when i'm back online | 05:59 |
jimbaker | note that the update works, it's just the case that the update does not return the new variables object, per the crud contract in cratonclient | 06:00 |
jimbaker | instead it fails because of an unpopulated json response body somewhere in the process | 06:01 |
*** VW has joined #craton | 06:29 | |
*** VW has quit IRC | 06:34 | |
*** VW has joined #craton | 12:38 | |
*** VW has quit IRC | 13:08 | |
*** valw has joined #craton | 14:47 | |
*** VW has joined #craton | 15:07 | |
jimbaker | git-harry, thanks for that fix in https://review.openstack.org/#/c/426197/ - very well timed for us | 15:10 |
jimbaker | sulo, so i don't know if you looked at https://gist.github.com/jimbaker/45cad5868e8eba174c9b04b6705e8787, but git-harry's fix was that all was needed to finalize | 15:11 |
jimbaker | just need to add delete support and it's comprehensive in functionality | 15:14 |
sulo | jimbaker: cool. i have not tried it. | 15:14 |
sulo | but i fixed functional tests | 15:14 |
sulo | so they are all ready for review now | 15:14 |
jimbaker | sulo, sounds good. i will continue working on it then | 15:14 |
sulo | https://review.openstack.org/#/c/410260/ | 15:14 |
sulo | https://review.openstack.org/#/c/408784/ | 15:14 |
sulo | https://review.openstack.org/#/c/422564/ | 15:15 |
sulo | and here is the host test https://review.openstack.org/#/c/426250/ | 15:15 |
sulo | it will fail on delete though | 15:15 |
jimbaker | sulo, thanks for the functional testing stuff | 15:15 |
jimbaker | and yeah, i can fix up the host test | 15:15 |
jimbaker | i will just push that change on it | 15:15 |
sulo | so i have one more simple change coming up to fix the created_at /updated_at fields | 15:16 |
jimbaker | sulo, so for priorities, i will review the functional test changes; work on variables update/delete in the client | 15:17 |
sulo | waiting for git-harry change to go in so i can rebase on top of his | 15:17 |
sulo | ill push that shortly | 15:17 |
jimbaker | which change by git-harry ? | 15:17 |
jimbaker | are you referring to https://review.openstack.org/#/c/424751/ ? | 15:17 |
sulo | the one thats approved already .. its witing merge | 15:17 |
jimbaker | sulo, already merged | 15:18 |
sulo | ah cool | 15:18 |
jimbaker | it fixed my code. thus i was very incentivized to get that one fast tracked :) | 15:19 |
jimbaker | not to mention, this is sort of critical for our demo work | 15:19 |
jimbaker | sulo, maybe i will also add the variables support to the cli. have you done any work there yet on it? | 15:21 |
git-harry | jimbaker: np, although I can't claim to have been intentionally solving your problem. | 15:21 |
jimbaker | git-harry, :) then just making things awesome. even better | 15:22 |
sigmavirus | so I need to fix up tests, but the pagination links work is working well now | 15:37 |
sigmavirus | I also want to add additional functional tests and fix up the API documentation but those may be one or more extra reviews | 15:37 |
*** jovon has joined #craton | 15:40 | |
*** valw has quit IRC | 15:41 | |
*** valw has joined #craton | 15:45 | |
sulo | https://review.openstack.org/#/c/426278/ , ill add functional tests to that separately when that stuff merges in | 15:51 |
jimbaker | sigmavirus, thanks for the pagination work, i will take a look at your WIP change. sounds good about splitting into additional reviews | 15:51 |
jimbaker | sulo, ok | 15:51 |
*** VW_ has joined #craton | 15:59 | |
*** VW_ has quit IRC | 16:00 | |
*** VW_ has joined #craton | 16:00 | |
*** VW_ has quit IRC | 16:01 | |
*** VW_ has joined #craton | 16:01 | |
*** VW has quit IRC | 16:02 | |
*** Syed__ has joined #craton | 16:07 | |
sulo | jimbaker: so, i am going to work on getting some of the network models into generate script and maybe add that to cli ... i am getting a feeling we need that for demo | 16:20 |
sulo | also, no i have dont much on variables on cli so you can go for it | 16:21 |
jimbaker | sulo, sounds like a great way to divide things up | 16:27 |
jimbaker | also maybe we can "script" with respect to the data elements that dusty gave us in that reqs doc | 16:27 |
jimbaker | the only other thing i see here is that we need to be able to navigate to children in the device tree. but this is a secondary priority | 16:28 |
*** VW_ has quit IRC | 16:37 | |
*** VW has joined #craton | 16:38 | |
*** valw has quit IRC | 16:46 | |
*** valw has joined #craton | 16:50 | |
tojuvone | Good evening | 16:58 |
jimbaker | sigmavirus, i didn't look into the details, but rest api calls against /v1/cells and /v1/regions are now failing with the wip change you made; /v1/hosts works fine | 17:03 |
jimbaker | tojuvone, had a great weekend! | 17:03 |
jimbaker | oops, different tense, different meaning | 17:03 |
jimbaker | have a great weekend! | 17:03 |
jimbaker | or perhaps you are checking in with one last time? :) | 17:04 |
tojuvone | jimbaker, you too :) Just came by before go speding it | 17:04 |
tojuvone | spending | 17:04 |
jimbaker | sounds good | 17:04 |
jimbaker | and thanks! we will be enjoying the chinese new year | 17:05 |
tojuvone | So at least almost booked to Milan, do that on monday | 17:05 |
tojuvone | Oh yes, we have also the fireworks today downtown Helsinki I think | 17:05 |
jimbaker | ok, we will see what we can do on our side. i will have a chance to discuss by tues | 17:05 |
tojuvone | sure, there is still time | 17:06 |
tojuvone | I have in OPNFV side release coming, kinda busy still there. | 17:07 |
jimbaker | also we were obviously preoccupied with demos, and putting some stuff together for that. but should have a chance to discuss notifications/maintenance in more detail next week if that works for you | 17:07 |
jimbaker | the stuff that is being done is pretty important for making this production ready of course :) | 17:07 |
jimbaker | so lots of good work here this week | 17:07 |
tojuvone | Yes, demos are now priority. | 17:07 |
tojuvone | Those sell ;) | 17:08 |
jimbaker | yes, let's do that :) | 17:08 |
jimbaker | also from your perspective: being able to fully manage the inventory for OPNFV will surely be important | 17:08 |
jimbaker | in fact, that could be the next step for this core cmdb work - just load the sort of data you need to manage | 17:09 |
jimbaker | we could also use variables to capture maintenance state. might be the right way to do it | 17:09 |
tojuvone | Yes, looking some fault management speed enhancements.. also need that in shape till Boston | 17:10 |
jimbaker | but still need good notification support on top of that | 17:10 |
jimbaker | right | 17:10 |
sigmavirus | jimbaker: there was a typo in cells | 17:10 |
sigmavirus | and in regions | 17:10 |
jimbaker | sigmavirus, yeah, no surprise | 17:10 |
tojuvone | Yes, I was also looking that discussion about variables, that it might be usable for it | 17:11 |
* sigmavirus is working on tests | 17:11 | |
jimbaker | seeing it now "link_paramss" - life :) | 17:11 |
jimbaker | and tests make this stuff go away, so good stuff | 17:11 |
jimbaker | tojuvone, so let's work together to build out some inventory data for OPNFV. could use the python client, or the CLI. maybe both. but would be a good example that we could add to say an /examples subdir | 17:13 |
tojuvone | Then if do not want to hardcode some notif to certain variable changing value, that could also be somehow pluggable. But that can be discussed later | 17:14 |
jimbaker | tojuvone, yep | 17:14 |
jimbaker | tojuvone, also it might relate to the idea of namespaces i've been tossing around | 17:14 |
jimbaker | (which we can do now, because keys can be arbitrary; but we can add more structuring with namespaces in the future) | 17:15 |
tojuvone | jimbaker, ok | 17:16 |
tojuvone | jimbaker, Well we got kids away for whole weekend, so guess should go take everything out of it :) | 17:17 |
jimbaker | tojuvone, sounds like a great plan. enjoy the time! | 17:18 |
tojuvone | Thanks, let's come back next week! Have a nice weekend! | 17:19 |
jimbaker | thanks, should be very nice here! and looking forward to putting that work together with you next week! | 17:21 |
jimbaker | sigmavirus, fixing that typo fixed things nicely with cells and regions, thanks | 17:22 |
sigmavirus | jimbaker: so, that change should have a corresponding client change | 17:23 |
sigmavirus | let's not merge it until I can fix up the tests and get the client working | 17:23 |
jimbaker | sigmavirus, yes, still very much WIP i know | 17:23 |
jimbaker | just wanted to try it out | 17:23 |
jimbaker | otherwise if we don't have that client change, we have limited ourselves to the trial version of craton ;) | 17:23 |
jimbaker | which can handle 30 hosts, 30 cells, and 30 regions. or something like that | 17:24 |
jimbaker | just perfect for managing a small cloud! ;) | 17:24 |
sigmavirus | jimbaker: not quite | 17:28 |
sigmavirus | the present version you can still get other pages | 17:28 |
sigmavirus | you just need to construct the limit & marker params yourself | 17:28 |
sigmavirus | this change does it for the user | 17:28 |
*** VW has quit IRC | 17:33 | |
*** VW has joined #craton | 17:36 | |
Syed__ | Guys, kindly review https://review.openstack.org/#/c/425463/ | 17:44 |
*** valw has quit IRC | 17:56 | |
*** valw has joined #craton | 18:01 | |
*** harlowja has joined #craton | 18:02 | |
*** rainya has joined #craton | 18:02 | |
*** VW has quit IRC | 18:14 | |
jimbaker | Syed__, thanks | 18:15 |
*** rainya has quit IRC | 18:19 | |
*** rainya has joined #craton | 18:22 | |
*** rainya has quit IRC | 18:43 | |
*** VW has joined #craton | 19:16 | |
*** jovon has quit IRC | 19:20 | |
*** david-lyle has joined #craton | 20:01 | |
*** rainya has joined #craton | 20:01 | |
*** valw has quit IRC | 20:02 | |
*** valw has joined #craton | 20:05 | |
*** klindgren has joined #craton | 21:00 | |
klindgren | hello | 21:01 |
*** valw has quit IRC | 21:04 | |
jimbaker | klindgren, hi | 21:08 |
*** rainya has quit IRC | 21:19 | |
*** rainya has joined #craton | 21:22 | |
*** VW has quit IRC | 22:18 | |
*** VW has joined #craton | 22:32 | |
*** rainya has quit IRC | 23:02 | |
*** rainya has joined #craton | 23:02 | |
*** VW has quit IRC | 23:04 | |
*** VW has joined #craton | 23:04 | |
*** rainya has quit IRC | 23:06 | |
*** VW has quit IRC | 23:12 | |
*** VW has joined #craton | 23:13 | |
*** VW has quit IRC | 23:18 | |
*** Syed__ has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!