| jimbaker | thomasem, re https://review.openstack.org/#/c/427777/26/craton/tests/functional/test_project_calls.py | 00:14 |
|---|---|---|
| jimbaker | you probably want to base on https://review.openstack.org/#/c/432355/ | 00:14 |
| jimbaker | if you are going to support variables | 00:14 |
| jimbaker | also i made some cleanup in those functional tests to be consistent | 00:14 |
| jimbaker | sometimes we used the response as the "resource", other times it was response.json(). the latter is more consistent (and makes more sense) | 00:14 |
| *** VW has joined #craton | 00:18 | |
| *** VW has quit IRC | 00:41 | |
| *** VW has joined #craton | 00:41 | |
| *** VW has quit IRC | 00:45 | |
| *** VW has joined #craton | 00:54 | |
| thomasem | Oh, excellent. Thanks, jimbaker! | 01:29 |
| *** VW has quit IRC | 01:34 | |
| *** VW has joined #craton | 01:35 | |
| thomasem | Dropped a note on the review, but it looks like you're missing a file in that patch, jimbaker | 01:39 |
| *** VW has quit IRC | 01:39 | |
| thomasem | craton.tests.functional.test_variable_calls | 01:39 |
| thomasem | I guess the functional tests don't run in CI there, huh? | 01:40 |
| thomasem | Yeah, they definitely don't. I remember they were broken the other day and we were none the wiser as a result of the Jenkins run. | 01:40 |
| thomasem | Once that's fixed, I can rebase my patch with it. | 01:42 |
| thomasem | And then get it all consistent. | 01:42 |
| thomasem | Wonder what, if anything, we can do to try and reduce the stepping on each others' toes that's been pretty time consuming here, btw. I've had to rebase and refactor my Project variables patch about 4 times. Feels like I'm wasting valuable time doing that, especially given all of these other priorities. Any thoughts on that? | 01:58 |
| thomasem | Anyway, getting late for me, so I'm gonna cheese it for the weekend. Take it easy! See ya Monday. :) | 01:59 |
| *** FiveBroDeepBook has joined #craton | 02:08 | |
| *** FiveBroDeepBook has left #craton | 02:08 | |
| *** VW has joined #craton | 03:36 | |
| *** VW has quit IRC | 03:41 | |
| *** VW has joined #craton | 05:08 | |
| *** Guest13842 has joined #craton | 05:37 | |
| *** Guest13842 has quit IRC | 05:46 | |
| *** VW has quit IRC | 05:55 | |
| *** VW has joined #craton | 05:55 | |
| *** VW has quit IRC | 06:00 | |
| *** FiveBroDeepBook has joined #craton | 07:01 | |
| *** FiveBroDeepBook has left #craton | 07:01 | |
| *** VW has joined #craton | 07:56 | |
| *** VW has quit IRC | 08:03 | |
| *** VW has joined #craton | 10:00 | |
| *** VW has quit IRC | 10:06 | |
| *** VW has joined #craton | 11:03 | |
| *** VW has quit IRC | 11:09 | |
| *** VW has joined #craton | 12:44 | |
| *** VW has quit IRC | 12:52 | |
| *** FiveBroDeepBook has joined #craton | 12:55 | |
| *** FiveBroDeepBook has left #craton | 12:55 | |
| *** VW has joined #craton | 14:50 | |
| *** VW has quit IRC | 14:54 | |
| *** VW has joined #craton | 15:52 | |
| *** VW has quit IRC | 15:58 | |
| *** VW has joined #craton | 15:59 | |
| *** VW has quit IRC | 16:04 | |
| *** VW has joined #craton | 16:27 | |
| *** VW has quit IRC | 16:33 | |
| *** VW has joined #craton | 16:54 | |
| *** VW has quit IRC | 16:59 | |
| *** mdorman has quit IRC | 18:42 | |
| *** VW has joined #craton | 18:55 | |
| *** VW has quit IRC | 19:00 | |
| *** VW has joined #craton | 20:21 | |
| *** VW has quit IRC | 20:27 | |
| *** mdorman has joined #craton | 20:39 | |
| *** VW has joined #craton | 21:19 | |
| *** VW has quit IRC | 21:23 | |
| *** VW has joined #craton | 23:20 | |
| *** VW has quit IRC | 23:27 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!