| *** VW has quit IRC | 00:32 | |
| *** VW has joined #craton | 00:44 | |
| *** VW has quit IRC | 00:46 | |
| *** `_^gk`_^1wm`_^ has joined #craton | 00:52 | |
| *** `_^gk`_^1wm`_^ has quit IRC | 00:54 | |
| *** VW has joined #craton | 02:43 | |
| *** VW has quit IRC | 02:48 | |
| *** david-lyle_ has joined #craton | 03:56 | |
| *** david-lyle has quit IRC | 03:58 | |
| *** VW has joined #craton | 05:10 | |
| *** VW has quit IRC | 05:11 | |
| *** VW has joined #craton | 05:11 | |
| *** VW has quit IRC | 05:22 | |
| *** VW has joined #craton | 07:38 | |
| *** VW has quit IRC | 08:04 | |
| *** VW has joined #craton | 15:06 | |
| *** Syed__ has joined #craton | 15:28 | |
| *** jovon has joined #craton | 15:31 | |
| thomasem | Doh! I remember what the problem with the functional tests is now. | 15:46 |
|---|---|---|
| jimbaker | ? | 15:46 |
| thomasem | Not going through the API for initial project setup didn't set up the proper variable association | 15:46 |
| thomasem | I guess somewhere along the way my fix for that got lost in some refactoring :( | 15:47 |
| thomasem | Alright, fixing again | 15:47 |
| thomasem | There were these weird failures that seemed to only happen in the functional tests, so it had to be related to how they're set up. | 15:47 |
| thomasem | Locally it worked as expected, but when the functional test came along, it bombed. | 15:47 |
| thomasem | And that made me think of resolution order, since the only thing that changed in my patch was adding the project variables stuff, but the failures were on hosts tests. | 15:48 |
| jimbaker | yep, that would make sense | 15:48 |
| * thomasem puts on spelunking gear | 15:48 | |
| jimbaker | because the functional tests are the only ones that really exercise some of those code paths. i think we can do a better job with the db tests fwiw | 15:48 |
| jimbaker | there's no reason in principle they cannot | 15:49 |
| thomasem | Yeah. The out-of-band setup that reaches into the DB is a bit of a no-no, too. | 15:49 |
| jimbaker | yes. don't do that | 15:49 |
| jimbaker | at best reserve it for "bootstrap" or whatever you ended calling it. or will call it | 15:49 |
| thomasem | That's just how it's doing things in master | 15:49 |
| thomasem | Need to refactor that whole piece | 15:50 |
| jimbaker | so the change you posted is still WIP? | 15:50 |
| thomasem | for a moment | 15:50 |
| jimbaker | https://review.openstack.org/#/c/427777/ | 15:50 |
| jimbaker | ack. will hold off then | 15:50 |
| thomasem | Feel free to code review, it's mostly done. | 15:50 |
| thomasem | Just know functional tests are going to bomb until I fix this | 15:50 |
| thomasem | jimbaker: ^^ | 15:50 |
| thomasem | Any issues I can get in the next revision I push up will save some time | 15:51 |
| thomasem | issues I can get resolved* | 15:51 |
| sigmavirus | thomasem: jimbaker did y'all come up with priorities? | 15:53 |
| thomasem | sigmavirus: it's on the etherpad https://etherpad.openstack.org/p/cmdb_prototype_meeting_2017_02_09 | 15:54 |
| thomasem | jimbaker: did you ever get a bug going for that CLI work? | 15:54 |
| thomasem | Wanted to link it in the etherpad | 15:55 |
| thomasem | I see this one https://bugs.launchpad.net/python-cratonclient/+bug/1659110 | 15:56 |
| openstack | Launchpad bug 1659110 in Craton's Python Client "Variables should be available from cli" [High,New] - Assigned to Sulochan Acharya (sulochan-acharya) | 15:56 |
| thomasem | jimbaker: Okay, it's gtg now! | 16:17 |
| thomasem | All fixed up | 16:17 |
| *** david-lyle has joined #craton | 16:26 | |
| *** david-lyle_ has quit IRC | 16:29 | |
| Syed__ | thomasem: just checked | 16:31 |
| Syed__ | still failing some tests :/ | 16:31 |
| thomasem | Syed__: hmmm? | 16:32 |
| jimbaker | thomasem, now assigned to me. i will add some additional notes to it | 16:32 |
| thomasem | jimbaker: awesome, thanks! | 16:32 |
| thomasem | Syed__: what has failing tests? | 16:32 |
| Syed__ | let me put it in pastebin | 16:34 |
| Syed__ | a min | 16:34 |
| thomasem | git-harry: FYI, the reason I was fixing that inconsistent ID type for project was because it was causing all sorts of problems in tests and it got more painful working around the inconsistency than just fixing the problem. | 16:35 |
| Syed__ | thomasem: https://gist.github.com/ahsan518/6f1dd188a4fa60e2ddf50d8b7b9a9d5e | 16:35 |
| thomasem | Syed__: that looks like a Docker problem on your end. | 16:36 |
| Syed__ | docker | 16:36 |
| thomasem | Check your daemon and be sure you can actually run the tests on, say, master | 16:36 |
| Syed__ | let me check again | 16:36 |
| thomasem | AttributeError: 'APIV1RegionTest' object has no attribute 'service_ip' | 16:36 |
| thomasem | Tells me that something got messed up when trying to set up your Docker daemon for the functional tests. That's where `service_ip` gets set. | 16:37 |
| thomasem | By the way, this project vars patch is blocking Syed | 16:39 |
| thomasem | So, that's why you're probably going to see me get annoying about reviews for it. | 16:39 |
| thomasem | That and it's one of our priority items for ze week :P | 16:39 |
| thomasem | Getting really good at these keyboard shortcuts for Gerrit, though. | 16:40 |
| Syed__ | thomasem: works fine now, looks good. Thanks | 16:42 |
| thomasem | Syed__: You bet! And thank you for taking a look at it. :) | 16:43 |
| jovon | will notes be included in networks or contained to regions cells and devices? | 16:52 |
| Syed__ | jovon: No, since it is not present in the schema | 16:55 |
| Syed__ | jovon: https://github.com/openstack/craton/blob/master/craton/api/v1/schemas.py | 16:56 |
| git-harry | thomasem: okay, might have been nice to have done that separately | 16:57 |
| thomasem | Honestly? The way code reviews have been working on this team made me feel that would probably push this out by days. | 16:57 |
| thomasem | but, I do agree wholeheartedly with the goal there and want to do it that way. | 16:58 |
| thomasem | farid: this meeting is actually on Vidyo in Craton-recordable | 17:00 |
| farid | ah thanks thomasem | 17:01 |
| *** VW has quit IRC | 17:11 | |
| *** VW has joined #craton | 17:11 | |
| jovon | http://docs.openstack.org/contributor-guide/api-guides.html | 17:11 |
| sigmavirus | thomasem: so I have it narrowed down to one last functional test | 17:24 |
| sigmavirus | combination of pagination + vars filtering | 17:24 |
| sigmavirus | getting a 200 with 0 hosts | 17:24 |
| sigmavirus | also, should we time-box these discussions? | 17:25 |
| sigmavirus | thomasem: inspired that by timeboxing Jim's standup | 17:27 |
| sigmavirus | :) | 17:27 |
| sigmavirus | I LEARNED IT FROM WATCHING thomasem | 17:28 |
| sigmavirus | jimbaker: so, we're not getting 500 out of paginated filtering with vars, but I haven't yet determined why we get 0 hosts back | 17:56 |
| sigmavirus | :) | 17:56 |
| jimbaker | love the timeboxing, and thanks! | 17:56 |
| jimbaker | sigmavirus, re pagination - it certainly simplifies the work if the resulting collection always has zero items | 17:57 |
| sigmavirus | lol | 17:57 |
| sigmavirus | jimbaker.enable_helper_mode() | 17:57 |
| jimbaker | but have you considered further optimizing the query by just avoiding any sqlalchemy to begin with? ;) | 17:58 |
| thomasem | lol sigmavirus | 17:59 |
| sigmavirus | hm the query just works fine | 18:00 |
| * sigmavirus just stepped through the query generation and filtering | 18:00 | |
| * sigmavirus glares | 18:00 | |
| sigmavirus | sure, when I debugger through that monstrosity it works fine | 18:01 |
| * sigmavirus begins to suspect something is wrong with the functional test | 18:05 | |
| jimbaker | doubting the test is a good place to start | 18:09 |
| sigmavirus | yeah, when I just use requests, I can get filtering by vars + pagination working fine | 18:20 |
| thomasem | What's the error you're getting? (I usually comment out the container cleanup in __init__.py and docker logs...) | 18:28 |
| jimbaker | i'm warming up to /v1/devices | 18:29 |
| jimbaker | anyway, RPC meeting. back in 90 min or so | 18:30 |
| thomasem | Same | 18:30 |
| sigmavirus | thomasem: I'm not getting any errors. Everything comes back ok except that there are 0 hosts | 19:05 |
| thomasem | OH sorry, I see it now in the scrollback | 19:05 |
| sigmavirus | also, my testing box is on RAX pub cloud and ssh'ing to it on the vpn is a headache | 19:05 |
| sigmavirus | and I keep getting dropped | 19:05 |
| thomasem | Serrriously | 19:06 |
| thomasem | Mine's been dropping all morning | 19:06 |
| sigmavirus | I should just work with two laptops | 19:06 |
| thomasem | Right. | 19:17 |
| jimbaker | back | 19:54 |
| jimbaker | i looked a bit into devices, just so i can better understand what's going on for supporting /v1/devices. should be very straightforward, with minimal api work, and a bit of change in the client to instantiate the right resource | 19:58 |
| jimbaker | https://bugs.launchpad.net/craton/+bug/1664696 | 19:58 |
| openstack | Launchpad bug 1664696 in craton "Support GET on a collection of devices" [Undecided,New] | 19:58 |
| jimbaker | git-harry, ^^^ | 20:01 |
| jimbaker | sigmavirus, thomasem - one thing i noticed in doing this is that queries on /v1/hosts really need to be more lazy | 20:01 |
| jimbaker | i assume this is a common thing with out queries - we too aggressively load the object graph, even when details are not being returned | 20:02 |
| jimbaker | anyway, we should add a tuning bug | 20:03 |
| jimbaker | to at least get at some of the common one. or at least, let's track as work to be done :) | 20:04 |
| jimbaker | https://bugs.launchpad.net/craton/+bug/1664707 | 20:19 |
| openstack | Launchpad bug 1664707 in craton "SQLAlchemy queries are not lazy enough" [Undecided,New] | 20:19 |
| sigmavirus | Found the bug in the functional tests | 20:28 |
| sigmavirus | jimbaker: let's optimize that when we find it to be a real problem | 20:28 |
| jimbaker | sigmavirus, i did mark it as high | 20:29 |
| jimbaker | not critical as a consequence | 20:29 |
| jimbaker | but retrieving every variable setting for every host that is returned, even with pagination... sounds potentially expensive even if we throw it all away on the output to the rest api | 20:30 |
| jimbaker | especially since this pruning should be a simple change :) | 20:30 |
| sigmavirus | jimbaker: that's fair | 20:30 |
| sigmavirus | jimbaker: do you have 5 minutes for a video call? I suspect thomasem is out | 20:31 |
| sigmavirus | farid: you might want to join us if you have a few minutes? | 20:31 |
| farid | sure thing | 20:32 |
| jimbaker | ok | 20:32 |
| jimbaker | craton room? | 20:32 |
| farid | sounds good, gimme a min to fill up my cup | 20:33 |
| sigmavirus | yep | 20:33 |
| sigmavirus | Do we want a voting functional gate for Craton | 20:50 |
| Syed__ | I guess that would be useful and handy ? | 20:52 |
| Syed__ | to check functional testing at gate to verify if we break stuff or not, | 20:52 |
| sigmavirus | Syed__: yeah | 20:52 |
| sigmavirus | Would have caught some breakage with my patch sooner for me because I forgot about `tox -e functional` :0 | 20:52 |
| Syed__ | sigmavirus: just playing around with your patch | 20:53 |
| Syed__ | sigmavirus: works fine till now :) | 20:53 |
| sigmavirus | Syed__: ssssh don't jinx it | 20:53 |
| Syed__ | yeah, my vote is yes | 20:53 |
| sigmavirus | I won't pull a jimbaker and +2+A it myself ;) | 20:53 |
| jimbaker | ;) | 20:54 |
| git-harry | jimbaker: thomasem adding parent links to hosts/network-devices is going to conflict with the pagination patch from sigmavirus. If it's important to get his patch in, it could do with some reviews today otherwise basing my patch off his will likely cause delays. | 21:32 |
| git-harry | Delays in the critical items that is. | 21:33 |
| jimbaker | git-harry, let's get sigmavirus' patch in | 21:42 |
| jimbaker | he's suffered enough | 21:43 |
| jimbaker | git-harry, if we haven't done so, we do need a bug re PUT for device_id update | 21:44 |
| git-harry | jimbaker: parent_id? | 21:45 |
| jimbaker | sorry, parent_id | 21:46 |
| jimbaker | :) | 21:46 |
| git-harry | Okay, I can sort that out tomorrow | 21:48 |
| jimbaker | git-harry, yeah, i think this is the best prioritization | 21:50 |
| thomasem | What'd I miss? | 22:32 |
| thomasem | jimbaker, farid, sigmavirus: did I miss anything in your vidyo call? | 22:34 |
| farid | hey thomasem | 22:34 |
| farid | we were just discussing and creating a milestone in the craton project for the next 3 weeks | 22:34 |
| *** jovon_ has joined #craton | 22:35 | |
| thomasem | Oh okay | 22:35 |
| farid | you can see it here https://launchpad.net/craton/+milestone/v0.1.0 | 22:35 |
| *** izaakk_ has joined #craton | 22:35 | |
| Syed__ | That would be really helpful | 22:35 |
| thomasem | Excellent | 22:35 |
| thomasem | Yes, thank you! | 22:35 |
| farid | essentially of what we had discussed we should focus on, just to have a central place to track. | 22:35 |
| farid | jimbaker / sigmavirus anything to add ? | 22:35 |
| thomasem | do we also need one on the client LP project? | 22:36 |
| farid | good point, item #2 is for the client huh | 22:36 |
| thomasem | Yep, and #3, partially | 22:36 |
| thomasem | Specifically, 3.3 | 22:37 |
| farid | cool, sounds like a good idea | 22:38 |
| farid | jumping in impromptu meeting, brb and can check on that | 22:38 |
| thomasem | jimbaker: should we just consider that part of https://bugs.launchpad.net/python-cratonclient/+bug/1659110? | 22:39 |
| openstack | Launchpad bug 1659110 in Craton's Python Client "Variables should be available from cli" [High,New] - Assigned to Jim Baker (jimbaker) | 22:39 |
| thomasem | instead of https://bugs.launchpad.net/craton/+bug/1648626 | 22:39 |
| openstack | Launchpad bug 1648626 in craton "Projects should support variables, which other entities use in resolution" [Critical,In progress] - Assigned to Thomas Maddox (thomas-maddox) | 22:39 |
| thomasem | since that's for Craton API | 22:39 |
| thomasem | I don't mind doing the work, but it seems silly to make another bug since it's the same thing, really. | 22:39 |
| *** sballe__ has joined #craton | 22:40 | |
| *** jovon has quit IRC | 22:42 | |
| *** wirehead_ has quit IRC | 22:42 | |
| *** izaakk has quit IRC | 22:42 | |
| *** sballe_ has quit IRC | 22:42 | |
| *** mhayden has quit IRC | 22:42 | |
| *** jovon_ is now known as jovon | 22:42 | |
| *** izaakk_ is now known as izaakk | 22:43 | |
| *** sballe__ is now known as sballe_ | 22:45 | |
| *** klindgren has quit IRC | 22:46 | |
| *** jimbaker has quit IRC | 22:46 | |
| *** mhayden has joined #craton | 22:50 | |
| *** klindgren has joined #craton | 22:52 | |
| *** jimbaker has joined #craton | 22:52 | |
| *** adams.freenode.net sets mode: +o jimbaker | 22:52 | |
| *** VW_ has joined #craton | 23:22 | |
| *** VW has quit IRC | 23:25 | |
| *** VW_ has quit IRC | 23:26 | |
| *** jovon has quit IRC | 23:42 | |
| *** wirehead_ has joined #craton | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!