| *** jovon has quit IRC | 00:12 | |
| jimbaker | farid, that's a bug - the client has partial support for pagination, and is emitting GET /v1/cells?region_id=2&sort_dir=asc | 00:46 |
|---|---|---|
| jimbaker | but sort_dir is not valid, because we need to get https://review.openstack.org/#/c/434506/ completed | 00:47 |
| jimbaker | and allow sort_dir to be used by the client | 00:47 |
| jimbaker | FWIW, the client should not use sort_dir unless necessary, just to keep the requests simpler | 00:47 |
| jimbaker | in this past, this would all work because the schema validation would have quietly ignored args, but we are trying to make things more robust, with tighter errors. and breaking a few things here & there that used to work. unfortunately | 00:49 |
| jimbaker | hopefully we will have sigmavirus' change in soon; as well as getting the gate unblocked, and this bug will go away. thanks for asking! | 00:50 |
| *** Syed__ has quit IRC | 01:25 | |
| *** VW has quit IRC | 02:58 | |
| *** VW has joined #craton | 02:58 | |
| *** VW has quit IRC | 02:59 | |
| *** VW has joined #craton | 03:00 | |
| *** tojuvone has quit IRC | 03:21 | |
| *** tojuvone has joined #craton | 03:28 | |
| *** david-lyle has quit IRC | 03:49 | |
| *** david-lyle has joined #craton | 03:50 | |
| *** VW has quit IRC | 04:08 | |
| *** VW has joined #craton | 04:10 | |
| *** VW has quit IRC | 04:11 | |
| *** VW has joined #craton | 04:12 | |
| *** deepbook5broo has joined #craton | 04:13 | |
| *** deepbook5broo has left #craton | 04:13 | |
| *** mdorman has quit IRC | 04:32 | |
| *** VW has quit IRC | 05:17 | |
| *** VW has joined #craton | 06:25 | |
| *** VW has quit IRC | 06:47 | |
| *** VW has joined #craton | 07:40 | |
| *** VW has quit IRC | 10:21 | |
| openstackgerrit | git-harry proposed openstack/craton master: Add devices endpoint https://review.openstack.org/435005 | 11:15 |
| openstackgerrit | Merged openstack/craton master: Removes left-over debugging logs https://review.openstack.org/434936 | 11:27 |
| sigmavirus | Does the gate seem not fixed for others? | 13:03 |
| *** VW has joined #craton | 13:16 | |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 13:37 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 13:43 |
| openstackgerrit | Merged openstack/craton master: RBAC-Lite for generic resources implementation https://review.openstack.org/434976 | 13:51 |
| *** VW has quit IRC | 13:54 | |
| thomasem | sigmavirus: gate seemed to work fine there ^^. I'm assuming we disabled functional? | 13:56 |
| sigmavirus | yeah, seemed like it wasn't an immediate fix yesterday is all | 13:57 |
| thomasem | gootcha | 14:00 |
| thomasem | sigmavirus: your patch for sort_keys/sort_dir only allows them to be set, but does not attempt to implement the use of them. Is that correct? | 14:06 |
| thomasem | https://review.openstack.org/#/c/434506/3 | 14:06 |
| sigmavirus | thomasem: the pagination work already uses them =) | 14:07 |
| thomasem | Excellent. | 14:07 |
| sigmavirus | look at the _paginate function in craton/db/sqlalchemy/api.py | 14:07 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:07 |
| thomasem | Right. So, then, we probably need some functional tests in that patch to exercise that. | 14:08 |
| sigmavirus | ^ This might get our functional tests working | 14:08 |
| thomasem | Ooooooo | 14:08 |
| sigmavirus | thomasem: roger wilco | 14:08 |
| thomasem | :wookieedance: | 14:10 |
| sigmavirus | nah | 14:11 |
| sigmavirus | my trickery didn't seem to work | 14:11 |
| thomasem | Aww man | 14:11 |
| sigmavirus | d'oh | 14:12 |
| sigmavirus | that's maybe because I stopped the daemon instead of restarting it | 14:12 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:12 |
| * sigmavirus crosses fingers on ^ patchset | 14:12 | |
| * thomasem crosses fingers as well | 14:13 | |
| sigmavirus | luckily at this time of the openstack dev cycle, the check queue is *very* short | 14:14 |
| sigmavirus | still didn't work | 14:14 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:19 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:24 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:29 |
| farid | morning, and thanks for the explanation jimbaker | 14:29 |
| *** VW has joined #craton | 14:30 | |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:33 |
| sigmavirus | okay, so docker+systemd is a pain but this hack might work | 14:34 |
| sigmavirus | it's fragile, but at this point I want working functional tests | 14:34 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fix up functional testing https://review.openstack.org/435038 | 14:59 |
| sigmavirus | thomasem: I'm more optimistic about https://review.openstack.org/#/c/435038/20 | 15:05 |
| sigmavirus | lol | 15:05 |
| sigmavirus | craton as an interface to osquery =P | 15:10 |
| sigmavirus | jimbaker: ^ | 15:13 |
| thomasem | Lol, osquery crawler | 15:13 |
| sigmavirus | thomasem: distributed osquery =P | 15:13 |
| thomasem | yeah! | 15:13 |
| sigmavirus | https://review.openstack.org/#/c/435038/ works! | 15:14 |
| sigmavirus | jimbaker: ^ that will allow us to enable our functional gate | 15:14 |
| jimbaker | awesome news! and now we have collected a lot of data as well | 15:14 |
| jimbaker | we just need to put the data in our cmdb... | 15:15 |
| *** Syed__ has joined #craton | 15:52 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 15:57 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 15:59 |
| *** jovon has joined #craton | 16:10 | |
| *** VW_ has joined #craton | 16:12 | |
| *** VW has quit IRC | 16:12 | |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Configure OpenStack CI to run functional tests https://review.openstack.org/435038 | 16:16 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Configure OpenStack CI to run functional tests https://review.openstack.org/435038 | 16:17 |
| thomasem | I have to run to two back-to-back appointments. I'll bbiab! | 16:18 |
| jimbaker | thomasem, ttyl | 16:23 |
| sigmavirus | anyone care to review https://review.openstack.org/#/c/435038/22 | 16:34 |
| sigmavirus | *? | 16:34 |
| *** valw has joined #craton | 16:46 | |
| jimbaker | sigmavirus, sounds good | 17:02 |
| jimbaker | i was just waiting for the go on that | 17:02 |
| sigmavirus | jimbaker: well it's all ready | 17:03 |
| sigmavirus | I can self-approve if you're more comfortable with that | 17:03 |
| jimbaker | oh sure, let's always do it that way | 17:03 |
| jimbaker | ;) | 17:03 |
| jimbaker | approved, gate is hopefully clear | 17:04 |
| sigmavirus | heh | 17:06 |
| sigmavirus | let's leave that job experimental for a bit longer | 17:06 |
| sigmavirus | just to make sure we have a good track record with it | 17:06 |
| sigmavirus | To run that job, just comment "check experimental" on a review | 17:06 |
| openstackgerrit | Merged openstack/craton master: Configure OpenStack CI to run functional tests https://review.openstack.org/435038 | 17:07 |
| sigmavirus | jimbaker: do you have the link to the priorities etherpad? | 17:17 |
| jimbaker | https://etherpad.openstack.org/p/cmdb_prototype_meeting_2017_02_09 | 17:17 |
| sigmavirus | thanks! | 17:17 |
| *** VW_ has quit IRC | 17:44 | |
| *** VW has joined #craton | 17:48 | |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Add sort_dir and sort_keys to endpoint schemata https://review.openstack.org/434506 | 17:56 |
| jimbaker | sigmavirus, that recent patch in https://review.openstack.org/#/c/434506/ | 18:11 |
| jimbaker | other than test failures of course | 18:11 |
| sigmavirus | jimbaker: you said nothing just now | 18:11 |
| sigmavirus | but I just figured out the failures | 18:11 |
| sigmavirus | I wanted to make sure it wasn't just local | 18:11 |
| jimbaker | but at least list(craton.hosts.list(region_id=1) works | 18:11 |
| jimbaker | and the rel links work | 18:12 |
| jimbaker | hopefully i stated something... | 18:12 |
| jimbaker | anyway, it looks like i might be trying to review the patch too soon. but figured i would offer the feedback | 18:12 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Add sort_dir and sort_keys to endpoint schemata https://review.openstack.org/434506 | 18:13 |
| sigmavirus | ^ should be ready for review, but I'm running the functional tests locally and we'll know in 4-8 minutes | 18:14 |
| sigmavirus | (also kicked them off on the patch) | 18:15 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Add sort_dir and sort_keys to endpoint schemata https://review.openstack.org/434506 | 18:17 |
| sigmavirus | okay | 18:18 |
| sigmavirus | I typod the tests but those are fixed now | 18:18 |
| sigmavirus | I'm going to take a quick lunch | 18:18 |
| jimbaker | sigmavirus, cool, thanks for that update | 18:19 |
| *** valw has quit IRC | 18:24 | |
| openstackgerrit | Merged openstack/craton master: Add sort_dir and sort_keys to endpoint schemata https://review.openstack.org/434506 | 18:32 |
| *** VW_ has joined #craton | 18:57 | |
| *** VW_ has quit IRC | 18:57 | |
| *** VW_ has joined #craton | 18:58 | |
| *** VW has quit IRC | 19:00 | |
| *** VW has joined #craton | 19:00 | |
| *** VW has quit IRC | 19:01 | |
| *** VW has joined #craton | 19:01 | |
| -openstackstatus- NOTICE: Restarting gerrit due to performance problems | 19:02 | |
| *** VW_ has quit IRC | 19:03 | |
| *** VW has quit IRC | 19:07 | |
| *** VW has joined #craton | 19:07 | |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fixes device search by label https://review.openstack.org/432283 | 19:08 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fixes device search by label https://review.openstack.org/432283 | 19:16 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fixes device search by label https://review.openstack.org/432283 | 19:25 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 19:44 |
| Syed__ | Hmm ... Facing weird git problem | 20:13 |
| thomasem | Syed__: hmm? | 20:13 |
| Syed__ | https://www.irccloud.com/pastebin/0d0jznPG/ | 20:14 |
| Syed__ | so i wanted my change to be child change of yours, Add variable support one | 20:14 |
| sigmavirus | Syed__: that is odd | 20:21 |
| Syed__ | so i did rebase since my change is now in a merge conflict | 20:21 |
| sigmavirus | is 65492c4 the latest version of thomasem's patch? | 20:21 |
| Syed__ | what i did was pull my change | 20:21 |
| Syed__ | then git rebase --pull | 20:21 |
| Syed__ | made changes and added those | 20:21 |
| Syed__ | then git rebase --continue | 20:21 |
| Syed__ | and when i try to review, it gives me this | 20:21 |
| sigmavirus | Syed__: want to hop on vidyo together? | 20:22 |
| Syed__ | sounds good to me | 20:22 |
| Syed__ | the same craton room ? | 20:22 |
| sigmavirus | WFM | 20:23 |
| Syed__ | okie, joining | 20:23 |
| sigmavirus | did vidyo die for everyone else? | 20:26 |
| * sigmavirus rejoins | 20:26 | |
| sigmavirus | Syed__: you dropped from vidyo again | 20:34 |
| Syed__ | sorry guys, might need to restart pc since it says already in an connection | 20:34 |
| thomasem | Syed__: ouch, no worries | 20:36 |
| sigmavirus | Syed__: | 20:37 |
| Syed__ | An error occurred while trying to log in (2002). | 20:38 |
| Syed__ | sigmavirus: https://review.openstack.org/#/c/427777/ | 20:43 |
| openstackgerrit | Ian Cordasco proposed openstack/craton master: Fixes device search by label https://review.openstack.org/432283 | 20:46 |
| *** VW has quit IRC | 21:01 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Ignore None param values when generating links https://review.openstack.org/435595 | 21:01 |
| *** VW has joined #craton | 21:05 | |
| *** VW has quit IRC | 21:06 | |
| thomasem | Also found this issue with the generated links for pagination after addressing ^^ https://bugs.launchpad.net/craton/+bug/1665780 | 21:06 |
| openstack | Launchpad bug 1665780 in craton "error using generated pagination links for Projects collection" [Undecided,New] | 21:06 |
| *** VW has joined #craton | 21:06 | |
| thomasem | Syed__: did you get it figured out? | 21:08 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Use String for Project ID in schema https://review.openstack.org/435599 | 21:23 |
| openstackgerrit | Syed Ahsan Shamim Zaidi proposed openstack/craton master: Update requests for Users and Projects https://review.openstack.org/425463 | 21:23 |
| Syed__ | git thomasem yeap, thanks | 21:23 |
| thomasem | Excellent! | 21:23 |
| Syed__ | sorry for git* | 21:23 |
| thomasem | hahaha no problem | 21:23 |
| openstackgerrit | Syed Ahsan Shamim Zaidi proposed openstack/craton master: Update requests for Users and Projects https://review.openstack.org/425463 | 21:25 |
| thomasem | jimbaker: you cool w/ me adding https://bugs.launchpad.net/craton/+bug/1665779 and https://bugs.launchpad.net/craton/+bug/1665780 to our 0.1.0 milestone and setting to 'High' priority? | 21:27 |
| openstack | Launchpad bug 1665779 in craton "error using generated link for collection with parameter defaulted to None" [Undecided,In progress] - Assigned to Thomas Maddox (thomas-maddox) | 21:27 |
| openstack | Launchpad bug 1665780 in craton "error using generated pagination links for Projects collection" [Undecided,In progress] - Assigned to Thomas Maddox (thomas-maddox) | 21:27 |
| thomasem | I threw up a quick fix for them, just need to test a bit more and write functional tests to be sure it actually fixes them. | 21:27 |
| thomasem | Found them in the course of doing cloud work, so figured I'd get them captured now. | 21:28 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Use String for Project ID in schema https://review.openstack.org/435599 | 21:29 |
| *** VW has quit IRC | 21:46 | |
| *** VW has joined #craton | 21:51 | |
| *** VW has quit IRC | 21:56 | |
| *** VW has joined #craton | 22:15 | |
| *** VW has quit IRC | 22:19 | |
| jimbaker | thomasem, sounds good to me | 22:39 |
| jimbaker | farid, btw, with the last fix in master (https://github.com/openstack/craton/commit/462c501b13e0510c69a742141f809a21a141685a), craton cell-list -r1 now works. next step: remove the requirement to specify -r (which is in my WIP work on client var support) | 22:41 |
| farid | o/ | 22:43 |
| *** VW has joined #craton | 22:48 | |
| jimbaker | hope to get some good progress in this weekend with respect to CLI stuff. lots of possible spit & polish. but will also ski :) | 22:51 |
| *** VW has quit IRC | 22:53 | |
| farid | yep don't want to miss the ski :) hehe | 22:55 |
| farid | have fun! | 22:55 |
| jimbaker | farid, thanks. yeah, should have fresh snow through this weekend in the mountains. although much more forecast for next weekend. meanwhile it will stay in the 60s and 70s and sunny in the denver/boulder area. just the way i like it | 22:58 |
| *** VW has joined #craton | 22:59 | |
| farid | very cool | 22:59 |
| jimbaker | "pick your adventure" | 22:59 |
| *** VW has quit IRC | 23:03 | |
| *** VW has joined #craton | 23:12 | |
| jimbaker | thomasem, re https://review.openstack.org/#/c/435599/ - maybe you should look at the verification of the uuid for the project btw; example: http://127.0.0.1:8080/v1/projects/i-am-not-an-actually-valid-uuid | 23:14 |
| jimbaker | but there is a whole bunch of possible fuzzing possible on project uuid fwiw - most examples i tried fail properly, but not uniformly | 23:15 |
| jimbaker | in terms of reported error messages | 23:15 |
| jimbaker | anyway, not necessarily in scope for this change. just thought i would mention it as part of spit & polish work. the important thing is they fail, the next step is to just make sure they fail with correct errors | 23:17 |
| *** jovon has quit IRC | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!