| *** IRCFrEAK has joined #craton | 01:31 | |
| *** IRCFrEAK has left #craton | 01:31 | |
| *** VW has joined #craton | 01:48 | |
| *** madgoat has joined #craton | 04:38 | |
| *** madgoat has left #craton | 04:38 | |
| *** VW_ has joined #craton | 04:49 | |
| *** VW_ has quit IRC | 04:49 | |
| *** VW has quit IRC | 04:49 | |
| *** VW has joined #craton | 04:50 | |
| *** VW has quit IRC | 04:54 | |
| *** VW has joined #craton | 05:03 | |
| *** VW has quit IRC | 05:04 | |
| *** VW has joined #craton | 05:04 | |
| *** VW has quit IRC | 07:43 | |
| thomasem | jimbaker: Are you mentioning that as additional validation to add to that schema definition? :) | 13:46 |
|---|---|---|
| *** VW has joined #craton | 14:13 | |
| *** VW has quit IRC | 14:35 | |
| jimbaker | thomasem, i don't think the schema definition can do this - it can only say i take a string or int or object of ... | 14:53 |
| jimbaker | right now, such calls fail when we attempt to construct a UUID from the input | 14:53 |
| thomasem | You said "such calls". Which calls are you referring to? | 14:53 |
| jimbaker | just need to make sure we do this in a uniform fashion, that's all. much like we already do if we attempt to look up an object by a non-existent id and we get 404 | 14:53 |
| jimbaker | thomasem, sure, nothing like a conversation spread out over a few days :) | 14:54 |
| thomasem | lol, yes | 14:54 |
| thomasem | I'm pretty sure I could add a regex filter to that definition? | 14:54 |
| jimbaker | so context here: http://127.0.0.1:8080/v1/projects/i-am-not-an-actually-valid-uuid | 14:54 |
| thomasem | Right, that's supposed to have a validation error, or 404? | 14:54 |
| jimbaker | thomasem, yeah, but that is of diminishing return | 14:54 |
| jimbaker | a 404 sounds reasonable to me | 14:55 |
| thomasem | Me too | 14:55 |
| jimbaker | just not a 500 | 14:55 |
| thomasem | 404 sounds most reasonable, even. | 14:55 |
| thomasem | But, instead, it's giving a validation error | 14:55 |
| thomasem | The patch you linked had to do with uuid's in URL params. | 14:56 |
| thomasem | not part of the path | 14:56 |
| thomasem | So, 404 wouldn't make sense there. | 14:56 |
| thomasem | Maybe empty list, then? | 14:57 |
| thomasem | Since it'd essentially return nothing from the DB. Or a validation error, so the user doesn't keep trying to do the wrong thing? | 14:57 |
| thomasem | Or at least we try to inform them. :P | 14:57 |
| jimbaker | thomasem, yeah, something like that | 14:57 |
| jimbaker | to be honest, i'm suffering a bit from ENOCONTEXT | 14:58 |
| thomasem | Basically, I was getting errors when trying to use the generated links for /projects | 14:58 |
| jimbaker | but when i was looking at that patch, i found myself playing with various futzing on the project uuid to see what would happen | 14:58 |
| thomasem | Because those links included params that weren't being handled as expected. | 14:59 |
| thomasem | Or params that weren't supposed to be there | 14:59 |
| jimbaker | yeah, something like that | 14:59 |
| jimbaker | btw, meeting now | 15:00 |
| thomasem | yeah | 15:00 |
| *** VW has joined #craton | 15:10 | |
| *** david-lyle has joined #craton | 15:53 | |
| *** david-lyle has quit IRC | 16:18 | |
| *** VW has quit IRC | 16:30 | |
| *** VW has joined #craton | 16:31 | |
| *** acabot has quit IRC | 16:57 | |
| *** VW has quit IRC | 17:03 | |
| *** VW has joined #craton | 17:03 | |
| *** VW has quit IRC | 17:11 | |
| *** VW has joined #craton | 17:15 | |
| * thomasem needs food | 17:16 | |
| *** VW has quit IRC | 17:21 | |
| *** tojuvone has quit IRC | 17:32 | |
| *** VW has joined #craton | 17:36 | |
| openstackgerrit | git-harry proposed openstack/craton master: Add devices endpoint https://review.openstack.org/435005 | 17:37 |
| openstackgerrit | Jim Baker proposed openstack/python-cratonclient master: WIP: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:49 |
| openstackgerrit | Jim Baker proposed openstack/python-cratonclient master: WIP: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:53 |
| *** david-lyle has joined #craton | 18:47 | |
| *** david-lyle has quit IRC | 19:15 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 19:26 |
| *** david-lyle has joined #craton | 19:27 | |
| *** david-lyle has quit IRC | 19:50 | |
| *** david-lyle_ has joined #craton | 19:50 | |
| *** david-lyle_ has quit IRC | 19:59 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 20:15 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 20:34 |
| thomasem | :\ going to be a big patch | 20:35 |
| thomasem | Already at almost 900 lines to wire up Clouds | 20:36 |
| thomasem | Still needs API controllers and functional tests, afaict. | 20:36 |
| thomasem | And any changes to controllers for other resources that are now dependent on a cloud_id | 20:36 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: WIP: Add Cloud resource https://review.openstack.org/431705 | 20:39 |
| *** david-lyle has joined #craton | 20:43 | |
| *** david-lyle has quit IRC | 20:50 | |
| *** david-lyle has joined #craton | 21:04 | |
| jimbaker | thomasem, sure, but it's a straightforward patch, since it follows region so closely. i assume this expectation holds, right? i just quickly scanned through the WIP and it seems to be true | 21:19 |
| thomasem | jimbaker: yep | 21:19 |
| jimbaker | unlike say the project vars work, which intersected with mini-RBAC | 21:19 |
| thomasem | +1 | 21:20 |
| *** david-lyle has quit IRC | 21:55 | |
| thomasem | So, how about that tornado that came right through central Texas? | 21:59 |
| thomasem | or was it tornados? | 21:59 |
| thomasem | Pretty sure the surrounding storms kept me up a lot of the night with what felt like a pressure washer on my window. | 21:59 |
| jimbaker | thomasem, crazy weather impacting you in san antonio | 22:34 |
| thomasem | I'm in Austin, but, yerp. | 22:34 |
| thomasem | Apparently knocked out power for a bunch of folks close by. | 22:35 |
| thomasem | Makes me think I probably should have checked the weather more carefully before going to bed, lol. | 22:38 |
| *** VW has quit IRC | 22:55 | |
| *** VW has joined #craton | 22:57 | |
| *** VW has quit IRC | 22:59 | |
| *** VW has joined #craton | 22:59 | |
| thomasem | Alright. I've had plenty of fun for the day. Have a wonderful evening/day folks! | 23:01 |
| jimbaker | thomasem, thanks. take care, and hopefully no adverse weather for you! | 23:15 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!