| *** Syed__ has quit IRC | 00:55 | |
| *** david-lyle has joined #craton | 00:58 | |
| *** jovon has quit IRC | 01:02 | |
| *** david-lyle has quit IRC | 01:05 | |
| *** VW_ has quit IRC | 02:09 | |
| *** VW has joined #craton | 02:32 | |
| *** david-lyle has joined #craton | 03:02 | |
| *** david-lyle has quit IRC | 03:07 | |
| *** VW has quit IRC | 03:23 | |
| *** VW has joined #craton | 03:23 | |
| *** VW has quit IRC | 03:27 | |
| *** VW has joined #craton | 03:27 | |
| *** VW has quit IRC | 03:52 | |
| *** VW has joined #craton | 04:09 | |
| *** david-lyle has joined #craton | 05:04 | |
| *** david-lyle has quit IRC | 05:08 | |
| *** VW has quit IRC | 05:31 | |
| *** david-lyle has joined #craton | 07:05 | |
| *** david-lyle has quit IRC | 07:10 | |
| *** tojuvone has joined #craton | 07:52 | |
| sulo | o/ | 09:15 |
|---|---|---|
| openstackgerrit | sulochan-acharya proposed openstack/craton master: Ensures no extra property is allowed on creates https://review.openstack.org/437606 | 09:31 |
| *** tojuvone has quit IRC | 09:43 | |
| git-harry | jimbaker: I don't see the use of the devices object as unnecessary nesting, the nesting has come with the introduction of the hosts and network-devices arrays. devices provides a clear separation between the data (devices) and any metadata (currently links) that gets returned with the object. | 09:52 |
| openstackgerrit | sulochan-acharya proposed openstack/craton master: Ensures no extra property is allowed on creates https://review.openstack.org/437606 | 09:57 |
| openstackgerrit | sulochan-acharya proposed openstack/craton master: Ensures no extra property is allowed on creates https://review.openstack.org/437606 | 10:05 |
| openstackgerrit | git-harry proposed openstack/craton master: Add GET /v1/devices https://review.openstack.org/437585 | 10:54 |
| openstackgerrit | git-harry proposed openstack/craton master: Add GET /v1/devices https://review.openstack.org/437585 | 11:13 |
| *** tojuvone has joined #craton | 11:30 | |
| *** openstackgerrit has quit IRC | 12:18 | |
| thomasem | o/ | 13:05 |
| sigmavirus | o/ | 13:08 |
| sigmavirus | <expletive>Charter is having an outage so I have the joy of tethering from my phone for the morning at least | 13:08 |
| sigmavirus | farid: I can't meet today at that time | 13:12 |
| sigmavirus | I have to head to the dentist to pick up an occlusion guard | 13:12 |
| thomasem | :( | 13:12 |
| thomasem | sulo: At what point would testing the excluded POST properties become impractical? I'm not sure I follow. | 13:14 |
| *** VW has joined #craton | 13:20 | |
| sulo | thomasem: heh, its not and i have updated the patch. I meant testing every property like that might be so .. should be tests be per property or to get that the logic is sound ? | 13:23 |
| sigmavirus | sulo: could have a semi-generative test that uses hte blacklist global in the schemas module to test each of the attributes | 13:25 |
| sigmavirus | I say semi-generative because the only way to actually generate new tests in nose is absolutely terrible (as git-harry has shown by example) and so just having a test that tries to create an X with those properties would make sense | 13:26 |
| sulo | sigmavirus: rgt, sounds good, if i have to update the patch i might go that route | 13:27 |
| thomasem | sulo: I was suggesting either test for each property to ensure there's no regression, or one test that tests for all of them for the verbs we intend to exclude those properties from. | 13:31 |
| sulo | thomasem: sounds good. thx for the suggestion. i have updated the patch. lets go with this for now .. if we extend that list ill refractor to do what sigmavirus suggested | 13:32 |
| thomasem | Hell, you could break it up and test the logic, assert the expected list, and then just assert that the function is called for the expected routes/verbs | 13:33 |
| thomasem | Sure thing! Sounds good to me. :) | 13:33 |
| *** valw has quit IRC | 13:36 | |
| *** openstackgerrit has joined #craton | 13:36 | |
| openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: Adds basic Cloud resource CRUD to CLI https://review.openstack.org/437098 | 13:36 |
| thomasem | How's everyones' Friday going?? :) | 13:45 |
| sigmavirus | Exception of dental appointment and unreliable internet? I tested myself in the foot =P | 13:46 |
| sigmavirus | spent a couple days last year rewriting some of our shell unit tests only to have those backfire on me now :) | 13:46 |
| thomasem | Awww man | 13:47 |
| thomasem | I'm digging around in those, too. | 13:47 |
| thomasem | :P | 13:47 |
| thomasem | knitting cloud_id throughout | 13:47 |
| sigmavirus | Granted, they're easier to deal with now than they used to be | 13:47 |
| thomasem | All you can do. Make it better and better. | 13:47 |
| sigmavirus | but, we baked in assumptions about print_{list,dict} | 13:47 |
| sigmavirus | and that's all going away :) | 13:47 |
| sigmavirus | I think what I'll do, is save that work for a separate patch | 13:48 |
| * thomasem hopes we don't step on toes too much here | 13:48 | |
| thomasem | I've been intentionally following existing patterns to be sure refactorings make sense for Clouds, too. | 13:48 |
| thomasem | to avoid some of that pain | 13:49 |
| thomasem | sigmavirus: which assumptions are you referring to? | 13:51 |
| sigmavirus | thomasem: that's fine | 13:52 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add --format to the client shell https://review.openstack.org/437659 | 13:52 |
| sigmavirus | ^ is going to change how we do formatting though | 13:52 |
| sigmavirus | dramatically makes it easier to understand what we were using before too | 13:52 |
| sigmavirus | just need to add tests for the table formatting | 13:52 |
| sigmavirus | After that, I'll merge in your clouds cli change and then start building on both to replace print_{list,dict} with a more generic handling of our data for output formatting | 13:53 |
| sigmavirus | Also want to visually test the client before any of that gets merged | 13:53 |
| openstackgerrit | sulochan-acharya proposed openstack/craton master: Allow getting vars on get all resouce call https://review.openstack.org/437905 | 13:54 |
| thomasem | sigmavirus: +1! | 14:05 |
| *** VW has quit IRC | 14:18 | |
| sigmavirus | thomasem: glad you like it | 14:21 |
| thomasem | I will be giving a more thorough review, but, yeah. Having formatters is going to be quite helpful. | 14:23 |
| thomasem | This mold is going to kill me. | 14:27 |
| *** VW has joined #craton | 14:33 | |
| farid | morning all | 14:40 |
| farid | sigmavirus: what time works for you? we can work something out with the team | 14:41 |
| sigmavirus | farid: so my appointment is at 10. Which means I have to leave at 9:30 (or possibly earlier given the freezing rain). So 9AM CST? (15 minutes from now) | 14:41 |
| sigmavirus | I don't think jimbaker is around though | 14:43 |
| *** valw has joined #craton | 14:43 | |
| sigmavirus | I'm not sure how long the appointment will take (I don't think it should take very long) but I should be back by 11:30 CST (45 after our usual time) at the latest | 14:43 |
| sigmavirus | (and that's really the absolute latest) | 14:43 |
| farid | we can wait til you're back then chat sigmavirus | 14:44 |
| farid | no hurries, hopefully rest of team have a fairly flexible schedule today, we'll find out :) | 14:44 |
| sigmavirus | farid: I'm just worried about that time being inconvenient for sulo + git-harry | 14:45 |
| sigmavirus | I can provide you with my updates here if that would work better for everyone and they can be recited during the meeting in memoriam of my presence | 14:45 |
| farid | sigmavirus: that should work fine, thanks :) | 14:45 |
| farid | interested in blockers if any so the team can think about them while together later | 14:46 |
| sigmavirus | No blockers on my end today. Working on client formatting and testing refactors. All of this to work towards significantly better client testing and less coupled items. | 14:46 |
| sigmavirus | Actually, only thing approximating a blocker is our lack of review bandwidth | 14:46 |
| sigmavirus | but that's a minor problem | 14:46 |
| * sigmavirus expects people to read that as sardonically as I typed it =P | 14:51 | |
| openstackgerrit | sulochan-acharya proposed openstack/craton master: Allow getting vars on get all resouce call https://review.openstack.org/437905 | 14:54 |
| thomasem | lol sigmavirus | 14:54 |
| thomasem | I'd be happy read sigmavirus's statements to you all in our meeting. Not certain I'll get the tone absolutely correct, but I will try. | 14:55 |
| thomasem | If nothing else, I can read it as if I were reading a children's book. That'd be entertaining. | 14:55 |
| sigmavirus | thomasem: ++ | 14:55 |
| sigmavirus | i'll give you bonus points if you can read it to the rhythm of "Little Miss Muffet" | 14:56 |
| sigmavirus | just keep it SFW. No Andrew Dice Clay versioning | 14:57 |
| thomasem | Bonus points... like Schrute Bucks? | 14:58 |
| thomasem | LOL | 14:58 |
| sigmavirus | exactly. Everyone knows I'm the Assistant something or other, which gives me authority to handout dead deer | 14:58 |
| thomasem | Oh dear. I made myself laugh. | 14:58 |
| thomasem | Baaahhhahaha | 14:59 |
| thomasem | That is definitely something Dwight would do, too. | 14:59 |
| sigmavirus | in better news, should get my gunnar's today | 15:00 |
| thomasem | Excellent! What style did you go for? | 15:00 |
| sigmavirus | Onyx Emmisary's with Crystalline tint lenses | 15:01 |
| thomasem | Oh very nice | 15:02 |
| sigmavirus | also found a 10% coupon | 15:02 |
| sigmavirus | so | 15:02 |
| thomasem | Heyyyy, nice | 15:02 |
| thomasem | Doesn't hurt | 15:02 |
| sigmavirus | exactly. was only 7 bucks, but still nice to get a semi-discount | 15:02 |
| sigmavirus | brb internet's working again. going to switch over to wifi instead of tethering | 15:03 |
| thomasem | awesome | 15:05 |
| thomasem | I spy rebasing on the horizon. | 15:14 |
| thomasem | :P | 15:15 |
| openstackgerrit | Merged openstack/craton master: Ensures no extra property is allowed on creates https://review.openstack.org/437606 | 15:19 |
| thomasem | I wonder how my neighbors will receive it if I show up with already paid for Reactive Dog Rehabilitation classes for their dogs... Investing in my sanity. | 15:22 |
| farid | ugh | 15:26 |
| *** VW_ has joined #craton | 15:27 | |
| *** VW has quit IRC | 15:27 | |
| *** VW_ has quit IRC | 15:28 | |
| thomasem | I can't open my back door without them trying to tear down my fence, lol. | 15:28 |
| *** VW has joined #craton | 15:28 | |
| farid | what a pain, good neighbor finding is probably amongst the hardest part of home buying | 15:31 |
| *** valw has quit IRC | 15:33 | |
| thomasem | Haha, yep. The original neighbor in that house was the seller's agent that sold me this house. | 15:34 |
| thomasem | But, then they moved... and yeah. C'est la vie. :) | 15:34 |
| *** valw has joined #craton | 15:36 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Add Cloud resource before Region https://review.openstack.org/431705 | 15:51 |
| *** Syed__ has joined #craton | 15:59 | |
| openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: Adds basic Cloud resource CRUD to CLI https://review.openstack.org/437098 | 16:02 |
| openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: Adds basic Cloud resource CRUD to CLI https://review.openstack.org/437098 | 16:08 |
| *** valw has quit IRC | 16:09 | |
| thomasem | Alright, both the Craton API Clouds and Craton CLI Clouds patches are gtg, please let me know if you see any issues. | 16:15 |
| thomasem | Added a dependency for the CLI patch to the API patch. | 16:16 |
| thomasem | Actually, flip that. | 16:16 |
| thomasem | I set the CLI patch to depend on the API patch. :) | 16:16 |
| *** valw has joined #craton | 16:22 | |
| *** valw has quit IRC | 16:27 | |
| jimbaker | thomasem, awesome about the cloud work being ready | 16:31 |
| thomasem | jimbaker: !! Mhmm | 16:31 |
| jimbaker | sigmavirus, any thoughts on the format of the devices endpoint that git-harry worked on? i just want to make sure it's workable as it is now | 16:32 |
| thomasem | Thinking about what git-harry said, I'm inclined to agree and am in favor of using {"devices": {"hosts": [...], "network-devices": [...]}} | 16:33 |
| thomasem | For what that's worth. | 16:33 |
| *** david-lyle has joined #craton | 16:35 | |
| jimbaker | thomasem, missed that in my logback from the bouncer | 16:36 |
| jimbaker | taking a look at the actual log | 16:36 |
| jimbaker | ok, works for me. we can obviously make it work with the client | 16:37 |
| *** valw has joined #craton | 16:38 | |
| thomasem | Sounds good! | 16:40 |
| thomasem | It is a beautiful day outside. I'm definitely doing at least dog walkies over lunch, maybe a run. | 16:40 |
| jimbaker | https://etherpad.openstack.org/p/cmdb_prototype_meeting_2017_02_091 | 16:53 |
| jimbaker | https://gist.github.com/anonymous/0885ce1944523e0b78d898457b17f9e3 | 16:54 |
| jimbaker | has the sample data from osic | 16:54 |
| farid | zz_pwnall1337: around for meeting ? | 16:54 |
| jimbaker | corrected link: https://etherpad.openstack.org/p/cmdb_prototype_meeting_2017_02_09 | 16:54 |
| *** valw has quit IRC | 16:58 | |
| *** valw has joined #craton | 17:01 | |
| sigmavirus | o/ | 17:03 |
| openstackgerrit | git-harry proposed openstack/craton master: Add GET /v1/devices https://review.openstack.org/437585 | 17:22 |
| *** zz_pwnall1337 is now known as pwnall1337 | 17:24 | |
| * thomasem is preparing for an epic rebase. | 17:25 | |
| sulo | jimbaker: https://review.openstack.org/#/c/437905/ is the ?details=all to get vars on list calls btw | 17:26 |
| sulo | thomasem: ^ | 17:26 |
| sulo | something that was asked for | 17:26 |
| jimbaker | yep, good stuff | 17:26 |
| sulo | afk for now | 17:26 |
| jimbaker | sulo, cool, we will regroup when you get back | 17:27 |
| jimbaker | should have some stuff merged in just a few | 17:27 |
| jimbaker | thomasem, ok, please rebase away | 17:34 |
| thomasem | Danke shön! | 17:35 |
| *** valw has quit IRC | 17:42 | |
| openstackgerrit | Merged openstack/craton master: Add GET /v1/devices https://review.openstack.org/437585 | 17:43 |
| *** valw has joined #craton | 17:43 | |
| *** pwnall1337 has left #craton | 17:47 | |
| farid | sulo / jimbaker / sigmavirus : http://imagebin.rackspace.com/uploads/35g6ju.png | 17:47 |
| farid | seems like looping over the hostvars section would be good for now | 17:47 |
| farid | here's the link in the screenshot btw https://gist.github.com/anonymous/0885ce1944523e0b78d898457b17f9e3#file-openstack_inventory-fcfs-iad3-3-json-L95 | 17:48 |
| farid | I'll get an osic inventory | 17:48 |
| *** valw has quit IRC | 17:49 | |
| jimbaker | farid, ok. any chance you can put the image somewhere public? | 17:50 |
| farid | ah yeah | 17:50 |
| farid | jimbaker: https://0bin.net/paste/Otr8AjKQS3-SlrSu#h2EofCBQm20f0LVs02kpryenqiys7O0YizAxo0WxPEf | 17:51 |
| farid | and the json links to the 'hostvars' section of the json inventory | 17:51 |
| jimbaker | farid, thanks! | 17:51 |
| farid | yup | 17:51 |
| *** pwnall1337 has joined #craton | 17:56 | |
| pwnall1337 | how does one define whether a host is physical vs container vs vm when importing a device? | 17:57 |
| pwnall1337 | i assumed we were only putting physical inventory hosts in craton but farid told me containers as well. | 17:58 |
| *** valw has joined #craton | 18:11 | |
| openstackgerrit | Merged openstack/craton master: Allow getting vars on get all resouce call https://review.openstack.org/437905 | 18:15 |
| *** valw has quit IRC | 18:16 | |
| jimbaker | pwnall1337, so we consider all of these as host objects, but with a specific parent and device_type (so 'server' or 'container' or 'vm') | 18:22 |
| *** VW has quit IRC | 18:24 | |
| *** valw has joined #craton | 18:25 | |
| *** VW has joined #craton | 18:29 | |
| pwnall1337 | how can i specify the device type? | 18:29 |
| *** valw has quit IRC | 18:29 | |
| sigmavirus | pwnall1337: what are you using? Python client? CLI? | 18:32 |
| sigmavirus | Curl? | 18:32 |
| sigmavirus | httpie? | 18:32 |
| sigmavirus | perl + some HTTP module? | 18:32 |
| sigmavirus | ruby + one of the umpteenmillion HTTP gems? | 18:33 |
| pwnall1337 | lets just hypothetically say im using craton client | 18:34 |
| pwnall1337 | im not, but let's say i am | 18:34 |
| pwnall1337 | well not using the cli | 18:34 |
| pwnall1337 | i am using the objects imported | 18:34 |
| *** valw has joined #craton | 18:38 | |
| *** valw has quit IRC | 18:43 | |
| *** valw has joined #craton | 18:45 | |
| jimbaker | pwnall1337, assuming something like craton-get (https://gist.github.com/jimbaker/9089e381), i will get device_type in the output with v1/devices or v1/hosts or v1/network-devices. i can set this as well, eg with -X PUT -d '{"device_type": "switch2"}' | 18:47 |
| pwnall1337 | jimbaker: are device types documented or is it just any string? | 18:54 |
| jimbaker | pwnall1337, they are just any string | 18:54 |
| *** david-lyle has quit IRC | 18:54 | |
| jimbaker | the assumption is that the user of this inventory has some convention | 18:55 |
| jimbaker | i just updated https://gist.github.com/jimbaker/9089e381af38d9db6bc4af59baed6d47 so it has better support for CRUD ops (post, get, put, delete) | 19:00 |
| jimbaker | should rewrite so it's not duplicating code, but a subsequent revision. my bash is weak | 19:00 |
| jimbaker | ;) | 19:00 |
| *** pwnall1337 is now known as zz_pwnall1337 | 19:04 | |
| *** zz_pwnall1337 is now known as pwnall1337 | 19:15 | |
| *** VW has quit IRC | 19:19 | |
| *** valw has quit IRC | 19:26 | |
| *** valw has joined #craton | 19:33 | |
| *** valw has quit IRC | 19:33 | |
| *** valw has joined #craton | 19:33 | |
| *** VW has joined #craton | 19:44 | |
| thomasem | So, what've folks got planned for the weekend? | 19:54 |
| sigmavirus | thomasem: work on some projects, you? | 19:55 |
| thomasem | Bit of the same. I have to catalog a bunch of needed repairs around the house for the contractor, we're going to see Lego Batman Movie for funsies on Saturday, and probably going plug away at some Craton things as time allows. | 19:57 |
| thomasem | Mow the crazy backyard... seems it turned into a jungle over the week. | 19:57 |
| sigmavirus | ah, our backyard is currently frozen | 19:57 |
| sigmavirus | I have probably a few more weeks before I need to worry about it growing | 19:57 |
| thomasem | Hah! Nice. | 19:57 |
| thomasem | Yeah, I thought I did and then it was upon me in a flash. | 19:58 |
| sigmavirus | We literally had hail and freezing rain this morning, so I'm covered =P | 19:58 |
| thomasem | Yikes | 19:58 |
| *** valw has quit IRC | 20:23 | |
| *** valw has joined #craton | 20:24 | |
| *** valw has quit IRC | 20:26 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Add Cloud resource before Region https://review.openstack.org/431705 | 20:39 |
| *** valw has joined #craton | 20:39 | |
| thomasem | Allright. Think that's gtg ^^ | 20:43 |
| *** valw has quit IRC | 20:44 | |
| openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: Adds basic Cloud resource CRUD to CLI https://review.openstack.org/437098 | 20:49 |
| thomasem | Same with that ^^ | 20:51 |
| *** valw has joined #craton | 20:53 | |
| thomasem | https://bugs.launchpad.net/craton/+bug/1667809 | 20:55 |
| openstack | Launchpad bug 1667809 in craton "500 when creating child resources for parents that don't exist" [Undecided,New] | 20:55 |
| thomasem | ruh roh, Scoob | 20:55 |
| thomasem | brb | 20:57 |
| *** valw has quit IRC | 20:58 | |
| thomasem | back | 21:05 |
| thomasem | Looks like the patch git-harry got in for devices didn't link up properly to their LP issues to set them to Fix Released. I just moved those to Fix Released. They are: https://bugs.launchpad.net/bugs/1664696 and https://bugs.launchpad.net/bugs/1662614 | 21:16 |
| openstack | Launchpad bug 1664696 in craton "Support GET on a collection of devices" [Critical,Fix released] - Assigned to git-harry (git-harry) | 21:16 |
| openstack | Launchpad bug 1662614 in craton "Allow search by parent_id filter to retrieve all child devices" [Critical,Fix released] - Assigned to git-harry (git-harry) | 21:16 |
| *** valw has joined #craton | 21:18 | |
| thomasem | Excellent. Thanks, sigmavirus! | 21:22 |
| sigmavirus | HTH thomasem | 21:22 |
| * sigmavirus hops on VPN | 21:23 | |
| openstackgerrit | Merged openstack/craton master: Add Cloud resource before Region https://review.openstack.org/431705 | 21:25 |
| thomasem | :wookieedance: | 21:26 |
| jimbaker | :) | 21:27 |
| jimbaker | just need the CLI stuff now | 21:27 |
| thomasem | That's on its way in, too. | 21:27 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add --format to the client shell https://review.openstack.org/437659 | 21:29 |
| sigmavirus | Okay, think I'm out for the weekend. Enjoy Lego Batman thomasem | 21:29 |
| thomasem | sigmavirus: Will, do! Thanks. Have a wonderful weekend! | 21:30 |
| thomasem | s/,// :P | 21:30 |
| *** VW has quit IRC | 22:03 | |
| *** VW_ has joined #craton | 22:03 | |
| *** VW_ has quit IRC | 22:04 | |
| *** VW has joined #craton | 22:05 | |
| thomasem | Alright, I need to get running. Have a lovely weekend, everyone!! | 22:13 |
| *** valw has quit IRC | 22:14 | |
| farid | laters thomasem have a great weekend! | 22:15 |
| *** pwnall1337 is now known as zz_pwnall1337 | 22:23 | |
| *** valw has joined #craton | 23:08 | |
| *** valw has quit IRC | 23:14 | |
| *** VW has quit IRC | 23:23 | |
| *** VW has joined #craton | 23:24 | |
| *** david-lyle has joined #craton | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
