farid | aww yeah I got it working | 00:14 |
---|---|---|
farid | wtf debian | 00:14 |
farid | guess I should've tried this in ubuntu since that's what craton will eventually run on doh | 00:16 |
*** jovon has quit IRC | 00:22 | |
*** VW has quit IRC | 00:35 | |
jimbaker | any reason why https://review.openstack.org/#/c/438561/ is not getting merged in? | 00:56 |
*** VW has joined #craton | 01:01 | |
*** Syed__ has quit IRC | 01:05 | |
*** VW has quit IRC | 02:57 | |
*** VW has joined #craton | 03:33 | |
*** VW has quit IRC | 03:34 | |
*** VW has joined #craton | 03:35 | |
openstackgerrit | Jim Baker proposed openstack/craton master: WIP: Variable search for resources now uses resolved variables. https://review.openstack.org/440929 | 04:57 |
*** VW has quit IRC | 05:09 | |
*** tojuvone has quit IRC | 06:52 | |
*** david-lyle has quit IRC | 07:16 | |
*** david-lyle has joined #craton | 07:16 | |
*** tojuvone has joined #craton | 07:26 | |
git-harry | sigmavirus: next time I would prefer you speak to me before picking up something assigned to me. Given that you have a review up referencing the bug, I'm going to assign it to you. I'm also going to assign you the other two bugs referenced by your wip. | 08:36 |
git-harry | sulo: ping | 08:38 |
openstackgerrit | git-harry proposed openstack/python-cratonclient master: Add devices-list to support /v1/devices https://review.openstack.org/438561 | 08:41 |
*** david-lyle has quit IRC | 09:13 | |
*** david-lyle has joined #craton | 09:14 | |
*** david-lyle_ has joined #craton | 09:30 | |
*** david-lyle has quit IRC | 09:31 | |
sulo | git-harry: morning | 09:37 |
git-harry | hiya, I was trying to assign some bugs on launchpad but don't appear to have the right permissions | 09:37 |
git-harry | Can you fix that for me? | 09:38 |
sulo | yeah one sec | 09:40 |
sulo | git-harry: can you try now ? | 09:43 |
openstackgerrit | Merged openstack/python-cratonclient master: Add devices-list to support /v1/devices https://review.openstack.org/438561 | 09:44 |
git-harry | sulo: that's done it. Thanks | 09:44 |
openstackgerrit | Merged openstack/craton master: Move craton to a non-conflicting port https://review.openstack.org/439909 | 09:55 |
openstackgerrit | Sulochan Acharya proposed openstack/craton master: Allow resolved vars in details list calls https://review.openstack.org/439175 | 11:11 |
*** VW has joined #craton | 11:43 | |
openstackgerrit | Sulochan Acharya proposed openstack/python-cratonclient master: Add vars filtering to region-list https://review.openstack.org/440611 | 12:07 |
openstackgerrit | Sulochan Acharya proposed openstack/python-cratonclient master: Adds --vars filter to cell-list command https://review.openstack.org/441097 | 12:34 |
*** VW has quit IRC | 13:04 | |
*** VW has joined #craton | 13:32 | |
*** mhayden has joined #craton | 13:50 | |
*** VW has quit IRC | 13:57 | |
farid | morning guys | 14:36 |
*** VW has joined #craton | 14:37 | |
*** VW has quit IRC | 14:37 | |
*** VW has joined #craton | 14:38 | |
farid | git-harry: https://github.com/osic/ops-generic/tree/master/tools/osa_import_for_craton | 14:43 |
farid | since you were asking | 14:43 |
git-harry | farid: ah, it's got a home. Excellent. Thanks | 14:44 |
farid | :) | 14:45 |
*** jovon has joined #craton | 14:54 | |
thomasem | hey there | 15:00 |
jovon | hola o/ | 15:04 |
thomasem | jovon: How'd training go? | 15:12 |
jovon | a tad disorganized. we were supposed to deploy a multi node env using kolla, but due to lack of communication there was confusion about the location and time. | 15:15 |
thomasem | Yikes | 15:15 |
thomasem | If you don't mind my asking, who was administering the training? | 15:15 |
jovon | and then we received an email saying there was problem with santa clara and had to reschedule :( | 15:16 |
jovon | tbh im not sure who is overseeing the process I'm only on the receiving end from some chained emails from the intel fuys | 15:20 |
jovon | guys* | 15:20 |
thomasem | Ahhhh, I see | 15:22 |
thomasem | Well that's pretty crummy - the miscommunications and such. | 15:22 |
jovon | yes, very much so. | 15:23 |
jovon | gotta make lemonade out of lemons though | 15:23 |
jimbaker | thomasem, here's that code we were discussing yesterday. i need to fix up tests, pep8, the usual. but it works nicely in terms of supporting both multiple vars and resolved vars in a search query: https://review.openstack.org/#/c/440929/ | 15:27 |
thomasem | jovon: haha, undoubtedly | 15:27 |
thomasem | jimbaker: thanks! | 15:27 |
antonym | farid: cool, i'll need to give that script a try | 15:29 |
jimbaker | sulo, should be good to demo for monday, even if we don't get it in by then | 15:29 |
*** Syed__ has joined #craton | 15:34 | |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: WIP: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 15:34 |
openstackgerrit | Syed Ahsan Shamim Zaidi proposed openstack/craton master: Documentation Fix for Region Create https://review.openstack.org/440790 | 15:50 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: WIP: Make column ordering consistent and predictable https://review.openstack.org/440810 | 15:57 |
*** VW_ has joined #craton | 15:59 | |
*** VW__ has joined #craton | 16:01 | |
*** VW_ has quit IRC | 16:01 | |
*** VW__ has quit IRC | 16:02 | |
*** VW has quit IRC | 16:02 | |
*** VW_ has joined #craton | 16:02 | |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: WIP: Make column ordering consistent and predictable https://review.openstack.org/440810 | 16:17 |
* farid o/'s jimbaker | 16:22 | |
sigmavirus | thomasem: jimbaker sulo ^ is ready for review | 16:27 |
sigmavirus | I'll brb | 16:27 |
thomasem | Anyone here know off the top of their head a good way to mock sys.stdin.isatty? :) | 16:39 |
thomasem | Lemme try going up one level. | 16:40 |
thomasem | Got it. | 16:40 |
thomasem | Neeevermind | 16:40 |
thomasem | isatty is read-only, so can't patch it directly, but patching stdin worked fine. | 16:43 |
jimbaker | farid, o/ | 16:45 |
jimbaker | sulo, i think the logical thing for us to do is to get sigmavirus' patch in, then your --vars support (rebased) after that | 16:45 |
sigmavirus | sulo: If you want, I can rebase your change :) | 16:49 |
sigmavirus | git-harry: I'm sorry you took my working on that bug as anything other than trying to make sure it made the deadline | 16:57 |
sigmavirus | I saw no work in progress from you | 16:57 |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: WIP: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:07 |
sigmavirus | thomasem: how's ^ coming along? | 17:12 |
thomasem | sigmavirus: writing tests. Figured we'd get in the projects implementation, then I'll follow up with rest so it doesn't turn into a huge patch? | 17:12 |
thomasem | Already wrote some tests. Definitely looking for feedback. | 17:13 |
farid | sulo: put a playbook to set up an ajaxterm demo box here https://github.com/faridsaad/demobox | 17:13 |
thomasem | Going to update commit message. | 17:13 |
farid | seems to work well with latest debian/ubuntu | 17:13 |
sigmavirus | thomasem: i'll take a look | 17:15 |
thomasem | sigmavirus: thank you! | 17:15 |
thomasem | Probably should have done hosts vars support first... no idea why I did projects? | 17:17 |
thomasem | Maybe I should swap that around. | 17:17 |
sulo | farid: fancy | 17:19 |
sulo | farid: is that running somewhere | 17:19 |
farid | it's pretty basic but hope it simplifies things... tmux seemed to work well inside it | 17:19 |
farid | sulo: yeah try it here https://104.130.11.101/ | 17:19 |
* farid is embarrassed to say the ht user and password is what's in README.md | 17:19 | |
sulo | heh | 17:20 |
sulo | farid: nice .. works well | 17:20 |
farid | cool, hope it can handle a few users for the demo, otherwise we can fall back to vidyo or something else. | 17:21 |
jimbaker | sigmavirus, your patch looks great! next up: hopefully we can standardize on the columns, but that's an easy next step | 17:22 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Clean up shell submodule unit tests https://review.openstack.org/441244 | 17:23 |
sigmavirus | jimbaker: I tried to make the defaults valuable | 17:24 |
sigmavirus | that said, we can now remove lots of code ^ | 17:24 |
jimbaker | +100 | 17:24 |
thomasem | sigmavirus: jimbaker: I'm switching to using hosts for initial implementation in my CLI vars patch. Cool? | 17:24 |
sigmavirus | thomasem: wfm | 17:24 |
jimbaker | thomasem, that's fine | 17:24 |
thomasem | Cool. I think that makes more sense. :P | 17:25 |
thomasem | Fortunately, that was _super_ easy. | 17:25 |
thomasem | So, won't be a biggie to fast-follow. | 17:25 |
sigmavirus | thomasem: see, here's the thing, I expect that if you want to do something it's because it makes more sense than the alternatives | 17:25 |
sigmavirus | You don't need to explain that =P | 17:25 |
jimbaker | agreed. lots of autonomy in this group. we celebrate it! :) | 17:26 |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:27 |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:28 |
sulo | thomasem: jimbaker: sigmavirus: git-harry: can i get a few quick reviews pls, i can fix any concerns now .. but otherwise i am out for the rest of the evening here | 17:28 |
sulo | https://review.openstack.org/#/c/439175/ | 17:28 |
sulo | https://review.openstack.org/#/c/441097/ | 17:28 |
sulo | https://review.openstack.org/#/c/440611/ | 17:28 |
jimbaker | re column choices: i went through systematically with the list commands - project-list, cloud-list, region-list, cell-list, host-list, device-list (no network-*-list, user-list yet...) | 17:28 |
jimbaker | so now that we are consistent in our ordering within a command, we should be consistent across resource collection commands | 17:29 |
jimbaker | in terms of column selection | 17:29 |
sigmavirus | jimbaker: I disagree | 17:30 |
sigmavirus | I tried to be consistent in what I chose to only include in --detail | 17:31 |
jimbaker | sigmavirus, i'm sure that we need different default columns to be selected | 17:32 |
thomasem | sulo: All of those LGTM, pulled them down and tried out the vars queries and such. | 17:32 |
sigmavirus | sulo: jimbaker suggested merging https://review.openstack.org/#/c/441097/ after the column ordering change. Would you be okay with me rebasing it onto that chain? | 17:32 |
sulo | sigmavirus: yes, sounds good | 17:33 |
sigmavirus | I can do teh same with https://review.openstack.org/#/c/440611/ | 17:33 |
sulo | thomasem: thanks ! | 17:33 |
sigmavirus | But I'll likely workflow them after rebase so that as soon as you/jimbaker approve mine yours will go in | 17:33 |
jimbaker | +1 | 17:34 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Adds --vars filter to cell-list command https://review.openstack.org/441097 | 17:35 |
* sigmavirus apologizes in advance for double notification | 17:37 | |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Adds --vars filter to cell-list command https://review.openstack.org/441097 | 17:37 |
thomasem | Boy, if he's apologizing for this one time, what does that make me? | 17:37 |
jimbaker | thomasem, just a vile spammer? ;) | 17:37 |
thomasem | I guess so. | 17:37 |
jimbaker | no, you are all good. we chose to turn this bot on | 17:38 |
sigmavirus | thomasem: I was apologizing because you'd previously apologized | 17:39 |
sigmavirus | And I fubar'd adding a change I made to sulo's tests =P | 17:39 |
sigmavirus | IOW, I felt bad for being sloppy rather than being efficient | 17:39 |
thomasem | Lol, ah. I must have mindlessly apologized. Guess that means it doesn't count? | 17:40 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add vars filtering to region-list https://review.openstack.org/440611 | 17:40 |
sigmavirus | okay, sulo's reviews are rebased and approved | 17:40 |
thomasem | :P | 17:40 |
openstackgerrit | Merged openstack/python-cratonclient master: Make column ordering consistent and predictable https://review.openstack.org/440810 | 17:40 |
sulo | sigmavirus: awesome, thanks! | 17:41 |
sulo | alright then see you all next week | 17:41 |
jimbaker | sulo, cool | 17:41 |
Syed__ | have a good weekend sulo | 17:41 |
sulo | have a good weekend | 17:41 |
thomasem | sigmavirus: working through reviewing your patch, btw. Fixing up my craton-api since --detail isn't working for a lot of calls. | 17:41 |
thomasem | sulo: take it easy! | 17:41 |
*** mudpuppy_zzz has joined #craton | 17:41 | |
*** pwnall138 has joined #craton | 17:42 | |
*** Guest27612 has joined #craton | 17:42 | |
*** fsaad has joined #craton | 17:43 | |
*** zz_pwnall1337 has quit IRC | 17:43 | |
*** palendae has quit IRC | 17:43 | |
*** mudpuppy has quit IRC | 17:43 | |
*** farid has quit IRC | 17:43 | |
*** cloudnull has quit IRC | 17:43 | |
*** Guest27612 is now known as palendae | 17:43 | |
*** cloudnull has joined #craton | 17:44 | |
thomasem | Weird... is --detail supposed to actually work? | 17:45 |
sigmavirus | thomasem: I think sulo has a patch fixing detail | 17:46 |
thomasem | Okay, great | 17:46 |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 17:51 |
thomasem | food | 17:54 |
sigmavirus | Something I'm still bad at: Updating to latest master before making a new branch | 17:58 |
thomasem | Lol | 17:59 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Clean up shell submodule unit tests https://review.openstack.org/441244 | 17:59 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Make column ordering of devices-* consistent https://review.openstack.org/441261 | 17:59 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add vars filtering to region-list https://review.openstack.org/440611 | 17:59 |
openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Adds --vars filter to cell-list command https://review.openstack.org/441097 | 17:59 |
sigmavirus | jimbaker: https://review.openstack.org/#/c/441261/ needs your approval | 17:59 |
sigmavirus | I didn't have the devices code in my tree so that original commit missed it | 18:00 |
jimbaker | sigmavirus, ack | 18:00 |
sigmavirus | (This is why the clean-up commit failed the check jobs) | 18:00 |
*** VW has joined #craton | 18:01 | |
*** VW_ has quit IRC | 18:04 | |
*** VW has quit IRC | 18:05 | |
*** VW has joined #craton | 18:06 | |
*** VW has quit IRC | 18:07 | |
*** VW has joined #craton | 18:08 | |
*** VW_ has joined #craton | 18:09 | |
*** VW has quit IRC | 18:09 | |
*** VW_ has quit IRC | 18:10 | |
*** VW has joined #craton | 18:11 | |
*** VW has quit IRC | 18:12 | |
*** VW has joined #craton | 18:13 | |
*** VW has quit IRC | 18:14 | |
*** VW has joined #craton | 18:14 | |
*** VW has quit IRC | 18:15 | |
*** VW has joined #craton | 18:16 | |
*** VW_ has joined #craton | 18:18 | |
*** VW has quit IRC | 18:18 | |
*** VW_ has quit IRC | 18:19 | |
*** VW has joined #craton | 18:19 | |
antonym | getting a traceback when doing craton host-show 1: https://gist.github.com/antonym/340a0719889d85e24cf3b71bac72172c | 18:20 |
*** VW has quit IRC | 18:21 | |
antonym | just pulled master for client and server | 18:21 |
*** VW has joined #craton | 18:21 | |
*** VW_ has joined #craton | 18:23 | |
*** VW has quit IRC | 18:23 | |
*** VW_ has quit IRC | 18:23 | |
sigmavirus | antonym: I suspect that's from what we just merged from sulo | 18:23 |
* sigmavirus takes a gander | 18:23 | |
sigmavirus | Oh that didn't merge | 18:24 |
sigmavirus | hm | 18:24 |
sigmavirus | also jimbaker https://review.openstack.org/#/c/441244/ is necessary to merge sulo's client reviews | 18:24 |
antonym | i double as a gate job on fridays ;) | 18:24 |
jimbaker | antonym, :) | 18:24 |
sigmavirus | antonym: much obliged =) | 18:25 |
sigmavirus | that's quite weird though | 18:25 |
antonym | https://gist.github.com/antonym/830ca234737e1938cc89b28357ec1bed | 18:27 |
antonym | that's all that was in it | 18:27 |
openstackgerrit | Merged openstack/python-cratonclient master: Make column ordering of devices-* consistent https://review.openstack.org/441261 | 18:28 |
sigmavirus | that's bubbling up through the response_filter | 18:29 |
jimbaker | antonym, so that can happen if you don't set up the variable association table properly; usually this is not a problem | 18:29 |
jimbaker | but it occurs at bootstrap for project | 18:29 |
antonym | ah, did i goof up on creation | 18:30 |
jimbaker | because we do bootstrap at the mysql level, normal integrity stuff is bypassed | 18:30 |
sigmavirus | jimbaker: uh, really? this validation is happening on the response | 18:30 |
sigmavirus | It's happening in response_filter when we call normalize() | 18:31 |
jimbaker | because of project | 18:31 |
openstackgerrit | Merged openstack/python-cratonclient master: Clean up shell submodule unit tests https://review.openstack.org/441244 | 18:31 |
sigmavirus | Ah | 18:31 |
sigmavirus | I see | 18:31 |
jimbaker | and project vars support | 18:31 |
openstackgerrit | Merged openstack/python-cratonclient master: Add vars filtering to region-list https://review.openstack.org/440611 | 18:31 |
sigmavirus | the project is "snippy" and not a UUID | 18:31 |
pwnall138 | tool for importing osa into craton can be found here. https://github.com/osic/ops-generic/tree/master/tools/osa_import_for_craton | 18:31 |
antonym | oh derp | 18:31 |
pwnall138 | needs some tlcc | 18:31 |
sigmavirus | pwnall138: what's the second c? | 18:31 |
sigmavirus | commitment? | 18:32 |
antonym | i snagged out the wrong uuid heh | 18:32 |
jimbaker | this specific problem would be masked if we were more lazy, fwiw | 18:32 |
antonym | the proj is actually 717e9a216e2d44e0bc848398563bdada | 18:32 |
openstackgerrit | Merged openstack/python-cratonclient master: Adds --vars filter to cell-list command https://review.openstack.org/441097 | 18:32 |
antonym | i meant to snip out the token lol | 18:32 |
pwnall138 | 2 issues, when vars are importing, host-show failed because craton has issus parsingthe vars. and when i added labels, a host with labels would throw a 500 when trying to delete it. | 18:32 |
sigmavirus | antonym: also that server port might change | 18:32 |
antonym | yeah, i saw kevin's thing | 18:32 |
sigmavirus | pwnall138: did you create issues on launchpad for those? | 18:33 |
sigmavirus | If not, we *will* most likely lose them | 18:33 |
pwnall138 | just encountered them last night | 18:33 |
sigmavirus | bugs.launchpad.net/craton | 18:33 |
pwnall138 | ill create launchpads soon, but im pretty busy today | 18:33 |
jimbaker | anyway, this is why we have this specific lines in the docker setup, https://github.com/openstack/craton/blob/master/tools/docker_run.sh#L41-L42 | 18:33 |
antonym | think this exception is from having the vars in there? | 18:33 |
jimbaker | antonym, sigmavirus ^^^ | 18:33 |
antonym | jimbaker: so should i recreate with that line then? | 18:34 |
jimbaker | antonym, yes | 18:34 |
antonym | k | 18:34 |
antonym | one sec | 18:34 |
sigmavirus | jimbaker: is there any reason why taht can't be part of an alembic migration to create the database? | 18:34 |
jimbaker | it's absolutely necessary | 18:34 |
sigmavirus | I mean, that seems like a crucial part of setting up craton | 18:34 |
jimbaker | sigmavirus, so that's get into a question of, how do we set up our bootstrap user. with password | 18:34 |
sigmavirus | might be best if every operator configuring craton didn't need that secret sauce for it to work | 18:35 |
antonym | yeah, i just started with my scripts from a few weeks ago | 18:35 |
antonym | so didnt know about that part | 18:35 |
jimbaker | and this is recent | 18:35 |
jimbaker | because of the project vars stuff | 18:35 |
jimbaker | we were not doing this for the bootstrap project | 18:35 |
jimbaker | but it didn't matter until thomasem added project vars support | 18:36 |
jimbaker | in the last couple of weeks or so | 18:36 |
jimbaker | antonym, so that's the backstory, hopefully it makes sense | 18:36 |
antonym | works now | 18:36 |
jimbaker | awesome | 18:36 |
antonym | probably should notate that in docs somewhere | 18:37 |
antonym | is that a perm thing? | 18:37 |
jimbaker | sigmavirus, re making this work better - yeah, i think we have been (implicitly at least) saying that https://github.com/openstack/craton/blob/master/tools/docker_run.sh is the example for how to get things setup | 18:37 |
sigmavirus | jimbaker: yeah, that's not acceptable really at this point | 18:38 |
sigmavirus | It was fine when antonym and everyone else was waiting for craton to be something they could use | 18:38 |
jimbaker | well, i think it's acceptable for today. but not after monday | 18:38 |
sigmavirus | Now that it is something they can and *are* using it needs to be better | 18:38 |
sigmavirus | antonym: fwiw, the ordering of columns in the client should now be fixed | 18:39 |
jimbaker | this is the whole, we need to make this suitable for deployment. whether that's a proper mysql cluster setup; use of an appropriate wsgi server; or user/password mgmt | 18:39 |
jimbaker | the advantage of https://github.com/openstack/craton/blob/master/tools/docker_run.sh is that it puts all the insecure, only do this in dev/test mode, in one place | 18:40 |
jimbaker | real usage needs to create desired users, with high entropy passwords, etc | 18:40 |
jimbaker | antonym, definitely want feedback on that! | 18:42 |
jimbaker | we could certainly create a mysql rollout script that generates high quality passwords; and does the necessary bootstrap linkage for the project. it should also not create this project each time :) | 18:43 |
jimbaker | with identical uuid | 18:43 |
*** valw has joined #craton | 18:43 | |
antonym | yeah, understand that the docker stuff is just for devel | 18:44 |
antonym | cool, the details=all stuff works on vars | 18:44 |
jimbaker | almost feel like we should use an even better :) project uuid like 00000000-0000-0000-0000-000000000000 for the docker_run.sh example. to convey, yes, you will want to change this! | 18:46 |
antonym | kinda looks like searching by two vars doesn't return results | 18:57 |
antonym | /v1/hosts?vars=switch_port:6&details=all | 18:58 |
antonym | er | 18:58 |
antonym | this one: /v1/hosts?vars=switch_name:dfw-tor-1,switch_port:6&details=all | 18:58 |
antonym | by themselves they return results, but together they don't narrow down the host | 18:58 |
jimbaker | antonym, known problem | 19:02 |
jimbaker | and fixed with this patch | 19:02 |
jimbaker | https://review.openstack.org/#/c/440929/ | 19:02 |
jimbaker | please try that and see if it works for you | 19:03 |
antonym | cool, thanks | 19:03 |
antonym | so is hosts becoming devices? | 19:03 |
jimbaker | devices is a heterogenous collection of hosts and network-devices | 19:03 |
antonym | ok | 19:03 |
jimbaker | we plan to add more to devices in the future. example: aws resources | 19:03 |
antonym | i didn't make use of the networking stuff btw, i just made variables called that | 19:04 |
jimbaker | in hind sight, we probably should have used a more generic term, s/device/resource/ | 19:04 |
jimbaker | antonym, yeah, that's what we need to do to support such queries for now | 19:04 |
antonym | k, i'll give that a whirl | 19:04 |
jimbaker | we should be able to query against the network topology, but not there yet | 19:05 |
jimbaker | vars are the workaround for now | 19:05 |
jimbaker | antonym, the nice thing is, you can use vars in the search, wherever they are set in the hierarchy | 19:05 |
antonym | yeah, that's fine, that's what i was used to in galaxy | 19:06 |
jimbaker | antonym, right. network support is still very much WIP, but hopefully it will grow in functionality. until then, the vars stuff was a good idea that we definitely are taking advantage of from what worked in galaxy | 19:09 |
jimbaker | aka, steal those good ideas :) | 19:10 |
anonymike | :D | 19:10 |
antonym | its good to run with proven stuff sometimes :D | 19:10 |
jimbaker | indeed | 19:10 |
thomasem | back | 19:12 |
thomasem | Holy scrollback, Batman. | 19:12 |
*** valw_ has joined #craton | 19:13 | |
*** valw has quit IRC | 19:13 | |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 19:14 |
openstackgerrit | Merged openstack/craton master: Allow resolved vars in details list calls https://review.openstack.org/439175 | 19:19 |
openstackgerrit | Jim Baker proposed openstack/craton master: WIP: Variable search for resources now uses resolved variables. https://review.openstack.org/440929 | 19:35 |
jimbaker | antonym, rebased my var search support patch on top of master | 19:37 |
*** valw_ has quit IRC | 19:58 | |
*** pwnall138 is now known as zz_pwnall138 | 20:00 | |
*** jovon has quit IRC | 20:12 | |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 21:06 |
thomasem | sigmavirus: addressed your comments and added tests ^^ | 21:08 |
thomasem | Bah... some difference with python 3.5 | 21:12 |
thomasem | Looking into it | 21:12 |
thomasem | Looks like they got more strict about Mock() in a range evaluation | 21:23 |
openstackgerrit | Thomas Maddox proposed openstack/python-cratonclient master: CLI and client support for get/set/delete of resource vars https://review.openstack.org/427032 | 21:23 |
*** VW has joined #craton | 21:35 | |
*** VW has quit IRC | 21:35 | |
*** VW has joined #craton | 21:35 | |
thomasem | Wells, I think I'm done for the week. I'll work on this more this weekend as I get time. | 21:50 |
*** VW has quit IRC | 21:59 | |
fsaad | laters thomasem , have a great weekend man! | 22:00 |
jimbaker | thomasem, thanks so much! | 22:15 |
jimbaker | and have a great weekend! | 22:15 |
*** david-lyle_ is now known as david-lyle | 23:29 | |
*** VW has joined #craton | 23:32 | |
*** david-lyle has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!