| *** Syed__ has quit IRC | 00:25 | |
| *** VW has joined #craton | 02:21 | |
| *** VW has quit IRC | 04:17 | |
| *** VW has joined #craton | 04:17 | |
| *** VW has quit IRC | 05:32 | |
| *** VW has joined #craton | 05:33 | |
| openstackgerrit | Tao Li proposed openstack/craton master: Remove log translations https://review.openstack.org/447833 | 05:50 |
|---|---|---|
| *** VW has quit IRC | 06:37 | |
| openstackgerrit | Tao Li proposed openstack/craton master: Remove log translations https://review.openstack.org/447833 | 08:02 |
| openstackgerrit | Tao Li proposed openstack/craton master: Remove log translations https://review.openstack.org/447833 | 08:04 |
| -openstackstatus- NOTICE: Wiki is broken with database problems, we are working to resolve it | 08:28 | |
| *** ChanServ changes topic to "Wiki is broken with database problems, we are working to resolve it" | 08:28 | |
| *** ChanServ changes topic to "Summit talk: https://www.youtube.com/watch?v=Q-sf12SDR3M || Logs: http://eavesdrop.openstack.org/irclogs/%23craton/latest.log.html || Mon 1500 UTC in #openstack-meeting-4 || Client/ecosystem Tues 1700 UTC || Core Thur 1700 UTC || Resources: https://etherpad.openstack.org/p/Fleet_Management" | 08:37 | |
| -openstackstatus- NOTICE: Wiki problems have been fixed, it's up and running | 08:37 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| sulo | o/ | 10:09 |
| *** openstackgerrit has joined #craton | 10:24 | |
| openstackgerrit | Sulochan Acharya proposed openstack/craton master: Create user under project_id passed in request https://review.openstack.org/446972 | 10:24 |
| *** VW has joined #craton | 12:08 | |
| *** VW has quit IRC | 12:16 | |
| *** VW has joined #craton | 12:47 | |
| sigmavirus | belated mornings | 12:53 |
| openstackgerrit | Merged openstack/craton master: Include project_id only where needed https://review.openstack.org/446938 | 13:03 |
| thomasem | o/ | 13:17 |
| thomasem | So, where did we want to enumerate retro topics into the future, so folks know where to go when something occurs to them that they wish to discuss in retro? The main meeting etherpad? | 13:18 |
| openstackgerrit | Antony Messerli proposed openstack/craton master: Updates documentation for setting up a dev env https://review.openstack.org/447697 | 13:23 |
| sigmavirus | thomasem: so is that retro going to be open to all folks in this channel? | 13:41 |
| thomasem | sigmavirus: I sure hope so | 13:41 |
| sigmavirus | Or is this going to be a Rackspace specific retro? That's one thing I don't have clarity on | 13:41 |
| thomasem | If it's not, I'm concerned. | 13:41 |
| thomasem | fsaad: ^^ | 13:42 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 13:47 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Move to MySQL 5.7 and SQLAlchemy>=1.1.0 https://review.openstack.org/443186 | 13:47 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Variable search for resources now uses resolved variables. https://review.openstack.org/440929 | 13:47 |
| thomasem | antonym: thanks a 'mil for the doc updates. I made that the parent to the variables work. | 13:50 |
| antonym | thomasem: sweet, no prob | 13:50 |
| sigmavirus | thomasem: did you mention problems with docker networking yesterday? | 13:56 |
| thomasem | sigmavirus: Only for trying to run functional tests on OS X. | 13:56 |
| * sigmavirus can't even talk to craton via an exposed port on ubuntu | 13:56 | |
| thomasem | Oh? | 13:56 |
| thomasem | sigmavirus: are you mapping to the new default port, or 8080? | 13:56 |
| sigmavirus | ohhhh | 13:56 |
| sigmavirus | what's the new port? | 13:56 |
| thomasem | https://github.com/openstack/craton/blob/master/etc/craton-api-conf.sample#L11 | 13:57 |
| sigmavirus | nevermind | 13:57 |
| thomasem | sigmavirus: ^^ | 13:57 |
| * sigmavirus angsts | 13:57 | |
| sigmavirus | thanks | 13:58 |
| thomasem | sigmavirus: you bet! | 13:58 |
| sulo | thomasem: so we stil not sync with global req ? | 13:58 |
| * sigmavirus missed that merging | 13:58 | |
| sigmavirus | sulo: correct | 13:58 |
| sulo | sigmavirus: why so ? | 13:58 |
| sigmavirus | thomasem: now I'm getting 401's that the bootstrap user isn't permitted to access the server | 13:58 |
| thomasem | sulo: yeah, until the entry in global-requirements.txt matches our lower-bound. We want to communicate the limitations of our project. | 13:59 |
| sigmavirus | sulo: the reason is loosely that we're likely to update our own requirements faster than g-r | 13:59 |
| thomasem | sulo: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L278 that's too low for our lower-bound. It must be >=1.1.0. | 14:00 |
| sigmavirus | thomasem: so will these tests need to create their own user with the bootstrap user and then do things? | 14:00 |
| thomasem | sigmavirus: Not if we can inject different values at record time... I thought that was the change you were going to make? Is that not possible, or a good idea? | 14:01 |
| sigmavirus | thomasem: it is possible, but I can't even re-record those cassettes now | 14:01 |
| thomasem | Oh... huh | 14:01 |
| sulo | thomasem: sigmavirus: so the worry is if someone is already usign that version its not getting updated ... | 14:01 |
| sigmavirus | I'm trying to use the bootstrap user to record these, but it seems that won't work | 14:02 |
| sigmavirus | sulo: the worry is that if we only use what's in g-r, someone might use something older than 1.1.0 and they won't have a functioning craton | 14:02 |
| thomasem | I don't see how, if the env vars are set for the bootstrap user's creds? | 14:02 |
| sulo | sigmavirus: tests create its own user with given project_id straight into the db | 14:02 |
| thomasem | sulo: sigmavirus is talking about cratonclient integration tests | 14:02 |
| sulo | oh gotcha re:client | 14:03 |
| thomasem | Regarding recording API responses so we don't need to call an actual API all of the time. | 14:03 |
| sigmavirus | or impose the cost of setting up a container per-test on the test runner(s) | 14:03 |
| thomasem | Yeah... that'd hurt | 14:03 |
| thomasem | sigmavirus: Can you, out of band, talk to the API using that bootstrap user? | 14:04 |
| thomasem | Not through the tests | 14:04 |
| sulo | sigmavirus: thomasem: so whats the strategy to sync with global for other pkgs .. it might take ages before g-r gets to 1.1.0 ? | 14:06 |
| sigmavirus | with curl it seems to work | 14:07 |
| sigmavirus | sulo: what other packages? | 14:08 |
| thomasem | Hmmm... and you're sure the tests have the same creds? Are the cassettes deleted? I'm not 100% sure how that works, but when I inserted some extra calls I was getting errors because it was trying to run that call against a cassette that didn't contain that call. | 14:08 |
| sigmavirus | integrated projects don't rely on features of libraries/databases taht they can't guarantee will be there | 14:08 |
| thomasem | So, that's one way to kind of tracer-bullet debug that | 14:08 |
| thomasem | Is deleting the cassettes the way to re-record? Or do you flip something else? | 14:09 |
| sulo | sigmavirus: olso.xxx for example | 14:09 |
| sigmavirus | I delete cassettes and re-record | 14:09 |
| sigmavirus | sulo: that's an integrated project | 14:10 |
| sigmavirus | it won't promise support for things that it can't actually support | 14:10 |
| sulo | sigmavirus: what does that mean ? | 14:10 |
| sulo | not sure i follow | 14:10 |
| sulo | does olso not release new version of things etc ? | 14:10 |
| sigmavirus | oslo does release new versions, usually several times over a development cycle | 14:11 |
| sigmavirus | They won't release a feature that depends on a version of a library that is newer than a lower bound though | 14:11 |
| sulo | sigmavirus: and do we not care about those new releases ? | 14:11 |
| sigmavirus | oslo.db, for example, wouldn't support something that's only sqla 1.1.0 when the minimum version is lower than that | 14:11 |
| sigmavirus | sulo: we do | 14:11 |
| sigmavirus | and we consume them because we're not pinning to specific versions | 14:11 |
| sulo | sigmavirus: so do we care to get upto date with that or not ? you sayiing it not important as long as we freeze ? | 14:12 |
| sigmavirus | I'm saying, we don't freeze versions, so we will inherently, by the default behaviour of pip, remain up-to-date with oslo releases | 14:13 |
| sigmavirus | We do not cap our dependencies in craton | 14:13 |
| sigmavirus | So we will always get the newest version, for better or for worse | 14:13 |
| sigmavirus | my kingdom for craton to log things that are actually useful | 14:14 |
| sulo | ah right, so we dont care taht g-r caps right ? | 14:14 |
| sulo | nevermind, i think it makes sense | 14:15 |
| sigmavirus | g-r has aggressively removed caps on dependencies | 14:15 |
| sigmavirus | g-r is using upper-constraints to test a specific version without capping though | 14:15 |
| sulo | sigmavirus: gotcha | 14:15 |
| sigmavirus | that is what prevents surprise breakage | 14:15 |
| sulo | yeah makes sense | 14:15 |
| sulo | cool cool i understand now .. thanks | 14:15 |
| thomasem | sigmavirus: I'm going to pull your patch and see if I can better understand the problem. | 14:17 |
| sigmavirus | thomasem: it's not all in that patch at the moment | 14:17 |
| thomasem | Ah | 14:17 |
| thomasem | I need to step away for like 15 minutes or so. Want to Vidyo after that, sigmavirus? | 14:21 |
| sigmavirus | Sounds good thomasem | 14:21 |
| fsaad | retro is open, thought we discussed sending invite to openstack dev list with subject [CRATON] in right ? | 14:23 |
| fsaad | good morning btw ;) | 14:23 |
| sigmavirus | sitting in craton-recordable | 14:29 |
| fsaad | it's 90 mins away for me sigmavirus | 14:30 |
| fsaad | for me it shows 11am-12pm central | 14:30 |
| fsaad | that's how exchange added it anyways | 14:30 |
| sigmavirus | fsaad: ah, I'm talking about an impromptu pairing session with thomasem | 14:31 |
| fsaad | got it thanks ;) | 14:31 |
| fsaad | was still reading scroll heh | 14:31 |
| *** Syed__ has joined #craton | 14:40 | |
| thomasem | fsaad: Yeah, that was my impression, too. I don't think a .ics went out yet, though. Thanks for clearing that up! | 14:49 |
| thomasem | Interesting that the push to the betamax review didn't dispatch an IRC message? | 14:55 |
| sigmavirus | thomasem: very interesting | 15:13 |
| openstackgerrit | Merged openstack/python-cratonclient master: Enable coverage report in console output https://review.openstack.org/433505 | 15:14 |
| fsaad | what's this betamax review y'all talk about ? | 15:22 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add tests for our cells integration https://review.openstack.org/445515 | 15:23 |
| sigmavirus | well that one worked | 15:24 |
| anonymike | I'd like to submit some updates on the docs. Nothing major, I'd just like to get some of those sweet launchpad gerrit points ;) I'm about to report a bug on the dev environment docs but noticed antonyms parent bug is very similar. Should I piggy back off of that or follow through and create a new bug. | 15:24 |
| sigmavirus | fsaad: https://review.openstack.org/#/c/442165/10 which appears to be failing | 15:24 |
| sigmavirus | anonymike: that's up to your judgment | 15:24 |
| fsaad | ah! thanks sigmavirus | 15:24 |
| anonymike | hmm I'm not sure how to create a child bug. Perhaps that's a better exercise | 15:25 |
| jimbaker | thomasem, the retrospective is open to everyone. tojuvone plans to attend, along with intel folks | 15:26 |
| anonymike | I'll try that | 15:26 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add Betamax for testing https://review.openstack.org/442165 | 15:26 |
| sigmavirus | anonymike: there's no such thing as a child bug | 15:26 |
| sigmavirus | sorry, I misunderstood your original question | 15:26 |
| anonymike | oh? | 15:26 |
| thomasem | jimbaker: +1, good deal | 15:26 |
| anonymike | what is the parent in reference to here https://review.openstack.org/#/c/447697/ | 15:27 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add tests for our cells integration https://review.openstack.org/445515 | 15:27 |
| anonymike | a child patch? | 15:27 |
| sigmavirus | anonymike: do you mean 584f0551facf065564d8cb2bdcb7fbb138332504? on the gerrit page? | 15:28 |
| jimbaker | sigmavirus, thomasem, so with the env vars for https://review.openstack.org/#/c/442165/, no changes required to dbsync bootstrap, right? | 15:28 |
| sigmavirus | That's the parent commit sha | 15:28 |
| anonymike | sigmavirus: yes | 15:28 |
| sigmavirus | anonymike: want a quick introduction to how git works under the hood? | 15:28 |
| thomasem | jimbaker: that's the idea. We're using placeholders in the recordings so it won't require any specific credentials for replaying the recorded API responses. | 15:29 |
| thomasem | iiuc | 15:29 |
| anonymike | sigmavirus: I'm pretty familiar but I'm sure it wouldn't hurt | 15:29 |
| jimbaker | got it, that sounds the right approach to me. also better than having this type of data explicitly everywhere in the recordings | 15:30 |
| sigmavirus | anonymike: are you familiar with the way that repository history is stored as a Directed Acyclic Graph? | 15:30 |
| thomasem | jimbaker: definitely | 15:30 |
| anonymike | sigmavirus: yes | 15:30 |
| sigmavirus | so each commit has at least one commit that is it's 'parent' | 15:30 |
| sigmavirus | merge commits tend to have at least 2 | 15:31 |
| thomasem | https://betamax.readthedocs.io/en/latest/configuring.html#filtering-sensitive-data | 15:31 |
| sigmavirus | octopus commits have been known to have over 50 (in the kernel) | 15:31 |
| sigmavirus | So the parent in the gerrit view is just the parent commit's SHA1 | 15:31 |
| sigmavirus | That has no impact on LaunchPad | 15:31 |
| anonymike | !!! i didn't read the subject matter of the commit correctly. I thought it was a direct reference to a typo in the docs | 15:32 |
| openstack | anonymike: Error: "!!" is not a valid command. | 15:32 |
| sigmavirus | lol anonymike don't upset openstack bot | 15:33 |
| thomasem | LOL | 15:33 |
| anonymike | So I thought it was somehow related to what antonym did | 15:33 |
| thomasem | openstack bot smash !!! | 15:33 |
| anonymike | haha welp, im sorry openstack bot | 15:33 |
| * anonymike will stop overcomplicating things | 15:34 | |
| sigmavirus | anonymike: gerrit is confusing | 15:35 |
| *** palendae_ is now known as palendae | 15:35 | |
| anonymike | lol I was trying to make it a lot more confusing :/ Anyway, I'm just gonna keep going along with this task and try not to upset anyone or any bots | 15:39 |
| jimbaker | sulo, https://review.openstack.org/#/c/446972/ - just wanted to find out your plan for the duplicate user creation bug (which could be done as part of overall users functional testing) | 15:44 |
| jimbaker | didn't want this problem i observed get lost... | 15:44 |
| sulo | jimbaker: ah thats tracked separately | 15:45 |
| sigmavirus | anonymike: you only upset the bots | 15:45 |
| jimbaker | also worthwhile in general. try for example this: craton-post v1/projects name=baz | 15:45 |
| sulo | jimbaker: see commit msg on test coverage too .. i've tracked that separately too | 15:45 |
| sulo | https://bugs.launchpad.net/craton/+bug/1674347 | 15:45 |
| openstack | Launchpad bug 1674347 in craton "User create throws 500 error on bad uuid string" [Medium,New] - Assigned to Sulochan Acharya (sulochan-acharya) | 15:45 |
| sigmavirus | anonymike: don't think you upset any of us =) | 15:45 |
| jimbaker | repeatedly | 15:45 |
| sulo | will tackle the dup with that ^ | 15:46 |
| jimbaker | sulo, ok, not quite the same, but sounds reasonable | 15:46 |
| jimbaker | i will add my bug report to that, and will +2 the user in project fix | 15:46 |
| sulo | jimbaker: yeah, i need to tackle excpetion on that | 15:46 |
| sulo | so dup exception will get wrapped | 15:47 |
| sulo | jimbaker: sounds good | 15:47 |
| sulo | jimbaker: i didnt want to start fixing separate things on that patch is all | 15:48 |
| thomasem | Please add topics to the etherpad for retro! https://etherpad.openstack.org/p/craton-meetings (starting at line 85) | 15:48 |
| jimbaker | sulo, understood | 15:48 |
| jimbaker | i suggest we go through a program of systematic testing | 15:49 |
| jimbaker | such as attempt to duplicate a resource, for every type of resource; etc | 15:49 |
| sulo | jimbaker: +1, yeah i caught that uuid error trying to test bad project_id ... but i am sure the same might be true for others | 15:50 |
| sulo | also there are some other problem re tests | 15:50 |
| sulo | for example .. we were testing output to be json in functional tests .. and some were not returning that back .. so that was erroring out too .. | 15:51 |
| sulo | git-harry has fixed that though in his latest patch | 15:51 |
| jimbaker | a bit of refactoring is probably necessary to do this systematically as well - want to parse project uuid the same way, every usage... | 15:51 |
| jimbaker | cool | 15:51 |
| sulo | yeah true | 15:52 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add integration tests for clouds client https://review.openstack.org/445909 | 15:52 |
| openstackgerrit | Ian Cordasco proposed openstack/python-cratonclient master: Add integration tests for regions https://review.openstack.org/446134 | 15:52 |
| sigmavirus | betamax test series updated | 15:53 |
| thomasem | awesome sigmavirus, will take a look | 15:56 |
| jimbaker | so meeting in craton vidyo room... | 16:00 |
| sulo | jimbaker: cool, thanks for updating that | 16:05 |
| jimbaker | tojuvone, are you joining us today for the retrospective? (including report from milan?) | 16:10 |
| sigmavirus | thomasem: in case you've not read it: https://www.amazon.com/Agile-Retrospectives-Making-Teams-Great/dp/0977616649 | 16:11 |
| sigmavirus | https://plans-for-retrospectives.com/en/ is a good companion for the book too | 16:11 |
| openstackgerrit | Merged openstack/craton master: Updates documentation for setting up a dev env https://review.openstack.org/447697 | 16:16 |
| tojuvone | jimbaker, yes, just need to bring kid to soccer soon, but back 17 UTC | 16:26 |
| openstackgerrit | Merged openstack/craton master: Variable search for resources now uses resolved variables. https://review.openstack.org/440929 | 16:41 |
| git-harry | https://review.openstack.org/#/dashboard/?foreach=%2528project%253A%255Eopenstack%252Fopenstack%252Dansible.%252A%2529%250Astatus%253Aopen%250ANOT+owner%253Aself%250ANOT+label%253AWorkflow%253C%253D%252D1%250Alabel%253AVerified%253E%253D1%252Cjenkins%250ANOT+label%253ACode%252DReview%253E%253D0%252Cself&title=OpenStack%252DAnsible+Review+Inbox&Reviews+Requested+by+PTL=starredby%253Ajesse%252Dpretorius&Need | 16:47 |
| git-harry | s+Feedback+%2528Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%2529=NOT+label%253ACode%252DReview%253C%253D2+age%253A5d&You+are+a+reviewer+but+haven%2527t+voted+in+the+current+revision=NOT+label%253ACode%252DReview%253C%253D2%252Cself+reviewer%253Aself&Needs+final+%252B2=label%253ACode%252DReview%253E%253D2+limit%253A50+NOT+label%253ACode%252DReview%253C%253D%252D1%252Cself&Passed+Jenkins% | 16:47 |
| git-harry | 252C+No+Negative+Feedback=NOT+label%253ACode%252DReview%253E%253D2+NOT+label%253ACode%252DReview%253C%253D%252D1+limit%253A50&Wayward+Changes+%2528Changes+with+no+code+review+in+the+last+2days%2529=NOT+label%253ACode%252DReview%253C%253D2+age%253A2d | 16:47 |
| thomasem | By the way, we're past our scheduled time, if anyone needs to run. | 17:08 |
| fsaad | +1 | 17:09 |
| fsaad | the tuesday invite I have is for every two weeks, are we not having a weekly sprint and retro flip flop? | 17:21 |
| jimbaker | fsaad, double checking.... | 17:22 |
| fsaad | thanks just making sure I didn't misunderstand what we ended up agreeing on | 17:22 |
| jimbaker | so it is flip flopping. but you haven't accepted the sprint planning meeting | 17:23 |
| jimbaker | so probably just a problem in the cal setup. let me resend | 17:23 |
| fsaad | oh! lemme check that | 17:23 |
| fsaad | pebkac | 17:23 |
| fsaad | ah that's the empty-looking one I had gotten before | 17:24 |
| jimbaker | ok, so strange | 17:24 |
| fsaad | ok now I got it fine | 17:24 |
| fsaad | not sure what was the deal last time but this one worked, thanks jimbaker ! | 17:25 |
| jimbaker | fsaad, cool, glad it worked this time! | 17:26 |
| fsaad | o/ | 17:27 |
| jimbaker | looks i can readily share my entire calendar. but that's not so good... still looking how to do a single ICS export | 17:29 |
| jimbaker | (may require do separately in a better tool than owa outlook) | 17:29 |
| *** VW_ has joined #craton | 17:33 | |
| *** VW has quit IRC | 17:33 | |
| sigmavirus | jimbaker: what do you use? OWA? Outlook? Mail.app? | 17:33 |
| thomasem | Thanks for the suggestions, sigmavirus!! | 17:35 |
| sigmavirus | thomasem: I worked at a consultancy. Used to run our own retros | 17:35 |
| thomasem | Ahh, I see. I'll check these out. I've mainly organically learned the various agile flavors, never done any sort of focused learning on the subject, besides some silly training at my last job which got completely ignored by the rest of the team when in practice. | 17:36 |
| thomasem | So, you did specifically agile consulting, or software, or...? | 17:38 |
| sigmavirus | yes | 17:41 |
| sigmavirus | We were small and each tasked with doing all the things | 17:42 |
| sigmavirus | Agile Consulting - Helping customers with agile (writing stories, planning work, running retros, etc.); Agile Staff Augmentation - Writing code; and other stuff | 17:42 |
| sigmavirus | We were billed off as pairs too, so I ended up spending ~32 hours a week pairing | 17:43 |
| sigmavirus | Sometimes I spent 36-40 hours pairing to help others make up time off | 17:43 |
| * sigmavirus is a chronic over-worker | 17:43 | |
| thomasem | Lol, I see. | 17:44 |
| sigmavirus | I took 1 day of vacation at that job... to interview at Rackspace | 17:47 |
| sigmavirus | Flew in to SATX on a Sunday, flew out the Monday night after the interview. Went to work Tuesday | 17:47 |
| thomasem | Wow | 17:48 |
| thomasem | I was about to ask... did you often run into teams pretty resistant to changing as a result of your consulting? | 17:48 |
| sigmavirus | So I only worked there for a year, and for 90% of that time was on the same client. That client existed before I got there, but was already pretty receptive to agile and constructive feedback on improving their process | 17:51 |
| sigmavirus | Other people worked on other clients, and one was really bad about it | 17:52 |
| thomasem | That's good. I guess when they bring someone in they recognize their need to change. | 17:52 |
| thomasem | At least one would hope | 17:52 |
| sigmavirus | That said, we were doing completely new application development for them, they had no engineers and just wanted an app at the end. Didn't care about properly prioritizing features and getting an MVP out or anything reasonable | 17:52 |
| thomasem | Ohhhhhhhh | 17:52 |
| sigmavirus | Yeah. The problem, though, is that we hired some people who only ever wanted to write some code and not do the hard work | 17:53 |
| sigmavirus | So after I left for Rackspace, some of those people took over that client relationship and it fell apart | 17:53 |
| sigmavirus | But also, after I left for Rackspace, the consultancy lost 11 people in the course of 6 months | 17:53 |
| thomasem | Lol, damn. Sounds like it imploded. | 17:55 |
| sigmavirus | Yeah, it was in need of hiring some consultants of its own ironically | 17:56 |
| thomasem | Hahaha | 17:56 |
| jimbaker | sigmavirus, i use OWA | 17:59 |
| jimbaker | it seems to work just fine, other than occasional sync issues with fsaad; or not being able to publish ICS for specific events (or maybe my inadequate knowledge...) | 18:01 |
| sigmavirus | yeah Idk how to do it with owa | 18:01 |
| *** klindgren has quit IRC | 18:10 | |
| anonymike | how and when are updates to the read the docs site triggered? | 18:48 |
| sigmavirus | anonymike: I don't think they're triggered any longer as that was configured back when we were using github | 18:58 |
| sigmavirus | We need to publish our docs via openstack-infra but I've forgotten how that works | 18:58 |
| anonymike | Most of the changes I proposed were already addressed in the code but not on the doc site :( :( | 19:00 |
| anonymike | Should have read through that first | 19:00 |
| fsaad | boo | 19:03 |
| * sigmavirus runs errand | 19:09 | |
| openstackgerrit | Michael Porras proposed openstack/craton master: Documentation update for pymysql https://review.openstack.org/448248 | 19:26 |
| anonymike | pretty insignificant :/ but just making sure everything is setup correctly ^ | 19:27 |
| thomasem | good catch, anonymike | 19:48 |
| anonymike | heh thanks, I thought I found a lot more but it was already updated :) | 19:49 |
| anonymike | working on getting stuff setup to try and reveiew | 19:49 |
| jimbaker | so docs should rebuild when published in master against github.com/openstack/craton | 19:52 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 19:53 |
| jimbaker | even better if we use openstack's doc build of course... | 19:54 |
| anonymike | jimbaker: docs definitely differ between openstack/craton master and read the docs | 19:56 |
| thomasem | Good thing I'm doing the functional tests this way, already found a bug when doing var search on networks. | 19:57 |
| anonymike | would you like me to look at openstack doc build jimbaker? | 19:57 |
| jimbaker | anonymike, yeah, i noticed the triggering stopped working. manually rebuilt | 19:57 |
| jimbaker | anonymike, +1 | 19:57 |
| anonymike | cool, I'll dive into that | 19:58 |
| jimbaker | anonymike, ok, should be rebuilt to latest now on http://craton.readthedocs.io/en/latest/index.html | 19:58 |
| jimbaker | and hopefully new support soon against openstack infra | 19:58 |
| anonymike | jimbaker: changes look good | 19:59 |
| thomasem | So, something introduced in the resolved vars search patch broke network var search. | 20:03 |
| thomasem | Wonder if it's something to do with 'descendants'. | 20:04 |
| jimbaker | thomasem, maybe with respect to how descendants are specifically specified by class of resource? | 20:05 |
| jimbaker | i would check that lookup function | 20:06 |
| thomasem | Right | 20:06 |
| thomasem | I shall, thanks! | 20:06 |
| jimbaker | np | 20:06 |
| thomasem | It was missing from the _resource_mapping for the get_desc lookup | 20:13 |
| thomasem | models.Network didn't have an entry there. | 20:14 |
| thomasem | Now it does. :) | 20:14 |
| jimbaker | ahh. maybe it should throw a good exception if not registered... | 20:14 |
| thomasem | Annnnd it works. | 20:14 |
| jimbaker | nice. well at least the abstraction holds! | 20:15 |
| jimbaker | just modestly leaky, due to lack of reg enforcement | 20:15 |
| thomasem | Lol, yep | 20:16 |
| thomasem | Would be interested in thoughts on my approach for consistently testing nested var search across all resources: https://review.openstack.org/#/c/443941/12/craton/tests/functional/test_jsonpath_search.py | 20:16 |
| thomasem | And Gerrit's like molasses again. :( | 20:17 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 20:17 |
| jimbaker | thomasem, will take a look | 20:19 |
| jimbaker | +1 | 20:19 |
| jimbaker | seems like a decent abstraction to what would be otherwise annoying repetition | 20:20 |
| jimbaker | thomasem, i think the only thing i sometimes do here in this case | 20:20 |
| jimbaker | is to add something to generate specific level keys | 20:21 |
| jimbaker | so in this case it might be "bumbleywump-C1" for cloud, or something like that | 20:21 |
| jimbaker | just so we get descendant testing as well in | 20:22 |
| thomasem | jimbaker: aha, yeah. So, I was thinking this would help us test the data type handling (json approximation) and unresolved searching for all resources in a uniform fashion, then I was going to set up some separate tests to build a whole cloud and assert things at different layers of it, making sure resolved search works with this. | 20:23 |
| thomasem | To keep the abstraction simple here. | 20:23 |
| jimbaker | yep. works for me | 20:24 |
| thomasem | excellent! | 20:24 |
| jimbaker | one slice at a time sounds good | 20:24 |
| thomasem | That is good feedback and I totally agree we need to address it both ways. | 20:24 |
| jimbaker | agreed. i think the approach you suggest is the best one. the data types being checked are a separable code path from the descendant aspect (as is the conjunction aspect) | 20:26 |
| jimbaker | so three slices, three types of tests | 20:27 |
| jimbaker | Morpheus: ... When I see three objectives, three captains, three ships. I do not see coincidence, I see providence. I see purpose. ... | 20:28 |
| thomasem | jimbaker: yep. Although, I can do a bit of the conjunctive testing in this abstraction. :P | 20:28 |
| thomasem | Hahaha | 20:28 |
| thomasem | https://bugs.launchpad.net/craton/+bug/1674815 | 20:36 |
| openstack | Launchpad bug 1674815 in craton "Network create does not return variables in response" [Undecided,New] | 20:36 |
| jimbaker | git-harry, sigmavirus, sulo - http://lists.openstack.org/pipermail/openstack-dev/2017-March/114425.html - nomination of thomasem for craton core | 20:43 |
| jimbaker | which is very much well earned! | 20:43 |
| thomasem | jimbaker: Thanks!! :) | 20:46 |
| fsaad | ~. | 20:46 |
| fsaad | just experienced how annoying the internal network can get if you're trying to contribute upstream | 20:47 |
| *** klindgren has joined #craton | 20:48 | |
| thomasem | lol what happened fsaad? | 20:48 |
| fsaad | was just playing around with gerrit the firewall bounced me back on my seat as I was taking a stab at a review | 20:50 |
| fsaad | since port closed. | 20:50 |
| thomasem | Wow | 20:52 |
| thomasem | Hmmmm, I haven't had that problem? Wonder if it's an LDAP group you need to be in or something? | 20:52 |
| jimbaker | this is why i do all substantive comments in another editor | 20:52 |
| jimbaker | then paste into gerrit | 20:52 |
| jimbaker | but even outside vpn, it can be problematic and lose stuff | 20:52 |
| jimbaker | because... | 20:52 |
| fsaad | thomasem: are you on vpn? | 20:53 |
| fsaad | maybe I'm doing things wrong, but I was following https://docs.openstack.org/infra/manual/developers.html#working-on-bugs | 20:53 |
| fsaad | and git review -s tried to connect to the site on a port that wasn't 80 or 443 | 20:55 |
| thomasem | fsaad: I'm not, but I've done that before on VPN. Lemme give it a go here in a bit. | 20:55 |
| fsaad | don't worry I'll poke around, it's good exercise thanks thomasem | 20:56 |
| thomasem | Sounds good, fsaad! | 20:56 |
| fsaad | ah it was pretty basic, my ssh key had too open permissions... I'm playing with this in a container so was manually setting stuff up. Thanks thomasem ! | 21:04 |
| fsaad | also I'm now surprised port 29418 is open, but i imagine it's only towards certain ip's. | 21:05 |
| jimbaker | thomasem, also check for user variables as well | 21:05 |
| jimbaker | in search | 21:05 |
| jimbaker | if you haven't done so | 21:05 |
| jimbaker | just going through an ancestor patch however | 21:05 |
| jimbaker | although it looks like user variables are still undersupported in general. hmmm. i guess we can address in a separate pass | 21:07 |
| jimbaker | (probably an outstanding bug..) | 21:07 |
| thomasem | Yeah, we need to shore that up. | 21:12 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Return variables in response on Network create https://review.openstack.org/448285 | 21:22 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 21:23 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Move to MySQL 5.7 and SQLAlchemy>=1.1.0 https://review.openstack.org/443186 | 21:23 |
| openstackgerrit | Merged openstack/craton master: Remove log translations https://review.openstack.org/447833 | 21:24 |
| thomasem | jimbaker: I based my patches on https://review.openstack.org/448285 | 21:29 |
| thomasem | FYI | 21:29 |
| jimbaker | thomasem, ack | 21:30 |
| thomasem | Since it was a small fix that makes network creates consistent and allows my functional tests to work. :) | 21:30 |
| jimbaker | ok, will look at that parent so we can get everything else in | 21:30 |
| thomasem | Awesome | 21:30 |
| jimbaker | thomasem, also this is the sort of trivial that i would love to describe as not needing independent core reviews | 21:30 |
| thomasem | I'm inclined to agree. On my last project we basically gave some rope for trivial changes like this. At least while we weren't stable and in production. :) | 21:31 |
| jimbaker | so i'm going to my core discretion here... | 21:31 |
| jimbaker | cool | 21:31 |
| thomasem | It's the same pattern as everywhere else and the test proves it. | 21:32 |
| jimbaker | indeed | 21:32 |
| jimbaker | ok, +2'ed and workflowed | 21:32 |
| thomasem | Thanks! | 21:33 |
| jimbaker | np! brb | 21:33 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 21:36 |
| openstackgerrit | Merged openstack/craton master: Return variables in response on Network create https://review.openstack.org/448285 | 21:41 |
| openstackgerrit | Merged openstack/craton master: Move to MySQL 5.7 and SQLAlchemy>=1.1.0 https://review.openstack.org/443186 | 21:41 |
| thomasem | Awww yiss | 21:45 |
| thomasem | Alright. I've partied pretty hard today; time to run. Have a lovely evening/day! | 21:50 |
| anonymike | later thomasem! | 21:51 |
| jimbaker | sigmavirus, can you give me more context on your -1 on git-harry's patch - https://review.openstack.org/#/c/447580/3 ? | 21:58 |
| jimbaker | eg, is this with respect to https://review.openstack.org/#/c/447580/3/craton/api/v1/schemas.py ? (which seems to be removing lots of duped code, so LGTM, at the cost of some possible reflection possibilities for docs) | 22:02 |
| *** klindgren has quit IRC | 22:22 | |
| *** pwnall138 is now known as zz_pwnall138 | 22:26 | |
| *** VW has joined #craton | 22:59 | |
| *** VW_ has quit IRC | 23:01 | |
| *** VW has quit IRC | 23:03 | |
| *** harlowja has quit IRC | 23:06 | |
| *** cloudkiller has joined #craton | 23:49 | |
| *** cloudnull has quit IRC | 23:50 | |
| *** d34dh0r53 has quit IRC | 23:50 | |
| *** cloudkiller is now known as cloudnull | 23:50 | |
| *** _d34dh0r53_ has joined #craton | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!