| *** VW has joined #craton | 00:15 | |
| *** VW has quit IRC | 00:18 | |
| *** VW has joined #craton | 00:18 | |
| *** VW has quit IRC | 03:13 | |
| *** jimbaker` has joined #craton | 05:39 | |
| *** jimbaker has quit IRC | 05:39 | |
| sulo | thomasem: jimbaker`: anonymike: ping as soon as you get online please | 11:58 |
|---|---|---|
| thomasem | sulo: what's up? | 13:48 |
| *** wirehead_ has quit IRC | 14:07 | |
| fsaad | 'sup guys | 14:08 |
| *** wirehead_ has joined #craton | 14:09 | |
| thomasem | Hihi | 14:14 |
| fsaad | hi thomasem | 14:21 |
| sulo | hi fsaad | 14:31 |
| thomasem | hi sulo | 14:31 |
| thomasem | hi fsaad | 14:31 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: Add documentation for JSON Path-like variable searching https://review.openstack.org/450861 | 14:33 |
| *** VW has joined #craton | 14:33 | |
| *** VW has quit IRC | 14:34 | |
| *** VW has joined #craton | 14:34 | |
| thomasem | Yeah! Documentation! | 14:36 |
| thomasem | Wooooo | 14:36 |
| sulo | merged | 14:36 |
| thomasem | Lol | 14:36 |
| sulo | :) | 14:37 |
| anonymike | hey sulo :) | 14:47 |
| sulo | anonymike: thomasem: fsaad: git-harry: jimbaker`: lets have a quick catchup meeting when everyone is in ? | 14:49 |
| thomasem | Sure | 14:49 |
| thomasem | hi anonymike | 14:49 |
| git-harry | yep | 14:49 |
| anonymike | how's it going thomasem? | 14:49 |
| fsaad | I'm ready whenever | 14:49 |
| git-harry | I assume we're just waiting on jimbaker? | 14:49 |
| *** fsaad is now known as farid | 14:49 | |
| sulo | git-harry: yeah | 14:50 |
| thomasem | anonymike: It's going alright. Waiting on my big batch of cold brew to finish in... 16 minutes. | 14:50 |
| thomasem | Cold brew coffee, that is. I drink beer, but I don't drink this early folks. | 14:50 |
| farid | think some guy has my nick registered but hardly ever uses it... I'm probably breaking nettiquette but will roll with it for now | 14:50 |
| thomasem | Not even sure you CAN cold brew such a thing. | 14:50 |
| anonymike | thomasem: ohh nice. How do you make it? I got one of those tower drip cold brewers for christmas | 14:51 |
| thomasem | farid: if you register it with NickServ you can keep it. | 14:51 |
| thomasem | anonymike: http://coffeesock.com/coldbrew/diy-coldbrew-kit-gift-pack-1-and-2-gallon | 14:51 |
| anonymike | thomasem: nice! | 14:52 |
| thomasem | I used to use the Toddy method, but this has been the simplest and I still find it to be pretty flavorful. | 14:52 |
| thomasem | tower drip cold brewers... never seen that. | 14:53 |
| thomasem | Iiiiiiiinteresting | 14:53 |
| thomasem | anonymike: like this? https://www.amazon.com/Yama-Glass-Maker-Straight-Black/dp/B004EBUZ1A | 14:53 |
| farid | thomasem: I think someone has it registered is the problem | 14:53 |
| thomasem | farid: :( | 14:53 |
| thomasem | I see | 14:54 |
| thomasem | Well, then, if they don't want someone else using it, perhaps they should use a bouncer. :P | 14:54 |
| anonymike | thomasem: yep, that's almost exactly the one I have | 14:54 |
| thomasem | anonymike: wild. What's the benefit of that over something like what I'm using? | 14:54 |
| * thomasem looks at the price of this thing | 14:54 | |
| thomasem | If nothing else, it looks like some cool laboratory instrument in your kitchen. | 14:55 |
| sulo | y'all use all those things to make coffee ? | 14:55 |
| thomasem | So, it's got some ornamental value. :P | 14:55 |
| thomasem | sulo: yep | 14:56 |
| anonymike | thomasem: yeah I'm not sure there's much of an advantage | 14:56 |
| anonymike | lol | 14:56 |
| sulo | damn, i use nescafe coffee power and just stir it in with watter | 14:56 |
| thomasem | anonymike: Lol, now I'm super curious, though. | 14:56 |
| thomasem | sulo: Hey, if you like it, that's all that matters. | 14:56 |
| thomasem | :P | 14:57 |
| sulo | hehe .. yeah as you can see i am not a big coffee drinker | 14:57 |
| anonymike | I do know that it lets a lot less sediment through the filter though | 14:57 |
| sulo | i do like it though, but not enough to buy such cool looking tools | 14:57 |
| thomasem | I get a gallon batch of concentrate that keeps for 2 weeks in the refrigerator. So, I get to make a bunch and then just mix 50/50 with water for every cup I want. | 14:57 |
| thomasem | anonymike: interesting | 14:57 |
| anonymike | less than some other cold brew kits i've tried** | 14:58 |
| * sulo wonders if tea has such cool tools also | 14:58 | |
| thomasem | Ahhhh, yes. I've had pretty good experience with the coffee sock, but I also make sure I get a proper grind. | 14:58 |
| thomasem | sulo: you can cold brew tea the same way, and it's delicious. | 14:58 |
| thomasem | sulo: http://www.arborteas.com/iced-tea-preparation/ | 14:59 |
| thomasem | I've used my coffee sock for huge batches of loose leaf earl grey, english breakfast, and irish breakfast. | 15:00 |
| sulo | thomasem: yeah i mean i have different kinds of tea .. but is usually just put in the pot with water kinda thing | 15:00 |
| thomasem | All of which turned out pretty ell | 15:00 |
| thomasem | Gotcha | 15:00 |
| sulo | i need to get into some of your style | 15:00 |
| thomasem | I originally went with cold brew stuff because hot coffee tended to upset my stomach (high acidity) | 15:01 |
| thomasem | And... well, I'm in Texas. Let's get real. It gets so fricken hot here. | 15:01 |
| sulo | heh | 15:01 |
| thomasem | Hot coffee when it's 100 degrees outside just doesn't work. :P | 15:01 |
| thomasem | Same with tea | 15:01 |
| thomasem | sulo: what's your favorite tea? | 15:02 |
| * thomasem really wants to try out one of these drip towers. | 15:03 | |
| sulo | thomasem: so i dont know the name of it .. its from my home country Nepal .. afaik its a mix of few different blends | 15:03 |
| thomasem | Interesting | 15:03 |
| sulo | my parent get it from somewhere | 15:03 |
| sulo | and i usually buy thorough them | 15:03 |
| thomasem | Ahhhh | 15:03 |
| anonymike | thomasem: are you in SA or Austin? | 15:04 |
| thomasem | Austin | 15:04 |
| anonymike | same, I'll make you a batch one daylol | 15:04 |
| anonymike | also, have you had the cold brew on tap from cuvee coffee? | 15:05 |
| anonymike | so good | 15:05 |
| thomasem | I have not! I will have to try it. I've had the nitro cold brew on tap in some shop in San Marcos and at Stumptown in Portland. Is it anything like that? | 15:06 |
| thomasem | And thank you! I'd appreciate that. :) | 15:07 |
| thomasem | brb | 15:07 |
| anonymike | oh dang stumptown is probably better | 15:07 |
| anonymike | but cuvee is pretty good | 15:07 |
| *** VW_ has joined #craton | 15:07 | |
| *** VW has quit IRC | 15:10 | |
| *** VW_ has quit IRC | 15:11 | |
| *** VW has joined #craton | 15:11 | |
| *** VW has quit IRC | 15:11 | |
| *** VW has joined #craton | 15:12 | |
| thomasem | Back | 15:15 |
| thomasem | And, you know, actually here where I live. :) | 15:15 |
| thomasem | I'll give it a go. Thanks for the suggestion. Is it nitro cold brew, though? | 15:15 |
| thomasem | And boy did this batch turn out well. | 15:16 |
| anonymike | haha yes it's nitro | 15:17 |
| thomasem | Awesome | 15:17 |
| jimbaker` | sulo, i'm at coffee shop this moment. are we planning to do this over vidyo, or here? | 15:19 |
| *** jimbaker` is now known as jimbaker | 15:20 | |
| *** jimbaker is now known as Guest47227 | 15:21 | |
| *** Guest47227 has quit IRC | 15:21 | |
| *** Guest47227 has joined #craton | 15:21 | |
| *** ChanServ sets mode: +o Guest47227 | 15:21 | |
| *** Guest47227 is now known as jimbaker | 15:21 | |
| git-harry | I think vidyo would make sense | 15:21 |
| jimbaker | ok, it's only moderately noisy here | 15:22 |
| jimbaker | anonymike, git-harry, sulo, thomasem - vidyo in craton room? | 15:28 |
| anonymike | on my way | 15:32 |
| sulo | farid: you wanna join too | 15:32 |
| farid | yep one sec | 15:36 |
| farid | gonna have to drop a meeting I'm on temporarily gimme a min | 15:36 |
| farid | ucraton room ? | 15:38 |
| *** klindgren__ has joined #craton | 15:38 | |
| *** klindgren_ has quit IRC | 15:40 | |
| jimbaker | so just everyone knows, +2 implies workflow given changes | 16:03 |
| jimbaker | thomasem, i will start with your json path, then rebase alembic | 16:04 |
| thomasem | +2 | 16:04 |
| jimbaker | and we will pump that out in the next hour | 16:04 |
| thomasem | ;) | 16:04 |
| openstackgerrit | Merged openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 16:12 |
| openstackgerrit | Merged openstack/craton master: Add documentation for JSON Path-like variable searching https://review.openstack.org/450861 | 16:14 |
| thomasem | Heyyyy, my things merged. | 16:15 |
| jimbaker | awesome stuff! | 16:26 |
| jimbaker | ok rebasing time | 16:26 |
| openstackgerrit | Jim Baker proposed openstack/craton master: Updates Alembic migration to better match SQLAlchemy models https://review.openstack.org/441644 | 16:32 |
| antonym | yay | 16:34 |
| * antonym goes to break stuff | 16:34 | |
| * thomasem holds up drop cloth as if this were a Gallagher show. | 16:35 | |
| antonym | or dexter ;) | 16:37 |
| thomasem | LOL that bad, huh? | 16:37 |
| thomasem | :P | 16:37 |
| antonym | haha | 16:37 |
| anonymike | brb grabbing some lunch | 16:47 |
| thomasem | same | 16:52 |
| *** VW has quit IRC | 17:24 | |
| *** VW has joined #craton | 17:25 | |
| openstackgerrit | Jim Baker proposed openstack/craton master: Updates Alembic migration to better match SQLAlchemy models https://review.openstack.org/441644 | 17:25 |
| *** VW has quit IRC | 17:25 | |
| *** VW has joined #craton | 17:26 | |
| jimbaker | ok, just need to resolve whatever functional testing dependency there is against the current db setup that the alembic changes are modifying | 17:39 |
| jimbaker | will resolve later today | 17:39 |
| jimbaker | it was working great until we merged in the json path stuff. all good! :) | 17:40 |
| thomasem | jimbaker: I'll take a look, too. | 17:40 |
| thomasem | See if a second pair of eyes doesn't help. | 17:40 |
| jimbaker | thomasem, it's pretty simple i think | 17:40 |
| jimbaker | i had added in https://review.openstack.org/#/c/441644/6..7/craton/tests/functional/__init__.py | 17:41 |
| jimbaker | thinking that the dbsync stuff obviated these changes, i blew it away in patch #7 | 17:42 |
| jimbaker | nope, this is *not* the case | 17:42 |
| jimbaker | functional testing does stuff directly against the db to make it run faster. so the constraints in dbsync have to be respected | 17:42 |
| jimbaker | and then whatever was done for json path support | 17:43 |
| jimbaker | i'm sure it's pretty minor. but thomasem if you want to add some eyes here, look at http://logs.openstack.org/44/441644/6/check/gate-craton-tox-functional-ubuntu-xenial/d106ed6/ | 17:43 |
| openstackgerrit | Jim Baker proposed openstack/craton master: Updates Alembic migration to better match SQLAlchemy models https://review.openstack.org/441644 | 17:48 |
| jimbaker | thomasem, ok, this restores it to patch #6, so we should expect to see a few failures | 17:48 |
| jimbaker | thomasem, https://review.openstack.org/#/c/441644/8/craton/tests/functional/__init__.py is where we should start looking i would think | 17:49 |
| jimbaker | anyway, biab, exercise | 17:49 |
| thomasem | I just received a bag of gummy bears. | 17:53 |
| anonymike | yum | 17:55 |
| antonym | thomasem: got the json searching working for my discovery playbook: https://gist.github.com/antonym/ecfc14d5ed0b7f25db5d52a2a324f308 | 17:55 |
| thomasem | antonym: awesome! Run into any snags? | 18:19 |
| *** openstackstatus has joined #craton | 18:43 | |
| *** ChanServ sets mode: +v openstackstatus | 18:43 | |
| *** VW_ has joined #craton | 18:58 | |
| *** VW__ has joined #craton | 19:01 | |
| *** VW_ has quit IRC | 19:01 | |
| *** VW has quit IRC | 19:02 | |
| *** VW__ has quit IRC | 19:11 | |
| *** VW has joined #craton | 19:12 | |
| thomasem | jimbaker: apparently adding that variable key_ index is causing the test_jsonpath_search_bad_json_string_value and test_jsonpath_search_hyphenated_without_quotes tests to fail? | 19:23 |
| thomasem | the validation that's supposed to break those is no longer happening... I wonder if that's because the order of evaluation is changed? | 19:24 |
| thomasem | And MySQL is short-circuiting when the key doesn't exist. | 19:24 |
| thomasem | Instead of actually validating the JSON path. | 19:24 |
| thomasem | Which means users would get inconsistent behavior when the key doesn't exist, which is bad. | 19:24 |
| *** openstackgerrit has quit IRC | 19:33 | |
| antonym | thomasem: not really, the craton part just worked, some of the ansible logic was a bit fun though | 19:41 |
| thomasem | Ahhh, okay. Cool! | 19:41 |
| jimbaker | thomasem, ahh, interesting detail | 19:50 |
| jimbaker | i was wondering about that shortcircuiting, because in principle, it's a good thing to avoid unnecessary work | 19:50 |
| jimbaker | thomasem, i can take a look at that, and see if we get the desired behavior + optimization. but i will remove from this specific migration script | 19:50 |
| jimbaker | remove *from* | 19:50 |
| jimbaker | at least we have some tests that can verify we are in good shape | 19:51 |
| jimbaker | when a variation of that index is put in, along with the corresponding optimization | 19:51 |
| jimbaker | thanks for the debugging, very helpful! | 19:51 |
| thomasem | Sure thing! | 19:52 |
| anonymike | all that talk of cold brew this morning has me craving it. Brb gonna make a batch | 19:56 |
| *** openstackgerrit has joined #craton | 20:11 | |
| openstackgerrit | Jim Baker proposed openstack/craton master: Updates Alembic migration to better match SQLAlchemy models https://review.openstack.org/441644 | 20:12 |
| jimbaker | thomasem, ^^^ removed that index for key_ on variables | 20:12 |
| jimbaker | works locally on my ubuntu test server, we will shortly see it hopefully pass the gate | 20:12 |
| thomasem | jimbaker: yeah, whoever picks this up will probably want to figure out a good indexing strategy for that whole setup. I don't like how it doesn't properly validate, though I can appreciate the value of short-circuiting, for something that's supposed to be more declarative, it can _really_ trip you up. | 20:35 |
| jimbaker | thomasem, the build passed for https://review.openstack.org/#/c/441644/ - any further thoughts, or ready to +2? | 20:51 |
| jimbaker | i will try to look at indexing/optimization now, given it's low hanging fruit | 20:51 |
| *** VW_ has joined #craton | 21:02 | |
| *** VW has quit IRC | 21:04 | |
| thomasem | jimbaker: +2'ed | 21:28 |
| jimbaker | thomasem, awesome, thanks | 22:03 |
| jimbaker | and +2 implies workflow right now, so took care of that | 22:08 |
| openstackgerrit | Merged openstack/craton master: Updates Alembic migration to better match SQLAlchemy models https://review.openstack.org/441644 | 22:14 |
| *** VW has joined #craton | 22:52 | |
| *** VW_ has quit IRC | 22:56 | |
| *** VW has quit IRC | 22:56 | |
| *** Tamayo has quit IRC | 23:02 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!