| *** openstackgerrit has quit IRC | 00:16 | |
| *** openstackgerrit has joined #dox | 00:17 | |
| *** pcrews has quit IRC | 03:22 | |
| *** studiotate has quit IRC | 04:48 | |
| *** flaper87|afk is now known as flaper87 | 06:08 | |
| chmouel | Shrews: nice! will review | 06:59 |
|---|---|---|
| *** openstackgerrit has quit IRC | 08:48 | |
| *** pcrews has joined #dox | 13:56 | |
| *** openstackgerrit has joined #dox | 14:15 | |
| *** openstackgerrit has quit IRC | 14:40 | |
| *** openstackgerrit has joined #dox | 14:41 | |
| openstackgerrit | A change was merged to stackforge/dox: Simplify Popen.communicate() result parsing https://review.openstack.org/124042 | 15:12 |
| *** studiotate has joined #dox | 15:17 | |
| openstackgerrit | A change was merged to stackforge/dox: Close files after use https://review.openstack.org/124037 | 15:43 |
| Shrews | uh, why is jenkins trying to merge my change when it wasn't approved??? | 15:45 |
| openstackgerrit | David Shrewsbury proposed a change to stackforge/dox: Use base class for config file parsers https://review.openstack.org/123864 | 15:50 |
| Shrews | chmouel: that ^^^ was just a rebase, if you've already started reviewing | 15:51 |
| chmouel | i am redoing that now | 15:52 |
| chmouel | i started but lost the thread :( | 15:52 |
| Shrews | chmouel: i probably could have made it easier by not changing the test stuff so much, but, eh, i was already there :) | 16:06 |
| chmouel | heh | 16:06 |
| chmouel | man i diverged again from the review! | 16:06 |
| Shrews | chmouel: thx | 16:13 |
| * Shrews adds the forgotten +A :) | 16:13 | |
| chmouel | lol | 16:13 |
| Shrews | i plan to push that multi-command support review through soon-ish | 16:14 |
| *** openstackgerrit has quit IRC | 16:33 | |
| *** openstackgerrit has joined #dox | 16:52 | |
| openstackgerrit | A change was merged to stackforge/dox: Use base class for config file parsers https://review.openstack.org/123864 | 17:23 |
| *** openstackgerrit has quit IRC | 17:33 | |
| *** openstackgerrit has joined #dox | 17:39 | |
| *** pcrews has quit IRC | 17:41 | |
| *** pcrews has joined #dox | 17:42 | |
| *** pcrews has quit IRC | 18:32 | |
| *** pcrews has joined #dox | 19:12 | |
| Shrews | flaper87: there's a bug with your multiple image handling | 19:20 |
| Shrews | if a Doxfile exists, default_images is empty, and then Runner.run() never gets called | 19:20 |
| *** studiotate has quit IRC | 19:22 | |
| Shrews | flaper87: https://bugs.launchpad.net/dox/+bug/1374111 | 19:43 |
| openstackgerrit | David Shrewsbury proposed a change to stackforge/dox: Better support for multiple commands https://review.openstack.org/120562 | 20:00 |
| Shrews | mordred: you should probably look at that ^^^^ change to see if it fits with the workflow you had imagined | 20:01 |
| Shrews | i think it still matches what you originally envisioned | 20:01 |
| mordred | Shrews: woot! | 20:05 |
| * mordred will look | 20:05 | |
| Shrews | ugh. must fix tests | 20:16 |
| Shrews | mordred: so, one thing different. passing extra args does not automatically append to the command if {posargs} is not present. doing so doesn't really make sense in a multiple-command situation | 20:21 |
| Shrews | so not sure how you'd like to see that handled | 20:22 |
| Shrews | we could either: 1. require the use of {posargs} if someone wants to do that, or 2. append if there is only a single command | 20:24 |
| Shrews | 3. other? | 20:24 |
| Shrews | don't really like 2, personally | 20:25 |
| *** pcrews has quit IRC | 20:34 | |
| *** studiotate has joined #dox | 20:44 | |
| *** pcrews has joined #dox | 21:05 | |
| *** flaper87 is now known as flaper87|afk | 22:30 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!