| *** openstack has joined #dox | 12:40 | |
| *** pcrews has joined #dox | 14:48 | |
| *** studiotate has joined #dox | 15:19 | |
| *** cdent has quit IRC | 17:23 | |
| *** studiotate has quit IRC | 18:18 | |
| *** studiotate has joined #dox | 19:45 | |
| *** studiotate has quit IRC | 21:18 | |
| Shrews | mordred: had a chance to consider the implications of https://review.openstack.org/120562 yet? | 21:39 |
|---|---|---|
| mordred | Shrews: nope! let me go look right now ... | 21:43 |
| Shrews | mordred: well, don't have to "right now", but at some point when you have a chance :) | 21:43 |
| mordred | Shrews: your commit message makes sense to me | 21:44 |
| Shrews | mordred: it's the last sentence of that i'm concerned about | 21:44 |
| mordred | the posargs thing? | 21:45 |
| mordred | why don't you like it? | 21:45 |
| mordred | oh - wait | 21:45 |
| mordred | sorry | 21:45 |
| mordred | reading scrollback poorly | 21:45 |
| mordred | yeah - I think you should have to add a posargs | 21:45 |
| mordred | or - so - what if we ALWAYS made a master_script | 21:45 |
| mordred | even if there's only one command | 21:45 |
| Shrews | what would be the point of that? | 21:46 |
| mordred | and we ALWAYS passed command line args to it | 21:46 |
| mordred | so that instead of {posargs} - your like could say "python setup.py testr -- $*" | 21:46 |
| mordred | and then dox would put that into a script and pass anything to it | 21:46 |
| * mordred just brainstorming out loud - this may be terrible | 21:46 | |
| Shrews | mordred: so, you make confusing words | 21:47 |
| Shrews | so lemme try this... | 21:48 |
| Shrews | {posargs} is only a tox.ini thing at this point | 21:48 |
| * mordred throws confusing words at Shrews | 21:48 | |
| mordred | yah | 21:48 |
| Shrews | this change still supports replacing that | 21:48 |
| Shrews | but what we CAN'T do now is toss extra arguments at the command in a tox.ini... unless it ends with {posargs} | 21:49 |
| Shrews | so we can't do: dox run blah ironic.tests.blah_test | 21:50 |
| Shrews | unless the command is: testr {posargs} | 21:50 |
| Shrews | that's probably a bad example, since i think that is true anyway | 21:50 |
| Shrews | hmm. i actually can't think of a good example | 21:52 |
| mordred | I agree with your "we can't do this" example | 21:54 |
| Shrews | mordred: ok. we can always add it back if we decide "hey, this sucks that we can't do this now" | 21:56 |
| Shrews | it really only changes what is required of tox.ini | 21:56 |
| mordred | ++ | 21:57 |
| Shrews | mordred: thx | 21:57 |
| *** studiotate has joined #dox | 23:17 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!