| *** e0ne has quit IRC | 00:00 | |
| *** e0ne has joined #heat | 00:00 | |
| *** giulivo has quit IRC | 00:00 | |
| *** e0ne has quit IRC | 00:05 | |
| *** IlyaE has quit IRC | 00:07 | |
| *** dmueller_ has joined #heat | 00:10 | |
| *** agileclipse has joined #heat | 00:19 | |
| *** edmund has quit IRC | 00:20 | |
| *** agileclipse has left #heat | 00:22 | |
| *** pvaneck has quit IRC | 00:24 | |
| *** dmueller_ has quit IRC | 00:34 | |
| *** radez_g0n3 is now known as radez | 00:45 | |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Added testr-args option support for tox coverage https://review.openstack.org/67036 | 00:52 |
|---|---|---|
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Refactor heat gate testing contrib support https://review.openstack.org/67783 | 00:52 |
| sdake | sweet when you buy vinyl on amazon, you get a free copy of the mp3 included | 00:56 |
| zaneb | sdake: hard to believe there was a time it didn't work like that :D | 00:58 |
| sdake | ya no doubt | 01:00 |
| *** topol has joined #heat | 01:01 | |
| sdake | nice to have digital copies of the vinyl I'm buying | 01:01 |
| sdake | without having to pay twice | 01:01 |
| *** asalkeld has joined #heat | 01:10 | |
| *** blomquisg has quit IRC | 01:39 | |
| *** kfox1111 has quit IRC | 01:47 | |
| *** blomquisg has joined #heat | 01:54 | |
| *** e0ne has joined #heat | 01:57 | |
| *** nosnos has joined #heat | 01:59 | |
| *** e0ne has quit IRC | 02:02 | |
| *** mkollaro has joined #heat | 02:05 | |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Database model for software config/deployment https://review.openstack.org/58876 | 02:15 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: RPC service for software config/deployment https://review.openstack.org/58877 | 02:15 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: REST API for software config/deployment https://review.openstack.org/66514 | 02:15 |
| *** yogesh has quit IRC | 02:21 | |
| *** mkollaro has quit IRC | 02:27 | |
| *** Linz has quit IRC | 02:42 | |
| *** Linz has joined #heat | 02:43 | |
| *** sdake has quit IRC | 02:49 | |
| *** asalkeld has quit IRC | 02:51 | |
| *** erkules_ has joined #heat | 02:53 | |
| *** kbenton_ has joined #heat | 02:53 | |
| *** erkules has quit IRC | 02:55 | |
| *** e0ne has joined #heat | 02:57 | |
| *** e0ne has quit IRC | 03:02 | |
| *** IlyaE has joined #heat | 03:02 | |
| *** radez is now known as radez_g0n3 | 03:06 | |
| *** ramishra has joined #heat | 03:06 | |
| *** Linz has quit IRC | 03:08 | |
| *** ramishra_ has joined #heat | 03:08 | |
| *** Linz has joined #heat | 03:11 | |
| *** ramishra has quit IRC | 03:11 | |
| *** blomquisg has quit IRC | 03:30 | |
| *** blomquisg has joined #heat | 03:44 | |
| *** asalkeld has joined #heat | 03:45 | |
| openstackgerrit | Feng Ju proposed a change to openstack/heat: Update python-neutronclient dependency to 2.3.2,<3 https://review.openstack.org/68017 | 03:46 |
| openstackgerrit | Feng Ju proposed a change to openstack/heat: Update python-neutronclient dependency to >=2.3.2,<3 https://review.openstack.org/68017 | 03:49 |
| *** asalkeld has quit IRC | 03:52 | |
| *** e0ne has joined #heat | 03:57 | |
| *** e0ne has quit IRC | 04:02 | |
| *** asalkeld has joined #heat | 04:05 | |
| SpamapS | hrm... | 04:25 |
| SpamapS | has anybody had problems with heat-api-cfn not auth'ing properly with latest "everything" ? | 04:25 |
| SpamapS | 2014-01-21 04:24:24.179 12222 WARNING keystone.common.wsgi [-] Authorization failed. The request you have made requires authentication. from 127.0.0.1 | 04:25 |
| SpamapS | I'm getting that when I do cfn reqs | 04:25 |
| SpamapS | (specifically with an in-instance user created in the template itself) | 04:25 |
| *** yogesh_ has joined #heat | 04:27 | |
| *** yogesh has joined #heat | 04:30 | |
| SpamapS | 2014-01-21 04:29:49.687 12370 WARNING keystone.common.wsgi [-] Authorization failed. User not valid for tenant. from 127.0.0.1 | 04:32 |
| SpamapS | hmmmmm | 04:32 |
| *** yogesh_ has quit IRC | 04:34 | |
| *** ramishra_ has quit IRC | 04:40 | |
| asalkeld | brb | 04:45 |
| *** asalkeld has quit IRC | 04:45 | |
| *** nkhare has joined #heat | 04:45 | |
| SpamapS | hm.. no roles for the user | 04:46 |
| *** ramishra has joined #heat | 04:55 | |
| *** rcleere has joined #heat | 04:57 | |
| *** e0ne has joined #heat | 04:57 | |
| *** e0ne has quit IRC | 05:01 | |
| *** IlyaE has quit IRC | 05:04 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 05:06 | |
| *** chandankumar_ has joined #heat | 05:14 | |
| *** cmyster has joined #heat | 05:16 | |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: A cloud-config resource based on SoftwareConfig https://review.openstack.org/63214 | 05:18 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: A multipart cloud-init resource based on SoftwareConfig https://review.openstack.org/63215 | 05:18 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Resource type for software configuration https://review.openstack.org/67621 | 05:18 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: A cloud-config resource based on SoftwareConfig https://review.openstack.org/63214 | 05:21 |
| *** asalkeld has joined #heat | 05:22 | |
| *** IlyaE has joined #heat | 05:26 | |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: A cloud-config resource based on SoftwareConfig https://review.openstack.org/63214 | 05:26 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: A multipart cloud-init resource based on SoftwareConfig https://review.openstack.org/63215 | 05:26 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Resource type for software configuration https://review.openstack.org/67621 | 05:26 |
| *** blomquisg has quit IRC | 05:27 | |
| *** Linz has quit IRC | 05:32 | |
| *** IlyaE has quit IRC | 05:32 | |
| *** larsks has quit IRC | 05:35 | |
| *** larsks has joined #heat | 05:35 | |
| *** Linz has joined #heat | 05:36 | |
| *** blomquisg has joined #heat | 05:40 | |
| openstackgerrit | Feng Ju proposed a change to openstack/heat: Update python-keystoneclient dependency to >=0.4.2 https://review.openstack.org/68021 | 05:45 |
| *** aignatov_ has joined #heat | 05:52 | |
| *** e0ne has joined #heat | 05:57 | |
| *** akuznetsov has quit IRC | 05:59 | |
| *** e0ne has quit IRC | 06:02 | |
| openstackgerrit | Zhang Yang proposed a change to openstack/heat: add the validation of MaxSize ,MinSize and DesiredCapacity https://review.openstack.org/67618 | 06:02 |
| *** nkhare has quit IRC | 06:05 | |
| *** nkhare has joined #heat | 06:05 | |
| *** nati_ueno has quit IRC | 06:06 | |
| *** faramir1 has joined #heat | 06:06 | |
| *** tzumainn has quit IRC | 06:07 | |
| *** nkhare has quit IRC | 06:08 | |
| *** nkhare has joined #heat | 06:09 | |
| *** nkhare has quit IRC | 06:11 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 06:12 | |
| *** nkhare has joined #heat | 06:13 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 06:13 | |
| openstackgerrit | Jenkins proposed a change to openstack/heat: Imported Translations from Transifex https://review.openstack.org/64504 | 06:16 |
| *** nkhare has joined #heat | 06:17 | |
| *** nkhare has quit IRC | 06:17 | |
| *** nkhare has joined #heat | 06:18 | |
| *** nati_ueno has joined #heat | 06:22 | |
| *** nati_ueno has quit IRC | 06:23 | |
| *** nati_ueno has joined #heat | 06:24 | |
| *** akuznetsov has joined #heat | 06:26 | |
| *** rongze has joined #heat | 06:26 | |
| *** bvandenh has joined #heat | 06:33 | |
| *** nanjj has joined #heat | 06:34 | |
| *** akuznetsov has quit IRC | 06:37 | |
| *** akuznetsov has joined #heat | 06:37 | |
| *** aignatov_ has quit IRC | 06:38 | |
| *** ramishra has quit IRC | 06:38 | |
| *** faramir1 has quit IRC | 06:39 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 06:42 | |
| *** rcleere has quit IRC | 06:50 | |
| *** topol has quit IRC | 06:54 | |
| *** e0ne has joined #heat | 06:57 | |
| *** e0ne has quit IRC | 07:02 | |
| *** e0ne has joined #heat | 07:04 | |
| *** akuznets_ has joined #heat | 07:05 | |
| *** akuznetsov has quit IRC | 07:08 | |
| skraynev | Hello all | 07:08 |
| skraynev | SpamapS, are you here? | 07:08 |
| *** sgordon` has quit IRC | 07:09 | |
| *** sgordon` has joined #heat | 07:10 | |
| *** nati_uen_ has joined #heat | 07:12 | |
| *** nati_uen_ has quit IRC | 07:13 | |
| *** nati_uen_ has joined #heat | 07:14 | |
| *** aignatov_ has joined #heat | 07:14 | |
| *** nati_ueno has quit IRC | 07:16 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 07:29 | |
| *** IlyaE has joined #heat | 07:30 | |
| shardy | morning | 07:34 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Ignore tox -e cover generated files https://review.openstack.org/67030 | 07:34 |
| shardy | Sigh. Gate still very broken :( | 07:39 |
| *** ifarkas has joined #heat | 07:41 | |
| *** jprovazn has joined #heat | 07:52 | |
| *** cmyster_ has joined #heat | 07:54 | |
| *** sdake has joined #heat | 07:58 | |
| *** cmyster has quit IRC | 07:58 | |
| *** aignatov_ has quit IRC | 08:01 | |
| *** nati_ueno has joined #heat | 08:02 | |
| *** nati_ueno has quit IRC | 08:02 | |
| *** nati_ueno has joined #heat | 08:03 | |
| *** erkules_ is now known as erkules | 08:04 | |
| *** asalkeld has quit IRC | 08:05 | |
| *** nati_uen_ has quit IRC | 08:05 | |
| openstackgerrit | Feng Ju proposed a change to openstack/heat: Update python-neutronclient dependency to >=2.3.3,<3 https://review.openstack.org/68017 | 08:07 |
| *** e0ne has quit IRC | 08:09 | |
| *** IlyaE has quit IRC | 08:10 | |
| *** _ruhe is now known as ruhe | 08:11 | |
| *** jistr has joined #heat | 08:14 | |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Refactor heat gate testing contrib support https://review.openstack.org/67783 | 08:20 |
| openstackgerrit | Jun Jie Nan proposed a change to openstack/heat: Added testr-args option support for tox coverage https://review.openstack.org/67036 | 08:21 |
| *** cmyster_ has quit IRC | 08:22 | |
| *** cmyster has joined #heat | 08:22 | |
| *** cmyster has quit IRC | 08:22 | |
| *** cmyster has joined #heat | 08:22 | |
| *** nanjj has quit IRC | 08:32 | |
| openstackgerrit | A change was merged to openstack/heat: Use oslo crypto https://review.openstack.org/59685 | 08:36 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 08:37 | |
| *** tsmadds has joined #heat | 08:38 | |
| therve | 'morning | 08:39 |
| *** alexheneveld has joined #heat | 08:39 | |
| *** alexheneveld has joined #heat | 08:40 | |
| *** mkollaro has joined #heat | 08:41 | |
| *** nati_uen_ has joined #heat | 08:51 | |
| *** tspatzier has joined #heat | 08:51 | |
| *** aignatov_ has joined #heat | 08:51 | |
| *** nati_ueno has quit IRC | 08:55 | |
| *** nati_uen_ has quit IRC | 08:56 | |
| *** nati_ueno has joined #heat | 08:57 | |
| *** tspatzier has quit IRC | 08:58 | |
| *** derekh has joined #heat | 09:00 | |
| pshchelo | morning all :) | 09:03 |
| *** aignatov_ has left #heat | 09:03 | |
| *** nkhare has quit IRC | 09:04 | |
| *** giulivo has joined #heat | 09:05 | |
| *** aignatov has joined #heat | 09:08 | |
| *** tomek_adamczewsk has joined #heat | 09:15 | |
| *** nkhare has joined #heat | 09:21 | |
| *** nanjj has joined #heat | 09:29 | |
| *** nanjj has quit IRC | 09:32 | |
| *** tomek_adamczewsk has quit IRC | 09:33 | |
| *** tspatzier has joined #heat | 09:50 | |
| *** nati_uen_ has joined #heat | 09:50 | |
| *** e0ne has joined #heat | 09:53 | |
| *** nati_ueno has quit IRC | 09:54 | |
| *** nkhare has quit IRC | 09:55 | |
| *** nati_uen_ has quit IRC | 09:57 | |
| *** nati_ueno has joined #heat | 09:58 | |
| *** nkhare has joined #heat | 10:07 | |
| *** sileht has quit IRC | 10:11 | |
| *** sileht has joined #heat | 10:21 | |
| *** tomek_adamczewsk has joined #heat | 10:26 | |
| *** aignatov is now known as aignatov_ | 10:29 | |
| openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Update olso gettextutils https://review.openstack.org/67758 | 10:37 |
| openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Update oslo db https://review.openstack.org/67759 | 10:37 |
| openstackgerrit | Angus Salkeld proposed a change to openstack/heat: Update oslo modules https://review.openstack.org/67757 | 10:37 |
| *** asalkeld has joined #heat | 10:38 | |
| *** ruhe is now known as _ruhe | 10:39 | |
| *** tspatzier has quit IRC | 10:40 | |
| *** IgorYozhikov has quit IRC | 10:44 | |
| *** IgorYozhikov has joined #heat | 10:44 | |
| *** nati_uen_ has joined #heat | 10:46 | |
| *** ramishra has joined #heat | 10:49 | |
| *** nati_ueno has quit IRC | 10:49 | |
| *** rongze has quit IRC | 10:51 | |
| *** _ruhe is now known as ruhe | 10:54 | |
| *** yogesh has quit IRC | 10:54 | |
| *** tomek_adamczewsk has quit IRC | 10:56 | |
| pshchelo | need advise on the next question: I have an approved blueprint https://blueprints.launchpad.net/heat/+spec/reduce-flake8-ignored-rules assigned to me | 10:58 |
| pshchelo | I've removed on style check (order of imports) and modified the code accordingly | 10:58 |
| pshchelo | these changes naturally affect *many* files, 161 to be precise | 10:59 |
| pshchelo | does it make sense to split such huge patch? | 10:59 |
| therve | H201 is not meaningful | 11:00 |
| therve | I don't like h302 | 11:00 |
| pshchelo | on the second thought, I will not be able to split it, as it will fail in the presence of non-modified files | 11:00 |
| therve | Of course you can split | 11:00 |
| pshchelo | therve, I don't like it either | 11:01 |
| openstackgerrit | Thomas Herve proposed a change to openstack/heat: Don't pass empty security groups in port creation https://review.openstack.org/68073 | 11:01 |
| *** aignatov_ is now known as aignatov | 11:01 | |
| pshchelo | but H306 (that one I have a patch for) looks harmless | 11:02 |
| pshchelo | and h201 looks quite reasonable as well, just needs very careful testing | 11:02 |
| therve | No it's not | 11:02 |
| therve | except Exception: is not the same as except: | 11:02 |
| therve | There is a reason we do except: in some places | 11:03 |
| pshchelo | I know, BaseException, used in system calls and eventlet | 11:03 |
| pshchelo | s/calls/exceptions | 11:03 |
| pshchelo | that's why careful testing :) | 11:03 |
| *** tomek_adamczewsk has joined #heat | 11:04 | |
| *** tspatzier has joined #heat | 11:04 | |
| therve | I don't understand why careful testing matters. It's just logically useful that we use except: | 11:05 |
| *** mkollaro has quit IRC | 11:05 | |
| pshchelo | I mean to decide which occurrences can be used with Exception and which really mean BaseException | 11:07 |
| therve | But you'll still have to keep the pep8 exception | 11:08 |
| therve | shardy, If you could look at https://review.openstack.org/#/c/62730/ that'd be cool | 11:09 |
| pshchelo | therve, no, hacking only checks for presence of bare ``except:`` line | 11:10 |
| *** e0ne has quit IRC | 11:15 | |
| *** e0ne has joined #heat | 11:15 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 11:15 | |
| *** bvandenh has quit IRC | 11:18 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 11:19 | |
| *** mkollaro has joined #heat | 11:21 | |
| *** rongze has joined #heat | 11:22 | |
| *** tomek_adamczewsk has quit IRC | 11:24 | |
| *** rongze has quit IRC | 11:27 | |
| *** rongze has joined #heat | 11:35 | |
| *** rongze has quit IRC | 11:41 | |
| *** nkhare has quit IRC | 12:00 | |
| *** topol has joined #heat | 12:00 | |
| *** blomquisg has quit IRC | 12:02 | |
| *** yogesh has joined #heat | 12:05 | |
| *** ruhe is now known as _ruhe | 12:05 | |
| *** yogesh has quit IRC | 12:10 | |
| *** _ruhe is now known as ruhe | 12:11 | |
| *** nkhare has joined #heat | 12:12 | |
| *** bvandenh has joined #heat | 12:18 | |
| alienyyg | hi guys, I found something with the IHA, in my case , an instance runs on a compute node, then when I shut down the instance ,the IHA works perfect , then I poweroff the compute node, heat miss the heartbeat and then try to delete the instance ,but it keep deleting ,and ofcourse no new instance is launched | 12:19 |
| alienyyg | so is this a bug? | 12:20 |
| *** agileclipse has joined #heat | 12:23 | |
| alienyyg | I also try to launch a instance , then poweroff the compute node it runs on , then I try to delete the instance with dashboard,the first time I try to delete the isntance , the status is keep deleting like what I meet in IHA, but then I try to delete the instance ,I do it ,seems the data about the instance iin keystone is deleted,so shoud heat try to delete the instance twice when the compute node i s down? maybe this can make the IHA work | 12:23 |
| alienyyg | with IHA ,I delete the instance manually ,then heat create a new instance for me,so this what I meet with IHA | 12:27 |
| therve | What's IHA? | 12:32 |
| therve | HARestarter? | 12:32 |
| *** nkhare has quit IRC | 12:34 | |
| *** rpothier_ has quit IRC | 12:34 | |
| *** rongze has joined #heat | 12:35 | |
| *** rongze has quit IRC | 12:41 | |
| *** ramishra has quit IRC | 12:46 | |
| *** nkhare has joined #heat | 12:47 | |
| *** asalkeld has quit IRC | 12:51 | |
| *** sgordon_ has joined #heat | 12:52 | |
| shardy | therve: yep, it's an example template demonstrating using a heartbeat alarm and HARestarter | 12:52 |
| alienyyg | therve Instance high avibility | 12:52 |
| shardy | alienyyg: tbh, I'm not really sure HARestarter is expected to deal with part of your openstack infrastructure dissappearing | 12:52 |
| shardy | The idea was to rebuild an instance if the application or OS crashes, not to work around catastropic failure of your cloud | 12:53 |
| alienyyg | shardy: but to user, the don't mind what pysical machine we use , the only mind there application and instance keep running, but the infrustructure dissappearing can cause the instance not that available, so maybe it is needed? | 12:58 |
| shardy | alienyyg: Maybe, or maybe the cloud itself should be deployed in a highly available topology | 12:59 |
| shardy | alienyyg: The problem is, when you cause the delete to fail, the stack goes into a failed state, so I'm not sure how we can recover without losing track of the instance we failed to delete (leaking an instance) | 12:59 |
| shardy | alienyyg: probably a better solution for your use-case is to use an AutoScalingGroup instead of HA restarter | 13:00 |
| derekh | hi, where debugging a problem on tripleo ATM, it looks like heat users aren't getting the heat_stack_user role | 13:00 |
| shardy | you could have a metric which ensures you always have exactly one instance active in the group | 13:00 |
| shardy | derekh: Is this latest master? | 13:01 |
| *** rlandy has joined #heat | 13:01 | |
| derekh | the users created by heat | 13:01 |
| derekh | shardy: yes | 13:01 |
| derekh | shardy: running this seems to solve the problem | 13:02 |
| derekh | keystone user-role-add --user undercloud-User-ggcjcybrzoai --tenant admin --role | 13:02 |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 13:02 | |
| derekh | shardy: but obviously heat should be doing that | 13:02 |
| *** tspatzier has quit IRC | 13:02 | |
| shardy | derekh: Yeah, I'm in the process of migrating heat to the keystone v3 API so it's possible I broke something: | 13:03 |
| shardy | https://review.openstack.org/#/c/66646/2/heat/common/heat_keystoneclient.py | 13:03 |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 13:03 | |
| *** asalkeld has joined #heat | 13:03 | |
| shardy | derekh: Do you see any backtrace, and/or the "Adding user... to role" message? | 13:03 |
| derekh | shardy: ok, was looking at the same commit | 13:04 |
| shardy | derekh: In the engine.log | 13:04 |
| *** asalkeld has quit IRC | 13:04 | |
| derekh | Jan 21 10:24:07 localhost heat-engine[3111]: 2014-01-21 10:24:07.427 3111 ERROR heat.common.keystoneclient [-] Failed to add user undercloud-User-ggcjcybrzoai to role heat_stack_user, check role exists! | 13:04 |
| derekh | | b3372896f4cd4170988ce978478a9280 | heat_stack_user | | 13:05 |
| *** mkollaro has quit IRC | 13:05 | |
| shardy | derekh: Is it possible for you to put a line of debug in there to also log the tenant_id? | 13:05 |
| shardy | derekh: I'm wondering if that is not set in your environment for some reason | 13:05 |
| *** _jmp_ has joined #heat | 13:06 | |
| shardy | actually, wait, you're not getting that far.. | 13:06 |
| shardy | derekh: Give me 5mins, I'll re-test | 13:06 |
| *** tspatzier has joined #heat | 13:07 | |
| derekh | shardy: I'm thinking it also may be possible that heat might be attempting this before wee create the role in keystone, I'll verify but will take a few minutes to rerun | 13:07 |
| shardy | derekh: Ah, that would explain it ;) | 13:08 |
| shardy | derekh: I'll re-test anyway as this was definitely working before I posted the patch (in my environment anyway..) | 13:08 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 13:09 | |
| derekh | shardy: ok, cool | 13:09 |
| *** blomquisg has joined #heat | 13:10 | |
| *** giulivo has quit IRC | 13:12 | |
| *** giulivo has joined #heat | 13:12 | |
| *** pafuent has joined #heat | 13:12 | |
| *** mkollaro has joined #heat | 13:15 | |
| alienyyg | shardy: you mean assocaite a AWS::CloudWatch::Alarm(heartbeat) to launchconfig, if the heartbeat fails, then trigger the scalup policy? | 13:17 |
| shardy | alienyyg: yes | 13:17 |
| alienyyg | shardy: OK ,thanks for your idear, I will do this tomarrow, good night :) | 13:18 |
| alienyyg | shardy: maybe a little early for you | 13:18 |
| derekh | 2 | 13:20 |
| *** rpothier has joined #heat | 13:22 | |
| openstackgerrit | Zhang Yang proposed a change to openstack/heat: add the validation of MaxSize ,MinSize and DesiredCapacity https://review.openstack.org/67618 | 13:22 |
| derekh | shardy: the role is created about 2 minutes before the error message so thats that theory gone | 13:22 |
| *** e0ne_ has joined #heat | 13:27 | |
| *** e0ne has quit IRC | 13:28 | |
| *** Linz has quit IRC | 13:29 | |
| *** nosnos has quit IRC | 13:30 | |
| *** Linz has joined #heat | 13:30 | |
| openstackgerrit | Thomas Spatzier proposed a change to openstack/heat: Enable better sub-classing of common Schema class https://review.openstack.org/65688 | 13:30 |
| openstackgerrit | Thomas Spatzier proposed a change to openstack/heat: Refactor Parameters Schema based on common Schema https://review.openstack.org/67183 | 13:30 |
| openstackgerrit | Thomas Spatzier proposed a change to openstack/heat: Move param format for template-validate to API https://review.openstack.org/67171 | 13:30 |
| *** jdob has joined #heat | 13:31 | |
| *** nosnos has joined #heat | 13:31 | |
| *** rongze has joined #heat | 13:35 | |
| *** nosnos has quit IRC | 13:38 | |
| shardy | derekh: Hmm. I can't reproduce: http://paste.openstack.org/show/61622/ | 13:39 |
| shardy | derekh: That's @ 7406a334863035108d50fbf15549824a1a57e138 | 13:39 |
| openstackgerrit | Thomas Spatzier proposed a change to openstack/heat: Refactor Parameters Schema based on common Schema https://review.openstack.org/67183 | 13:39 |
| *** rongze has quit IRC | 13:40 | |
| shardy | derekh: I'm not running bleeding edge keystone atm though, are you running latest everything? | 13:40 |
| derekh | shardy: yup, master of everything, I'll keep digging | 13:40 |
| shardy | derekh: cool, praps you can try that minimal template from my paste and see if it works | 13:41 |
| derekh | shardy: will do | 13:41 |
| *** ruhe is now known as _ruhe | 13:42 | |
| *** ramishra has joined #heat | 13:43 | |
| *** _ruhe is now known as ruhe | 13:45 | |
| *** ramishra has quit IRC | 13:45 | |
| *** ramishra has joined #heat | 13:46 | |
| *** ramishra_ has joined #heat | 13:47 | |
| *** mkollaro1 has joined #heat | 13:49 | |
| *** mkollaro has quit IRC | 13:49 | |
| *** ramishra has quit IRC | 13:51 | |
| *** cmyster has quit IRC | 13:54 | |
| *** rcleere has joined #heat | 13:59 | |
| *** ramishra_ has quit IRC | 13:59 | |
| *** tzumainn has joined #heat | 14:01 | |
| *** dims has quit IRC | 14:06 | |
| *** jdob_ has joined #heat | 14:08 | |
| *** nkhare has quit IRC | 14:10 | |
| *** jrist has joined #heat | 14:11 | |
| *** jrist has quit IRC | 14:12 | |
| *** jrist has joined #heat | 14:15 | |
| *** jrist has quit IRC | 14:17 | |
| *** jrist has joined #heat | 14:18 | |
| *** bvandenh has quit IRC | 14:18 | |
| *** dims has joined #heat | 14:19 | |
| *** e0ne has joined #heat | 14:24 | |
| openstackgerrit | Liang Chen proposed a change to openstack/heat: Marconi message queue resource implementation https://review.openstack.org/61036 | 14:26 |
| *** e0ne_ has quit IRC | 14:27 | |
| *** vijendar has joined #heat | 14:27 | |
| *** jcru has joined #heat | 14:30 | |
| *** jdob_ has quit IRC | 14:34 | |
| *** arbylee has joined #heat | 14:35 | |
| *** rongze has joined #heat | 14:35 | |
| *** rongze has quit IRC | 14:39 | |
| *** giulivo has quit IRC | 14:40 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 14:42 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 14:43 | |
| *** achampio1 has joined #heat | 14:44 | |
| *** aignatov is now known as aignatov_ | 14:45 | |
| *** gokrokve has joined #heat | 14:46 | |
| *** giulivo has joined #heat | 14:47 | |
| *** achampion has quit IRC | 14:47 | |
| *** bvandenh has joined #heat | 14:47 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 14:50 | |
| *** achampion has joined #heat | 14:52 | |
| *** aignatov_ is now known as aignatov | 14:52 | |
| *** pasquier-s has quit IRC | 14:52 | |
| *** pasquier-s has joined #heat | 14:53 | |
| *** achampio1 has quit IRC | 14:53 | |
| *** IlyaE has joined #heat | 14:57 | |
| *** spzala has joined #heat | 15:03 | |
| openstackgerrit | Steven Hardy proposed a change to openstack/heat: Fix adding heat_stack_user role via v3 API https://review.openstack.org/68135 | 15:03 |
| *** chmouel has quit IRC | 15:05 | |
| *** chmouel_ has joined #heat | 15:05 | |
| *** chmouel_ is now known as chmouel | 15:06 | |
| *** rongze has joined #heat | 15:12 | |
| pscheie | So, I'm playing with OS:;Nova:Server and the 'name' property as shown here: http://pastebin.com/3nk6eMcn | 15:15 |
| pscheie | But it doesn't seem to be working. | 15:15 |
| pscheie | The hostname is still coming out dave1-dataapi-ij3eg7ngtlo3 | 15:15 |
| pscheie | That is, heat is still appending a random string on the end of the hostname. | 15:16 |
| pscheie | Is it supposed to do that? | 15:16 |
| *** rcleere has quit IRC | 15:20 | |
| jasond | pscheie: it is https://github.com/openstack/heat/blob/master/heat/engine/resource.py#L581-L583 | 15:25 |
| *** Linz has quit IRC | 15:29 | |
| pscheie | jasond, then what is the point of the 'name' property? | 15:30 |
| jasond | pscheie: to go between the stack name and the random id | 15:31 |
| *** Linz has joined #heat | 15:32 | |
| shardy | pscheie: The idea is to avoid enabling users creating duplicate named resources | 15:32 |
| shardy | pscheie: But IIRC nova does actually allow you to create multiple instances with the same name (in the same project!) I can see the argument that we should just pass the name to nova | 15:33 |
| shardy | I'm not sure that will really result in a manageable deployment though, in situations where you want to control the name but also launch multiple stacks of the same template | 15:34 |
| *** andrew_plunk has joined #heat | 15:35 | |
| jasond | shardy: how would that not be manageable? | 15:36 |
| shardy | jasond: well you'd end up with a bunch of instances with the same name and no easy way to figure out which stack they belong to | 15:37 |
| jasond | shardy: by a human or by heat? | 15:37 |
| shardy | jasond: by a human, obviously it's trivial if you instrospect the resources in the stack as we expose the id | 15:37 |
| *** flwang has joined #heat | 15:38 | |
| radix | morning heaters | 15:39 |
| *** nati_uen_ has quit IRC | 15:40 | |
| *** flwang has left #heat | 15:40 | |
| *** rcleere has joined #heat | 15:41 | |
| jasond | shardy: oh ok. well that seems a little more up for debate. it just depends on how people use heat | 15:41 |
| shardy | jasond: Yeah, arguably folks already have control over the name component of physical resource name via the template resource naming, so we should just pass it straight to nova | 15:43 |
| shardy | I was just trying to explain the rationale for why it is how it is now | 15:43 |
| sdake | morning | 15:45 |
| *** Linz has quit IRC | 15:45 | |
| jasond | shardy: i see. it might also be the case that whoever wrote that wasn't aware that nova allowed duplicate names | 15:45 |
| jasond | i recall someone being surprised that was the case in the ML thread about heat stack names a while back | 15:45 |
| openstackgerrit | Vijendar Komalla proposed a change to openstack/heat: Delete rackspace database resource https://review.openstack.org/68144 | 15:47 |
| *** tims has joined #heat | 15:48 | |
| *** jprovazn has quit IRC | 15:52 | |
| *** tspatzier has quit IRC | 15:54 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 15:57 | |
| *** kebray_ has joined #heat | 15:58 | |
| *** alexheneveld has quit IRC | 15:58 | |
| *** alexpilotti has joined #heat | 16:02 | |
| *** agileclipse has left #heat | 16:07 | |
| *** nati_ueno has joined #heat | 16:08 | |
| *** chandankumar_ has quit IRC | 16:10 | |
| *** sgordon_ has quit IRC | 16:18 | |
| *** topol has quit IRC | 16:19 | |
| zaneb | "Here are the 5 most popular mailing list threads for the past 2 weeks." As measured by... number of messages?! | 16:27 |
| zaneb | why is it that when you put numbers in front of people they suddenly become so *dumb* | 16:27 |
| sdake | zaneb: http://www.google.com/imgres?sa=X&biw=1912&bih=724&tbm=isch&tbnid=yrIZOZNFLO9tIM%3A&imgrefurl=http%3A%2F%2Fbobpage.net%2F2007%2F05%2F17%2Fdilbert-dashboards%2F&docid=UyM57DnaQh0QCM&imgurl=http%3A%2F%2Fbobpage.net%2Fwp-content%2Fuploads%2F2007%2F05%2Fdilbert-dashboard.jpg&w=488&h=168&ei=UKDeUpefC4yDkQeY24DwAg&zoom=1&ved=0CFcQhBwwAQ&iact=rc&dur=3024&page=1&start=0&ndsp=8 | 16:29 |
| zaneb | sdake: nailed it :D | 16:30 |
| sdake | thanks :) | 16:30 |
| *** aignatov is now known as aignatov_ | 16:30 | |
| *** tspatzier has joined #heat | 16:43 | |
| *** arbylee has quit IRC | 16:44 | |
| *** pablosan has joined #heat | 16:47 | |
| *** achampio1 has joined #heat | 16:48 | |
| *** gokrokve has quit IRC | 16:49 | |
| *** gokrokve has joined #heat | 16:49 | |
| *** achampion has quit IRC | 16:50 | |
| *** gokrokve_ has joined #heat | 16:51 | |
| *** topol has joined #heat | 16:51 | |
| *** rlandy is now known as rlandy|bbl | 16:53 | |
| *** gokrokve has quit IRC | 16:54 | |
| *** andersonvom has joined #heat | 16:55 | |
| *** mkollaro1 has quit IRC | 16:55 | |
| *** andersonvom has quit IRC | 16:55 | |
| *** rongze has quit IRC | 16:57 | |
| *** arbylee has joined #heat | 16:57 | |
| *** rongze has joined #heat | 16:57 | |
| *** rongze has quit IRC | 17:02 | |
| *** nati_uen_ has joined #heat | 17:02 | |
| *** nati_uen_ has quit IRC | 17:02 | |
| *** nati_uen_ has joined #heat | 17:03 | |
| *** nati_ueno has quit IRC | 17:03 | |
| *** mkollaro has joined #heat | 17:04 | |
| openstackgerrit | Richard Lee proposed a change to openstack/heat: Add support for generating contrib docs https://review.openstack.org/68171 | 17:05 |
| *** gokrokve_ has quit IRC | 17:08 | |
| *** pafuent1 has joined #heat | 17:08 | |
| *** pafuent has quit IRC | 17:09 | |
| *** shadower has quit IRC | 17:09 | |
| *** lifeless has quit IRC | 17:09 | |
| *** shadower_ has joined #heat | 17:09 | |
| *** achampion has joined #heat | 17:09 | |
| *** lifeless1 has joined #heat | 17:09 | |
| *** skraynev has quit IRC | 17:09 | |
| *** isviridov has quit IRC | 17:09 | |
| *** isviridov has joined #heat | 17:09 | |
| *** skraynev has joined #heat | 17:09 | |
| *** achampio1 has quit IRC | 17:11 | |
| *** jistr has quit IRC | 17:15 | |
| *** e0ne has quit IRC | 17:16 | |
| derekh | shardy: works for me https://review.openstack.org/#/c/68135/ | 17:16 |
| jasond | does anybody know of a difftool that's similar to Gerrit? | 17:16 |
| jasond | so instead of http://dunsmor.com/shots/2014-01-21-105952_1298x989.png it would show https://review.openstack.org/#/c/67971/2/heat/engine/service.py | 17:17 |
| shardy | derekh: Great, thanks, just needs some -core reviews and a couple of weeks to get through the gate now :D | 17:17 |
| sdake | couple weeks lol | 17:17 |
| derekh | :-) | 17:17 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 17:22 | |
| *** pvaneck has joined #heat | 17:23 | |
| *** mkollaro has quit IRC | 17:25 | |
| *** rongze has joined #heat | 17:28 | |
| *** rongze has quit IRC | 17:32 | |
| *** tspatzier has quit IRC | 17:33 | |
| *** tspatzier has joined #heat | 17:33 | |
| *** rongze has joined #heat | 17:35 | |
| *** aweiteka has joined #heat | 17:35 | |
| *** achampio1 has joined #heat | 17:39 | |
| *** achampion has quit IRC | 17:39 | |
| *** rongze has quit IRC | 17:40 | |
| *** cmyster has joined #heat | 17:40 | |
| *** Linz has joined #heat | 17:42 | |
| *** Linz has quit IRC | 17:43 | |
| *** gokrokve has joined #heat | 17:43 | |
| *** gokrokve has quit IRC | 17:43 | |
| *** gokrokve has joined #heat | 17:43 | |
| SpamapS | skraynev: hi, I'm here now in case you still want to chat. :) | 17:44 |
| *** Linz has joined #heat | 17:46 | |
| *** jistr has joined #heat | 17:47 | |
| *** nati_ueno has joined #heat | 17:51 | |
| *** nati_ueno has quit IRC | 17:51 | |
| *** harlowja_away is now known as harlowja | 17:51 | |
| *** nati_ueno has joined #heat | 17:51 | |
| *** arbylee has quit IRC | 17:54 | |
| *** mestery has quit IRC | 17:55 | |
| *** nati_uen_ has quit IRC | 17:55 | |
| *** ruhe is now known as _ruhe | 17:57 | |
| SpamapS | shardy: so glad to wake up to "and yes you're not crazy your stack users aren't getting the proper role" fixes :) | 17:58 |
| *** derekh has quit IRC | 17:58 | |
| *** tspatzier has quit IRC | 18:01 | |
| *** andrew_plunk has quit IRC | 18:07 | |
| *** maxskew has quit IRC | 18:08 | |
| *** tsmadds has quit IRC | 18:14 | |
| SpamapS | core reviewers: this is breaking TripleO badly: https://review.openstack.org/#/c/68135/ please review ASAP | 18:16 |
| *** dims has quit IRC | 18:17 | |
| *** aignatov_ is now known as aignatov | 18:19 | |
| *** radez_g0n3 is now known as radez | 18:23 | |
| *** aignatov is now known as aignatov_ | 18:23 | |
| *** arbylee has joined #heat | 18:24 | |
| *** dims has joined #heat | 18:24 | |
| *** bvandenh has quit IRC | 18:34 | |
| *** nati_uen_ has joined #heat | 18:40 | |
| *** IlyaE has quit IRC | 18:40 | |
| *** nati_ueno has quit IRC | 18:43 | |
| *** yogesh has joined #heat | 18:43 | |
| *** jprovazn has joined #heat | 18:47 | |
| SpamapS | <tap tap> any cores? Anyone? | 18:53 |
| sdake | SpamapS I was going to take a look but looks like zane got to it already | 18:56 |
| SpamapS | ah good | 18:56 |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Fix error in RS Auto Scale properties schema https://review.openstack.org/67913 | 18:58 |
| *** akuznets_ has quit IRC | 18:59 | |
| *** lifeless1 is now known as lifeless | 18:59 | |
| SpamapS | zaneb: btw, it is considered harmful to the gate to +A a change which has not been +1'd by jenkins yet. | 18:59 |
| SpamapS | "wrecking balls" has been a term used | 19:00 |
| *** IlyaE has joined #heat | 19:01 | |
| shardy | SpamapS: Yeah, sorry about that, glad it was an easy fix | 19:01 |
| zaneb | SpamapS: yes, that occurred to me just after I approved it | 19:01 |
| SpamapS | zaneb: jenkins has not started jobs yet so you can un-approve | 19:02 |
| SpamapS | or rather, the gate has not | 19:02 |
| zaneb | SpamapS: I blame you for asking us to review it asap ;) | 19:02 |
| *** shadower_ is now known as shadower | 19:02 | |
| SpamapS | zaneb: I blame my childhood. You can blame it too if you want. :) | 19:02 |
| shardy | SpamapS: serializing the check/gate jobs seems like something which should really be automated | 19:02 |
| *** rlandy|bbl is now known as rlandy | 19:02 | |
| SpamapS | shardy: that is already under discussion | 19:02 |
| *** andrew_plunk has joined #heat | 19:04 | |
| *** spzala has quit IRC | 19:07 | |
| *** mkollaro has joined #heat | 19:08 | |
| *** mkollaro has quit IRC | 19:09 | |
| *** mkollaro has joined #heat | 19:09 | |
| *** e0ne has joined #heat | 19:11 | |
| *** topol has quit IRC | 19:12 | |
| *** mkollaro1 has joined #heat | 19:13 | |
| *** mkollaro has quit IRC | 19:13 | |
| *** cmyster has quit IRC | 19:13 | |
| *** nati_ueno has joined #heat | 19:27 | |
| *** gokrokve has quit IRC | 19:28 | |
| *** IlyaE has quit IRC | 19:29 | |
| *** cmyster has joined #heat | 19:29 | |
| *** tspatzier has joined #heat | 19:30 | |
| *** nati_uen_ has quit IRC | 19:31 | |
| *** IlyaE has joined #heat | 19:32 | |
| *** blomquisg has quit IRC | 19:33 | |
| *** bvandenh has joined #heat | 19:36 | |
| *** ktbenton has quit IRC | 19:40 | |
| *** kbenton_ has quit IRC | 19:41 | |
| *** mestery has joined #heat | 19:41 | |
| openstackgerrit | Ivan Kolodyazhny proposed a change to openstack/python-heatclient: Add HTTP proxy support to heat client https://review.openstack.org/67153 | 19:42 |
| *** cmyster has quit IRC | 19:43 | |
| stevebaker | morning | 19:44 |
| *** aignatov_ is now known as aignatov | 19:45 | |
| *** tspatzier has quit IRC | 19:47 | |
| stevebaker | radix: does https://review.openstack.org/#/c/67006/ complete as-lib? | 19:47 |
| stevebaker | or anyone ^ ? | 19:47 |
| radix | stevebaker: no | 19:47 |
| radix | stevebaker: it's just one part | 19:48 |
| radix | I'm in the process right now of trying to figure out how to create a second patch in the series without re-uploading the first... | 19:48 |
| stevebaker | radix: OK thanks. Could you start putting partial blueprint... in the commit messages? | 19:48 |
| radix | oh, ok | 19:48 |
| radix | "partial blueprint as-lib"? | 19:48 |
| stevebaker | radix: if the first hasn't changed it won't be re-gated, or notified | 19:48 |
| radix | oh | 19:49 |
| radix | so if "git review" says "hey you're going to upload two patches", that's ok? | 19:49 |
| stevebaker | actually it will notify here, but we have a high spam tolerance | 19:49 |
| radix | heh :) | 19:49 |
| stevebaker | yep, that is ok | 19:49 |
| radix | well, lemme fix this commit message | 19:50 |
| openstackgerrit | Christopher Armstrong proposed a change to openstack/heat: Template management functions for autoscaling https://review.openstack.org/67006 | 19:50 |
| openstackgerrit | Christopher Armstrong proposed a change to openstack/heat: Policy-related autoscale functions https://review.openstack.org/68221 | 19:52 |
| radix | let's see what happened | 19:53 |
| radix | cool | 19:53 |
| *** e0ne has quit IRC | 19:54 | |
| *** gokrokve has joined #heat | 19:58 | |
| *** gokrokve_ has joined #heat | 20:00 | |
| *** gokrokve has quit IRC | 20:03 | |
| *** gokrokve_ has quit IRC | 20:05 | |
| openstackgerrit | Tim Schnell proposed a change to openstack/heat: Adds Parameter Label to HOT spec and parameter schema https://review.openstack.org/62418 | 20:08 |
| openstackgerrit | Tim Schnell proposed a change to openstack/heat: Adds Parameter Label to template validate call https://review.openstack.org/65325 | 20:08 |
| *** sjmc has joined #heat | 20:09 | |
| *** sjmc has quit IRC | 20:10 | |
| *** sjmc7 has joined #heat | 20:10 | |
| *** jistr has quit IRC | 20:11 | |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Make Server compatible with Nova Key Pair resource https://review.openstack.org/68230 | 20:13 |
| *** nati_uen_ has joined #heat | 20:16 | |
| *** nati_ueno has quit IRC | 20:19 | |
| openstackgerrit | Jenkins proposed a change to openstack/heat: Updated from global requirements https://review.openstack.org/68240 | 20:24 |
| *** aweiteka has quit IRC | 20:24 | |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Make Server compatible with Nova Key Pair resource https://review.openstack.org/68230 | 20:26 |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Native Nova Server compatibility for Cloud Server https://review.openstack.org/58043 | 20:26 |
| openstackgerrit | Pablo Andres Fuente proposed a change to openstack/heat: Use a HeatIdentifier instance to create Parameters https://review.openstack.org/68257 | 20:31 |
| *** nati_uen_ has quit IRC | 20:33 | |
| *** jdob has quit IRC | 20:35 | |
| *** jdob has joined #heat | 20:36 | |
| *** rongze has joined #heat | 20:37 | |
| *** achampio1 has quit IRC | 20:41 | |
| *** rongze has quit IRC | 20:42 | |
| *** achampion has joined #heat | 20:42 | |
| *** spzala has joined #heat | 20:42 | |
| *** gokrokve has joined #heat | 20:43 | |
| *** e0ne has joined #heat | 20:43 | |
| *** e0ne has quit IRC | 20:44 | |
| *** jdob has quit IRC | 20:47 | |
| *** jdob has joined #heat | 20:47 | |
| *** achampio1 has joined #heat | 20:47 | |
| *** gokrokve has quit IRC | 20:47 | |
| *** achampion has quit IRC | 20:48 | |
| *** blomquisg has joined #heat | 20:54 | |
| *** aweiteka has joined #heat | 21:01 | |
| *** gokrokve has joined #heat | 21:03 | |
| radix | aw man | 21:05 |
| radix | stevebaker: looks like that did reset the reviews :( | 21:06 |
| radix | I guess because the commit message changed? | 21:06 |
| *** e0ne has joined #heat | 21:06 | |
| zaneb | radix: if you don't have the same SHA, you will get a new patchset | 21:06 |
| stevebaker | radix: there may be a delay for the trivial review bot to restore the scores | 21:06 |
| radix | stevebaker: ah | 21:06 |
| zaneb | does trivial rebase apply if the commit message changes? | 21:07 |
| zaneb | I think it may only re-apply the reviews if it really is only a trivial rebase | 21:08 |
| *** tsmadds has joined #heat | 21:09 | |
| radix | ah okay | 21:09 |
| radix | so it detected a trivial rebase with a commit message change | 21:09 |
| radix | it posted a message to that effect | 21:10 |
| *** achampio1 has quit IRC | 21:10 | |
| *** achampion has joined #heat | 21:10 | |
| *** glucas has joined #heat | 21:11 | |
| *** abramley has joined #heat | 21:13 | |
| *** tsmadds has quit IRC | 21:14 | |
| radix | anyway, if anyone wants to take a look, it's already had two positive reviews and only very small changes since they were done :) | 21:17 |
| *** pafuent1 has left #heat | 21:19 | |
| *** rlandy has quit IRC | 21:21 | |
| *** nati_ueno has joined #heat | 21:23 | |
| *** spzala has quit IRC | 21:23 | |
| andrew_plunk | Good afternoon everyone | 21:26 |
| *** e0ne has quit IRC | 21:27 | |
| *** e0ne has joined #heat | 21:31 | |
| *** jprovazn has quit IRC | 21:37 | |
| *** e0ne has quit IRC | 21:43 | |
| *** asalkeld has joined #heat | 21:44 | |
| *** aweiteka has quit IRC | 21:54 | |
| zaneb | radix: why are we breaking the implementation in half, instead of pulling it out wholesale? | 21:56 |
| radix | zaneb: I don't know what you mean | 21:56 |
| stevebaker | SpamapS: https://review.openstack.org/#/c/68135/ is approved | 21:56 |
| zaneb | radix: I mean, there's heaps of code left behind in resources.autoscaling | 21:57 |
| radix | zaneb: I haven't gotten to it all yet | 21:57 |
| zaneb | radix: and I'm re-reviewing and trying to work out if anything has changed, but the design is now completely different | 21:57 |
| zaneb | so it's really hard to tell | 21:57 |
| radix | re-reviewing what? my patch? | 21:58 |
| *** rcleere has quit IRC | 21:58 | |
| radix | changed since what? | 21:58 |
| radix | what design is completely different from what? :) | 21:58 |
| radix | there are a lot of ambiguous antecedents in this conversation :) | 21:58 |
| zaneb | (I'm looking at https://review.openstack.org/#/c/67006/ ) | 21:58 |
| *** jdob has quit IRC | 21:58 | |
| radix | ok | 21:59 |
| radix | so, that's a really small patch, it just factors out the template generation logic into a new module. | 21:59 |
| *** rcleere has joined #heat | 21:59 | |
| *** rcleere has quit IRC | 22:00 | |
| openstackgerrit | A change was merged to openstack/python-heatclient: Use template_format.parse for local stack parsing https://review.openstack.org/66224 | 22:00 |
| openstackgerrit | A change was merged to openstack/python-heatclient: reconcile prepare_environment_file/url into one funtion https://review.openstack.org/66225 | 22:00 |
| radix | zaneb: can you clarify what you mean? | 22:03 |
| zaneb | radix: I'm just thinking, why not move all of it out in one go? | 22:04 |
| radix | zaneb: because of small, incremental patches | 22:04 |
| zaneb | go through and audit everywhere it uses "self" and replace that with a parameter | 22:04 |
| zaneb | then refactor if you want | 22:05 |
| zaneb | this is doing moving and refactoring at the same time | 22:05 |
| radix | hmm | 22:05 |
| openstackgerrit | Tim Schnell proposed a change to openstack/heat: Adds Parameter Label to HOT spec and parameter schema https://review.openstack.org/62418 | 22:05 |
| openstackgerrit | Tim Schnell proposed a change to openstack/heat: Adds Parameter Label to template validate call https://review.openstack.org/65325 | 22:05 |
| zaneb | that's not my idea of incremental ;) | 22:05 |
| radix | hm | 22:06 |
| zaneb | incremental would be 1 patch to move, 1 to refactor, not necessarily in that order | 22:06 |
| radix | zaneb: I don't think that's feasible. there's too many call chains that go into the database, or assume stuff about resources, or whatever | 22:06 |
| zaneb | yes, I can see that would be an issue | 22:06 |
| radix | I basically found some good chunks of logic that *don't* depend on structure/database and extracted them out | 22:06 |
| zaneb | I'm trying to read a bit deeper now | 22:07 |
| radix | the rolling update one in particular was so I could have one function do all of the work of preparing the batches without having to touch the DB in every iteration (it just returns a list of work to do) | 22:07 |
| SpamapS | stevebaker: thanks. :) Now we just have to wait for ye olde gate. ;) | 22:08 |
| stevebaker | hold not one's breath | 22:08 |
| radix | not just DB, but DB, nested stack, and resource properties/metadata/UpdatePolicy | 22:08 |
| radix | so the interesting data from those became parameters to the functions | 22:08 |
| openstackgerrit | Jason Dunsmore proposed a change to openstack/heat: Document Heat terms in glossary.rst https://review.openstack.org/64314 | 22:09 |
| *** nati_ueno has quit IRC | 22:10 | |
| zaneb | radix: but couldn't you have just kept the same function and passed in callbacks to do the work? | 22:11 |
| *** nati_ueno has joined #heat | 22:11 | |
| radix | zaneb: maybe. but this code looks a lot nicer :) | 22:11 |
| radix | it's way more testing-friendly, for example | 22:11 |
| radix | and it's still a small patch | 22:12 |
| zaneb | really? it's still got all kinds of finicky details like figuring out when you're at the second-to-last batch so you can pause, and they have to be reimplemented every time you use this library call | 22:13 |
| *** harlowja is now known as harlowja_away | 22:14 | |
| radix | zaneb: yeah, I agree, that could be improved. I guess I didn't want to go _too_ far in changing everything | 22:14 |
| stevebaker | Technically it is not a refactor. Since the tests look good enough then maybe changing the commit message would be enough | 22:15 |
| stevebaker | I mean *If* the tests look good enough | 22:15 |
| radix | I was only trying to remove dependence on context | 22:15 |
| radix | stevebaker: hmm, I'm not sure what you mean that it's not a refactor | 22:15 |
| radix | all the old tests still passed | 22:16 |
| stevebaker | radix: a refactor has zero changes in functionality, it is literally just moving things around | 22:16 |
| radix | right. I don't think I changed behavior. | 22:16 |
| radix | I extracted some functions, changed them to be less context-dependent, and everything kept working the same. | 22:16 |
| stevebaker | ok | 22:16 |
| *** asalkeld has quit IRC | 22:20 | |
| *** aignatov is now known as aignatov_ | 22:23 | |
| *** vijendar has quit IRC | 22:24 | |
| *** nati_ueno has quit IRC | 22:24 | |
| *** scollier has quit IRC | 22:29 | |
| *** dims has quit IRC | 22:31 | |
| *** asalkeld has joined #heat | 22:33 | |
| *** achampio1 has joined #heat | 22:34 | |
| *** harlowja_away is now known as harlowja | 22:35 | |
| *** achampion has quit IRC | 22:36 | |
| *** radez is now known as radez_g0n3 | 22:38 | |
| *** IlyaE has quit IRC | 22:41 | |
| *** dims has joined #heat | 22:46 | |
| *** achampio1 has quit IRC | 22:46 | |
| *** spzala has joined #heat | 22:47 | |
| *** achampion has joined #heat | 22:47 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 22:50 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 22:51 | |
| *** achampion has quit IRC | 22:54 | |
| *** achampion has joined #heat | 22:55 | |
| *** rpothier has quit IRC | 22:55 | |
| *** arbylee1 has joined #heat | 22:57 | |
| *** arbylee has quit IRC | 22:58 | |
| *** harlowja has quit IRC | 23:07 | |
| *** andrew_plunk has quit IRC | 23:08 | |
| *** tims has quit IRC | 23:22 | |
| *** arbylee1 has quit IRC | 23:26 | |
| sdake | stevebaker is a film star ! http://www.youtube.com/watch?v=M87R8qoCga8&feature=youtu.be | 23:27 |
| stevebaker | ugh | 23:27 |
| *** yogesh has quit IRC | 23:28 | |
| stevebaker | hmm, our unit tests fail when using git python-novaclient | 23:31 |
| *** slong_ has joined #heat | 23:34 | |
| *** slong has quit IRC | 23:35 | |
| stevebaker | russellb: hey, is there a python-novaclient release looming? | 23:35 |
| russellb | stevebaker: hadn't planned one | 23:37 |
| russellb | stevebaker: release schedule is roughly "when someone asks me" | 23:37 |
| stevebaker | ok, I'm just wondering if the fix for https://bugs.launchpad.net/heat/+bug/1271367 is urgent for i-2. Stuffs will break when python-novaclient is released | 23:38 |
| stevebaker | unit tests will fail specifically | 23:39 |
| *** blamar has quit IRC | 23:47 | |
| *** jcru has quit IRC | 23:50 | |
| SpamapS | stevebaker: sounds like a bug is needed in one or the other. :) | 23:51 |
| stevebaker | what I need is a mox.IgnoreArg for a keyword arg which may be specified or not | 23:54 |
| *** sjmc7 has quit IRC | 23:54 | |
| *** alexpilotti has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
