asalkeld | i am not sure on the status on some of those bp (multi region, outputs need to be lazy loaded) | 00:00 |
---|---|---|
mimizone_ | stevebaker: heat version is 0.2.12 | 00:03 |
stevebaker | mimizone_: could you attach your local.yaml to the bug? | 00:04 |
mimizone_ | stevebaker: done | 00:06 |
*** Qiming has joined #heat | 00:12 | |
*** metral is now known as metral_zzz | 00:15 | |
stevebaker | mimizone_: odd, I can launch that template fine | 00:16 |
mimizone_ | arrrrrr | 00:17 |
mimizone_ | sounds like something shitty in our deployment I guess... | 00:17 |
mimizone_ | what Heat and Openstack version are you running? | 00:17 |
stevebaker | mimizone_: this looks like a heatclient issue, and I've just tried on master and 0.2.12 | 00:18 |
mimizone_ | We are on whatever comes with MOS 5.1 | 00:19 |
mimizone_ | I'll check | 00:19 |
*** Qiming has quit IRC | 00:19 | |
mimizone_ | stevebaker: heat-manage --version returns 2014.1.1 | 00:20 |
stevebaker | mimizone_: maybe there is something weird in your yaml parser. Just to amuse me could you remove the " quoting from the template 'type:' values? | 00:22 |
*** EricGonczer_ has quit IRC | 00:26 | |
mimizone_ | stevebaker: removing the quotes doesn't help much but doesn't make it worth either | 00:27 |
mimizone_ | worst | 00:27 |
mimizone_ | worse | 00:27 |
*** kebray has joined #heat | 00:28 | |
mimizone_ | stevebaker: I'll report the bug to Mirantis. I feel it comes from the specific version we have. And the bug may have been fixed since. | 00:29 |
stevebaker | mimizone_: and you haven't modified kubecluster.yaml or kubenode.yaml in any way? | 00:29 |
*** julienvey has joined #heat | 00:29 | |
mimizone_ | stevebaker: nope. no changes. I even use the same image name to be sure | 00:30 |
*** dims_ has joined #heat | 00:31 | |
*** bhavishkhatri has joined #heat | 00:31 | |
stevebaker | mimizone_: figuring out how to run the installed heatclient unit tests might give you a more specific failure | 00:33 |
*** julienvey has quit IRC | 00:34 | |
*** dims has quit IRC | 00:34 | |
mimizone_ | stevebaker: if yo uhave any pointers for that, appreciated. I am googling. | 00:35 |
mimizone_ | stevebaker: I will also modify a bit the template to try to run it from horizon | 00:35 |
stevebaker | mimizone_: horizon won't work since it can't attach kubenode.yaml | 00:36 |
*** asalkeld has quit IRC | 00:37 | |
*** htruta has quit IRC | 00:37 | |
*** tellesnobrega has quit IRC | 00:37 | |
mimizone_ | any way I can put everything inline? | 00:39 |
*** ccrouch has quit IRC | 00:43 | |
mimizone_ | stevebaker: I may have found some issue in my second file kubenode... | 00:44 |
*** tellesnobrega has joined #heat | 00:44 | |
mimizone_ | stevebaker: basically referencing itself | 00:44 |
stevebaker | mimizone_: no :( You could try defining the kubenode type in your environment file resource_registry, then referencing that type instead of kubenode.yaml http://docs.openstack.org/developer/heat/template_guide/environment.html#usage-examples | 00:44 |
mimizone_ | stevebaker: some copy paste I guess... | 00:45 |
stevebaker | mimizone_: yeah, thats bad. My version doesn't reference itself | 00:45 |
*** tellesnobrega_ has quit IRC | 00:46 | |
mimizone_ | stevebaker: aaahhhh no more recursion! | 00:46 |
mimizone_ | stevebaker: but another error :) | 00:46 |
*** crose has joined #heat | 00:46 | |
mimizone_ | stevebaker: anyway you can close my bug report that was not making any sense then!?! | 00:46 |
stevebaker | mimizone_: so your kubenode was modified? | 00:46 |
mimizone_ | stevebaker: yep. I am pretty sure it's a copy paste of the section at the bottom which appears to come from the other file | 00:47 |
mimizone_ | stevebaker: lame.... | 00:47 |
stevebaker | ok | 00:47 |
mimizone_ | stevebaker: now I have this "ERROR: Property error : kube_master: user_data "Fn::Join" must operate on a list" | 00:47 |
mimizone_ | stevebaker: which is related to this bug report https://review.openstack.org/#/c/121139/ | 00:50 |
*** asalkeld has joined #heat | 00:51 | |
asalkeld | isp seems to think i have moved house :o | 00:51 |
asalkeld | stevebaker, http://specs.openstack.org/openstack/heat-specs/specs/kilo/software-config-progress.html | 00:51 |
asalkeld | what's the correct bp url for that ^ | 00:52 |
stevebaker | mimizone_: I don't know if that fix is in MOS 5.1, asalkeld might be able to help | 00:52 |
asalkeld | or have you not made a bp? | 00:52 |
stevebaker | asalkeld: possibly not created yet | 00:52 |
asalkeld | stevebaker, can you do that? | 00:52 |
stevebaker | I can | 00:52 |
asalkeld | it claims to be targeted at k1 | 00:52 |
stevebaker | it won't be in k1, aim for k2 | 00:53 |
*** htruta has joined #heat | 00:53 | |
* asalkeld doing spec gardening | 00:53 | |
*** crose has quit IRC | 00:53 | |
*** serg_melikyan has joined #heat | 00:54 | |
mimizone_ | stevebaker: thanks for your time. It was very helpful. | 00:54 |
*** mc__ has joined #heat | 00:56 | |
stevebaker | mimizone_: larsks may be able to help with those templates too | 00:58 |
*** serg_melikyan has quit IRC | 00:58 | |
mimizone_ | stevebaker: I got confirmation from Mirantis the patch is not applied and will be possibly in the next 5.1.1 release and Juno. | 00:59 |
stevebaker | ok | 00:59 |
asalkeld | stevebaker, if you have a chance: https://review.openstack.org/#/c/131337/ | 01:12 |
asalkeld | the parameter_defaults patch | 01:12 |
*** Qiming has joined #heat | 01:13 | |
*** zhiwei has joined #heat | 01:15 | |
openstackgerrit | huangtianhua proposed openstack/heat: Do static template validation for nested stacks https://review.openstack.org/132625 | 01:25 |
*** hdd has quit IRC | 01:28 | |
*** spzala has quit IRC | 01:31 | |
*** EricGonczer_ has joined #heat | 01:32 | |
*** killer_prince is now known as lazy_prince | 01:40 | |
asalkeld | stevebaker, regarding that "transparent nested resource", if you added OS::stack_id as an output would you expect get_attr to work on the inner resource? | 01:46 |
openstackgerrit | huangtianhua proposed openstack/heat: Implement 'InstanceId' for LaunchConfiguration https://review.openstack.org/133401 | 01:46 |
asalkeld | because we talked about this, and we backed off | 01:46 |
asalkeld | then you asked for the test case, which leads me to believe that is what feels natural | 01:47 |
*** EricGonczer_ has quit IRC | 01:47 | |
asalkeld | i am beginning to think i should can this one for a bit | 01:48 |
*** EricGonczer_ has joined #heat | 01:49 | |
openstackgerrit | huangtianhua proposed openstack/heat: Check stack adopt enable before adopting https://review.openstack.org/137570 | 01:50 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply nova server constraints for resources https://review.openstack.org/134151 | 01:54 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply nova flavor constraint for resources https://review.openstack.org/134879 | 01:55 |
*** nosnos has joined #heat | 01:56 | |
openstackgerrit | huangtianhua proposed openstack/heat: Add cinder volume custom constraint https://review.openstack.org/136254 | 01:56 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply cinder volume custom constraint https://review.openstack.org/136263 | 01:56 |
openstackgerrit | huangtianhua proposed openstack/heat: Add cinder snapshot custom constraint https://review.openstack.org/136279 | 01:56 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply cinder snapshot custom constraint https://review.openstack.org/136285 | 01:56 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron network constraint https://review.openstack.org/135823 | 01:56 |
openstackgerrit | Merged openstack/heat: Pickup the region name passed in from heatclient https://review.openstack.org/135521 | 01:59 |
*** sarob has quit IRC | 01:59 | |
*** Yanyanhu has joined #heat | 02:00 | |
*** tellesnobrega_ has joined #heat | 02:04 | |
*** EricGonczer_ has quit IRC | 02:08 | |
openstackgerrit | Angus Salkeld proposed openstack/heat: Support better access to nested attributes https://review.openstack.org/136230 | 02:08 |
*** apporc has joined #heat | 02:10 | |
*** EricGonczer_ has joined #heat | 02:11 | |
*** Marga_ has quit IRC | 02:11 | |
*** Qiming_ has joined #heat | 02:17 | |
*** julienvey has joined #heat | 02:18 | |
*** serg_melikyan has joined #heat | 02:19 | |
*** crose has joined #heat | 02:20 | |
*** Qiming has quit IRC | 02:20 | |
*** hdd has joined #heat | 02:20 | |
*** EricGonczer_ has quit IRC | 02:22 | |
*** julienvey has quit IRC | 02:23 | |
*** erkules_ has joined #heat | 02:23 | |
*** hdd has quit IRC | 02:25 | |
*** hdd has joined #heat | 02:25 | |
*** erkules has quit IRC | 02:25 | |
*** serg_melikyan has quit IRC | 02:32 | |
*** serg_melikyan has joined #heat | 02:34 | |
*** serg_melikyan has joined #heat | 02:34 | |
*** dims_ has quit IRC | 02:36 | |
*** serg_melikyan has quit IRC | 02:38 | |
*** serg_melikyan has joined #heat | 02:38 | |
*** pm90_ has quit IRC | 02:39 | |
*** serg_melikyan has joined #heat | 02:39 | |
stevebaker | asalkeld: no I wouldn't. The template author can always manually add the outputs for the attributes they need to duck-type. Its currently possible to duck-type properties and attributes, but not the ref id. Hence the need for this change | 02:39 |
asalkeld | ok, stevebaker just wanted to make sure as i got concerned about your comment in the tests | 02:40 |
asalkeld | but i assume you just want the outputs mapped? | 02:40 |
*** rushiagr_away is now known as rushiagr | 02:42 | |
*** bhavishkhatri has quit IRC | 02:43 | |
stevebaker | asalkeld: which next commit? https://review.openstack.org/#/c/132190/5/heat/tests/test_provider_template.py (last comment) | 02:46 |
*** erkules_ has quit IRC | 02:49 | |
*** erkules_ has joined #heat | 02:50 | |
asalkeld | stevebaker, i just unlinked the commits | 02:50 |
asalkeld | https://review.openstack.org/#/c/136230/ | 02:51 |
asalkeld | (sorry isp on the phone) | 02:52 |
stevebaker | asalkeld: ah, ok | 02:58 |
* asalkeld a bit frazzled - moving house,kids schools, kids schools,xmas - ga | 03:00 | |
*** fandi has quit IRC | 03:04 | |
openstackgerrit | Angus Salkeld proposed openstack-dev/heat-cfnclient: Fix the standard port that is inferred from url scheme https://review.openstack.org/138260 | 03:12 |
openstackgerrit | Angus Salkeld proposed openstack-dev/heat-cfnclient: Fix the tox environment and requirements https://review.openstack.org/138617 | 03:12 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron network constraint https://review.openstack.org/135823 | 03:12 |
elynn | morning :) | 03:14 |
asalkeld | hi elynn | 03:15 |
*** serg_melikyan has quit IRC | 03:19 | |
openstackgerrit | Angus Salkeld proposed openstack/heat: Add support for pass through references https://review.openstack.org/132190 | 03:20 |
asalkeld | stevebaker, re-proposed ^ | 03:21 |
*** serg_melikyan has joined #heat | 03:24 | |
*** rushiagr is now known as rushiagr_away | 03:27 | |
*** bhavishkhatri has joined #heat | 03:30 | |
*** enterprisedc has quit IRC | 03:33 | |
*** bhavishkhatri has quit IRC | 03:33 | |
*** enterprisedc has joined #heat | 03:33 | |
*** dsneddon has quit IRC | 03:33 | |
*** hdd has quit IRC | 03:33 | |
*** andersonvom has quit IRC | 03:34 | |
*** dsneddon has joined #heat | 03:34 | |
*** andersonvom has joined #heat | 03:36 | |
*** dims has joined #heat | 03:36 | |
*** nosnos has quit IRC | 03:39 | |
*** kebray has quit IRC | 03:42 | |
*** dims has quit IRC | 03:42 | |
asalkeld | brb | 03:43 |
*** jamielennox is now known as jamielennox|away | 03:44 | |
*** achanda has joined #heat | 03:44 | |
*** harlowja_ is now known as harlowja_away | 03:47 | |
*** ccrouch has joined #heat | 03:48 | |
*** Yanyanhu has quit IRC | 03:49 | |
*** crose has quit IRC | 03:50 | |
*** rushiagr_away is now known as rushiagr | 03:53 | |
*** dsneddon has quit IRC | 03:54 | |
*** dsneddon has joined #heat | 03:55 | |
*** Qiming_ has quit IRC | 03:56 | |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron port constraint https://review.openstack.org/135835 | 03:57 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron subnet constraint https://review.openstack.org/135875 | 03:58 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron router constraint https://review.openstack.org/135880 | 03:58 |
cmyster | morning | 04:00 |
*** sanjayu has joined #heat | 04:01 | |
*** hdd has joined #heat | 04:02 | |
*** julienvey has joined #heat | 04:07 | |
*** julienvey has quit IRC | 04:11 | |
*** dsneddon has quit IRC | 04:15 | |
*** dsneddon has joined #heat | 04:16 | |
*** apporc has quit IRC | 04:16 | |
*** nosnos has joined #heat | 04:19 | |
*** jamielennox|away is now known as jamielennox | 04:20 | |
*** thedodd has joined #heat | 04:26 | |
*** swygue has joined #heat | 04:27 | |
*** dsneddon has quit IRC | 04:35 | |
*** dsneddon has joined #heat | 04:37 | |
*** lazy_prince is now known as killer_prince | 04:39 | |
*** mc__ has quit IRC | 04:42 | |
*** achanda has quit IRC | 04:43 | |
*** achanda has joined #heat | 04:43 | |
*** achanda has quit IRC | 04:46 | |
*** achanda_ has joined #heat | 04:46 | |
*** GonZo2K has quit IRC | 04:55 | |
*** Qiming has joined #heat | 04:56 | |
*** dsneddon has quit IRC | 04:57 | |
*** dsneddon has joined #heat | 04:57 | |
*** nkhare has joined #heat | 05:02 | |
*** kopparam has joined #heat | 05:06 | |
*** Marga_ has joined #heat | 05:07 | |
*** serg_melikyan has quit IRC | 05:07 | |
*** killer_prince is now known as lazy_prince | 05:09 | |
*** fandi has joined #heat | 05:12 | |
*** mc__ has joined #heat | 05:13 | |
*** hdd has quit IRC | 05:15 | |
*** dsneddon has quit IRC | 05:17 | |
*** serg_melikyan has joined #heat | 05:18 | |
*** dsneddon has joined #heat | 05:18 | |
*** kopparam has quit IRC | 05:20 | |
*** kopparam has joined #heat | 05:21 | |
*** achanda_ has quit IRC | 05:23 | |
*** Yanyanhu has joined #heat | 05:24 | |
*** serg_melikyan has quit IRC | 05:28 | |
*** tellesnobrega_ has quit IRC | 05:28 | |
*** fandi has quit IRC | 05:29 | |
*** lazy_prince is now known as killer_prince | 05:29 | |
*** Marga_ has quit IRC | 05:31 | |
*** Marga_ has joined #heat | 05:31 | |
*** sarob has joined #heat | 05:36 | |
*** unmeshg has joined #heat | 05:36 | |
*** thedodd has quit IRC | 05:38 | |
*** ckmvishnu has joined #heat | 05:43 | |
*** cmyster has quit IRC | 05:44 | |
*** achanda has joined #heat | 05:51 | |
*** killer_prince is now known as lazy_prince | 05:55 | |
*** achanda has quit IRC | 05:55 | |
*** julienvey has joined #heat | 05:55 | |
*** sanjayu has quit IRC | 05:56 | |
*** sanjayu has joined #heat | 05:57 | |
*** dsneddon has quit IRC | 05:59 | |
*** kopparam has quit IRC | 06:00 | |
*** dsneddon has joined #heat | 06:00 | |
*** julienvey has quit IRC | 06:00 | |
*** Marga_ has quit IRC | 06:02 | |
*** sarob has quit IRC | 06:02 | |
*** cmyster has joined #heat | 06:05 | |
*** kopparam has joined #heat | 06:08 | |
*** ParsectiX has quit IRC | 06:08 | |
*** Marga_ has joined #heat | 06:08 | |
*** kopparam has quit IRC | 06:11 | |
*** kopparam has joined #heat | 06:11 | |
*** dsneddon has quit IRC | 06:19 | |
*** k4n0 has joined #heat | 06:20 | |
*** dsneddon has joined #heat | 06:20 | |
Qiming | hi, can someone tell me what's does it implies that a resource_id is None? | 06:24 |
cmyster | Qiming: on a live stack ? | 06:29 |
cmyster | morning btw | 06:29 |
Qiming | for any resource | 06:29 |
Qiming | or in most resource implementations, I saw checks like this 'if self.resource_id is None' | 06:30 |
Qiming | I'm wondering what are we actually checking | 06:31 |
cmyster | I can't think of a case wehn a resource might not have an id... is it an assert test ? | 06:31 |
*** Marga_ has quit IRC | 06:31 | |
Qiming | No. It's virtually everywhere | 06:31 |
cmyster | like, create something, assert that self.id is not none ? | 06:32 |
cmyster | oh | 06:32 |
cmyster | no idea :) | 06:32 |
cmyster | Qiming: can you link ? | 06:32 |
Qiming | okay, showing you an example | 06:32 |
cmyster | just paste the file's path... | 06:32 |
Qiming | cmyster, http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/server.py#n1100 | 06:34 |
Qiming | oh, n1106 | 06:34 |
Qiming | and n1057 | 06:35 |
cmyster | I think that the exception here explains it well, if there is no resource_id, you cannot continue because the resource is not set. | 06:35 |
cmyster | raise exception.Error(_('Cannot resume %s, resource_id not set') % | 06:35 |
cmyster | sounds legit ? | 06:36 |
Qiming | why resource_id is None? | 06:36 |
cmyster | failed to be set by any reason | 06:36 |
Qiming | it is only explicitly set to None here: http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resource.py#n176 | 06:36 |
cmyster | but this is an assignment, heat is saying, we want to continue asap so lets assume that the resource was deleted and assign Null as it's id | 06:38 |
Qiming | I have an impression why this was added, but cannot recall the exact details | 06:38 |
cmyster | this is my interpretation to the code I am reading now, | 06:38 |
cmyster | I might be off track, but it seems reasonable | 06:38 |
*** nosnos has quit IRC | 06:38 | |
Qiming | no objections to the checks, even if it IS redundant | 06:40 |
tiantian | Qiming: resource_id always be set after the resource created succesful | 06:40 |
Qiming | my doubt is about the message (error) returned | 06:40 |
*** dsneddon has quit IRC | 06:40 | |
*** apporc has joined #heat | 06:40 | |
*** nosnos has joined #heat | 06:40 | |
Qiming | as a user, I would be pretty shocked Heat tells me 'resource_id not set' | 06:41 |
cmyster | +1 | 06:41 |
cmyster | open a bug | 06:41 |
Qiming | so it means what? A resource cannot be found? | 06:41 |
tiantian | Qiming: about the msg, I agree with you | 06:42 |
Qiming | unless the Error is caught in the middle way and translated to something understandable to users | 06:42 |
cmyster | it read it like so, a resource has failed to be set in a reasonable manner | 06:42 |
*** dsneddon has joined #heat | 06:43 | |
* Qiming needs to follow the call trace | 06:43 | |
cmyster | because as tiantian wrote it is being set after a resource was successfully created | 06:43 |
cmyster | Qiming: so I guess the better msg here would be 'Cannot resume %s, it has failed to be set' | 06:46 |
cmyster | tiantian? ^ | 06:46 |
Qiming | :) what is 'it'? | 06:46 |
cmyster | %sa | 06:46 |
cmyster | -a | 06:46 |
cmyster | the self.name in this case | 06:46 |
cmyster | also Qiming: | 06:49 |
cmyster | http://paste.openstack.org/show/143929/ | 06:49 |
cmyster | so if you want to change the msg all over... | 06:49 |
Qiming | I'm not quite sure we should change it or not | 06:50 |
Qiming | need to find out whether a user is actually seeing them | 06:50 |
cmyster | Qiming: hard to say as this is not something that can be easily be reproduced. maybe with a stub | 06:51 |
Qiming | right. | 06:51 |
cmyster | or just setting that id to None just before | 06:51 |
Qiming | if it is not reproducible, then it is useless code, :P | 06:52 |
*** tomek_adamczewsk has joined #heat | 06:52 | |
cmyster | or just setting that id to None just before this part of code needs a proper try/catch and if catched in needs a proper msg even if it might happen once a blue moon | 06:52 |
cmyster | up key... | 06:53 |
cmyster | Qiming: its what we call a minor bug: a bug in the system because it is there and we know wbout it even if the end user may not reach it ever. | 06:54 |
Qiming | ok | 06:54 |
cmyster | unline a medium bug which is just like that but the user can notice it. major/critical bugs effect the end result as well. | 06:55 |
*** kopparam has quit IRC | 06:56 | |
cmyster | unlike | 06:56 |
cmyster | coffee++ | 06:57 |
*** kopparam has joined #heat | 06:57 | |
asalkeld | coffee+icecream=even better | 06:59 |
asalkeld | :-) | 06:59 |
asalkeld | Qiming, are you happy with the plan forward with autoscaling? | 07:00 |
*** dsneddon has quit IRC | 07:02 | |
Qiming | asalkeld, that sounds a viable approach | 07:02 |
asalkeld | Qiming, can you think of a better approach? - or one that you would prefer? | 07:03 |
Qiming | asalkeld, my current thought is to attack this from both ends | 07:03 |
*** dsneddon has joined #heat | 07:04 | |
asalkeld | Qiming, yeah that's probably needed | 07:04 |
Qiming | on one hand, we manipulate heat code to come up with a library of code that can be shared | 07:04 |
Qiming | on the other hand, we need to stand up a service quickly for verification | 07:05 |
asalkeld | tho' that library probably needs to be in the autoscaling repo in the long term | 07:05 |
Qiming | yes, if Heat is calling AS API directly, there is no reason the leave the library there in Heat | 07:05 |
Qiming | btw, asalkeld, do you know (or call you recall) why we have so many "resource_id is None" checkings? | 07:06 |
Qiming | s/call/can | 07:07 |
asalkeld | Qiming, as a way to know if we have created the resource | 07:07 |
Qiming | so the short interval between the python object is initialized but the physical resource is not there yet? | 07:08 |
asalkeld | Qiming, yeah - i am not sure if it is actually needed outside of resource.py | 07:09 |
asalkeld | once we have descided to create/update/delete we should probablyjust do it | 07:09 |
Qiming | I have an impression about this -- there could be some problems when doing validation | 07:09 |
Qiming | cannot recall the details | 07:10 |
asalkeld | Qiming, i'd have to check the code to confirm | 07:10 |
Qiming | okay | 07:10 |
asalkeld | but there are also lots of checks in handle_delete | 07:10 |
asalkeld | that might not be needed | 07:11 |
Qiming | agreed | 07:11 |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron subnet constraint https://review.openstack.org/135875 | 07:13 |
tiantian | asalkeld: not exactly, if the resources not be successfully created, no need to call responding client to delete them, I think this is one reason to check resource_id in handle_delete() | 07:16 |
asalkeld | tiantian, or we could just try/except | 07:17 |
asalkeld | both are valid approaches, we should just be consistent | 07:17 |
tiantian | asalkeld: no need to try if check the resource_id:) | 07:18 |
asalkeld | shrug, doesn't make a big difference to me | 07:18 |
tiantian | asalkeld: another question | 07:20 |
asalkeld | yip | 07:20 |
tiantian | asalkeld: implement instanceid for autoscaling group | 07:21 |
asalkeld | yeah | 07:21 |
tiantian | asalkeld: my thought is to set the instance's properties to asg's resource_data | 07:22 |
tiantian | such as an internal launchconfig resource | 07:22 |
asalkeld | tiantian, just looking at the code | 07:22 |
*** dsneddon has quit IRC | 07:23 | |
asalkeld | tiantian, https://review.openstack.org/#/c/130728/ | 07:24 |
asalkeld | that's the spec | 07:24 |
asalkeld | reading | 07:24 |
tiantian | the creation works, but the updation is failed, because get childe_template() in prev_resource.implementation_signature() | 07:24 |
*** dsneddon has joined #heat | 07:25 | |
*** julienvey has joined #heat | 07:26 | |
*** songli has joined #heat | 07:27 | |
tiantian | s/child_template | 07:27 |
*** serg_melikyan has joined #heat | 07:28 | |
asalkeld | looks like you just need to override _get_conf_properties | 07:29 |
*** songli has quit IRC | 07:29 | |
asalkeld | and you *could* get the properties each time from the instance | 07:29 |
*** Putns has joined #heat | 07:29 | |
tiantian | yes, you can review https://review.openstack.org/#/c/133905/7/heat/engine/resources/aws/autoscaling_group.py | 07:29 |
*** songli has joined #heat | 07:30 | |
*** julienvey has quit IRC | 07:31 | |
asalkeld | tiantian, do we really want to create a whole implicit resource instance? | 07:32 |
asalkeld | for the lc | 07:32 |
tiantian | you mean no need to store the instance'props? this is the original idea | 07:32 |
asalkeld | well you create a resource for the lc | 07:32 |
asalkeld | scheduler.TaskRunner(conf.create)() | 07:32 |
asalkeld | that will store a new resource in the db | 07:32 |
asalkeld | and the user will see that | 07:33 |
*** serg_melikyan has quit IRC | 07:33 | |
tiantian | in fact no need, according qiming's commend | 07:33 |
tiantian | user can't see | 07:33 |
asalkeld | maybe just store a map | 07:33 |
tiantian | no matter what to be stored, there is a problem when get childe_template() in prev_resource.implementation_signature() in updation | 07:34 |
tiantian | because the prev_resource is a new one, no id, no resource_id, no data()... | 07:35 |
asalkeld | gate looks good | 07:37 |
asalkeld | is there no test for that scenario? | 07:37 |
asalkeld | one issue with using instanceid is you have no guarentee that is going to stay the same | 07:39 |
asalkeld | i'd suggest not storing anything, and just getting the properties fresh each time | 07:39 |
tiantian | after the commit Ibd64b3607721487be5b0562cdb54e6c76db51149, the patch doesn't work | 07:40 |
asalkeld | you won't have to worry about existing resources existing or not too | 07:40 |
asalkeld | tiantian, i need to make some food - i'll in and out in the evening | 07:41 |
asalkeld | tiantian, i can't find that commit | 07:42 |
asalkeld | 'Ibd64b3607721487be5b0562cdb54e6c76db51149': unknown revision | 07:43 |
tiantian | https://review.openstack.org/#/c/135354/ | 07:43 |
asalkeld | so it's calling child_template early | 07:44 |
asalkeld | shouldn't be a problem | 07:44 |
asalkeld | tiantian, brb | 07:44 |
asalkeld | kids asking for food | 07:44 |
cmyster | asalkeld: the nerve... ;) | 07:45 |
*** dsneddon has quit IRC | 07:45 | |
*** jprovazn has joined #heat | 07:45 | |
*** dsneddon has joined #heat | 07:47 | |
*** openstackgerrit has quit IRC | 07:50 | |
*** openstackgerrit has joined #heat | 07:50 | |
openstackgerrit | huangtianhua proposed openstack/heat: Apply neutron router constraint https://review.openstack.org/135880 | 07:58 |
shardy | morning all | 07:58 |
mc__ | morning shardy | 07:59 |
tiantian | shardy: hi:) | 08:03 |
*** dsneddon has quit IRC | 08:06 | |
*** julienvey has joined #heat | 08:07 | |
*** dsneddon has joined #heat | 08:08 | |
*** pas-ha has joined #heat | 08:11 | |
skraynev | Good morning | 08:13 |
cmyster | morning | 08:14 |
tiantian | skraynev: hi | 08:14 |
skraynev | hi tiantian | 08:14 |
*** tomek_adamczews1 has joined #heat | 08:23 | |
*** julienvey has quit IRC | 08:24 | |
*** julienvey has joined #heat | 08:25 | |
*** tomek_adamczewsk has quit IRC | 08:25 | |
*** serg_melikyan has joined #heat | 08:29 | |
*** jstrachan has joined #heat | 08:30 | |
*** Qiming_ has joined #heat | 08:31 | |
*** julienvey has quit IRC | 08:33 | |
*** serg_melikyan has quit IRC | 08:33 | |
*** Qiming has quit IRC | 08:34 | |
openstackgerrit | huangtianhua proposed openstack/heat-specs: Implement 'InstanceId' for AutoScalingGroup https://review.openstack.org/130728 | 08:35 |
*** jcoufal has joined #heat | 08:38 | |
*** tomek_adamczews1 has quit IRC | 08:38 | |
mc__ | shardy, do you know, how to set up a service chain in openstack? I can enter neutron service-provider-list, but how can I create a new one? Any hints? | 08:40 |
*** dkusidlo has joined #heat | 08:41 | |
*** dkusidlo has quit IRC | 08:43 | |
*** jtomasek has joined #heat | 08:48 | |
*** dsneddon has quit IRC | 08:48 | |
*** ahonda has joined #heat | 08:48 | |
*** dsneddon has joined #heat | 08:49 | |
*** erkules_ is now known as erkules | 09:00 | |
*** pas-ha has quit IRC | 09:01 | |
*** nkhare has quit IRC | 09:01 | |
*** ishant has joined #heat | 09:02 | |
*** dims has joined #heat | 09:03 | |
*** sarob has joined #heat | 09:03 | |
*** sanjayu has quit IRC | 09:05 | |
*** sanjayu has joined #heat | 09:06 | |
*** Qiming_ has quit IRC | 09:07 | |
*** sarob has quit IRC | 09:08 | |
*** dims has quit IRC | 09:08 | |
*** dsneddon has quit IRC | 09:09 | |
*** dsneddon has joined #heat | 09:11 | |
*** dkusidlo has joined #heat | 09:12 | |
skraynev | zaneb: ping | 09:14 |
*** tspatzier has joined #heat | 09:15 | |
*** jstrachan has quit IRC | 09:17 | |
*** jstrachan has joined #heat | 09:21 | |
*** tomek_adamczewsk has joined #heat | 09:22 | |
*** tomek_adamczews1 has joined #heat | 09:24 | |
*** tomek_adamczewsk has quit IRC | 09:26 | |
*** jstrachan has quit IRC | 09:27 | |
*** pas-ha has joined #heat | 09:28 | |
*** unmeshg has quit IRC | 09:29 | |
*** dkusidlo has quit IRC | 09:29 | |
shardy | mc__: Sorry, not sure, try #openstack-neutron | 09:30 |
mc__ | thanks | 09:30 |
openstackgerrit | huangtianhua proposed openstack/heat: Implement 'InstanceId' for LaunchConfiguration https://review.openstack.org/133401 | 09:30 |
*** unmeshg has joined #heat | 09:30 | |
*** nkhare has joined #heat | 09:30 | |
*** jstrachan has joined #heat | 09:31 | |
*** tomek_adamczewsk has joined #heat | 09:34 | |
*** songli has quit IRC | 09:34 | |
*** jstrachan_ has joined #heat | 09:34 | |
*** justin-8_ has joined #heat | 09:35 | |
*** kopparam has quit IRC | 09:35 | |
*** tomek_adamczews1 has quit IRC | 09:36 | |
*** songli has joined #heat | 09:36 | |
*** jstracha_ has joined #heat | 09:37 | |
*** jstrachan has quit IRC | 09:37 | |
*** justin-8 has quit IRC | 09:37 | |
*** jstrachan_ has quit IRC | 09:39 | |
*** jcoufal has quit IRC | 09:40 | |
openstackgerrit | huangtianhua proposed openstack/heat: Implement 'InstanceId' for autoscaling group https://review.openstack.org/133905 | 09:44 |
*** jstracha_ has quit IRC | 09:44 | |
*** julienvey has joined #heat | 09:44 | |
*** jstrachan has joined #heat | 09:48 | |
*** julienvey has quit IRC | 09:49 | |
*** Yanyanhu has quit IRC | 09:49 | |
openstackgerrit | huangtianhua proposed openstack/heat: Implement 'InstanceId' for autoscaling group https://review.openstack.org/133905 | 09:50 |
*** mattt has quit IRC | 09:51 | |
*** mattt has joined #heat | 09:55 | |
*** _shaps_ has joined #heat | 09:56 | |
*** mc__ has quit IRC | 09:56 | |
*** lazy_prince has quit IRC | 09:57 | |
*** GonZo2K has joined #heat | 10:00 | |
*** justin-8_ has quit IRC | 10:01 | |
*** justin-8 has joined #heat | 10:01 | |
*** zhiwei has quit IRC | 10:02 | |
*** jstrachan has quit IRC | 10:02 | |
*** tspatzier has quit IRC | 10:03 | |
*** jstrachan has joined #heat | 10:04 | |
*** julienvey has joined #heat | 10:06 | |
*** enterprisedc has quit IRC | 10:07 | |
*** enterprisedc has joined #heat | 10:07 | |
*** fayablazer has joined #heat | 10:10 | |
*** killer_prince has joined #heat | 10:11 | |
*** killer_prince is now known as lazy_prince | 10:11 | |
*** alexpilotti has joined #heat | 10:12 | |
*** tomek_adamczewsk has quit IRC | 10:13 | |
*** tomek_adamczews1 has joined #heat | 10:13 | |
*** GonZo2K has quit IRC | 10:13 | |
*** tellesnobrega_ has joined #heat | 10:18 | |
*** tomek_adamczewsk has joined #heat | 10:21 | |
*** tomek_adamczews1 has quit IRC | 10:21 | |
*** inc0 has joined #heat | 10:22 | |
openstackgerrit | huangtianhua proposed openstack/heat: Delete resource_data after resource deleted https://review.openstack.org/129508 | 10:25 |
*** kopparam has joined #heat | 10:30 | |
*** steel13 has joined #heat | 10:31 | |
*** jistr has joined #heat | 10:37 | |
*** jistr is now known as jistr|trng | 10:38 | |
*** sanjayu has quit IRC | 10:38 | |
*** inc0_ has joined #heat | 10:39 | |
*** sanjayu has joined #heat | 10:39 | |
*** inc0 has quit IRC | 10:42 | |
*** pfreund has quit IRC | 10:42 | |
*** jcoufal has joined #heat | 10:42 | |
*** asalkeld has quit IRC | 10:43 | |
*** bdossant has joined #heat | 10:44 | |
*** pfreund has joined #heat | 10:44 | |
*** tspatzier has joined #heat | 10:45 | |
*** dkusidlo has joined #heat | 10:46 | |
*** dulek has joined #heat | 10:49 | |
*** derekh has joined #heat | 10:50 | |
*** julienvey has quit IRC | 10:51 | |
*** tomek_adamczewsk has quit IRC | 10:55 | |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for log messages https://review.openstack.org/138124 | 10:55 |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for help messages https://review.openstack.org/138081 | 10:55 |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Initial setup for i18n support https://review.openstack.org/137842 | 10:55 |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for error messages https://review.openstack.org/138123 | 10:55 |
*** dkusidlo has quit IRC | 10:56 | |
*** tellesnobrega_ has quit IRC | 11:02 | |
openstackgerrit | Qiming Teng proposed openstack/heat: Make all assertEqual() calls conform to convention https://review.openstack.org/138369 | 11:04 |
*** tomek_adamczewsk has joined #heat | 11:05 | |
*** serg_melikyan has joined #heat | 11:11 | |
*** bhi has joined #heat | 11:13 | |
*** serg_melikyan has quit IRC | 11:15 | |
*** bdossant has quit IRC | 11:16 | |
*** Marga_ has joined #heat | 11:20 | |
*** andreaf has joined #heat | 11:22 | |
*** k4n0 has quit IRC | 11:23 | |
*** jstrachan has quit IRC | 11:30 | |
*** dims has joined #heat | 11:30 | |
*** serg_melikyan has joined #heat | 11:32 | |
*** ckmvishnu has quit IRC | 11:32 | |
*** ishant has quit IRC | 11:33 | |
*** nkhare has quit IRC | 11:35 | |
*** apporc has quit IRC | 11:36 | |
*** jstrachan has joined #heat | 11:38 | |
*** jstrachan has quit IRC | 11:43 | |
*** jstrachan has joined #heat | 11:43 | |
cmyster | hmmm | 11:45 |
cmyster | I went to have a look at that heat-db-setup. shardy if it being used ? | 11:46 |
cmyster | I see quite a few different syntaxes all in the same file | 11:46 |
shardy | cmyster: I thought it was (very) legacy tbh | 11:47 |
cmyster | shardy: maybe, remove ? | 11:47 |
shardy | cmyster: Yeah, I've already suggested that in the bug, but I'm interested to understand why the reporter thinks they need it first | 11:48 |
shardy | Hopefully andersonvom can clarify when he wakes up :) | 11:48 |
openstackgerrit | Merged openstack/heat: Apply nova server constraints for resources https://review.openstack.org/134151 | 11:48 |
openstackgerrit | Merged openstack/heat: Apply nova flavor constraint for resources https://review.openstack.org/134879 | 11:48 |
cmyster | shardy: https://bugzilla.redhat.com/show_bug.cgi?id=1046326 | 11:49 |
uvirtbot | cmyster: Error: Could not parse XML returned by bugzilla.redhat.com: HTTP Error 404: Not Found | 11:49 |
* cmyster looks at the bot... | 11:50 | |
cmyster | shardy: BTW was wondering about the structure of test_update.py, do you have a minute to talk about it ? | 11:52 |
shardy | cmyster: sure | 11:52 |
cmyster | shardy: I am trying to follow what exactly used there to make a template a nested template of another | 11:55 |
cmyster | my goal is to take this test and mke it to a negative test | 11:55 |
shardy | cmyster: provider_template defines My::RandomString which will create a nested stack of whatever is defined in the environment | 11:57 |
shardy | cmyster: Also, ResourceGroup creates a nested stack internally | 11:57 |
shardy | So by creating a ResourceGroup of My::RandomString we're effectively testing two-level nested updates | 11:57 |
shardy | (which was the bug I'd just fixed when writing the tests) | 11:58 |
cmyster | shardy: I was trying to do the same but a scenario with actual template files but its a pita... | 11:58 |
*** jstrachan has quit IRC | 11:58 | |
shardy | cmyster: "actual template files"? | 11:59 |
cmyster | yes files | 11:59 |
cmyster | read from a file not define a string called template | 12:00 |
shardy | The scenario tests read the files anyway I think | 12:00 |
*** dulek_ has joined #heat | 12:00 | |
cmyster | I know, but none of those uses nested templates | 12:01 |
*** jstrachan has joined #heat | 12:01 | |
shardy | I guess what I'm saying is what you (I think) want to do will only work via the heatclient CLI, not the python API | 12:01 |
*** pm90_ has joined #heat | 12:01 | |
*** julienvey has joined #heat | 12:02 | |
cmyster | I see | 12:02 |
cmyster | well, legit | 12:02 |
shardy | the code from shell.py resolves filenames, reads the contents, then calls the python API (which is what we're doing in all the tests) | 12:02 |
cmyster | its too bad, I can see many cases where I can re-use templates in different tests | 12:02 |
*** serg_melikyan has quit IRC | 12:02 | |
shardy | Well you can just create the file and read it in the test, see test_volumes.py for an example | 12:03 |
*** dulek has quit IRC | 12:03 | |
shardy | We can even create a common wrapper which takes filenames if you like | 12:03 |
cmyster | the first file is OK but if you map a type to a different file you might need to pass the exact full path | 12:03 |
*** serg_melikyan has joined #heat | 12:04 | |
*** serg_melikyan has joined #heat | 12:04 | |
cmyster | the issue is, after reading things from the 'parent' template and understanding that were now looking for a new file, where is that file? | 12:05 |
cmyster | not a big issuie, just annoying and I did not want to import os in the test | 12:06 |
*** jstrachan has quit IRC | 12:06 | |
*** julienvey has quit IRC | 12:06 | |
*** kopparam has quit IRC | 12:06 | |
shardy | https://github.com/openstack/heat/blob/master/heat_integrationtests/functional/test_update.py#L121 | 12:07 |
shardy | cmyster: ^^ You just read the file and put the contents in the files map | 12:07 |
shardy | https://github.com/openstack/heat/blob/master/heat_integrationtests/scenario/test_volumes.py#L59 | 12:08 |
cmyster | I see | 12:08 |
shardy | https://github.com/openstack/heat/blob/master/heat_integrationtests/common/test.py#L179 | 12:09 |
*** serg_melikyan has quit IRC | 12:09 | |
cmyster | shardy: thats what you have standardized after the last change ? | 12:09 |
*** kopparam has joined #heat | 12:09 | |
cmyster | I remember a TODO in that proximity | 12:09 |
*** julienvey has joined #heat | 12:10 | |
cmyster | OK I see what you did there, yup that should work, thanks | 12:10 |
shardy | The TODO was about refactoring all the common code to create a stack | 12:10 |
shardy | I posted this review which is a step to fixing that: | 12:11 |
shardy | https://review.openstack.org/#/c/136008/ | 12:11 |
*** serg_melikyan has joined #heat | 12:11 | |
cmyster | OK | 12:11 |
cmyster | is there a plan to do something like for updates as well ? | 12:11 |
shardy | cmyster: We could add an interface to that which takes a file_names list or something, then read the templates inside the helper | 12:12 |
*** jstrachan has joined #heat | 12:12 | |
shardy | There's already update_stack in the base-class | 12:12 |
shardy | Over time I guess we'll enahance the base class helpers to avoid too much duplicated logic | 12:13 |
cmyster | shardy: and if we want to do something more nested? passing a parameter to the child template in order for it to pass it to *its* child ? | 12:13 |
shardy | unless you're using asalkeld's new parameter_defaults, that has to be passed in as a parameter to the parent anyway | 12:14 |
cmyster | shardy: I'm not, thats new to me | 12:16 |
*** bdossant has joined #heat | 12:17 | |
shardy | https://review.openstack.org/#/c/131337/ | 12:17 |
shardy | Quite a cool new feature :) | 12:17 |
* cmyster rads | 12:19 | |
cmyster | and reads | 12:19 |
*** funzo has quit IRC | 12:20 | |
*** bdossant has quit IRC | 12:21 | |
*** jstrachan has quit IRC | 12:23 | |
*** dkusidlo has joined #heat | 12:26 | |
*** kopparam has quit IRC | 12:27 | |
*** jstrachan has joined #heat | 12:28 | |
*** jistr|trng has quit IRC | 12:28 | |
*** jstrachan has quit IRC | 12:34 | |
*** jistr has joined #heat | 12:34 | |
*** jistr is now known as jistr|trng | 12:35 | |
*** jstrachan has joined #heat | 12:38 | |
*** pm90_ has quit IRC | 12:39 | |
*** pm90_ has joined #heat | 12:39 | |
*** pm90_ has quit IRC | 12:39 | |
*** funzo has joined #heat | 12:40 | |
*** Marga_ has quit IRC | 12:41 | |
*** EricGonczer_ has joined #heat | 12:41 | |
*** bdossant has joined #heat | 12:41 | |
*** jstrachan has quit IRC | 12:44 | |
*** htruta has quit IRC | 12:44 | |
*** unmeshg has quit IRC | 12:45 | |
*** bdossant has quit IRC | 12:45 | |
*** bdossant has joined #heat | 12:45 | |
*** htruta has joined #heat | 12:47 | |
*** stannie has joined #heat | 12:48 | |
*** dulek has joined #heat | 12:48 | |
*** dulek_ has quit IRC | 12:49 | |
*** pm90_ has joined #heat | 12:49 | |
*** sanjayu has quit IRC | 12:49 | |
*** sanjayu has joined #heat | 12:51 | |
*** jstrachan has joined #heat | 12:51 | |
*** hdd has joined #heat | 13:03 | |
openstackgerrit | Merged openstack/heat: Make all assertEqual() calls conform to convention https://review.openstack.org/138369 | 13:05 |
openstackgerrit | Merged openstack/heat: Fix invalid syntax on heat-db-setup https://review.openstack.org/138525 | 13:06 |
*** dulek has quit IRC | 13:09 | |
*** rushiagr is now known as rushiagr_away | 13:10 | |
*** jstrachan has quit IRC | 13:11 | |
*** jstrachan has joined #heat | 13:11 | |
*** kopparam has joined #heat | 13:12 | |
*** radez_g0n3 is now known as radez | 13:16 | |
*** zhiwei has joined #heat | 13:27 | |
*** kitch has joined #heat | 13:30 | |
*** jdob has joined #heat | 13:30 | |
*** sanjayu has quit IRC | 13:31 | |
*** rpothier has joined #heat | 13:32 | |
*** hdd has quit IRC | 13:33 | |
*** hdd has joined #heat | 13:33 | |
*** EricGonc_ has joined #heat | 13:33 | |
*** EricGonc_ has quit IRC | 13:33 | |
*** kopparam has quit IRC | 13:33 | |
*** aweiteka has joined #heat | 13:34 | |
*** dkusidlo has quit IRC | 13:35 | |
*** kopparam has joined #heat | 13:36 | |
*** tomek_adamczews1 has joined #heat | 13:39 | |
*** tomek_adamczewsk has quit IRC | 13:41 | |
*** shadower has joined #heat | 13:44 | |
*** serg_melikyan has quit IRC | 13:49 | |
*** serg_melikyan has joined #heat | 13:50 | |
*** jstrachan has quit IRC | 13:50 | |
*** andersonvom has quit IRC | 13:50 | |
*** andersonvom has joined #heat | 13:50 | |
*** serg_melikyan has quit IRC | 13:54 | |
openstackgerrit | Pratik Mallya proposed openstack/heat: Pass status reason when trove misbehaves https://review.openstack.org/131563 | 13:54 |
*** jcoufal has quit IRC | 13:55 | |
*** jstrachan has joined #heat | 13:55 | |
*** jcoufal has joined #heat | 13:56 | |
*** crose has joined #heat | 13:56 | |
*** julienvey has quit IRC | 13:57 | |
*** julienvey has joined #heat | 13:58 | |
*** serg_melikyan has joined #heat | 13:59 | |
*** dkusidlo has joined #heat | 14:00 | |
*** bdossant_ has joined #heat | 14:02 | |
*** bdossant has quit IRC | 14:03 | |
*** zhiwei has quit IRC | 14:05 | |
*** rushiagr_away is now known as rushiagr | 14:05 | |
*** jstrachan has quit IRC | 14:06 | |
*** EricGonczer_ has quit IRC | 14:08 | |
*** tomek_adamczewsk has joined #heat | 14:09 | |
*** GonZo2K has joined #heat | 14:09 | |
*** lazy_prince is now known as killer_prince | 14:10 | |
*** jstrachan has joined #heat | 14:10 | |
*** GonZo2K has quit IRC | 14:10 | |
*** tomek_adamczews1 has quit IRC | 14:10 | |
*** julienvey has quit IRC | 14:11 | |
*** ckmvishnu has joined #heat | 14:12 | |
ckmvishnu | zaneb: Hi | 14:12 |
*** hdd has quit IRC | 14:17 | |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for log messages https://review.openstack.org/138124 | 14:17 |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for help messages https://review.openstack.org/138081 | 14:17 |
openstackgerrit | Tetiana Lashchova proposed openstack/python-heatclient: Add transtlation markers for error messages https://review.openstack.org/138123 | 14:17 |
inc0_ | hello ckmvishnu, howdy? | 14:19 |
inc0_ | guys, do we have issues regarding no-downtime upgrades listed anywhere? | 14:21 |
*** blomquisg has joined #heat | 14:22 | |
*** crose has quit IRC | 14:25 | |
*** jmckind has joined #heat | 14:27 | |
*** kopparam has quit IRC | 14:27 | |
*** nosnos has quit IRC | 14:28 | |
*** jdob has quit IRC | 14:32 | |
*** jdob has joined #heat | 14:32 | |
ckmvishnu | inc0_: Hi | 14:33 |
ckmvishnu | you mean database upgrades? | 14:33 |
*** GonZo2K has joined #heat | 14:34 | |
ckmvishnu | inc0_: Just wanted to juscuss with zaneb: and you over g+ or the likes and come to a closure on convergence. | 14:35 |
*** GonZo2K has quit IRC | 14:36 | |
inc0_ | yeah, about time we agree on something;) | 14:36 |
ckmvishnu | when do you think zaneb will be available | 14:36 |
ckmvishnu | i can schedule a hangout tomorrow at a convenient time for all interested to discuss. propose/amend bp and proceed implementation | 14:38 |
*** jdob has quit IRC | 14:39 | |
ryansb | ckmvishnu: zane is on Eastern time, if that helps | 14:39 |
*** jdob has joined #heat | 14:39 | |
inc0_ | problem is we have whole spread of globe here;) Angus is Australia, then Bangalore, Europe and east coast;) | 14:40 |
ckmvishnu | ryansb: oh, then we must have overlapping time | 14:40 |
*** jprovazn has quit IRC | 14:42 | |
ryansb | inc0_: global team, global problems. | 14:43 |
inc0_ | I'd suggest to live by ZULU time;) | 14:44 |
*** kopparam has joined #heat | 14:44 | |
*** jasond has joined #heat | 14:46 | |
*** thedodd has joined #heat | 14:46 | |
*** hdd has joined #heat | 14:47 | |
*** bdossant_ has quit IRC | 14:47 | |
*** bdossant has joined #heat | 14:48 | |
*** apporc has joined #heat | 14:49 | |
zaneb | ckmvishnu: o/ can do, but hangouts are not possible for me (I don't have an account) | 14:54 |
ckmvishnu | skype? | 14:55 |
inc0_ | well, I'd still prefere irc | 14:55 |
inc0_ | we get log... | 14:55 |
*** EricGonczer_ has joined #heat | 14:56 | |
ckmvishnu | inc0_: arrggh | 14:56 |
ckmvishnu | zaneb: what about timing | 14:56 |
zaneb | I can do irc or skype | 14:56 |
ckmvishnu | will the same time be ok for you guys | 14:56 |
ckmvishnu | india its 8:30pm | 14:56 |
ckmvishnu | great | 14:57 |
*** jstrachan has quit IRC | 14:57 | |
zaneb | same time as what? | 14:57 |
ckmvishnu | i have an notification aggregator based code. will push them in an hour or two. | 14:57 |
inc0_ | I guess now zaneb ;) | 14:57 |
*** justin-8_ has joined #heat | 14:58 | |
*** jstrachan has joined #heat | 14:58 | |
ckmvishnu | i'll have to inform by guys as well. | 14:58 |
ckmvishnu | 8:30 india time | 14:58 |
zaneb | oh, I forgot india had a fractional hour offset | 14:59 |
ckmvishnu | what time is it over there? | 14:59 |
zaneb | 10am here | 14:59 |
ckmvishnu | 7:30 - 8:00 am | 14:59 |
inc0_ | 4pm | 14:59 |
ckmvishnu | so your 10am | 14:59 |
ckmvishnu | is it file inc0_ | 14:59 |
zaneb | we could go earlier if that is easier | 14:59 |
ckmvishnu | fine | 14:59 |
zaneb | 9am is fine | 15:00 |
ckmvishnu | by all means. | 15:00 |
inc0_ | which day? | 15:00 |
ckmvishnu | tomorrow | 15:00 |
zaneb | tomorrow is good | 15:00 |
*** bdossant has quit IRC | 15:00 | |
inc0_ | just let me take a look at my calendar | 15:00 |
zaneb | today and Friday I have a meeting at 10 | 15:00 |
*** justin-8 has quit IRC | 15:01 | |
ckmvishnu | ok. we'll start sharp by 9:00 zane's time | 15:01 |
ckmvishnu | tomorrow | 15:01 |
inc0_ | ok, works for me as well | 15:02 |
*** julienvey has joined #heat | 15:02 | |
ckmvishnu | inc0_: great. | 15:02 |
zaneb | ok | 15:02 |
ckmvishnu | bye. | 15:02 |
inc0_ | cya ckmvishnu | 15:02 |
inc0_ | shame that Angus won't be there tho, but I guess we can handle without him | 15:03 |
*** dims has quit IRC | 15:04 | |
*** dims has joined #heat | 15:04 | |
*** bdossant has joined #heat | 15:06 | |
*** crose has joined #heat | 15:06 | |
*** julienvey has quit IRC | 15:07 | |
openstackgerrit | Steven Hardy proposed openstack/python-heatclient: Convert importutils to oslo.utils https://review.openstack.org/131828 | 15:09 |
openstackgerrit | Steven Hardy proposed openstack/python-heatclient: Remove remaining deprecated oslo-incubator modules https://review.openstack.org/131829 | 15:09 |
*** ckmvishnu has quit IRC | 15:11 | |
inc0_ | shardy, ping | 15:11 |
shardy | inc0_: hi | 15:11 |
*** prazumovsky has joined #heat | 15:12 | |
*** tellesnobrega_ has joined #heat | 15:12 | |
inc0_ | quick question, do we have any list of issues of no-downtime updates of heat | 15:12 |
inc0_ | ? | 15:12 |
shardy | inc0_: Not that I'm aware of, other than the summit etherpads with related content | 15:13 |
skraynev | zaneb: hi. I have a question about https://bugs.launchpad.net/bugs/1299259 | 15:15 |
uvirtbot | Launchpad bug 1299259 in heat "FloatingIP needs a hidden dependency on Routers" [High,Fix released] | 15:15 |
*** EricGonczer_ has quit IRC | 15:15 | |
zaneb | skraynev: I'm also in a meeting, but go ahead and I can try to answer | 15:15 |
skraynev | zaneb: ok, I agree with solution about depends_on. | 15:16 |
skraynev | zaneb: but I met that we have some kind of gap here. There are two different ways to change graph of dependencies: | 15:17 |
skraynev | zaneb: 1. normal add_dependencies in resource class, which look at template and cross resources references. | 15:18 |
*** thedodd has quit IRC | 15:18 | |
zaneb | that's not normal, it's a hack to work around broken APIs and data models | 15:18 |
skraynev | zaneb: 2. re-written add_dependencies in some resources , f.e. floating_ip | 15:18 |
*** ananta has joined #heat | 15:18 | |
skraynev | zaneb: and in the second we try to look at dependencies and find some information about stack | 15:19 |
zaneb | ah ok, yeah, the second part is the hack I was referring to above | 15:19 |
skraynev | zaneb: and it may lead to error mentioned in bug, if we have such resource (FIP) the first in the list of stack resources | 15:20 |
*** EricGonczer_ has joined #heat | 15:20 | |
skraynev | it goes to deps and finds nothing. so it decides that it has not any dependencies. | 15:21 |
zaneb | yes | 15:21 |
zaneb | there's no 'list' though; resources are unordered except for dependencies | 15:21 |
*** jprovazn has joined #heat | 15:22 | |
skraynev | zaneb: in my case the second loop for resources helps in that case | 15:22 |
skraynev | zaneb: i.e. I use already created dep graph and re-call add_dependencies again. | 15:22 |
skraynev | I am not sure, that it's valid fix :) | 15:23 |
*** ananta has quit IRC | 15:23 | |
zaneb | that should never make any difference | 15:23 |
skraynev | zaneb: in case of FIP it does | 15:23 |
skraynev | because we use not empty dict of deps | 15:24 |
skraynev | about other things - you are right | 15:24 |
*** charlesr has joined #heat | 15:24 | |
zaneb | how can it make a difference? | 15:25 |
skraynev | because on second iteration dict of dependencies is not empty and FIP looks into it and add RouterInterface in dep | 15:26 |
zaneb | oh right | 15:27 |
skraynev | on the first iteration it's not possible, because deps is empty | 15:27 |
zaneb | for d in deps.required_by(self): | 15:27 |
zaneb | that's a bug | 15:27 |
skraynev | right! | 15:27 |
*** julienvey has joined #heat | 15:27 | |
skraynev | could you note, which thing here is bug exactly ? :) | 15:27 |
skraynev | 1. for d in deps.required_by(self): | 15:28 |
skraynev | or 2. when we add_deps for first FIP? | 15:28 |
zaneb | hmm, actually that should be ok... we should already know our own dependencies at that point | 15:29 |
skraynev | I just want to understand, that I fixed in correct place | 15:29 |
*** shakamunyi has joined #heat | 15:29 | |
*** shakamunyi has quit IRC | 15:29 | |
zaneb | it would be a bug if it was assuming the dep graph was complete at that point | 15:29 |
*** vijendar has joined #heat | 15:29 | |
*** killer_prince has quit IRC | 15:29 | |
zaneb | skraynev: OH. I see what you're saying now | 15:30 |
zaneb | yes, there should be two for resource in self.stack.itervalues(): loops | 15:30 |
zaneb | sorry | 15:30 |
skraynev | ok! | 15:30 |
skraynev | cool! | 15:30 |
skraynev | thanks | 15:30 |
* zaneb is being particularly dense this morning | 15:30 | |
skraynev | zaneb: np, I understand :) | 15:31 |
* skraynev Will upload a fix soon | 15:31 | |
*** kitch has quit IRC | 15:32 | |
*** hdd has quit IRC | 15:33 | |
*** kopparam has quit IRC | 15:34 | |
*** jasond has quit IRC | 15:34 | |
*** dkusidlo has quit IRC | 15:36 | |
*** f13o has quit IRC | 15:36 | |
*** kopparam has joined #heat | 15:39 | |
*** pm90_ has quit IRC | 15:40 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Change ResourceInterface resource's resource_id https://review.openstack.org/138336 | 15:41 |
*** maishsk has joined #heat | 15:42 | |
maishsk | good evening heat gurus | 15:42 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Change ResourceInterface resource's resource_id https://review.openstack.org/138336 | 15:42 |
maishsk | is there a way to get the port_id of an newly created instance as an output parameter? | 15:43 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add attributes to RouterInterface resource https://review.openstack.org/138335 | 15:43 |
*** jstrachan_ has joined #heat | 15:43 | |
*** jstrachan has quit IRC | 15:45 | |
*** jstrachan has joined #heat | 15:45 | |
therve | maishsk, Using get_attr, 'my_server', 'my_network', 0, 'port_id' should work | 15:47 |
*** kitch has joined #heat | 15:47 | |
therve | Or something like that I think | 15:47 |
*** blues-man has joined #heat | 15:47 | |
therve | 'my_network' 0 is an IP address, so maybe something else | 15:47 |
openstackgerrit | Steven Hardy proposed openstack/heat: engine service add stack_user_project_id to create_stack interface https://review.openstack.org/118136 | 15:48 |
openstackgerrit | Steven Hardy proposed openstack/heat: Add stack_user_project_id to _create_stack RPC interface https://review.openstack.org/118137 | 15:48 |
blues-man | hello | 15:48 |
*** jstrachan_ has quit IRC | 15:49 | |
*** kopparam has quit IRC | 15:51 | |
*** EricGonczer_ has quit IRC | 15:52 | |
*** sgordon_ has quit IRC | 16:00 | |
*** sgordon has joined #heat | 16:01 | |
*** sgordon has quit IRC | 16:01 | |
*** maishsk has quit IRC | 16:02 | |
*** pas-ha has quit IRC | 16:03 | |
*** sgordon has joined #heat | 16:05 | |
*** kebray has joined #heat | 16:05 | |
inc0_ | shardy, https://review.openstack.org/#/c/116336/ ...timeout in minutes? why? | 16:07 |
*** jstrachan_ has joined #heat | 16:07 | |
*** jstrachan has quit IRC | 16:11 | |
*** jstrachan_ has quit IRC | 16:12 | |
*** jstrachan has joined #heat | 16:13 | |
*** kebray has quit IRC | 16:13 | |
*** jstracha_ has joined #heat | 16:17 | |
*** jstrachan has quit IRC | 16:18 | |
*** Marga_ has joined #heat | 16:19 | |
*** randallburt has joined #heat | 16:23 | |
*** randallburt has quit IRC | 16:24 | |
*** randallburt has joined #heat | 16:24 | |
*** tomek_adamczewsk has quit IRC | 16:27 | |
*** tellesnobrega_ has quit IRC | 16:28 | |
*** Drago has joined #heat | 16:28 | |
*** Drago has quit IRC | 16:28 | |
*** Drago has joined #heat | 16:28 | |
*** hdd has joined #heat | 16:29 | |
*** andreaf has quit IRC | 16:29 | |
*** pm90_ has joined #heat | 16:33 | |
*** EricGonczer_ has joined #heat | 16:37 | |
*** dwe_ has joined #heat | 16:40 | |
*** EricGonczer_ has quit IRC | 16:41 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Convert x.iteritems() to six.iteritems(x) https://review.openstack.org/138782 | 16:46 |
*** EricGonczer_ has joined #heat | 16:47 | |
*** Marga_ has quit IRC | 16:49 | |
*** tspatzier has quit IRC | 16:49 | |
*** blues-man has quit IRC | 16:49 | |
*** blues-man has joined #heat | 16:51 | |
*** EricGonc_ has joined #heat | 16:52 | |
*** achanda has joined #heat | 16:54 | |
*** EricGonczer_ has quit IRC | 16:56 | |
*** charlesr has quit IRC | 16:58 | |
*** prazumovsky has quit IRC | 17:00 | |
*** Drago has quit IRC | 17:01 | |
*** sgordon has quit IRC | 17:01 | |
*** mimizone_ has quit IRC | 17:01 | |
*** achanda has quit IRC | 17:02 | |
shardy | inc0_: It's a historical thing, due to the decision to start out cloning the cloudformation API | 17:04 |
shardy | There are a few AWS-naming-isms around due to that | 17:04 |
*** sgordon has joined #heat | 17:06 | |
*** kebray has joined #heat | 17:07 | |
inc0_ | ah, so we can't make it right shardy ? | 17:08 |
*** achanda has joined #heat | 17:10 | |
shardy | inc0_: We could for the internal RPC interface, I'm just not sure it's worth it as it's a backwards incompatible change | 17:10 |
inc0_ | well we could expose it everywhere besides cloudformation template resolution and translate to seconds? | 17:11 |
*** jistr|trng has quit IRC | 17:11 | |
inc0_ | I mean that just a cosmetics, but really everyone is used to timeouts in seconds | 17:11 |
shardy | inc0_: we could, but like I said, it's a backwards incompatible change | 17:12 |
inc0_ | allright, well I'll recall -1 on this one then, but we might like to think about that | 17:13 |
*** tomek_adamczewsk has joined #heat | 17:17 | |
*** fayablazer has quit IRC | 17:18 | |
*** DaveJ__ has joined #heat | 17:21 | |
*** ParsectiX has joined #heat | 17:22 | |
zaneb | inc0_: as long as it's *called* timeout_in_<units>, it doesn't really matter | 17:24 |
*** jcoufal has quit IRC | 17:30 | |
*** tomek_adamczewsk has quit IRC | 17:30 | |
*** tomek_adamczewsk has joined #heat | 17:31 | |
*** Marga_ has joined #heat | 17:32 | |
*** stannie has quit IRC | 17:33 | |
openstackgerrit | Merged openstack/heat: Pass status reason when trove misbehaves https://review.openstack.org/131563 | 17:34 |
openstackgerrit | Merged openstack/heat: Pass status reason when trove misbehaves https://review.openstack.org/131563 | 17:34 |
inc0_ | zaneb, agree, its not *that bad*, but I'd rather prefere to have everything in same unit;) but I know, its just cosmetics which can break things | 17:38 |
*** julienvey has quit IRC | 17:39 | |
shardy | Oh great, oslo.messaging has released and broke our config.sample again | 17:39 |
* shardy works on patch to remove sample config | 17:39 | |
*** blues-man has quit IRC | 17:40 | |
*** tomek_adamczewsk has quit IRC | 17:41 | |
*** tomek_adamczewsk has joined #heat | 17:41 | |
openstackgerrit | Steven Hardy proposed openstack/heat: Remove heat.config.sample file https://review.openstack.org/138800 | 17:45 |
openstackgerrit | Steven Hardy proposed openstack/heat: Remove heat.config.sample file https://review.openstack.org/138800 | 17:48 |
*** pm90_ has quit IRC | 17:49 | |
*** pm90_ has joined #heat | 17:50 | |
*** apporc has quit IRC | 17:53 | |
*** killer_prince has joined #heat | 17:58 | |
*** killer_prince is now known as lazy_prince | 17:58 | |
*** inc0__ has joined #heat | 17:59 | |
*** derekh has quit IRC | 18:00 | |
openstackgerrit | Anderson Mesquita proposed openstack/heat: Implement handle_check for Rackspace Cloud Servers https://review.openstack.org/128358 | 18:00 |
*** inc0_ has quit IRC | 18:02 | |
*** rrubins has joined #heat | 18:03 | |
*** harlowja_away is now known as harlowja_ | 18:04 | |
rrubins | What's the proper way to call Private IP address of an instance in HOT template using get_attr? | 18:10 |
*** Drago has joined #heat | 18:11 | |
*** Drago has quit IRC | 18:12 | |
*** Drago has joined #heat | 18:12 | |
*** hdd has quit IRC | 18:17 | |
*** rushiagr is now known as rushiagr_away | 18:17 | |
*** achanda has quit IRC | 18:20 | |
*** achanda has joined #heat | 18:21 | |
*** inc0_ has joined #heat | 18:25 | |
*** inc0 has joined #heat | 18:27 | |
*** inc0__ has quit IRC | 18:29 | |
*** inc0_ has quit IRC | 18:30 | |
*** hdd has joined #heat | 18:32 | |
*** ParsectiX has quit IRC | 18:38 | |
*** jstracha_ has quit IRC | 18:43 | |
openstackgerrit | Jason Dunsmore proposed openstack/heat: Use physical_resource_name to generate the resource ID https://review.openstack.org/138819 | 18:45 |
*** steel13 has quit IRC | 18:46 | |
*** tomek_adamczewsk has quit IRC | 18:48 | |
*** tomek_adamczewsk has joined #heat | 18:48 | |
*** achanda has quit IRC | 18:51 | |
*** achanda has joined #heat | 18:52 | |
*** achanda has quit IRC | 18:52 | |
*** achanda has joined #heat | 18:52 | |
*** arif-ali has quit IRC | 18:54 | |
*** sdake has quit IRC | 18:56 | |
*** arif-ali has joined #heat | 18:56 | |
*** sdake has joined #heat | 18:57 | |
*** andersonvom has quit IRC | 19:03 | |
*** xxj has quit IRC | 19:03 | |
*** xxj has joined #heat | 19:03 | |
*** metral_zzz is now known as metral | 19:04 | |
*** andersonvom has joined #heat | 19:08 | |
openstackgerrit | Dan Prince proposed openstack/heat-templates: heat-config-puppet: support hiera https://review.openstack.org/138532 | 19:08 |
*** tomek_adamczewsk has quit IRC | 19:14 | |
*** jdob has quit IRC | 19:17 | |
larsks | rrubins: this template has an example: https://github.com/larsks/heat-kubernetes/blob/master/kubenode.yaml | 19:19 |
sdake | hey larsks are you still around? | 19:22 |
larsks | Yup, here. | 19:22 |
sdake | daneyon hada pull request outstanding for you, were you going to merge it or reject it ? | 19:22 |
sdake | (just curious if we need to carry a fork for aw hile while it gets sorted out upstream) | 19:22 |
larsks | Ah, right, I will try to get that merged today. | 19:22 |
sdake | cool thanks! | 19:22 |
larsks | Sorry, distracted by upgrade docs. | 19:22 |
sdake | ya | 19:22 |
sdake | our release is next tuesday | 19:23 |
sdake | so you have a pretty large window | 19:23 |
*** sarob has joined #heat | 19:23 | |
sdake | if its not merged, I'll just post a fork for a short period | 19:23 |
sdake | we already have the announce written in facct ;-) | 19:23 |
sdake | (to the forked repo) | 19:23 |
inc0 | shardy, still here?;) | 19:25 |
*** jdob has joined #heat | 19:26 | |
*** sarob has quit IRC | 19:27 | |
openstackgerrit | Merged openstack/heat: Implement handle_check for Rackspace Cloud Servers https://review.openstack.org/128358 | 19:28 |
openstackgerrit | Dan Prince proposed openstack/heat-templates: heat-config-puppet: support hiera https://review.openstack.org/138532 | 19:30 |
*** skraynev_ has joined #heat | 19:34 | |
*** achanda has quit IRC | 19:41 | |
*** achanda has joined #heat | 19:42 | |
*** sabeen2 has quit IRC | 19:43 | |
*** sarob has joined #heat | 19:43 | |
*** sarob has quit IRC | 19:44 | |
*** achanda has quit IRC | 19:46 | |
*** serg_melikyan has quit IRC | 19:47 | |
*** serg_melikyan has joined #heat | 19:48 | |
*** pas-ha has joined #heat | 19:48 | |
*** bhi has quit IRC | 19:50 | |
*** andersonvom has quit IRC | 19:50 | |
*** sabeen has joined #heat | 19:51 | |
*** serg_melikyan has quit IRC | 19:52 | |
*** Drago has quit IRC | 19:52 | |
*** asalkeld has joined #heat | 19:56 | |
asalkeld | morning | 19:57 |
pas-ha | morning | 19:57 |
*** tspatzier has joined #heat | 19:58 | |
*** thedodd has joined #heat | 19:59 | |
*** serg_melikyan has joined #heat | 19:59 | |
*** serg_melikyan has quit IRC | 20:03 | |
*** serg_melikyan has joined #heat | 20:04 | |
*** dwe_ has quit IRC | 20:12 | |
*** hdd has quit IRC | 20:14 | |
*** kebray has quit IRC | 20:14 | |
*** kebray has joined #heat | 20:17 | |
*** hdd has joined #heat | 20:18 | |
*** serg_melikyan has quit IRC | 20:22 | |
*** serg_melikyan has joined #heat | 20:23 | |
*** DaveJ__ has quit IRC | 20:24 | |
*** serg_melikyan has quit IRC | 20:26 | |
*** serg_melikyan has joined #heat | 20:26 | |
*** GonZo2K has joined #heat | 20:30 | |
*** hdd has quit IRC | 20:32 | |
*** serg_melikyan has quit IRC | 20:32 | |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert check path to RPC https://review.openstack.org/116340 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert update_with_template to RPC https://review.openstack.org/116341 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert handle_suspend to RPC https://review.openstack.org/116338 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert handle_resume to RPC https://review.openstack.org/116339 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert create operations to use RPC https://review.openstack.org/116336 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: StackResource convert delete_nested to RPC https://review.openstack.org/116337 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: engine service add stack_user_project_id to create_stack interface https://review.openstack.org/118136 | 20:32 |
openstackgerrit | Steven Hardy proposed openstack/heat: Add stack_user_project_id to _create_stack RPC interface https://review.openstack.org/118137 | 20:32 |
*** serg_melikyan has joined #heat | 20:33 | |
openstackgerrit | Steven Hardy proposed openstack/heat: Remove heat.config.sample file https://review.openstack.org/138800 | 20:36 |
openstackgerrit | Steven Hardy proposed openstack/heat: Remove config check_uptodate test https://review.openstack.org/138850 | 20:36 |
*** serg_melikyan has quit IRC | 20:37 | |
*** hdd has joined #heat | 20:40 | |
shardy | asalkeld: ^^ pushed my latest local branch, the first two patches in the series should just need reviews, the convert* ones all need test rework I'm afraid (but tested locally OK) | 20:42 |
asalkeld | shardy, thanks - i'll get the branch fresh | 20:42 |
*** sgordon` has joined #heat | 20:48 | |
*** Putns has quit IRC | 20:50 | |
*** inc0 has quit IRC | 20:57 | |
*** skraynev_ has quit IRC | 20:57 | |
*** tspatzier has quit IRC | 20:58 | |
*** pas-ha has quit IRC | 20:59 | |
shardy | stevebaker: Hmm, I just re-ran the test and I do now see the failure | 21:01 |
shardy | let me dig into it | 21:02 |
asalkeld | shardy, you might take that bug then | 21:02 |
asalkeld | https://bugs.launchpad.net/heat/+bug/1398973 | 21:02 |
*** sarob has joined #heat | 21:02 | |
uvirtbot | Launchpad bug 1398973 in heat "test_stack_update_provider_group integration test is failing" [Undecided,New] | 21:02 |
asalkeld | if you are working on it | 21:02 |
asalkeld | i won't get to for ~ 2 hours | 21:02 |
asalkeld | i won't get to it for ~ 2 hours | 21:03 |
sdake | anyone know how heat creates the database in the test cases | 21:03 |
shardy | asalkeld: I have 30mins before my next meeting, let me see what I can do ;) | 21:03 |
asalkeld | or add some info there | 21:04 |
sdake | specifically the tables | 21:04 |
shardy | https://github.com/openstack/heat/blob/master/heat/tests/utils.py#L50 | 21:06 |
shardy | sdake: ^^ that does it I think | 21:06 |
sdake | oh db_sync | 21:06 |
sdake | interesting | 21:06 |
sdake | thanks shardy | 21:06 |
*** jtomasek has quit IRC | 21:06 | |
*** hdd has quit IRC | 21:09 | |
*** Marga_ has quit IRC | 21:11 | |
*** hdd has joined #heat | 21:11 | |
*** arif-ali has quit IRC | 21:11 | |
*** Marga_ has joined #heat | 21:12 | |
rrubins | larsks: thanks much! That worked great. {get_attr: [inst1_port, fixed_ips, 0, ip_address]} | 21:12 |
*** arif-ali has joined #heat | 21:13 | |
*** Marga_ has quit IRC | 21:17 | |
*** Marga_ has joined #heat | 21:18 | |
*** serg_melikyan has joined #heat | 21:24 | |
*** jprovazn has quit IRC | 21:25 | |
shardy | asalkeld, stevebaker: appears to be a regression in heat, bisecting now to find which commit | 21:25 |
asalkeld | ok | 21:26 |
*** sjmc7 has joined #heat | 21:36 | |
stevebaker | shardy: http://logstash.openstack.org/ should show you when it started breaking | 21:39 |
shardy | https://github.com/openstack/heat/commit/51390e8ba70cc22202e27f972455af66d3dbe779 | 21:39 |
shardy | That appears to be the problem | 21:39 |
shardy | The validation step fails trying to find provider.yaml in the files | 21:40 |
*** alexpilotti has quit IRC | 21:40 | |
*** jamielennox is now known as jamielennox|away | 21:42 | |
asalkeld | thanks shardy | 21:43 |
*** Marga_ has quit IRC | 21:43 | |
stevebaker | shardy: what do you reckon, rollback or fix? | 21:43 |
*** Marga_ has joined #heat | 21:43 | |
*** sjmc7_ has joined #heat | 21:43 | |
shardy | stevebaker: It's not that obvious a fix, so I vote revert | 21:44 |
*** Marga_ has quit IRC | 21:44 | |
asalkeld | are the files not getting passed in the validate? | 21:44 |
*** Marga_ has joined #heat | 21:44 | |
stevebaker | shardy: +1, lets quick revert then figure it out | 21:45 |
openstackgerrit | Steven Hardy proposed openstack/heat: Revert "Handle error with non existing template file" https://review.openstack.org/138867 | 21:46 |
*** sjmc7 has quit IRC | 21:47 | |
*** Marga_ has quit IRC | 21:48 | |
*** Marga__ has joined #heat | 21:48 | |
shardy | asalkeld: Possibly, not entirely sure, there's no proper traceback, just an info print, so it's a bit hard to tell | 21:49 |
asalkeld | ok, yeah - revert and make that check gating | 21:49 |
*** Marga__ has quit IRC | 21:50 | |
*** Marga_ has joined #heat | 21:50 | |
*** Marga_ has quit IRC | 21:52 | |
*** Marga_ has joined #heat | 21:52 | |
shardy | asalkeld: That does seem to be the crux of the problem, the TemplateResource inside the ResourceGroup isn't getting files for template_data at validation time | 21:56 |
asalkeld | ok | 21:57 |
*** kitch has quit IRC | 21:57 | |
*** rpothier has quit IRC | 22:00 | |
*** serg_melikyan has quit IRC | 22:01 | |
*** serg_melikyan has joined #heat | 22:01 | |
*** Marga_ has quit IRC | 22:02 | |
*** Marga_ has joined #heat | 22:02 | |
*** pm90__ has joined #heat | 22:02 | |
*** jdob has quit IRC | 22:03 | |
*** sjmc7__ has joined #heat | 22:03 | |
*** pm90_ has quit IRC | 22:04 | |
*** tellesnobrega_ has joined #heat | 22:05 | |
*** Marga_ has quit IRC | 22:06 | |
*** serg_melikyan has quit IRC | 22:06 | |
*** Marga_ has joined #heat | 22:06 | |
*** sjmc7_ has quit IRC | 22:07 | |
*** asalkeld has quit IRC | 22:08 | |
*** crose has quit IRC | 22:11 | |
*** jmckind has quit IRC | 22:11 | |
*** Marga_ has quit IRC | 22:12 | |
*** Marga_ has joined #heat | 22:12 | |
openstackgerrit | Steve Baker proposed openstack/heat-templates: Fix description indent https://review.openstack.org/138880 | 22:14 |
*** Marga_ has quit IRC | 22:15 | |
*** Marga_ has joined #heat | 22:15 | |
*** Marga_ has quit IRC | 22:16 | |
*** Marga_ has joined #heat | 22:16 | |
openstackgerrit | Merged openstack/heat: Remove config check_uptodate test https://review.openstack.org/138850 | 22:19 |
*** tomek_adamczewsk has joined #heat | 22:20 | |
*** pm90__ has quit IRC | 22:20 | |
*** asalkeld has joined #heat | 22:21 | |
*** pm90_ has joined #heat | 22:21 | |
*** EricGonc_ has quit IRC | 22:24 | |
*** pm90_ has quit IRC | 22:25 | |
*** Marga_ has quit IRC | 22:27 | |
*** Marga_ has joined #heat | 22:27 | |
*** EricGonczer_ has joined #heat | 22:29 | |
*** sjmc7__ has quit IRC | 22:35 | |
*** aweiteka has quit IRC | 22:39 | |
*** EricGonczer_ has quit IRC | 22:49 | |
*** Marga_ has quit IRC | 22:52 | |
*** kebray has quit IRC | 22:52 | |
*** Marga_ has joined #heat | 22:53 | |
*** kebray has joined #heat | 22:53 | |
*** pm90_ has joined #heat | 22:53 | |
*** sarob has quit IRC | 23:00 | |
*** jamielennox|away is now known as jamielennox | 23:09 | |
*** vijendar has quit IRC | 23:13 | |
openstackgerrit | Merged openstack/heat-templates: Fix description indent https://review.openstack.org/138880 | 23:19 |
*** shardy is now known as shardy_z | 23:19 | |
*** sarob has joined #heat | 23:47 | |
*** blomquisg has quit IRC | 23:54 | |
*** sarob has quit IRC | 23:55 | |
*** xxj has quit IRC | 23:57 | |
*** andersonvom has joined #heat | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!