| *** xmltok has left #heat | 00:00 | |
| *** cdent has quit IRC | 00:01 | |
| *** pm90_ has joined #heat | 00:04 | |
| *** serg_melikyan has joined #heat | 00:12 | |
| *** lvdongbing has joined #heat | 00:15 | |
| *** dims__ has joined #heat | 00:15 | |
| *** alexheneveld has quit IRC | 00:16 | |
| *** serg_melikyan has quit IRC | 00:16 | |
| *** alexheneveld has joined #heat | 00:18 | |
| *** dgonzalez has joined #heat | 00:19 | |
| *** dims_ has joined #heat | 00:19 | |
| *** dims__ has quit IRC | 00:23 | |
| *** dims_ has quit IRC | 00:24 | |
| *** dgonzalez has quit IRC | 00:25 | |
| *** sarob has quit IRC | 00:27 | |
| *** alexheneveld has quit IRC | 00:33 | |
| *** crose has joined #heat | 00:34 | |
| *** crose has quit IRC | 00:34 | |
| *** GonZo2K has joined #heat | 00:35 | |
| *** david-ly_ has joined #heat | 00:36 | |
| *** hdd has quit IRC | 00:38 | |
| *** hdd has joined #heat | 00:40 | |
| *** david-ly_ has quit IRC | 00:41 | |
| *** EricGonczer_ has joined #heat | 00:44 | |
| *** EricGonc_ has joined #heat | 00:47 | |
| *** EricGonczer_ has quit IRC | 00:49 | |
| *** achanda has joined #heat | 00:50 | |
| *** achanda has quit IRC | 00:55 | |
| *** achanda has joined #heat | 00:56 | |
| *** achanda has quit IRC | 01:01 | |
| *** hdd has quit IRC | 01:05 | |
| *** dgonzalez has joined #heat | 01:07 | |
| *** dgonzalez has quit IRC | 01:11 | |
| *** pm90_ has quit IRC | 01:11 | |
| *** dims__ has joined #heat | 01:24 | |
| *** alexheneveld has joined #heat | 01:25 | |
| *** Qiming has joined #heat | 01:29 | |
| *** nosnos has joined #heat | 01:50 | |
| *** rwsu has quit IRC | 02:03 | |
| *** dgonzalez has joined #heat | 02:07 | |
| *** EricGonczer_ has joined #heat | 02:08 | |
| *** EricGonc_ has quit IRC | 02:10 | |
| *** dsneddon has quit IRC | 02:11 | |
| *** dgonzalez has quit IRC | 02:12 | |
| *** dsneddon has joined #heat | 02:12 | |
| *** dims__ has quit IRC | 02:16 | |
| *** GonZo2K has quit IRC | 02:18 | |
| *** aweiteka has joined #heat | 02:20 | |
| *** Putns has quit IRC | 02:30 | |
| *** dsneddon has quit IRC | 02:32 | |
| *** dsneddon has joined #heat | 02:33 | |
| *** tiantian has joined #heat | 02:37 | |
| *** dims__ has joined #heat | 02:38 | |
| *** erkules_ has joined #heat | 02:52 | |
| *** erkules has quit IRC | 02:55 | |
| *** alexheneveld has quit IRC | 02:57 | |
| *** erkules_ is now known as erkules | 02:59 | |
| *** hdd has joined #heat | 03:04 | |
| *** dgonzalez has joined #heat | 03:09 | |
| *** dgonzalez has quit IRC | 03:13 | |
| *** dsneddon has quit IRC | 03:14 | |
| *** dims__ has quit IRC | 03:14 | |
| *** dsneddon has joined #heat | 03:15 | |
| jamielennox | is there anywhere in heat where we expect that auth_token will be present without the auth_token_info or trust_id? | 03:23 |
|---|---|---|
| jamielennox | https://github.com/openstack/heat/blob/master/heat/common/heat_keystoneclient.py#L189 | 03:23 |
| jamielennox | it's used in tests, however if it were to happen really then you've seeded the keystoneclient with the endpoint and a token, but there is no service_catalog so calls to url_for will fail | 03:23 |
| jamielennox | the main case i can think of is if the context is sent over RPC - but i'm not sure how it wouldn't have been seen | 03:27 |
| *** aweiteka has quit IRC | 03:30 | |
| *** nosnos has quit IRC | 03:34 | |
| *** EricGonczer_ has quit IRC | 03:42 | |
| *** EricGonczer_ has joined #heat | 03:45 | |
| *** EricGonczer_ has quit IRC | 03:47 | |
| *** david-lyle has joined #heat | 03:48 | |
| *** hdd has quit IRC | 03:57 | |
| *** lvdongbing has quit IRC | 03:58 | |
| asalkeld | jamielennox: i think with "heat stack-list" and other commands that do not modify | 04:02 |
| *** radez is now known as radez_g0n3 | 04:02 | |
| asalkeld | (but i'd have to check some more) | 04:03 |
| *** GonZo2K has joined #heat | 04:03 | |
| jamielennox | asalkeld: but they'll come through auth_token middleware which will catch here: https://github.com/openstack/heat/blob/master/heat/common/heat_keystoneclient.py#L173 | 04:04 |
| jamielennox | i *think* the only way it would happen (given new enough auth_token middleware) is if the context was serialized for later work or such - but does that happen without trusts? | 04:05 |
| jamielennox | ah, auth_token_info is also part of to_dict | 04:06 |
| jamielennox | maybe never | 04:06 |
| asalkeld | jamielennox: i am a bit rusty with this code | 04:07 |
| jamielennox | asalkeld: i understand how it came about - but it's a bit of a mess | 04:07 |
| asalkeld | https://github.com/openstack/heat/blob/master/heat/common/heat_keystoneclient.py#L86 | 04:07 |
| asalkeld | (yeah it is) | 04:07 |
| jamielennox | asalkeld: i'm looking at updating it, but i'm not familiar enough with heat yet to know if some of these paths are just old or used in some edge cases | 04:08 |
| asalkeld | jamielennox: the guy to talk to is shardy (as i am sure you know) | 04:09 |
| jamielennox | yep - i just always forget to come online with the europeans | 04:10 |
| asalkeld | jamielennox: i wanted to change all that user related stuff into actual resources - tho' big job | 04:11 |
| jamielennox | asalkeld: well i've put a fair bit of time into making (most) of the clients work consistently and not needing to hack tokens out of keystoneclient any more | 04:12 |
| jamielennox | asalkeld: if i can fix heat to use the plugins then it can become my todo list | 04:12 |
| asalkeld | ok, good to see you helping out | 04:13 |
| jamielennox | is the client plugins interface public? are we expecting clients to have been developed out of tree? | 04:13 |
| *** dims__ has joined #heat | 04:15 | |
| asalkeld | jamielennox: yeah they can | 04:15 |
| asalkeld | https://github.com/openstack/heat/blob/master/contrib/rackspace/rackspace/clients.py#L47 | 04:16 |
| asalkeld | like that ^ | 04:16 |
| asalkeld | tho' honestly not sure who else has | 04:16 |
| jamielennox | i don't know yet if i need to but that means I have to keep compatability with the current ClientPlugin object | 04:17 |
| jamielennox | that's fine - just good to know in advance | 04:17 |
| asalkeld | brb | 04:20 |
| *** dims__ has quit IRC | 04:20 | |
| cmyster | morning | 04:20 |
| *** tiantian has quit IRC | 04:22 | |
| asalkeld | hi cmyster | 04:23 |
| cmyster | sup | 04:23 |
| *** signed8bit has quit IRC | 04:23 | |
| cmyster | hmmm, asalkeld did you have a chance to look at this bug by any chance https://bugs.launchpad.net/heat/+bug/1407392 ? | 04:25 |
| uvirtbot | Launchpad bug 1407392 in heat "resource validation fails before a dependant resource is created" [Undecided,New] | 04:25 |
| *** david-lyle is now known as david-lyle_afk | 04:25 | |
| cmyster | IIRC you wrote some code around that area | 04:26 |
| asalkeld | i am looking at it now, hold on | 04:28 |
| *** nosnos has joined #heat | 04:29 | |
| cmyster | thanks | 04:29 |
| asalkeld | i'll make a functional test for it and post that | 04:35 |
| asalkeld | cmyster: are you using a new heat? | 04:36 |
| asalkeld | this *should* have fixed it: https://github.com/openstack/heat/commit/e1e852856047313159699f6a814135b6a6fde5e5 | 04:36 |
| cmyster | asalkeld: should be, remember a few days ago I reinstalled devstack from scratch ? | 04:37 |
| asalkeld | ok, should be fine | 04:37 |
| cmyster | and I'm using LIBS_FROM_GIT=python-heatclient in local.conf | 04:38 |
| cmyster | should, but thats from the most uptodate code | 04:38 |
| cmyster | seeing as above fix was merged a few months ago... | 04:39 |
| *** lsmola has quit IRC | 04:45 | |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Try and fail to make a reproducer for cmyster https://review.openstack.org/145125 | 04:51 |
| asalkeld | cmyster: ^ | 04:51 |
| asalkeld | that passes, see if you can see why | 04:51 |
| cmyster | mk | 04:52 |
| cmyster | as a non root use, is tox creating a virtual inv or something? its stuck on installingdeps | 04:58 |
| asalkeld | yip | 04:59 |
| *** sdake has quit IRC | 04:59 | |
| *** lsmola has joined #heat | 05:00 | |
| *** nkhare has joined #heat | 05:02 | |
| *** GonZo2K has quit IRC | 05:07 | |
| *** dgonzalez has joined #heat | 05:10 | |
| cmyster | ... | 05:13 |
| cmyster | keeps failing to install deps :) | 05:13 |
| * cmyster makes a point about slackware's pacvkages being full and not being split into -client -server -dev etc | 05:14 | |
| cmyster | packages even | 05:14 |
| asalkeld | cmyster: from just looking at it any suggestions? | 05:14 |
| *** dgonzalez has quit IRC | 05:15 | |
| cmyster | asalkeld: on the surface it seems fine to me. as it is it should find the same issue as with my test. | 05:16 |
| * cmyster wonders | 05:16 | |
| cmyster | asalkeld: mind trying my templates on that setup of yours ? | 05:16 |
| asalkeld | ok, as long as i have neutron | 05:17 |
| asalkeld | yip, i'll give it a wirl | 05:17 |
| cmyster | I think that the env file is missing from the bug report but you need to edit the mapping to where those yaml's really are on your computer | 05:18 |
| cmyster | also I had to add a new log.debug to get the output as you see it in the bug | 05:19 |
| cmyster | OK, tox passed | 05:21 |
| asalkeld | cmyster: ok i can reproduce | 05:23 |
| *** k4n0 has joined #heat | 05:24 | |
| cmyster | reading your test 'harder' it should validate that resource.validate is not validating | 05:25 |
| cmyster | wow | 05:25 |
| *** k4n0 has quit IRC | 05:25 | |
| cmyster | but yes, that it is not validating when calling stack create because the resource is not there yet | 05:26 |
| *** rakesh_hs has joined #heat | 05:26 | |
| asalkeld | cmyster: it looks like a new check that has been added to neutron | 05:27 |
| cmyster | as for tests, my WIP has found this thing, so I am just gonna continue working on it when this issue is resolved | 05:27 |
| asalkeld | (our resource ) | 05:27 |
| cmyster | indeed | 05:27 |
| cmyster | asalkeld: on a side note, to help me debug it I added a debug log in heat/engine/resource.py in 'validate'. can I add a patch for it? | 05:29 |
| cmyster | twas useful only in this case but who knows who else can find it useful | 05:30 |
| asalkeld | mmm, not very useful for a user tho' (you have access to the logs) | 05:30 |
| asalkeld | you are a special case really operator+user | 05:31 |
| cmyster | hmmm | 05:31 |
| cmyster | ok. I'll just add that when I need extra info | 05:31 |
| cmyster | (that gave me the line after the TL;DR in the bug report | 05:32 |
| cmyster | ) | 05:32 |
| asalkeld | cmyster: https://bugs.launchpad.net/heat/+bug/1407392/comments/2 | 05:39 |
| uvirtbot | Launchpad bug 1407392 in heat "resource validation fails before a dependant resource is created" [Undecided,New] | 05:39 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: make a reproducer for bug 1407392 https://review.openstack.org/145125 | 05:41 |
| uvirtbot | Launchpad bug 1407392 in heat "resource validation fails before a dependant resource is created" [Undecided,New] https://launchpad.net/bugs/1407392 | 05:41 |
| *** hdd has joined #heat | 05:41 | |
| jamielennox | asalkeld: who would be the person to talk to about heatclient | 05:50 |
| cmyster | jamielennox: just ask in general | 05:51 |
| cmyster | asalkeld: thanks for the comment. +1 that validating at creation is pointless. just needs to make an intelligent assumption | 05:52 |
| asalkeld | jamielennox: shardy knows both parts | 05:52 |
| jamielennox | well, when the SessionClient work was done there is a mess of stuff that doesn't really make sense, do you know if it's used anywhere and the compatibility i'd need | 05:52 |
| asalkeld | jamielennox: i'd look at the projects that use heatclient | 05:53 |
| asalkeld | heat, tripleo, murano, solum | 05:53 |
| *** saju_m has joined #heat | 05:58 | |
| *** unmeshg has joined #heat | 05:58 | |
| *** lvdongbing has joined #heat | 06:04 | |
| *** dims__ has joined #heat | 06:04 | |
| *** dgonzalez has joined #heat | 06:11 | |
| asalkeld | cmyster: i have a fix for you, maybe you can test? | 06:14 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Use properties.data when testing for "provided by the user" https://review.openstack.org/145125 | 06:14 |
| *** LiJiansheng has joined #heat | 06:15 | |
| *** dgonzalez has quit IRC | 06:15 | |
| *** killer_prince is now known as lazy_prince | 06:24 | |
| cmyster | back | 06:27 |
| cmyster | asalkeld: testing | 06:27 |
| *** tiantian has joined #heat | 06:31 | |
| cmyster | asalkeld: shouldn't the test itself be in scenario and not in functional ? | 06:32 |
| cmyster | talking about /functional/test_template_resource.py | 06:33 |
| asalkeld | cmyster: i'll remove that functional test | 06:33 |
| cmyster | OK | 06:33 |
| asalkeld | and just do unit tests | 06:33 |
| cmyster | I'm covering it anyway | 06:33 |
| *** tiantian has quit IRC | 06:36 | |
| *** dims__ has quit IRC | 06:38 | |
| cmyster | asalkeld: so far so good... | 06:39 |
| asalkeld | ok | 06:40 |
| cmyster | just need to run something heavier | 06:40 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Use properties.data when testing for "provided by the user" https://review.openstack.org/145125 | 06:52 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Catch exceptions from get_class in validate template https://review.openstack.org/145147 | 06:52 |
| cmyster | asalkeld: seems like a similar issue with glance. The 2nd half of the original test (where we had the neutron issues) is to boot a nova server (also in a nested template) and I set its 'image' property like so: image: {get_resource: glance_image}. this resource is not created yet and I get this error: http://paste.openstack.org/show/155701/ | 06:52 |
| asalkeld | looking | 06:53 |
| cmyster | if you need the full log or a new bug for this issue... | 06:53 |
| *** reed has quit IRC | 06:54 | |
| asalkeld | cmyster: can i see the template? | 06:55 |
| cmyster | ja, sec | 06:55 |
| cmyster | asalkeld: http://paste.openstack.org/show/155702/ | 06:56 |
| cmyster | asalkeld: if you are trying to create it you would need the rest of the templates as well... | 06:57 |
| cmyster | but those are the 'offending' ones | 06:57 |
| asalkeld | i could make a simple version | 06:58 |
| cmyster | k | 06:58 |
| asalkeld | cmyster: you becomming our thirdparty ci ;) | 06:58 |
| cmyster | asalkeld: if only I had more hours in a day... | 06:59 |
| openstackgerrit | Jamie Lennox proposed openstack/python-heatclient: Cleanup shell tests https://review.openstack.org/145148 | 06:59 |
| openstackgerrit | Jamie Lennox proposed openstack/python-heatclient: Replace httpretty with requests-mock https://review.openstack.org/145149 | 06:59 |
| cmyster | asalkeld: also this template from the latest paste did work like a month ago or so | 07:00 |
| *** jamielennox is now known as jamielennox|away | 07:03 | |
| asalkeld | cmyster: can you make a bug? | 07:04 |
| asalkeld | (or i can) | 07:04 |
| asalkeld | easy to reproduce | 07:04 |
| cmyster | for this specific issue or something more fundemental ? | 07:04 |
| asalkeld | actually, I'll do it | 07:05 |
| cmyster | I think the latest resource validatio tests need some looking into | 07:05 |
| cmyster | validation* | 07:05 |
| cmyster | asalkeld: link with bug # when done please | 07:06 |
| *** ananta has joined #heat | 07:09 | |
| asalkeld | https://bugs.launchpad.net/heat/+bug/1407877 | 07:11 |
| uvirtbot | Launchpad bug 1407877 in heat "can't create a template resource that has a ref to OS::Glance::Image" [Undecided,New] | 07:11 |
| asalkeld | that is not such a nice bug to fix | 07:13 |
| asalkeld | very general problem | 07:13 |
| asalkeld | lots of competing requirements | 07:14 |
| asalkeld | imo get_resource should not resolve in a validate | 07:15 |
| openstackgerrit | huangtianhua proposed openstack/heat: Need to call _delete_resource() anyway for sd deletion https://review.openstack.org/144593 | 07:19 |
| openstackgerrit | huangtianhua proposed openstack/heat: Make some properties required for software deployment https://review.openstack.org/144865 | 07:20 |
| *** tiantian has joined #heat | 07:23 | |
| *** miguelgrinberg has quit IRC | 07:23 | |
| *** hdd has quit IRC | 07:25 | |
| *** ifarkas has joined #heat | 07:26 | |
| *** dgonzalez has joined #heat | 07:26 | |
| *** tiantian has quit IRC | 07:33 | |
| *** tiantian has joined #heat | 07:33 | |
| *** serg_melikyan has joined #heat | 07:41 | |
| *** tiantian has quit IRC | 07:44 | |
| *** tiantian has joined #heat | 07:44 | |
| *** serg_melikyan has quit IRC | 07:44 | |
| *** Yanyanhu has joined #heat | 07:46 | |
| *** chlong has quit IRC | 07:49 | |
| *** chlong has joined #heat | 07:49 | |
| *** jprovazn has joined #heat | 07:50 | |
| *** chlong has quit IRC | 07:51 | |
| *** miguelgrinberg has joined #heat | 07:52 | |
| *** chlong has joined #heat | 07:53 | |
| *** dgonzalez has quit IRC | 07:54 | |
| *** serg_melikyan has joined #heat | 07:54 | |
| *** dgonzalez has joined #heat | 07:54 | |
| *** serg_melikyan has quit IRC | 07:59 | |
| *** dgonzalez has quit IRC | 07:59 | |
| *** julienvey has joined #heat | 08:22 | |
| openstackgerrit | huangtianhua proposed openstack/heat: Add actions AllowedValues for software_component https://review.openstack.org/145163 | 08:24 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Don't validate the nested stack if there are references https://review.openstack.org/145164 | 08:30 |
| asalkeld | cmyster: ^ | 08:33 |
| asalkeld | not so bad after all | 08:34 |
| asalkeld | taking a break bbl | 08:34 |
| *** dsneddon has quit IRC | 08:37 | |
| shardy | morning all | 08:37 |
| *** miguelgrinberg has quit IRC | 08:38 | |
| *** dsneddon has joined #heat | 08:38 | |
| shardy | asalkeld: I think that's the same problem I'm trying to solve in https://review.openstack.org/#/c/144766/ | 08:38 |
| openstackgerrit | unmesh-gurjar proposed openstack/heat: Return available info for uncreated resource https://review.openstack.org/143425 | 08:38 |
| asalkeld | shardy: lol too many patches in review | 08:40 |
| shardy | asalkeld: no worries, I was busy yesterday and didn't have time to finish off the tests, on it this morning | 08:40 |
| shardy | TripleO are hitting the same issue trying to pass a server id into a provider template containing a SoftwareDeployment | 08:41 |
| shardy | asalkeld: happy to get feedback on my patch vs your approach, I decided to just not validate the schema values for StackResource on validate() | 08:41 |
| shardy | maybe there's a better way | 08:41 |
| asalkeld | yikes Stack(yet_another_option) | 08:42 |
| shardy | shrug | 08:42 |
| cmyster | morning shardy | 08:42 |
| cmyster | asalkeld: looking | 08:42 |
| * cmyster nods... | 08:43 | |
| cmyster | asalkeld: I'll test on this patch | 08:43 |
| *** julienvey has quit IRC | 08:45 | |
| asalkeld | shardy: i don't mind either: my thinking was we want to migrate to remote stacks and we should really wait until we have all the parameters to run template validate | 08:45 |
| asalkeld | and there is also stack preview | 08:45 |
| asalkeld | groan | 08:45 |
| shardy | asalkeld: I like the cleanness of your approach, but won't needs_resolving return true if you use get_param for a property? | 08:46 |
| asalkeld | shardy: mmm, maybe but i can check on the res.INIT | 08:46 |
| asalkeld | (state) | 08:47 |
| shardy | asalkeld: we've already got a test for that | 08:47 |
| shardy | the problem is when the resource being referenced is in a different stack | 08:47 |
| asalkeld | yip, that's where i copied it from | 08:47 |
| shardy | then it's indirectly referenced via a parameter | 08:47 |
| cmyster | woot | 08:47 |
| cmyster | asalkeld: worked for my test | 08:47 |
| shardy | Maybe I need to pull your patch and test it, I'm not quite clear if/how it solves it atm | 08:47 |
| asalkeld | ok | 08:47 |
| shardy | I've got a reproducer for bug #1407100 so let me try | 08:48 |
| uvirtbot | Launchpad bug 1407100 in heat "Validation prevents SoftwareDeployments in provider templates" [High,In progress] https://launchpad.net/bugs/1407100 | 08:48 |
| shardy | happy to abandon my stuff if yours works ;) | 08:48 |
| asalkeld | shardy: ok - i'll give it some more thought after some food | 08:48 |
| shardy | asalkeld: kk, I'll dig into it some more and leave feedback on your review | 08:48 |
| *** che-arne has quit IRC | 08:49 | |
| *** dgonzalez has joined #heat | 08:49 | |
| cmyster | asalkeld: for what its worth stack-preview also seems to work well. now trying some updates | 08:49 |
| *** dgonzalez has quit IRC | 08:50 | |
| *** dgonzalez has joined #heat | 08:51 | |
| asalkeld | urg so much for supper - project 1-1 | 08:52 |
| asalkeld | https://bugs.launchpad.net/heat/+bug/1401317 | 08:53 |
| uvirtbot | Launchpad bug 1401317 in heat "resource group property validation failing in nested stack" [High,Triaged] | 08:53 |
| asalkeld | shardy: another one ^ | 08:53 |
| *** f13o has joined #heat | 08:54 | |
| shardy | asalkeld: heh, Ok thanks, I guess we can figure out the preferred fix then close the rest as dupes | 08:54 |
| *** f13o has quit IRC | 08:55 | |
| *** f13o has joined #heat | 08:55 | |
| *** dgonzalez has quit IRC | 08:55 | |
| asalkeld | songli: ping | 08:56 |
| songli | Hi Angus | 08:57 |
| asalkeld | songli: that doesn't have anything to do with decouple-nested | 08:57 |
| asalkeld | songli: that code is not really "in" | 08:57 |
| songli | oh, yes, It was just my guess | 08:58 |
| *** dsneddon has quit IRC | 08:58 | |
| shardy | asalkeld: Your fix does work for me, I just need another coffee before I understand why ;) | 08:58 |
| *** jistr has joined #heat | 08:58 | |
| asalkeld | songli: it's this patch https://github.com/openstack/heat/commit/c31c34f8dfd0919bf46a975701c139073115debc | 08:59 |
| shardy | asalkeld: happy to go with that, and help with the tests if that's what looks best to folks | 08:59 |
| shardy | songli: Are you planning to work on tests for https://review.openstack.org/#/c/145164/1, could you use some help? | 08:59 |
| shardy | songli: turns out your bug is a duplicate of one I'm working on | 09:00 |
| *** dsneddon has joined #heat | 09:00 | |
| songli | sure | 09:00 |
| songli | shardy: I will test that, if it works, I will set that duplicated | 09:00 |
| asalkeld | songli: so just grab the patch i propsed and write some tests for it | 09:00 |
| *** miguelgrinberg has joined #heat | 09:00 | |
| songli | asalkeld: ok | 09:01 |
| songli | asalkeld: thanks very much | 09:01 |
| shardy | songli: Perhaps we'll leave bug #1407877 open if we're going with asalkeld's fix, and close the others | 09:01 |
| uvirtbot | Launchpad bug 1407877 in heat "can't create a template resource that has a ref to OS::Glance::Image" [High,In progress] https://launchpad.net/bugs/1407877 | 09:01 |
| asalkeld | np, thank you | 09:01 |
| asalkeld | songli: this one: https://review.openstack.org/#/c/145164/ | 09:02 |
| songli | ok | 09:02 |
| *** julienvey has joined #heat | 09:03 | |
| *** jcoufal has joined #heat | 09:03 | |
| *** jcoufal has quit IRC | 09:03 | |
| shardy | asalkeld: I think your fix may actually relax validation too much, e.g we now fail slow if there's an invalid resource type or other structural issue in the nested template | 09:06 |
| shardy | When all we really want is to skip value validation for the properties | 09:06 |
| *** serg_melikyan has joined #heat | 09:07 | |
| *** derekh has joined #heat | 09:08 | |
| *** lvdongbing has quit IRC | 09:09 | |
| *** tiantian has quit IRC | 09:09 | |
| *** tiantian has joined #heat | 09:10 | |
| *** Yanyanhu has quit IRC | 09:10 | |
| asalkeld | shardy: i know it's important, but we should think a bit more about it | 09:10 |
| shardy | asalkeld: Yeah, left some review comments, will think about it some more - perhaps we can combine the two approaches somehow | 09:10 |
| asalkeld | another option is we generate test data for all get_attr and get_resource functions | 09:11 |
| shardy | asalkeld: really, the issue is custom constraints in all the resources | 09:11 |
| shardy | I'm not sure if that even makes a huge amount of sense, vs just validating in the parameter constraints, doesn't seem all that scalable | 09:12 |
| shardy | But if we are sticking with that, perhaps custom constraint value validation should only ever be done at runtime (e.g just before the create/update?) | 09:12 |
| *** serg_melikyan has quit IRC | 09:12 | |
| asalkeld | shardy: maybe | 09:13 |
| asalkeld | tho' custom constraint is just a fancy version of the check we used to have in nova server validate | 09:13 |
| shardy | Yeah, I guess so, just seems like possibly excessive prevalidation no it's spread to so many other resources | 09:14 |
| *** LiJiansheng has quit IRC | 09:14 | |
| *** LiJiansheng has joined #heat | 09:15 | |
| asalkeld | and no one has done the caching yet | 09:15 |
| asalkeld | say we are suposed to have all kilo-2 specs sorted out by next week! | 09:16 |
| asalkeld | cores go run off and review specs please | 09:16 |
| songli | asalkeld: your fix works for the issue 1407877 | 09:17 |
| asalkeld | :-O | 09:17 |
| asalkeld | songli: yeah, but i think we need a little more thought about it | 09:17 |
| shardy | songli: see my comments above, it solves the problem, but introduces another one | 09:18 |
| asalkeld | shardy: thinks it is swinging too much into the non-vlalidation side | 09:18 |
| songli | asalkeld: yes, I have seen the history | 09:18 |
| shardy | asalkeld: well it's gonna break tests we already have for validating stuff like resource types | 09:18 |
| shardy | I do think we need to do structural/syntax validation in the validate(), just not the values | 09:19 |
| asalkeld | shardy: or "structural/syntax/static data" | 09:20 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/heat: external link not working in heat doc https://review.openstack.org/145175 | 09:20 |
| shardy | asalkeld: Yeah, anything which isn't going to change between the validate and create basically | 09:20 |
| shardy | Let me try mangling our two patches and see what that looks like | 09:21 |
| asalkeld | ok, so when running a validate on a nested stack how do we indicate htat this parameter is provided, but it's dynamic so ignore it? | 09:21 |
| shardy | asalkeld: I'll try to lose the stack attribute if that will make you happy ;) | 09:21 |
| asalkeld | shardy: that was tonge-in-cheek | 09:21 |
| asalkeld | use it if you need it | 09:21 |
| shardy | asalkeld: we don't, which is why I just disabled all value validation in the validate() | 09:22 |
| asalkeld | oooo | 09:22 |
| asalkeld | that might be best actually, else it's too fiddly | 09:22 |
| *** f13o has quit IRC | 09:23 | |
| asalkeld | shardy: when you have time review my 10 000 test patches? | 09:23 |
| shardy | Yeah, I couldn't see any other way as at the nested stack level you don't have enough information to determing where the properties data is coming from (in the get_param case at least) | 09:23 |
| shardy | asalkeld: today, I've been on PTO and need to get back on it | 09:23 |
| asalkeld | for sure, off you go | 09:24 |
| asalkeld | says me enjoying a beer | 09:24 |
| *** andreaf has joined #heat | 09:25 | |
| *** alexheneveld has joined #heat | 09:26 | |
| *** Putns has joined #heat | 09:28 | |
| *** dkusidlo has joined #heat | 09:32 | |
| openstackgerrit | Steven Hardy proposed openstack/heat: Make StackResource less strict on initial validation https://review.openstack.org/144766 | 09:34 |
| openstackgerrit | Steven Hardy proposed openstack/heat: Add a strict_validate flag to Stacks https://review.openstack.org/144804 | 09:34 |
| shardy | asalkeld: I just mangled your patch into https://review.openstack.org/144766, it still has the ugly stack flag, but it solves the validation issue I mentioned | 09:34 |
| shardy | The challenge with removing the stack.strict_validate is we need an interface which doesn't break the plugin API | 09:35 |
| shardy | e.g we can't add an argument to validate() as some out of tree (and contrib) plugins override it | 09:35 |
| shardy | ideas welcome on how best to improve it :) | 09:36 |
| *** swygue has quit IRC | 09:36 | |
| *** pas-ha has joined #heat | 09:37 | |
| pas-ha | morning all | 09:37 |
| *** jtomasek has joined #heat | 09:39 | |
| *** dsneddon has quit IRC | 09:40 | |
| *** dsneddon has joined #heat | 09:41 | |
| *** pas-ha has quit IRC | 09:42 | |
| *** dkusidlo has quit IRC | 09:44 | |
| *** serg_melikyan has joined #heat | 09:44 | |
| *** dkusidlo has joined #heat | 09:44 | |
| *** pas-ha has joined #heat | 09:45 | |
| *** serg_melikyan has quit IRC | 09:47 | |
| *** swygue has joined #heat | 09:49 | |
| *** dgonzalez has joined #heat | 09:52 | |
| *** dkusidlo has quit IRC | 09:56 | |
| *** dgonzale_ has joined #heat | 09:58 | |
| *** dgonzalez has quit IRC | 09:58 | |
| *** Qiming has quit IRC | 09:59 | |
| *** dsneddon has quit IRC | 10:01 | |
| *** alexpilotti has joined #heat | 10:02 | |
| *** dsneddon has joined #heat | 10:02 | |
| *** dgonzale_ is now known as dgonzalez | 10:02 | |
| *** jcoufal has joined #heat | 10:04 | |
| *** dims__ has joined #heat | 10:11 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/heat: external link not working in heat doc https://review.openstack.org/145175 | 10:15 |
| *** dims__ has quit IRC | 10:17 | |
| *** pas-ha has quit IRC | 10:18 | |
| *** dgonzalez has quit IRC | 10:19 | |
| *** dsneddon has quit IRC | 10:22 | |
| *** dsneddon has joined #heat | 10:23 | |
| *** lvdongbing has joined #heat | 10:26 | |
| *** serg_melikyan has joined #heat | 10:26 | |
| *** serg_melikyan has quit IRC | 10:31 | |
| *** yassine has joined #heat | 10:32 | |
| *** Qiming has joined #heat | 10:36 | |
| *** dsneddon has quit IRC | 10:43 | |
| *** che-arne has joined #heat | 10:45 | |
| *** dsneddon has joined #heat | 10:45 | |
| *** pas-ha has joined #heat | 10:48 | |
| *** tomek_adamczewsk has joined #heat | 10:52 | |
| *** dkusidlo has joined #heat | 10:54 | |
| openstackgerrit | Miro Hroncok proposed openstack/heat-cfntools: Python 3 compatibility https://review.openstack.org/145200 | 10:59 |
| *** dkusidlo has quit IRC | 11:00 | |
| *** yassine has quit IRC | 11:01 | |
| *** julienve_ has joined #heat | 11:01 | |
| *** julienvey has quit IRC | 11:04 | |
| *** dsneddon has quit IRC | 11:04 | |
| *** dgonzalez has joined #heat | 11:05 | |
| *** dsneddon has joined #heat | 11:06 | |
| *** nkhare has quit IRC | 11:13 | |
| *** ochuprykov has joined #heat | 11:14 | |
| *** alexheneveld has quit IRC | 11:21 | |
| *** dsneddon has quit IRC | 11:26 | |
| *** dsneddon has joined #heat | 11:26 | |
| *** dgonzalez has quit IRC | 11:26 | |
| *** dgonzalez has joined #heat | 11:27 | |
| *** alexheneveld has joined #heat | 11:27 | |
| *** dgonzalez has quit IRC | 11:31 | |
| mkoderer | asalkeld: ping | 11:32 |
| asalkeld | mkoderer: hi | 11:33 |
| mkoderer | asalkeld: hi, I am currently search for some low hanging fruits bugs for a student | 11:33 |
| mkoderer | asalkeld: do you think we can take this one https://bugs.launchpad.net/heat/+bug/1355070 | 11:33 |
| uvirtbot | Launchpad bug 1355070 in heat "Can not pass empty string as parameter to provider resource" [Medium,Triaged] | 11:33 |
| asalkeld | looking | 11:34 |
| asalkeld | mkoderer: sure, the normal protocol is to ask the assignee | 11:35 |
| mkoderer | asalkeld: yeah.. but I don't find Alexey Ivanitskiy in irc | 11:36 |
| asalkeld | but it's been 5 months | 11:36 |
| mkoderer | that's why I am asking :) | 11:36 |
| *** cdent has joined #heat | 11:42 | |
| *** dims__ has joined #heat | 11:44 | |
| *** ananta has quit IRC | 11:45 | |
| *** vijayagurug has joined #heat | 11:46 | |
| openstackgerrit | unmesh-gurjar proposed openstack/heat: Added unit test for unavailable resource https://review.openstack.org/145206 | 11:46 |
| *** vijayagurug has left #heat | 11:46 | |
| *** tomek_adamczewsk has quit IRC | 11:46 | |
| *** dsneddon has quit IRC | 11:46 | |
| *** dsneddon has joined #heat | 11:47 | |
| *** tiantian has quit IRC | 11:48 | |
| *** dims__ has quit IRC | 11:49 | |
| *** dgonzale_ has joined #heat | 11:55 | |
| * asalkeld is pushing them launchpad buttons :-( | 11:57 | |
| Qiming | asalkeld, still up? | 11:57 |
| asalkeld | hi Qiming yeah, for a bit more | 11:58 |
| asalkeld | watching tv and triaging bugs | 11:58 |
| Qiming | asalkeld, please check https://review.openstack.org/#/c/144987/ and let me know if something is wrong there | 11:58 |
| *** julienve_ has quit IRC | 11:59 | |
| *** dims__ has joined #heat | 11:59 | |
| asalkeld | so Qiming maybe, but this is just removing the compatiblity hack | 12:00 |
| asalkeld | so there is no real change there | 12:00 |
| asalkeld | but what you raised might be worth a bug | 12:00 |
| Qiming | right, it looks like we need to override the 'coerce' method from sqlalchemy.ext.Mutable to make LongText itself a usable data type | 12:01 |
| *** jtomasek has quit IRC | 12:01 | |
| asalkeld | ok | 12:02 |
| *** julienvey has joined #heat | 12:03 | |
| *** viktors|afk has joined #heat | 12:04 | |
| *** unmeshg has quit IRC | 12:04 | |
| *** yassine has joined #heat | 12:12 | |
| *** nkhare has joined #heat | 12:14 | |
| *** jtomasek has joined #heat | 12:22 | |
| *** dgonzalez has joined #heat | 12:23 | |
| *** dgonzale_ has quit IRC | 12:23 | |
| *** dims__ has quit IRC | 12:25 | |
| *** dsneddon has quit IRC | 12:29 | |
| *** dsneddon has joined #heat | 12:30 | |
| openstackgerrit | Steven Hardy proposed openstack/heat: Make StackResource less strict on initial validation https://review.openstack.org/144766 | 12:39 |
| shardy | asalkeld: ^^ added a functional test which proves the fix works, and that existing tests where validation should fail still work | 12:40 |
| *** lvdongbing has quit IRC | 12:40 | |
| shardy | still open to suggestions for improvement re the stack attribute thing | 12:40 |
| asalkeld | shardy: i'll look tomorrow | 12:40 |
| asalkeld | sorting specs | 12:40 |
| shardy | asalkeld: np | 12:40 |
| *** julienvey has quit IRC | 12:41 | |
| *** lvdongbing has joined #heat | 12:41 | |
| shardy | songli: ^^ also FYI, I've merged asalkeld's fix with mine and added some tests | 12:41 |
| *** julienvey has joined #heat | 12:45 | |
| openstackgerrit | Steven Hardy proposed openstack/heat: Clarify "attributes" support status for ResourceGroup https://review.openstack.org/143156 | 12:47 |
| *** dsneddon has quit IRC | 12:50 | |
| *** dsneddon has joined #heat | 12:50 | |
| songli | shardy: thanks | 12:51 |
| *** dims__ has joined #heat | 12:57 | |
| *** nkhare has quit IRC | 13:01 | |
| *** steveg is now known as sgordon | 13:01 | |
| asalkeld | https://review.openstack.org/#/q/status:open+project:openstack/heat-specs,n,z | 13:03 |
| asalkeld | need reviews of specs for kilo-2 | 13:04 |
| asalkeld | see if we can get some more in | 13:04 |
| asalkeld | one more +2/a here: https://review.openstack.org/#/c/135076/ | 13:05 |
| *** Flcn____ has quit IRC | 13:06 | |
| *** rakesh_hs has quit IRC | 13:06 | |
| asalkeld | night all | 13:07 |
| *** asalkeld has quit IRC | 13:07 | |
| *** jprovazn has quit IRC | 13:07 | |
| *** saju_m has quit IRC | 13:08 | |
| *** dsneddon has quit IRC | 13:10 | |
| openstackgerrit | Merged openstack/heat-specs: Stack Tags https://review.openstack.org/135076 | 13:11 |
| *** dsneddon has joined #heat | 13:12 | |
| *** jdob has joined #heat | 13:13 | |
| *** aweiteka has joined #heat | 13:17 | |
| openstackgerrit | Merged openstack/heat-specs: Implement 'InstanceId' for AutoScalingGroup https://review.openstack.org/130728 | 13:18 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: ** WIP - do not approve ** Remove all tests that don't run :-O https://review.openstack.org/140250 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move template resource tests to functional https://review.openstack.org/144622 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Add missing template resource member list test https://review.openstack.org/144623 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: WIP: Move aws nested stack tests to functional tests https://review.openstack.org/144621 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Convert parser tests that need nested stacks to unit tests https://review.openstack.org/144929 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move resource group property update tests to functional https://review.openstack.org/144928 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move launch configuration into tests/autoscaling/ https://review.openstack.org/142268 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move autoscaling vpc zone test into autoscaling/ https://review.openstack.org/142981 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Make the attribute tests not need a nested stack https://review.openstack.org/144924 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move the resource group adopt test to functional https://review.openstack.org/144925 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move ResourceGroup update sequence test to functional https://review.openstack.org/144926 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Unit test name_list and black_list https://review.openstack.org/144927 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move tests for _lb_reload() into test_instance_group https://review.openstack.org/142982 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Remove duplicate autoscaling adjustment tests https://review.openstack.org/142265 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Separate the nested resources attribute tests https://review.openstack.org/144626 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move heat_autoscaling_group into tests/autoscaling/ https://review.openstack.org/142266 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Move heat_autoscaling_policy to tests/autoscaling/ https://review.openstack.org/142267 | 13:26 |
| openstackgerrit | Angus Salkeld proposed openstack/heat: Add some crud tests to nested stacks https://review.openstack.org/144624 | 13:26 |
| *** lvdongbing has quit IRC | 13:31 | |
| *** rpothier has joined #heat | 13:35 | |
| *** crose has joined #heat | 13:38 | |
| *** sgordon is now known as steveg | 13:41 | |
| *** jprovazn has joined #heat | 13:44 | |
| *** julienvey has quit IRC | 13:53 | |
| openstackgerrit | Merged openstack/heat: Gracefully fail to delete nonempty S3 Bucket https://review.openstack.org/144779 | 13:53 |
| openstackgerrit | Merged openstack/heat: Use oslo.config generator https://review.openstack.org/142418 | 13:53 |
| openstackgerrit | Merged openstack/heat: Remove MutableDict realization https://review.openstack.org/144987 | 13:53 |
| *** julienvey has joined #heat | 13:58 | |
| *** tochi_ has quit IRC | 14:00 | |
| *** nosnos has quit IRC | 14:04 | |
| *** signed8bit has joined #heat | 14:08 | |
| *** blomquisg has joined #heat | 14:09 | |
| *** LiJiansheng has quit IRC | 14:10 | |
| *** dsneddon has quit IRC | 14:13 | |
| *** dsneddon has joined #heat | 14:15 | |
| *** dkusidlo has joined #heat | 14:18 | |
| *** eoutin has joined #heat | 14:18 | |
| *** tomek_adamczewsk has joined #heat | 14:25 | |
| *** julienvey has quit IRC | 14:27 | |
| *** julienvey has joined #heat | 14:27 | |
| *** dkusidlo has quit IRC | 14:28 | |
| *** lazy_prince is now known as killer_prince | 14:28 | |
| *** sdake has joined #heat | 14:30 | |
| *** sdake has quit IRC | 14:30 | |
| *** sdake has joined #heat | 14:30 | |
| *** dsneddon has quit IRC | 14:35 | |
| *** dsneddon has joined #heat | 14:37 | |
| *** cmyster has quit IRC | 14:38 | |
| *** pm90_ has joined #heat | 14:38 | |
| *** EricGonczer_ has joined #heat | 14:40 | |
| *** pm90_ has quit IRC | 14:40 | |
| *** pm90_ has joined #heat | 14:40 | |
| *** dgonzale_ has joined #heat | 14:49 | |
| *** vijayagurug has joined #heat | 14:50 | |
| *** dkusidlo has joined #heat | 14:50 | |
| *** dgonzalez has quit IRC | 14:51 | |
| *** radez_g0n3 is now known as radez | 14:52 | |
| *** vijayagurug1 has joined #heat | 14:52 | |
| *** vijayagurug1 has quit IRC | 14:54 | |
| *** vijayagurug has quit IRC | 14:54 | |
| *** tspatzier__ has joined #heat | 14:54 | |
| *** crose has quit IRC | 14:55 | |
| *** vijayagurug has joined #heat | 14:56 | |
| *** jmckind has joined #heat | 14:56 | |
| *** jmckind has quit IRC | 14:56 | |
| *** dsneddon has quit IRC | 14:56 | |
| *** jistr has quit IRC | 14:56 | |
| *** dkusidlo has quit IRC | 14:56 | |
| *** jmckind has joined #heat | 14:56 | |
| *** jmckind has quit IRC | 14:57 | |
| *** dsneddon has joined #heat | 14:57 | |
| *** jistr has joined #heat | 14:57 | |
| *** jmckind has joined #heat | 14:57 | |
| *** jmckind has quit IRC | 14:57 | |
| *** jmckind has joined #heat | 14:58 | |
| *** jmckind has quit IRC | 14:58 | |
| *** mattt has quit IRC | 14:58 | |
| *** julienvey has quit IRC | 14:59 | |
| *** jmckind has joined #heat | 15:00 | |
| *** jmckind has quit IRC | 15:00 | |
| *** julienvey has joined #heat | 15:00 | |
| *** jmckind has joined #heat | 15:00 | |
| *** jmckind has quit IRC | 15:00 | |
| *** dgonzalez has joined #heat | 15:01 | |
| *** jmckind has joined #heat | 15:01 | |
| *** dgonzale_ has quit IRC | 15:02 | |
| *** alexheneveld has quit IRC | 15:03 | |
| *** mattt has joined #heat | 15:03 | |
| *** Qiming_ has joined #heat | 15:06 | |
| *** Qiming has quit IRC | 15:06 | |
| *** mattt has quit IRC | 15:08 | |
| *** mattt has joined #heat | 15:08 | |
| *** dgonzalez has quit IRC | 15:12 | |
| *** dgonzalez has joined #heat | 15:12 | |
| *** dgonzalez has quit IRC | 15:16 | |
| *** dsneddon has quit IRC | 15:16 | |
| *** alexheneveld has joined #heat | 15:18 | |
| *** dsneddon has joined #heat | 15:19 | |
| *** Qiming__ has joined #heat | 15:28 | |
| *** Qiming_ has quit IRC | 15:28 | |
| *** devx_ has quit IRC | 15:35 | |
| *** julienvey has quit IRC | 15:38 | |
| *** julienvey has joined #heat | 15:40 | |
| *** rm_work is now known as rm_work|away | 15:41 | |
| *** pm90_ has quit IRC | 15:42 | |
| *** jcoufal_ has joined #heat | 15:43 | |
| *** jcoufal has quit IRC | 15:47 | |
| *** rwsu has joined #heat | 15:48 | |
| *** EricGonc_ has joined #heat | 15:50 | |
| *** alexheneveld has quit IRC | 15:52 | |
| *** barra204_ has joined #heat | 15:52 | |
| *** EricGonczer_ has quit IRC | 15:53 | |
| *** barra204_ is now known as shakamunyi | 15:53 | |
| *** kebray has joined #heat | 15:54 | |
| *** ochuprykov has quit IRC | 15:54 | |
| dhellmann | it looks like the oslo.i18n 1.2.0 is breaking heat's unit tests because the wsgi module is looking at a private class inside oslo.i18n.message | 15:58 |
| *** dsneddon has quit IRC | 15:58 | |
| dhellmann | it's quite likely that's going to break the main gate tests, too | 15:58 |
| *** reed has joined #heat | 15:59 | |
| *** alexheneveld has joined #heat | 15:59 | |
| *** dsneddon has joined #heat | 15:59 | |
| *** andreaf is now known as andreaf_ | 16:00 | |
| zaneb | dhellmann: do you have a link? | 16:00 |
| dhellmann | zaneb: it's happening on my local system | 16:01 |
| dhellmann | the release *just* went up so it may not be affecting the gate yet | 16:01 |
| zaneb | ah, can you paste it maybe? | 16:01 |
| dhellmann | zaneb: I'm working on a patch | 16:01 |
| dhellmann | yeah, sure | 16:01 |
| dhellmann | http://paste.openstack.org/show/155750/ | 16:02 |
| zaneb | dhellmann: I have a call coming up but I can look at it after if you haven't fixed it already | 16:03 |
| shadower | anyone seen this error when starting the engine? http://paste.openstack.org/show/155743/ | 16:04 |
| shadower | my devstack is failing with that | 16:04 |
| shadower | (f20, up-to-date heat, devstack & os) | 16:04 |
| pas-ha | use fresh vm or uninstall and reinstall oslo.db | 16:05 |
| therve | dhellmann, It seems to work for me with oslo.i18n master | 16:05 |
| pas-ha | dhellmann, I'm seeing it in the gate already, in our integration tests | 16:06 |
| pas-ha | http://logs.openstack.org/38/144738/1/check/check-heat-dsvm-functional-mysql/7b97605/console.html | 16:06 |
| dhellmann | it looks like the problem is in the exception handling in the wsgi module | 16:07 |
| dhellmann | oslo_i18n.translate() is meant to be called without worrying about whether the argument is a Message or not -- the function checks for you | 16:07 |
| dhellmann | patch coming... | 16:07 |
| *** Qiming__ has quit IRC | 16:07 | |
| openstackgerrit | Doug Hellmann proposed openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 16:08 |
| dhellmann | therve, zaneb, pas-ha: ^^ | 16:09 |
| therve | Looking | 16:11 |
| therve | dhellmann, The first part of the patch looks weird. Is that necessary or even working? | 16:12 |
| *** julienvey has quit IRC | 16:13 | |
| dhellmann | therve: I'm not sure what you mean by "weird"? | 16:13 |
| therve | dhellmann, It seems to assume all exceptions have a message attribute | 16:13 |
| therve | dhellmann, Also it's unrelated to the error you're mentioning | 16:14 |
| dhellmann | oh, hmm, maybe I got carried away | 16:14 |
| shadower | pas-ha: thanks for the oslo.db tip, works great | 16:14 |
| openstackgerrit | Doug Hellmann proposed openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 16:14 |
| *** jistr has quit IRC | 16:15 | |
| *** pm90_ has joined #heat | 16:15 | |
| *** jistr has joined #heat | 16:16 | |
| *** jistr has quit IRC | 16:17 | |
| *** jistr has joined #heat | 16:17 | |
| therve | dhellmann, I also guess the comment just above should be revisited | 16:18 |
| *** dsneddon has quit IRC | 16:19 | |
| dhellmann | therve: do you understand what that is saying? it seems like it could all just be deleted now, but I wonder if some behavior is being altered in an unexpected way | 16:20 |
| *** dsneddon has joined #heat | 16:20 | |
| therve | dhellmann, It's a bit unclear indeed. It already seems false currently, but I'd remove it. | 16:21 |
| therve | dhellmann, The only thing I wonder is what happens with exc.detail between your patch and master | 16:21 |
| dhellmann | yeah, I don't know why the detail was being thrown away before | 16:22 |
| *** dgonzalez has joined #heat | 16:22 | |
| openstackgerrit | Doug Hellmann proposed openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 16:23 |
| dhellmann | oh, I'll bet I'm going to have to reorder these commits to get this one to land, too | 16:23 |
| *** thedodd has joined #heat | 16:24 | |
| openstackgerrit | Doug Hellmann proposed openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 16:26 |
| *** randallburt has joined #heat | 16:27 | |
| *** sabeen has joined #heat | 16:27 | |
| *** dgonzalez has quit IRC | 16:29 | |
| *** eoutin has quit IRC | 16:37 | |
| *** dsneddon has quit IRC | 16:40 | |
| *** dsneddon has joined #heat | 16:42 | |
| *** packet has joined #heat | 16:46 | |
| *** pm90_ has quit IRC | 16:47 | |
| openstackgerrit | Ryan Brown proposed openstack/heat-cfntools: Support dnf when specified or yum is missing https://review.openstack.org/142512 | 16:52 |
| *** packet has quit IRC | 16:57 | |
| *** pm90_ has joined #heat | 16:58 | |
| *** tspatzier__ has quit IRC | 16:59 | |
| *** tspatzier__ has joined #heat | 17:00 | |
| *** tspatzier__ has quit IRC | 17:00 | |
| *** thedodd has quit IRC | 17:02 | |
| *** dsneddon has quit IRC | 17:02 | |
| *** thedodd has joined #heat | 17:04 | |
| *** dsneddon has joined #heat | 17:04 | |
| *** ifarkas has quit IRC | 17:04 | |
| openstackgerrit | Ryan Brown proposed openstack/heat: Add a preview endpoint for stack updates https://review.openstack.org/122473 | 17:06 |
| *** alexheneveld has quit IRC | 17:08 | |
| *** packet has joined #heat | 17:11 | |
| *** kebray has quit IRC | 17:13 | |
| *** julienvey has joined #heat | 17:13 | |
| *** kebray has joined #heat | 17:15 | |
| *** jcoufal_ has quit IRC | 17:18 | |
| *** julienvey has quit IRC | 17:18 | |
| *** jistr has quit IRC | 17:22 | |
| *** dsneddon has quit IRC | 17:23 | |
| *** dgonzalez has joined #heat | 17:25 | |
| *** dsneddon has joined #heat | 17:25 | |
| *** dgonzalez has quit IRC | 17:30 | |
| *** dmueller has joined #heat | 17:35 | |
| *** dmueller has quit IRC | 17:41 | |
| *** serg_melikyan has joined #heat | 17:41 | |
| *** yassine has quit IRC | 17:45 | |
| *** dsneddon has quit IRC | 17:45 | |
| *** dsneddon has joined #heat | 17:47 | |
| *** alexheneveld has joined #heat | 17:52 | |
| *** che-arne has quit IRC | 17:57 | |
| *** jamielennox|away is now known as jamielennox | 18:01 | |
| *** serg_melikyan has quit IRC | 18:02 | |
| *** derekh has quit IRC | 18:04 | |
| *** jtomasek has quit IRC | 18:07 | |
| *** dsneddon has quit IRC | 18:07 | |
| *** zaneb has quit IRC | 18:08 | |
| *** dsneddon has joined #heat | 18:08 | |
| *** julienvey has joined #heat | 18:14 | |
| *** thedodd has quit IRC | 18:15 | |
| *** pm90_ has quit IRC | 18:18 | |
| *** julienvey has quit IRC | 18:18 | |
| *** pm90_ has joined #heat | 18:19 | |
| *** pas-ha has quit IRC | 18:20 | |
| *** zaneb has joined #heat | 18:20 | |
| *** serg_melikyan has joined #heat | 18:21 | |
| *** dgonzalez has joined #heat | 18:26 | |
| *** dsneddon has quit IRC | 18:29 | |
| *** dsneddon has joined #heat | 18:29 | |
| *** jistr has joined #heat | 18:30 | |
| *** dgonzalez has quit IRC | 18:30 | |
| *** jistr has quit IRC | 18:31 | |
| *** jistr has joined #heat | 18:32 | |
| *** hdd has joined #heat | 18:35 | |
| *** jtomasek has joined #heat | 18:36 | |
| *** zz_gondoi is now known as gondoi | 18:40 | |
| openstackgerrit | Doug Hellmann proposed openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 18:43 |
| *** rm_work|away is now known as rm_work | 18:44 | |
| *** alexheneveld has quit IRC | 18:46 | |
| *** killer_prince has quit IRC | 18:47 | |
| *** killer_prince has joined #heat | 18:47 | |
| *** killer_prince is now known as lazy_prince | 18:48 | |
| *** vijayagurug has quit IRC | 18:48 | |
| *** vijayagurug has joined #heat | 18:49 | |
| *** dsneddon has quit IRC | 18:49 | |
| *** packet has quit IRC | 18:49 | |
| *** reed has quit IRC | 18:49 | |
| *** dsneddon has joined #heat | 18:50 | |
| *** vijayagurug1 has joined #heat | 18:50 | |
| *** vijayagurug has quit IRC | 18:51 | |
| *** vijayagurug1 has quit IRC | 18:51 | |
| *** vijayagurug has joined #heat | 18:52 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 18:53 | |
| *** serg_melikyan has quit IRC | 18:53 | |
| *** serg_melikyan has joined #heat | 18:54 | |
| *** che-arne has joined #heat | 18:55 | |
| *** serg_melikyan has quit IRC | 18:56 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 19:00 | |
| *** pm90_ has quit IRC | 19:02 | |
| *** aweiteka has quit IRC | 19:03 | |
| *** shakamunyi has quit IRC | 19:07 | |
| *** vijayagurug has quit IRC | 19:11 | |
| *** miguelgrinberg has quit IRC | 19:12 | |
| *** vijayagurug has joined #heat | 19:13 | |
| *** rm_work is now known as rm_work|away | 19:14 | |
| *** serg_melikyan has joined #heat | 19:14 | |
| *** pm90_ has joined #heat | 19:15 | |
| *** aweiteka has joined #heat | 19:16 | |
| *** reed has joined #heat | 19:17 | |
| *** hdd has quit IRC | 19:18 | |
| *** vijayagurug has quit IRC | 19:19 | |
| *** vijayagurug has joined #heat | 19:19 | |
| *** vijayagurug has quit IRC | 19:25 | |
| *** dgonzalez has joined #heat | 19:27 | |
| *** packet has joined #heat | 19:30 | |
| *** che-arne has quit IRC | 19:31 | |
| *** dgonzalez has quit IRC | 19:31 | |
| *** cdent has quit IRC | 19:32 | |
| *** vijayagurug has joined #heat | 19:33 | |
| *** gondoi is now known as zz_gondoi | 19:35 | |
| *** vijayagurug has quit IRC | 19:36 | |
| *** vijayagurug has joined #heat | 19:37 | |
| *** thedodd has joined #heat | 19:37 | |
| *** david-lyle_afk is now known as david-lyle | 19:39 | |
| *** miguelgrinberg has joined #heat | 19:42 | |
| *** dims__ has quit IRC | 19:45 | |
| *** julienvey has joined #heat | 19:45 | |
| *** dims__ has joined #heat | 19:46 | |
| *** GonZo2K has joined #heat | 19:47 | |
| *** dims__ has quit IRC | 19:49 | |
| *** sarob has joined #heat | 19:49 | |
| *** dims__ has joined #heat | 19:49 | |
| *** julienvey has quit IRC | 19:49 | |
| *** vijayagurug1 has joined #heat | 19:52 | |
| *** vijayagurug1 has quit IRC | 19:52 | |
| *** shakamunyi has joined #heat | 19:52 | |
| *** vijayagurug has quit IRC | 19:53 | |
| *** vijayagurug has joined #heat | 19:54 | |
| *** vijayagurug has quit IRC | 19:54 | |
| *** barra204_ has joined #heat | 19:55 | |
| *** vijayagurug has joined #heat | 19:55 | |
| *** jprovazn has quit IRC | 19:55 | |
| *** vijayagurug1 has joined #heat | 19:58 | |
| *** serg_melikyan has quit IRC | 19:58 | |
| *** vijayagurug1 has quit IRC | 19:58 | |
| *** vijayagurug has quit IRC | 19:58 | |
| *** shakamunyi has quit IRC | 19:58 | |
| *** vijayagurug has joined #heat | 20:01 | |
| openstackgerrit | Ryan Brown proposed openstack/heat: Add a preview endpoint for stack updates https://review.openstack.org/122473 | 20:11 |
| *** serg_melikyan has joined #heat | 20:14 | |
| *** vijayagurug has quit IRC | 20:14 | |
| *** vijayagurug has joined #heat | 20:15 | |
| *** vijayagurug has quit IRC | 20:17 | |
| *** vijayagurug has joined #heat | 20:21 | |
| *** vijayagurug has quit IRC | 20:21 | |
| *** vijayagurug has joined #heat | 20:22 | |
| *** jistr has quit IRC | 20:25 | |
| *** dgonzalez has joined #heat | 20:27 | |
| *** tellesnobrega has quit IRC | 20:28 | |
| *** serg_melikyan has quit IRC | 20:29 | |
| *** vijayagurug has quit IRC | 20:29 | |
| *** vijayagurug has joined #heat | 20:29 | |
| *** dgonzalez has quit IRC | 20:32 | |
| *** serg_melikyan has joined #heat | 20:34 | |
| *** tellesnobrega has joined #heat | 20:41 | |
| *** hdd has joined #heat | 20:44 | |
| *** asalkeld has joined #heat | 20:46 | |
| asalkeld | morning | 20:48 |
| ryansb | morning | 20:48 |
| *** vijayagurug1 has joined #heat | 20:51 | |
| *** vijayagurug1 has quit IRC | 20:51 | |
| *** vijayagurug has quit IRC | 20:51 | |
| *** vijayagurug has joined #heat | 20:51 | |
| *** jmckind has quit IRC | 20:59 | |
| *** thedodd has quit IRC | 21:06 | |
| *** thedodd has joined #heat | 21:07 | |
| *** serg_melikyan has quit IRC | 21:13 | |
| asalkeld | https://review.openstack.org/#/c/132552/3/specs/log-guidelines.rst | 21:15 |
| *** julienvey has joined #heat | 21:16 | |
| *** vijayagurug has quit IRC | 21:20 | |
| *** vijayagurug has joined #heat | 21:21 | |
| *** Marga_ has joined #heat | 21:21 | |
| *** julienvey has quit IRC | 21:21 | |
| *** thedodd has quit IRC | 21:22 | |
| *** Drago1 has joined #heat | 21:23 | |
| *** thedodd has joined #heat | 21:23 | |
| *** vijayagurug1 has joined #heat | 21:25 | |
| *** vijayagurug has quit IRC | 21:26 | |
| *** vijayagurug1 has quit IRC | 21:26 | |
| *** vijayagurug has joined #heat | 21:27 | |
| *** dgonzalez has joined #heat | 21:28 | |
| *** dgonzalez has quit IRC | 21:33 | |
| *** barra204_ has quit IRC | 21:39 | |
| *** barra204_ has joined #heat | 21:40 | |
| *** kebray has quit IRC | 21:41 | |
| *** Drago1 has quit IRC | 21:46 | |
| *** jtomasek has quit IRC | 21:53 | |
| *** Marga_ has quit IRC | 21:57 | |
| *** Marga_ has joined #heat | 21:57 | |
| *** Marga_ has quit IRC | 21:59 | |
| *** Marga_ has joined #heat | 21:59 | |
| *** rpothier has quit IRC | 22:00 | |
| *** hdd has quit IRC | 22:05 | |
| *** vijayagurug has quit IRC | 22:08 | |
| *** vijayagurug has joined #heat | 22:09 | |
| *** barra204_ has quit IRC | 22:12 | |
| *** ccrouch1 has joined #heat | 22:13 | |
| *** barra204 has joined #heat | 22:13 | |
| *** ccrouch has quit IRC | 22:15 | |
| *** aweiteka has quit IRC | 22:21 | |
| *** blomquisg has quit IRC | 22:22 | |
| ekarlso- | when doing say a stack delete, should heat redirect ? | 22:24 |
| asalkeld | ekarlso-: if you give the name: yes | 22:25 |
| asalkeld | if you give the id, it shouldn't (afaik) | 22:26 |
| *** jdob has quit IRC | 22:26 | |
| shardy | asalkeld: I think you may have to give the fully qualified name/id to avoid the lookup | 22:28 |
| shardy | e.g heat stack-show oac4/9f1faf78-bfc1-4b95-8e19-d1a4dbf8f859 | 22:28 |
| *** dims_ has joined #heat | 22:28 | |
| *** dgonzalez has joined #heat | 22:29 | |
| asalkeld | ok | 22:29 |
| *** julienvey has joined #heat | 22:32 | |
| *** dims__ has quit IRC | 22:32 | |
| *** dgonzalez has quit IRC | 22:33 | |
| *** sarob has quit IRC | 22:34 | |
| *** julienvey has quit IRC | 22:37 | |
| *** hdd has joined #heat | 22:58 | |
| *** ccrouch has joined #heat | 23:06 | |
| *** ccrouch1 has quit IRC | 23:07 | |
| *** alexpilotti has quit IRC | 23:12 | |
| openstackgerrit | Merged openstack/heat: Do not use private classes from oslo.i18n https://review.openstack.org/145257 | 23:14 |
| *** EricGonc_ has quit IRC | 23:16 | |
| *** packet has quit IRC | 23:17 | |
| *** pm90_ has quit IRC | 23:20 | |
| *** erkules has quit IRC | 23:20 | |
| *** radez has quit IRC | 23:21 | |
| *** shardy has quit IRC | 23:21 | |
| *** ryansb has quit IRC | 23:21 | |
| *** tsufiev has quit IRC | 23:21 | |
| *** IgorYozhikov has quit IRC | 23:21 | |
| *** manfred has quit IRC | 23:21 | |
| *** mkoderer has quit IRC | 23:21 | |
| *** reed has quit IRC | 23:21 | |
| *** dsneddon has quit IRC | 23:21 | |
| *** jpeeler has quit IRC | 23:21 | |
| *** nijaba has quit IRC | 23:21 | |
| *** DandyPandy has quit IRC | 23:21 | |
| *** bnemec has quit IRC | 23:21 | |
| *** cody-somerville has quit IRC | 23:21 | |
| *** gpocentek has quit IRC | 23:21 | |
| *** aignatov has quit IRC | 23:21 | |
| *** SergeyLukjanov has quit IRC | 23:21 | |
| *** shadower has quit IRC | 23:21 | |
| *** therve has quit IRC | 23:21 | |
| *** ekarlso- has quit IRC | 23:21 | |
| *** DinaBelova has quit IRC | 23:21 | |
| *** Chinorro has quit IRC | 23:21 | |
| *** jasond` has quit IRC | 23:21 | |
| *** IgorYozhikov has joined #heat | 23:21 | |
| *** manfred has joined #heat | 23:21 | |
| *** mkoderer has joined #heat | 23:21 | |
| *** ryansb has joined #heat | 23:21 | |
| *** tsufiev has joined #heat | 23:21 | |
| *** radez has joined #heat | 23:22 | |
| *** reed has joined #heat | 23:22 | |
| *** jpeeler has joined #heat | 23:22 | |
| *** nijaba has joined #heat | 23:22 | |
| *** DandyPandy has joined #heat | 23:22 | |
| *** bnemec has joined #heat | 23:22 | |
| *** cody-somerville has joined #heat | 23:22 | |
| *** gpocentek has joined #heat | 23:22 | |
| *** aignatov has joined #heat | 23:22 | |
| *** SergeyLukjanov has joined #heat | 23:22 | |
| *** shadower has joined #heat | 23:22 | |
| *** therve has joined #heat | 23:22 | |
| *** ekarlso- has joined #heat | 23:22 | |
| *** DinaBelova has joined #heat | 23:22 | |
| *** Chinorro has joined #heat | 23:22 | |
| *** jasond` has joined #heat | 23:22 | |
| *** boris-42 has quit IRC | 23:24 | |
| *** boris-42 has joined #heat | 23:26 | |
| *** dgonzalez has joined #heat | 23:29 | |
| *** vijayagurug has quit IRC | 23:33 | |
| *** wirehead_ has quit IRC | 23:33 | |
| *** dgonzalez has quit IRC | 23:34 | |
| *** wirehead_ has joined #heat | 23:34 | |
| *** vijayagurug has joined #heat | 23:35 | |
| *** tochi has joined #heat | 23:35 | |
| *** alexheneveld has joined #heat | 23:38 | |
| *** thedodd has quit IRC | 23:42 | |
| *** barra204 has quit IRC | 23:43 | |
| *** GonZoPT has joined #heat | 23:44 | |
| *** GonZo2K has quit IRC | 23:45 | |
| *** dims_ has quit IRC | 23:48 | |
| *** dims__ has joined #heat | 23:53 | |
| *** erkules has joined #heat | 23:55 | |
| *** shardy has joined #heat | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!