*** mwheckmann has quit IRC | 00:00 | |
*** serg_melikyan has joined #heat | 00:01 | |
*** mixos has quit IRC | 00:05 | |
*** daneyon_ has joined #heat | 00:15 | |
*** pm90_ has joined #heat | 00:16 | |
*** daneyon has quit IRC | 00:18 | |
*** daneyon_ has quit IRC | 00:21 | |
*** tobe has joined #heat | 00:32 | |
*** Qiming has joined #heat | 00:33 | |
*** alexpilotti has joined #heat | 00:34 | |
*** tobe has quit IRC | 00:36 | |
asalkeld | stevebaker: sorry i missed the meeting, i got it 1 hour too late :-( , I'll get with the new slot | 00:44 |
---|---|---|
stevebaker | asalkeld: heh, np | 00:44 |
stevebaker | asalkeld: do you think you'll get a chance to refresh https://review.openstack.org/#/c/180022 ? | 00:45 |
asalkeld | sure, i'll check if the dependant one is rebased | 00:45 |
asalkeld | it is - sure | 00:46 |
*** nkhare has quit IRC | 00:48 | |
*** kitch_ has joined #heat | 00:50 | |
*** mwheckmann has joined #heat | 00:51 | |
openstackgerrit | Angus Salkeld proposed openstack/heat: Add the convergence resource replacement logic https://review.openstack.org/180022 | 00:52 |
*** jruano has quit IRC | 00:58 | |
*** Berezin has joined #heat | 01:03 | |
*** Berezin has left #heat | 01:05 | |
*** LiJiansheng has joined #heat | 01:06 | |
*** pm90_ has quit IRC | 01:07 | |
*** alanf-mc_ has quit IRC | 01:16 | |
*** zzxwill has quit IRC | 01:18 | |
*** tobe has joined #heat | 01:18 | |
*** serg_melikyan has quit IRC | 01:24 | |
*** sdake_ has quit IRC | 01:28 | |
*** dims_ has quit IRC | 01:35 | |
*** Yanyanhu has joined #heat | 01:36 | |
*** sparr has quit IRC | 01:37 | |
*** sparr has joined #heat | 01:39 | |
*** mixos has joined #heat | 01:41 | |
*** alexpilotti has quit IRC | 01:42 | |
*** erkules has quit IRC | 01:50 | |
*** erkules has joined #heat | 01:51 | |
*** serg_melikyan has joined #heat | 01:55 | |
*** gokrokve has joined #heat | 02:00 | |
*** huangtianhua has joined #heat | 02:01 | |
openstackgerrit | Miguel Grinberg proposed openstack/heat: Avoid crash when registering resources https://review.openstack.org/186237 | 02:07 |
*** liusheng has quit IRC | 02:08 | |
*** pm90_ has joined #heat | 02:08 | |
*** liusheng has joined #heat | 02:08 | |
*** hdd has quit IRC | 02:11 | |
*** gokrokve has quit IRC | 02:17 | |
*** gokrokve has joined #heat | 02:23 | |
*** mwheckmann has quit IRC | 02:26 | |
*** gokrokve has quit IRC | 02:29 | |
*** gokrokve has joined #heat | 02:30 | |
*** gokrokve has quit IRC | 02:31 | |
*** alanf-mc has joined #heat | 02:32 | |
*** hdd has joined #heat | 02:34 | |
*** Raj1 has joined #heat | 02:36 | |
*** serg_melikyan has quit IRC | 02:39 | |
*** LiJiansheng has quit IRC | 02:39 | |
*** rwsu has quit IRC | 02:46 | |
*** pm90_ has quit IRC | 02:53 | |
*** pm90_ has joined #heat | 02:54 | |
*** zhonghua-lee has joined #heat | 02:54 | |
*** alanf-mc_ has joined #heat | 02:59 | |
*** alanf-mc has quit IRC | 03:01 | |
*** alanf-mc_ has quit IRC | 03:01 | |
*** ashishjain has joined #heat | 03:03 | |
*** Raj1 has quit IRC | 03:03 | |
*** alanf-mc has joined #heat | 03:03 | |
*** Raj1 has joined #heat | 03:03 | |
*** cody-somerville has joined #heat | 03:05 | |
*** pm90_ has quit IRC | 03:15 | |
*** Raj1 has quit IRC | 03:17 | |
*** achanda has joined #heat | 03:22 | |
*** spzala has quit IRC | 03:24 | |
*** pm90_ has joined #heat | 03:35 | |
*** pm90_ has quit IRC | 03:35 | |
*** jfluhmann has joined #heat | 03:43 | |
openstackgerrit | huangtianhua proposed openstack/heat: Skip decrypt parameters when get from db object https://review.openstack.org/186249 | 03:50 |
*** ashishjain has quit IRC | 03:52 | |
*** zhonghua-lee has quit IRC | 04:00 | |
*** achanda has quit IRC | 04:01 | |
*** cody-somerville has quit IRC | 04:02 | |
*** sergmelikyan has quit IRC | 04:05 | |
*** jaison has joined #heat | 04:05 | |
*** kitch_ has quit IRC | 04:11 | |
openstackgerrit | Miguel Grinberg proposed openstack/heat: Include support status in resource schema https://review.openstack.org/186252 | 04:15 |
*** Murali_ has joined #heat | 04:27 | |
*** Drago has quit IRC | 04:28 | |
ramishra | stevebaker: hi around? | 04:29 |
*** ananta_ has joined #heat | 04:29 | |
*** Murali__ has joined #heat | 04:30 | |
*** Murali__ is now known as Murali | 04:30 | |
ramishra | Would you please have a look at https://review.openstack.org/#/c/185400/ when you have a few mins to spare. | 04:33 |
*** Murali_ has quit IRC | 04:33 | |
*** kebray_ has joined #heat | 04:35 | |
*** tobe has quit IRC | 04:36 | |
*** KanagarajM has joined #heat | 04:39 | |
*** kebray has quit IRC | 04:39 | |
*** sdake has joined #heat | 04:39 | |
*** mixos has left #heat | 04:39 | |
KanagarajM | good morning all ! | 04:40 |
*** hdd has quit IRC | 04:46 | |
*** hdd has joined #heat | 04:46 | |
KanagarajM | miguelgrinberg: hi | 04:46 |
*** openstackgerrit has quit IRC | 04:50 | |
*** sdake_ has joined #heat | 04:50 | |
*** openstackgerrit has joined #heat | 04:50 | |
*** sdake has quit IRC | 04:54 | |
*** Murali has quit IRC | 04:54 | |
*** hdd has quit IRC | 05:00 | |
*** gokrokve has joined #heat | 05:03 | |
*** KanagarajM has quit IRC | 05:04 | |
*** hdd has joined #heat | 05:07 | |
*** hdd has quit IRC | 05:08 | |
*** gokrokve has quit IRC | 05:10 | |
*** gokrokve has joined #heat | 05:10 | |
*** dsneddon has quit IRC | 05:11 | |
*** gokrokve has quit IRC | 05:11 | |
*** gokrokve has joined #heat | 05:12 | |
*** skraynev_ has joined #heat | 05:14 | |
*** gokrokve has quit IRC | 05:17 | |
*** gokrokve has joined #heat | 05:18 | |
*** jaison has quit IRC | 05:18 | |
*** ananta_ has quit IRC | 05:19 | |
*** ananta_ has joined #heat | 05:19 | |
*** gokrokve has quit IRC | 05:23 | |
*** huangtianhua has quit IRC | 05:24 | |
*** achanda has joined #heat | 05:38 | |
sdake_ | zaneb awake? | 05:39 |
sdake_ | or stevebaker? | 05:39 |
*** harlowja_ has quit IRC | 05:40 | |
*** gokrokve has joined #heat | 05:41 | |
*** vijayagurug has joined #heat | 05:48 | |
*** nkhare has joined #heat | 05:50 | |
*** nihilifer has joined #heat | 05:54 | |
*** skraynev_ has quit IRC | 05:56 | |
*** multi_io has quit IRC | 05:59 | |
*** multi_io has joined #heat | 06:01 | |
*** tobe has joined #heat | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Imported Translations from Transifex https://review.openstack.org/186275 | 06:05 |
*** nkhare has quit IRC | 06:07 | |
*** jtomasek has joined #heat | 06:07 | |
*** rakesh_hs has joined #heat | 06:08 | |
*** skraynev_ has joined #heat | 06:09 | |
*** huangtianhua has joined #heat | 06:15 | |
openstackgerrit | Qiming Teng proposed openstack/heat: Squash Havana migration scripts https://review.openstack.org/186291 | 06:18 |
*** hdd has joined #heat | 06:24 | |
*** nkhare has joined #heat | 06:27 | |
*** LimorStotland has joined #heat | 06:30 | |
*** jprovazn has joined #heat | 06:32 | |
*** tspatzier has joined #heat | 06:39 | |
*** alanf-mc has quit IRC | 06:43 | |
Qiming | hi, anyone saw this error when runnting test cases? | 06:48 |
Qiming | Traceback (most recent call last): | 06:48 |
Qiming | File "heat/tests/common.py", line 80, in setUp | 06:48 |
Qiming | self.warnings = self.useFixture(fixtures.WarningsCapture()) | 06:48 |
Qiming | AttributeError: 'module' object has no attribute 'WarningsCapture' | 06:48 |
*** LimorStotland has quit IRC | 06:49 | |
cmyster | morning | 06:50 |
*** pas-ha has joined #heat | 06:51 | |
pas-ha | morning all | 06:51 |
*** cmyster has quit IRC | 06:52 | |
*** cmyster has joined #heat | 06:53 | |
*** cmyster has quit IRC | 06:53 | |
*** cmyster has joined #heat | 06:53 | |
*** erkules has quit IRC | 07:06 | |
*** erkules has joined #heat | 07:06 | |
sdake_ | hey qiming it was a pleasure to meet you | 07:07 |
*** cmyster has quit IRC | 07:07 | |
Qiming | sdake_, my honor, sir, :) | 07:07 |
sdake_ | say areo u a python wizard | 07:07 |
sdake_ | I am working on a simple deserializer | 07:08 |
sdake_ | atm it uses eval, which is evil | 07:08 |
sdake_ | I am un-evaling it :) | 07:08 |
sdake_ | TypeError: 'V1beta3_Pod' object has no attribute '__getitem__' | 07:08 |
sdake_ | I ge tthis error | 07:08 |
sdake_ | shoudln't object have a defautl getitem attribute builtin? | 07:08 |
Qiming | __getitem__ is only available for collections? | 07:09 |
sdake_ | here is my code | 07:09 |
sdake_ | http://ur1.ca/mnquc -> http://paste.fedoraproject.org/226400/96984143 | 07:09 |
sdake_ | swaggerTypes is a dictionary | 07:10 |
sdake_ | qiming nevermind sorted it out | 07:12 |
Qiming | seems my_pod is not a collection | 07:12 |
*** Murali_ has joined #heat | 07:14 | |
openstackgerrit | Sergey Kraynev proposed openstack/python-heatclient: Add functional tests from Tempest https://review.openstack.org/180217 | 07:17 |
openstackgerrit | Sergey Kraynev proposed openstack/python-heatclient: Add first pass at post_test_hook for functional https://review.openstack.org/180539 | 07:17 |
*** pbrooko has joined #heat | 07:25 | |
*** zhonghua-lee has joined #heat | 07:27 | |
openstackgerrit | Sergey Kraynev proposed openstack/python-heatclient: Add functional tests from Tempest https://review.openstack.org/180217 | 07:27 |
openstackgerrit | Sergey Kraynev proposed openstack/python-heatclient: Add first pass at post_test_hook for functional https://review.openstack.org/180539 | 07:27 |
*** pbrooko_ has joined #heat | 07:28 | |
*** ifarkas has joined #heat | 07:29 | |
*** pbrooko has quit IRC | 07:30 | |
*** tspatzier has quit IRC | 07:30 | |
*** pbrooko has joined #heat | 07:30 | |
*** nkhare has quit IRC | 07:32 | |
*** pbrooko_ has quit IRC | 07:32 | |
*** LimorStotland has joined #heat | 07:33 | |
*** hdd has quit IRC | 07:35 | |
*** alexheneveld has joined #heat | 07:38 | |
*** pbrooko has quit IRC | 07:42 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Move check_active to nova client plugin https://review.openstack.org/186063 | 07:51 |
*** jistr has joined #heat | 07:54 | |
*** pbrooko has joined #heat | 07:55 | |
*** pbrooko_ has joined #heat | 07:57 | |
*** pbrooko has quit IRC | 08:00 | |
*** mgershen has joined #heat | 08:01 | |
*** pbrooko_ has quit IRC | 08:02 | |
*** dims_ has joined #heat | 08:02 | |
*** tspatzier has joined #heat | 08:05 | |
*** yassine_ has joined #heat | 08:07 | |
*** dims_ has quit IRC | 08:08 | |
*** shardy has joined #heat | 08:18 | |
openstackgerrit | huangtianhua proposed openstack/heat-specs: Support define checks for resource in template https://review.openstack.org/186316 | 08:37 |
*** pbrooko has joined #heat | 08:43 | |
*** nkhare has joined #heat | 08:43 | |
openstackgerrit | huangtianhua proposed openstack/heat: Support actions for remote stacks https://review.openstack.org/186321 | 08:45 |
*** pbrooko has quit IRC | 08:46 | |
openstackgerrit | huangtianhua proposed openstack/heat-specs: Support define checks for resource in template https://review.openstack.org/186316 | 08:47 |
*** pbrooko has joined #heat | 08:48 | |
*** mkoderer has quit IRC | 08:50 | |
*** mkoderer has joined #heat | 08:53 | |
*** sdake has joined #heat | 08:58 | |
*** derekh has joined #heat | 09:00 | |
*** sdake_ has quit IRC | 09:01 | |
*** sdake_ has joined #heat | 09:04 | |
*** pbrooko has quit IRC | 09:04 | |
*** sdake has quit IRC | 09:07 | |
*** xek_ is now known as xek | 09:12 | |
*** pbrooko has joined #heat | 09:13 | |
openstackgerrit | Merged openstack/heat: Add validation for parameter_groups https://review.openstack.org/183466 | 09:13 |
*** pbrooko has quit IRC | 09:14 | |
*** pbrooko has joined #heat | 09:14 | |
*** pbrooko has quit IRC | 09:14 | |
openstackgerrit | Merged openstack/heat: Check for encrypted_param_names key in environment https://review.openstack.org/184321 | 09:19 |
Qiming | asalkeld, there? | 09:19 |
*** e0ne has joined #heat | 09:22 | |
*** Yanyanhu has quit IRC | 09:26 | |
sirushti | does anyone know if osprofiler still works in Heat? | 09:27 |
*** e0ne is now known as e0ne_ | 09:30 | |
*** e0ne_ has quit IRC | 09:35 | |
*** pbrooko has joined #heat | 09:41 | |
*** LiJiansheng has joined #heat | 09:41 | |
*** pbrooko has quit IRC | 09:42 | |
*** pbrooko has joined #heat | 09:43 | |
d0ugal | shardy: Any idea how I've made this happen? http://paste.openstack.org/show/241829/ | 09:55 |
*** yassine_ has quit IRC | 09:56 | |
*** e0ne has joined #heat | 09:57 | |
*** pbrooko_ has joined #heat | 09:57 | |
*** dims_ has joined #heat | 09:57 | |
*** LimorStotland has quit IRC | 09:58 | |
d0ugal | shadower: ^ | 09:58 |
d0ugal | I cant even delete it, I get the same error with `heat stack-delete overcloud` | 09:59 |
openstackgerrit | Sirushti Murugesan proposed openstack/heat: Convergence: Check-Resource skeleton https://review.openstack.org/167324 | 09:59 |
*** pbrooko has quit IRC | 10:00 | |
d0ugal | It could possibly have happened because I think deployed THT and then done a Tuskar stack update afterwards? | 10:00 |
shardy | d0ugal: Hmm, yeah it looks a bug, can you check the heat-engine logs for errors please? | 10:02 |
shardy | Even if the update broke something it should at worst go UPDATE_FAILED, not break like that | 10:02 |
shardy | there's probably a fat backtrace from heat-engine each time you try list/delete which may give some more clues | 10:03 |
shardy | did the heat-engine get killed or restarted during the stack-update? | 10:03 |
d0ugal | shardy: not that I'm aware of | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add additional info for DEPRECATED objects https://review.openstack.org/168868 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add info about available since to docs https://review.openstack.org/185043 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add since parameter to SupportStatus https://review.openstack.org/185042 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add documentation page for Support Status https://review.openstack.org/168816 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add previous_status to SupportStatus https://review.openstack.org/186339 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add HIDDEN status to SupportStatus https://review.openstack.org/186340 | 10:04 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Update SupportStatuses for resources/props/attrs https://review.openstack.org/186341 | 10:04 |
d0ugal | shadower: Just digging through the logs | 10:05 |
*** prazumovsky has quit IRC | 10:06 | |
d0ugal | shadower: http://paste.openstack.org/show/241860/ | 10:08 |
d0ugal | sorry, shardy they were for you | 10:08 |
d0ugal | That;s the full heat-engine output from running stack-list | 10:08 |
d0ugal | The third from the bottom seems relevant, but no sign of a stacktrace | 10:08 |
shardy | d0ugal: Hmm, yeah that's not helping much unfortunately | 10:10 |
shardy | Feel free to raise a bug, if you have any idea how to reproduce it then we'll stand some chance of investigating :) | 10:11 |
*** Qiming_ has joined #heat | 10:11 | |
shardy | also if you have earlier logs check out if there's a backtrace during the stack-update | 10:11 |
shardy | something has clearly gone very wrong to end up in that state, either we failed to validate the stack on update or we've stored it in an inconsistent state | 10:12 |
*** Qiming has quit IRC | 10:12 | |
d0ugal | shardy: I'll grep the previous logs | 10:13 |
*** Qiming_ has quit IRC | 10:16 | |
d0ugal | shardy: This is the only sign I can see of a traceback - http://paste.openstack.org/show/241861/ | 10:16 |
d0ugal | 3rd bottom line, nested in the JSON | 10:16 |
*** LimorStotland has joined #heat | 10:17 | |
d0ugal | shardy: Otherwise I can't see anything, I'd be happy to delete my stack and cut my losses. However, I get the same error with stack-delete! | 10:17 |
*** ifarkas has quit IRC | 10:21 | |
d0ugal | shardy: This looks somewhat interesting. http://paste.openstack.org/show/241882/ | 10:22 |
*** zhonghua-lee has quit IRC | 10:22 | |
*** kbyrne has quit IRC | 10:34 | |
kairat_kushaev | shardy: Hello, I read this bug: https://bugs.launchpad.net/heat/+bug/1306294 | 10:37 |
openstack | Launchpad bug 1306294 in tripleo "Heat fails to re-authenticate when faced with authentication failure during stack operations" [High,In progress] - Assigned to Robert Collins (lifeless) | 10:37 |
kairat_kushaev | shardy: are there something updates on this bug? I mean: do we have any other option how to re-authentificate now? | 10:38 |
*** sdake_ has quit IRC | 10:38 | |
*** e0ne is now known as e0ne_ | 10:39 | |
shardy | kairat_kushaev: No, it's still pending - for the TripleO use-case it's been worked around by setting the token expiry to 4 hours on the undercloud | 10:39 |
kairat_kushaev | shardy: Right now we are trying to deploy huge instances on scale and heat tests fail with unauthorized because it tooks more then | 10:40 |
shardy | kairat_kushaev: The work jamielennox has been doing moving heat to auth plugins will probably help us complete that during Liberty | 10:40 |
shardy | kairat_kushaev: The best workaround right now is probably to extend the token expiry timeout | 10:41 |
kairat_kushaev | shardy: How about trusts? | 10:41 |
shardy | yes, the eventual solution will involve switching to a new token using the stored trust_id heat has | 10:41 |
shardy | The code just doesn't support that yet | 10:41 |
*** kbyrne has joined #heat | 10:41 | |
*** e0ne_ has quit IRC | 10:45 | |
*** higgins has quit IRC | 10:47 | |
*** smccully has quit IRC | 10:50 | |
*** higgins has joined #heat | 10:51 | |
*** higgins has quit IRC | 10:53 | |
*** e0ne has joined #heat | 10:53 | |
*** higgins has joined #heat | 10:57 | |
*** yassine_ has joined #heat | 11:06 | |
*** jfluhmann has quit IRC | 11:06 | |
*** yassine_ has quit IRC | 11:06 | |
*** yassine_ has joined #heat | 11:07 | |
*** e0ne is now known as e0ne_ | 11:11 | |
*** e0ne_ is now known as e0ne | 11:12 | |
*** nihilifer has quit IRC | 11:16 | |
*** dims_ has quit IRC | 11:16 | |
*** ananta_ has quit IRC | 11:16 | |
*** kebray_ has quit IRC | 11:16 | |
*** dims_ has joined #heat | 11:17 | |
*** higgins has quit IRC | 11:19 | |
*** e0ne is now known as e0ne_ | 11:20 | |
*** higgins has joined #heat | 11:21 | |
*** zhonghua-lee has joined #heat | 11:22 | |
*** higgins has quit IRC | 11:22 | |
*** huangtianhua has quit IRC | 11:22 | |
*** pbrooko_ has quit IRC | 11:22 | |
*** higgins has joined #heat | 11:23 | |
*** e0ne_ has quit IRC | 11:25 | |
*** dims_ has quit IRC | 11:28 | |
*** dims_ has joined #heat | 11:28 | |
*** tobe has quit IRC | 11:30 | |
*** Qiming has joined #heat | 11:32 | |
*** dims_ has quit IRC | 11:33 | |
*** e0ne has joined #heat | 11:34 | |
*** mwheckmann has joined #heat | 11:37 | |
*** higgins has quit IRC | 11:37 | |
*** openstackgerrit has quit IRC | 11:39 | |
*** pbrooko has joined #heat | 11:39 | |
*** openstackgerrit has joined #heat | 11:39 | |
*** dims_ has joined #heat | 11:39 | |
*** tobe has joined #heat | 11:39 | |
*** mwheckmann has quit IRC | 11:40 | |
*** higgins has joined #heat | 11:42 | |
*** radez_g0n3 is now known as radez | 11:43 | |
*** higgins has quit IRC | 11:43 | |
*** higgins has joined #heat | 11:45 | |
*** higgins has quit IRC | 11:49 | |
*** higgins has joined #heat | 11:49 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat: Convergence resource operations https://review.openstack.org/163132 | 11:52 |
*** zhonghua-lee has quit IRC | 11:56 | |
*** achanda has quit IRC | 11:57 | |
*** pbrooko has quit IRC | 12:08 | |
*** inc0 has joined #heat | 12:10 | |
inc0 | hello | 12:10 |
*** EricGonczer_ has joined #heat | 12:14 | |
*** inc0 has quit IRC | 12:16 | |
*** kitch has joined #heat | 12:16 | |
*** pfreund has joined #heat | 12:17 | |
*** EricGonczer_ has quit IRC | 12:20 | |
*** higgins has quit IRC | 12:21 | |
*** higgins has joined #heat | 12:23 | |
*** zhonghua-lee has joined #heat | 12:24 | |
*** spzala has joined #heat | 12:26 | |
openstackgerrit | Rakesh H S proposed openstack/heat: Removes deprecated metadata property from Resource class https://review.openstack.org/174360 | 12:26 |
*** LimorStotland has quit IRC | 12:27 | |
*** pbrooko has joined #heat | 12:27 | |
*** ifarkas has joined #heat | 12:31 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Stop monkey-patching global namespace https://review.openstack.org/186362 | 12:31 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Do not pass rich objects on server's resume https://review.openstack.org/186363 | 12:31 |
*** e0ne is now known as e0ne_ | 12:32 | |
*** nkhare has quit IRC | 12:33 | |
*** inc0 has joined #heat | 12:39 | |
therve | ricolin, I just closed the bug you opened as duplicate, let me know if it's incorrect | 12:41 |
*** e0ne_ has quit IRC | 12:43 | |
inc0 | ryansb, are you around by any chance? | 12:43 |
ryansb | inc0: yup, I'm about | 12:44 |
inc0 | about default unlimited stacks | 12:44 |
inc0 | any chances you could rething this? I don't have problem with keeping 1000 resources default | 12:44 |
ryansb | so you just want to add an option to remove the limit entirely, but leave the default? | 12:45 |
*** LimorStotland has joined #heat | 12:46 | |
*** inc0_ has joined #heat | 12:46 | |
inc0_ | sorry, vpn died | 12:46 |
inc0_ | I'm thinking of leaving 1000, but removing nested stack counting | 12:47 |
*** Raj1 has joined #heat | 12:47 | |
*** e0ne has joined #heat | 12:47 | |
inc0_ | since decouple nested, this will not affect memory that much as it used to | 12:47 |
inc0_ | what do you think about this solution? | 12:48 |
ryansb | It depends on how operators use this limit. If they just use it for "we don't want to OOM" then sure | 12:48 |
*** inc0 has quit IRC | 12:48 | |
ryansb | but if they're using it to keep users from making huge-normous nested stacks, then changing the limit semantics is going to get really confusing | 12:49 |
ryansb | very quickly | 12:49 |
ryansb | oh...ok bye | 12:49 |
*** Qiming has quit IRC | 12:49 | |
inc0_ | no, I'm here;) | 12:49 |
inc0_ | this was my old, disconnected nick | 12:49 |
ryansb | ah, missed the _ | 12:49 |
*** Qiming has joined #heat | 12:49 | |
inc0_ | rest in peace my old nick | 12:49 |
ryansb | lol | 12:50 |
inc0_ | yeah, changing behaviour of config is bad thing | 12:50 |
inc0_ | also, steven's changes won't help that much with memory, as this validation is often called before stack.store, so db won't help | 12:50 |
ryansb | uh, I've tested steven's changes | 12:51 |
inc0_ | in some cases it will | 12:51 |
ryansb | and they do help, significantly | 12:51 |
ryansb | on the order of a 70% reduction, in certain cases | 12:51 |
*** inc0__ has joined #heat | 12:52 | |
inc0__ | damn you connection | 12:52 |
inc0__ | let's move this conversation for a time when I'll have more stable internet | 12:53 |
inc0__ | also, I'll just remove default change from this patches | 12:53 |
inc0__ | and maybe we'll discuss changing the default on meeting | 12:53 |
inc0__ | how about that? | 12:54 |
inc0__ | now I'll just introduce mechanism | 12:54 |
ryansb | works for me | 12:54 |
inc0__ | cool, I'll do that | 12:54 |
inc0__ | thanks Ryan | 12:54 |
ryansb | (just make sure it's not the 3am-EST meeting if you want me to be there) | 12:54 |
inc0__ | no, I'll try to be on next Wednesday one | 12:55 |
inc0__ | so should be ok for you | 12:55 |
inc0__ | a bit worse for me, but not THAT bad, midnight | 12:55 |
inc0__ | or 10pm, can't remember | 12:55 |
*** inc0_ has quit IRC | 12:55 | |
*** Raj1 has quit IRC | 12:55 | |
inc0__ | 9pm, even better, I'll add this topic to an agenda | 12:56 |
ryansb | k, see you then | 12:56 |
*** zhonghua-lee has quit IRC | 12:57 | |
openstackgerrit | Michal Jastrzebski (inc0) proposed openstack/heat: Unlimited option max_resources_per_stack https://review.openstack.org/185894 | 12:59 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Do not pass rich objects on server's resume https://review.openstack.org/186363 | 13:01 |
*** metral is now known as metral_zzz | 13:03 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Move check_active to nova client plugin https://review.openstack.org/186063 | 13:06 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Do not pass rich objects on server's resume https://review.openstack.org/186363 | 13:06 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Stop monkey-patching global namespace https://review.openstack.org/186362 | 13:06 |
*** dyasny has joined #heat | 13:07 | |
*** tobe has quit IRC | 13:08 | |
*** jruano has joined #heat | 13:11 | |
*** smccully has joined #heat | 13:11 | |
*** tonisboner has joined #heat | 13:14 | |
*** tonisboner is now known as tonisbones | 13:14 | |
*** jprovazn has quit IRC | 13:16 | |
openstackgerrit | Tetiana Lashchova proposed openstack/heat: Fix py27log env in tox https://review.openstack.org/186378 | 13:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Heat could not create samples with Ceilometer https://review.openstack.org/183901 | 13:17 |
*** radez is now known as radez_g0n3 | 13:19 | |
*** spzala has quit IRC | 13:19 | |
*** radez_g0n3 is now known as radez | 13:28 | |
*** jamielennox is now known as jamielennox|away | 13:29 | |
openstackgerrit | Tetiana Lashchova proposed openstack/heat: Reload logging options when receiving SIGHUP https://review.openstack.org/185640 | 13:32 |
*** ChuckC has quit IRC | 13:32 | |
*** samueldmq has joined #heat | 13:32 | |
*** gcivitella has joined #heat | 13:34 | |
*** dims_ has quit IRC | 13:37 | |
*** bnemec has quit IRC | 13:37 | |
*** dims_ has joined #heat | 13:38 | |
therve | tlashchova, Hi! Can you update your review of https://review.openstack.org/185507 ? I added a test file. | 13:38 |
*** jasond has joined #heat | 13:40 | |
*** achanda has joined #heat | 13:40 | |
tlashchova | therve, done | 13:41 |
jdandrea | morning | 13:41 |
therve | Thanks! | 13:41 |
jdandrea | (well, here anyway *grin*) | 13:41 |
*** mgershen has quit IRC | 13:42 | |
*** bnemec has joined #heat | 13:42 | |
*** jprovazn has joined #heat | 13:48 | |
*** blomquisg has joined #heat | 13:56 | |
*** cody-somerville has joined #heat | 13:59 | |
*** dyasny has quit IRC | 13:59 | |
*** inc0__ has quit IRC | 14:02 | |
openstackgerrit | Tetiana Lashchova proposed openstack/heat: Reload logging options when receiving SIGHUP https://review.openstack.org/185640 | 14:02 |
*** radez is now known as radez_g0n3 | 14:04 | |
*** inc0 has joined #heat | 14:05 | |
*** sdake has joined #heat | 14:09 | |
openstackgerrit | Michal Jastrzebski (inc0) proposed openstack/heat: Unlimited option max_resources_per_stack https://review.openstack.org/185894 | 14:09 |
inc0 | zaneb, about unlimited, fair point abot fork bomb thing, I revoke my previous commitment to default -1, but how about somehow limit nested stack count? And keep single stack? | 14:10 |
*** sdake_ has joined #heat | 14:10 | |
inc0 | I mean, we put limit on resources on single stack, with default of 1000, but somehow skip checking nested stacks recursively | 14:10 |
inc0 | so we won't skip all validations, just memory heavy one | 14:11 |
zaneb | inc0: I wonder if we should introduce a per-tenant resource limit rather than a per-tree-of-nested-stacks limit | 14:11 |
inc0 | like resource quota? | 14:12 |
inc0 | that actually makes sense | 14:12 |
inc0 | imho | 14:12 |
zaneb | I'd be happy to see something like that for Liberty | 14:12 |
*** Qiming has quit IRC | 14:12 | |
zaneb | seems like that would be easy enough for the DB to count for us | 14:13 |
*** achanda_ has joined #heat | 14:13 | |
*** mixos has joined #heat | 14:13 | |
inc0 | well, would need this validation I'm trying to get rid of;) | 14:13 |
inc0 | or not? we can keep creating stacks until we hit limit | 14:13 |
inc0 | and then fail stack at this point with quota exceeded | 14:13 |
inc0 | without prior count, which would be prone to errors anyway if people would create several stacks at same time | 14:14 |
*** sdake has quit IRC | 14:14 | |
inc0 | anyway, I'll work on spec for that, seems like fun feature | 14:15 |
*** mixos has left #heat | 14:16 | |
inc0 | allright, I'm about to have another conference talk, probably should go in there | 14:16 |
inc0 | bbl | 14:16 |
*** rakesh_hs has quit IRC | 14:17 | |
*** achanda has quit IRC | 14:17 | |
openstackgerrit | Merged openstack/heat: Fix py27log env in tox https://review.openstack.org/186378 | 14:17 |
openstackgerrit | Rico Lin proposed openstack/heat: Heat could not create samples with Ceilometer https://review.openstack.org/183901 | 14:19 |
*** LiJiansheng has quit IRC | 14:19 | |
*** inc0 has quit IRC | 14:21 | |
*** cody-somerville has quit IRC | 14:23 | |
*** vijendar has joined #heat | 14:30 | |
*** rpothier has joined #heat | 14:34 | |
openstackgerrit | Tetiana Lashchova proposed openstack/heat: Reload logging options when receiving SIGHUP https://review.openstack.org/185640 | 14:38 |
*** metral_zzz is now known as metral | 14:40 | |
*** sdake has joined #heat | 14:40 | |
*** cody-somerville has joined #heat | 14:42 | |
*** cody-somerville has quit IRC | 14:42 | |
*** cody-somerville has joined #heat | 14:42 | |
openstackgerrit | Sergey Kraynev proposed openstack/heat: Add functional test for neutron port https://review.openstack.org/178189 | 14:42 |
*** sdake_ has quit IRC | 14:44 | |
*** smc7 has joined #heat | 14:45 | |
*** vijendar has quit IRC | 14:47 | |
*** metral is now known as metral_zzz | 14:47 | |
*** gokrokve has quit IRC | 14:48 | |
*** Murali_ has quit IRC | 14:49 | |
*** inc0 has joined #heat | 14:54 | |
*** alexheneveld has quit IRC | 14:55 | |
*** inc0 has quit IRC | 14:56 | |
openstackgerrit | Tetiana Lashchova proposed openstack/heat: Remove deprecated instance_user option https://review.openstack.org/186419 | 14:57 |
*** inc0 has joined #heat | 14:57 | |
*** tspatzier has quit IRC | 14:57 | |
*** e0ne is now known as e0ne_ | 15:00 | |
*** e0ne_ is now known as e0ne | 15:00 | |
*** dyasny has joined #heat | 15:00 | |
*** inc0 has quit IRC | 15:04 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat: Do not pass rich objects in server's suspend https://review.openstack.org/186424 | 15:05 |
*** inc0 has joined #heat | 15:06 | |
*** Adri2000 has quit IRC | 15:12 | |
*** Adri2000 has joined #heat | 15:12 | |
*** Adri2000 has quit IRC | 15:12 | |
*** Adri2000 has joined #heat | 15:12 | |
jdandrea | sbaker: I'm going to announce the template cookbook on the openstack list. Am I correct in recalling that would land in the dev documentation? | 15:13 |
ryansb | +1 | 15:14 |
ryansb | I think in hot_guide/alongside it | 15:14 |
jdandrea | ryansb: Ah, yes. | 15:14 |
*** pm90_ has joined #heat | 15:16 | |
*** hdd has joined #heat | 15:17 | |
openstackgerrit | Merged openstack/heat: Split engine service test cases (4) https://review.openstack.org/182578 | 15:20 |
*** LimorStotland has quit IRC | 15:21 | |
*** skraynev_ has quit IRC | 15:21 | |
*** pm90_ has quit IRC | 15:21 | |
*** pm90_ has joined #heat | 15:22 | |
*** radez_g0n3 is now known as radez | 15:23 | |
*** kebray has joined #heat | 15:23 | |
*** Drago has joined #heat | 15:26 | |
*** Drago has quit IRC | 15:26 | |
*** vijayagurug has left #heat | 15:26 | |
*** Drago has joined #heat | 15:26 | |
jdandrea | For raw material contributions (since this is going to be in the docs), is it appropriate to have those go directly to me or should folks be encouraged to reply to my post? (I'll ask for links, no attachments/embedded stuffs.) | 15:33 |
ryansb | might as well keep it all on the ML, or have folks propose patches to the docs repo | 15:34 |
jdandrea | Ah, good idea with the repo. (It's not set up yet, but when it is, definitely.) | 15:34 |
ryansb | ah, ML it is | 15:35 |
* jdandrea *whoosh* | 15:36 | |
*** crose has joined #heat | 15:37 | |
*** Raj1 has joined #heat | 15:37 | |
openstackgerrit | Ryan Brown proposed openstack/heat-specs: Add a spec for Event Messages in Heat https://review.openstack.org/186436 | 15:44 |
*** tspatzier has joined #heat | 15:44 | |
*** mwheckmann has joined #heat | 15:45 | |
*** Raj1 has quit IRC | 15:52 | |
*** mwheckmann has quit IRC | 15:53 | |
*** sabeen1 has joined #heat | 15:53 | |
jdandrea | ryansb: Whoops. Should I have posted that question to openstack or openstack-dev? (I posted to the former.) | 15:54 |
*** spzala has joined #heat | 15:54 | |
*** chlong has quit IRC | 15:54 | |
ryansb | probably -dev | 15:54 |
jdandrea | Oops. ok. | 15:54 |
ryansb | since those are (I think) the folks most likely to have stuff to contrib | 15:54 |
*** jistr has quit IRC | 15:56 | |
*** mwheckmann has joined #heat | 15:57 | |
*** sdake_ has joined #heat | 15:58 | |
*** sdake has quit IRC | 15:59 | |
*** sdake has joined #heat | 16:00 | |
*** smc7 has quit IRC | 16:01 | |
*** sjmc7 has joined #heat | 16:02 | |
openstackgerrit | Ryan Brown proposed openstack/heat-specs: Add a spec for Event Messages in Heat https://review.openstack.org/186436 | 16:02 |
*** sdake_ has quit IRC | 16:03 | |
*** gokrokve has joined #heat | 16:03 | |
*** metral_zzz is now known as metral | 16:04 | |
*** sjmc7 has left #heat | 16:05 | |
*** chlong has joined #heat | 16:07 | |
*** sabeen3 has joined #heat | 16:09 | |
*** chuckC_ has joined #heat | 16:10 | |
*** sabeen1 has quit IRC | 16:11 | |
*** kebray has quit IRC | 16:12 | |
*** inc0 has quit IRC | 16:16 | |
*** rwsu has joined #heat | 16:16 | |
*** kitch has quit IRC | 16:17 | |
*** kitch has joined #heat | 16:20 | |
*** derekh has quit IRC | 16:21 | |
*** yassine_ has quit IRC | 16:24 | |
openstackgerrit | Ryan Brown proposed openstack/heat-specs: Add a spec for Event Messages in Heat https://review.openstack.org/186436 | 16:28 |
*** metral is now known as metral_zzz | 16:36 | |
*** gcivitella has quit IRC | 16:42 | |
*** pbrooko has quit IRC | 16:44 | |
*** sileht has quit IRC | 16:47 | |
*** ashishjain has joined #heat | 16:49 | |
*** achanda_ has quit IRC | 16:54 | |
*** jrist has quit IRC | 16:58 | |
*** alexheneveld has joined #heat | 16:58 | |
*** alanf-mc has joined #heat | 16:59 | |
*** vijayagurug has joined #heat | 17:00 | |
*** gokrokve has quit IRC | 17:00 | |
*** gokrokve has joined #heat | 17:01 | |
*** sparr has quit IRC | 17:01 | |
*** sparr has joined #heat | 17:01 | |
*** Drago has quit IRC | 17:01 | |
*** alexheneveld has quit IRC | 17:02 | |
*** cody-somerville has quit IRC | 17:03 | |
*** harlowja has joined #heat | 17:05 | |
*** gokrokve has quit IRC | 17:05 | |
*** cody-somerville has joined #heat | 17:06 | |
*** tsandall has quit IRC | 17:06 | |
*** Drago has joined #heat | 17:08 | |
*** e0ne has quit IRC | 17:08 | |
*** kebray has joined #heat | 17:09 | |
*** Drago has quit IRC | 17:09 | |
*** Drago has joined #heat | 17:09 | |
*** jrist has joined #heat | 17:11 | |
*** ifarkas has quit IRC | 17:14 | |
*** vijayagurug has left #heat | 17:14 | |
*** sileht has joined #heat | 17:27 | |
*** daneyon has joined #heat | 17:32 | |
*** metral_zzz is now known as metral | 17:33 | |
*** daneyon_ has joined #heat | 17:33 | |
openstackgerrit | Merged openstack/heat: Revert "Add validation to set one of network, port or uuid" https://review.openstack.org/186143 | 17:34 |
*** sdake_ has joined #heat | 17:35 | |
*** daneyon has quit IRC | 17:36 | |
*** sdake has quit IRC | 17:39 | |
*** cody-somerville has quit IRC | 17:45 | |
*** pas-ha has quit IRC | 17:46 | |
*** vijendar has joined #heat | 17:57 | |
*** achanda has joined #heat | 18:00 | |
*** kebray has quit IRC | 18:01 | |
*** e0ne has joined #heat | 18:06 | |
*** tspatzier has quit IRC | 18:09 | |
*** tspatzier has joined #heat | 18:09 | |
*** tspatzier has quit IRC | 18:10 | |
*** jrist has quit IRC | 18:11 | |
*** alexpilotti has joined #heat | 18:14 | |
*** tsandall has joined #heat | 18:17 | |
*** jprovazn has quit IRC | 18:18 | |
*** e0ne has quit IRC | 18:21 | |
*** jrist has joined #heat | 18:23 | |
*** achanda has quit IRC | 18:23 | |
*** kebray has joined #heat | 18:26 | |
*** hdd has quit IRC | 18:34 | |
*** sjmc7 has joined #heat | 18:47 | |
*** kebray has quit IRC | 18:57 | |
*** zhonghua-lee has joined #heat | 19:00 | |
*** EricGonczer_ has joined #heat | 19:04 | |
*** alanf-mc has quit IRC | 19:10 | |
*** hdd has joined #heat | 19:13 | |
*** zhonghua-lee has quit IRC | 19:16 | |
*** kebray has joined #heat | 19:19 | |
*** alexpilotti has quit IRC | 19:23 | |
jasond | can someone please review https://review.openstack.org/#/c/151388/ and https://review.openstack.org/#/c/174978/ ? | 19:24 |
*** sdake has joined #heat | 19:26 | |
jasond | and/or :) | 19:28 |
*** sdake_ has quit IRC | 19:29 | |
*** mwheckmann has quit IRC | 19:35 | |
*** pm90_ has quit IRC | 19:40 | |
*** sjmc7 has quit IRC | 19:40 | |
*** pm90_ has joined #heat | 19:46 | |
*** blomquisg has quit IRC | 19:54 | |
*** pm90_ has quit IRC | 19:56 | |
*** pm90_ has joined #heat | 19:56 | |
*** gokrokve has joined #heat | 19:59 | |
*** kitch has quit IRC | 20:04 | |
*** daneyon has joined #heat | 20:05 | |
*** daneyon_ has quit IRC | 20:08 | |
*** kitch has joined #heat | 20:12 | |
openstackgerrit | Ryan Brown proposed openstack/heat-specs: Format for stack event messages https://review.openstack.org/186555 | 20:12 |
*** achanda has joined #heat | 20:13 | |
*** alanf-mc has joined #heat | 20:13 | |
therve | jasond, Please help on other reviews to reduce the list! :) | 20:17 |
*** achanda has quit IRC | 20:20 | |
openstackgerrit | Thomas Herve proposed openstack/heat: Implement barbican-backed store mechanism https://review.openstack.org/180959 | 20:22 |
*** ashishjain has quit IRC | 20:23 | |
jasond | therve: i will try to get at least 3 done by the end of the day | 20:25 |
therve | Thanks :) | 20:26 |
*** sdake_ has joined #heat | 20:26 | |
*** cody-somerville has joined #heat | 20:26 | |
*** sdake has quit IRC | 20:30 | |
*** Drago has quit IRC | 20:32 | |
stevebaker | morning | 20:34 |
*** mwheckmann has joined #heat | 20:45 | |
*** metral is now known as metral_zzz | 20:47 | |
*** sdake_ has quit IRC | 20:47 | |
*** daneyon has quit IRC | 20:48 | |
*** sdake has joined #heat | 20:49 | |
*** shardy has quit IRC | 20:56 | |
*** sjmc7 has joined #heat | 20:58 | |
*** samueldmq has quit IRC | 20:58 | |
*** radez is now known as radez_g0n3 | 21:02 | |
*** kitch has quit IRC | 21:02 | |
*** dyasny has quit IRC | 21:02 | |
*** Raj1 has joined #heat | 21:09 | |
*** sdake_ has joined #heat | 21:11 | |
*** Drago has joined #heat | 21:11 | |
*** rpothier has quit IRC | 21:13 | |
*** Drago has quit IRC | 21:13 | |
*** Drago has joined #heat | 21:13 | |
*** mwheckmann has quit IRC | 21:14 | |
*** sdake has quit IRC | 21:14 | |
*** jruano has quit IRC | 21:17 | |
*** blomquisg has joined #heat | 21:17 | |
*** blomquisg has quit IRC | 21:17 | |
stevebaker | hey, we have a gate-heat-python34 | 21:17 |
*** blomquisg has joined #heat | 21:17 | |
*** crose has quit IRC | 21:18 | |
*** jtomasek has quit IRC | 21:18 | |
*** alexpilotti has joined #heat | 21:21 | |
asalkeld | morning | 21:22 |
*** jasond has quit IRC | 21:30 | |
*** kebray has quit IRC | 21:31 | |
*** jamielennox|away is now known as jamielennox | 21:34 | |
*** EricGonczer_ has quit IRC | 21:35 | |
*** openstackgerrit has quit IRC | 21:36 | |
*** openstackgerrit has joined #heat | 21:37 | |
*** pm90_ has quit IRC | 21:39 | |
*** pm90_ has joined #heat | 21:46 | |
*** Raj1 has quit IRC | 21:51 | |
*** alexpilotti has quit IRC | 21:55 | |
openstackgerrit | Miguel Grinberg proposed openstack/heat: Added unsupported resources page to documentation https://review.openstack.org/186573 | 21:58 |
openstackgerrit | Miguel Grinberg proposed openstack/heat: Add unsupported resources page to documentation https://review.openstack.org/186573 | 21:58 |
*** sdake has joined #heat | 21:59 | |
*** sdake_ has quit IRC | 22:03 | |
*** jruano has joined #heat | 22:04 | |
*** metral_zzz is now known as metral | 22:05 | |
*** vijendar has quit IRC | 22:06 | |
*** hdd has quit IRC | 22:08 | |
*** hdd has joined #heat | 22:14 | |
*** jruano has quit IRC | 22:19 | |
*** hdd has quit IRC | 22:20 | |
*** hdd has joined #heat | 22:22 | |
*** sdake_ has joined #heat | 22:23 | |
*** Raj1 has joined #heat | 22:23 | |
*** mixos has joined #heat | 22:27 | |
*** mixos has left #heat | 22:27 | |
*** sdake has quit IRC | 22:27 | |
openstackgerrit | Steve Baker proposed openstack/heat: Switch total_resources to use stack_count_total_resources https://review.openstack.org/185155 | 22:32 |
openstackgerrit | Steve Baker proposed openstack/heat: Count all nested stack resources with DB operations https://review.openstack.org/185154 | 22:32 |
*** Qiming has joined #heat | 22:32 | |
*** gokrokve has quit IRC | 22:32 | |
*** gokrokve has joined #heat | 22:39 | |
*** barra204 has joined #heat | 22:43 | |
Qiming | asalkeld, a few minutes? | 22:47 |
*** chlong has quit IRC | 22:52 | |
asalkeld | sure Qiming | 22:55 |
Qiming | asalkeld, morning, need your help debug this: https://review.openstack.org/#/c/186291/ | 22:55 |
*** dsneddon has joined #heat | 22:56 | |
Qiming | PY27 complaining this: relation "resource_id_seq" does not exist | 22:56 |
asalkeld | looking | 22:56 |
Qiming | a grep of the migration versions subdir showed me that is related to 057 change | 22:56 |
*** jruano has joined #heat | 22:57 | |
Qiming | and it is only relevant to postgre engine .... | 22:57 |
asalkeld | Qiming: first off, you need placeholder scrips for the empty migrations | 22:57 |
asalkeld | you can't just delete the migrations (afaik) | 22:58 |
Qiming | 028 is a new starting point, that accumulates all historical changes | 22:58 |
*** barra204 has quit IRC | 23:01 | |
*** pm90_ has quit IRC | 23:03 | |
openstackgerrit | Merged openstack/heat: Should raise error if hook is invalid https://review.openstack.org/183409 | 23:04 |
*** kebray has joined #heat | 23:04 | |
asalkeld | i don't see anything obvious Qiming | 23:07 |
Qiming | asalkeld, the error message may be caused by this line: http://git.openstack.org/cgit/openstack/heat/tree/heat/db/sqlalchemy/migrate_repo/versions/057_resource_uuid_to_id.py#n152 | 23:08 |
asalkeld | ok, but you haven't changed that | 23:08 |
Qiming | yep | 23:08 |
asalkeld | can you confirm the schema is the same until that point? | 23:08 |
Qiming | yes, line by line added/changed | 23:09 |
asalkeld | no, on a live db | 23:09 |
Qiming | ah, that wasn't tested | 23:10 |
asalkeld | that's the only true way to know | 23:10 |
Qiming | I'd better do a migration dryrun | 23:10 |
Qiming | btw, regarding the sequence thing, for posgresql engine, we do have a sequence generated here: http://git.openstack.org/cgit/openstack/heat/tree/heat/db/sqlalchemy/migrate_repo/versions/057_resource_uuid_to_id.py#n115 | 23:11 |
miguelgrinberg | Qiming: hi, I wonder if the problem has to do with the fact that without the flattening the resource id column goes from int to uuid in the range that you collapsed | 23:14 |
miguelgrinberg | not super familiar with Postgres, but maybe there is one of these sequences created automatically for int primary keys? | 23:15 |
miguelgrinberg | so now that you create the resource table directly with a uuid key that sequence is never created | 23:15 |
*** barra204 has joined #heat | 23:16 | |
Qiming | miguelgrinberg, if we focus on 057, you will see that a sequence named 'res' is created on line 115, and we seem to be dropping an non-existent sequence named 'resource_id_seq' on line 152? | 23:17 |
miguelgrinberg | Qiming: yeah, so I'm thinking the one that gets dropped was added by migration #15 maybe | 23:17 |
Qiming | not sure why the test is running into that path, but it is funny | 23:17 |
*** dims_ has quit IRC | 23:17 | |
miguelgrinberg | so #57 is doing some cleanup that now is unnecessary | 23:18 |
Qiming | because #18 has changed ID to be a UUID? | 23:18 |
*** dims_ has joined #heat | 23:20 | |
Qiming | so, seems that we could have dropped the sequence in #18 | 23:20 |
miguelgrinberg | Qiming: I think so, not sure because I don't use Postgres, but it seems likely | 23:21 |
miguelgrinberg | that means that now that you collapsed the whole thing you can just remove that | 23:21 |
Qiming | em, hopefully I'm not breaking some postgre users | 23:22 |
miguelgrinberg | trying to find some justification in documentation | 23:22 |
miguelgrinberg | Qiming: http://www.postgresql.org/docs/8.1/static/datatype.html#DATATYPE-SERIAL | 23:24 |
miguelgrinberg | this "serial" type creates a sequence with the name {table}_{column}_{seq} | 23:24 |
miguelgrinberg | that matches | 23:24 |
Qiming | yes, but you need to create a sequence beforehand, or you will user SERIAL as the data type | 23:25 |
miguelgrinberg | this is the equivalent to "auto increment" in standard SQL | 23:25 |
miguelgrinberg | I bet SQLAlchemy did this automatically in migration #15 | 23:25 |
miguelgrinberg | the serial type creates the sequence for you, you do not create it | 23:26 |
Qiming | oh, we have SQLAlchemy in the middle, almost forgot that, :) | 23:26 |
miguelgrinberg | it's like a macro | 23:26 |
*** tonisbones has quit IRC | 23:28 | |
*** jruano has quit IRC | 23:28 | |
Qiming | I hope SQLAlchemy has been doing this a long time ago, or else we will run into another problem | 23:28 |
*** sabeen3 has quit IRC | 23:28 | |
miguelgrinberg | why? with your changes it will not need to do that | 23:28 |
*** tonisbones has joined #heat | 23:29 | |
Qiming | tox -e py27 passed happily in my local environment | 23:29 |
Qiming | so I'm doubting that SQLAlchemy version difference is causing the problem at the gate | 23:29 |
miguelgrinberg | I'm not familiar with the way the gate launches the script, is there any chance that it sets some env var to use Postgres? But in your local env you don't have that so it goes with sqlite or MySQL? | 23:31 |
Qiming | not familiar with gate setup either | 23:31 |
*** gokrokve has quit IRC | 23:34 | |
*** gokrokve has joined #heat | 23:35 | |
Qiming | ah, the error was triggered when running this: heat.tests.db.test_migrations.ModelsMigrationsSyncPostgres.test_models_sync | 23:36 |
Qiming | but I don't have postgresql in my env, maybe that path was skipped | 23:36 |
*** sjmc7 has quit IRC | 23:36 | |
*** gokrokve has quit IRC | 23:40 | |
*** Raj1 has quit IRC | 23:40 | |
Qiming | thanks, guys, got to run | 23:41 |
Qiming | bye for now | 23:41 |
miguelgrinberg | Qiming: just arrived at the same conclusion. The db tests are skipped if you don't have the for a given db installed. That explains it. | 23:43 |
miguelgrinberg | if you install the postgres client and the python package you'll be able to reproduce the error | 23:44 |
*** pm90_ has joined #heat | 23:44 | |
*** Qiming has quit IRC | 23:46 | |
*** alanf-mc has quit IRC | 23:50 | |
*** alanf-mc has joined #heat | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!