*** sdake has quit IRC | 00:00 | |
*** tmatsu has joined #heat | 00:02 | |
*** chlong_ has quit IRC | 00:03 | |
openstackgerrit | Steve Baker proposed openstack/python-heatclient: Implement stack event list --follow https://review.openstack.org/280487 | 00:05 |
---|---|---|
openstackgerrit | Steve Baker proposed openstack/python-heatclient: Register a log formatter for stack event list https://review.openstack.org/284492 | 00:05 |
openstackgerrit | Steve Baker proposed openstack/python-heatclient: WIP An svg chart event list formatter https://review.openstack.org/284993 | 00:05 |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat: Enable client plugin to support dynamic api version https://review.openstack.org/255443 | 00:05 |
openstackgerrit | Steve Baker proposed openstack/python-heatclient: WIP An svg chart event list formatter https://review.openstack.org/284993 | 00:08 |
*** mwheckmann has quit IRC | 00:15 | |
*** sdake has joined #heat | 00:22 | |
*** daneyon has quit IRC | 00:28 | |
*** sridhar_ram has joined #heat | 00:30 | |
*** sridhar_ram has quit IRC | 00:33 | |
*** sridhar_ram has joined #heat | 00:35 | |
*** sdake has quit IRC | 00:36 | |
*** zeih has joined #heat | 00:49 | |
*** manishg has quit IRC | 00:51 | |
*** zeih has quit IRC | 00:54 | |
*** cwolferh has quit IRC | 00:55 | |
*** Qiming has joined #heat | 00:57 | |
*** zeih has joined #heat | 01:00 | |
*** zeih has quit IRC | 01:05 | |
*** cwolferh has joined #heat | 01:16 | |
*** zz_dimtruck is now known as dimtruck | 01:17 | |
*** tmatsu has quit IRC | 01:17 | |
*** tmatsu has joined #heat | 01:17 | |
*** tmatsu_ has joined #heat | 01:18 | |
*** tmatsu has quit IRC | 01:22 | |
*** daneyon has joined #heat | 01:28 | |
*** KanagarajM_ has joined #heat | 01:28 | |
openstackgerrit | Merged openstack/heat: Resource mark unhealthy RPC and ReST API https://review.openstack.org/266038 | 01:29 |
*** daneyon_ has joined #heat | 01:30 | |
*** KanagarajM has quit IRC | 01:31 | |
*** daneyon has quit IRC | 01:33 | |
*** KanagarajM_ has quit IRC | 01:35 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/285009 | 01:39 |
*** Yanyanhu has joined #heat | 01:47 | |
*** dims has quit IRC | 01:49 | |
*** chlong_ has joined #heat | 01:50 | |
stevebaker | any reviewer able to look at this? https://review.openstack.org/#/c/279755/ | 02:01 |
*** tochi has quit IRC | 02:06 | |
*** tochi has joined #heat | 02:07 | |
*** Drago has quit IRC | 02:07 | |
*** sabeen has joined #heat | 02:23 | |
*** EricGonczer_ has joined #heat | 02:24 | |
*** shangxdy has joined #heat | 02:25 | |
*** EricGonczer_ has quit IRC | 02:25 | |
*** EricGonczer_ has joined #heat | 02:27 | |
*** manishg has joined #heat | 02:27 | |
*** KanagarajM_ has joined #heat | 02:29 | |
*** bana_k has joined #heat | 02:29 | |
*** jonesbr has joined #heat | 02:32 | |
openstackgerrit | Merged openstack/heat: Make AutoScale sub-template a string instead of map https://review.openstack.org/281953 | 02:33 |
*** shangxdy has quit IRC | 02:39 | |
*** mwheckmann has joined #heat | 02:43 | |
*** Shangxdy has joined #heat | 02:44 | |
tiantian | stevebaker, about the https://review.openstack.org/#/c/279755/, see comments inline | 02:47 |
stevebaker | tiantian: hey, I've replied | 02:51 |
jonesbr | tiantian: could you look at my response to your comment in https://review.openstack.org/#/c/238612/ ? | 02:53 |
tiantian | stevebaker, done | 02:55 |
stevebaker | tiantian: thanks | 02:55 |
tiantian | stevebaker, :) | 02:56 |
stevebaker | tiantian: while you're at it could you take a look at this series? https://review.openstack.org/#/c/280396/ | 02:57 |
*** zeih has joined #heat | 03:01 | |
*** cwolferh has quit IRC | 03:05 | |
*** zeih has quit IRC | 03:06 | |
*** dims has joined #heat | 03:10 | |
openstackgerrit | Merged openstack/python-heatclient: Fix collision with update and update cancel https://review.openstack.org/279755 | 03:10 |
*** neelashah has joined #heat | 03:12 | |
*** EricGonczer_ has quit IRC | 03:12 | |
*** bana_k has quit IRC | 03:23 | |
*** boris-42 has quit IRC | 03:24 | |
*** tochi has quit IRC | 03:26 | |
*** links has joined #heat | 03:26 | |
*** Yanyan has joined #heat | 03:30 | |
*** Yanyanhu has quit IRC | 03:30 | |
*** sabeen1 has joined #heat | 03:37 | |
*** Kennan has quit IRC | 03:39 | |
*** Kennan has joined #heat | 03:39 | |
*** manishg has quit IRC | 03:39 | |
*** sabeen has quit IRC | 03:40 | |
*** daneyon_ has quit IRC | 03:54 | |
*** Marga_ has quit IRC | 03:57 | |
*** Marga_ has joined #heat | 03:58 | |
*** tochi has joined #heat | 03:59 | |
*** EricGonczer_ has joined #heat | 04:02 | |
*** Marga_ has quit IRC | 04:03 | |
*** mwheckmann has quit IRC | 04:05 | |
*** sridhar_ram has quit IRC | 04:05 | |
*** EricGonczer_ has quit IRC | 04:07 | |
openstackgerrit | Rabi Mishra proposed openstack/heat: Release note for resource update restrict https://review.openstack.org/285100 | 04:17 |
*** brad[] has quit IRC | 04:17 | |
*** Marga_ has joined #heat | 04:19 | |
*** Marga_ has quit IRC | 04:21 | |
*** Marga_ has joined #heat | 04:21 | |
*** wangbo has quit IRC | 04:29 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat: Enable client plugin to support dynamic api version https://review.openstack.org/255443 | 04:32 |
*** manishg has joined #heat | 04:40 | |
*** wangbo has joined #heat | 04:42 | |
*** manishg has quit IRC | 04:46 | |
*** dimtruck is now known as zz_dimtruck | 04:49 | |
*** sabeen1 has quit IRC | 04:52 | |
*** zeih has joined #heat | 05:02 | |
openstackgerrit | Merged openstack/heat: Updated from global requirements https://review.openstack.org/285009 | 05:02 |
*** zeih has quit IRC | 05:06 | |
*** sdake has joined #heat | 05:13 | |
openstackgerrit | Merged openstack/python-heatclient: Use yaml.safe_load() instead of yaml.load() https://review.openstack.org/280693 | 05:21 |
*** sdake has quit IRC | 05:23 | |
*** manishg has joined #heat | 05:28 | |
*** manishg has quit IRC | 05:32 | |
*** tmatsu_ has quit IRC | 05:32 | |
*** mohankumar_ has joined #heat | 05:34 | |
*** neelashah has quit IRC | 05:38 | |
openstackgerrit | Merged openstack/python-heatclient: Changes to support server-side environment resolution https://review.openstack.org/239504 | 05:43 |
*** tmatsu has joined #heat | 05:46 | |
*** mohankumar_ has quit IRC | 05:58 | |
*** mohankumar_ has joined #heat | 05:59 | |
*** Marga_ has quit IRC | 06:00 | |
openstackgerrit | Bryan Jones proposed openstack/heat: LBaaS v2 Pool Member https://review.openstack.org/241251 | 06:00 |
openstackgerrit | Bryan Jones proposed openstack/heat: LBaaS v2 Pool https://review.openstack.org/240049 | 06:01 |
openstackgerrit | Bryan Jones proposed openstack/heat: LBaas v2 HealthMonitor https://review.openstack.org/245287 | 06:01 |
openstackgerrit | Bryan Jones proposed openstack/heat: LBaaS v2 Loadbalancer https://review.openstack.org/238612 | 06:01 |
openstackgerrit | Bryan Jones proposed openstack/heat: LBaaS v2 Listener https://review.openstack.org/239755 | 06:01 |
jonesbr | KanagarajM_: ^ updated patches based on your comments | 06:01 |
*** jonesbr has left #heat | 06:13 | |
*** Marga_ has joined #heat | 06:17 | |
*** links has quit IRC | 06:26 | |
*** manishg has joined #heat | 06:28 | |
*** manishg has quit IRC | 06:33 | |
*** dims has quit IRC | 06:37 | |
*** ricolin has joined #heat | 06:44 | |
*** zeih has joined #heat | 06:55 | |
openstackgerrit | Merged openstack/heat: Release note for resource update restrict https://review.openstack.org/285100 | 06:57 |
*** wirehead_ has quit IRC | 07:04 | |
*** mkrai_ has joined #heat | 07:04 | |
*** wirehead_ has joined #heat | 07:05 | |
*** mkrai_ has quit IRC | 07:08 | |
*** vjain has joined #heat | 07:08 | |
openstackgerrit | Han Manjong proposed openstack/heat: Allow external fixed IP address to be set on Router in template https://review.openstack.org/236748 | 07:14 |
*** rakesh_hs has joined #heat | 07:15 | |
*** KanagarajM_ has quit IRC | 07:21 | |
*** chlong_ has quit IRC | 07:26 | |
*** manishg has joined #heat | 07:29 | |
*** manishg has quit IRC | 07:34 | |
*** jprovazn has joined #heat | 07:49 | |
*** jtomasek has joined #heat | 07:52 | |
*** jtomasek_ has joined #heat | 08:00 | |
*** sdake has joined #heat | 08:02 | |
*** sdake has quit IRC | 08:04 | |
*** skraynev_ has joined #heat | 08:05 | |
*** zeih has quit IRC | 08:15 | |
skraynev_ | jdob: ping | 08:18 |
skraynev_ | jdob: please update your BP about multi envs support ;) | 08:22 |
*** achanda has quit IRC | 08:29 | |
*** manishg has joined #heat | 08:30 | |
*** zeih has joined #heat | 08:32 | |
*** tmatsu has quit IRC | 08:33 | |
*** achanda has joined #heat | 08:33 | |
openstackgerrit | Ishant Tyagi proposed openstack/heat-templates: Verify certificates when makeing https request to cfn api https://review.openstack.org/285157 | 08:34 |
*** wangbo has quit IRC | 08:34 | |
*** manishg has quit IRC | 08:35 | |
*** zeih has quit IRC | 08:37 | |
*** tmatsu has joined #heat | 08:38 | |
*** tmatsu has quit IRC | 08:42 | |
*** blues-man has joined #heat | 08:48 | |
*** jtomasek_ has quit IRC | 08:48 | |
jgrassler | Good morning | 08:53 |
jgrassler | I have discovered a bit of an issue with https://github.com/openstack/heat/commit/487a211a8a3d603ae4b77087836081037fa49c70 | 08:54 |
jgrassler | Namely, it causes heat-api (and presumably other heat services, but I haven't looked at others, yet) to throw an exception and stop working | 08:54 |
jgrassler | The problem happens in cases where Keystone is not available or not available, yet | 08:55 |
*** vgridnev has joined #heat | 08:56 | |
jgrassler | This can happen either when Keystone starts after heat-api or directly before it (the listeners take a while to come up) | 08:56 |
openstackgerrit | Han Manjong proposed openstack/heat: Allow external fixed IP address to be set on Router in template https://review.openstack.org/236748 | 08:57 |
jgrassler | And if keystone is not reachable at the point where the code from that commit tries to figure out the appropriate auth_url from the catalog | 08:58 |
jgrassler | heat-api grinds to a halt. | 08:58 |
*** wangbo has joined #heat | 09:00 | |
jgrassler | Bug material? If so I'll create a bug report :-) | 09:01 |
jgrassler | (I've got a rough patch lined up, too. I can polish that up and submit it.) | 09:01 |
*** blues-man has quit IRC | 09:02 | |
*** blues-man has joined #heat | 09:02 | |
*** achanda has quit IRC | 09:03 | |
therve | jgrassler, What's the traceback? | 09:03 |
jgrassler | therve: Just a sec, let me dig it up... | 09:04 |
therve | But yeah I think I see the issue | 09:05 |
therve | We should resolve the url at runtime only, no need to do it during init | 09:05 |
therve | Definitely needs a bug report | 09:05 |
jgrassler | Here's the traceback: https://gist.github.com/anonymous/2266a525e6a9199aee37 | 09:06 |
jgrassler | Catching the exception from Keystoneclient and retrying until Keystone is available fixes the problem | 09:07 |
jgrassler | Ok, I'll create a bug report then, thanks :-) | 09:07 |
therve | I would solve that differently, though :) | 09:08 |
*** mohankumar_ has quit IRC | 09:08 | |
*** mohankumar_ has joined #heat | 09:08 | |
openstackgerrit | Ishant Tyagi proposed openstack/heat-templates: Verify certificates when makeing https request to cfn api https://review.openstack.org/285157 | 09:08 |
*** mohankumar_ has quit IRC | 09:08 | |
*** mohankumar_ has joined #heat | 09:08 | |
jgrassler | therve: do tell...I'd rather do it properly right away rather than go through multiple review iterations needlessly :-) | 09:09 |
*** jcoufal has joined #heat | 09:10 | |
therve | jgrassler, Just don't do it in init. Resolve the url when we need it | 09:10 |
therve | And if it raises an error, let it raise | 09:10 |
jgrassler | therve: There's that, but it would only move the race condition to a later point, wouldn't it? | 09:11 |
therve | jgrassler, Why would there be a race condition? | 09:11 |
jgrassler | therve: Keystone may still not be available at the later point when the URL is being resolved | 09:12 |
therve | jgrassler, Sure. Then you raise the error | 09:12 |
therve | Retrying doesn't make keystone magically available :) | 09:13 |
jgrassler | Of course not, not :-) | 09:13 |
therve | That's not a race condition though | 09:13 |
jgrassler | But will heat just sit there and not talk to Keystone until it receives inbound requests (I'm not that familiar with the heat code base) | 09:14 |
jgrassler | Well, it is in the case at hand | 09:14 |
jgrassler | Keystone just takes a few seconds from the point where it forks (and is considered running by the init script or systemd) to the point where all of its listeners are up | 09:15 |
therve | Sure, but what if it's just down? | 09:16 |
*** ricolin has quit IRC | 09:17 | |
jgrassler | In that case error handling code would black Heat (possibly indefinitely) until Keystone becomes available (or not) | 09:17 |
jgrassler | I see little harm in that, after all Heat can't do much, if anything while Keystone is down - and it will recover once it is back up | 09:18 |
jgrassler | As opposed to heat immediately coming to a halt due to the error raising, even is there is just a temporary Keystone outage due to, say, somebody unplugging the wrong cable | 09:19 |
jgrassler | s/is there/if there/ | 09:20 |
therve | I didn't say that Heat should come up to a halt | 09:22 |
therve | Just that one request can fail if the backend is unavaiable | 09:22 |
therve | (Hint: the request won't get to heat in the first place if keystone isn't there) | 09:22 |
jgrassler | Ah, ok...so at a later stage that error raising would not be fatal to the main process? | 09:23 |
therve | No | 09:25 |
*** sorantis has joined #heat | 09:26 | |
*** yassine__ has joined #heat | 09:27 | |
*** jistr has joined #heat | 09:27 | |
jgrassler | Ok, then I'll have a look at where the auth_url is needed and look into moving resolving it somewhere more appropriate | 09:30 |
jgrassler | But first of all I'll create the bug report :-) | 09:30 |
*** maishsk_ has joined #heat | 09:30 | |
*** maishsk has quit IRC | 09:30 | |
*** maishsk_ is now known as maishsk | 09:30 | |
*** Yanyanhu has joined #heat | 09:33 | |
*** zeih has joined #heat | 09:33 | |
*** ricolin has joined #heat | 09:34 | |
*** dgonzalez has quit IRC | 09:35 | |
*** dgonzalez has joined #heat | 09:35 | |
*** Yanyan has quit IRC | 09:35 | |
*** ishant has joined #heat | 09:35 | |
*** blues-man has quit IRC | 09:35 | |
*** blues-man has joined #heat | 09:35 | |
*** blues-man has quit IRC | 09:35 | |
*** blues-man has joined #heat | 09:35 | |
*** zeih has quit IRC | 09:39 | |
*** wangbo has quit IRC | 09:39 | |
*** wangbo has joined #heat | 09:52 | |
openstackgerrit | Merged openstack/python-heatclient: poll_for_events fall back to stack get https://review.openstack.org/280396 | 09:54 |
openstackgerrit | Merged openstack/python-heatclient: Use poll_for_events for "openstack stack create" https://review.openstack.org/280397 | 10:04 |
openstackgerrit | Merged openstack/python-heatclient: Use poll_for_events for "openstack stack update" https://review.openstack.org/280398 | 10:04 |
openstackgerrit | Merged openstack/python-heatclient: Use poll_for_events for "openstack stack adopt" https://review.openstack.org/280399 | 10:04 |
*** ricolin has quit IRC | 10:11 | |
*** maishsk has quit IRC | 10:13 | |
*** derekh has joined #heat | 10:13 | |
*** maishsk has joined #heat | 10:13 | |
*** Qiming has quit IRC | 10:16 | |
*** mohankumar_ has quit IRC | 10:21 | |
*** maishsk has quit IRC | 10:22 | |
*** maishsk has joined #heat | 10:23 | |
*** maishsk has quit IRC | 10:26 | |
*** vgridnev has quit IRC | 10:27 | |
*** ishant has quit IRC | 10:27 | |
*** vgridnev has joined #heat | 10:31 | |
*** manishg has joined #heat | 10:31 | |
*** achanda has joined #heat | 10:33 | |
*** maishsk has joined #heat | 10:34 | |
*** manishg has quit IRC | 10:36 | |
*** Yanyanhu has quit IRC | 10:37 | |
*** achanda has quit IRC | 10:38 | |
openstackgerrit | Zeng Tao proposed openstack/heat: Fix heat provider_net bug https://review.openstack.org/285211 | 10:45 |
openstackgerrit | Zeng Tao proposed openstack/heat: Fix heat provider_net bug https://review.openstack.org/285211 | 10:45 |
*** mohankumar_ has joined #heat | 10:54 | |
openstackgerrit | Merged openstack/heat: Allow external fixed IP address to be set on Router in template https://review.openstack.org/236748 | 11:10 |
*** wangbo has quit IRC | 11:10 | |
*** spotz_zzz is now known as spotz | 11:11 | |
*** Qiming has joined #heat | 11:22 | |
*** wangbo has joined #heat | 11:23 | |
openstackgerrit | Mohankumar proposed openstack/heat: Add networking-sfc port-pair-group resource plug-in https://review.openstack.org/277849 | 11:32 |
*** manishg has joined #heat | 11:32 | |
openstackgerrit | Merged openstack/heat: Implement custom guidelines https://review.openstack.org/281815 | 11:33 |
*** vjain has quit IRC | 11:34 | |
*** achanda has joined #heat | 11:35 | |
*** manishg has quit IRC | 11:37 | |
*** achanda has quit IRC | 11:39 | |
openstackgerrit | Mohankumar proposed openstack/heat: Add networking-sfc port-pair-group resource plug-in https://review.openstack.org/277849 | 11:43 |
*** vgridnev has quit IRC | 11:44 | |
*** vgridnev has joined #heat | 11:51 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all properties errors for custom guidelines https://review.openstack.org/281816 | 11:52 |
*** prazumovsky has joined #heat | 11:54 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all attributes error for custom guidelines https://review.openstack.org/281817 | 11:55 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix resources descriptions for custom guidelines https://review.openstack.org/281818 | 11:55 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all method errors for custom guidelines https://review.openstack.org/281819 | 11:55 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all trailing spaces for custom guidelines https://review.openstack.org/281820 | 11:56 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Add way to use custom pathes in translation https://review.openstack.org/280131 | 11:58 |
prazumovsky | Hello! Please, check reno for docstring-improvement bp https://review.openstack.org/#/c/284691/ it's small:) | 11:59 |
*** wangbo has quit IRC | 12:10 | |
*** wangbo has joined #heat | 12:10 | |
*** krotscheck_dcm is now known as krotscheck | 12:13 | |
*** mohankumar_ has quit IRC | 12:22 | |
*** sdake has joined #heat | 12:29 | |
*** manishg has joined #heat | 12:33 | |
*** maishsk has quit IRC | 12:34 | |
*** maishsk_ has joined #heat | 12:34 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: LBaaS v2 Loadbalancer https://review.openstack.org/238612 | 12:35 |
prazumovsky | tiantian: I think, you can review lbaasv2 lb https://review.openstack.org/#/c/238612/ - your comment has been resolved | 12:36 |
*** manishg has quit IRC | 12:37 | |
*** tiantian has quit IRC | 12:40 | |
therve | prazumovsky, Do we really need a note for that? | 12:40 |
prazumovsky | I thought, that all implemented bp should have reno | 12:40 |
prazumovsky | if I am wrong, I can abandon it | 12:41 |
*** tiantian has joined #heat | 12:41 | |
therve | Doug just sent an email about that, actually :) | 12:43 |
*** mohankumar_ has joined #heat | 12:46 | |
*** maishsk_ has quit IRC | 12:48 | |
*** maishsk has joined #heat | 12:50 | |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all trailing spaces for custom guidelines https://review.openstack.org/281820 | 12:52 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all properties errors for custom guidelines https://review.openstack.org/281816 | 12:52 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all attributes error for custom guidelines https://review.openstack.org/281817 | 12:52 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix resources descriptions for custom guidelines https://review.openstack.org/281818 | 12:52 |
openstackgerrit | Peter Razumovsky proposed openstack/heat: Fix all method errors for custom guidelines https://review.openstack.org/281819 | 12:52 |
*** dprince has joined #heat | 12:57 | |
*** mohankumar_ has quit IRC | 13:01 | |
*** maishsk has quit IRC | 13:09 | |
*** tochi has quit IRC | 13:19 | |
*** prazumovsky has quit IRC | 13:21 | |
*** spotz is now known as spotz_zzz | 13:25 | |
*** brad[] has joined #heat | 13:25 | |
*** dyasny has quit IRC | 13:26 | |
*** automagically_ has joined #heat | 13:27 | |
*** automagically_ has left #heat | 13:27 | |
*** neelashah has joined #heat | 13:29 | |
*** manishg has joined #heat | 13:34 | |
*** achanda has joined #heat | 13:37 | |
*** manishg has quit IRC | 13:38 | |
*** Akanksha08 has quit IRC | 13:42 | |
*** achanda has quit IRC | 13:42 | |
*** rakesh_hs has quit IRC | 13:46 | |
jdob | skraynev_: just to double check, now that all of the multi-env code has landed, I move the BP to Implemented, is there anything else I do to the BP? https://blueprints.launchpad.net/heat/+spec/multi-environments | 13:48 |
skraynev_ | jdob: nope ;) Release notes were merged so I don't see any blockers | 13:49 |
jdob | awesome, thanks :) | 13:49 |
openstackgerrit | Jason Dunsmore proposed openstack/heat: Add functional test for immutable parameters https://review.openstack.org/262274 | 13:52 |
skraynev_ | ramishra: hi. if you have a minute, could you please analyze the root cause of error for this patch https://review.openstack.org/#/c/281817/4 - currently it looks pretty similar on bug, which you recently fixed | 13:53 |
skraynev_ | I meant this fix https://review.openstack.org/#/c/282208/ | 13:53 |
*** dims has joined #heat | 13:54 | |
therve | skraynev_, https://bugs.launchpad.net/heat/+bug/1545577 | 14:00 |
openstack | Launchpad bug 1545577 in heat "Transaction error in user_creds_delete" [Low,New] | 14:00 |
openstackgerrit | Jason Dunsmore proposed openstack/heat: Add release notes for Immutable Parameters feature https://review.openstack.org/285312 | 14:01 |
skraynev_ | therve: awesome. thx. | 14:01 |
ramishra | therve: can we not use a transaction context with user_creds_delete and avoid manual session.flush() ? | 14:12 |
*** dyasny has joined #heat | 14:12 | |
ramishra | skraynev_: it seems my patch did not help resolve the issue:( | 14:13 |
openstackgerrit | Merged openstack/heat: Add OS::Senlin::Node resource https://review.openstack.org/280094 | 14:14 |
therve | ramishra, We could, but I don't think that would fix the issue? | 14:14 |
therve | The code is correct, it just doesn't handle transaction conflicts | 14:14 |
skraynev_ | ramishra: I suppose, that therve right, that fix just does not cover root cause ;( | 14:17 |
therve | skraynev_, You mean https://review.openstack.org/#/c/282208/ ? | 14:18 |
ramishra | therve: IMO, purge is impacting the delete transaction because we don't use a demarcated transaction for the delete. It uses transaction associate with the session and we're flushing manually. | 14:18 |
*** sabeen has joined #heat | 14:19 | |
therve | ramishra, Ah so we don't have an being in that function? | 14:19 |
therve | It's always weird how sqlalchemy works | 14:19 |
skraynev_ | therve: yes, I meant this one | 14:19 |
ramishra | using a transaction would flush and rollback and we would not get ant StaleData errors. | 14:20 |
therve | skraynev_, It's totally unrelated? It's on update, this problem is on delete | 14:20 |
ramishra | s/ant/any | 14:20 |
therve | ramishra, I don't know about *any*. It would reduce the window for sure. | 14:21 |
*** sabeen1 has joined #heat | 14:21 | |
ramishra | therve: we can use a transaction context with the creds delete and and check? | 14:23 |
openstackgerrit | Sergey Kraynev proposed openstack/heat: Add release notes for senlin resources https://review.openstack.org/282953 | 14:23 |
*** sabeen has quit IRC | 14:23 | |
therve | ramishra, I guess you're right that we wouldn't have a StaleDataError. We could still have some other conflict error though IIUC | 14:24 |
therve | At any rate, it seems that replacing all flush by explicit transaction would be better | 14:24 |
ramishra | therve: Do you plan to push a patch for it? I can do that if you like. | 14:26 |
therve | ramishra, Please do so! | 14:26 |
ramishra | therve: sure | 14:26 |
*** manishg has joined #heat | 14:34 | |
*** sdake has quit IRC | 14:35 | |
*** manishg has quit IRC | 14:39 | |
*** crose has joined #heat | 14:51 | |
*** zz_dimtruck is now known as dimtruck | 14:53 | |
*** jonesbr has joined #heat | 14:54 | |
openstackgerrit | Sergey Kraynev proposed openstack/python-heatclient: Use poll_for_events for "openstack stack <action>" https://review.openstack.org/280400 | 14:54 |
*** vgridnev has quit IRC | 14:54 | |
*** vgridnev has joined #heat | 14:57 | |
*** vgridnev has quit IRC | 14:59 | |
*** vgridnev has joined #heat | 15:00 | |
*** jreeves has quit IRC | 15:01 | |
*** sorantis has quit IRC | 15:01 | |
*** vijendar has joined #heat | 15:02 | |
*** vgridnev has quit IRC | 15:04 | |
*** tlashchova has joined #heat | 15:05 | |
*** sdake has joined #heat | 15:05 | |
*** Raj1 has joined #heat | 15:11 | |
*** automagically has joined #heat | 15:19 | |
*** automagically has left #heat | 15:19 | |
skraynev_ | therve: ramishra: guys, could you please review patch https://review.openstack.org/#/c/280400/6 | 15:19 |
skraynev_ | it's last in series for wait/polling, which were introduced by stevebaker. | 15:19 |
skraynev_ | I just rebased it after merge conflict | 15:20 |
skraynev_ | I hoped to use it as last patch in 1.0.0 | 15:20 |
skraynev_ | i.e. before 1.0.0 | 15:20 |
*** Raj1 has quit IRC | 15:24 | |
*** achanda has joined #heat | 15:24 | |
*** vgridnev has joined #heat | 15:24 | |
*** vgridnev has quit IRC | 15:28 | |
*** Raj1 has joined #heat | 15:28 | |
*** vgridnev has joined #heat | 15:28 | |
*** Raj3 has joined #heat | 15:31 | |
*** vgridnev has quit IRC | 15:31 | |
*** Raj1 has quit IRC | 15:33 | |
openstackgerrit | Merged openstack/heat: Add release notes for senlin resources https://review.openstack.org/282953 | 15:33 |
*** Raj1 has joined #heat | 15:33 | |
*** dprince has quit IRC | 15:35 | |
*** manishg has joined #heat | 15:35 | |
*** Raj3 has quit IRC | 15:35 | |
*** jprovazn has quit IRC | 15:39 | |
*** manishg has quit IRC | 15:40 | |
*** spotz_zzz is now known as spotz | 15:42 | |
*** sdake has quit IRC | 15:47 | |
openstackgerrit | Mark Vanderwiel proposed openstack/python-heatclient: Add more readonly openstack client funcitonal tests https://review.openstack.org/279752 | 15:47 |
*** vgridnev has joined #heat | 15:49 | |
*** achanda has quit IRC | 15:51 | |
*** vgridnev has quit IRC | 15:51 | |
*** randallburt has joined #heat | 15:51 | |
*** Drago has joined #heat | 15:53 | |
*** vgridnev has joined #heat | 15:53 | |
*** mwheckmann has joined #heat | 15:57 | |
*** Raj1 has quit IRC | 16:03 | |
*** Raj1 has joined #heat | 16:05 | |
*** rpothier has joined #heat | 16:07 | |
*** Qiming has quit IRC | 16:09 | |
*** vgridnev has quit IRC | 16:10 | |
*** jreeves has joined #heat | 16:11 | |
*** logan- has quit IRC | 16:14 | |
*** logan- has joined #heat | 16:14 | |
skraynev_ | stevebaker: we are forced to release without several patches due to merge conflicts or -1 from some guys. So I update your patch. p.s. wait polling was mostly landed, except implementation for actions. it was in merge conflict. I fixed it, but looks like gate takes a lot of time before it be ready to merge | 16:15 |
skraynev_ | markvan: ping | 16:15 |
markvan | skraynev_: hi | 16:16 |
skraynev_ | markvan: I suppose, that we may close BP for openstack client implementation | 16:16 |
skraynev_ | markvan: hi ^ | 16:16 |
skraynev_ | markvan: I already update stevebaker's patch with release 1.0.0 heatclient | 16:16 |
skraynev_ | so I don't think, that we need to leave BP in open state, otherwise I need to move it to Newton | 16:17 |
skraynev_ | P.s. other related work IMO can be done without BP and tracked externally | 16:17 |
markvan | skraynev_: there are a couple minor work items left, some integration tests, can tools cleanup, but those are out side of strict osc work | 16:18 |
skraynev_ | markvan: so you agree ? | 16:18 |
markvan | yes | 16:18 |
skraynev_ | markvan: great thank you. | 16:19 |
*** wangbo has quit IRC | 16:19 | |
*** dims has quit IRC | 16:22 | |
skraynev_ | markvan: could you then update BP status | 16:23 |
skraynev_ | ? | 16:23 |
skraynev_ | to Implemented | 16:23 |
skraynev_ | or do it at Monday ? | 16:23 |
therve | skraynev, Isn't the client on a different schedule? | 16:23 |
skraynev_ | markvan: ^ | 16:23 |
therve | I thought we could release whenever we wanted | 16:23 |
skraynev_ | therve: I thought, that this week is last week for releasing clients, which will be used for Mitaka release. | 16:25 |
skraynev_ | let' me ask ttx | 16:25 |
therve | skraynev, I don't know, we released 0.9 last month? | 16:28 |
therve | I guess releasing now matters for the library, but not for the osc stuff which is for the shell | 16:28 |
*** vijendar has quit IRC | 16:29 | |
*** Raj1 has quit IRC | 16:35 | |
*** Raj1 has joined #heat | 16:35 | |
*** wangbo has joined #heat | 16:37 | |
openstackgerrit | Mark Vanderwiel proposed openstack/heat-templates: Use new openstack heat plugins for validation https://review.openstack.org/285414 | 16:38 |
jonesbr | skraynev_: I have updated the bp to implemented | 16:40 |
skraynev_ | jonesbr: thank you very much :) | 16:41 |
openstackgerrit | Mark Vanderwiel proposed openstack/heat-templates: Use new openstack heat plugins for validation https://review.openstack.org/285414 | 16:42 |
openstackgerrit | Merged openstack/heat: Add functional test for immutable parameters https://review.openstack.org/262274 | 16:44 |
openstackgerrit | Mark Vanderwiel proposed openstack/heat-templates: Use new openstack heat plugins for validation https://review.openstack.org/285414 | 16:44 |
*** vijendar has joined #heat | 16:44 | |
openstackgerrit | Mark Vanderwiel proposed openstack/heat-templates: Use new openstack heat plugins for validation https://review.openstack.org/285414 | 16:46 |
skraynev_ | therve: great. we can do merge more patches before 1.0.0 | 16:50 |
openstackgerrit | Rabi Mishra proposed openstack/heat: Use transactions instead of session.flush https://review.openstack.org/285425 | 16:50 |
therve | skraynev, Still there is a window where we can't release, which I didn't know about | 16:51 |
therve | Thanks for asking | 16:51 |
skraynev_ | therve: will add WIP for https://review.openstack.org/#/c/283852/2 | 16:51 |
*** Marga_ has quit IRC | 16:51 | |
*** Marga_ has joined #heat | 16:52 | |
skraynev_ | therve: np. thank you too. I just worried, that we can go out of the time.. | 16:53 |
*** vijendar1 has joined #heat | 16:53 | |
skraynev_ | so It's great new, that we have part of the next week for landing some other patches for python heatclient | 16:53 |
*** vijendar has quit IRC | 16:54 | |
therve | Yeah be careful, a week passes quickly :D | 16:54 |
*** vijendar has joined #heat | 16:54 | |
skraynev_ | jonesbr, markvan: could you please check this doc and make sure, that all other necessary patches for 1.0.0 are mentioned here https://etherpad.openstack.org/p/heat-support-python-openstackclient | 16:55 |
skraynev_ | therve: sure. we are 98% ready for that ;) | 16:55 |
jonesbr | skraynev_: Looks like that doc is up to date | 16:56 |
markvan | +1 | 16:57 |
skraynev_ | jonesbr: good. so we just need to fix merge conflicts and some comments | 16:57 |
*** Marga_ has quit IRC | 16:57 | |
*** Marga_ has joined #heat | 16:57 | |
*** vijendar1 has quit IRC | 16:58 | |
*** Drago has quit IRC | 16:59 | |
*** skraynev_ has quit IRC | 17:00 | |
*** Marga_ has quit IRC | 17:02 | |
*** cwolferh has joined #heat | 17:06 | |
*** dprince has joined #heat | 17:07 | |
openstackgerrit | Merged openstack/python-heatclient: Use poll_for_events for "openstack stack <action>" https://review.openstack.org/280400 | 17:08 |
*** dims has joined #heat | 17:09 | |
*** achanda has joined #heat | 17:10 | |
*** dims has quit IRC | 17:10 | |
*** mwheckma1n has joined #heat | 17:10 | |
*** vijendar1 has joined #heat | 17:11 | |
*** sabeen has joined #heat | 17:12 | |
*** xek__ has joined #heat | 17:13 | |
*** Kennan2 has joined #heat | 17:13 | |
*** manishg has joined #heat | 17:14 | |
*** pleia2_ has joined #heat | 17:15 | |
*** tlashchova has quit IRC | 17:15 | |
*** mikal_ has joined #heat | 17:15 | |
*** kmARC_ has joined #heat | 17:16 | |
*** kfox1111_ has joined #heat | 17:16 | |
*** sshen_ has joined #heat | 17:16 | |
*** bana_k has joined #heat | 17:18 | |
*** stevebak` has joined #heat | 17:19 | |
*** vijendar has quit IRC | 17:20 | |
*** mwheckmann has quit IRC | 17:20 | |
*** sabeen1 has quit IRC | 17:20 | |
*** yassine__ has quit IRC | 17:20 | |
*** Kennan has quit IRC | 17:20 | |
*** xek_ has quit IRC | 17:20 | |
*** Tristitia has quit IRC | 17:20 | |
*** miguelgrinberg has quit IRC | 17:20 | |
*** krotscheck has quit IRC | 17:20 | |
*** sshen has quit IRC | 17:20 | |
*** mikal has quit IRC | 17:20 | |
*** mkoderer__ has quit IRC | 17:20 | |
*** strictlyb has quit IRC | 17:20 | |
*** fbo_ has quit IRC | 17:20 | |
*** afazekas has quit IRC | 17:20 | |
*** pleia2 has quit IRC | 17:20 | |
*** kmARC has quit IRC | 17:20 | |
*** mburns has quit IRC | 17:20 | |
*** stevebaker has quit IRC | 17:20 | |
*** bapalm has quit IRC | 17:20 | |
*** kfox1111 has quit IRC | 17:20 | |
*** krotscheck has joined #heat | 17:20 | |
*** mburns_ has joined #heat | 17:20 | |
*** mkoderer___ has joined #heat | 17:20 | |
*** afazekas has joined #heat | 17:21 | |
*** miguelgrinberg_ has joined #heat | 17:21 | |
*** bapalm has joined #heat | 17:21 | |
*** strictlyb has joined #heat | 17:21 | |
*** miguelgrinberg_ is now known as miguelgrinberg | 17:21 | |
*** dims has joined #heat | 17:22 | |
*** fbo has joined #heat | 17:22 | |
*** Tristitia has joined #heat | 17:23 | |
*** yassine__ has joined #heat | 17:27 | |
*** blues-man has quit IRC | 17:27 | |
*** sabeen has quit IRC | 17:33 | |
*** sdake has joined #heat | 17:34 | |
*** Drago has joined #heat | 17:38 | |
*** bana_k has quit IRC | 17:40 | |
*** Drago has quit IRC | 17:40 | |
*** Drago has joined #heat | 17:40 | |
*** bana_k has joined #heat | 17:41 | |
*** bana_k has quit IRC | 17:42 | |
*** jistr has quit IRC | 17:49 | |
*** vijendar1 has quit IRC | 17:51 | |
*** manishg has quit IRC | 17:58 | |
*** manishg has joined #heat | 17:59 | |
*** derekh has quit IRC | 18:00 | |
*** Raj1 has quit IRC | 18:02 | |
*** vijendar has joined #heat | 18:03 | |
*** pt_15 has joined #heat | 18:08 | |
*** dims is now known as dimsum__ | 18:09 | |
*** Marga_ has joined #heat | 18:10 | |
*** Marga__ has joined #heat | 18:11 | |
*** Marga__ has quit IRC | 18:12 | |
*** Marga_ has quit IRC | 18:12 | |
*** Marga_ has joined #heat | 18:13 | |
*** Marga_ has quit IRC | 18:13 | |
*** jcoufal has quit IRC | 18:14 | |
*** Marga_ has joined #heat | 18:14 | |
*** dimtruck is now known as zz_dimtruck | 18:17 | |
*** jreeves has quit IRC | 18:30 | |
*** dprince has quit IRC | 18:49 | |
*** achanda has quit IRC | 18:51 | |
*** achanda has joined #heat | 18:55 | |
openstackgerrit | Crag Wolfe proposed openstack/python-heatclient: Prompt user before deleting stack if tty https://review.openstack.org/254351 | 19:10 |
*** dprince has joined #heat | 19:14 | |
*** dimsum__ has quit IRC | 19:16 | |
*** sridhar_ram has joined #heat | 19:19 | |
*** vijendar has quit IRC | 19:19 | |
*** dprince has quit IRC | 19:21 | |
*** dprince has joined #heat | 19:21 | |
*** Raj1 has joined #heat | 19:22 | |
*** Raj has joined #heat | 19:23 | |
*** vijendar has joined #heat | 19:24 | |
*** Raj1 has quit IRC | 19:26 | |
*** bana_k has joined #heat | 19:54 | |
*** zz_dimtruck is now known as dimtruck | 19:59 | |
openstackgerrit | Trevor McCasland proposed openstack/heat-cfntools: Changed logger init and added verbose arg handling https://review.openstack.org/284369 | 20:05 |
openstackgerrit | Mark Vanderwiel proposed openstack/heat-templates: Use new openstack heat plugins for validation https://review.openstack.org/285414 | 20:07 |
*** Raj has quit IRC | 20:19 | |
zaneb | randallburt: just need you +A on this trivial rebase and we can mark the penultimate blueprint as implemented :) https://review.openstack.org/#/c/270042/ | 20:25 |
randallburt | zaneb: looking | 20:25 |
zaneb | (you already +2'd prev patchset) | 20:26 |
randallburt | zaneb: ok, remind me, though. Why shouldn't we defer that to the nested stack? | 20:26 |
zaneb | randallburt: because you might want to replace the whole nested stack by marking it unhealthy | 20:27 |
randallburt | zaneb: fair enough and patchable later if that's the wrong thing to do. | 20:27 |
zaneb | sweet, thanks | 20:28 |
*** vijendar has quit IRC | 20:29 | |
randallburt | np | 20:29 |
*** sabeen has joined #heat | 20:39 | |
*** sabeen1 has joined #heat | 20:43 | |
*** achanda has quit IRC | 20:45 | |
*** sabeen has quit IRC | 20:45 | |
*** dims has joined #heat | 20:48 | |
*** vijendar has joined #heat | 20:50 | |
*** vijendar has quit IRC | 20:59 | |
*** vijendar has joined #heat | 21:11 | |
*** jdob has quit IRC | 21:13 | |
*** pt_15 has quit IRC | 21:15 | |
*** dyasny has quit IRC | 21:29 | |
*** jamielennox is now known as jamielennox|away | 21:43 | |
*** vijendar has quit IRC | 21:43 | |
*** spotz is now known as spotz_zzz | 21:57 | |
*** crose has quit IRC | 22:02 | |
*** Drago has quit IRC | 22:07 | |
*** jonesbr has left #heat | 22:11 | |
*** Drago has joined #heat | 22:12 | |
*** Marga_ has quit IRC | 22:16 | |
*** Marga_ has joined #heat | 22:16 | |
*** mburns_ is now known as mburns | 22:24 | |
*** randallburt has quit IRC | 22:28 | |
*** liusheng has quit IRC | 22:37 | |
*** liusheng has joined #heat | 22:38 | |
*** mwheckma1n has quit IRC | 22:41 | |
*** dimtruck is now known as zz_dimtruck | 22:43 | |
*** Marga_ has quit IRC | 22:48 | |
*** Marga_ has joined #heat | 22:49 | |
*** zz_dimtruck is now known as dimtruck | 22:52 | |
*** Marga_ has quit IRC | 22:53 | |
*** Drago has quit IRC | 22:54 | |
*** jtomasek has quit IRC | 22:54 | |
*** sridhar_ram1 has joined #heat | 23:03 | |
*** neelashah has quit IRC | 23:04 | |
*** sridhar_ram has quit IRC | 23:05 | |
*** rpothier has quit IRC | 23:06 | |
*** dims has quit IRC | 23:07 | |
*** yassine__ has quit IRC | 23:07 | |
*** dimtruck is now known as zz_dimtruck | 23:12 | |
*** Marga_ has joined #heat | 23:15 | |
*** ccard_ has joined #heat | 23:16 | |
*** Drago has joined #heat | 23:17 | |
*** Drago has quit IRC | 23:18 | |
*** Drago has joined #heat | 23:18 | |
*** ccard__ has quit IRC | 23:19 | |
*** Marga_ has quit IRC | 23:19 | |
*** Drago1 has joined #heat | 23:21 | |
*** Drago has quit IRC | 23:25 | |
*** Drago1 has quit IRC | 23:26 | |
*** dims has joined #heat | 23:34 | |
*** sridhar_ram1 has quit IRC | 23:40 | |
*** sridhar_ram has joined #heat | 23:42 | |
*** sdake has quit IRC | 23:53 | |
*** sdake_ has joined #heat | 23:53 | |
*** zz_dimtruck is now known as dimtruck | 23:53 | |
*** Marga_ has joined #heat | 23:55 | |
*** Qiming has joined #heat | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!