| *** jamielennox is now known as jamielennox|away | 00:00 | |
| *** Alexey_Abashkin_ has quit IRC | 00:13 | |
| *** jamielennox|away is now known as jamielennox | 00:14 | |
| *** Alexey_Abashkin_ has joined #heat | 00:14 | |
| *** Alexey_Abashkin_ has quit IRC | 00:18 | |
| *** adrian_otto has quit IRC | 00:21 | |
| *** vishwanathj has quit IRC | 00:22 | |
| *** Alexey_Abashkin_ has joined #heat | 00:32 | |
| *** zhurong has joined #heat | 01:13 | |
| *** bana_k has quit IRC | 01:15 | |
| *** sdake_ has joined #heat | 01:19 | |
| *** sdake has quit IRC | 01:21 | |
| openstackgerrit | huangtianhua proposed openstack/heat: Return condition functions based on the filter param https://review.openstack.org/369860 | 01:22 |
|---|---|---|
| *** yanyanhu has joined #heat | 01:24 | |
| *** zhihui has joined #heat | 01:30 | |
| *** steveg_afk has quit IRC | 01:54 | |
| ramishra | stevebaker: hey around? | 01:54 |
| stevebaker | ramishra: hai | 01:54 |
| ramishra | stevebaker: I think heatclient stable/newton is missing some more stuff like the env merging | 01:55 |
| ramishra | stevebaker: I think tripleo is using that for their newton release | 01:55 |
| stevebaker | oh, thats important | 01:55 |
| stevebaker | ramishra: can you backport what else is needed? and also review https://review.openstack.org/#/c/373531/ ? | 01:58 |
| stevebaker | ramishra: then I'll review yours and do a release when they land | 01:58 |
| ramishra | yes, I'll though I can't +2 any of those:) | 01:58 |
| stevebaker | it'll need to be 1.5.0 | 01:58 |
| stevebaker | meh, I'll approve them. 2 cores +1 is enough | 01:59 |
| *** vijendar has joined #heat | 01:59 | |
| ramishra | btw, can you review https://review.openstack.org/#/c/367502/? I think murano team were making noise about it, good if we can get that fix in. | 01:59 |
| stevebaker | sure | 02:00 |
| stevebaker | ramishra: approved. should it be backported too? | 02:01 |
| ramishra | yeah, I'll do that | 02:02 |
| ramishra | I think it should do without backporting in 1.5.0 | 02:02 |
| stevebaker | ok | 02:02 |
| openstackgerrit | zhufl proposed openstack/heat: Remove unnecessary setUp and tearDown https://review.openstack.org/373586 | 02:03 |
| *** vijendar has quit IRC | 02:04 | |
| *** dimtruck is now known as zz_dimtruck | 02:05 | |
| ramishra | stevebaker: done the env merge one. I don't see anything else that needs backporting. should we tag 1.5.0 too? | 02:11 |
| stevebaker | ramishra: the stable/newton release will be 1.5.0, because it has a new feature | 02:11 |
| stevebaker | ramishra: we could do a 1.6.0 on master when the releases repo opens up ocata | 02:12 |
| ramishra | stevebaker: ok, thanks. | 02:13 |
| *** zz_dimtruck is now known as dimtruck | 02:15 | |
| openstackgerrit | Merged openstack/python-heatclient: Don't use endpoint_override with session https://review.openstack.org/367502 | 02:17 |
| openstackgerrit | zhufl proposed openstack/heat: Add missing %s in print message https://review.openstack.org/373595 | 02:29 |
| stevebaker | ramishra: ugh, I can't approve this either https://review.openstack.org/#/c/373531/ | 02:38 |
| *** caowei has joined #heat | 02:39 | |
| ramishra | stevebaker: hehe.. have to wait for skraynev or therve :) | 02:41 |
| *** jdandrea_ has joined #heat | 02:44 | |
| openstackgerrit | zhufl proposed openstack/heat: Add missing %s in print message https://review.openstack.org/373595 | 02:44 |
| *** jdandrea has quit IRC | 02:47 | |
| *** cmyster has quit IRC | 02:49 | |
| *** elynn has joined #heat | 02:50 | |
| *** yuanying has quit IRC | 02:52 | |
| *** priteau has joined #heat | 02:53 | |
| *** elynn has quit IRC | 02:55 | |
| *** elynn has joined #heat | 02:56 | |
| *** priteau has quit IRC | 02:58 | |
| *** david-lyle has quit IRC | 03:04 | |
| *** cmyster has joined #heat | 03:04 | |
| *** sdake_ has quit IRC | 03:42 | |
| openstackgerrit | zhufl proposed openstack/heat: Remove unnecessary __init__ https://review.openstack.org/373625 | 03:45 |
| *** yuanying has joined #heat | 03:49 | |
| *** dimtruck is now known as zz_dimtruck | 04:16 | |
| *** zz_dimtruck is now known as dimtruck | 04:16 | |
| *** dimtruck is now known as zz_dimtruck | 04:25 | |
| *** KanagarajM has joined #heat | 04:34 | |
| openstackgerrit | Merged openstack/heat: Add missing %s in print message https://review.openstack.org/373595 | 04:35 |
| *** elynn has quit IRC | 04:36 | |
| *** jaosorior has joined #heat | 04:50 | |
| *** elynn has joined #heat | 04:53 | |
| *** code-R has joined #heat | 04:56 | |
| *** elynn has quit IRC | 04:58 | |
| *** elynn has joined #heat | 04:58 | |
| *** jaosorior has quit IRC | 05:10 | |
| *** jaosorior has joined #heat | 05:11 | |
| *** bana_k has joined #heat | 05:15 | |
| *** caowei has quit IRC | 05:32 | |
| *** mohankumar has joined #heat | 05:41 | |
| *** bana_k has quit IRC | 05:45 | |
| *** vijendar has joined #heat | 05:48 | |
| *** code-R has quit IRC | 05:51 | |
| *** caowei has joined #heat | 05:52 | |
| *** vijendar has quit IRC | 05:54 | |
| *** akuznetsov has joined #heat | 05:58 | |
| *** code-R has joined #heat | 05:58 | |
| *** rcernin has joined #heat | 06:07 | |
| *** akuznetsov has quit IRC | 06:08 | |
| *** code-R_ has joined #heat | 06:09 | |
| *** akuznetsov has joined #heat | 06:12 | |
| *** code-R has quit IRC | 06:12 | |
| *** shardy has joined #heat | 06:14 | |
| openstackgerrit | shizhihui proposed openstack/heat: Trivial:Standardize the output format of 'help' in some files https://review.openstack.org/363567 | 06:20 |
| *** jprovazn has joined #heat | 06:35 | |
| *** akuznetsov has quit IRC | 06:36 | |
| *** sshnaidm|afk is now known as sshnaidm | 06:44 | |
| *** code-R_ has quit IRC | 06:45 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-heatclient: Replace MagicMock with Mock class https://review.openstack.org/373792 | 06:51 |
| skraynev | stevebaker: ramishra: +W | 06:51 |
| openstackgerrit | huangtianhua proposed openstack/heat: Add Ocata version '8.0.0' in doc https://review.openstack.org/373797 | 06:58 |
| *** ccamacho has joined #heat | 07:08 | |
| *** akuznetsov has joined #heat | 07:08 | |
| *** yprokule has joined #heat | 07:10 | |
| *** Alexey_Abashkin_ has quit IRC | 07:20 | |
| openstackgerrit | Shu Yingya proposed openstack/heat: Remove remaining 'heat/openstack/common' from heat https://review.openstack.org/373807 | 07:22 |
| *** AlexeyAbashkin has joined #heat | 07:23 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/373698 | 07:26 |
| openstackgerrit | Rico Lin proposed openstack/heat: Add a new HOT template version for Ocata https://review.openstack.org/373814 | 07:28 |
| *** ricolin has joined #heat | 07:28 | |
| *** jpich has joined #heat | 07:36 | |
| *** code-R has joined #heat | 07:37 | |
| *** mohankumar has quit IRC | 07:38 | |
| openstackgerrit | Shu Yingya proposed openstack/heat: Remove remaining 'heat/openstack/common' from heat https://review.openstack.org/373807 | 07:40 |
| *** akuznetsov has quit IRC | 07:41 | |
| *** code-R has quit IRC | 07:46 | |
| stevebaker | skraynev: thanks | 07:48 |
| *** vijendar has joined #heat | 07:50 | |
| skraynev | np :) | 07:51 |
| *** blues-man has joined #heat | 07:52 | |
| *** akuznetsov has joined #heat | 07:54 | |
| ramishra | it seems gate broken again, this time with latest openstacksdk/osc | 07:54 |
| *** vijendar has quit IRC | 07:55 | |
| stevebaker | ramishra: can you point to a change? | 07:55 |
| stevebaker | thatis failing? | 07:56 |
| ramishra | I've proposed a work around for the time being https://review.openstack.org/#/c/373850 | 07:56 |
| ramishra | stevebaker: https://bugs.launchpad.net/python-openstackclient/+bug/1625954, I've proposed a fix too:) | 07:56 |
| openstack | Launchpad bug 1625954 in python-openstackclient "router_interface_add/remove broken with openstacksdk" [Undecided,In progress] - Assigned to Rabi Mishra (rabi) | 07:56 |
| * cmyster looks at the time | 07:56 | |
| cmyster | stevebaker: hi | 07:56 |
| stevebaker | cmyster: hey | 07:57 |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #heat | 08:00 | |
| openstackgerrit | huangtianhua proposed openstack/heat: Add networking-sfc port-pair-group resource plug-in https://review.openstack.org/277849 | 08:02 |
| *** code-R has joined #heat | 08:02 | |
| ramishra | do we've a meeting now, therve? | 08:02 |
| therve | We do! | 08:02 |
| therve | shardy, skraynev, elynn meeting if you can | 08:05 |
| therve | KanagarajM maybe | 08:05 |
| * shardy joins | 08:05 | |
| *** akuznetsov has quit IRC | 08:06 | |
| *** ricolin_afk has joined #heat | 08:08 | |
| *** yassine has joined #heat | 08:09 | |
| *** yassine is now known as Guest98774 | 08:10 | |
| *** ricolin has quit IRC | 08:11 | |
| *** code-R has quit IRC | 08:11 | |
| *** akuznetsov has joined #heat | 08:12 | |
| *** mohankumar has joined #heat | 08:22 | |
| *** jaosorior is now known as jaosorior_brb | 08:28 | |
| *** ricolin has joined #heat | 08:40 | |
| *** ricolin_afk has quit IRC | 08:40 | |
| *** shardy has quit IRC | 08:42 | |
| *** ricolin_afk has joined #heat | 08:43 | |
| *** derekh has joined #heat | 08:44 | |
| *** ricolin_afk has quit IRC | 08:44 | |
| *** ricolin_afk has joined #heat | 08:45 | |
| *** ricolin has quit IRC | 08:47 | |
| *** sorantis has joined #heat | 08:48 | |
| *** shardy has joined #heat | 08:52 | |
| *** akuznetsov has quit IRC | 08:57 | |
| *** sorantis has quit IRC | 08:59 | |
| openstackgerrit | Rico Lin proposed openstack/heat: Add a new HOT template version for Ocata https://review.openstack.org/373814 | 08:59 |
| *** sorantis has joined #heat | 09:04 | |
| *** nijaba has quit IRC | 09:05 | |
| *** akuznetsov has joined #heat | 09:06 | |
| *** nijaba has joined #heat | 09:06 | |
| *** nijaba has quit IRC | 09:06 | |
| *** nijaba has joined #heat | 09:06 | |
| *** akuznetsov has quit IRC | 09:08 | |
| *** yanyanhu has quit IRC | 09:10 | |
| *** yanyanhu has joined #heat | 09:11 | |
| *** yanyanhu has quit IRC | 09:11 | |
| *** bks has joined #heat | 09:16 | |
| *** akuznetsov has joined #heat | 09:20 | |
| *** mohankumar has quit IRC | 09:29 | |
| *** code-R has joined #heat | 09:30 | |
| *** code-R_ has joined #heat | 09:31 | |
| *** ricolin_afk has quit IRC | 09:32 | |
| *** ricolin has joined #heat | 09:32 | |
| *** code-R has quit IRC | 09:34 | |
| *** vijendar has joined #heat | 09:51 | |
| *** akuznetsov has quit IRC | 09:51 | |
| *** vijendar has quit IRC | 09:56 | |
| openstackgerrit | Rico Lin proposed openstack/heat: Make more clear diff in hot template functions https://review.openstack.org/373981 | 09:57 |
| *** akuznetsov has joined #heat | 09:57 | |
| *** ricolin has quit IRC | 09:59 | |
| shardy | therve: Hey, I raised two bugs describing the nested validation issues we're hitting: | 10:00 |
| shardy | https://bugs.launchpad.net/heat/+bug/1626022 | 10:00 |
| openstack | Launchpad bug 1626022 in heat "Nested validation issues with non-defaulted nested parameters" [Undecided,New] | 10:00 |
| shardy | https://bugs.launchpad.net/heat/+bug/1626025 | 10:00 |
| openstack | Launchpad bug 1626025 in heat "Nested validation breaks with ResourceGroup and non-defaulted count parameter" [Undecided,New] | 10:00 |
| shardy | I think the second one we can actually fix in tht by just adding a default value of zero | 10:00 |
| shardy | but it's still kind of unexpected for validation to fail when the template isn't broken | 10:01 |
| *** zhurong has quit IRC | 10:02 | |
| therve | shardy, Thanks, will look at it | 10:07 |
| *** akuznetsov has quit IRC | 10:20 | |
| *** sshnaidm has quit IRC | 10:37 | |
| *** sshnaidm has joined #heat | 10:42 | |
| *** steveg_afk has joined #heat | 10:43 | |
| *** prazumovsky has joined #heat | 10:44 | |
| *** dfflanders has quit IRC | 10:47 | |
| *** code-R_ has quit IRC | 10:56 | |
| *** code-R has joined #heat | 10:56 | |
| therve | shardy, I don't totally get https://bugs.launchpad.net/heat/+bug/1626022 | 11:01 |
| openstack | Launchpad bug 1626022 in heat "Nested validation issues with non-defaulted nested parameters" [Undecided,New] | 11:01 |
| therve | shardy, The issue is that if you remove, say, from_parent_attr: {get_attr: [a_resource, value]}, validation will succeed? | 11:01 |
| shardy | therve: No, the problem is that the schema exposed via NestedParameters doesn't convey that a value will be passed from the parent stack | 11:02 |
| shardy | e.g there's only a Value field for from_parent_param_default | 11:03 |
| shardy | therve: this makes it impossible to decide which parameters have values passed down from the parent, and which require user input (e.g via parameter_defaults in the environment) | 11:03 |
| therve | Ah | 11:04 |
| shardy | some kind of easily identifiable placeholder from the parent in Value would solve that | 11:04 |
| therve | shardy, So you'd like something in the Value field | 11:04 |
| shardy | yeah | 11:04 |
| therve | Ok, understood | 11:04 |
| shardy | it's mostly so the Ux can build an interface from this schema | 11:04 |
| shardy | we don't want to ask the user for things we know are passed from the parent | 11:04 |
| *** shardy is now known as shardy_lunch | 11:05 | |
| therve | I'd like to blame parameter_defaults for that :) | 11:05 |
| *** mewald_ has joined #heat | 11:05 | |
| mewald_ | What's currently the best way to distribute instances across availability zones with heat? I've browser the internet a bit but haven't found any satisfying solution | 11:07 |
| *** steveg_afk has quit IRC | 11:09 | |
| *** mohankumar has joined #heat | 11:17 | |
| *** elynn has quit IRC | 11:17 | |
| openstackgerrit | Merged openstack/heat: Use neutron cli command instead of osc https://review.openstack.org/373850 | 11:21 |
| openstackgerrit | Merged openstack/heat: Add Ocata version '8.0.0' in doc https://review.openstack.org/373797 | 11:22 |
| *** jaosorior_brb is now known as jaosorior | 11:28 | |
| *** shardy_lunch is now known as shardy | 11:29 | |
| *** EricGonczer_ has joined #heat | 11:34 | |
| *** code-R_ has joined #heat | 11:42 | |
| mewald_ | I feel like the best solution to spreading instances across availbility zones might be to wrap Heat with Ansible and template the HOTs with jinja2. Any experience with that? | 11:43 |
| *** code-R has quit IRC | 11:45 | |
| *** sshnaidm is now known as sshnaidm|afk | 11:47 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/373698 | 11:49 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Add parameters and outputs template migrate https://review.openstack.org/373373 | 11:50 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Add check for unsupported resource to tmpl migrate https://review.openstack.org/373377 | 11:50 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Add function migration to template migrate https://review.openstack.org/373375 | 11:50 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Add migrate version to actual HOT template version https://review.openstack.org/373376 | 11:50 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Add resource keys translation in template migrate https://review.openstack.org/373374 | 11:51 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Initial implementation template migrate mechanism https://review.openstack.org/370153 | 11:51 |
| *** vijendar has joined #heat | 11:52 | |
| *** zhurong has joined #heat | 11:54 | |
| *** bks has quit IRC | 11:57 | |
| *** vijendar has quit IRC | 11:58 | |
| therve | ramishra, There is something really weird going on in tests | 12:06 |
| therve | We have some pretty strange intermittent failures | 12:06 |
| ramishra | therve: yeah, I could not understand some of the failures. Did you notice anything specific? | 12:08 |
| therve | ramishra, Not really. It seems to be around tests with signals though. | 12:09 |
| therve | I'm looking at http://logs.openstack.org/50/373850/1/check/gate-heat-dsvm-functional-orig-mysql-lbaasv2/603074a/ currently | 12:09 |
| therve | Suddenly there is a DELETE in the middle of the test for no apparent reason | 12:09 |
| ramishra | yeah, I agree. It's happening mostly for non-convergence path. | 12:13 |
| *** dprince has joined #heat | 12:13 | |
| ramishra | I think I raised a bug sometime back, where there was nothing after a delete rpc message https://bugs.launchpad.net/heat/+bug/1617130 | 12:14 |
| openstack | Launchpad bug 1617130 in heat "test_resource_group functional test times out for delete " [Medium,New] - Assigned to Rabi Mishra (rabi) | 12:14 |
| therve | ramishra, http://logs.openstack.org/14/373614/1/gate/gate-heat-dsvm-functional-convg-mysql-lbaasv2/d5c33eb/console.html this convergence one is weird too | 12:14 |
| *** steveg_afk has joined #heat | 12:15 | |
| *** annegentle has joined #heat | 12:16 | |
| ramishra | Another one http://logs.openstack.org/15/373615/1/gate/gate-heat-dsvm-functional-convg-mysql-lbaasv2/8e33b52/console.html#_2016-09-21_11_58_10_276335 | 12:22 |
| therve | Yeah I opened one yesterday, though it looks a bit different | 12:23 |
| ramishra | yeah, I saw that. | 12:25 |
| *** crose has joined #heat | 12:25 | |
| therve | I'll open bugs to track them at least | 12:28 |
| *** dyasny has quit IRC | 12:28 | |
| *** EricGonczer_ has quit IRC | 12:29 | |
| *** sshnaidm|afk is now known as sshnaidm | 12:32 | |
| ramishra | I've added SDG test error backtrace with 'heatclient.exc.HTTPNotFound: ERROR: None' to an earlier bug for the same test. | 12:32 |
| ramishra | though it would have been another bug. | 12:33 |
| ramishra | https://bugs.launchpad.net/heat/+bug/1625921/comments/1 | 12:34 |
| openstack | Launchpad bug 1625921 in heat "SoftwareDeploymentGroupTest fails at times with TimeoutException" [Medium,New] | 12:34 |
| *** askb has quit IRC | 12:35 | |
| *** zhihui has quit IRC | 12:38 | |
| *** dyasny has joined #heat | 12:42 | |
| therve | OK | 12:45 |
| therve | ramishra, https://bugs.launchpad.net/heat/+bug/1626075 is a simple race condition | 12:46 |
| openstack | Launchpad bug 1626075 in heat "test_hook_pre_update_in_place intermittently fails" [Medium,New] | 12:46 |
| therve | We store the event, but the hook is not yet in place, so the test doesn't find it | 12:46 |
| therve | Possibly just inverting the operations would be good enough | 12:46 |
| *** annegentle has quit IRC | 12:47 | |
| openstackgerrit | Thomas Herve proposed openstack/heat: Set hooks before storing events https://review.openstack.org/374115 | 12:49 |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: [WIP] Add API call for template migrate https://review.openstack.org/374119 | 12:53 |
| *** crose has quit IRC | 12:56 | |
| *** david-lyle has joined #heat | 12:56 | |
| *** jcoufal has joined #heat | 12:57 | |
| *** tung_doan has joined #heat | 13:03 | |
| *** zz_dimtruck is now known as dimtruck | 13:03 | |
| openstackgerrit | Mohankumar proposed openstack/heat: Add networking-sfc port-pair-group resource plug-in https://review.openstack.org/277849 | 13:04 |
| *** vishwanathj has joined #heat | 13:06 | |
| *** dimtruck is now known as zz_dimtruck | 13:08 | |
| *** zz_dimtruck is now known as dimtruck | 13:08 | |
| *** jaosorior has quit IRC | 13:10 | |
| *** jaosorior has joined #heat | 13:11 | |
| *** vijendar has joined #heat | 13:12 | |
| mohankumar | prazumovsky : ping | 13:14 |
| prazumovsky | hello | 13:15 |
| mohankumar | prazumovsky : Appened patch with your review comments , Could you pls review while you find time :) (have little doubt in my understanding) | 13:15 |
| mohankumar | prazumovsky : https://review.openstack.org/#/c/277849/ | 13:15 |
| prazumovsky | done | 13:16 |
| mohankumar | prazumovsky : great ! | 13:17 |
| *** dimtruck is now known as zz_dimtruck | 13:18 | |
| *** vijendar has quit IRC | 13:18 | |
| openstackgerrit | Peter Razumovsky proposed openstack/python-heatclient: [WIP] add cli command for template migrate https://review.openstack.org/374140 | 13:21 |
| mewald_ | I feel like the best solution to spreading instances across availbility zones might be to wrap Heat with Ansible and template the HOTs with jinja2. Any experience with that? | 13:29 |
| mewald_ | I feel like the best solution to spreading instances across availbility zones might be to wrap Heat with Ansible and template the HOTs with jinja2. Any experience with that? | 13:29 |
| *** mewald_ has quit IRC | 13:29 | |
| *** blomquisg_gone is now known as blomquisg | 13:29 | |
| *** code-R_ has quit IRC | 13:34 | |
| *** code-R has joined #heat | 13:36 | |
| *** spzala has joined #heat | 13:47 | |
| *** jrist has quit IRC | 13:52 | |
| *** blues-man has quit IRC | 13:53 | |
| *** akshai has joined #heat | 13:55 | |
| *** KanagarajM has quit IRC | 13:56 | |
| *** lifeless has quit IRC | 13:57 | |
| *** sdake has joined #heat | 13:59 | |
| *** lifeless has joined #heat | 13:59 | |
| *** sdake has quit IRC | 13:59 | |
| *** sdake has joined #heat | 14:00 | |
| *** jasond has joined #heat | 14:00 | |
| *** tanvirt has joined #heat | 14:03 | |
| *** tanvirt has quit IRC | 14:03 | |
| *** tanvirt has joined #heat | 14:03 | |
| *** jasond has quit IRC | 14:05 | |
| *** jasond has joined #heat | 14:06 | |
| *** jrist has joined #heat | 14:07 | |
| *** cmartin has joined #heat | 14:10 | |
| *** spedione|AWAY is now known as spedione | 14:10 | |
| *** annegentle has joined #heat | 14:11 | |
| *** jasond has quit IRC | 14:12 | |
| *** pradk_ has joined #heat | 14:13 | |
| *** dyasny has quit IRC | 14:23 | |
| *** pradk has quit IRC | 14:26 | |
| *** pradk_ is now known as pradk | 14:26 | |
| *** dyasny has joined #heat | 14:26 | |
| *** mohankumar has quit IRC | 14:27 | |
| *** mfisch has quit IRC | 14:28 | |
| *** rajpatel has joined #heat | 14:28 | |
| *** rajpatel1 has joined #heat | 14:30 | |
| *** mfisch has joined #heat | 14:32 | |
| *** mfisch has quit IRC | 14:32 | |
| *** mfisch has joined #heat | 14:32 | |
| *** rajpatel has quit IRC | 14:33 | |
| *** zz_dimtruck is now known as dimtruck | 14:33 | |
| *** akshai has quit IRC | 14:40 | |
| *** akshai has joined #heat | 14:43 | |
| *** crose has joined #heat | 14:44 | |
| *** caowei has quit IRC | 14:48 | |
| *** akshai has quit IRC | 14:49 | |
| *** netmanager has joined #heat | 14:49 | |
| *** zhurong has quit IRC | 14:51 | |
| *** akshai has joined #heat | 14:52 | |
| *** jprovazn has quit IRC | 14:53 | |
| *** jprovazn has joined #heat | 14:55 | |
| *** netmanager has quit IRC | 14:55 | |
| *** openstack has joined #heat | 15:03 | |
| *** sorantis has joined #heat | 15:05 | |
| *** vijendar has quit IRC | 15:18 | |
| *** sorantis has quit IRC | 15:19 | |
| *** Drago has joined #heat | 15:20 | |
| *** vijendar has joined #heat | 15:22 | |
| *** vijendar has quit IRC | 15:27 | |
| *** Guest98774 has quit IRC | 15:28 | |
| *** Guest98774 has joined #heat | 15:32 | |
| *** prazumovsky has quit IRC | 15:38 | |
| *** jaosorior has quit IRC | 15:39 | |
| *** bks has joined #heat | 15:45 | |
| *** ccamacho is now known as ccamacho|afk | 15:47 | |
| *** ramishra has quit IRC | 15:48 | |
| *** d0ugal has quit IRC | 15:48 | |
| *** bana_k has joined #heat | 15:49 | |
| *** d0ugal has joined #heat | 15:49 | |
| *** ramishra has joined #heat | 15:50 | |
| *** kumarb has joined #heat | 15:51 | |
| EmilienM | hi, Puppet OpenStack reported a bug in heat: https://bugs.launchpad.net/heat/+bug/1626173 | 15:52 |
| openstack | Launchpad bug 1626173 in heat "stack failed to reach DELETE_COMPLETE status (timeout)" [Undecided,New] | 15:52 |
| EmilienM | we have this timeout very often recently | 15:52 |
| EmilienM | I was wondering if you had the same in your gate | 15:52 |
| EmilienM | shardy, therve ^ fyi | 15:52 |
| *** bks has quit IRC | 15:52 | |
| *** spotz_zzz is now known as spotz | 15:53 | |
| tanvirt | zaneb: Continuing our discussion of the bug at: https://bugs.launchpad.net/heat/+bug/1570576. I'm inside the update_task() method inside heat/engine/stack.py. In order for me to steal the lock from the dead engine, I need the engine_id. How I can retreive that from here? | 15:55 |
| openstack | Launchpad bug 1570576 in heat "After updating a stack stuck IN_PROGRESS, resources will be permanently stuck IN_PROGRESS" [High,Triaged] - Assigned to Tanvir Talukder (tanvirt16) | 15:55 |
| zaneb | EmilienM: by happy coincidence I believe I have a fix for that one | 15:57 |
| zaneb | tanvirt: looking... | 15:57 |
| EmilienM | zaneb: nice :) please let me know in the bug report or on IRC! thanks | 15:58 |
| zaneb | tanvirt: create a StackLock object. try to acquire() it and it'll return the engine ID if something else is holding the lock | 15:58 |
| tanvirt | zaneb: but doesn't the creation of a StackLock object require an engine_id as a parameter? | 15:59 |
| zaneb | tanvirt: ah, you mean our local engine_id | 16:00 |
| *** vijendar has joined #heat | 16:00 | |
| zaneb | tanvirt: I can't actually think of a way to get back the the EngineService object. The easiest way might be to send an RPC message to do what you need to do and let some other engine handle it in its EngineService object | 16:02 |
| *** rcernin has quit IRC | 16:03 | |
| zaneb | EmilienM: do you _always_ see that error message? Just trying to establish if there could be multiple causes | 16:03 |
| tanvirt | zaneb: hmmm... another option may be to somehow utilize the get_engine_id method inside the StackLock object. I'd have to create a variation of it with parameters like: get_engine_id(context stack_id), and make it a class method. Any thoughts? | 16:05 |
| iurygregory | zaneb, some times this error show up and we do recheck (las time: http://logs.openstack.org/67/373967/2/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/a7960f6/console.html#_2016-09-21_15_01_51_161249, http://logs.openstack.org/67/373967/2/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7-nv/dcf98e6/console.html#_2016-09-21_13_54_22_914887) | 16:06 |
| iurygregory | is just in scenario003 jobs in puppet-openstack =) | 16:07 |
| *** EricGonczer_ has joined #heat | 16:07 | |
| openstackgerrit | Oleksii Chuprykov proposed openstack/heat: Return error with path in function validate https://review.openstack.org/373451 | 16:08 |
| tanvirt | zaneb: or I can make the engine_id an optional paramter for the StackLock object, with the default value being whats returned by the get_engine_id method | 16:09 |
| EmilienM | zaneb: no, but very often recently | 16:09 |
| *** Drago1 has joined #heat | 16:09 | |
| zaneb | tanvirt: StackLock.get_engine_id() returns the ID of the engine that has the lock. StackLock.__init__() takes the ID of the current engine, so that when you acquire the lock it knows to say who has it. | 16:09 |
| *** Drago has quit IRC | 16:10 | |
| *** Drago1 is now known as Drago | 16:10 | |
| EmilienM | zaneb: what iurygregory means is that our "scenario003" is the only one which test Heat. | 16:10 |
| zaneb | EmilienM: ok, we'll squash that one first and see what's left behind | 16:10 |
| tanvirt | zaneb: ah, ok | 16:10 |
| zaneb | iurygregory, EmilienM: to be clear, I was asking if http://logs.openstack.org/67/373967/2/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/a7960f6/logs/heat/heat-engine.txt.gz#_2016-09-21_14_41_38_553 always shows up when the delete times out | 16:12 |
| *** jprovazn has quit IRC | 16:12 | |
| EmilienM | zaneb: yes | 16:13 |
| EmilienM | zaneb: I saw it everytime I see the timeout | 16:13 |
| zaneb | EmilienM: oh, excellent :) | 16:13 |
| zaneb | should be only one bug to squash then | 16:13 |
| *** crose has quit IRC | 16:15 | |
| *** KanagarajM has joined #heat | 16:20 | |
| *** spzala has quit IRC | 16:30 | |
| *** spzala has joined #heat | 16:31 | |
| *** tung_doan has left #heat | 16:33 | |
| *** adrian_otto1 has joined #heat | 16:35 | |
| *** crose has joined #heat | 16:35 | |
| *** spzala has quit IRC | 16:37 | |
| *** vijendar has quit IRC | 16:41 | |
| zzzeek | zaneb: I lied https://bitbucket.org/zzzeek/sqlalchemy/issues/3258/a-gevent-killed-greenlet-causes-pymysql | 16:43 |
| zaneb | zzzeek: there was one! :) | 16:46 |
| zzzeek | zaneb: there were two :) | 16:46 |
| *** spzala has joined #heat | 16:46 | |
| zzzeek | zaneb: but, i think the whole gevent thing only started catching on like 2013/2014 and at this point it's likely on the wane | 16:46 |
| zzzeek | at least the "global monkeypatch" variety | 16:46 |
| zaneb | with any luck | 16:47 |
| *** rpothier has joined #heat | 16:47 | |
| zzzeek | zaneb: so yeah I "knew" this on the openstack-dev list from old muscle memory :) | 16:48 |
| * zzzeek is old | 16:48 | |
| *** jpich has quit IRC | 16:48 | |
| zzzeek | facts are jumbled and dusty | 16:48 |
| zzzeek | zaneb: from these two issues at least the invalidation mechanics were made to withstand this condition | 16:49 |
| zaneb | zzzeek: so IIUC, the issue is all the lines like https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/base.py#L702 are only catching Exception, and if you added another handler to catch BaseException + call _handle_dbapi_exception() + always always always re-raise the original exception, then everything would work? | 16:49 |
| *** adrian_otto1 has quit IRC | 16:49 | |
| zzzeek | zaneb: almost. I would like to just allow create_engine("mysql+pymysql://...", handle_exceptions=(greenlet.GreenletExit, )) | 16:50 |
| zzzeek | something like that | 16:50 |
| *** rwsu has quit IRC | 16:51 | |
| zzzeek | zaneb: I still dont think getting involved with KeyboardInterrupt / SystemExit by default is something I could relax with | 16:51 |
| zaneb | zzzeek: ok. I still don't agree that GreenletExit is a special case here | 16:51 |
| zzzeek | zaneb: it's more like, I cannot conceive of what will go wrong if keybaordinterrupt/systemexit suddenly makes tons of new code run for people, only that very disastrous effects have occurred from much, much more innocuous-seeming things | 16:52 |
| zaneb | zzzeek: as long as you never ever ever wrap or suppress exit exceptions, then there's no problem handling them, and in fact cleaning up when they happen is the right thing to do | 16:52 |
| zaneb | zzzeek: I totally get that you are in a very conservative line of work :) | 16:53 |
| zzzeek | zaneb: messing w/ the boundaries of the interpreter is creepy | 16:53 |
| zzzeek | glad to make it an optoin | 16:53 |
| *** randallburt has joined #heat | 16:53 | |
| zzzeek | zaneb: an old example that recently I revisited is, you connect from the connection pool. then you just drop the connection, don't close it or return it. OK let's use __del__ and automatically return it. easy! | 16:54 |
| zaneb | I don't feel like it's messing with the boundaries of the interpreter. if you weren't supposed to be able to clean up after getting a signal then Python wouldn't raise an exception, it would just exit | 16:54 |
| zzzeek | 8 zillion bug reports and changes later, I ultimately had to use my own Queue.Queue implementation etc. b.c. there were deadlocks in the wild | 16:55 |
| zzzeek | change __del__ to be weakref callback | 16:55 |
| zzzeek | etc | 16:55 |
| zaneb | __del__ is nasty | 16:55 |
| *** randallburt1 has joined #heat | 16:55 | |
| zzzeek | well it's weakref callback now. however, it caused deadlocks. because gc.collect() runs whenever it feels like, such as inside the mutex in Queue.put() | 16:55 |
| zzzeek | QueuePool is still technically wrong because calling Queue.Queue.put() reentrant-ly does not guarantee its internal state | 16:56 |
| zzzeek | zaneb: also, the variety of "cleanup" we're talking about here is very strange. I know of no other way to put a pymysql connection in this broken state except for unsynchronized access | 16:57 |
| *** randallburt has quit IRC | 16:58 | |
| *** akuznetsov has quit IRC | 16:58 | |
| zzzeek | only greenlet's magic breakage of sockets can really make this happen. the whole "monkeypatch" use case IMO should not be used | 16:58 |
| zaneb | zzzeek: say that there's a KeyboardInterrupt. when would the user ever want to not clean up afterwards, and be like "no, I'd rather you return that borked connection to the pool so that some future unrelated transaction can die with a cryptic error message"? that's why I find it strange to make handling it correctly optional | 16:59 |
| *** derekh has quit IRC | 16:59 | |
| zzzeek | zaneb: I'd need to confirm that you can actually break the connection like that. | 17:00 |
| *** rajpatel1 has quit IRC | 17:00 | |
| zzzeek | zaneb: a program might be reading rows on a single connection, press ctrl-C to stop, breaks out, goes back to "READY>", keeps using connection | 17:01 |
| *** yprokule has quit IRC | 17:01 | |
| zaneb | zzzeek: I think that'd be worth trying. it should be possible with a variant on your POC from yesterday. just run the function with the loop and hit Ctrl-C on the keyboard a lot | 17:01 |
| zzzeek | zaneb: then also again. sohuldn't pymysql catch KeyboardInterrupt ? | 17:02 |
| zzzeek | zaneb: i think we might want to look and see that pymysql's "corruption" itself is unusual. usually we all use native-C DBAPIs which also don't realy have these kinds of problems | 17:02 |
| zaneb | zzzeek: arguably, yes. I looked at the code and they assume the only exception that can happen is IOError | 17:02 |
| zzzeek | zaneb: the reason we are using pymysql is....for eventlet compat ! :) | 17:03 |
| zaneb | it looks really hard to unwind from the inside though. I think in most cases you'll end up having to kill the connection and start again. that's probably easier to deal with at the sqlalchemy level, even though it leaves other PyMySQL users in the lurch | 17:04 |
| *** jcoufal has quit IRC | 17:06 | |
| zaneb | agree that C APIs are atomic w.r.t. async exceptions like this, so they don't have this issue | 17:06 |
| zaneb | although there are probably (short) sections of sqlalchemy where an exception could cause problems | 17:07 |
| *** dprince has quit IRC | 17:07 | |
| *** kumarb has quit IRC | 17:09 | |
| *** code-R has quit IRC | 17:09 | |
| zaneb | zzzeek: that patch from your first comment in that bug report has some interesting context: https://github.com/zzzeek/sqlalchemy/blob/rel_0_9_3/lib/sqlalchemy/pool.py#L541-L545 | 17:13 |
| zzzeek | haha woops | 17:13 |
| zaneb | zzzeek: clearly you were intending to catch SystemExit and KeyboardInterrupt there, but you're actually missing them | 17:14 |
| zzzeek | zaneb: i wonder if that's still th4ere b.c. it is obv. wrong | 17:14 |
| zzzeek | zaneb: or perhaps that's from my py2.4 days | 17:14 |
| zaneb | nope, not any more afaict | 17:14 |
| zzzeek | before BaseException | 17:14 |
| zaneb | I did use Python 2.4, but my memory doesn't go that far back ;) | 17:15 |
| zzzeek | zaneb: we're catching BaseException there now | 17:16 |
| *** vijendar has joined #heat | 17:16 | |
| zaneb | ah, yep. it's 100% correct now | 17:16 |
| zzzeek | zaneb: that's a case where the connection is already being garbage collected | 17:18 |
| zzzeek | zaneb: that's not a normal "userland" use case | 17:18 |
| zaneb | garbage collection is the twilight zone, but userland may not be as normal as we think :D | 17:19 |
| *** akuznetsov has joined #heat | 17:20 | |
| zzzeek | zaneb: but in userland, *the user is there* | 17:21 |
| zzzeek | zaneb: i think the cases of "corrupts the connection" vs. "the SQLAlchemy oepration was interupted" should perhaps be separate | 17:21 |
| zzzeek | zaneb: if i can demontraste to pymysql a ctrl-C corrupting a connection i'll send it to him and see what he thinks | 17:22 |
| *** Guest98774 has quit IRC | 17:22 | |
| zaneb | zzzeek: +1 | 17:23 |
| *** akuznetsov has quit IRC | 17:25 | |
| *** KanagarajM has quit IRC | 17:27 | |
| *** pradk has quit IRC | 17:34 | |
| *** pradk has joined #heat | 17:35 | |
| *** jasond has joined #heat | 17:35 | |
| *** dsneddon has quit IRC | 17:40 | |
| zzzeek | zaneb: there might be an entirely different way to look at this issue | 17:41 |
| zzzeek | zaneb: when heat or whoever has this problem, e.g. not just that the connection was interrupted, but then you get errors afterwards, do you always have the "ResourceClosedError" part of this? | 17:43 |
| zzzeek | e.g. and not just the "commands out of sync" part | 17:43 |
| *** Dave has quit IRC | 17:45 | |
| *** Dave____ has joined #heat | 17:51 | |
| *** bana_k has quit IRC | 17:51 | |
| *** Zer0Byte__ has joined #heat | 17:52 | |
| *** sshnaidm is now known as sshnaidm|afk | 17:52 | |
| zzzeek | eh nevermind | 17:53 |
| openstackgerrit | Stephen Watson proposed openstack/heat: Brings Magnum resource up to date https://review.openstack.org/374321 | 18:11 |
| *** jpich has joined #heat | 18:14 | |
| *** bana_k has joined #heat | 18:17 | |
| *** shardy has quit IRC | 18:18 | |
| *** akuznetsov has joined #heat | 18:21 | |
| zaneb | zzzeek: usually. not sure about 'always' | 18:25 |
| *** akuznetsov has quit IRC | 18:26 | |
| zzzeek | zaneb: nevermind, you win all points https://bitbucket.org/zzzeek/sqlalchemy/issues/3803/dbapi-connections-go-invalid-on | 18:26 |
| *** rcernin has joined #heat | 18:30 | |
| *** vijendar has quit IRC | 18:30 | |
| *** rajpatel has joined #heat | 18:31 | |
| *** jprovazn has joined #heat | 18:33 | |
| zaneb | zzzeek: thanks for all your help with this. that patch looks great to me | 18:34 |
| zaneb | zzzeek: you might want to add "and not is_base_exception" on the end of the definition of should_wrap, since you never want to wrap an exit exception | 18:35 |
| *** jpich has quit IRC | 18:35 | |
| zaneb | zzzeek: maybe something similar on the "if newraise:" line | 18:36 |
| *** vijendar has joined #heat | 18:36 | |
| *** sdake has quit IRC | 18:39 | |
| *** Dave____ has quit IRC | 18:48 | |
| *** Dave has joined #heat | 18:50 | |
| *** sdake has joined #heat | 18:56 | |
| *** catintheroof has joined #heat | 19:12 | |
| *** sabeen has joined #heat | 19:13 | |
| zaneb | EmilienM: https://review.openstack.org/#/c/374340/ | 19:14 |
| openstackgerrit | Yosef Hoffman proposed openstack/heat-specs: New Resource Type OS::Nova::Quota https://review.openstack.org/373546 | 19:16 |
| EmilienM | zaneb: :o | 19:20 |
| *** akshai has quit IRC | 19:20 | |
| EmilienM | zaneb: thanks, unfortunatly, I can't test it in puppet CI easily | 19:21 |
| *** akuznetsov has joined #heat | 19:23 | |
| *** akshai has joined #heat | 19:25 | |
| zaneb | EmilienM: hmm, actually that might not fix it. that looks to be a different constraint from the one my patch fixes | 19:27 |
| *** akuznetsov has quit IRC | 19:28 | |
| zaneb | cwolferh: any clues what might be causing the IntegrityError in http://logs.openstack.org/67/373967/2/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/a7960f6/logs/heat/heat-engine.txt.gz#_2016-09-21_14_41_38_553 ? | 19:29 |
| cwolferh | zaneb, not off the top of my head but i'll dig | 19:31 |
| *** mfisch has quit IRC | 19:37 | |
| cwolferh | it seems odd that a user_cred would disappear. user_cred id is 1 here which is probably an admin. hmm. wrongfully purged? | 19:38 |
| *** jprovazn has quit IRC | 19:40 | |
| *** jasond has quit IRC | 19:40 | |
| *** bana_k has quit IRC | 19:43 | |
| *** dyasny has quit IRC | 19:45 | |
| *** cmartin has quit IRC | 19:47 | |
| zaneb | cwolferh: note that this is in the puppet gate, and this is literally the only test they run on heat, so that might be why it gets id=1 | 19:47 |
| zaneb | but yeah, an incorrect purge somewhere sounds like it could be the culprit | 19:47 |
| *** tanvirt has quit IRC | 19:50 | |
| swatson | Hey everyone, quick question re: heat.egg_info | 19:51 |
| swatson | I was just updating the Magnum resource for Heat and my tests were failing until I updated heat/heat.egg-info/entrypoints.txt for the Magnum entry | 19:52 |
| *** rajpatel has quit IRC | 19:53 | |
| swatson | But I noticed that folder seems to be ignored by git--is there some other file I need to edit that will update the egg-info instead? | 19:53 |
| *** rajpatel has joined #heat | 19:56 | |
| openstackgerrit | Zane Bitter proposed openstack/heat: Don't delete RawTemplate if it referenced by a stack https://review.openstack.org/374340 | 19:57 |
| *** rajpatel has quit IRC | 19:57 | |
| *** jasond has joined #heat | 19:58 | |
| *** bana_k has joined #heat | 19:59 | |
| *** dyasny has joined #heat | 19:59 | |
| *** steveg_afk has quit IRC | 20:00 | |
| *** catintheroof has quit IRC | 20:08 | |
| openstackgerrit | Stephen Watson proposed openstack/heat: Brings Magnum resource up to date https://review.openstack.org/374321 | 20:08 |
| *** blomquisg is now known as blomquisg_gone | 20:10 | |
| *** steveg_afk has joined #heat | 20:15 | |
| *** jcoufal has joined #heat | 20:15 | |
| cwolferh | zaneb, so, i think the problem has to do with trying to delete the stack twice, once in the test itself: https://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/orchestration/stacks/test_stacks.py#n58 and again in the cleanup https://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/orchestration/base.py#n84 . the first delete succeeds fine. i'm not sure why the 2nd gets as far as it does before blowing up | 20:22 |
| zaneb | cwolferh: hmmm. so with convergence there's no longer a lock at the stack level | 20:23 |
| zaneb | which is fine as far as starting the update to an empty template goes... | 20:24 |
| zaneb | but when it comes to actually doing the delete of the Stack row in the DB, possibly not as good | 20:24 |
| cwolferh | the test waiting for DELETE_COMPLETE means the credential will be deleted by the time the 2nd delete in the cleanup is called. but i feel like that 2nd delete should see, "oh there is nothing to do" | 20:29 |
| cwolferh | (but i can imagine an issue if two calls to delete are made without a wait for DELETE_COMPLETE) | 20:30 |
| *** steveg_afk has quit IRC | 20:33 | |
| zaneb | yeah, I agree | 20:36 |
| zaneb | so if it's DELETE_COMPLETE we should reject any attempts to change it | 20:36 |
| cwolferh | seems fair | 20:36 |
| zaneb | I guess that isn't happening? | 20:36 |
| cwolferh | not sure yet :-) looking at the issue in my devstack | 20:37 |
| cwolferh | but clearly in the puppet-ci case the 2nd delete is trying to do too much | 20:37 |
| zaneb | actually, now that I think about it, if there's a race it should be OK. only one of them can be the current traversal, and only that one gets to write DELETE_COMPLETE to the DB and then soft-delete the stack | 20:38 |
| zaneb | so it's more likely to be that we are starting something after it's already DELETE_COMPLETE that we really shouldn't | 20:39 |
| cwolferh | in my devstack, i'm only seeing one attempt to delete the stack for this test (in h-eng.log). hmm. | 20:41 |
| *** bana_k has quit IRC | 20:42 | |
| *** crose has quit IRC | 20:44 | |
| *** steveg_afk has joined #heat | 20:46 | |
| openstackgerrit | Stephen Watson proposed openstack/heat: Brings Magnum resource up to date https://review.openstack.org/374321 | 20:47 |
| cwolferh | zaneb, from an api (or heat.engine.service) perspective, i think this is just as simple as checking for DELETE_COMPLETE and treating that as a "not found". in the puppet-ci case, i think the 2nd call just came too fast before the stack was actually deleted after the DELETE_COMPLETE status was set | 20:54 |
| *** askb has joined #heat | 20:55 | |
| zaneb | cwolferh: so we're checking for whether the stack has been soft-deleted, but not if it is in DELETE_COMPLETE, and there's a race where a new request can get in between those two? | 20:55 |
| *** jasond has quit IRC | 20:57 | |
| *** jasond has joined #heat | 20:57 | |
| cwolferh | zaneb, yes, between this try: https://git.openstack.org/cgit/openstack/heat/tree/heat/engine/stack.py#n1764 and line 1777 | 20:57 |
| zaneb | cwolferh: that's the legacy path and IIUC this is convergence, but I bet there is something equivalent in convergence | 20:59 |
| cwolferh | ah, oops | 20:59 |
| *** akshai has quit IRC | 20:59 | |
| zaneb | https://git.openstack.org/cgit/openstack/heat/tree/heat/engine/stack.py#n2003 | 21:00 |
| *** bana_k has joined #heat | 21:00 | |
| zaneb | same thing | 21:00 |
| zaneb | I hate that we've added two lots of methods to the same class to do legacy and convergence | 21:01 |
| zaneb | I wish we had two separate helper classes :/ | 21:01 |
| cwolferh | that would have been nice | 21:04 |
| *** akuznetsov has joined #heat | 21:06 | |
| *** rwsu has joined #heat | 21:06 | |
| cwolferh | ok, so same possible fix is to treat DELETE_COMPLETE by raising exception.EntityNotFound in https://git.openstack.org/cgit/openstack/heat/tree/heat/engine/service.py#n1360 | 21:08 |
| *** akuznetsov has quit IRC | 21:11 | |
| zaneb | cwolferh: +1 | 21:11 |
| zaneb | so pre-convergence we'd have killed the thread doing the first delete, in order to get its lock. by which point it would have either completed (and we'd get NotFound when we tried to reload the stack) or it wouldn't have done the soft-delete yet, and we could try again | 21:13 |
| zaneb | tricky | 21:13 |
| *** vijendar has quit IRC | 21:17 | |
| *** dsneddon has joined #heat | 21:19 | |
| *** vijendar has joined #heat | 21:24 | |
| *** rcernin has quit IRC | 21:24 | |
| *** rajpatel has joined #heat | 21:25 | |
| *** Zer0Byte__ has quit IRC | 21:28 | |
| *** rpothier has quit IRC | 21:35 | |
| *** EricGonczer_ has quit IRC | 21:48 | |
| *** jasond has quit IRC | 21:52 | |
| *** randallburt1 has quit IRC | 21:55 | |
| *** cwolferh has quit IRC | 21:59 | |
| *** ccamacho|afk has quit IRC | 21:59 | |
| *** cwolferh has joined #heat | 22:01 | |
| *** jasond has joined #heat | 22:05 | |
| *** spotz is now known as spotz_zzz | 22:07 | |
| *** akuznetsov has joined #heat | 22:07 | |
| zaneb | wow, navigating the code base from 2012 is hard | 22:08 |
| *** spedione is now known as spedione|AWAY | 22:08 | |
| *** annegentle has quit IRC | 22:11 | |
| *** sabeen has quit IRC | 22:12 | |
| *** akuznetsov has quit IRC | 22:12 | |
| *** spzala has quit IRC | 22:20 | |
| *** jcoufal has quit IRC | 22:20 | |
| *** spzala has joined #heat | 22:20 | |
| *** adrian_otto has joined #heat | 22:20 | |
| *** vijendar has quit IRC | 22:20 | |
| *** jasond has quit IRC | 22:21 | |
| openstackgerrit | Yosef Hoffman proposed openstack/heat: Add OS::Nova::Quota resource https://review.openstack.org/373548 | 22:22 |
| *** steveg_afk has quit IRC | 22:24 | |
| *** spzala has quit IRC | 22:25 | |
| *** adrian_otto has quit IRC | 22:25 | |
| zaneb | stevebaker: what were you thinking? ;) https://bugs.launchpad.net/heat/+bug/1499669/comments/17 | 22:26 |
| openstack | Launchpad bug 1499669 in heat mitaka "Heat stucks in DELETE_IN_PROGRESS for some input data" [High,Triaged] | 22:26 |
| *** adrian_otto has joined #heat | 22:28 | |
| stevebaker | zaneb: I was thinking I really want a job at Red Hat, whats this OpenStack thing? | 22:31 |
| zaneb | lol | 22:31 |
| stevebaker | zaneb: also I probably cargo-culted it from somewhere | 22:32 |
| zaneb | yeah, probably nova | 22:32 |
| stevebaker | OpenStack is swift plus things cargo-culted from nova | 22:34 |
| *** rajpatel has quit IRC | 22:46 | |
| *** adrian_otto has quit IRC | 22:47 | |
| *** rajpatel has joined #heat | 22:47 | |
| *** annegentle has joined #heat | 22:58 | |
| *** jamielennox is now known as jamielennox|away | 23:04 | |
| *** akuznetsov has joined #heat | 23:10 | |
| *** hoonetorg has quit IRC | 23:10 | |
| *** akuznetsov has quit IRC | 23:14 | |
| *** annegentle has quit IRC | 23:15 | |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Do not attempt deletion of a DELETE_COMPLETE stack in service api https://review.openstack.org/374440 | 23:20 |
| openstackgerrit | Zane Bitter proposed openstack/heat: Don't use cast() to do StackResource delete https://review.openstack.org/374442 | 23:27 |
| openstackgerrit | Zane Bitter proposed openstack/heat: Increase the timeout for the stop_stack message https://review.openstack.org/374443 | 23:27 |
| openstackgerrit | Zane Bitter proposed openstack/heat: RPC Client: don't cast() delete_stack by default https://review.openstack.org/374444 | 23:27 |
| *** Zer0Byte__ has joined #heat | 23:28 | |
| *** jamielennox|away is now known as jamielennox | 23:43 | |
| *** rwsu has quit IRC | 23:45 | |
| *** zhurong has joined #heat | 23:46 | |
| *** rajpatel has quit IRC | 23:56 | |
| *** zhurong has quit IRC | 23:57 | |
| *** dimtruck is now known as zz_dimtruck | 23:58 | |
| *** EricGonczer_ has joined #heat | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!