Monday, 2017-01-16

*** sdake has quit IRC00:00
*** sdake has joined #heat00:02
*** sdake has quit IRC00:03
*** jistr has quit IRC00:03
*** sdake has joined #heat00:04
*** jistr has joined #heat00:07
*** Pavo has joined #heat00:23
*** sdake has quit IRC00:28
*** adrian_otto has joined #heat00:30
*** ramishra has quit IRC00:45
*** ramishra has joined #heat00:47
*** hoangcx has joined #heat00:50
*** dimtruck is now known as zz_dimtruck00:50
*** zz_dimtruck is now known as dimtruck00:50
*** adrian_otto has quit IRC00:52
*** ramishra has quit IRC00:58
*** dimtruck is now known as zz_dimtruck01:00
*** ramishra has joined #heat01:00
*** ramishra has quit IRC01:05
*** ramishra has joined #heat01:07
*** liusheng has quit IRC01:10
*** liusheng has joined #heat01:18
*** elynn has joined #heat01:26
*** ramishra has quit IRC01:30
*** ramishra has joined #heat01:32
*** yanyanhu has joined #heat01:34
*** ramishra has quit IRC01:37
*** ramishra has joined #heat01:39
openstackgerrithuangtianhua proposed openstack/heat: No need to check if resource not created  https://review.openstack.org/41563901:44
*** steveg_afk has joined #heat01:49
*** EricGonczer_ has quit IRC01:52
*** liusheng has quit IRC01:54
openstackgerritMerged openstack/heat: Set content-type when signaling deployment  https://review.openstack.org/41924402:01
*** steveg_afk has quit IRC02:03
*** ramishra has quit IRC02:09
*** zhihui has joined #heat02:10
*** ramishra has joined #heat02:11
*** liusheng has joined #heat02:12
*** vijendar has joined #heat02:17
*** EricGonczer_ has joined #heat02:19
*** stevemar has quit IRC02:21
*** zz_dimtruck is now known as dimtruck02:21
*** stevemar has joined #heat02:21
*** vijendar has quit IRC02:22
*** links has joined #heat02:25
*** ramishra has quit IRC02:32
*** ramishra has joined #heat02:34
*** links has quit IRC02:38
*** links has joined #heat02:46
*** ramishra has quit IRC03:00
*** ramishra has joined #heat03:02
*** wangbo has joined #heat03:05
*** bana_k has joined #heat03:16
*** bana_k has quit IRC03:29
*** wllabs has joined #heat03:32
openstackgerrithuangtianhua proposed openstack/heat: Refactor _show_resource() for neutron resources  https://review.openstack.org/41985103:44
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for neutron resources  https://review.openstack.org/42026203:44
*** KanagarajM has joined #heat03:53
openstackgerritKanagaraj Manickam proposed openstack/heat: Release notes for designate v2 support  https://review.openstack.org/41704303:54
*** EricGonczer_ has quit IRC03:57
*** ramishra has quit IRC04:05
*** ramishra has joined #heat04:07
*** ramishra has quit IRC04:08
*** elynn has quit IRC04:11
*** vijendar has joined #heat04:18
wllabsscaling policy has a propoerties number is 204:19
wllabscreate a receiver-create -P count=1004:20
wllabsif triggering reciver, num of node what the cluster scaling node04:21
*** manjong has joined #heat04:22
*** adrian_otto has joined #heat04:23
*** vijendar has quit IRC04:23
*** adrian_otto has quit IRC04:24
*** adrian_otto has joined #heat04:25
*** adrian_otto has quit IRC04:33
*** adrian_otto has joined #heat04:46
*** dimtruck is now known as zz_dimtruck04:49
openstackgerrithuangtianhua proposed openstack/heat: Refactor _show_resource() for neutron resources  https://review.openstack.org/41985105:02
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for neutron resources  https://review.openstack.org/42026205:02
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for senlin resources  https://review.openstack.org/42050005:02
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for senlin resources  https://review.openstack.org/42050005:04
*** adrian_otto has quit IRC05:11
*** KanagarajM has quit IRC05:20
*** elynn has joined #heat05:24
*** prateek has joined #heat05:28
openstackgerritMerged openstack/python-heatclient: Enable coverage report in console output  https://review.openstack.org/41864905:29
*** sgordon has quit IRC05:31
*** sgordon has joined #heat05:39
*** fandi has joined #heat05:49
*** manjong has quit IRC06:02
*** manjong has joined #heat06:05
*** adrian_otto has joined #heat06:06
*** manjong has quit IRC06:10
openstackgerritNam Nguyen Hoai proposed openstack/heat: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/42050906:11
*** adrian_otto has quit IRC06:14
openstackgerritNam Nguyen Hoai proposed openstack/heat: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/42050906:15
*** adrian_otto has joined #heat06:16
*** adrian_otto has quit IRC06:16
*** vijendar has joined #heat06:19
*** adrian_otto has joined #heat06:21
*** vijendar has quit IRC06:25
*** manjong has joined #heat06:26
*** adrian_otto has quit IRC06:33
*** manjong has quit IRC06:34
*** manjong has joined #heat06:35
*** vijendar has joined #heat06:42
*** vijendar has quit IRC06:47
*** manjong has quit IRC06:50
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for senlin resources  https://review.openstack.org/42050006:51
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for neutron resources  https://review.openstack.org/42026206:51
*** Drago has quit IRC06:51
*** afazekas has quit IRC06:53
*** afazekas has joined #heat06:57
*** afazekas has quit IRC07:02
*** afazekas has joined #heat07:13
openstackgerrithuangtianhua proposed openstack/heat: Don't override _show_resource() for image  https://review.openstack.org/42053207:27
*** jprovazn has joined #heat07:27
*** fandi has quit IRC07:35
*** ricolin has joined #heat07:44
*** zhurong has joined #heat08:05
*** stingaci has joined #heat08:07
openstackgerrithuangtianhua proposed openstack/heat: Improve resource.NoActionRequired  https://review.openstack.org/42055808:11
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for neutron resources  https://review.openstack.org/42026208:13
openstackgerrithuangtianhua proposed openstack/heat: Apply super _show_resource() for senlin resources  https://review.openstack.org/42050008:15
openstackgerritTuan Luong-Anh proposed openstack/heat-templates: Replace yaml.load() with yaml.safe_load()  https://review.openstack.org/42056208:20
*** shardy has joined #heat08:24
*** trananhkma has joined #heat08:30
openstackgerrithuangtianhua proposed openstack/heat: Avoid use internal attribut '_info'  https://review.openstack.org/42057708:40
openstackgerrithuangtianhua proposed openstack/heat: Avoid to use internal attribute '_info'  https://review.openstack.org/42057708:42
*** wllabs_ has joined #heat08:48
*** jpich has joined #heat08:49
*** wllabs has quit IRC08:49
*** wllabs_ is now known as wllabs08:50
*** sdake has joined #heat08:52
*** zzzeek has quit IRC09:00
*** zzzeek has joined #heat09:00
*** sdake_ has joined #heat09:00
*** sdake has quit IRC09:02
openstackgerrithuangtianhua proposed openstack/heat: Remove handle_delete() for keystone group  https://review.openstack.org/42060109:26
*** dbecker has joined #heat09:29
*** yassine has joined #heat09:32
*** yassine is now known as Guest701109:32
openstackgerrithuangtianhua proposed openstack/heat: Improve resource.NoActionRequired  https://review.openstack.org/42055809:32
robcresswellHey guys; when can we expect a new heatclient release?09:34
*** sshnaidm|off is now known as sshnaidm09:35
*** zhurong has quit IRC09:37
*** derekh has joined #heat09:40
*** sgordon has quit IRC09:41
*** sdake_ has quit IRC09:41
openstackgerrithuangtianhua proposed openstack/heat: Allow admins to get resource by physical resource id  https://review.openstack.org/41169609:42
*** sgordon has joined #heat09:49
*** ccamacho|lunch is now known as ccamacho09:57
*** nilles has joined #heat10:06
*** zhurong has joined #heat10:09
*** hoangcx has quit IRC10:14
*** yanyanhu has quit IRC10:34
*** Guest7011 has quit IRC10:37
*** roughiz has joined #heat10:43
*** vijendar has joined #heat10:43
*** roughiz has quit IRC10:44
*** roughiz has joined #heat10:45
*** blues-man has joined #heat10:45
*** Guest7011 has joined #heat10:45
openstackgerritRico Lin proposed openstack/heat: Allow multi-layer global environment/template directory  https://review.openstack.org/29805411:09
openstackgerritRico Lin proposed openstack/heat: Allow load global template for template resouce  https://review.openstack.org/20943911:09
*** ricolin has quit IRC11:11
*** vijendar has quit IRC11:12
*** sshnaidm is now known as sshnaidm|afk11:24
*** blues-man has quit IRC11:36
openstackgerritGiulio Fidente proposed openstack/heat: Add initial support for execution of Mistral workflows via Heat resource  https://review.openstack.org/42066411:40
openstackgerritGiulio Fidente proposed openstack/heat: Add initial support for execution of Mistral workflows via Heat resource  https://review.openstack.org/42066411:44
openstackgerritGiulio Fidente proposed openstack/heat: Add initial support for execution of Mistral workflows via Heat resource  https://review.openstack.org/42066411:45
*** winggundamth has joined #heat11:51
winggundamthhi all11:51
winggundamthI just wonder how can I do something like this port_id: { get_attr: [instance, addresses, { get_param: external_network_name }, 0, port] }11:51
winggundamthcan we use get_param inside get_attr?11:52
*** om2 has quit IRC11:55
*** wllabs_ has joined #heat12:00
*** wllabs has quit IRC12:01
*** wllabs_ is now known as wllabs12:01
*** jprovazn has quit IRC12:06
*** jprovazn has joined #heat12:07
thervewinggundamth, Yes12:11
winggundamththerve: is this the correct syntax? port_id: { get_attr: [instance, addresses, { get_param: external_network_name }, 0, port] }12:12
therveLooks like it12:12
winggundamththerve: thanks. so maybe I have done something wrong on the others12:13
thervewinggundamth, What's happening? Maybe you should start with that :)12:13
*** steveg_afk has joined #heat12:13
winggundamththerve: grrrr. I don't know why but I just deleted everything and build the stack again. it works -_-12:14
therveHooray12:14
winggundamththerve: check the whole template file here https://github.com/opsta/openstack-heat-workshop/blob/master/workshop/05-parameters.yml12:17
*** winggundamth has quit IRC12:34
*** gfidente has joined #heat12:37
thervegfidente, Thanks12:38
therveSo I had a quick look12:38
gfidentetherve hey thanks12:38
therveI think it doesn't answer our main concern, which is being able to trigger a workflow based on stack/resource operations12:38
thervegfidente, Are you aware of https://review.openstack.org/267770 ?12:38
gfidentegoing through that now12:40
gfidenteoh so I basically implemented what was described as phase of in the blueprint it seems12:41
therveYour implementation is totally correct, there is no issue about that12:41
therveThat's possible yeah12:41
therveThe problem is that the spec is not what we want yet :)12:42
gfidentesec, reading the comments now12:42
thervegfidente, http://lists.openstack.org/pipermail/openstack-dev/2016-December/109089.html and the rest of the thread highlights that, too12:44
*** blues-man has joined #heat12:47
*** vijendar has joined #heat12:48
gfidentetherve so you're suggesting that12:49
gfidentewe should rather have a list of actions for the existing workflow resource and trigger execution when action is matched?12:50
thervegfidente, No I think it deserves a new resource. But that resource needs some kind of actions12:50
gfidenteok so to clear things up for me a bit12:52
*** vijendar has quit IRC12:53
gfidenteif in the template an execution resource refers to a workflow via get_resource, the execution will be deleted/recreated if the parent workflow is updated12:53
gfidenteis the above correct?12:53
therveThat depends on your resource implementation12:56
gfidentebecause that was my goal12:57
therveYeah that may be interesting13:02
therveBut I don't think that's the main issue we have13:02
therveWhat we want is being to control whether the workflow executes on stack update13:02
therveRegardless of the changes on the workflow itself13:02
*** zhurong has quit IRC13:03
gfidenteokay and to get that, looking at software_deployment, seems like I could add a generic _handle_action and use that matching against the desired actions for all handle_ requests?13:05
*** beagles_afk is now known as beagles13:08
therveRight that ought to look very similar13:08
gfidenteok thanks13:08
gfidentethat sounds cool to me13:08
therveIt is! Ultimately it will be nice13:09
gfidenteI will ping the blueprint author to see if they want to coop13:09
gfidentemaybe we should revive that to describe the intents13:10
gfidentebetter13:10
gfidente(and the implementation)13:10
therveThat'd be nice, yeah. We haven't seen him around for a while, though13:10
*** ccamacho is now known as ccamacho|lunch13:10
*** Guest7011 has quit IRC13:13
*** Guest7011 has joined #heat13:20
*** KanagarajM has joined #heat13:22
dimstherve : ramishra : https://review.openstack.org/#/c/420443/ should now show more of the heat related (py35) failures. ive fixed quite a bit of the nova failures etc.13:30
*** sshnaidm|afk is now known as sshnaidm13:30
thervedims, There are none?13:32
therveoh duh13:32
thervesorry didn't spot13:33
dimstherve : was looking at "... FAILED" in console.html13:33
therveYeah you're right13:34
thervedims, It's still that weird locale error in sqlalchemy13:35
dimstherve : which file are you looking at? so i can tell someone else to dig into the same spot13:36
thervedims, http://logs.openstack.org/43/420443/1/check/gate-heat-dsvm-functional-orig-mysql-lbaasv2-py35-ubuntu-xenial-nv/d858544/logs/screen-h-eng.txt.gz13:36
therve(warning, big)13:36
dimsthanks therve13:36
*** jdandrea has joined #heat13:39
*** jprovazn has quit IRC13:39
*** sdake has joined #heat13:39
openstackgerritDan Prince proposed openstack/heat-agents: Fix: all containers are being set privileged  https://review.openstack.org/42072113:42
*** EricGonczer_ has joined #heat13:43
openstackgerritFlavio Percoco proposed openstack/heat-agents: Run non-detached containers first  https://review.openstack.org/42072313:46
thervedims, It seems that the issue is in pymysql13:49
therveOr possibly oslo.i18n13:49
dimstherve : y, going to pass this traceback around (http://paste.openstack.org/show/595050/)13:50
*** EricGonczer_ has quit IRC13:50
openstackgerritGiulio Fidente proposed openstack/heat: Implements execution of Mistral workflows using a Heat resource  https://review.openstack.org/42066413:56
*** dprince has joined #heat13:59
*** jcoufal has joined #heat14:02
openstackgerritDan Prince proposed openstack/heat-agents: Add exit_codes option to docker-cmd hook  https://review.openstack.org/42072914:04
*** KanagarajM has quit IRC14:06
*** crose has joined #heat14:06
*** prateek has quit IRC14:11
*** paw has quit IRC14:13
*** ccamacho|lunch is now known as ccamacho14:18
*** pradk has joined #heat14:18
*** jcoufal_ has joined #heat14:18
*** jcoufal has quit IRC14:20
*** jprovazn has joined #heat14:21
*** Guest7011 has quit IRC14:28
*** links has quit IRC14:30
*** jcoufal has joined #heat14:38
*** KanagarajM has joined #heat14:39
*** jcoufal_ has quit IRC14:39
*** Guest7011 has joined #heat14:42
*** KanagarajM has quit IRC14:43
*** manjong has joined #heat14:52
*** vijendar has joined #heat14:53
*** dyasny has quit IRC14:56
*** dyasny has joined #heat14:57
*** KanagarajM has joined #heat14:57
*** paw has joined #heat14:57
*** beagles is now known as beagles_brb14:57
*** vijendar has quit IRC14:59
*** wllabs has quit IRC14:59
*** KanagarajM has quit IRC14:59
*** KanagarajM has joined #heat14:59
*** wllabs has joined #heat14:59
*** spotz_zzz is now known as spotz15:01
*** chris_hultin|AWA is now known as chris_hultin15:11
*** zz_dimtruck is now known as dimtruck15:14
*** KanagarajM has quit IRC15:20
*** KanagarajM has joined #heat15:20
*** jaosorior has joined #heat15:25
*** beekneemech is now known as bnemec15:26
*** frippe75 has joined #heat15:27
*** EricGonczer_ has joined #heat15:28
*** blues-man has quit IRC15:28
*** KanagarajM has quit IRC15:32
*** blomquisg_gone is now known as blomquisg15:32
*** KanagarajM has joined #heat15:33
*** sshnaidm has quit IRC15:36
*** sshnaidm has joined #heat15:36
*** jdandrea has quit IRC15:39
*** KanagarajM has quit IRC15:40
*** blues-man has joined #heat15:40
*** blues-man has quit IRC15:40
*** blues-man has joined #heat15:40
*** KanagarajM has joined #heat15:40
*** beagles_brb is now known as beagles15:41
*** nilles has quit IRC15:43
*** KanagarajM has quit IRC15:43
*** rajpatel has joined #heat15:44
*** KanagarajM has joined #heat15:44
*** jdandrea has joined #heat15:45
*** jasond has joined #heat15:48
*** stingaci has quit IRC15:48
*** stingaci has joined #heat15:48
*** Drago has joined #heat15:49
*** KanagarajM has quit IRC15:52
*** KanagarajM has joined #heat15:53
*** spotz is now known as spotz_zzz15:55
*** Drago has quit IRC15:55
*** vijendar has joined #heat15:55
*** randallburt has joined #heat15:55
*** crose has quit IRC15:56
*** spotz_zzz is now known as spotz15:57
*** randallburt has quit IRC16:00
*** Drago has joined #heat16:01
*** randallburt has joined #heat16:09
*** jasond has quit IRC16:10
*** crose has joined #heat16:11
*** rajpatel has quit IRC16:14
*** manjong has quit IRC16:14
openstackgerritFlavio Percoco proposed openstack/heat-agents: Run non-detached containers first  https://review.openstack.org/42072316:17
*** rajpatel has joined #heat16:18
*** blues-man has quit IRC16:21
*** jdandrea has quit IRC16:23
*** crose has quit IRC16:23
*** manjong has joined #heat16:25
*** manjong has quit IRC16:30
*** adrian_otto has joined #heat16:31
*** sdake has quit IRC16:33
*** KanagarajM has quit IRC16:34
*** KanagarajM has joined #heat16:34
*** jdandrea has joined #heat16:36
*** jose-phillips has joined #heat16:52
*** jose-phi_ has joined #heat16:54
*** jose-phillips has quit IRC16:54
cwolferhlooking for reviews for https://review.openstack.org/#/c/363415/ . i have patches ready for related patch sets that have merge conflicts once that one is merged16:56
thervecwolferh, Why does it move away from transaction in purge?17:01
cwolferhtherve, off the top of my head, too many operations in one transaction, will likely end up db deadlock issues17:02
cwolferhi know its ironic, since i tried hard to get the transaction working in the previous patch, but now it is too much :/17:03
*** dprince has quit IRC17:04
*** dprince has joined #heat17:05
therveOK :)17:05
openstackgerritRico Lin proposed openstack/heat: Brings Magnum resource up to date with Cluster  https://review.openstack.org/37432117:06
*** jcoufal_ has joined #heat17:07
cwolferhtherve, for reference, when it was in a transaction i tried adding this to deal with it: https://review.openstack.org/#/c/397938/ . but probably better to avoid it17:08
* therve nods17:08
*** dave-johnston has joined #heat17:09
*** jcoufal has quit IRC17:09
*** gfidente is now known as gfidente|afk17:17
openstackgerritDavanum Srinivas (dims) proposed openstack/heat: [WIP] python3 experiment - ignore me  https://review.openstack.org/42044317:18
openstackgerritOpenStack Proposal Bot proposed openstack/heat: Updated from global requirements  https://review.openstack.org/42083317:18
*** stingaci has quit IRC17:19
*** stingaci has joined #heat17:23
*** jose-phi_ has quit IRC17:24
openstackgerritOpenStack Proposal Bot proposed openstack/python-heatclient: Updated from global requirements  https://review.openstack.org/42085417:27
*** stingaci has quit IRC17:28
*** jdandrea has quit IRC17:28
*** jpich has quit IRC17:29
*** stingaci has joined #heat17:29
*** jose-phillips has joined #heat17:29
*** stingaci has quit IRC17:30
*** stingaci has joined #heat17:30
*** rajpatel has quit IRC17:32
*** KanagarajM has quit IRC17:33
*** stingaci has quit IRC17:35
*** jose-phillips has quit IRC17:35
*** jose-phillips has joined #heat17:36
*** jose-phi_ has joined #heat17:40
*** jose-phillips has quit IRC17:43
*** roughiz has quit IRC17:44
*** adrian_otto1 has joined #heat17:47
*** derekh has quit IRC17:48
*** adrian_otto has quit IRC17:51
*** dprince has quit IRC17:53
*** dprince has joined #heat17:56
*** spzala has joined #heat17:59
*** jdandrea has joined #heat18:02
*** jcoufal_ has quit IRC18:03
*** bana_k has joined #heat18:05
*** jcoufal has joined #heat18:05
*** dbecker has quit IRC18:09
*** crose has joined #heat18:12
*** bank_ has joined #heat18:17
*** bana_k has quit IRC18:19
*** shardy has quit IRC18:24
*** bank_ has quit IRC18:29
openstackgerritDavanum Srinivas (dims) proposed openstack/heat: [WIP] python3 experiment - ignore me  https://review.openstack.org/42044318:29
*** dprince has quit IRC18:36
*** elynn has quit IRC19:02
*** elynn_ has joined #heat19:02
*** dprince has joined #heat19:04
*** rajpatel has joined #heat19:06
openstackgerritDavanum Srinivas (dims) proposed openstack/heat: [WIP] python3 experiment - ignore me  https://review.openstack.org/42044319:10
*** bana_k has joined #heat19:11
openstackgerritCrag Wolfe proposed openstack/heat: Don't load all resources in convergence check  https://review.openstack.org/42019119:25
openstackgerritDavanum Srinivas (dims) proposed openstack/heat: [WIP] python3 experiment - ignore me  https://review.openstack.org/42044319:36
*** paw has quit IRC19:40
*** om2 has joined #heat19:49
zanebha19:50
zanebcwolferh: so get this...19:51
zanebthe input data from the sync point is stored in the stack, and it gets substituted in when you call e.g. Resource.FnGetRefId() http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resource.py#n203919:52
zanebso in order to use the cached data, you have to load all of the resources from the database, then call a method on them so it can ignore the data it just loaded from the database and use the cached data you had already19:53
zanebI have a plan to attack this and also fix some other longstanding architecture problems, but it's going to take a few days at least19:55
cwolferhzaneb, ah, hmm.  i was pretty sure i saw cases in Resource.FnGetAtt where loading the cached data worked without loading all the resources19:56
*** sdake has joined #heat19:57
cwolferhnot sure why .FnGetRefId would be different19:58
zanebcwolferh: by the time you're calling Resource.FnGetAtt/Resource.FnGetRefId (in fact, Resource.anything), you've already lost19:59
cwolferhzaneb, that seems likely :)20:05
*** bana_k has quit IRC20:07
cwolferhzaneb, actually, i don't think it is that bad. http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resource.py#n26320:08
zanebcwolferh: ah, you're right20:09
zanebcwolferh: but that's only for resources where we have the data? so it will load all the *rest* (the ones you'll never use) from the DB when you do stack.resources...20:10
*** bana_k has joined #heat20:10
zanebI think?20:10
*** chris_hultin is now known as chris_hultin|AWA20:11
cwolferhzaneb, ah, i think you are right20:11
*** spzala has quit IRC20:14
larsksIs there a way to generate a signed url for externally checking the state of a waitcondition (rather than setting it)?20:16
zanebcwolferh: took that check out, now getting KeyErrors. I wonder if that was masking some other issues as well20:24
zaneblarsks: no but, more importantly, why?20:25
larskszaneb, mostly curiosity.20:26
zanebcwolferh: oh, it's because of the resource actually being checked, never mind20:31
* cwolferh deletes what i was writing :-)20:31
cwolferhzaneb, i suspect we could get away with just not loading any resources from the db if cache_data is not none20:32
zanebcwolferh: yeah, that's what I'm trying20:33
*** jose-phi_ has quit IRC20:33
*** jose-phillips has joined #heat20:35
*** adrian_otto1 has quit IRC20:40
*** Guest7011 has quit IRC20:46
*** spzala has joined #heat20:49
*** charlesr has joined #heat20:49
*** jcoufal has quit IRC20:50
zanebcwolferh: ok, fixed it I think. I'll run some tests + then upload patches20:55
*** rajpatel has quit IRC20:55
*** chris_hultin|AWA is now known as chris_hultin20:58
*** jamielennox|away is now known as jamielennox20:59
*** chris_hultin is now known as chris_hultin|AWA21:07
*** dimtruck is now known as zz_dimtruck21:10
*** jose-phillips has quit IRC21:12
*** jose-phillips has joined #heat21:13
*** crose has quit IRC21:15
*** jprovazn has quit IRC21:15
*** charlesr has quit IRC21:20
*** sdake_ has joined #heat21:23
*** sdake has quit IRC21:24
*** paw has joined #heat21:25
*** jdandrea has quit IRC21:27
*** sdake_ has quit IRC21:27
*** sdake has joined #heat21:28
*** jdandrea has joined #heat21:31
*** randallburt has quit IRC21:31
*** zz_dimtruck is now known as dimtruck21:32
*** adrian_otto has joined #heat21:33
*** frippe75 has quit IRC21:36
*** sdake has quit IRC21:41
*** randallburt has joined #heat21:43
*** blomquisg is now known as blomquisg_gone21:43
*** blomquisg_gone is now known as blomquisg21:45
*** dfflanders has joined #heat21:52
*** vijendar has quit IRC21:57
*** sdake has joined #heat21:57
*** dprince has quit IRC21:57
openstackgerritZane Bitter proposed openstack/heat: Don't load non-referenced resources from DB  https://review.openstack.org/42097121:58
openstackgerritZane Bitter proposed openstack/heat: Don't load resources in dep_attrs  https://review.openstack.org/42097221:58
zanebcwolferh: ^ first one there should fix it21:59
zanebcwolferh: although it won't help memory usage as much as I was hoping, because we still create all of the Resource objects22:00
cwolferhzaneb, first one looks good to me22:01
zanebsecond one doesn't make any meaningful difference to the bug, it's just a tidy-up really22:02
cwolferhOK, was staring at that wondering if it was fixing something :)22:03
zanebI also abandoned the one from Friday, which was in the same boat, since it would have made things worse in the short term22:05
cwolferhof course, the other approach would not to be to not instantiate a resource at all in Stack.resources if cache_data is not None and the resource is not in cache_data, but i wouldn't be surprised if that breaks something else. anyways, first one is a lot better than nothing22:07
*** gfidente|afk has quit IRC22:07
*** jdandrea has quit IRC22:08
zanebcwolferh: that might actually work22:08
zanebI can't think of a reason we would be accessing any other resources during check_resource22:09
cwolferhme neither22:10
zanebthe main place I was seeing asserts was when resolving the definition of the resource being checked, so that only has references to the resources its referencing22:10
*** sdake_ has joined #heat22:12
zanebcwolferh: my long term plan is to write a StackDefinition class, and pass that object to intrinsic functions instead of the Stack object22:13
*** spzala has quit IRC22:13
zaneband it can do something TBD but much lighter-weight when functions try to access resources through it22:13
*** sdake has quit IRC22:14
zanebin the short term though definitely feel free to try out not instantiating resources that aren't in cache_data22:15
cwolferhmakes sense, probably better to avoid passing around stack so much22:16
cwolferhok, will see what happens :)22:16
zanebyeah, it's a sucky interface because 3rd party plugin authors have no idea what's supposed to be stable and what's not22:17
*** dimtruck is now known as zz_dimtruck22:17
zanebtbh *we* have no clear idea22:17
*** zz_dimtruck is now known as dimtruck22:18
cwolferhglad i'm not the only one22:19
*** stingaci has joined #heat22:20
openstackgerritDavanum Srinivas (dims) proposed openstack/heat: [WIP] python3 experiment - ignore me  https://review.openstack.org/42044322:20
cwolferhzaneb, fwiw, we still don't care about stack output-related attrs being passed around since check_resource doesn't care for its particular resource at it needs to resolve attributes for. but, we would want to pass them once we start caching stack outputs.22:22
cwolferhpart of the reason i'm mentioning that is if not instantiating all resources in stack.resource breaks, it'll probably be because of stack outputs (not sure yet)22:22
zanebit shouldn't break because we're not actually doing *anything* with that data when it comes to calculating outputs afaict22:23
zanebI agree we should just leave that data out for now22:24
*** stingaci has quit IRC22:24
zaneblater we'll want to ensure any attributes used by outputs are included in the set of attributes whose values we request from the resource, but we'll not want to pass all of those values to other resources, just to wherever we're storing data for outputs22:25
zanebwhich is looking increasingly like it should be in the resource itself, not in the sync point22:26
cwolferhi think the sync_point makes sense until the stack is COMPLETE22:26
cwolferhat which point copy it22:26
*** dimtruck is now known as zz_dimtruck22:28
*** zz_dimtruck is now known as dimtruck22:29
cwolferhi'm worried of some race about two traversals trying to write to the same resource which i don't have to worry about with sync_point, but maybe i worry too much. need to think about it more22:30
*** vijendar has joined #heat22:35
*** chris_hultin|AWA is now known as chris_hultin22:36
*** vijendar has quit IRC22:39
*** jaosorior has quit IRC22:41
*** vijendar has joined #heat22:43
*** vijendar has quit IRC22:44
*** vijendar has joined #heat22:44
*** vijendar has quit IRC22:55
*** spzala has joined #heat23:14
*** spzala has quit IRC23:18
*** jose-phillips has quit IRC23:23
*** jose-phillips has joined #heat23:29
*** chris_hultin is now known as chris_hultin|AWA23:31
zanebcwolferh: in phase 1 resources are locked by a traversal, so there's no possibility of getting 2 writes simultaneously. plus we're already writing to that table so we get it ~for free23:33
*** dimtruck is now known as zz_dimtruck23:35
cwolferhzaneb, ok, so doesn't that mean all sync_point input_data could just be written to resources right now instead of sync_point.input_data?23:36
*** spzala has joined #heat23:36
cwolferheh, nevermind23:36
zanebit would, but that would require the resources that the sync points are for to load their dependencies from the DB23:37
*** chris_hultin|AWA is now known as chris_hultin23:39
cwolferhok, so supposed resA and resB have attributes used by stackA's outputs, and resB has an attribute used by resC... we still want resB to send its input_data to resC. but stackA can just go and look at resA and resB db attribute data whenever it wants to reference it for the sake of calculating its outputs23:40
*** randallburt has quit IRC23:44
*** dave-johnston has quit IRC23:55
*** vijendar has joined #heat23:56
*** elynn_ has quit IRC23:57
*** adrian_otto has quit IRC23:58
*** steveg_afk has quit IRC23:59
*** EricGonczer_ has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!