*** fragatina has quit IRC | 00:02 | |
*** boris-42_ has joined #heat | 00:05 | |
*** gomarivera has quit IRC | 00:17 | |
*** gomarivera has joined #heat | 00:18 | |
*** gomarivera has quit IRC | 00:19 | |
*** gomarivera has joined #heat | 00:19 | |
*** gomarivera has quit IRC | 00:29 | |
*** gomarivera has joined #heat | 00:39 | |
*** ricolin has joined #heat | 00:45 | |
*** zhurong has joined #heat | 00:45 | |
openstackgerrit | Merged openstack/heat master: Get the deployment group resources again after CREATE_COMPLETE https://review.openstack.org/471727 | 00:54 |
---|---|---|
*** fragatina has joined #heat | 00:59 | |
*** gomarivera has quit IRC | 01:00 | |
*** mdnadeem has joined #heat | 01:03 | |
*** gomarivera has joined #heat | 01:04 | |
*** fragatina has quit IRC | 01:05 | |
*** gomarivera has quit IRC | 01:06 | |
*** gomarivera has joined #heat | 01:07 | |
*** gomarivera has quit IRC | 01:07 | |
*** gomarivera has joined #heat | 01:08 | |
openstackgerrit | huangtianhua proposed openstack/heat master: Add 'contains' function https://review.openstack.org/471595 | 01:13 |
*** zhurong has quit IRC | 01:33 | |
*** zhurong has joined #heat | 01:35 | |
*** namnh has joined #heat | 01:44 | |
*** gomarivera has quit IRC | 01:44 | |
*** gomarivera has joined #heat | 01:44 | |
*** gomarivera has quit IRC | 01:48 | |
*** fragatina has joined #heat | 02:01 | |
*** fragatina has quit IRC | 02:06 | |
*** nwonknu has quit IRC | 02:12 | |
*** nwonknu has joined #heat | 02:15 | |
*** nwonknu is now known as Guest18801 | 02:16 | |
*** gomarivera has joined #heat | 02:17 | |
*** sgran has quit IRC | 02:19 | |
*** sgran has joined #heat | 02:26 | |
*** gomarivera has quit IRC | 02:32 | |
*** gomarivera has joined #heat | 02:33 | |
*** gomarivera has quit IRC | 02:45 | |
*** gomarivera has joined #heat | 02:45 | |
*** gomarivera has quit IRC | 02:50 | |
*** nicolasbock has joined #heat | 02:56 | |
*** fragatina has joined #heat | 03:02 | |
*** fragatina has quit IRC | 03:06 | |
*** ramishra has joined #heat | 03:09 | |
*** links has joined #heat | 03:14 | |
*** dbecker has quit IRC | 03:18 | |
*** Shunli has joined #heat | 03:24 | |
*** dbecker has joined #heat | 03:35 | |
*** dimtruck is now known as zz_dimtruck | 03:47 | |
*** fragatina has joined #heat | 04:03 | |
*** fragatina has quit IRC | 04:07 | |
*** gkadam has joined #heat | 04:08 | |
*** hoonetorg has quit IRC | 04:11 | |
*** hoonetorg has joined #heat | 04:22 | |
*** zhurong has quit IRC | 04:28 | |
*** EmilienM has quit IRC | 04:30 | |
*** EmilienM has joined #heat | 04:35 | |
*** zhurong has joined #heat | 04:38 | |
*** ramishra has quit IRC | 04:39 | |
*** mikal has quit IRC | 04:48 | |
*** mikal has joined #heat | 04:50 | |
*** prateek has joined #heat | 04:54 | |
*** skramaja has joined #heat | 05:12 | |
*** bnemec has quit IRC | 05:16 | |
*** zhurong has quit IRC | 05:17 | |
*** zhurong has joined #heat | 05:20 | |
*** boris-42_ has quit IRC | 05:34 | |
*** armaan has joined #heat | 05:43 | |
*** ltomasbo|away is now known as ltomasbo | 06:01 | |
*** rcernin has joined #heat | 06:08 | |
therve | tiantian, There seems to be something wrong with reno :/ | 06:13 |
*** LanceHaig has joined #heat | 06:14 | |
LanceHaig | ricolin, sorry I missed the meeting yesterday I will read the transcripts | 06:19 |
therve | LanceHaig, Meeting is today | 06:20 |
LanceHaig | haha | 06:21 |
LanceHaig | I need sleep | 06:21 |
*** jprovazn has joined #heat | 06:22 | |
*** Guest77651 has quit IRC | 06:32 | |
ricolin | LanceHaig, you can sleep for 6 hr and join meeting:) | 06:38 |
LanceHaig | :-) | 06:38 |
*** hjensas has quit IRC | 06:42 | |
*** jaosorior has joined #heat | 06:49 | |
*** d0ugal has joined #heat | 07:11 | |
*** ccamacho has joined #heat | 07:27 | |
*** armaan has quit IRC | 07:29 | |
*** armaan has joined #heat | 07:31 | |
*** shardy has joined #heat | 07:43 | |
*** ghs39ghsggf has joined #heat | 07:43 | |
*** ghs39ghsggf has left #heat | 07:43 | |
*** gomarivera has joined #heat | 07:46 | |
*** hjensas has joined #heat | 07:46 | |
openstackgerrit | huangtianhua proposed openstack/heat master: Add reno for soft policies supporting https://review.openstack.org/449393 | 07:49 |
*** gomarivera has quit IRC | 07:50 | |
*** amoralej|off is now known as amoralej | 07:52 | |
*** ramishra has joined #heat | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #heat | 08:00 | |
*** ltomasbo is now known as ltomasbo|away | 08:10 | |
*** fragatina has joined #heat | 08:11 | |
*** fragatina has quit IRC | 08:12 | |
*** fragatina has joined #heat | 08:13 | |
tiantian | heat reno jenkins is broken? | 08:36 |
therve | Yeah the last release introduced a regression | 08:37 |
therve | I talked to the release guys, ttx is looking into it | 08:37 |
therve | tiantian, You can remove the reno from the patch and add it later if you want | 08:37 |
*** fragatina has quit IRC | 08:37 | |
therve | I think we only build reno when there are new ones | 08:37 |
ricolin | therve, yep | 08:38 |
tiantian | therve, ok, thanks :) | 08:38 |
*** armaan has quit IRC | 08:56 | |
*** dbecker has quit IRC | 09:04 | |
*** derekh has joined #heat | 09:06 | |
*** dbecker has joined #heat | 09:06 | |
*** stokvis has joined #heat | 09:12 | |
*** stokvis has quit IRC | 09:19 | |
*** LanceHaig has quit IRC | 09:19 | |
*** LanceHaig has joined #heat | 09:19 | |
*** LanceHaig has quit IRC | 09:19 | |
*** gkadam is now known as gkadam-afk | 09:20 | |
*** jprovazn has quit IRC | 09:23 | |
*** LanceHaig has joined #heat | 09:24 | |
*** Shunli has quit IRC | 09:32 | |
*** zhurong has quit IRC | 09:40 | |
*** liusheng has quit IRC | 09:42 | |
*** liusheng has joined #heat | 09:42 | |
*** jprovazn has joined #heat | 09:44 | |
*** mdnadeem has quit IRC | 09:46 | |
*** ramishra has quit IRC | 09:49 | |
*** prateek has quit IRC | 09:49 | |
*** prateek has joined #heat | 09:50 | |
*** ramishra has joined #heat | 09:50 | |
*** fragatina has joined #heat | 09:55 | |
*** ayoung has quit IRC | 09:56 | |
*** ayoung has joined #heat | 10:08 | |
*** namnh has quit IRC | 10:25 | |
*** armaan has joined #heat | 10:32 | |
*** sai has quit IRC | 10:41 | |
*** rook has quit IRC | 10:42 | |
*** jcoufal has joined #heat | 10:46 | |
*** p01nt3r75 has joined #heat | 10:49 | |
*** ramishra has quit IRC | 10:51 | |
*** ramishra has joined #heat | 10:52 | |
*** ramishra has quit IRC | 10:57 | |
*** ramishra has joined #heat | 10:59 | |
*** ltomasbo|away is now known as ltomasbo | 11:04 | |
*** ioggstream has joined #heat | 11:06 | |
*** sai has joined #heat | 11:08 | |
*** rook has joined #heat | 11:08 | |
*** rook is now known as Guest18752 | 11:08 | |
*** ccard has quit IRC | 11:09 | |
*** ioggstream has quit IRC | 11:20 | |
*** jaosorior has quit IRC | 11:29 | |
*** EricGonczer_ has joined #heat | 11:36 | |
*** cmyster has joined #heat | 11:38 | |
*** gkadam-afk is now known as gkadam | 11:45 | |
*** LanceHaig has quit IRC | 12:03 | |
openstackgerrit | Bence Romsics proposed openstack/heat master: New resource: Neutron Trunk https://review.openstack.org/442496 | 12:07 |
*** LanceHaig has joined #heat | 12:16 | |
*** chlong has quit IRC | 12:20 | |
*** ltomasbo is now known as ltomasbo|away | 12:26 | |
*** prateek has quit IRC | 12:30 | |
*** dprince has joined #heat | 12:33 | |
*** ramishra has quit IRC | 12:35 | |
therve | shardy, If you can have a look at https://review.openstack.org/461904 that'd be great | 12:36 |
*** ramishra has joined #heat | 12:37 | |
shardy | therve: ack will do | 12:41 |
*** amoralej is now known as amoralej|lunch | 12:42 | |
*** links has quit IRC | 12:46 | |
*** gmoro has quit IRC | 12:50 | |
*** catintheroof has joined #heat | 12:52 | |
*** armaan has quit IRC | 12:56 | |
*** armaan has joined #heat | 12:56 | |
*** ramishra has quit IRC | 13:06 | |
*** yassine has joined #heat | 13:08 | |
*** gomarivera has joined #heat | 13:14 | |
*** gomarivera_ has joined #heat | 13:15 | |
*** gomarivera has quit IRC | 13:15 | |
*** gkadam has quit IRC | 13:17 | |
*** openstackgerrit has quit IRC | 13:18 | |
*** EricGonczer_ has quit IRC | 13:23 | |
*** jeremyfreudberg has joined #heat | 13:24 | |
*** amoralej|lunch is now known as amoralej | 13:29 | |
jeremyfreudberg | hey heat team, I'm wondering, if we have long-lived stack with a resource type which no longer exists, how is stack deletion handled? | 13:33 |
jeremyfreudberg | for example, OS::Nova::FloatingIPAssociation will be removed in Q release, and already right now deleting that resource is broken in Pike due to novaclient change | 13:33 |
jeremyfreudberg | (Sahara used that resource for M through O releases, we're worried about long-lived Sahara-managed stacks not being able to be deleted) | 13:34 |
ricolin | jeremyfreudberg, do you hope to keep the ability to kill the origin resource in Nova or just to be able to delete the template resource will be fine? | 13:35 |
*** cmyster has quit IRC | 13:36 | |
jeremyfreudberg | ricolin, good question, at the very least we want to be able to delete the stack, orphaned resources are not ideal, but we could manage if we have to | 13:37 |
*** skramaja has quit IRC | 13:37 | |
*** gmoro has joined #heat | 13:37 | |
*** cmyster has joined #heat | 13:37 | |
*** cmyster has joined #heat | 13:37 | |
jeremyfreudberg | (I was thinking we could change the handle_delete of OS::Nova::FloatingIPAssociation to attempt a delete using Neutron client, not sure if you guys are cool with that) | 13:37 |
therve | jeremyfreudberg, https://review.openstack.org/#/c/466187/ | 13:37 |
therve | We had to move quickly on that one because our gate was broken | 13:38 |
jeremyfreudberg | therve, awesome | 13:38 |
therve | jeremyfreudberg, In theory we never want to remove resources. We won't remove OS::Nova::FloatingIPAssociation, we'll make it an alias to nothing if necessary | 13:39 |
therve | If a stack can't be deleted, that's a bug we have to fix | 13:39 |
therve | We may leave some stuff behind, especially if the underlying APIs are deprecated | 13:40 |
jeremyfreudberg | therve, great, my worries are settled | 13:42 |
*** zhurong has joined #heat | 13:42 | |
jeremyfreudberg | I will say though, it looks like that patch might run into some issues, it's still using some novaclient calls that are pending removal very soon, see https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L55 | 13:44 |
*** openstackgerrit has joined #heat | 13:46 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat master: Add tag for server nic https://review.openstack.org/473744 | 13:46 |
therve | jeremyfreudberg, Well those are in master too | 13:47 |
jeremyfreudberg | therve, yes, I'm just saying you'll be needing another followup patch pretty soon | 13:48 |
therve | Those just got merged, so we have some time | 13:48 |
therve | Also, they actually display warnings instead of being in docstrings that we don't read :) | 13:48 |
ricolin | jeremyfreudberg, yep, you can backport that patch to your env, or use another resource type like OS::Heat::None to at last to remove stack. And as therve said, if that patch can't help to your env, then report a bug:) | 13:49 |
jeremyfreudberg | ricolin, therve, thanks. glad to see everything is under control on your end, and looks like the patch should be fine for Sahara's needs. Thanks!! | 13:50 |
ricolin | therve, rabi is not around this week? | 13:56 |
*** jeremyfreudberg has left #heat | 13:57 | |
therve | ricolin, Doesn't look like it | 13:58 |
*** chlong has joined #heat | 14:02 | |
*** prateek has joined #heat | 14:03 | |
*** bnemec has joined #heat | 14:05 | |
*** chlong has quit IRC | 14:06 | |
*** masber has quit IRC | 14:06 | |
*** masber has joined #heat | 14:07 | |
*** zz_dimtruck is now known as dimtruck | 14:11 | |
*** prateek has quit IRC | 14:12 | |
*** ccamacho is now known as ccamacho|brb | 14:17 | |
*** links has joined #heat | 14:20 | |
*** gomarivera_ has quit IRC | 14:22 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix race in SoftwareDeploymentGroupTest https://review.openstack.org/474004 | 14:27 |
*** jaosorior has joined #heat | 14:28 | |
*** felipemonteiro has joined #heat | 14:30 | |
*** chlong has joined #heat | 14:34 | |
*** chlong has quit IRC | 14:35 | |
*** ramishra has joined #heat | 14:36 | |
ricolin | zaneb, could you help to review https://review.openstack.org/#/c/328613/ when you have time:) | 14:36 |
*** links has quit IRC | 14:36 | |
zaneb | sure thing | 14:36 |
*** chlong has joined #heat | 14:38 | |
ricolin | Hi team, meeting in 14mins, feel free to add agenda | 14:46 |
ricolin | https://wiki.openstack.org/wiki/Meetings/HeatAgenda#Agenda_.282017-06-14_1500_UTC.29 | 14:46 |
*** zhurong has quit IRC | 14:49 | |
openstackgerrit | Merged openstack/heat master: Fix nova floatingip resources https://review.openstack.org/466187 | 14:52 |
ricolin | LanceHaig, kazsh, gaborm, mrwolf, zaneb, ramishra, therve, shardy, skraynev, prazumovsky, elynn, spzala, tiantian Meeting time! at openstack-meeting-5 | 15:01 |
*** EricGonczer_ has joined #heat | 15:06 | |
*** fultonj has quit IRC | 15:09 | |
*** EricGonc_ has joined #heat | 15:15 | |
*** EricGonczer_ has quit IRC | 15:17 | |
*** ioggstream has joined #heat | 15:40 | |
*** fragatina has quit IRC | 15:56 | |
*** fragatina has joined #heat | 15:56 | |
zaneb | tiantian: plugins expect self.t = before while handle_update is being called, but it may be correct to always set it to after once it's done, even if there was an exception | 16:06 |
zaneb | although tbh I don't know that we can ever get a consistent picture of a resource's state after cancelling an operation halfway through | 16:07 |
zaneb | there's no way for the rest of Heat to know what the plugin has and has not done | 16:08 |
zaneb | (convergence phase 2 would address this, using get_reality) | 16:08 |
tiantian | zaneb, can we control to accept cancel out of one resource updating? | 16:09 |
tiantian | not at the middle point of a resource updating? | 16:09 |
zaneb | that's actually something that convergence_engine solves. IIRC it will only cancel between calls to handle_update() and/or check_update_complete() | 16:11 |
*** p01nt3r75 has quit IRC | 16:11 | |
zaneb | but in legacy we still just kill the thread | 16:11 |
zaneb | so maybe tag the bug fixed-by-convergence and carry on with our lives? ;) | 16:12 |
tiantian | so this problem wont happen in convergence? I didn't test for it | 16:12 |
zaneb | yeah, I suspect it won't happen in convergence | 16:12 |
tiantian | I will try later in convergence | 16:13 |
tiantian | but you know our product works in legacy, so we still want to fix it in legacy | 16:14 |
zaneb | understood | 16:14 |
zaneb | that may be fixable in legacy, and the code we implemented for convergence might even help, but it would still be hard work | 16:16 |
tiantian | agree | 16:17 |
tiantian | how about to update self.t if we catch cancel exception? | 16:19 |
zaneb | I would at least try that. it will solve some situations | 16:19 |
tiantian | ok, will try tomorrow, thanks for the idea:) | 16:20 |
zaneb | any time :) | 16:21 |
zaneb | ramishra: sigh https://review.openstack.org/#/c/474004/2 :/ | 16:23 |
*** jmlowe has quit IRC | 16:23 | |
*** masber has quit IRC | 16:27 | |
*** masber has joined #heat | 16:28 | |
*** ricolin has quit IRC | 16:29 | |
*** gomarivera has joined #heat | 16:36 | |
zaneb | ramishra: on the bright side I think I've found the cause of the timeout race condition | 16:39 |
*** annegentle has joined #heat | 16:42 | |
*** jmlowe has joined #heat | 16:46 | |
*** rcernin has quit IRC | 16:49 | |
*** catintheroof has quit IRC | 17:02 | |
*** catintheroof has joined #heat | 17:03 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix races in SoftwareDeploymentGroupTest https://review.openstack.org/474004 | 17:03 |
*** derekh has quit IRC | 17:04 | |
*** LanceHaig has quit IRC | 17:08 | |
*** LanceHaig has joined #heat | 17:09 | |
*** LanceHaig has quit IRC | 17:09 | |
*** EricGonc_ has quit IRC | 17:12 | |
*** yassine has quit IRC | 17:20 | |
*** armaan has quit IRC | 17:23 | |
*** shardy has quit IRC | 17:24 | |
*** jcoufal has quit IRC | 17:25 | |
*** yassine has joined #heat | 17:28 | |
*** annegentle has quit IRC | 17:32 | |
*** annegentle has joined #heat | 17:33 | |
*** fragatina has quit IRC | 17:58 | |
*** gmoro has quit IRC | 17:59 | |
*** nicolasbock has quit IRC | 18:04 | |
*** nicolasbock has joined #heat | 18:05 | |
*** amoralej is now known as amoralej|off | 18:09 | |
*** annegentle has quit IRC | 18:16 | |
*** annegentle has joined #heat | 18:20 | |
*** ioggstream has quit IRC | 18:20 | |
*** ayoung has quit IRC | 18:30 | |
*** hjensas has quit IRC | 18:34 | |
*** rcernin has joined #heat | 19:10 | |
*** armaan has joined #heat | 19:13 | |
*** nicolasbock has quit IRC | 19:22 | |
*** jose-phillips has quit IRC | 19:22 | |
*** hjensas has joined #heat | 19:22 | |
*** annegentle has quit IRC | 19:27 | |
*** Guest18752 is now known as rook | 19:39 | |
*** gmoro has joined #heat | 19:56 | |
*** jprovazn has quit IRC | 19:58 | |
*** annegentle has joined #heat | 20:00 | |
*** ioggstream has joined #heat | 20:02 | |
*** gmoro has quit IRC | 20:04 | |
*** dprince has quit IRC | 20:07 | |
*** jcoufal has joined #heat | 20:18 | |
therve | zaneb, Not all resources are in progress when you do a rolling update :) | 20:19 |
zaneb | ugh, dammit | 20:20 |
zaneb | so it was actually relying on the fact that that data was grabbed during the create to show them all as IN_PROGRESS | 20:21 |
*** ioggstream has quit IRC | 20:22 | |
therve | You mean the ridiculous second assertEqual(4) | 20:24 |
zaneb | I still have no idea what the second assertEqual(4) was about :D | 20:26 |
therve | Oh yeah there is a check_input_values call as well, fantastic :) | 20:27 |
therve | I'm happy because you +2 that patch but I didn't :D | 20:28 |
therve | Oh actually the check_input_values is ok, it only needs the physical_resource_id | 20:29 |
zaneb | lol | 20:29 |
zaneb | I was more interested in the thing it was testing at that point in time | 20:33 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix races in SoftwareDeploymentGroupTest https://review.openstack.org/474004 | 20:34 |
zaneb | therve: does that^ look right this time? | 20:34 |
therve | zaneb, Yep! | 20:36 |
therve | Not sure we really need created_group_resources | 20:36 |
zaneb | whew. thanks! | 20:36 |
zaneb | we need two copies somehow - one where they're all IN_PROGRESS and one where they all have physical_resource_ids | 20:37 |
therve | I thought the ids were there once in progress | 20:38 |
zaneb | tbh I'm not sure when they get added | 20:39 |
zaneb | for most resources only when they're CREATE_COMPLETE, but sw deployments must be different | 20:39 |
*** armaan has quit IRC | 20:40 | |
zaneb | if it's the same time though then we wouldn't have had two failure modes (timeout and NotFound) | 20:40 |
therve | Yeah, the IDs are passed as argument to remove a race... | 20:40 |
therve | (I did that) | 20:40 |
zaneb | oh, so the failure mode just changed, we didn't have two failure modes at the same time? | 20:42 |
therve | https://bugs.launchpad.net/heat/+bug/1532445 | 20:43 |
openstack | Launchpad bug 1532445 in heat "ParallelDeploymentsTest intermittent failure" [Medium,Fix released] - Assigned to Thomas Herve (therve) | 20:43 |
*** armaan has joined #heat | 20:46 | |
zaneb | therve: I had no idea that resource_id_set made a database call | 20:47 |
zaneb | Author date 6/07/12 ... oh. | 20:49 |
*** dimtruck is now known as zz_dimtruck | 20:49 | |
*** armaan has quit IRC | 20:50 | |
therve | Heh | 20:51 |
zaneb | at least I didn't +2 it | 20:51 |
*** armaan has joined #heat | 20:53 | |
zaneb | therve: in any event, there's a short interval between the DB call that sets the state to CREATE_IN_PROGRESS and the one that sets the resource_id | 20:54 |
*** jmlowe has quit IRC | 21:05 | |
*** ayoung has joined #heat | 21:12 | |
*** zz_dimtruck is now known as dimtruck | 21:15 | |
*** ramishra has quit IRC | 21:19 | |
*** felipemonteiro has quit IRC | 21:21 | |
*** fragatina has joined #heat | 21:27 | |
*** hoonetorg has quit IRC | 21:34 | |
*** gomarivera has quit IRC | 21:34 | |
*** jmlowe has joined #heat | 21:40 | |
*** jcoufal_ has joined #heat | 21:42 | |
*** jcoufal has quit IRC | 21:43 | |
*** fragatina has quit IRC | 21:53 | |
*** jcoufal has joined #heat | 21:55 | |
*** fragatina has joined #heat | 21:56 | |
*** jcoufal_ has quit IRC | 21:57 | |
openstackgerrit | Hongbin Lu proposed openstack/heat master: Add Container to Zun resources https://review.openstack.org/437810 | 22:00 |
*** fragatina has quit IRC | 22:04 | |
*** ayoung has quit IRC | 22:09 | |
zaneb | yaaaaaay | 22:11 |
zaneb | it passed this time | 22:11 |
*** ayoung has joined #heat | 22:21 | |
*** jcoufal has quit IRC | 22:26 | |
*** annegentle has quit IRC | 22:27 | |
*** chlong has quit IRC | 22:37 | |
*** ayoung has quit IRC | 22:45 | |
*** bnemec has quit IRC | 22:59 | |
*** catintheroof has quit IRC | 23:09 | |
*** armaan has quit IRC | 23:25 | |
*** armaan has joined #heat | 23:25 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Support tenacity exponential backoff retry on resource sync https://review.openstack.org/328613 | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!