openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480755 | 00:00 |
---|---|---|
*** hoonetorg has joined #heat | 00:03 | |
*** yuanying_ has joined #heat | 00:05 | |
*** yuanying has quit IRC | 00:06 | |
*** dixiaoli has joined #heat | 00:09 | |
*** dixiaoli has quit IRC | 00:14 | |
*** yangyape_ has quit IRC | 00:17 | |
*** yangyapeng has joined #heat | 00:17 | |
*** yangyapeng has quit IRC | 00:22 | |
*** yuanying has joined #heat | 00:31 | |
*** yuanying_ has quit IRC | 00:31 | |
*** ayoung has joined #heat | 00:44 | |
*** yuanying has quit IRC | 00:49 | |
*** yuanying has joined #heat | 01:02 | |
*** dixiaoli has joined #heat | 01:09 | |
*** gfidente has quit IRC | 01:18 | |
*** yangyapeng has joined #heat | 01:19 | |
*** elynn has joined #heat | 01:21 | |
*** yangyapeng has quit IRC | 01:24 | |
*** elynn_ has joined #heat | 01:25 | |
*** elynn has quit IRC | 01:25 | |
*** yangyapeng has joined #heat | 01:28 | |
*** yangyapeng has quit IRC | 01:33 | |
*** yangyapeng has joined #heat | 01:34 | |
*** yangyape_ has joined #heat | 01:39 | |
*** yangyapeng has quit IRC | 01:39 | |
*** yuanying has quit IRC | 01:57 | |
*** yuanying has joined #heat | 02:00 | |
openstackgerrit | Rico Lin proposed openstack/heat master: Fix _retrigger_replaced in convergence worker https://review.openstack.org/480607 | 02:25 |
*** Shunli has joined #heat | 02:49 | |
*** kiennt has joined #heat | 03:10 | |
*** ramishra has joined #heat | 03:14 | |
*** d0ugal_ has joined #heat | 03:19 | |
*** d0ugal has quit IRC | 03:19 | |
*** gkadam has joined #heat | 03:30 | |
*** gkadam has quit IRC | 03:30 | |
*** gkadam has joined #heat | 03:30 | |
openstackgerrit | Merged openstack/heat master: Fix race in new condition test https://review.openstack.org/480486 | 03:36 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 03:45 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 03:45 |
*** mdnadeem has joined #heat | 03:47 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 03:53 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Implement all_dep_attrs() efficiently for get_attr https://review.openstack.org/477047 | 03:53 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 03:53 |
openstackgerrit | Rabi Mishra proposed openstack/heat master: DNM check uwsgi with thread count https://review.openstack.org/480822 | 03:57 |
*** flg_ has joined #heat | 04:00 | |
*** ramishra has quit IRC | 04:05 | |
*** links has joined #heat | 04:06 | |
*** ramishra has joined #heat | 04:07 | |
*** fragatin_ has joined #heat | 04:22 | |
*** ramishra has quit IRC | 04:23 | |
*** ramishra has joined #heat | 04:24 | |
*** fragatina has quit IRC | 04:26 | |
*** fragatin_ has quit IRC | 04:26 | |
*** iurygregory has quit IRC | 04:47 | |
*** iurygregory has joined #heat | 04:48 | |
*** dixiaoli has quit IRC | 04:58 | |
*** Shunli has quit IRC | 05:08 | |
*** gmoro has joined #heat | 05:08 | |
*** dixiaoli has joined #heat | 05:11 | |
*** skramaja has joined #heat | 05:21 | |
*** gmoro_ has quit IRC | 05:22 | |
*** harlowja has quit IRC | 05:22 | |
*** prateek has joined #heat | 05:24 | |
*** mnaser has quit IRC | 05:24 | |
*** mnaser has joined #heat | 05:27 | |
*** mnaser has joined #heat | 05:27 | |
*** prateek has quit IRC | 05:28 | |
*** prateek_ has joined #heat | 05:30 | |
*** prateek_ is now known as 7GHABESXC | 05:30 | |
*** prateek_ has joined #heat | 05:30 | |
*** prateek_ has quit IRC | 05:30 | |
*** kiennt has quit IRC | 05:38 | |
*** therve has quit IRC | 05:44 | |
*** dgonzalez has quit IRC | 05:44 | |
*** dgonzalez has joined #heat | 05:46 | |
*** therve has joined #heat | 05:46 | |
*** Shunli has joined #heat | 05:46 | |
*** kiennt has joined #heat | 05:58 | |
*** rcernin has joined #heat | 05:59 | |
*** ccamacho has quit IRC | 06:01 | |
*** rcernin has quit IRC | 06:04 | |
*** ioggstream has joined #heat | 06:09 | |
*** kiennt_ has joined #heat | 06:09 | |
*** kiennt has quit IRC | 06:12 | |
*** kiennt_ has quit IRC | 06:16 | |
*** kiennt has joined #heat | 06:16 | |
kiennt | ramishra: Hi, i want to ask you about multinode gate job for rolling upgrade testing. | 06:21 |
kiennt | What strategy do you prefer? utilize, modified Grenade gate job. Or Kolla-ansible gate based on, as you mentioned before. | 06:21 |
kiennt | Everything about rolling upgrade gate: https://review.openstack.org/#/c/407989/ | 06:21 |
ramishra | kiennt: hi, the one one that would be simpler and easy to maintain:) | 06:22 |
kiennt | please give me some advices :) Thanks | 06:22 |
ramishra | I've not seen anyone use grenade for rolling upgrade yet. grenade does not seem to have the building blocks for it. | 06:23 |
ramishra | so, if there is something that can be done quickly to test it at the gate it would be good. | 06:23 |
*** Shunli has quit IRC | 06:24 | |
ramishra | I've no preference on this, have not seen a job for rolling upgrade yet. | 06:24 |
ramishra | by any project | 06:25 |
kiennt | ramishra, grenade shuts down all services at once, so if we want to follow this strategy, we need change Grenade flow. The second seems good, but i get stuck to find the way to setup it. | 06:25 |
kiennt | Ironic team want build multinode grenade job for rolling | 06:26 |
kiennt | They mentioned in spec: https://github.com/openstack/ironic-specs/blob/master/specs/approved/support-rolling-upgrade.rst | 06:26 |
ramishra | may be ask the qa team for their suggestion? I would prefer we are not be the first one to do this;) | 06:26 |
ramishra | yeah, it's there in all specs merged glance, ironic etc.. I think neutron and nova did something to test it.. but I don't know the details | 06:27 |
ramishra | I don't know if any project has something that we can follow/use | 06:28 |
ramishra | I think cinder/swift also have the tag, may be ask them how they test it at the gate? | 06:30 |
kiennt | ramishra, i just read glance rolling upgrade spec. They `propose using Grenade for the full stack integration tests.`, just propose :) | 06:32 |
kiennt | i will ask Nova/Cinder team about this | 06:32 |
ramishra | yeah, I know.. all mentioned in specs nothing concrete yet | 06:33 |
ramishra | I thought kolla based testing would be easy, though I don't know much about kolla or spent time to understand how to do it either | 06:34 |
kiennt | Maybe another projects only use Grenade for now? I will ask and send you more info about it. | 06:34 |
kiennt | kolla based seems good, but build multinode job isn't easy | 06:35 |
kiennt | kolla-ansible had multinode node gate | 06:35 |
kiennt | already | 06:35 |
ramishra | "only use grenade" for what? AFAIK, grenade does not support rolling upgrade yet | 06:35 |
ramishra | I think you linked the spec in yesterday's meeting which was abandoned | 06:36 |
kiennt | Oh i mean, another projects, with them, passing grenade job is good enough, and they don't build any thing for rolling test. It's bad. | 06:38 |
kiennt | About the spec, it's a part of another spec, which was abandoned too because Intel won't be persuing this. But i think it still a great idea | 06:39 |
kiennt | https://review.openstack.org/#/c/449295/ | 06:40 |
kiennt | this spec about the set of tool for rolling upgrade test | 06:40 |
kiennt | universal gate, like Grenade but for rolling upgrade. | 06:40 |
ramishra | yeah.. specs may be good, but are not useful unless they are implemented by someone;) | 06:41 |
kiennt | ramishra, Now i am going to ask another projects how they test rolling upgrade. And ask qa-team too | 06:43 |
ramishra | yep, sounds good | 06:43 |
kiennt | yep, i will give you some informations asap. Hope we can the way :) | 06:44 |
ramishra | probably ask nova/neutron, I'm sure they did something together. Not sure if it's actively tested at the gate or not though | 06:44 |
*** gfidente has joined #heat | 06:44 | |
*** gfidente has joined #heat | 06:44 | |
kiennt | ramishra, ok, i will | 06:45 |
openstackgerrit | huangtianhua proposed openstack/heat master: Rollback stack with correct tags https://review.openstack.org/480153 | 06:47 |
*** fragatina has joined #heat | 06:50 | |
*** LanceHaig has quit IRC | 06:53 | |
*** fragatina has quit IRC | 06:54 | |
*** ccamacho has joined #heat | 06:55 | |
*** shardy has joined #heat | 07:06 | |
*** rwsu has quit IRC | 07:06 | |
*** dbecker has joined #heat | 07:19 | |
*** d0ugal_ has quit IRC | 07:46 | |
*** d0ugal has joined #heat | 07:46 | |
*** d0ugal has quit IRC | 07:46 | |
*** d0ugal has joined #heat | 07:46 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #heat | 08:01 | |
openstackgerrit | Bence Romsics proposed openstack/heat-templates master: New template: Example for Neutron Trunks https://review.openstack.org/475794 | 08:06 |
openstackgerrit | Bence Romsics proposed openstack/heat-templates master: New template: Example for Neutron Trunks https://review.openstack.org/475794 | 08:16 |
*** LanceHaig has joined #heat | 08:28 | |
*** LanceHaig has quit IRC | 08:28 | |
*** gkadam has quit IRC | 08:58 | |
*** dbecker has quit IRC | 09:03 | |
*** gkadam has joined #heat | 09:06 | |
openstackgerrit | Ethan Lynn proposed openstack/heat master: Set ssl options when initialize heat client() https://review.openstack.org/480923 | 09:09 |
openstackgerrit | Lajos Katona proposed openstack/heat master: Add trunk functional testcases to heat https://review.openstack.org/451799 | 09:12 |
kiennt | ramishra, hi, i asked QA team about our concern :) | 09:40 |
kiennt | http://eavesdrop.openstack.org/irclogs/%23openstack-qa/%23openstack-qa.2017-07-06.log.html#t2017-07-06T09:02:25 | 09:40 |
kiennt | here is the chatlog | 09:40 |
*** shardy is now known as working_shardy | 09:44 | |
ramishra | kiennt: not sure if I could understand much from that. It would be good to know what exactly nova test at the gate, we can atleast do that | 09:46 |
ramishra | if the sole objective is to get the tag;) | 09:46 |
*** gkadam has quit IRC | 09:47 | |
*** gkadam has joined #heat | 09:48 | |
*** dixiaoli has quit IRC | 09:51 | |
kiennt | ramishra: Of course, making something new like multinode gate job for rolling would be great, but it may take a lot of time and effort. | 09:52 |
kiennt | So, if you only want to get the tag, we can move on :) What's your opnion? | 09:53 |
kiennt | *opinion | 09:54 |
ramishra | kiennt: move on with no testing? | 09:54 |
kiennt | ramishra: Oh no, move on with some testing just like Nova | 09:54 |
kiennt | like QA's PTL said, `they only test the fact that two different versions of the nova service can run and work together` | 09:55 |
ramishra | kiennt: If that's something we and TC is happy with, then probably it's ok;) | 09:57 |
*** livelace has joined #heat | 09:57 | |
kiennt | ramishra: Andreaf said ` at the end that's most of what you need to prove rolling upgrade` :) I will try to setup multinode gate for rolling test, hope it can be done soon. | 09:58 |
*** dbecker has joined #heat | 09:58 | |
kiennt | Btw, can you review my patch set about spec and docs for rolling upgrade and leave some comments? | 09:59 |
ramishra | sure, will do | 10:00 |
kiennt | ramishra, thank you. I had to drop off now :) Thanks again | 10:00 |
*** yassine has joined #heat | 10:00 | |
*** yassine has quit IRC | 10:00 | |
*** yassine has joined #heat | 10:01 | |
ramishra | kiennt: np:) | 10:03 |
*** kiennt has quit IRC | 10:05 | |
*** elynn_ has quit IRC | 10:12 | |
*** working_shardy is now known as shardy | 10:21 | |
*** yangyape_ has quit IRC | 10:35 | |
openstackgerrit | Lajos Katona proposed openstack/heat master: Add trunk functional testcases to heat https://review.openstack.org/451799 | 10:57 |
*** rwsu has joined #heat | 11:33 | |
openstackgerrit | huangtianhua proposed openstack/heat master: Rollback stack with correct tags https://review.openstack.org/480153 | 11:51 |
openstackgerrit | huangtianhua proposed openstack/heat master: [api-ref] Correct config_id in url instead of in body https://review.openstack.org/481005 | 12:00 |
*** yangyapeng has joined #heat | 12:02 | |
*** jmlowe has joined #heat | 12:08 | |
*** gmoro has quit IRC | 12:11 | |
*** gmoro has joined #heat | 12:12 | |
*** jmlowe has quit IRC | 12:16 | |
*** dprince has joined #heat | 12:24 | |
*** chlong_ has joined #heat | 12:37 | |
*** mdnadeem has quit IRC | 12:42 | |
*** jmlowe has joined #heat | 12:56 | |
*** skramaja has quit IRC | 13:09 | |
*** jcoufal has joined #heat | 13:10 | |
*** 7GHABESXC has quit IRC | 13:10 | |
*** rwsu has quit IRC | 13:14 | |
openstackgerrit | Rabi Mishra proposed openstack/heat master: DNM check uwsgi with thread count https://review.openstack.org/480822 | 13:17 |
*** catintheroof has joined #heat | 13:25 | |
*** dprince has quit IRC | 13:26 | |
*** dprince has joined #heat | 13:29 | |
*** catintheroof has quit IRC | 13:36 | |
*** gkadam has quit IRC | 13:36 | |
*** catintheroof has joined #heat | 13:37 | |
*** LanceHaig has joined #heat | 13:47 | |
*** LanceHaig has quit IRC | 13:47 | |
*** LanceHaig has joined #heat | 13:47 | |
*** blomquisg_gone is now known as blomquisg | 13:48 | |
*** livelace has quit IRC | 13:54 | |
*** LanceHaig has quit IRC | 13:55 | |
*** ramishra has quit IRC | 13:58 | |
*** jdandrea has quit IRC | 13:59 | |
*** jdandrea has joined #heat | 13:59 | |
*** ramishra has joined #heat | 14:00 | |
*** hongbin has joined #heat | 14:01 | |
*** spzala has joined #heat | 14:03 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 14:06 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Cache dep_attrs for all resources in definitions https://review.openstack.org/477046 | 14:06 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Implement all_dep_attrs() efficiently for get_attr https://review.openstack.org/477047 | 14:06 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 14:06 |
*** links has quit IRC | 14:18 | |
*** dprince has quit IRC | 14:52 | |
*** catintheroof has quit IRC | 14:58 | |
*** spzala has quit IRC | 15:01 | |
*** catintheroof has joined #heat | 15:02 | |
ricolin | Hi zaneb about https://review.openstack.org/#/c/480607 , did you know any reliable way for test that we can jump into this logic(https://github.com/openstack/heat/blob/master/heat/engine/worker.py#L135)? | 15:28 |
ricolin | s/did/do/ | 15:29 |
ricolin | we can do it with resource group (like fail one of servers in group when replace it), but it's a little race condition there | 15:31 |
ricolin | which means not stable enough to be a gate test | 15:32 |
ricolin | therve, any idea?^^^ | 15:32 |
*** dixiaoli has joined #heat | 15:53 | |
*** dixiaoli has quit IRC | 15:57 | |
*** hjensas has quit IRC | 16:11 | |
*** hjensas has joined #heat | 16:12 | |
*** rwsu has joined #heat | 16:12 | |
*** ramishra has quit IRC | 16:19 | |
*** ramishra has joined #heat | 16:21 | |
*** dprince has joined #heat | 16:23 | |
*** dbecker has quit IRC | 16:27 | |
zaneb | ricolin: so... remind me what triggers this path again? | 16:33 |
*** felipemonteiro has joined #heat | 16:36 | |
*** ramishra has quit IRC | 16:38 | |
zaneb | oh, I see... yeah, that does require a race :/ | 16:39 |
ricolin | for example, with a instance resource group created, if you suspend one of those instance, and after that if we update those resources and if any of those instance got update replaced(like changing the keypair) and successed before try to do anything to that suspended instance, that update replace one will have to retrigger again | 16:39 |
ricolin | zaneb, tl;dr; yes:( | 16:40 |
zaneb | so we need a resource that does nothing for a while, and *then* raises UpdateReplace | 16:40 |
ricolin | I don't think that will jump in to that logic if we can't satisfied `if current_traversal != stack.current_traversal` | 16:43 |
zaneb | ricolin: should be easy enough to modify TestResource to do that ^. maybe add an UPDATE_REPLACE_WAIT_SECS property? | 16:43 |
zaneb | ricolin: that part is easy enough, just trigger a rollback | 16:43 |
zaneb | apparently they were originally hitting the problem in this test: https://review.openstack.org/#/c/306490/16/heat_integrationtests/functional/test_cancel_update.py | 16:44 |
zaneb | so I'd guess the test should look like that except with tighter control of the timing | 16:45 |
ricolin | zaneb, yep | 16:45 |
*** ioggstream has quit IRC | 16:47 | |
ricolin | zaneb, and IMO it got more race required when thinking about jump into logic if key not in graph and rsrc.replaces is not None: in _retrigger_replaced | 16:47 |
*** gfidente has quit IRC | 16:53 | |
ricolin | also I did test with test_resource+update replace, it also require race there | 16:56 |
*** shardy has quit IRC | 17:07 | |
*** rwsu has quit IRC | 17:07 | |
*** rwsu has joined #heat | 17:07 | |
*** fragatina has joined #heat | 17:11 | |
*** harlowja has joined #heat | 17:13 | |
*** zzzeek has quit IRC | 17:14 | |
*** jmlowe has quit IRC | 17:23 | |
*** fragatina has quit IRC | 17:25 | |
*** fragatina has joined #heat | 17:25 | |
*** zzzeek has joined #heat | 17:33 | |
*** LanceHaig has joined #heat | 17:36 | |
*** LanceHaig has quit IRC | 17:36 | |
*** LanceHaig has joined #heat | 17:36 | |
openstackgerrit | Rabi Mishra proposed openstack/heat master: DNM check uwsgi with thread count https://review.openstack.org/480822 | 17:36 |
*** zzzeek has quit IRC | 17:37 | |
*** zzzeek has joined #heat | 17:41 | |
*** zzzeek has quit IRC | 17:53 | |
*** fragatin_ has joined #heat | 17:59 | |
*** zzzeek has joined #heat | 18:00 | |
*** fragatina has quit IRC | 18:03 | |
*** zzzeek_ has joined #heat | 18:08 | |
*** zzzeek has quit IRC | 18:09 | |
*** jtomasek has joined #heat | 18:18 | |
*** dbecker has joined #heat | 18:33 | |
*** LanceHaig has quit IRC | 18:41 | |
*** jtomasek has quit IRC | 18:46 | |
*** ricolin has quit IRC | 18:48 | |
*** jmlowe has joined #heat | 19:03 | |
*** ccamacho has quit IRC | 19:05 | |
*** jtomasek has joined #heat | 19:11 | |
*** jtomasek has quit IRC | 19:28 | |
*** fragatin_ has quit IRC | 19:28 | |
*** fragatina has joined #heat | 19:29 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 19:30 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 19:30 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 19:38 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 19:38 |
*** dbecker has quit IRC | 20:10 | |
*** felipemonteiro has quit IRC | 20:14 | |
*** dprince has quit IRC | 20:17 | |
*** blomquisg is now known as blomquisg_gone | 20:19 | |
*** dbecker has joined #heat | 20:45 | |
*** jcoufal has quit IRC | 20:47 | |
*** ioggstream has joined #heat | 20:50 | |
*** jmlowe has quit IRC | 21:01 | |
*** jmlowe has joined #heat | 21:09 | |
*** flg_ has quit IRC | 21:24 | |
*** jmlowe has quit IRC | 21:25 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Add a functional test for nested get_attr functions https://review.openstack.org/480820 | 21:26 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Fix legacy updates with nested dep_attr functions https://review.openstack.org/480819 | 21:26 |
openstackgerrit | James Slagle proposed openstack/heat master: Make deployment_swift_data updateable https://review.openstack.org/481288 | 21:28 |
*** jmlowe has joined #heat | 21:42 | |
*** catintheroof has quit IRC | 21:55 | |
*** felipemonteiro has joined #heat | 22:07 | |
*** dprince has joined #heat | 22:25 | |
openstackgerrit | Harald Jensås proposed openstack/heat master: Exclude updated networks - match actual interface state https://review.openstack.org/471969 | 23:19 |
*** ioggstream has quit IRC | 23:27 | |
*** dprince has quit IRC | 23:35 | |
*** hongbin has quit IRC | 23:38 | |
-openstackstatus- NOTICE: nb03.openstack.org has been cleaned up and rebooted, and should return to building rotation | 23:42 | |
openstackgerrit | Harald Jensås proposed openstack/heat master: Exclude updated networks - match actual interface state https://review.openstack.org/471969 | 23:50 |
openstackgerrit | Harald Jensås proposed openstack/heat master: Exclude updated networks - match actual interface state https://review.openstack.org/471969 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!