*** yangyape_ has quit IRC | 00:08 | |
*** yangyapeng has joined #heat | 00:09 | |
*** yangyapeng has quit IRC | 00:13 | |
*** catintheroof has joined #heat | 00:19 | |
*** Shunli has joined #heat | 00:33 | |
*** hieulq has joined #heat | 00:42 | |
*** kiennt26 has joined #heat | 01:02 | |
*** ricolin has joined #heat | 01:09 | |
*** yangyapeng has joined #heat | 01:12 | |
*** ricolin has quit IRC | 01:14 | |
*** liusheng has quit IRC | 01:14 | |
*** yangyapeng has quit IRC | 01:16 | |
*** liusheng has joined #heat | 01:22 | |
*** wangbo has joined #heat | 01:24 | |
*** kei-ichi has quit IRC | 01:34 | |
*** kei-ichi has joined #heat | 01:36 | |
*** catintheroof has quit IRC | 01:37 | |
*** catintheroof has joined #heat | 01:38 | |
*** catintheroof has quit IRC | 01:57 | |
openstackgerrit | huangtianhua proposed openstack/heat master: Make sure we can get watch server url in uwsgi mode https://review.openstack.org/504876 | 02:12 |
---|---|---|
*** wangbo has quit IRC | 02:15 | |
*** ricolin has joined #heat | 02:18 | |
openstackgerrit | Rico Lin proposed openstack/heat master: Add attributes schema for OS::Keystone::Project https://review.openstack.org/462673 | 02:18 |
*** yangyapeng has joined #heat | 02:22 | |
*** yangyapeng has quit IRC | 02:25 | |
*** yangyapeng has joined #heat | 02:25 | |
openstackgerrit | huangtianhua proposed openstack/heat master: Unskip test_cancel_update_server_with_port https://review.openstack.org/506975 | 02:30 |
*** namnh has joined #heat | 02:41 | |
*** wangbo has joined #heat | 02:53 | |
*** wangbo has quit IRC | 02:54 | |
*** wangbo has joined #heat | 02:55 | |
*** yangyapeng has quit IRC | 02:55 | |
*** yangyapeng has joined #heat | 02:56 | |
*** kei-ichi has quit IRC | 02:57 | |
*** kei-ichi has joined #heat | 02:58 | |
*** wangbo has quit IRC | 03:16 | |
*** Shunli has quit IRC | 03:35 | |
*** gkadam has joined #heat | 03:38 | |
*** gkadam has quit IRC | 03:39 | |
*** gkadam has joined #heat | 03:39 | |
*** wangbo has joined #heat | 03:44 | |
*** links has joined #heat | 04:25 | |
*** wangbo has quit IRC | 04:32 | |
*** mdnadeem has joined #heat | 04:41 | |
*** livelace has joined #heat | 05:03 | |
*** wangbo has joined #heat | 05:09 | |
*** Shunli has joined #heat | 05:33 | |
*** zsli_ has joined #heat | 05:49 | |
*** Shunli has quit IRC | 05:52 | |
*** zsli_ has quit IRC | 06:09 | |
*** kei-ichi has quit IRC | 06:10 | |
*** kei-ichi has joined #heat | 06:11 | |
*** jprovazn has joined #heat | 06:26 | |
*** armaan has joined #heat | 06:28 | |
*** rcernin has joined #heat | 06:41 | |
*** kei-ichi has quit IRC | 06:51 | |
*** armaan has quit IRC | 06:52 | |
*** kei-ichi has joined #heat | 06:52 | |
*** armaan has joined #heat | 06:52 | |
*** ivveh has joined #heat | 06:54 | |
*** ivveh- has quit IRC | 06:56 | |
*** armaan has quit IRC | 07:00 | |
*** armaan has joined #heat | 07:01 | |
*** cmyster has joined #heat | 07:02 | |
*** ioggstream has joined #heat | 07:03 | |
*** kiennt26 has quit IRC | 07:05 | |
*** kiennt26 has joined #heat | 07:05 | |
ioggstream | hi@heat | 07:09 |
openstackgerrit | Merged openstack/heat master: Remove the existing snapshots from the backend https://review.openstack.org/503892 | 07:10 |
therve | 'morning | 07:23 |
ricolin | o/ | 07:28 |
*** ccamacho has joined #heat | 07:37 | |
ioggstream | this needs workflow, how does it work? https://review.openstack.org/#/c/502019/ | 07:38 |
*** hieulq has quit IRC | 07:45 | |
openstackgerrit | Wang Bo proposed openstack/heat master: Enable to specify network for Trove Cluster https://review.openstack.org/505521 | 07:47 |
*** shardy has joined #heat | 07:55 | |
*** gkadam is now known as gkadam-afk | 07:55 | |
*** serlex has joined #heat | 07:58 | |
*** kiennt26 has quit IRC | 08:01 | |
*** Shunli has joined #heat | 08:06 | |
openstackgerrit | Rico Lin proposed openstack/heat master: Replace SCREEN_LOGDIR with LOGDIR https://review.openstack.org/507014 | 08:07 |
*** kei-ichi has quit IRC | 08:09 | |
*** kei-ichi has joined #heat | 08:10 | |
*** ivveh has quit IRC | 08:13 | |
*** ivveh has joined #heat | 08:16 | |
*** zaneb has quit IRC | 08:17 | |
*** zaneb has joined #heat | 08:24 | |
*** armaan has quit IRC | 08:25 | |
*** armaan has joined #heat | 08:26 | |
*** mikal_ has joined #heat | 08:29 | |
*** armaan has quit IRC | 08:31 | |
*** armaan has joined #heat | 08:32 | |
*** gfidente has joined #heat | 08:32 | |
*** gfidente has joined #heat | 08:32 | |
*** gfidente is now known as gfidente|pto | 08:32 | |
*** mikal has quit IRC | 08:32 | |
*** kei-ichi has quit IRC | 08:33 | |
*** kei-ichi has joined #heat | 08:34 | |
*** gkadam-afk is now known as gkadam | 08:41 | |
*** derekh has joined #heat | 08:42 | |
*** rwsu has joined #heat | 08:43 | |
*** armaan has quit IRC | 08:44 | |
*** armaan has joined #heat | 08:44 | |
*** armaan has quit IRC | 08:50 | |
*** armaan has joined #heat | 08:50 | |
*** Shunli has quit IRC | 08:51 | |
*** dbecker has joined #heat | 08:57 | |
*** kei-ichi has quit IRC | 09:03 | |
*** kei-ichi has joined #heat | 09:03 | |
*** wangbo has quit IRC | 09:12 | |
*** pbourke has quit IRC | 09:22 | |
*** pbourke has joined #heat | 09:23 | |
openstackgerrit | Merged openstack/heat master: Improve update_wait_condition_handle docstring https://review.openstack.org/502019 | 09:23 |
*** ioggstream has quit IRC | 09:36 | |
*** kiennt26 has joined #heat | 09:39 | |
*** wangbo has joined #heat | 09:48 | |
*** wangbo has quit IRC | 09:50 | |
*** namnh has quit IRC | 09:59 | |
*** nicolasbock has joined #heat | 10:02 | |
*** livelace has quit IRC | 10:03 | |
*** kiennt26 has quit IRC | 10:10 | |
*** kiennt26 has joined #heat | 10:11 | |
*** nicolasbock has quit IRC | 10:12 | |
*** kiennt26 has quit IRC | 10:23 | |
*** cmyster has quit IRC | 10:23 | |
*** nicolasbock has joined #heat | 10:24 | |
*** wangbo has joined #heat | 10:33 | |
*** wangbo has quit IRC | 10:40 | |
*** wangbo has joined #heat | 10:42 | |
*** wangbo has quit IRC | 10:43 | |
*** wangbo has joined #heat | 10:45 | |
*** hieulq has joined #heat | 10:50 | |
*** armaan has quit IRC | 10:56 | |
*** armaan has joined #heat | 10:57 | |
*** AlexeyAbashkin has joined #heat | 10:58 | |
*** wangbo has quit IRC | 10:58 | |
*** AlexeyAbashkin has quit IRC | 11:00 | |
*** yangyapeng has quit IRC | 11:05 | |
*** livelace has joined #heat | 11:06 | |
*** clayton has quit IRC | 11:25 | |
*** armaan has quit IRC | 11:30 | |
*** clayton has joined #heat | 11:30 | |
*** armaan has joined #heat | 11:30 | |
*** ivve has quit IRC | 11:34 | |
*** wangbo has joined #heat | 11:38 | |
*** wangbo_ has joined #heat | 11:42 | |
*** wangbo has quit IRC | 11:42 | |
*** dprince has joined #heat | 12:01 | |
*** jmlowe has quit IRC | 12:10 | |
*** jcoufal has joined #heat | 12:10 | |
*** MVenesio has joined #heat | 12:11 | |
*** cmyster has joined #heat | 12:12 | |
*** pradk has quit IRC | 12:13 | |
*** yangyapeng has joined #heat | 12:20 | |
*** jcoufal has quit IRC | 12:24 | |
*** gfidente|pto is now known as gfidente | 12:36 | |
*** gkadam has quit IRC | 12:36 | |
*** derekh has quit IRC | 12:40 | |
*** derekh has joined #heat | 12:41 | |
openstackgerrit | Wang Bo proposed openstack/heat master: Enable to specify network for Trove Cluster https://review.openstack.org/505521 | 12:52 |
*** jistr is now known as jistr|mtg | 13:03 | |
*** jmlowe has joined #heat | 13:07 | |
*** amrith has left #heat | 13:08 | |
*** hjensas has quit IRC | 13:12 | |
*** wangbo_ has quit IRC | 13:16 | |
*** links has quit IRC | 13:23 | |
*** pradk has joined #heat | 13:25 | |
*** gouthamr has joined #heat | 13:26 | |
*** kiennt26 has joined #heat | 13:29 | |
*** gouthamr has quit IRC | 13:29 | |
*** jistr|mtg is now known as jistr | 13:29 | |
*** gouthamr has joined #heat | 13:30 | |
*** gfidente has quit IRC | 13:33 | |
therve | zaneb, Hey there | 13:45 |
zaneb | official most bizarro user question ever: https://ask.openstack.org/en/question/110405/why-are-there-3-different-intrinsic-functions-get_-instead-of-one-single-unified-one/?answer=110452#post-id-110452 | 13:45 |
therve | :) | 13:49 |
therve | zaneb, So. Outputs are slow! Why? | 13:49 |
zaneb | :( | 13:50 |
therve | zaneb, Are attributes only stored in convergence? | 13:50 |
zaneb | yes | 13:50 |
therve | OK I forgot about that | 13:51 |
zaneb | but we only get the ones we need to show outputs, so it shouldn't be any slower than before I thought? | 13:51 |
therve | zaneb, So... I'm not sure about that | 13:52 |
therve | It seems we're retrieving everything in resource groups? | 13:52 |
*** hjensas has joined #heat | 13:53 | |
*** hjensas has quit IRC | 13:53 | |
*** hjensas has joined #heat | 13:53 | |
therve | Wonder if I can make a test pre-refactoring | 13:53 |
zaneb | ugh, I bet it's the solution to the ******* nested get_attr problem causing it | 13:53 |
therve | https://review.openstack.org/#/c/469686/ ? | 13:55 |
zaneb | therve: so in list_outputs()/show_output() (who named these?) we pass for_resources=False http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/service.py#n1364 | 13:57 |
*** chlong has joined #heat | 13:57 | |
therve | Right | 13:57 |
zaneb | but in show_stack() we don't: http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/service.py#n533 | 13:58 |
zaneb | I wonder if that's a bug | 13:58 |
therve | Those flags don't make sense to me :/ | 13:58 |
*** pradk has quit IRC | 13:59 | |
zaneb | so we're getting the node data that is referenced by other resources (by default), or by outputs, or both | 13:59 |
zaneb | we know where get_attr is used in the template, so we can figure out which attributes need to be loaded and which do not | 14:00 |
zaneb | depending on what we're trying to show | 14:00 |
therve | zaneb, I have a system with the issue, want something to try? | 14:00 |
zaneb | sure | 14:01 |
*** beekneemech is now known as bnemec | 14:02 | |
therve | zaneb, Do you want the hand, or can I hack something? | 14:03 |
*** ivve has joined #heat | 14:04 | |
zaneb | hack away :) | 14:06 |
*** pradk has joined #heat | 14:12 | |
therve | zaneb, Yeah I was hoping for some suggestions :D | 14:12 |
zaneb | therve: try this: https://paste.fedoraproject.org/paste/-3BKV6-hCXMUhxKoPR7tQw/ | 14:13 |
therve | zaneb, Hum I was looking mostly at show_output right now | 14:14 |
zaneb | oh | 14:14 |
zaneb | :( | 14:14 |
therve | Yeah stack show with outputs is probably slow, but that's somewhat expected | 14:14 |
zaneb | that really shouldn't be slow then | 14:15 |
therve | Here show output is slow | 14:15 |
zaneb | can you paste the templates somewhere? or is it all of TripleO? | 14:15 |
*** mdnadeem has quit IRC | 14:16 | |
therve | Yeah it's tripleo | 14:16 |
zaneb | therve: https://review.openstack.org/#/c/475931/ is the prime suspect | 14:19 |
*** hongbin has joined #heat | 14:20 | |
*** livelace2 has joined #heat | 14:20 | |
zaneb | therve: hey, guess what? we're using show_stack to get nested stack outputs: http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/stack_resource.py#n609 | 14:27 |
therve | Oh, yeah. Of course we do | 14:28 |
zaneb | can't actually see a reason we couldn't use list_outputs() there | 14:30 |
*** livelace2 has quit IRC | 14:35 | |
therve | zaneb, OK that does seem to make a difference | 14:40 |
zaneb | cool. enough of a difference? | 14:40 |
therve | Though I probably touched too many things so I need to start again :) | 14:40 |
zaneb | lol | 14:41 |
zaneb | therve: I take it there's no bug open for this? | 14:43 |
therve | zaneb, https://bugzilla.redhat.com/show_bug.cgi?id=1493263 | 14:43 |
openstack | bugzilla.redhat.com bug 1493263 in rhosp-director "tripleo.deployment.overcloudrc workflow fails on clean deployment and during upgrade with: Internal Server Error (HTTP 500)" [Urgent,New] - Assigned to brad | 14:43 |
zaneb | therve: ok, I'll open one in Launchpad too | 14:44 |
*** hjensas has quit IRC | 14:44 | |
therve | zaneb, I get weird reference error when just replacing the rpc call | 14:47 |
zaneb | I wonder if the output format is different | 14:48 |
zaneb | (not pun intended) | 14:48 |
*** livelace2 has joined #heat | 14:49 | |
therve | Hum yeah | 14:52 |
therve | Oh | 14:54 |
therve | zaneb, list_outputs doesn't have value :/ | 14:54 |
zaneb | oh, it really is just a list? | 14:54 |
therve | Yeah | 14:54 |
zaneb | we shouldn't be loading all of the data in there at all then | 14:55 |
zaneb | return api.format_stack_outputs(stack.outputs) <- surely that returns values? | 14:57 |
therve | No | 14:57 |
zaneb | ugh, resolve_value=False | 14:57 |
zaneb | ah, but format_stack_output defaults to resolve_value=True | 14:58 |
zaneb | that's not confusing at all :/ | 14:58 |
*** felipemonteiro has joined #heat | 14:58 | |
zaneb | whyyyy would you not pass that explicitly | 15:00 |
*** felipemonteiro_ has joined #heat | 15:02 | |
therve | zaneb, OK, so if I resolve the values it doesn't really make a difference compare to stack show | 15:03 |
*** felipemonteiro has quit IRC | 15:05 | |
zaneb | therve: so show_output must be using stack_show under the hood, so you are actually using stack_show at the top level. and that's probably what's slowing it down | 15:06 |
zaneb | since in ResourceGroups the only attributes accessed will be the ones accessed by outputs anyway | 15:06 |
therve | Hum | 15:09 |
*** links has joined #heat | 15:09 | |
*** thrash has joined #heat | 15:10 | |
*** crose has joined #heat | 15:11 | |
therve | zaneb, So it worked in milestone 2 | 15:12 |
therve | around 20s for a stack show | 15:12 |
therve | m3 is around 110s | 15:12 |
zaneb | ouch | 15:12 |
*** ccamacho has quit IRC | 15:13 | |
zaneb | and with the change I pasted above? | 15:13 |
therve | That only leaves us with a few thousand of lines or so :) | 15:13 |
therve | zaneb, https://paste.fedoraproject.org/paste/-3BKV6-hCXMUhxKoPR7tQw you mean? | 15:13 |
zaneb | most of my big series of changes landed between m2 & m3, so not surprising that it'd be in there somewhere | 15:14 |
zaneb | therve: yes, that one | 15:14 |
therve | zaneb, Isn't that convergence only? | 15:14 |
therve | It looks like it would be | 15:14 |
zaneb | no, it fixes legacy to not do the expensive stuff we do in convergence | 15:14 |
zaneb | which isn't expensive (or is worth it) in convergence, but is in legacy | 15:15 |
* therve looks again | 15:15 | |
therve | Ah yeah for_resources is False | 15:15 |
zaneb | exactly | 15:16 |
*** links has quit IRC | 15:17 | |
therve | zaneb, Ah yeah it's better | 15:20 |
therve | Only 3 times slower instead of 6 :D | 15:20 |
zaneb | well, that's... something | 15:21 |
therve | Heh | 15:21 |
zaneb | 200% improvement in performance, as they would say in marketing | 15:21 |
*** kiennt26 has quit IRC | 15:21 | |
*** crose has quit IRC | 15:22 | |
*** crose has joined #heat | 15:24 | |
*** serlex has quit IRC | 15:26 | |
*** links has joined #heat | 15:30 | |
*** jmlowe has quit IRC | 15:37 | |
*** jmlowe has joined #heat | 15:44 | |
*** crose has quit IRC | 15:44 | |
*** crose has joined #heat | 15:47 | |
*** rcernin has quit IRC | 15:48 | |
*** crose has quit IRC | 16:01 | |
*** links has quit IRC | 16:10 | |
*** ccamacho has joined #heat | 16:15 | |
*** gkadam has joined #heat | 16:24 | |
*** ccamacho has quit IRC | 16:37 | |
*** gkadam has quit IRC | 16:42 | |
*** vishwanathj has joined #heat | 16:45 | |
*** livelace2 has quit IRC | 16:47 | |
*** armaan has quit IRC | 16:48 | |
*** armaan has joined #heat | 16:49 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Speed up show-stack with outputs in legacy path https://review.openstack.org/507206 | 16:50 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Don't load resource data for list_outputs https://review.openstack.org/507207 | 16:50 |
*** armaan has quit IRC | 16:53 | |
*** livelace has quit IRC | 16:59 | |
*** derekh has quit IRC | 16:59 | |
*** livelace2 has joined #heat | 17:01 | |
zaneb | therve: found the culprit: http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/template_resource.py#n304 <wince> | 17:05 |
*** masber has quit IRC | 17:10 | |
*** chlong has quit IRC | 17:10 | |
*** harlowja has joined #heat | 17:20 | |
*** thrash is now known as thrash|biab | 17:29 | |
*** chlong has joined #heat | 17:29 | |
*** hjensas has joined #heat | 17:53 | |
*** hjensas has joined #heat | 17:53 | |
*** felipemonteiro_ has quit IRC | 17:58 | |
*** rcernin has joined #heat | 18:11 | |
*** livelace2 has quit IRC | 18:12 | |
*** rwsu has quit IRC | 18:13 | |
*** jmlowe has quit IRC | 18:15 | |
*** livelace2 has joined #heat | 18:25 | |
*** livelace2 has quit IRC | 18:30 | |
*** blomquisg_gone has quit IRC | 18:33 | |
*** ltomasbo has quit IRC | 18:35 | |
*** ltomasbo has joined #heat | 18:37 | |
*** blomquisg_gone has joined #heat | 18:37 | |
*** livelace2 has joined #heat | 18:38 | |
*** thrash|biab is now known as thrash | 18:41 | |
*** livelace2 has quit IRC | 18:44 | |
openstackgerrit | Matthew Edmonds proposed openstack/heat master: fix logger names https://review.openstack.org/495310 | 18:53 |
*** yangyape_ has joined #heat | 18:54 | |
*** yangyapeng has quit IRC | 18:55 | |
*** livelace2 has joined #heat | 18:56 | |
*** chlong has quit IRC | 19:06 | |
*** felipemonteiro has joined #heat | 19:08 | |
*** jose-phillips has quit IRC | 19:08 | |
*** jose-phillips has joined #heat | 19:13 | |
*** lifeless has quit IRC | 19:14 | |
*** lifeless has joined #heat | 19:15 | |
*** jmlowe has joined #heat | 19:19 | |
*** chlong has joined #heat | 19:32 | |
*** rwsu has joined #heat | 19:32 | |
*** felipemonteiro_ has joined #heat | 19:37 | |
openstackgerrit | Zane Bitter proposed openstack/heat master: Use show_output in TemplateResource.get_reference_id() https://review.openstack.org/507248 | 19:40 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Ignore errors in OS::stack_id output https://review.openstack.org/507249 | 19:40 |
openstackgerrit | Zane Bitter proposed openstack/heat master: Use appropriate exception in StackResource.get_output() https://review.openstack.org/507250 | 19:40 |
*** felipemonteiro has quit IRC | 19:41 | |
*** jmlowe has quit IRC | 19:42 | |
*** jmlowe has joined #heat | 19:50 | |
*** chlong has quit IRC | 20:05 | |
*** rcernin has quit IRC | 20:11 | |
*** blomquisg_gone has quit IRC | 20:14 | |
*** ltomasbo has quit IRC | 20:14 | |
*** ltomasbo has joined #heat | 20:17 | |
*** blomquisg_gone has joined #heat | 20:17 | |
*** dprince has quit IRC | 20:19 | |
*** nicolasbock has quit IRC | 20:35 | |
*** jprovazn has quit IRC | 20:37 | |
*** armaan has joined #heat | 20:42 | |
*** felipemonteiro_ has quit IRC | 20:43 | |
*** felipemonteiro_ has joined #heat | 20:43 | |
*** jmlowe has quit IRC | 20:47 | |
*** dprince has joined #heat | 20:47 | |
*** huangtianhua_ has joined #heat | 20:48 | |
-openstackstatus- NOTICE: The infra team is bringing Zuul v3 online; expect service disruptions and please see https://docs.openstack.org/infra/manual/zuulv3.html for more information. | 20:49 | |
*** huangtianhua has quit IRC | 20:51 | |
*** liusheng has quit IRC | 20:52 | |
*** liusheng has joined #heat | 20:53 | |
*** jtomasek has quit IRC | 20:57 | |
*** gouthamr has quit IRC | 21:04 | |
*** armaan has quit IRC | 21:08 | |
*** chlong has joined #heat | 21:21 | |
*** jmlowe has joined #heat | 21:25 | |
*** chlong has quit IRC | 21:27 | |
*** jtomasek has joined #heat | 21:27 | |
*** chlong has joined #heat | 21:28 | |
*** jtomasek has quit IRC | 21:28 | |
*** MVenesio has quit IRC | 21:37 | |
*** MVenesio has joined #heat | 21:37 | |
*** MVenesio has quit IRC | 21:41 | |
therve | zaneb, Oh no | 21:45 |
*** jose-phillips has quit IRC | 21:46 | |
*** dprince has quit IRC | 21:46 | |
*** jose-phillips has joined #heat | 21:47 | |
*** shardy has quit IRC | 21:47 | |
*** jose-phillips has quit IRC | 21:48 | |
*** hjensas has quit IRC | 21:56 | |
*** rwsu has quit IRC | 21:57 | |
*** jose-phillips has joined #heat | 22:07 | |
*** jose-phillips has quit IRC | 22:07 | |
*** pradk has quit IRC | 22:11 | |
*** gouthamr has joined #heat | 22:12 | |
*** sai has quit IRC | 22:25 | |
*** sai has joined #heat | 22:25 | |
*** hieulq has quit IRC | 23:07 | |
*** felipemonteiro_ has quit IRC | 23:12 | |
*** hongbin has quit IRC | 23:29 | |
*** masber has joined #heat | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!