| *** k_mouza has joined #heat | 00:03 | |
| *** k_mouza has quit IRC | 00:09 | |
| *** masber has joined #heat | 00:21 | |
| *** jrist has quit IRC | 00:24 | |
| *** AlexeyAbashkin has joined #heat | 00:24 | |
| *** AlexeyAbashkin has quit IRC | 00:28 | |
| *** jrist has joined #heat | 00:36 | |
| *** openstackgerrit has joined #heat | 00:40 | |
| openstackgerrit | Merged openstack/heat-dashboard master: Imported Translations from Zanata https://review.openstack.org/545749 | 00:40 |
|---|---|---|
| *** armaan has quit IRC | 01:00 | |
| *** ysandeep has joined #heat | 01:06 | |
| *** k_mouza has joined #heat | 01:40 | |
| *** k_mouza has quit IRC | 01:45 | |
| *** armaan has joined #heat | 01:55 | |
| *** vishwanathj has joined #heat | 02:20 | |
| *** yangyapeng has quit IRC | 02:47 | |
| *** yangyapeng has joined #heat | 02:47 | |
| *** harlowja has quit IRC | 02:52 | |
| *** yangyape_ has joined #heat | 03:00 | |
| *** yangyapeng has quit IRC | 03:01 | |
| *** hongbin has joined #heat | 03:10 | |
| *** AlexeyAbashkin has joined #heat | 03:24 | |
| *** AlexeyAbashkin has quit IRC | 03:29 | |
| *** gkadam has joined #heat | 03:39 | |
| openstackgerrit | Kien Nguyen proposed openstack/heat master: Run the specified set of tests in grenade-multinode job https://review.openstack.org/542629 | 03:45 |
| *** links has joined #heat | 04:21 | |
| *** ramishra has joined #heat | 04:35 | |
| *** bnemec-pto has quit IRC | 04:36 | |
| *** ying_zuo has left #heat | 04:51 | |
| *** harlowja has joined #heat | 04:54 | |
| *** hongbin has quit IRC | 05:01 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Fix race conditions in test_create_update https://review.openstack.org/498657 | 05:40 |
| *** skramaja has joined #heat | 05:41 | |
| *** gkadam has quit IRC | 05:43 | |
| *** gkadam has joined #heat | 05:44 | |
| *** gfidente|afk has quit IRC | 05:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/heat master: Imported Translations from Zanata https://review.openstack.org/545659 | 06:16 |
| *** bnemec has joined #heat | 06:28 | |
| *** bnemec is now known as bnemec-pto | 06:29 | |
| *** dbecker has quit IRC | 06:31 | |
| *** dbecker has joined #heat | 06:44 | |
| *** harlowja has quit IRC | 07:10 | |
| *** ygl has joined #heat | 07:11 | |
| *** rcernin has quit IRC | 07:12 | |
| *** gkadam has quit IRC | 07:34 | |
| *** gkadam has joined #heat | 07:34 | |
| *** SmearedBeard has joined #heat | 07:34 | |
| *** ygl has quit IRC | 07:37 | |
| *** AlexeyAbashkin has joined #heat | 07:53 | |
| *** yangyape_ has quit IRC | 08:10 | |
| *** yangyapeng has joined #heat | 08:17 | |
| *** hoonetorg has quit IRC | 08:24 | |
| *** serlex has joined #heat | 08:25 | |
| *** yangyapeng has quit IRC | 08:27 | |
| *** gfidente has joined #heat | 08:36 | |
| *** yangyapeng has joined #heat | 08:38 | |
| *** hoonetorg has joined #heat | 08:42 | |
| openstackgerrit | Merged openstack/heat master: Updated from global requirements https://review.openstack.org/544212 | 08:45 |
| *** yangyape_ has joined #heat | 08:49 | |
| *** yangyapeng has quit IRC | 08:50 | |
| *** armaan has quit IRC | 09:00 | |
| *** armaan has joined #heat | 09:01 | |
| *** serlex has quit IRC | 09:03 | |
| *** shardy has joined #heat | 09:09 | |
| *** k_mouza has joined #heat | 09:11 | |
| *** derekh has joined #heat | 09:41 | |
| *** d0ugal_ has joined #heat | 10:31 | |
| *** d0ugal has quit IRC | 10:34 | |
| *** d0ugal_ has quit IRC | 10:50 | |
| *** gieldops has quit IRC | 10:50 | |
| *** gieldops has joined #heat | 10:51 | |
| *** d0ugal has joined #heat | 10:51 | |
| *** d0ugal has quit IRC | 10:51 | |
| *** d0ugal has joined #heat | 10:51 | |
| gieldops | Can I get some votes on my value_specs patch set? https://review.openstack.org/#/c/541788/ | 10:51 |
| gieldops | Please | 10:51 |
| *** mdnadeem has joined #heat | 10:56 | |
| *** gkadam has quit IRC | 11:06 | |
| *** gkadam has joined #heat | 11:07 | |
| *** gkadam has quit IRC | 11:12 | |
| *** gkadam has joined #heat | 11:12 | |
| *** gkadam has quit IRC | 11:18 | |
| *** armaan has quit IRC | 11:23 | |
| *** gkadam has joined #heat | 11:30 | |
| ramishra | gieldops: AFAIK, we don't encourage usage of value_specs, as it's random attributes sent to neutron. I did not get what problem you're trying to solve with the patch. | 11:39 |
| *** pbourke has quit IRC | 11:39 | |
| ramishra | If there is an api extension available for a new atrribute in neutron, it would be better to add a property to that specific resource | 11:40 |
| *** pbourke has joined #heat | 11:41 | |
| *** armaan has joined #heat | 11:42 | |
| *** k_mouza has quit IRC | 11:44 | |
| *** k_mouza has joined #heat | 11:45 | |
| *** k_mouza has quit IRC | 11:50 | |
| gieldops | ramishra, for vendors needing to use the value_specs property for a resource which doesn't have the extended property, it can be quite a problem if it isn't included | 11:51 |
| *** k_mouza has joined #heat | 11:51 | |
| gieldops | It's pretty stupid that some (seemingly random) resources have the property but others don't | 11:51 |
| ramishra | gieldops: No it's not stupid. I think It's there for some resources for a reason where we expect vendor specific properties may be required. what specific vendor property are you looking for and for what resource? | 11:53 |
| ramishra | There should be service/api extension in neutron for that | 11:54 |
| *** gkadam has quit IRC | 12:06 | |
| therve | ramishra, Security groups | 12:14 |
| gieldops | I made an extension to Neutron security groups where a security group contains an extra variable (statefulness). To add this property in Heat, we had to do some ugly code gymnastics | 12:15 |
| ramishra | therve: so there is an api extension for it in neutron? | 12:15 |
| therve | ramishra, All resources have api extensions | 12:15 |
| gieldops | My proposed patch set "solves" this for security groups, but also for all other Neutron resources, should there ever be another vendor wanting to add a custom property in, e.g., Trunk | 12:16 |
| ramishra | therve: not I know of, I mean if there is a new attribute/feature needed that's not in the basic api, an extension is added | 12:17 |
| ramishra | looks like it's a custom extension created by gieldops | 12:17 |
| gieldops | Yes it is | 12:17 |
| ramishra | gieldops: did u try to propose that to neutron? | 12:18 |
| gieldops | No, as it is vendor-specific | 12:19 |
| gieldops | We are however looking into adding it into Neutron, but that's not the main issue here. The main issue is that vendors might want to add customizations to the Neutron API but they won't be able call those custom API properties through Heat | 12:20 |
| ramishra | gieldops: I mean you can try to add the value-specs to security group if it's required, but I don't know how that would be useful for resources like AddressScope etc | 12:20 |
| ramishra | Some resources definitely don't need it | 12:21 |
| gieldops | ramishra, I understand, that was my initial plan :) but in the future, someone might want to use value specs in AddressScope, no? | 12:21 |
| *** gkadam has joined #heat | 12:22 | |
| ramishra | I can't think of anything like that | 12:22 |
| gieldops | ramishra, alright :) can you make a quick list of the resources which will never ever need value_specs? | 12:22 |
| gieldops | I will take them out then, if that's ok for you | 12:23 |
| ramishra | IMO you should add it to the resource you want to, we can look at other resources whenever there is a need | 12:23 |
| therve | https://docs.openstack.org/neutron/pike/contributor/internals/api_extensions.html#extensions-for-resources-with-standard-attributes is that the right list? | 12:25 |
| gieldops | ramishra, the release cycle is a bit slow for that imo :) | 12:26 |
| gieldops | therve, thanks! | 12:26 |
| gieldops | ramishra, I was thinking about future needs of vendors, it seems cumbersome to add value_specs to a resource each time it is needed | 12:26 |
| ramishra | therve: I normally check this https://github.com/openstack/neutron/tree/master/neutron/extensions | 12:30 |
| therve | Aren't those all resources? :) | 12:31 |
| ramishra | gieldops: there can be more than one extensions for a resource | 12:32 |
| therve | Eg address scope is in there | 12:32 |
| ramishra | some resources may not have | 12:32 |
| ramishra | AFAIK, adressscope itself is an extension | 12:32 |
| ramishra | therve: I mean as an when new attributes are added for a feature there can be new extensions for a resource, so AFAIK there is no 1-1 relationship | 12:34 |
| therve | ramishra, My point was that neutron seems to support extensions to all resources | 12:35 |
| gieldops | therve, indeed | 12:35 |
| ramishra | therve: yes, but that's not resource specific, but new features and apis | 12:36 |
| ramishra | tbh, what would be a vendor specific thing for AddressScope, Quota, SubnetPool? | 12:39 |
| *** dprince has joined #heat | 12:40 | |
| gieldops | I agree, for some resources, I can't think of any need for value_specs | 12:43 |
| gieldops | ramishra, but for others, there is definitely a chance some people might extend the Neutron API, e.g. security groups | 12:44 |
| *** bnemec-pto has quit IRC | 12:49 | |
| *** bnemec has joined #heat | 12:51 | |
| *** gfidente has quit IRC | 12:57 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Fix convergence unit tests for py36 https://review.openstack.org/546137 | 12:57 |
| *** gfidente has joined #heat | 12:58 | |
| *** gfidente has quit IRC | 12:58 | |
| *** gfidente has joined #heat | 12:58 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Fix convergence unit tests for py36 https://review.openstack.org/546137 | 12:59 |
| *** jcoufal has joined #heat | 13:28 | |
| *** skramaja has quit IRC | 13:32 | |
| *** k_mouza has quit IRC | 13:52 | |
| *** Smeared_Beard has joined #heat | 13:56 | |
| *** SmearedBeard has quit IRC | 13:57 | |
| *** jcoufal_ has joined #heat | 13:59 | |
| *** jcoufal has quit IRC | 14:01 | |
| openstackgerrit | Giel Dops proposed openstack/heat master: Add value_specs to all Neutron resources https://review.openstack.org/541788 | 14:01 |
| *** k_mouza has joined #heat | 14:01 | |
| *** sshnaidm|off is now known as sshnaidm | 14:05 | |
| openstackgerrit | Giel Dops proposed openstack/heat master: Add value_specs to all Neutron resources https://review.openstack.org/541788 | 14:08 |
| openstackgerrit | Giel Dops proposed openstack/heat master: Add value_specs to all Neutron resources https://review.openstack.org/541788 | 14:09 |
| openstackgerrit | Giel Dops proposed openstack/heat master: Add value_specs to all Neutron resources https://review.openstack.org/541788 | 14:12 |
| gieldops | Wow, made some stupid mistakes, I had to update my patch sets each time | 14:13 |
| gieldops | ramishra, therve, can you review my patch set again, please? https://review.openstack.org/#/c/541788 | 14:13 |
| *** links has quit IRC | 14:15 | |
| *** dbecker has quit IRC | 14:17 | |
| *** dbecker has joined #heat | 14:17 | |
| *** blomquisg_gone is now known as blomquisg | 14:38 | |
| *** k_mouza has quit IRC | 14:38 | |
| therve | zaneb, Got an env with the issue | 14:49 |
| zaneb | ah cool, was just about to ask if you'd made any progress | 14:52 |
| * zaneb has not | 14:52 | |
| *** hoonetorg has quit IRC | 14:54 | |
| therve | zaneb, So... What should I look for? :) | 14:57 |
| zaneb | good question! | 14:58 |
| zaneb | therve: lets start with the resource group's nested stack... see what its outputs actually are | 14:58 |
| zaneb | and what its template looks like | 14:59 |
| *** d0ugal has quit IRC | 14:59 | |
| *** d0ugal has joined #heat | 15:00 | |
| therve | zaneb, So hum. There is no stack because it's size 0 | 15:00 |
| zaneb | oh ho | 15:00 |
| zaneb | I didn't know we did that | 15:00 |
| zaneb | so that explains everything | 15:01 |
| therve | Ah :) | 15:01 |
| zaneb | http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/stack_resource.py#n620 | 15:01 |
| therve | Hum | 15:02 |
| therve | zaneb, It doesn't seem to be true all the time though | 15:02 |
| zaneb | it's never simple is it? | 15:02 |
| therve | Ohhh update_policy | 15:03 |
| *** k_mouza has joined #heat | 15:04 | |
| zaneb | ugh, more update_policy weirdness? | 15:04 |
| zaneb | I was hoping https://review.openstack.org/#/c/531926/ had fixed the last of it | 15:05 |
| *** ysandeep has quit IRC | 15:06 | |
| therve | zaneb, http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/heat/resource_group.py#n421 | 15:07 |
| therve | That's why we don't create it | 15:07 |
| therve | zaneb, http://paste.openstack.org/show/678653/ seems to work | 15:11 |
| *** k_mouza has quit IRC | 15:11 | |
| zaneb | that's definitely the simplest fix | 15:12 |
| zaneb | I wonder what else will break :) | 15:12 |
| therve | zaneb, So it doesn't fix the current state, but we assume it's incorrect right? | 15:12 |
| zaneb | sorry, I didn't follow that | 15:13 |
| therve | zaneb, Now that the outputs are stored, even if I make that fix, the state is broken | 15:14 |
| therve | IE that patch fixes a new deploy, but not the env I'm testing on | 15:15 |
| zaneb | in this case the value is frozen in the Value resource, so yeah, it will remain broken for any existing stacks deployed with the current code | 15:15 |
| zaneb | with the Value resource in there that'd be true of pretty much any fix | 15:16 |
| therve | True | 15:17 |
| therve | zaneb, http://paste.openstack.org/show/678675/ maybe that's a better fix | 15:18 |
| zaneb | therve: hmm, I suspect the reason we currently return None there is that we want attributes to be None during validation (when the nested stack hasn't been created yet). so yeah, maybe the second fix is better | 15:20 |
| openstackgerrit | Thomas Herve proposed openstack/heat master: Handle non-stored stack in resource group https://review.openstack.org/546179 | 15:23 |
| therve | God knows how long we've been non-storing those groups. Ugh :/ | 15:24 |
| *** hoonetorg has joined #heat | 15:25 | |
| therve | Still happy to find the issue. Too bad I missed that batch creation bug | 15:26 |
| *** armaan has quit IRC | 15:30 | |
| *** mdnadeem has quit IRC | 15:33 | |
| zaneb | probably since version='5.0.0' | 15:33 |
| *** d0ugal has quit IRC | 15:36 | |
| *** d0ugal has joined #heat | 15:39 | |
| *** d0ugal has quit IRC | 15:52 | |
| *** Guest72183 has quit IRC | 15:54 | |
| *** afazekas is now known as afazekas|air | 16:05 | |
| *** d0ugal has joined #heat | 16:06 | |
| *** blomquisg is now known as blomquisg_gone | 16:09 | |
| *** ramishra has quit IRC | 16:11 | |
| *** blomquisg_gone is now known as blomquisg | 16:12 | |
| *** k_mouza has joined #heat | 16:14 | |
| gieldops | ramishra, therve, sorry for bothering again. My patch set got +1 from Zuul, can you please review it whenever you're free? Thanks! https://review.openstack.org/#/c/541788 | 16:14 |
| *** hongbin has joined #heat | 16:14 | |
| *** links has joined #heat | 16:16 | |
| *** d0ugal has quit IRC | 16:17 | |
| openstackgerrit | Vadym Markov proposed openstack/heat master: Switch designate client to API v2 by default https://review.openstack.org/545885 | 16:17 |
| *** AlexeyAbashkin has quit IRC | 16:26 | |
| *** d0ugal has joined #heat | 16:34 | |
| *** yassine has joined #heat | 16:35 | |
| *** yassine is now known as Guest87022 | 16:35 | |
| *** k_mouza has quit IRC | 16:42 | |
| *** k_mouza has joined #heat | 16:42 | |
| *** k_mouza has quit IRC | 16:47 | |
| *** k_mouza has joined #heat | 16:57 | |
| *** k_mouza has joined #heat | 16:57 | |
| *** d0ugal has quit IRC | 16:59 | |
| *** d0ugal has joined #heat | 17:03 | |
| *** harlowja has joined #heat | 17:23 | |
| zaneb | therve: aha https://review.openstack.org/#/c/427822/ | 17:36 |
| *** links has quit IRC | 17:37 | |
| *** d0ugal has quit IRC | 17:38 | |
| *** derekh has quit IRC | 17:42 | |
| *** dprince has quit IRC | 17:47 | |
| *** jtomasek has quit IRC | 17:54 | |
| *** gfidente is now known as gfidente|afk | 17:55 | |
| *** AlexeyAbashkin has joined #heat | 17:57 | |
| *** d0ugal has joined #heat | 18:00 | |
| *** dprince has joined #heat | 18:01 | |
| *** AlexeyAbashkin has quit IRC | 18:02 | |
| openstackgerrit | Zane Bitter proposed openstack/heat master: Handle non-stored stack in resource group https://review.openstack.org/546179 | 18:03 |
| *** openstackgerrit has quit IRC | 18:03 | |
| *** k_mouza has quit IRC | 18:04 | |
| *** d0ugal has quit IRC | 18:05 | |
| *** d0ugal has joined #heat | 18:11 | |
| *** AlexeyAbashkin has joined #heat | 18:13 | |
| *** AlexeyAbashkin has quit IRC | 18:17 | |
| *** harlowja has quit IRC | 18:23 | |
| *** d0ugal has quit IRC | 18:38 | |
| *** d0ugal has joined #heat | 18:39 | |
| *** shardy has quit IRC | 18:43 | |
| *** d0ugal has quit IRC | 18:51 | |
| *** harlowja has joined #heat | 18:55 | |
| *** d0ugal_ has joined #heat | 18:56 | |
| *** felipemonteiro has joined #heat | 18:57 | |
| *** harlowja_ has joined #heat | 18:59 | |
| *** harlowja has quit IRC | 18:59 | |
| *** armaan has joined #heat | 19:11 | |
| *** felipemonteiro has quit IRC | 19:14 | |
| *** felipemonteiro has joined #heat | 19:28 | |
| *** d0ugal_ has quit IRC | 19:45 | |
| *** openstackgerrit has joined #heat | 19:54 | |
| openstackgerrit | Zane Bitter proposed openstack/heat master: Clarify resource deprecation process https://review.openstack.org/546290 | 19:54 |
| *** d0ugal_ has joined #heat | 19:56 | |
| openstackgerrit | Zane Bitter proposed openstack/heat master: Clarify resource deprecation process https://review.openstack.org/546290 | 19:57 |
| *** d0ugal_ has quit IRC | 20:03 | |
| *** d0ugal_ has joined #heat | 20:03 | |
| *** d0ugal_ has quit IRC | 20:10 | |
| *** d0ugal_ has joined #heat | 20:13 | |
| *** bnemec is now known as bnemec-pto | 20:19 | |
| *** AlexeyAbashkin has joined #heat | 20:23 | |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| *** d0ugal_ has quit IRC | 20:30 | |
| *** felipemonteiro_ has joined #heat | 20:53 | |
| *** stevebaker has quit IRC | 20:53 | |
| *** d0ugal_ has joined #heat | 20:56 | |
| *** gfidente|afk has quit IRC | 20:56 | |
| *** felipemonteiro has quit IRC | 20:56 | |
| *** dmellado has quit IRC | 20:58 | |
| *** felipemonteiro_ has quit IRC | 21:04 | |
| *** felipemonteiro has joined #heat | 21:05 | |
| zigo | https://review.openstack.org/#/c/546137/ <--- This one deserves a +2w | 21:05 |
| zigo | therve: ^ | 21:05 |
| *** felipemonteiro_ has joined #heat | 21:07 | |
| *** FL1SK has joined #heat | 21:08 | |
| *** dprince has quit IRC | 21:09 | |
| *** felipemonteiro has quit IRC | 21:09 | |
| *** armaan has quit IRC | 21:21 | |
| *** armaan has joined #heat | 21:21 | |
| *** AlexeyAbashkin has joined #heat | 21:23 | |
| *** AlexeyAbashkin has quit IRC | 21:27 | |
| *** armaan has quit IRC | 22:00 | |
| *** jcoufal_ has quit IRC | 22:02 | |
| *** d0ugal_ has quit IRC | 22:03 | |
| *** dmellado has joined #heat | 22:18 | |
| *** k_mouza has joined #heat | 22:28 | |
| openstackgerrit | Merged openstack/heat-tempest-plugin master: Updated from global requirements https://review.openstack.org/537048 | 22:32 |
| *** rcernin has joined #heat | 22:33 | |
| *** hoolio has joined #heat | 22:49 | |
| *** felipemonteiro_ has quit IRC | 22:57 | |
| *** stevebaker has joined #heat | 23:01 | |
| *** jmlowe has quit IRC | 23:01 | |
| *** Smeared_Beard has quit IRC | 23:02 | |
| *** openstackgerrit has quit IRC | 23:04 | |
| *** hoolio has quit IRC | 23:06 | |
| *** liusheng has quit IRC | 23:06 | |
| *** liusheng has joined #heat | 23:06 | |
| *** crose has joined #heat | 23:08 | |
| *** jmlowe has joined #heat | 23:19 | |
| *** blomquisg is now known as blomquisg_gone | 23:20 | |
| *** crose has quit IRC | 23:23 | |
| *** AlexeyAbashkin has joined #heat | 23:23 | |
| *** AlexeyAbashkin has quit IRC | 23:27 | |
| *** k_mouza has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!