| *** k_mouza has joined #heat | 00:14 | |
| *** inflatador has quit IRC | 00:17 | |
| *** k_mouza has quit IRC | 00:18 | |
| *** dopplergange has quit IRC | 00:59 | |
| *** dopplergange has joined #heat | 00:59 | |
| *** neatherweb has quit IRC | 01:59 | |
| *** neatherweb has joined #heat | 01:59 | |
| *** ramishra has joined #heat | 02:02 | |
| *** openstackgerrit has joined #heat | 02:05 | |
| openstackgerrit | Nafiz Haider proposed openstack/heat master: Add 'Extra_Properties' to OS::Glance::WebImage https://review.opendev.org/723063 | 02:05 |
|---|---|---|
| openstackgerrit | Nafiz Haider proposed openstack/heat master: Add 'Extra_Properties' to OS::Glance::WebImage https://review.opendev.org/723063 | 02:05 |
| openstackgerrit | Nafiz Haider proposed openstack/heat master: Add 'Extra_Properties' to OS::Glance::WebImage https://review.opendev.org/723063 | 02:06 |
| *** mikecmpbll has quit IRC | 02:51 | |
| *** jdandrea has quit IRC | 02:52 | |
| *** mikecmpbll has joined #heat | 02:54 | |
| *** neatherweb has quit IRC | 05:00 | |
| *** vishalmanchanda has joined #heat | 05:15 | |
| *** neatherweb has joined #heat | 05:16 | |
| *** k_mouza has joined #heat | 05:24 | |
| *** k_mouza has quit IRC | 05:28 | |
| *** mikecmpbll has quit IRC | 05:56 | |
| *** mikecmpbll has joined #heat | 05:58 | |
| openstackgerrit | Merged openstack/heat master: Check external resources after creation https://review.opendev.org/699543 | 06:39 |
| *** iokiwi has quit IRC | 07:00 | |
| *** iokiwi has joined #heat | 07:00 | |
| *** rcernin has quit IRC | 07:32 | |
| *** mikecmpbll has quit IRC | 08:01 | |
| *** mikecmpbll has joined #heat | 08:04 | |
| *** neatherweb has quit IRC | 08:12 | |
| *** k_mouza has joined #heat | 09:17 | |
| *** k_mouza has quit IRC | 09:52 | |
| *** k_mouza has joined #heat | 10:57 | |
| openstackgerrit | Akihiro Motoki proposed openstack/heat-dashboard stable/ussuri: Update hacking for Python3 https://review.opendev.org/724820 | 11:18 |
| *** tkajinam has quit IRC | 11:25 | |
| openstackgerrit | Merged openstack/heat-dashboard stable/ussuri: Use unittest.mock instead of third party mock https://review.opendev.org/723582 | 11:29 |
| *** k_mouza has quit IRC | 11:40 | |
| *** ramishra has quit IRC | 11:53 | |
| *** mikecmpbll has quit IRC | 12:07 | |
| *** k_mouza has joined #heat | 12:07 | |
| *** mikecmpbll has joined #heat | 12:09 | |
| *** neatherweb has joined #heat | 12:41 | |
| *** ramishra has joined #heat | 13:10 | |
| *** mailingsam has joined #heat | 13:28 | |
| mailingsam | Heat core developers, could you update this review: https://review.opendev.org/#/c/704630/ and let me know what are the next steps? | 13:28 |
| mailingsam | We can discuss in JIRA if further discussion is required | 13:28 |
| mailingsam | The review has been pending for 6 weeks | 13:28 |
| *** jdandrea has joined #heat | 13:30 | |
| *** jdandrea has quit IRC | 13:32 | |
| *** NafH has joined #heat | 13:35 | |
| openstackgerrit | Merged openstack/heat-agents stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/722945 | 13:46 |
| openstackgerrit | Merged openstack/heat-agents stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/722946 | 13:46 |
| *** jdandrea has joined #heat | 13:54 | |
| zaneb | mailingsam: to be fair, you could have implemented the existing feedback at any point during that | 13:57 |
| zaneb | reviews with a -1 on them don't tend to get a lot of attention | 13:57 |
| mailingsam | I need some more inputs | 13:57 |
| *** jmlowe has quit IRC | 13:57 | |
| mailingsam | I'll update the JIRA with the info I'm looking for | 13:57 |
| mailingsam | I need all the input before I make any more code change | 13:58 |
| mailingsam | will put in psedo code of what I plan to put in and then we can go off of that | 13:58 |
| mailingsam | unless if any more experience developer want to takeover the patchset and udpate the patchset | 13:58 |
| zaneb | you're aware that OpenStack doesn't use Jira right? | 13:58 |
| mailingsam | I mean the story board | 13:59 |
| mailingsam | at the moment I'm looking for any implementationo f active/deactive implementation, it need not be what I proposed | 13:59 |
| zaneb | ok. I replied to your questions just now, but the bottom line is that our feedback has been pretty consistent but you seem to be determined to do something different? | 14:00 |
| mailingsam | yes, I cannot make active = True by default, we need an option to opt out of active = True/False logic | 14:01 |
| *** jmlowe has joined #heat | 14:01 | |
| *** tkajinam has joined #heat | 14:01 | |
| zaneb | why? surely you either want it to be active or you don't? | 14:01 |
| zaneb | the existing default is that images are created active, so that has to be maintained or it breaks backward compatibility | 14:04 |
| mailingsam | The existing default is heat stack complete irrespective of glance image is active/in queue etc. | 14:05 |
| zaneb | no it isn't | 14:05 |
| *** inflatador has joined #heat | 14:05 | |
| mailingsam | Yes, please provide an invalid image URL or disconnect the network when you create heat stack, the image will be pending state but the stack creation completes | 14:06 |
| mailingsam | Let me recreate that and udpate the storyboard | 14:06 |
| zaneb | https://opendev.org/openstack/heat/src/branch/master/heat/engine/resources/openstack/glance/image.py#L182 | 14:06 |
| zaneb | the code is unambiguous. check_create_complete() doesn't return True until the image status is 'active' | 14:07 |
| openstackgerrit | Merged openstack/python-heatclient stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/719060 | 14:07 |
| zaneb | until it returns True the resource can't go CREATE_COMPLETE, and until the resource is complete the stack cannot complete | 14:08 |
| mailingsam | that's correct, so we need to make active = True | 14:09 |
| *** inflatador has quit IRC | 14:11 | |
| zaneb | right. so why are you saying that it completes if the state is still 'pending'? | 14:11 |
| mailingsam | Yes, I saw that issue in att/stein, let me check | 14:12 |
| mailingsam | stein branch | 14:12 |
| *** inflatador has joined #heat | 14:12 | |
| zaneb | looks the same to me https://opendev.org/openstack/heat/src/branch/stable/stein/heat/engine/resources/openstack/glance/image.py#L182 | 14:13 |
| *** jmlowe has quit IRC | 14:13 | |
| *** jmlowe has joined #heat | 14:14 | |
| mailingsam | You are correct | 14:16 |
| mailingsam | I'll set the active = True | 14:18 |
| mailingsam | checking your other comments | 14:18 |
| *** neatherweb has quit IRC | 14:24 | |
| mailingsam | zaneb I will check the other comment and let you know if any more questions | 14:57 |
| *** k_mouza has quit IRC | 15:04 | |
| *** k_mouza has joined #heat | 15:21 | |
| openstackgerrit | Merged openstack/heat-dashboard master: Update master for stable/ussuri https://review.opendev.org/722943 | 16:06 |
| openstackgerrit | Merged openstack/heat-dashboard master: Add Python3 victoria unit tests https://review.opendev.org/722944 | 16:06 |
| *** mikecmpbll has quit IRC | 16:12 | |
| *** k_mouza has quit IRC | 16:13 | |
| *** mikecmpbll has joined #heat | 16:15 | |
| *** tkajinam has quit IRC | 16:26 | |
| *** k_mouza has joined #heat | 16:31 | |
| *** inflatador_ has joined #heat | 17:03 | |
| *** inflatador has quit IRC | 17:05 | |
| *** inflatador_ is now known as inflatador | 17:05 | |
| *** gregwork has joined #heat | 17:11 | |
| *** vishalmanchanda has quit IRC | 17:14 | |
| *** k_mouza has quit IRC | 17:45 | |
| *** bnemec is now known as beekneemech | 18:11 | |
| *** mikecmpbll has quit IRC | 19:10 | |
| *** hjensas has quit IRC | 19:30 | |
| *** hjensas has joined #heat | 19:34 | |
| *** k_mouza has joined #heat | 21:48 | |
| *** k_mouza has quit IRC | 21:52 | |
| *** inflatador has quit IRC | 22:07 | |
| *** elod has quit IRC | 22:07 | |
| *** Roedy has quit IRC | 22:07 | |
| *** jmlowe has quit IRC | 22:07 | |
| *** dopplergange has quit IRC | 22:07 | |
| *** zaneb has quit IRC | 22:07 | |
| *** irclogbot_2 has quit IRC | 22:07 | |
| *** Hazelesque has quit IRC | 22:07 | |
| *** Hazelesque has joined #heat | 22:07 | |
| *** elod has joined #heat | 22:08 | |
| *** zaneb has joined #heat | 22:10 | |
| *** irclogbot_3 has joined #heat | 22:10 | |
| *** dopplergange has joined #heat | 22:10 | |
| *** Roedy has joined #heat | 22:11 | |
| *** NafH has quit IRC | 22:11 | |
| *** jmlowe has joined #heat | 22:12 | |
| *** k_mouza has joined #heat | 23:49 | |
| *** k_mouza has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!