| *** rcernin has quit IRC | 01:27 | |
| *** rcernin has joined #heat | 01:31 | |
| *** k_mouza has joined #heat | 02:07 | |
| *** k_mouza has quit IRC | 02:13 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Don't store signal_url for ec2 signaling https://review.opendev.org/733140 | 02:36 |
|---|---|---|
| *** rcernin has quit IRC | 02:37 | |
| *** inflatador has joined #heat | 02:53 | |
| *** k_mouza has joined #heat | 02:55 | |
| *** k_mouza has quit IRC | 03:00 | |
| *** rcernin has joined #heat | 03:37 | |
| *** inflatador has quit IRC | 03:43 | |
| *** udesale has joined #heat | 05:36 | |
| *** ricolin has joined #heat | 05:36 | |
| *** vishalmanchanda has joined #heat | 05:51 | |
| *** k_mouza has joined #heat | 06:58 | |
| ramishra | ricolin: https://review.opendev.org/#/c/733140/ seems to work fine.. May be we can review/merge it | 07:00 |
| ramishra | if the gate 'God' is kind:) Weird nova build errors.. | 07:00 |
| ricolin | ramishra, got it:) | 07:01 |
| *** k_mouza has quit IRC | 07:03 | |
| *** ttsiouts has joined #heat | 07:12 | |
| *** rcernin has quit IRC | 07:15 | |
| *** rcernin has joined #heat | 07:21 | |
| *** k_mouza has joined #heat | 07:30 | |
| openstackgerrit | Andreas Jaeger proposed openstack/heat-specs master: Cleanup docs building https://review.opendev.org/733464 | 07:35 |
| *** rcernin has quit IRC | 07:41 | |
| openstackgerrit | Andreas Jaeger proposed openstack/heat-specs master: Cleanup docs building https://review.opendev.org/733464 | 07:42 |
| *** ttsiouts has quit IRC | 07:46 | |
| *** ttsiouts has joined #heat | 07:47 | |
| *** jawad_axd has joined #heat | 07:48 | |
| *** jmlowe has quit IRC | 07:54 | |
| *** jmlowe has joined #heat | 07:56 | |
| *** ttsiouts has quit IRC | 08:00 | |
| openstackgerrit | Andreas Jaeger proposed openstack/heat-specs master: Cleanup docs building https://review.opendev.org/733464 | 08:01 |
| *** ttsiouts has joined #heat | 08:11 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat stable/queens: Don't store signal_url for ec2 signaling https://review.opendev.org/733476 | 08:13 |
| openstackgerrit | Andreas Jaeger proposed openstack/heat-specs master: Cleanup docs building https://review.opendev.org/733464 | 08:16 |
| *** gfidente has joined #heat | 08:36 | |
| *** tkajinam has quit IRC | 08:48 | |
| *** k_mouza has quit IRC | 09:37 | |
| *** ricolin has quit IRC | 09:39 | |
| *** udesale has quit IRC | 09:39 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat stable/queens: Don't store signal_url for ec2 signaling https://review.opendev.org/733476 | 09:43 |
| *** udesale has joined #heat | 09:49 | |
| *** k_mouza has joined #heat | 10:17 | |
| *** k_mouza has quit IRC | 10:22 | |
| openstackgerrit | Hervé Beraud proposed openstack/heat master: Always reset conf.CONF when starting the wsgi app https://review.opendev.org/733524 | 10:29 |
| openstackgerrit | Hervé Beraud proposed openstack/heat master: Always reset CONF when starting the wsgi app https://review.opendev.org/733524 | 10:30 |
| *** ttsiouts has quit IRC | 11:05 | |
| *** udesale_ has joined #heat | 11:08 | |
| *** udesale has quit IRC | 11:11 | |
| *** ravsingh has joined #heat | 11:21 | |
| *** ricolin has joined #heat | 11:36 | |
| *** hjensas|afk is now known as hjensas | 11:57 | |
| *** dmellado_ has joined #heat | 12:35 | |
| *** zzzeek has quit IRC | 12:36 | |
| *** dmellado has quit IRC | 12:36 | |
| *** udesale_ has quit IRC | 12:36 | |
| *** zigo has quit IRC | 12:36 | |
| *** elod has quit IRC | 12:36 | |
| *** elod_ has joined #heat | 12:37 | |
| *** dmellado_ is now known as dmellado | 12:37 | |
| *** zzzeek has joined #heat | 12:38 | |
| *** zigo_ has joined #heat | 12:44 | |
| *** k_mouza has joined #heat | 12:56 | |
| *** ricolin has quit IRC | 12:59 | |
| *** ricolin_ has joined #heat | 12:59 | |
| *** ricolin_ is now known as ricolin | 13:01 | |
| *** tkajinam has joined #heat | 13:02 | |
| *** k_mouza has quit IRC | 13:11 | |
| *** k_mouza has joined #heat | 13:11 | |
| *** elod_ is now known as elod | 13:17 | |
| *** iokiwi3 has joined #heat | 13:37 | |
| *** iokiwi has quit IRC | 13:37 | |
| *** iokiwi3 is now known as iokiwi | 13:39 | |
| *** iokiwi3 has joined #heat | 13:40 | |
| *** k_mouza has quit IRC | 14:09 | |
| *** ricolin_ has joined #heat | 14:27 | |
| *** ricolin has quit IRC | 14:28 | |
| *** ricolin_ has quit IRC | 14:28 | |
| *** ricolin has joined #heat | 14:28 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Don't store signal_url for ec2 signaling https://review.opendev.org/733140 | 14:30 |
| *** k_mouza has joined #heat | 14:40 | |
| zaneb | ramishra: I think those changes to the second test might be covering up a real issue | 14:49 |
| *** jawad_axd has quit IRC | 14:52 | |
| *** jawad_axd has joined #heat | 14:54 | |
| ramishra | zaneb: Do you see an issue if the aws waitcondition replaced during every update? due to https://github.com/openstack/heat/blob/master/heat/engine/resources/aws/cfn/wait_condition_handle.py#L40 | 15:00 |
| ramishra | I thought it should be ok as the signal url would have expired anyway | 15:01 |
| zaneb | if the WaitCondition gets replaced then the stack won't be able to continue, will it? | 15:02 |
| ramishra | oh you mean the server would be replaced etc? | 15:05 |
| zaneb | I mean the WaitCondition would be replaced and then just wait forever since nothing will be expecting to signal it? | 15:06 |
| ramishra | OK, I also see the same issue with not using a timestamp too for existing stacks | 15:08 |
| ramishra | but for new stacks it would be fine | 15:09 |
| zaneb | yeah | 15:09 |
| ramishra | too late for me even think about options.. If you've any good idea/solution feel free to help update the patch | 15:11 |
| zaneb | what if we make the 'handle' property of a WaitCondition update_allowed, and override needs_replace_with_prop_diff() so that it replaces only if the handle URL points to a different WaitConditionHandle resource | 15:11 |
| zaneb | hmmm, but we can only check the name... no way to know if the Handle itself has been replaced | 15:11 |
| zaneb | just removing the timestamp from new urls is starting to look more attractive... | 15:13 |
| ramishra | but it would have the same issue with existing stacks right? | 15:14 |
| zaneb | not if we continue to read from resource_data for existing resources | 15:14 |
| ramishra | but new keystone would reject those..no? | 15:15 |
| zaneb | if there's no timestamp in the URL they accept everything | 15:16 |
| ramishra | yeah, I mean if you read frm resource_data ..unless you migrate those stored urls to something without timestamp | 15:17 |
| zaneb | ah right | 15:18 |
| zaneb | do we need different approaches for different resource types? | 15:19 |
| zaneb | WaitConditions are usually one-shot things | 15:19 |
| zaneb | we just want them not to change on update | 15:19 |
| zaneb | maybe software deployments are different and we could generate new timestamps there? | 15:19 |
| ramishra | software deployments work fine.. I tested them with TripleO | 15:20 |
| ramishra | and it worked like charm | 15:20 |
| ramishra | TripeO does not use WC, so I did not encounter this issue:) | 15:21 |
| zaneb | so maybe the caching belongs in the WCHBase resource and not in SignalHandler | 15:21 |
| ramishra | I was thinking about UpdateWaitConditionHandle https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/wait_condition_handle.py#L223 | 15:25 |
| ramishra | its derived from the AWS one | 15:25 |
| ramishra | but I think it would be fine | 15:25 |
| ramishra | as it's replaced in every update | 15:26 |
| ramishra | I would probably do the caching only for https://github.com/openstack/heat/blob/master/heat/engine/resources/aws/cfn/wait_condition_handle.py ? | 15:27 |
| zaneb | https://opendev.org/openstack/heat/src/branch/master/heat/engine/resources/wait_condition.py#L25 | 15:33 |
| zaneb | there is also OS::Heat::WaitCondition, so I think it should be in BaseWaitConditionHandle | 15:33 |
| *** tkajinam has quit IRC | 16:05 | |
| *** gfidente is now known as gfidente|afk | 16:15 | |
| ramishra | zaneb: sorry was away for dinner..but for native WaitConditionHandle resource_id won't change https://github.com/openstack/heat/blob/master/heat/engine/resources/wait_condition.py#L45 | 16:35 |
| ramishra | but I can move it to BaseWaitConditionHandle if you want | 16:36 |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Don't store signal_url for ec2 signaling of deployments https://review.opendev.org/733140 | 16:38 |
| ramishra | zaneb: ^^ | 16:38 |
| *** ravsingh has quit IRC | 16:49 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Don't store signal_url for ec2 signaling of deployments https://review.opendev.org/733140 | 17:38 |
| *** jawad_axd has quit IRC | 17:57 | |
| *** ricolin has quit IRC | 18:06 | |
| *** vishalmanchanda has quit IRC | 19:11 | |
| *** k_mouza has quit IRC | 20:38 | |
| *** k_mouza has joined #heat | 20:40 | |
| *** k_mouza has quit IRC | 20:51 | |
| *** k_mouza has joined #heat | 21:05 | |
| *** k_mouza has quit IRC | 21:06 | |
| *** pas-ha has quit IRC | 22:36 | |
| *** simondodsley has quit IRC | 22:36 | |
| *** mnaser has quit IRC | 22:36 | |
| *** _erlon_ has quit IRC | 22:36 | |
| *** NobodyCam has quit IRC | 22:36 | |
| *** gregwork has quit IRC | 22:36 | |
| *** mwhahaha has quit IRC | 22:37 | |
| *** lxkong has quit IRC | 22:37 | |
| *** andrein has quit IRC | 22:37 | |
| *** NobodyCam has joined #heat | 22:37 | |
| *** pas-ha has joined #heat | 22:37 | |
| *** jrosser has quit IRC | 22:37 | |
| *** johnsom has quit IRC | 22:37 | |
| *** gmann has quit IRC | 22:37 | |
| *** gregwork has joined #heat | 22:38 | |
| *** gmann has joined #heat | 22:38 | |
| *** lxkong has joined #heat | 22:39 | |
| *** _erlon_ has joined #heat | 22:39 | |
| *** andrein has joined #heat | 22:40 | |
| *** jrosser has joined #heat | 22:41 | |
| *** mnaser has joined #heat | 22:41 | |
| *** mwhahaha has joined #heat | 22:41 | |
| *** johnsom has joined #heat | 22:43 | |
| *** simondodsley has joined #heat | 22:43 | |
| *** rcernin has joined #heat | 22:48 | |
| *** tkajinam has joined #heat | 22:56 | |
| *** rcernin has quit IRC | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!