| *** terdei has quit IRC | 00:02 | |
| *** terdei has joined #heat | 00:03 | |
| *** ayoung has quit IRC | 00:43 | |
| *** ayoung has joined #heat | 00:46 | |
| *** rcernin_ has joined #heat | 00:46 | |
| *** rcernin has quit IRC | 00:47 | |
| *** ayoung has quit IRC | 01:29 | |
| *** ayoung has joined #heat | 01:30 | |
| *** ayoung has quit IRC | 01:34 | |
| *** ramishra has quit IRC | 02:46 | |
| *** ramishra has joined #heat | 02:46 | |
| *** rcernin_ has quit IRC | 03:19 | |
| *** rcernin_ has joined #heat | 03:35 | |
| *** zaneb has quit IRC | 04:12 | |
| *** zaneb has joined #heat | 04:12 | |
| *** apetrich has joined #heat | 04:36 | |
| *** apetrich has quit IRC | 04:41 | |
| *** vishalmanchanda has joined #heat | 04:55 | |
| *** hjensas has joined #heat | 05:39 | |
| *** simondodsley_ has joined #heat | 06:02 | |
| *** simondodsley has quit IRC | 06:02 | |
| *** simondodsley_ is now known as simondodsley | 06:02 | |
| *** apetrich has joined #heat | 06:41 | |
| *** rcernin_ has quit IRC | 06:51 | |
| *** rcernin_ has joined #heat | 06:55 | |
| *** jtomasek has joined #heat | 07:00 | |
| *** rcernin_ has quit IRC | 07:35 | |
| *** tosky has joined #heat | 07:38 | |
| *** gfidente has joined #heat | 08:00 | |
| *** rcernin_ has joined #heat | 08:40 | |
| *** rcernin_ has quit IRC | 08:46 | |
| *** zzzeek has quit IRC | 09:32 | |
| *** zzzeek has joined #heat | 09:33 | |
| *** zzzeek has quit IRC | 09:48 | |
| *** zzzeek has joined #heat | 09:49 | |
| *** zzzeek has quit IRC | 10:08 | |
| *** zzzeek has joined #heat | 10:10 | |
| *** mikecmpbll has joined #heat | 10:13 | |
| *** k_mouza has joined #heat | 10:32 | |
| *** zzzeek has quit IRC | 10:57 | |
| *** zzzeek has joined #heat | 11:00 | |
| *** hjensas has quit IRC | 11:06 | |
| *** hjensas has joined #heat | 11:07 | |
| *** k_mouza has quit IRC | 11:09 | |
| *** elod has quit IRC | 11:15 | |
| *** elod has joined #heat | 11:16 | |
| *** k_mouza has joined #heat | 11:30 | |
| *** k_mouza has quit IRC | 11:31 | |
| *** k_mouza has joined #heat | 11:32 | |
| *** k_mouza has quit IRC | 11:34 | |
| ricolin | o/ | 13:09 |
|---|---|---|
| *** cliffparsons has joined #heat | 13:37 | |
| cloudnull | hey all can we get a couple reviews on https://review.opendev.org/#/c/725646/ | 15:18 |
| dpeacock | Hey folks - is there any way I can get https://review.opendev.org/#/c/725646/ merged? | 15:18 |
| cloudnull | haha! | 15:18 |
| dpeacock | ricolin ^^ ? | 15:23 |
| pas-ha | -1ed :-) | 15:27 |
| pas-ha | IMO better solution would be to just copy-paste the deleted function and couple of imports to heat-horizon plugin. Just removing constraint visual feedback will make the UX worse, even if just a bit | 15:28 |
| cloudnull | dpeacock ^ | 15:30 |
| dpeacock | That doesn't make any sense. | 15:30 |
| *** tosky has quit IRC | 15:31 | |
| dpeacock | pas-ha: image_field_data was removed in https://opendev.org/openstack/horizon/commit/26eebd4abbbabc1475bae61c51d1cfcf14dba770 | 15:32 |
| dpeacock | Horizon itself no longer recognizes this. | 15:32 |
| pas-ha | It is just a function that formats results if other function which is still in place afaiu. You can copy that removed function to heat plugin code with very minimal changes | 15:35 |
| pas-ha | And use it, still providing the same ux | 15:35 |
| pas-ha | Why it was removed with comment "not used in horizon or any plugin" while it is used in heat plugin is a different story | 15:37 |
| pas-ha | If you can wait I'll make a patch in an hour or so | 15:38 |
| *** gfidente has quit IRC | 15:43 | |
| dpeacock | pas-ha: ok if you think that makes better sense | 16:03 |
| dpeacock | Basically if you use a custom constraint like: | 16:03 |
| dpeacock | user_image: | 16:03 |
| dpeacock | type: string | 16:03 |
| dpeacock | label: user_image | 16:03 |
| dpeacock | description: "Required VM image" | 16:03 |
| dpeacock | constraints: | 16:03 |
| dpeacock | - custom_constraint: glance.image | 16:04 |
| pas-ha | yeah, I know | 16:04 |
| dpeacock | this works in Heat CLI, but does not work in Horizon | 16:04 |
| dpeacock | This is because Horizon no longer touches this. | 16:04 |
| dpeacock | I'm not sure of the value of working around a Horizon feature removal? | 16:04 |
| dpeacock | Isn't it better to just drop the code that's no longer relevant? | 16:04 |
| dpeacock | Or am I missing a piece of this puzzle? | 16:05 |
| pas-ha | not sure this particular function is a "feature", it most certainly is implemented now somehow differently - the actual choice of images available to be used. This makes sense for heat dashboard too. | 16:07 |
| pas-ha | btw, sahara-dashboard has done the same for those couple of methods they needed and which were also deleted | 16:12 |
| *** openstackgerrit has joined #heat | 16:13 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat-dashboard master: Move image_field_data method in-tree https://review.opendev.org/749546 | 16:13 |
| dpeacock | ok cool - thank you for the insight | 16:13 |
| pas-ha | dpeacock: ^^ | 16:14 |
| dpeacock | yeah - perfect - thank you for your help | 16:14 |
| *** mikecmpbll has quit IRC | 16:50 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/heat-dashboard master: Move image_field_data method in-tree https://review.opendev.org/749546 | 17:01 |
| *** ayoung has joined #heat | 17:37 | |
| *** mikecmpbll has joined #heat | 18:30 | |
| *** mikecmpbll has quit IRC | 18:31 | |
| *** k_mouza has joined #heat | 18:32 | |
| *** k_mouza has quit IRC | 18:36 | |
| openstackgerrit | Merged openstack/heat-dashboard master: [goal] Migrate testing to ubuntu focal https://review.opendev.org/744068 | 18:41 |
| *** vishalmanchanda has quit IRC | 18:43 | |
| *** zzzeek has quit IRC | 19:17 | |
| *** zzzeek has joined #heat | 19:18 | |
| *** zzzeek has quit IRC | 19:25 | |
| *** zzzeek has joined #heat | 19:27 | |
| *** zzzeek has quit IRC | 19:53 | |
| *** zzzeek has joined #heat | 19:56 | |
| *** apetrich has quit IRC | 20:07 | |
| *** jtomasek has quit IRC | 20:42 | |
| *** zzzeek has quit IRC | 20:50 | |
| *** zzzeek has joined #heat | 20:51 | |
| *** rcernin_ has joined #heat | 21:07 | |
| *** rcernin_ has quit IRC | 21:12 | |
| *** k_mouza has joined #heat | 21:12 | |
| *** k_mouza has quit IRC | 21:21 | |
| *** k_mouza has joined #heat | 21:27 | |
| *** k_mouza has quit IRC | 21:31 | |
| *** nsmeds has quit IRC | 21:59 | |
| *** k_mouza has joined #heat | 22:06 | |
| *** k_mouza has quit IRC | 22:11 | |
| *** rcernin_ has joined #heat | 22:16 | |
| *** k_mouza has joined #heat | 22:41 | |
| *** k_mouza has quit IRC | 22:47 | |
| *** rcernin_ has quit IRC | 23:04 | |
| *** rcernin has joined #heat | 23:04 | |
| *** hjensas has quit IRC | 23:11 | |
| *** k_mouza has joined #heat | 23:19 | |
| *** k_mouza has quit IRC | 23:24 | |
| *** lifeless has quit IRC | 23:29 | |
| *** irclogbot_2 has quit IRC | 23:29 | |
| *** irclogbot_3 has joined #heat | 23:32 | |
| *** k_mouza has joined #heat | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!