| *** tosky has quit IRC | 00:18 | |
| *** k_mouza has joined #heat | 02:05 | |
| *** k_mouza has quit IRC | 02:09 | |
| *** rcernin has quit IRC | 03:22 | |
| *** rcernin has joined #heat | 03:23 | |
| *** gmoro_ has quit IRC | 04:07 | |
| *** ayoung has quit IRC | 04:32 | |
| *** tkajinam has quit IRC | 04:40 | |
| *** tkajinam has joined #heat | 04:40 | |
| *** zzzeek has quit IRC | 05:01 | |
| *** zzzeek has joined #heat | 05:07 | |
| *** zzzeek has quit IRC | 05:37 | |
| *** zzzeek has joined #heat | 05:39 | |
| *** zzzeek has quit IRC | 05:47 | |
| *** zzzeek has joined #heat | 05:51 | |
| *** zzzeek has quit IRC | 05:55 | |
| *** zzzeek has joined #heat | 05:58 | |
| *** zzzeek has quit IRC | 06:12 | |
| *** zzzeek has joined #heat | 06:14 | |
| *** zzzeek has quit IRC | 06:35 | |
| *** k_mouza has joined #heat | 06:36 | |
| *** zzzeek has joined #heat | 06:38 | |
| *** k_mouza has quit IRC | 06:41 | |
| *** rcernin has quit IRC | 06:55 | |
| *** rcernin has joined #heat | 07:04 | |
| *** zzzeek has quit IRC | 07:51 | |
| *** rcernin has quit IRC | 07:53 | |
| *** zzzeek has joined #heat | 07:53 | |
| *** zzzeek has quit IRC | 08:17 | |
| *** zzzeek has joined #heat | 08:18 | |
| *** zzzeek has quit IRC | 09:02 | |
| *** zzzeek has joined #heat | 09:05 | |
| *** gfidente|afk is now known as gfidente | 09:14 | |
| *** rcernin has joined #heat | 09:33 | |
| *** k_mouza has joined #heat | 09:37 | |
| *** rcernin has quit IRC | 09:49 | |
| *** tosky has joined #heat | 09:57 | |
| *** openstackgerrit has quit IRC | 10:25 | |
| *** k_mouza has quit IRC | 10:43 | |
| *** k_mouza has joined #heat | 10:44 | |
| *** rcernin has joined #heat | 10:51 | |
| *** rcernin has quit IRC | 10:56 | |
| *** k_mouza has quit IRC | 11:41 | |
| *** gmoro_ has joined #heat | 11:42 | |
| *** k_mouza has joined #heat | 11:43 | |
| *** k_mouza has quit IRC | 11:45 | |
| *** k_mouza has joined #heat | 11:45 | |
| *** k_mouza has quit IRC | 12:11 | |
| *** zzzeek has quit IRC | 12:22 | |
| *** zzzeek has joined #heat | 12:24 | |
| *** k_mouza has joined #heat | 12:40 | |
| *** happyhemant has joined #heat | 12:47 | |
| -openstackstatus- NOTICE: The Gerrit service at review.opendev.org will be offline starting at 15:00 UTC (roughly two hours from now) for a weekend upgrade maintenance: http://lists.opendev.org/pipermail/service-announce/2020-October/000012.html | 13:01 | |
| *** zzzeek has quit IRC | 13:13 | |
| *** zzzeek has joined #heat | 13:17 | |
| *** zzzeek has quit IRC | 13:56 | |
| *** zzzeek has joined #heat | 13:57 | |
| -openstackstatus- NOTICE: The Gerrit service at review.opendev.org will be offline starting at 15:00 UTC (roughly one hour from now) for a weekend upgrade maintenance: http://lists.opendev.org/pipermail/service-announce/2020-October/000012.html | 13:59 | |
| *** k_mouza has quit IRC | 14:14 | |
| *** zzzeek has quit IRC | 14:17 | |
| *** zzzeek has joined #heat | 14:17 | |
| *** zzzeek has quit IRC | 14:40 | |
| *** zzzeek has joined #heat | 14:43 | |
| *** NafH has joined #heat | 14:44 | |
| -openstackstatus- NOTICE: The Gerrit service at review.opendev.org is offline for a weekend upgrade maintenance, updates will be provided once it's available again: http://lists.opendev.org/pipermail/service-announce/2020-October/000012.html | 15:02 | |
| *** k_mouza has joined #heat | 15:23 | |
| *** jobewan has quit IRC | 15:25 | |
| *** k_mouza has quit IRC | 15:27 | |
| *** k_mouza_ has joined #heat | 15:27 | |
| cloudnull | zaneb you around today by chance? | 15:40 |
|---|---|---|
| zaneb | cloudnull: o/ | 15:40 |
| cloudnull | apetrich dpeacock and I were looking into https://bugzilla.redhat.com/show_bug.cgi?id=1802602 and think we could do with some historical context | 15:40 |
| openstack | bugzilla.redhat.com bug 1802602 in openstack-heat "[RFE] Add REBUILD option to user_data_update_policy property of OS::Nova::Server" [Unspecified,On_dev] - Assigned to apetrich | 15:40 |
| cloudnull | idk if you are up to it, or anyone here in the heat channel - but we're all chatting on meet - https://meet.google.com/ocp-fyyb-hdz - happy to have you (or anyone from the community) join us | 15:41 |
| apetrich | in short adding a REPLACE option here You16:19 | 15:43 |
| apetrich | https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server.py#L548 | 15:43 |
| apetrich | but that is only used in this method https://meet.google.com/linkredirect?authuser=1&dest=https%3A%2F%2Fgithub.com%2Fopenstack%2Fheat%2Fblob%2Fmaster%2Fheat%2Fengine%2Fresources%2Fopenstack%2Fnova%2Fserver.py%23L1345 | 15:43 |
| apetrich | I mean here https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server.py#L1345 | 15:43 |
| apetrich | that needs_replace_with_prop_diff I don't see it being used in anywhere in openstack https://codesearch.opendev.org/?q=needs_replace_with_prop_diff&i=nope&files=&excludeFiles=&repos= | 15:44 |
| apetrich | no idea on what does it do or that is some leftover code | 15:45 |
| apetrich | So I don't see if adding REPLACE there does anything | 15:46 |
| apetrich | last time that was modified was when it was added 5 years ago and that patch does the same that I plan to do https://github.com/openstack/heat/commit/d4188127a14686f6d9844180b977cf5fa05aa024 | 15:47 |
| *** ekultails has joined #heat | 16:01 | |
| *** happyhemant has quit IRC | 16:27 | |
| *** k_mouza_ has quit IRC | 16:40 | |
| *** k_mouza has joined #heat | 16:51 | |
| *** tosky has quit IRC | 16:56 | |
| *** gfidente has quit IRC | 17:11 | |
| NobodyCam | Good Morning heat folks, I ran a stack cancel but forgot --no-roleback, is there a way to cancel the rollback? | 17:31 |
| NobodyCam | s/role/roll/ | 17:32 |
| *** k_mouza has quit IRC | 17:32 | |
| *** k_mouza has joined #heat | 17:38 | |
| *** k_mouza has quit IRC | 17:39 | |
| *** k_mouza has joined #heat | 17:45 | |
| *** tosky has joined #heat | 18:10 | |
| *** k_mouza has quit IRC | 18:20 | |
| *** k_mouza has joined #heat | 18:23 | |
| *** zzzeek has quit IRC | 18:52 | |
| *** zzzeek has joined #heat | 18:53 | |
| *** zzzeek has quit IRC | 19:00 | |
| *** zzzeek has joined #heat | 19:03 | |
| *** k_mouza has quit IRC | 19:12 | |
| *** tosky has quit IRC | 19:13 | |
| *** ekultails has quit IRC | 19:53 | |
| *** ekultails has joined #heat | 20:09 | |
| *** ekultails has quit IRC | 20:26 | |
| *** ekultails has joined #heat | 20:41 | |
| zaneb | NobodyCam: no | 20:55 |
| zaneb | cloudnull: sorry, got distracted and missed that whole conversation | 20:58 |
| zaneb | apetrich: we do a rebuild e.g. when the image changes https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server.py#L1275-L1296 so you would need to do the same when the user data changes | 20:59 |
| zaneb | currently the handle_update() code assumes that the user data update policy is always IGNORE (if it were REPLACE then handle_update() would never be called when the user data changes due to the code you linked in needs_replace_with_prop_diff()) | 21:01 |
| *** k_mouza has joined #heat | 21:13 | |
| *** k_mouza has quit IRC | 21:18 | |
| NobodyCam | zaneb: Thank you :) | 21:28 |
| zaneb | apetrich: actually, I'm confused about your question. REPLACE has always been available, and is still the default. it's checked in needs_replace_with_prop_diff(), which you can see being called in the first result of your code search. The bug is about implementing a REBUILD option. | 21:34 |
| apetrich | zaneb, yeah that is the only place called but what I'm unsure is where the rebuild does different | 21:37 |
| apetrich | sorry that I formulated it wrongly I condensed a bit of discussion in a few lines | 21:38 |
| zaneb | for a rebuild you'll need to implement code to handle it in handle_update(), similar to what I linked above | 21:38 |
| apetrich | but the clue in https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server.py#L1275-L1296 is what I was looking for and not understanding | 21:39 |
| apetrich | thank you zaneb | 21:39 |
| zaneb | to be clear, rebuild is a thing you call in the Nova API. replace is a thing that happens entirely in Heat (we just create a new resource instead of trying to update the existing one) | 21:40 |
| apetrich | yeah. the rebuild needs some wrangling that is already implemented in nova from what I understand from the bz | 21:41 |
| apetrich | sorry. | 21:41 |
| zaneb | rebuilding wasn't originally a thing in Nova, which is why it didn't always work like this | 21:41 |
| zaneb | rebuild is effectively like a resize without changing the size | 21:42 |
| zaneb | but it's been there for years now. there is a non-trivial amount of orchestration handling required for it though, as you can see from the image update code | 21:43 |
| apetrich | It is very late here. yeah | 21:43 |
| zaneb | np, sorry for the delayed response | 21:44 |
| apetrich | No worries. It helped me a lot! | 21:44 |
| *** NafH has quit IRC | 23:07 | |
| *** ekultails has quit IRC | 23:35 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!