| *** apetrich_ <apetrich_!~apetrich@79.140.121.170> has joined #heat | 02:07 | |
| *** apetrich_things_keep_breaking <apetrich_things_keep_breaking!~apetrich@212.86.48.59> has quit IRC (Ping timeout: 480 seconds) | 02:14 | |
| bshephar | Hey ricolin. When you have some time, would I be able to get a second review on: https://review.opendev.org/c/openstack/heat/+/795023 | 03:32 |
|---|---|---|
| *** ysandeep <ysandeep!~sandy@202.173.126.67> has joined #heat | 05:12 | |
| *** ysandeep is now known as ysandeep_ | 05:26 | |
| *** ysandeep <ysandeep!~ysandeep@125.16.200.50> has joined #heat | 05:34 | |
| *** ysandeep_ <ysandeep_!~sandy@202.173.126.67> has quit IRC (Quit: Leaving) | 05:35 | |
| opendevreview | Brendan Shephard proposed openstack/heat master: Remove unused and broken tests https://review.opendev.org/c/openstack/heat/+/796233 | 05:57 |
| *** ysandeep is now known as ysandeep|afk | 06:54 | |
| *** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has quit IRC (Quit: Leaving) | 07:16 | |
| *** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has joined #heat | 07:17 | |
| *** tosky <tosky!~luigi@dynamic-adsl-78-13-253-141.clienti.tiscali.it> has joined #heat | 07:45 | |
| *** ysandeep|afk is now known as ysandeep | 08:41 | |
| *** ramishra <ramishra!~rabi@49.37.41.194> has quit IRC (Quit: leaving) | 10:08 | |
| *** ramishra <ramishra!~rabi@49.37.41.194> has joined #heat | 10:08 | |
| *** ysandeep is now known as ysandeep|afk | 10:58 | |
| *** ysandeep|afk is now known as ysandeep | 11:56 | |
| *** zaneb <zaneb!~zaneb@0001a018.user.oftc.net> has joined #heat | 13:40 | |
| *** zaneb <zaneb!~zaneb@0001a018.user.oftc.net> has quit IRC (Remote host closed the connection) | 13:41 | |
| *** zaneb <zaneb!~zaneb@2600:6c5e:517f:c213:6bc0:43cc:3007:2960> has joined #heat | 13:41 | |
| *** ysandeep is now known as ysandeep|brb | 13:53 | |
| bshephar | zaneb: Hey mate. Re. removing that functional test. Are you saying you would prefer it existed and we fixed it instead? I spoke with ramishra today, he mentioned it had been broken for a while and we decided it might be better just to remove it rather than re-write it. | 14:24 |
| zaneb | bshephar: to my mind the test documents a thing that ought to work | 14:24 |
| zaneb | if we have reason that we've decided that thing ought not to work anymore, then we should delete it | 14:25 |
| zaneb | but deleting it just because it's failing seems like... just giving up? | 14:25 |
| bshephar | zaneb: Sure man. I can keep looking into it if we feel it has value. The ACCESS_REFUSED thing doesn't seem to be a problem now. I made it passed that, but it was getting stuck on the test somewhere else. | 14:26 |
| zaneb | (the -1 was for cleaning up the skip list btw) | 14:26 |
| bshephar | Yeah, completely understand. tbh, I didn't know the skip list existed, but I can see where it's mentioned there now. | 14:27 |
| bshephar | No complaints from me. Just wanted to clarify your position on it. | 14:27 |
| zaneb | I believe there's 2 places as well https://review.opendev.org/c/openstack/heat/+/589531 | 14:27 |
| zaneb | I'd like to know what broke. if it's just that the whole telemetry project is unusable nowadays then fine, delete it | 14:29 |
| bshephar | Noted. But I'll stick with trying to fix it rather than removing it if we think it has value. | 14:29 |
| zaneb | looking at that patch I just linked, it appears it was working again as recently as November. I didn't notice that before, I wish we'd just merged it then | 14:30 |
| bshephar | Interesting yeah. If we use the transport_url from the config file, it makes it passed that error Rabi mentioned, and the traceback from my story. I'll keep unpicking that puzzle and see how much further I can get. | 14:33 |
| bshephar | That sqlalchemy issue zuul picked up there seems like it could be more of a problem atm. Last successful run I can see was on SQLAlchemy 1.3.23. That latest one seems to be pulling in 1.4.15 and having issues. | 14:41 |
| *** ysandeep|brb is now known as ysandeep | 15:08 | |
| *** ysandeep is now known as ysandeep|dinner | 15:29 | |
| *** hjensas is now known as hjensas|afk | 15:50 | |
| *** ysandeep|dinner is now known as ysandeep | 16:33 | |
| *** ysandeep is now known as ysandeep|out | 16:36 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!