| bshephar | Hey ricolin and ramishra: When you guys have some time, just looking for any additional feedback on: https://review.opendev.org/c/openstack/heat/+/795023 | 05:25 |
|---|---|---|
| ramishra | bshephar: I think I had looked at it last week, qq, why we so we need to worry about keys not in properties or extra_properties L334/L335? | 05:29 |
| bshephar | It is a good question, pretty sure there was a reason I needed to do it twice because of the upper level for loop. But let me double check right now | 05:34 |
| ramishra | I think we should worry about keys in the resource and ignore the rest.. which would make it simple | 05:35 |
| bshephar | Yeah, I'll change that now and make sure it still does the expected. | 05:35 |
| bshephar | I think the other question you asked was why I can't just update image_reality directly. That was because it's a nested dictionary, so if I do that I only end up with one item in it each loop. | 05:36 |
| bshephar | I think I left it there just because I needed a test for the elif to evaluate to match what we're looking for. For the previous two we look for location and image. Then for this one, we want to capture keys that aren't in the list, if they aren't in the list then we check the resource_data for them. | 05:41 |
| bshephar | I could probably remove L335 | 05:42 |
| opendevreview | Brendan Shephard proposed openstack/heat master: Allow arbitrary image properties https://review.opendev.org/c/openstack/heat/+/795023 | 06:16 |
| bshephar | ramishra: ^ Still needs to evaluate the key to see if it's included in the glance_def_keys. If it's not in the list, then it's a key that is relevant to our extra_properties, so we begin a new for loop to create our extra_properties dict. Added a comment there as well since it's starting to get confusing | 06:18 |
| *** ChanServ changes topic to "OpenStack Heat (Logs: http://eavesdrop.openstack.org/irclogs/%23heat/)" | 22:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!